Re: [RFC][PATCH] HACK: usb: dwc2: Workaround case where GOTGCTL state is wrong

2016-12-08 Thread Chen Yu
e USB-A host >> ports on the board are wired up. As removing the usb-b plug seems to >> switch the device back into A mode. >> >> One quirk with this board is that the USB-A ports on the board do not >> function if anything is in the OTG/B plug (which is frustrating t

Re: [RFC][PATCH] HACK: usb: dwc2: Workaround case where GOTGCTL state is wrong

2016-12-09 Thread Chen Yu
On 2016/12/9 15:32, John Stultz wrote: > On Thu, Dec 8, 2016 at 11:09 PM, Chen Yu wrote: >> On 2016/12/9 7:29, John Youn wrote: >>> On 12/8/2016 2:43 PM, John Stultz wrote: >>>> On Tue, Dec 6, 2016 at 7:52 PM, John Youn wrote: >>>>> On 12/6/2016

[yu.c.c...@intel.com: Re: [RFC] Why ax88772a_hw_reset sleeps for 200ms? Can we reduce the value?]

2016-12-12 Thread Chen Yu
+usb mailist. On 2016年12月12日 11:56, Chen Yu wrote: > Hi guys, > Currently I'm experiencing long time latency of resuming > from S3 on my MacBookPro 2015, according to the log of ftrace, > one of the suspicious time consumers is ax88772a_hw_reset has an > explicit msleep of 2

BUG: scheduling while atomic in f_fs when gadget remove driver

2016-09-27 Thread Chen Yu
e (--count); } Should the epfile->read_buffer be cleared another place and the mutex_lock can be removed in ffs_func_eps_disable? Thanks and Regards Chen Yu -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: BUG: scheduling while atomic in f_fs when gadget remove driver

2016-09-28 Thread Chen Yu
Hi, 在 2016/9/27 18:01, Felipe Balbi 写道: > > Hi, > > Chen Yu writes: >> Hi All, >> >> I'm working on Hikey board based around the HiSilicon Kirin 620, with >> linaro kernel version 4.8.rc1 and I get below BUG error while >> extracting USB cable

Re: BUG: scheduling while atomic in f_fs when gadget remove driver

2016-09-29 Thread Chen Yu
ith adb function on android, it does fix the problem. thanks Chen Yu > >8 -- - >>From 6416a1065203a39328311f6c58083089efe169aa Mon Sep 17 00:00:00 2001 > From: Michal Nazarewicz > Date: Wed, 28 Sep 2016 23:36:56 +

Re: [PATCH 2/2] usb: gadget: f_fs: stop sleeping in ffs_func_eps_disable

2016-10-08 Thread Chen Yu
On 2016/10/4 8:07, Michal Nazarewicz wrote: > ffs_func_eps_disable is called from atomic context so it cannot sleep > thus cannot grab a mutex. Change the handling of epfile->read_buffer > to use non-sleeping synchronisation method. > > Reported-by: Chen Yu > Signed-off-

Re: [RFC][PATCH 2/2] usb: dwc2: Add a quirk to allow speed negotiation for Hisilicon Hi6220

2016-10-16 Thread Chen Yu
On 2016/10/15 3:37, John Youn wrote: > On 10/13/2016 4:36 PM, John Stultz wrote: >> From: Chen Yu >> >> The Hi6220's usb controller is limited in that it does not >> automatically autonegotiate the usb speed. Thus it requires a >> quirk so that we can man

Re: [RFC][PATCH 2/2] usb: dwc2: Add a quirk to allow speed negotiation for Hisilicon Hi6220

2016-10-20 Thread Chen Yu
On 2016/10/19 6:21, John Youn wrote: > On 10/16/2016 7:42 PM, Chen Yu wrote: >> >> >> On 2016/10/15 3:37, John Youn wrote: >>> On 10/13/2016 4:36 PM, John Stultz wrote: >>>> From: Chen Yu >>>> >>>> The Hi6220's usb controller

Re: [RFC][PATCH 2/2] usb: dwc2: Add a quirk to allow speed negotiation for Hisilicon Hi6220

2016-10-21 Thread Chen Yu
On 2016/10/22 4:00, John Youn wrote: > On 10/20/2016 5:43 PM, Chen Yu wrote: >> On 2016/10/19 6:21, John Youn wrote: >>> On 10/16/2016 7:42 PM, Chen Yu wrote: >>>> >>>> >>>> On 2016/10/15 3:37, John Youn wrote: >>>>> On 10/13/201

Re: [RFC 2/3] USB: dwc3: Modify dwc3 code for support usb of Hikey960

2017-10-24 Thread Chen Yu
Hi, Felipe On 2017/10/24 16:25, Felipe Balbi wrote: > Hi, > > Yu Chen writes: >> > The usb controller of Kirin960 is DesignWare Cores SuperSpeed USB 3.0 >> > Controller. >> > The patch modifies dwc3 for support Kirin960 and adds codes for a USB Hub >> > on board Hikey960. >> > >> > Signed-of

Re: [PATCH] usb:xhci fix panic in xhci_free_virt_devices_depth_first

2017-11-06 Thread Chen Yu
On 2017/11/6 15:59, Greg KH wrote: >> >> diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c >> index 2a82c927ded2..295789d993b0 100644 >> --- a/drivers/usb/host/xhci-mem.c >> +++ b/drivers/usb/host/xhci-mem.c >> @@ -947,6 +947,11 @@ void xhci_free_virt_devices_depth_first(stru

Re: [PATCH v2] usb:xhci fix panic in xhci_free_virt_devices_depth_first

2017-11-06 Thread Chen Yu
Hi, On 2017/11/6 16:31, Greg KH wrote: > On Mon, Nov 06, 2017 at 04:20:23PM +0800, Yu Chen wrote: >> From: Yu Chen >> >> Check vdev->real_port 0 to avoid panic >> [9.261347] [] >> xhci_free_virt_devices_depth_first+0x58/0x108 >> [9.261352] [] xhci_mem_cleanup+0x1bc/0x570 >> [9.261355

Re: [PATCH v2] usb:xhci fix panic in xhci_free_virt_devices_depth_first

2017-11-06 Thread Chen Yu
On 2017/11/6 19:32, Greg KH wrote: >> A simple process is as below: >> xhci_plat_probe() >>| >> usb_add_hcd() xhci_plat_remove() >> || >> find some device

Re: [PATCH v2] usb:xhci fix panic in xhci_free_virt_devices_depth_first

2017-11-06 Thread Chen Yu
On 2017/11/6 22:00, Mathias Nyman wrote: > On 06.11.2017 14:36, Chen Yu wrote: >> >> >> On 2017/11/6 19:32, Greg KH wrote: >>>> A simple process is as below: >>>> xhci_plat_probe() >>>> | &

Re: Regression: asix: BISECTED suspend crash - Dell XPS13-9360

2017-04-23 Thread Chen Yu
Hi Freddy, Robert, David, Any clue here? Seems to broken here: static int asix_suspend(struct usb_interface *intf, pm_message_t message) { struct usbnet *dev = usb_get_intfdata(intf); struct asix_common_private *priv = dev->driver_priv; if (priv->suspend) //priv is NULL th

Re: [RFC PATCH 1/1] usb: dwc3: drd: Register a USB role switch

2018-10-30 Thread Chen Yu
y: Heikki Krogerus > --- > Hi Chen Yu, > > This is related to your Hikey960 USB patches series [1]. I can't test > this patch, but I don't think this part should require anything else. > > And about the device graph you'll need for this and the other > compo

Re: [PATCH 08/10] usb: typec: Add support for usb role switch in rt1711h driver

2018-10-29 Thread Chen Yu
On 2018/10/29 19:58, Heikki Krogerus wrote: > On Sat, Oct 27, 2018 at 05:58:18PM +0800, Yu Chen wrote: >> This patch add struct device_connection to rt1711h driver to support >> find "usb-role-switch" in tcpm_register_port. >> >> Cc: Heikki Krogerus >> Cc: Greg Kroah-Hartman >> Cc: Lucas Tsai

Re: [PATCH 03/10] dt-bindings: misc: Add bindings for HiSilicon usb hub and data role switch functionality on HiKey960

2018-10-29 Thread Chen Yu
On 2018/10/28 2:06, Sergei Shtylyov wrote: > On 27.10.2018 12:58, Yu Chen wrote: > >> This patch adds binding documentation to support usb hub and usb >> data role switch of Hisilicon HiKey&HiKey960 Board. >> >> Cc: Rob Herring >> Cc: Mark Rutland >> Cc: John Stultz >> Cc: Binghui Wang >> Si

Re: [PATCH 07/10] hikey960: Support usb functionality of Hikey960

2018-10-29 Thread Chen Yu
Hi On 2018/10/29 22:30, Heikki Krogerus wrote: > Hi, > > On Sat, Oct 27, 2018 at 05:58:17PM +0800, Yu Chen wrote: >> This driver handles usb hub power on and typeC port event of HiKey960 board: >> 1)DP&DM switching between usb hub and typeC port base on typeC port >> state > By "hub" do you mean

Re: [PATCH 01/10] dt-bindings: usb: add support for dwc3 controller on HiSilicon SoCs

2018-11-16 Thread Chen Yu
Hi, On 2018/11/13 0:02, Rob Herring wrote: > On Sat, Oct 27, 2018 at 05:58:11PM +0800, Yu Chen wrote: >> This patch adds binding descriptions to support the dwc3 controller >> on HiSilicon SoCs and boards like the HiKey960. >> >> Cc: Greg Kroah-Hartman >> Cc: Rob Herring >> Cc: Mark Rutland >>

Re: [PATCH v1 05/12] usb: dwc3: Add two quirks for Hisilicon Kirin Soc Platform

2018-12-03 Thread Chen Yu
On 2018/12/3 16:02, Andy Shevchenko wrote: > On Mon, Dec 3, 2018 at 5:48 AM Yu Chen wrote: >> >> There are tow quirks for DesignWare USB3 DRD Core of Hisilicon Kirin Soc. >> 1)SPLIT_BOUNDARY_DISABLE should be set for Host mode >> 2)A GCTL soft reset should be executed when switch mode > >> +st

Re: [PATCH v1 04/12] usb: dwc3: dwc3-hisi: Add code for dwc3 of Hisilicon Soc Platform

2018-12-03 Thread Chen Yu
ce here, but you can just use > __maybe_unused and remove this #ifdef. > >> +{ >> + struct dwc3_hisi *dwc3_hisi = dev_get_drvdata(dev); >> + int ret; >> + > >> + dev_info(dev, "%s\n", __func__); > > Noise > >> +} > >> +static int dwc3_hisi_resume(struct device *dev) > > __maybe_unused ? > >> +{ > >> + dev_info(dev, "%s\n", __func__); > > Noise. > >> + /* Wait for clock stable */ >> + msleep(100); > > Don't you have any hardware notification that clocks are stable? > (Something like PLL locked?) > >> + >> + return 0; >> +} >> +#endif /* CONFIG_PM_SLEEP */ > >> +static const struct of_device_id dwc3_hisi_match[] = { >> + { .compatible = "hisilicon,hi3660-dwc3" }, >> + { /* sentinel */ }, > > No need comma for terminator line. > >> +}; > Thanks a lot for your advice! I will check and fix the patch. Chen Yu

Re: [PATCH v1 01/12] dt-bindings: usb: add support for dwc3 controller on HiSilicon SoCs

2018-12-03 Thread Chen Yu
Hi, On 2018/12/3 16:35, Sergei Shtylyov wrote: > Hello! > > On 03.12.2018 6:45, Yu Chen wrote: > >> This patch adds binding descriptions to support the dwc3 controller >> on HiSilicon SoCs and boards like the HiKey960. >> >> Cc: Greg Kroah-Hartman >> Cc: Rob Herring >> Cc: Mark Rutland >> Cc:

Re: [PATCH v1 01/12] dt-bindings: usb: add support for dwc3 controller on HiSilicon SoCs

2018-12-03 Thread Chen Yu
Hi, On 2018/12/3 16:59, Sergei Shtylyov wrote: > On 03.12.2018 11:51, Chen Yu wrote: > >>>> This patch adds binding descriptions to support the dwc3 controller >>>> on HiSilicon SoCs and boards like the HiKey960. >>>> >>>> Cc: Greg Kroa

Re: [PATCH v1 09/12] usb: dwc3: Registering a role switch in the DRD code.

2018-12-03 Thread Chen Yu
latforms with >> USB Type-C connectors. > >> + pr_info("%s:set role %d\n", __func__, role); > > Noise! > >> + return role; >> + > > Redundant blank line. > >> +} > OK. Thanks! Chen Yu

Re: [PATCH 01/10] dt-bindings: usb: add support for dwc3 controller on HiSilicon SoCs

2018-12-03 Thread Chen Yu
On 2018/12/4 0:01, Rob Herring wrote: > On Fri, Nov 16, 2018 at 8:29 PM Chen Yu wrote: >> >> Hi, >> >> On 2018/11/13 0:02, Rob Herring wrote: >>> On Sat, Oct 27, 2018 at 05:58:11PM +0800, Yu Chen wrote: >>>> This patch adds binding descriptions

Re: [PATCH v1 08/12] usb: roles: Add usb role switch notifier.

2018-12-03 Thread Chen Yu
On 2018/12/3 20:38, Heikki Krogerus wrote: > On Mon, Dec 03, 2018 at 11:45:11AM +0800, Yu Chen wrote: >> This patch adds notifier for drivers want to be informed of the usb role >> switch. > > I think in this case it would be good to explain a little for what we > need the notifier for. > >>

Re: [PATCH v1 11/12] usb: gadget: Add configfs attribuite for controling match_existing_only

2018-12-03 Thread Chen Yu
On 2018/12/3 17:25, Andy Shevchenko wrote: > On Mon, Dec 3, 2018 at 5:47 AM Yu Chen wrote: >> >> Currently the "match_existing_only" of usb_gadget_driver in configfs is >> set to one which is not flexible. >> Dwc3 udc will be removed when usb core switch to host mode. This causes >> failure of

Re: [PATCH v1 10/12] hikey960: Support usb functionality of Hikey960

2018-12-03 Thread Chen Yu
Hi, On 2018/12/3 17:23, Andy Shevchenko wrote: > On Mon, Dec 3, 2018 at 5:47 AM Yu Chen wrote: >> >> This driver handles usb hub power on and typeC port event of HiKey960 board: >> 1)DP&DM switching between usb hub and typeC port base on typeC port >> state >> 2)Control power of usb hub on Hikey9

Re: [PATCH v1 09/12] usb: dwc3: Registering a role switch in the DRD code.

2018-12-04 Thread Chen Yu
On 2018/12/4 18:54, Heikki Krogerus wrote: > On Mon, Dec 03, 2018 at 11:45:12AM +0800, Yu Chen wrote: >> The Type-C drivers use USB role switch API to inform the >> system about the negotiated data role, so registering a role >> switch in the DRD code in order to support platforms with >> USB Ty

Re: [PATCH v1 10/12] hikey960: Support usb functionality of Hikey960

2018-12-04 Thread Chen Yu
Hi, On 2018/12/5 1:47, Andy Shevchenko wrote: > On Tue, Dec 4, 2018 at 3:40 AM Chen Yu wrote: >> On 2018/12/3 17:23, Andy Shevchenko wrote: >>> On Mon, Dec 3, 2018 at 5:47 AM Yu Chen wrote: > >>>> + .of_match_table = of_match_ptr(id_table_hisi_hik

Re: [PATCH 01/10] dt-bindings: usb: add support for dwc3 controller on HiSilicon SoCs

2018-12-14 Thread Chen Yu
Hi, On 2018/12/4 0:01, Rob Herring wrote: > On Fri, Nov 16, 2018 at 8:29 PM Chen Yu wrote: >> >> Hi, >> >> On 2018/11/13 0:02, Rob Herring wrote: >>> On Sat, Oct 27, 2018 at 05:58:11PM +0800, Yu Chen wrote: >>>> This patch adds binding des

Re: [PATCH v1 01/12] dt-bindings: usb: add support for dwc3 controller on HiSilicon SoCs

2018-12-19 Thread Chen Yu
Hi, On 2018/12/19 22:09, Rob Herring wrote: > On Mon, Dec 03, 2018 at 05:28:56PM +0800, Chen Yu wrote: >> Hi, >> >> On 2018/12/3 16:59, Sergei Shtylyov wrote: >>> On 03.12.2018 11:51, Chen Yu wrote: >>> >>>>>> This patch adds binding descri

Re: [PATCH v1 02/12] dt-bindings: phy: Add support for HiSilicon's hi3660 USB PHY

2018-12-19 Thread Chen Yu
Hi, On 2018/12/19 22:14, Rob Herring wrote: > On Mon, Dec 03, 2018 at 11:45:05AM +0800, Yu Chen wrote: >> This patch adds binding documentation for supporting the hi3660 usb >> phy on boards like the HiKey960. >> >> Cc: Rob Herring >> Cc: Mark Rutland >> Cc: John Stultz >> Cc: Binghui Wang >>

Re: [PATCH v1 03/12] dt-bindings: misc: Add bindings for HiSilicon usb hub and data role switch functionality on HiKey960

2018-12-19 Thread Chen Yu
On 2018/12/19 22:21, Rob Herring wrote: > On Mon, Dec 03, 2018 at 11:45:06AM +0800, Yu Chen wrote: >> This patch adds binding documentation to support usb hub and usb >> data role switch of Hisilicon HiKey&HiKey960 Board. >> >> Cc: Sergei Shtylyov >> Cc: Rob Herring >> Cc: Mark Rutland >> Cc:

Re: [PATCH v1 07/12] usb: roles: Find the usb role switch by also matching against the device node

2019-01-21 Thread Chen Yu
Hi Heikki, On 2018/12/3 20:25, Heikki Krogerus wrote: > Hi, > > On Mon, Dec 03, 2018 at 10:17:20AM +0200, Andy Shevchenko wrote: >> On Mon, Dec 3, 2018 at 5:45 AM Yu Chen wrote: >>> >>> This patch adds code for supporting find usb role switch by matching against >>> the device node described usi

Re: [PATCH v2 04/10] usb: dwc3: Add two quirks for Hisilicon Kirin Soc Platform

2019-02-18 Thread Chen Yu
Hi, On 2019/2/18 20:21, Andy Shevchenko wrote: > On Mon, Feb 18, 2019 at 1:23 PM Yu Chen wrote: >> >> There are tow quirks for DesignWare USB3 DRD Core of Hisilicon Kirin Soc. >> 1)SPLIT_BOUNDARY_DISABLE should be set for Host mode >> 2)A GCTL soft reset should be executed when switch mode > > T

Re: [PATCH v2 00/10] Add support for usb on Hikey960

2019-02-18 Thread Chen Yu
Hi, On 2019/2/19 1:30, Valentin Schneider wrote: > Hi, > > On 18/02/2019 11:23, Yu Chen wrote: >> The patchset adds support for usb functionality of Hikey960, includes: >> - dwc3 driver for Hisilicon Kirin Soc hi3660 >> - usb driver for HiKey960 board >> - some adjustment in dwc3, usb gadget and

Re: [PATCH v2 07/10] usb: dwc3: Registering a role switch in the DRD code.

2019-02-18 Thread Chen Yu
Hi, On 2019/2/19 1:30, Valentin Schneider wrote: > Hi, > > On 18/02/2019 11:23, Yu Chen wrote: > [...] >> @@ -522,6 +556,15 @@ int dwc3_drd_init(struct dwc3 *dwc) >> dwc3_set_mode(dwc, DWC3_GCTL_PRTCAP_OTG); >> } >> >> +dwc3_role_switch.fwnode = dev_fwnode(dwc->dev); >> +

Re: [PATCH v2 01/10] dt-bindings: phy: Add support for HiSilicon's hi3660 USB PHY

2019-02-18 Thread Chen Yu
Hi, On 2019/2/19 4:18, Rob Herring wrote: > On Mon, Feb 18, 2019 at 07:23:01PM +0800, Yu Chen wrote: >> This patch adds binding documentation for supporting the hi3660 usb >> phy on boards like the HiKey960. >> >> Cc: Rob Herring >> Cc: Mark Rutland >> Cc: John Stultz >> Cc: Binghui Wang >> Si

Re: [PATCH v2 08/10] hikey960: Support usb functionality of Hikey960

2019-02-18 Thread Chen Yu
Hi, On 2019/2/19 10:50, Chunfeng Yun wrote: >> +if (ret) >> +hisi_hikey_usb->typec_vbus_enable_val = 1; >> + >> +hisi_hikey_usb->typec_vbus = devm_gpiod_get(dev, "typec-vbus", >> +hisi_hikey_usb->typec_vbus_enable_val ? >> +GPIOD_OUT_LOW

Re: [PATCH v2 07/10] usb: dwc3: Registering a role switch in the DRD code.

2019-02-18 Thread Chen Yu
Hi, On 2019/2/19 10:57, Jun Li wrote: >> >> +static int dwc3_usb_role_switch_set(struct device *dev, enum usb_role role) >> +{ >> + u32 mode; >> + >> + switch (role) { >> + case USB_ROLE_HOST: >> + mode = DWC3_GCTL_PRTCAP_HOST; >> + break; >> + c

Re: [PATCH v2 01/10] dt-bindings: phy: Add support for HiSilicon's hi3660 USB PHY

2019-02-18 Thread Chen Yu
Hi, On 2019/2/19 11:03, Chunfeng Yun wrote: + +Example: + usb-phy { + compatible = "hisilicon,hi3660-usb-phy"; + #phy-cells = <0>; + hisilicon,pericrg-syscon = <&crg_ctrl>; + hisilicon,pctrl-syscon = <&pctrl>; +

Re: [PATCH v2 02/10] dt-bindings: misc: Add bindings for HiSilicon usb hub and data role switch functionality on HiKey960

2019-02-19 Thread Chen Yu
Hi, On 2019/2/19 16:25, Sergei Shtylyov wrote: > Hello! > > On 18.02.2019 14:23, Yu Chen wrote: > >> This patch adds binding documentation to support usb hub and usb >> data role switch of Hisilicon HiKey960 Board. >> >> Cc: Sergei Shtylyov >> Cc: Rob Herring >> Cc: Mark Rutland >> Cc: John S

Re: [PATCH v2 08/10] hikey960: Support usb functionality of Hikey960

2019-03-01 Thread Chen Yu
Hi Chunfeng Yun, On 2019/2/22 15:32, Chunfeng Yun wrote: > On Tue, 2019-02-19 at 11:20 +0800, Chen Yu wrote: >> Hi, >> >> On 2019/2/19 10:50, Chunfeng Yun wrote: >>>> + if (ret) >>>> + hisi_hikey_usb->typec_vbus_enable_val = 1; >>&g

Re: [PATCH v3 10/12] hikey960: Support usb functionality of Hikey960

2019-03-03 Thread Chen Yu
On 2019/3/4 4:17, John Stultz wrote: > On Sat, Mar 2, 2019 at 4:05 AM Yu Chen wrote: >> +static int hisi_hikey_usb_probe(struct platform_device *pdev) >> +{ >> + struct device *dev = &pdev->dev; >> + struct device_node *root = dev->of_node; > > Minor nit: root is unused and generat

Re: [PATCH v3 10/12] hikey960: Support usb functionality of Hikey960

2019-03-03 Thread Chen Yu
Hi Chunfeng Yun, On 2019/3/4 9:47, Chunfeng Yun wrote: >> + >> +hisi_hikey_usb->role_sw = usb_role_switch_get(dev); >> +if (!hisi_hikey_usb->role_sw) >> +return -EPROBE_DEFER; > Here return EPROBE_DEFFER means the related device_connection is > registered after this probe is c

Re: [PATCH v3 10/12] hikey960: Support usb functionality of Hikey960

2019-03-03 Thread Chen Yu
Hi Andy, On 2019/3/3 0:01, Andy Shevchenko wrote: > On Sat, Mar 2, 2019 at 11:05 AM Yu Chen wrote: >> >> This driver handles usb hub power on and typeC port event of HiKey960 board: >> 1)DP&DM switching between usb hub and typeC port base on typeC port >> state >> 2)Control power of usb hub on Hi

Re: [PATCH v3 07/12] phy: Add usb phy support for hi3660 Soc of Hisilicon

2019-03-03 Thread Chen Yu
Hi Andy, On 2019/3/2 23:56, Andy Shevchenko wrote: > On Sat, Mar 2, 2019 at 11:06 AM Yu Chen wrote: >> >> This driver handles usb phy power on and shutdown for hi3660 Soc of >> Hisilicon. > > Few comments below. After fixing them, FWIW > Reviewed-by: Andy Shevchenko > >> +#define HI3660_USB_DE

//Re: [PATCH v3 06/12] usb: dwc3: Increase timeout for CmdAct cleared by device controller

2019-03-03 Thread Chen Yu
Hi Zhang Fei, On 2019/3/2 23:47, Andy Shevchenko wrote: > On Sat, Mar 2, 2019 at 11:06 AM Yu Chen wrote: >> >> It needs more time for the device controller to clear the CmdAct of >> DEPCMD on Hisilicon Kirin Soc. >> > > 5x times more? Can you provide more specific details on that? > Can you exp

Re: [PATCH v3 10/12] hikey960: Support usb functionality of Hikey960

2019-03-03 Thread Chen Yu
Hi, On 2019/3/4 14:55, Andy Shevchenko wrote: > On Mon, Mar 4, 2019 at 4:35 AM Chen Yu wrote: >> On 2019/3/3 0:01, Andy Shevchenko wrote: >>> On Sat, Mar 2, 2019 at 11:05 AM Yu Chen wrote: > >>>> +config HISI_HIKEY_USB >>>> + tristate &

Re: [PATCH v3 06/12] power: pwrseq: simple: Add support for regulator and generic property

2016-06-08 Thread Chen-Yu Tsai
Hi On Thu, Jun 9, 2016 at 3:03 AM, Rob Herring wrote: > On Tue, Jun 07, 2016 at 11:29:02AM +0200, Krzysztof Kozlowski wrote: >> On 06/03/2016 04:02 AM, Rob Herring wrote: >> >> Optional properties: >> >> - reset-gpios : contains a list of GPIO specifiers. The reset GPIOs are >> >> asserted >>

Re: [PATCH 08/12] doc: binding: pwrseq-usb-generic: add binding doc for generic usb power sequence driver

2016-06-20 Thread Chen-Yu Tsai
Hi, On Mon, Jun 20, 2016 at 7:26 PM, Peter Chen wrote: > On Fri, Jun 17, 2016 at 12:16:48PM -0500, Rob Herring wrote: >> On Fri, Jun 17, 2016 at 5:09 AM, Peter Chen wrote: >> > Add binding doc for generic usb power sequence driver, and update >> > generic usb device binding-doc accordingly. >> >

Re: [PATCH 1/4] phy: sun4i-usb: support PHY0 on H3 in MUSB mode

2017-01-17 Thread Chen-Yu Tsai
Hi, On Wed, Jan 18, 2017 at 4:06 AM, Maxime Ripard wrote: > On Wed, Jan 18, 2017 at 12:57:08AM +0800, Icenowy Zheng wrote: >> >> >> 17.01.2017, 16:06, "Maxime Ripard" : >> > On Tue, Jan 17, 2017 at 03:14:46AM +0800, Icenowy Zheng wrote: >> >> The PHY0 on H3 can be wired either to MUSB controller

Re: [PATCH v5 02/23] of: device: Export of_device_{get_modalias, uvent_modalias} to modules

2016-10-17 Thread Chen-Yu Tsai
On Tue, Oct 18, 2016 at 9:56 AM, Stephen Boyd wrote: > The ULPI bus can be built as a module, and it will soon be > calling these functions when it supports probing devices from DT. > Export them so they can be used by the ULPI module. > > Acked-by: Rob Herring > Cc: > Signed-off-by: Stephen Boy

Re: [PATCH v5 02/23] of: device: Export of_device_{get_modalias, uvent_modalias} to modules

2016-10-24 Thread Chen-Yu Tsai
Hi, On Tue, Oct 18, 2016 at 9:56 AM, Stephen Boyd wrote: > The ULPI bus can be built as a module, and it will soon be > calling these functions when it supports probing devices from DT. > Export them so they can be used by the ULPI module. > > Acked-by: Rob Herring > Cc: > Signed-off-by: Stephe

Re: [PATCH v5 02/23] of: device: Export of_device_{get_modalias, uvent_modalias} to modules

2016-11-06 Thread Chen-Yu Tsai
On Mon, Nov 7, 2016 at 9:29 AM, Peter Chen wrote: > On Fri, Nov 04, 2016 at 01:51:34PM -0700, Stephen Boyd wrote: >> Quoting Peter Chen (2016-10-24 18:16:32) >> > On Mon, Oct 24, 2016 at 12:48:24PM -0700, Stephen Boyd wrote: >> > > Quoting Chen-Yu Tsai (20

Re: [PATCH v5 02/23] of: device: Export of_device_{get_modalias, uvent_modalias} to modules

2016-11-10 Thread Chen-Yu Tsai
On Fri, Nov 11, 2016 at 5:42 AM, Rob Herring wrote: > On Sun, Nov 6, 2016 at 7:56 PM, Chen-Yu Tsai wrote: >> On Mon, Nov 7, 2016 at 9:29 AM, Peter Chen wrote: >>> On Fri, Nov 04, 2016 at 01:51:34PM -0700, Stephen Boyd wrote: >>>> Quoting Peter Chen (2016-10-24 1

Re: [PATCH 2/3] phy: sun4i: add support for A64 usb phy

2016-07-31 Thread Chen-Yu Tsai
Hi, On Sun, Jul 31, 2016 at 10:39 PM, Hans de Goede wrote: > Hi, > > On 31-07-16 13:25, Icenowy Zheng wrote: >> >> There's something unknown in the pmu part. >> >> Signed-off-by: Icenowy Zheng > > > Cool, I really like the work you're doing on A64 support, > keep up the good work! > >> --- >> d

Re: [linux-sunxi] Re: [PATCH] ARM: sunxi: Add driver for sunxi usb phy

2014-01-15 Thread Chen-Yu Tsai
Hi Hans, On Wed, Jan 15, 2014 at 11:48 PM, Hans de Goede wrote: > Hi, > > > On 01/15/2014 04:00 PM, Kishon Vijay Abraham I wrote: >> >> On Wednesday 15 January 2014 04:28 AM, Hans de Goede wrote: [...] >>> +static int sun4i_usb_phy_init(struct phy *_phy) >>> +{ >>> + struct sun4i_usb_phy *p

Re: [linux-sunxi] [PATCH v2 3/7] phy: usb: sunxi: Introduce Allwinner A31 USB PHY support

2014-05-12 Thread Chen-Yu Tsai
Hi, On Sat, May 10, 2014 at 8:56 PM, Maxime Ripard wrote: > The USB phy controller in the A31 differs mostly from the older controllers > because it has a clock dedicated for each phy, while the older ones were > having > a single clock for all the phys. > > Signed-off-by: Maxime Ripard > Revie

Re: [PATCH v2 06/13] musb: Add support for the Allwinner sunxi musb controller

2015-03-20 Thread Chen-Yu Tsai
Hi, On Sat, Mar 21, 2015 at 3:11 AM, Hans de Goede wrote: > This is based on initial code to get the Allwinner sunxi musb controller > supported by Chen-Yu Tsai and Roman Byshko. > > This adds support for the Allwinner sunxi musb controller in both host only > and otg mode. Perip

Re: [linux-sunxi] [PATCH 1/5] clk: sunxi: Add support for the H3 usb phy clocks

2015-11-15 Thread Chen-Yu Tsai
be done with it. > > Signed-off-by: Reinder de Haan > Signed-off-by: Hans de Goede Acked-by: Chen-Yu Tsai > --- > Documentation/devicetree/bindings/clock/sunxi.txt | 1 + > drivers/clk/sunxi/clk-usb.c | 12 > 2 files changed, 13 insertio

Re: [linux-sunxi] [PATCH 3/5] ARM: dts: sun8i: Add support for H3 usb clocks

2015-11-15 Thread Chen-Yu Tsai
On Mon, Nov 16, 2015 at 3:46 AM, Hans de Goede wrote: > From: Reinder de Haan > > Add a node describing the usb-clks found on the H3. > > Signed-off-by: Reinder de Haan > Signed-off-by: Hans de Goede Acked-by: Chen-Yu Tsai (Also updated Mike's email in my reply.) >

Re: [linux-sunxi] [PATCH 5/5] ARM: dts: sun8i-h3-orangepi-plus: Enable USB host controllers

2015-11-15 Thread Chen-Yu Tsai
Hi, On Mon, Nov 16, 2015 at 3:46 AM, Hans de Goede wrote: > From: Reinder de Haan > > Enable the 3 pairs of USB host controllers used on the Orange Pi Plus. > > Signed-off-by: Reinder de Haan > Signed-off-by: Hans de Goede > --- > arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts | 28 > +

Re: [linux-sunxi] Re: [PATCH 2/2] ehci-platform: Add support for controllers with multiple reset lines

2015-11-16 Thread Chen-Yu Tsai
On Mon, Nov 16, 2015 at 11:42 PM, Alan Stern wrote: > On Sun, 15 Nov 2015, Hans de Goede wrote: > >> From: Reinder de Haan >> >> At least the EHCI found on the Allwinnner H3 SoC needs multiple reset >> lines, the controller will not initialize while the reset for its >> companion OHCI is still as

Re: [PATCH v3 1/2] phy-sun4i-usb: Use of_match_node to get model specific config data

2015-11-25 Thread Chen-Yu Tsai
On Thu, Nov 26, 2015 at 12:50 AM, Hans de Goede wrote: > Use of_match_node instead of calling of_device_is_compatible a ton of > times to get model specific config data. > > Signed-off-by: Hans de Goede > --- > Changes in v3: > -New patch in v3 of this patch-set > --- > drivers/phy/phy-sun4i-usb

Re: [PATCH 00/15] musb: Add support for the Allwinner sunxi musb controller

2015-03-09 Thread Chen-Yu Tsai
Hi Arnd, On Tue, Mar 10, 2015 at 5:44 AM, Arnd Bergmann wrote: > On Monday 09 March 2015 21:40:13 Hans de Goede wrote: >> Hi All, >> >> This patch set has been a while in the making, so I'm very happy to present >> the end result here, and I hope everyone likes it. > > Awesome work! > >> Before t

Re: [PATCH 6/6] arm64: dts: allwinner: Remove useless phy-names from EHCI and OHCI

2019-04-16 Thread Chen-Yu Tsai
On Tue, Apr 16, 2019 at 4:28 PM Maxime Ripard wrote: > > Neither the OHCI or EHCI bindings are using the phy-names property, so we > can just drop it. > > Signed-off-by: Maxime Ripard Acked-by: Chen-Yu Tsai for all the DT patches in this series.

Re: [PATCH] extcon: Split out extcon header file for consumer and provider device

2017-10-02 Thread Chen-Yu Tsai
Vijay Abraham I > Cc: Greg Kroah-Hartman > Cc: Sebastian Reichel > Cc: Lee Jones > Signed-off-by: Chanwoo Choi > --- For > drivers/extcon/extcon-axp288.c| 2 +- and > drivers/phy/allwinner/phy-sun4i-usb.c | 2 +- Acked-by: Chen-Yu Tsai -- To u