Re: [PATCH] extcon: Split out the extcon APIs for extcon provider driver

2016-11-29 Thread Charles Keepax
> Cc: Yoshihiro Shimoda > Cc: Kishon Vijay Abraham I > Cc: Maxime Ripard > Cc: Felipe Balbi > Cc: Greg Kroah-Hartman > Cc: Chris Zhong > Cc: Roger Quadros > Cc: Charles Keepax > Cc: patc...@opensource.wolfsonmicro.com > Cc: linux-renesas-...@vger.kernel.org >

[PATCH] USB: OHCI: Only use ohci_driver_overrides if they are defined

2013-10-15 Thread Charles Keepax
Overrides are optional and many drivers pass NULL, in this case don't process the overrides so we don't deference a NULL pointer. Signed-off-by: Charles Keepax --- drivers/usb/host/ohci-hcd.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/usb/host/

Re: [PATCH] USB: OHCI: Only use ohci_driver_overrides if they are defined

2013-10-15 Thread Charles Keepax
Apologies looks like I was on an earlier RC there and the users that did this have been removed. I assume this patch can be ignored sorry for the noise. Thanks, Charles -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org Mor

Arndale ethernet regression

2014-11-02 Thread Charles Keepax
Hi Guys, I have been having an issue with the ethernet on Arndale and it bisects down to this commit: commit 3cc81d85ee01e5a0b7ea2f4190e2ed1165f53c31 Author: Michel Stam asix: Don't reset PHY on if_up for ASIX 88772 I am afraid I am not overly familiar with the USB or networking subsystems. But

Re: "asix: Don't reset PHY on if_up for ASIX 88772" breaks net on arndale platform

2014-11-04 Thread Charles Keepax
On Tue, Nov 04, 2014 at 11:23:06AM +0100, Stam, Michel [FINT] wrote: > Hello Riku, > > >Fixing a bug (ethtool support) must not cause breakage elsewhere (in > this case on arndale). This is now a regression of functionality from > 3.17. > > > >I think it would better to revert the change now and w

Re: "asix: Don't reset PHY on if_up for ASIX 88772" breaks net onarndale platform

2014-11-05 Thread Charles Keepax
d of a call to > asix_mdio_read(). Can anyone comment on its purpose? Should it be a > shadow copy of the real register or something? > > Riku, can you test Charles' patch as well? > > Kind regards, > > Michel Stam > > -Original Message- > From: Charl

Re: "asix: Don't reset PHY on if_up for ASIX 88772" breaks net on arndale platform

2014-11-06 Thread Charles Keepax
On Thu, Nov 06, 2014 at 11:06:51AM +0200, Riku Voipio wrote: > On Wed, Nov 05, 2014 at 03:02:58PM +0000, Charles Keepax wrote: > > On Wed, Nov 05, 2014 at 01:04:37PM +0100, Stam, Michel [FINT] wrote: > > > Hello Charles, > > > > > > After looking around I fou

Re: "asix: Don't reset PHY on if_up for ASIX 88772" breaks net on arndale platform

2014-11-06 Thread Charles Keepax
On Thu, Nov 06, 2014 at 01:39:07PM +0100, Stam, Michel [FINT] wrote: > Hello Riku and Charles, > > I tried this with my original patch and the suggested patch applied, > this seems to work for me too. > > One thing that bothers me, is the suspend / resume situation; usbnet.c > seems to call the b

Re: "asix: Don't reset PHY on if_up for ASIX 88772" breaks net onarndale platform

2014-11-06 Thread Charles Keepax
On Thu, Nov 06, 2014 at 03:01:56PM +0100, Stam, Michel [FINT] wrote: > Hello Charles and Riku, > > I've quickly tested this on a 3.10 kernel i had around; > I enabled CONFIG_PM, CONFIG_PM_RUNTIME, CONFIG_PM_AUTOSLEEP, > CONFIG_SUSPEND, CONFIG_SUSPEND_FREEZER, CONFIG_FREEZER in the kernel (by > def

[PATCH] asix: Do full reset during ax88772_bind

2014-11-06 Thread Charles Keepax
g reset code in ax88772_bind which removes some code duplication and fixes the ethernet on Arndale. It is still possible that the original patch causes some issues with suspend and resume but that seems like a separate issue and I haven't had a chance to test that yet. Signed-off-by: Charles Kee

Re: [PATCH v3 3/3] power: wm831x_power: Support USB charger current limit management

2015-08-18 Thread Charles Keepax
rrent inputs without drawing more current than specified from others. > > Signed-off-by: Mark Brown > Signed-off-by: Baolin Wang > --- Acked-by: Charles Keepax Sorry if you guys got a bunch of bounces, we had a bit of an email fiasco at this end. Hopefully all fixed now. Thanks, C

Re: [PATCH] extcon: Split out extcon header file for consumer and provider device

2017-10-03 Thread Charles Keepax
Cc: Kishon Vijay Abraham I > Cc: Greg Kroah-Hartman > Cc: Sebastian Reichel > Cc: Lee Jones > Signed-off-by: Chanwoo Choi > --- > drivers/extcon/extcon-arizona.c | 2 +- Acked-by: Charles Keepax Thanks, Charles -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 3/3] power: wm831x_power: Support USB charger current limit management

2017-07-03 Thread Charles Keepax
On Mon, Jul 03, 2017 at 02:07:15PM +0800, Baolin Wang wrote: > Integrate with the newly added USB charger interface to limit the current > we draw from the USB input based on the input device configuration > identified by the USB stack, allowing us to charge more quickly from high > current inputs

Re: [PATCH v3 3/3] power: wm831x_power: Support USB charger current limit management

2017-07-25 Thread Charles Keepax
rrent inputs without drawing more current than specified from others. > > Signed-off-by: Mark Brown > Signed-off-by: Baolin Wang > --- Acked-by: Charles Keepax Thanks, Charles -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message