adros
Cc: Charles Keepax
Cc: patc...@opensource.wolfsonmicro.com
Cc: linux-renesas-...@vger.kernel.org
Cc: linux-arm-ker...@lists.infradead.org
Cc: linux-usb@vger.kernel.org
Signed-off-by: Chanwoo Choi
---
drivers/extcon/devres.c| 2 +-
drivers/extcon/extcon-adc-jack.c
This patch replaces the deprecated extcon API as following:
- extcon_set_cable_state_() -> extcon_set_state_sync()
Signed-off-by: Chanwoo Choi
---
drivers/phy/phy-rcar-gen3-usb2.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/phy/phy-rcar-gen3-usb2.
This patch uses the resource-managed extcon API for extcon_register_notifier()
and replaces the deprecated extcon API as following:
- extcon_get_cable_state_() -> extcon_get_state()
Signed-off-by: Chanwoo Choi
---
drivers/usb/chipidea/core.c | 30 ++
1 file chan
This patch just uses the resource-managed extcon API when registering
the extcon notifier.
Signed-off-by: Chanwoo Choi
---
drivers/usb/musb/sunxi.c | 12 +++-
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/drivers/usb/musb/sunxi.c b/drivers/usb/musb/sunxi.c
index
This patch replaces the deprecated extcon API as following:
- extcon_set_cable_state_() -> extcon_set_state_sync()
Signed-off-by: Chanwoo Choi
---
drivers/usb/phy/phy-tahvo.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/phy/phy-tahvo.c b/drivers/
This patch uses the resource-managed extcon API for extcon_register_notifier()
and replaces the deprecated extcon API as following:
- extcon_get_cable_state_() -> extcon_get_state()
Signed-off-by: Chanwoo Choi
---
drivers/power/supply/axp288_charger.c | 51 +--
This patch uses the resource-managed extcon API for extcon_register_notifier()
and replaces the deprecated extcon API as following:
- extcon_get_cable_state_() -> extcon_get_state()
Signed-off-by: Chanwoo Choi
---
drivers/usb/phy/phy-omap-otg.c | 24 ++--
1 file changed
This patch uses the resource-managed extcon API for extcon_register_notifier()
and replaces the deprecated extcon API as following:
- extcon_get_cable_state_() -> extcon_get_state()
Signed-off-by: Chanwoo Choi
---
drivers/usb/phy/phy-qcom-8x16-usb.c | 13 -
1 file changed
This patch replaces the deprecated extcon API as following:
- extcon_set_cable_state_() -> extcon_set_state_sync()
Signed-off-by: Chanwoo Choi
---
drivers/power/supply/qcom_smbb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/supply/qcom_smbb.c b/driv
This patch replaces the deprecated extcon API as following:
- extcon_get_cable_state_() -> extcon_get_state()
Signed-off-by: Chanwoo Choi
---
drivers/usb/renesas_usbhs/common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/renesas_usbhs/common.c
b/drivers/
te_() -> extcon_get_state();
The each patch has not any dependency among patches. So, each maintainer
could pick up each patch without any problem.
Chanwoo Choi (12):
phy: rcar-gen3-usb2: Replace the deprecated extcon API
phy: sun4i-usb: Replace the deprecated extcon API
power_supply: axp288_c
This patch uses the resource-managed extcon API for extcon_register_notifier()
and replaces the deprecated extcon API as following:
- extcon_get_cable_state_() -> extcon_get_state()
Signed-off-by: Chanwoo Choi
---
drivers/usb/phy/phy-msm-usb.c | 33 +++--
1 f
This patch uses the resource-managed extcon API for extcon_register_notifier()
and replaces the deprecated extcon API as following:
- extcon_get_cable_state_() -> extcon_get_state()
Signed-off-by: Chanwoo Choi
---
drivers/usb/dwc3/dwc3-omap.c | 20 +++-
1 file changed
This patch replaces the deprecated extcon API as following:
- extcon_set_cable_state_() -> extcon_set_state_sync()
Cc: Kishon Vijay Abraham I
Cc: Maxime Ripard
Cc: Chen-Yu Tsai
Signed-off-by: Chanwoo Choi
---
drivers/phy/phy-sun4i-usb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deleti
Hi Felipe,
On 2016년 11월 30일 19:36, Felipe Balbi wrote:
>
> Hi,
>
> Chanwoo Choi writes:
>> This patch uses the resource-managed extcon API for
>> extcon_register_notifier()
>> and replaces the deprecated extcon API as following:
>> - extcon_ge
Hi Felipe,
2016-12-02 18:03 GMT+09:00 Felipe Balbi :
>
> Hi,
>
> Chanwoo Choi writes:
>> Hi Felipe,
>>
>> On 2016년 11월 30일 19:36, Felipe Balbi wrote:
>>>
>>> Hi,
>>>
>>> Chanwoo Choi writes:
>>>> This patch uses
On 2016년 12월 06일 01:32, Bin Liu wrote:
> On Wed, Nov 30, 2016 at 09:45:03AM +0100, Maxime Ripard wrote:
>> On Wed, Nov 30, 2016 at 02:57:35PM +0900, Chanwoo Choi wrote:
>>> This patch just uses the resource-managed extcon API when registering
>>> the extcon notifier.
>
Hi Kishon,
Could you review and pick the patch1/2 for phy driver?
Best Regards,
Chanwoo Choi
On 2016년 11월 30일 14:57, Chanwoo Choi wrote:
> This patch replaces the deprecated extcon API as following:
> - extcon_set_cable_state_() -> extcon_set_state_sync()
>
> Signed-off-b
Hi Sebastian,
Could you please review and pick the patch3/4 for power-supply driver?
Best Regards,
Chanwoo Choi
On 2016년 11월 30일 14:57, Chanwoo Choi wrote:
> This patch uses the resource-managed extcon API for extcon_register_notifier()
> and replaces the deprecated extcon API as fol
Hi Sebastian,
On 2016년 12월 07일 12:05, Sebastian Reichel wrote:
> Hi Chanwoo,
>
> On Tue, Dec 06, 2016 at 09:26:14AM +0900, Chanwoo Choi wrote:
>> Could you please review and pick the patch3/4 for power-supply driver?
>
> Patches look fine. As I expect the merge windo
Best Regards,
Chanwoo Choi
On 2016년 12월 06일 17:06, John Stultz wrote:
> This patch wires up extcon support to the dwc2 driver
> so that devices that use a modern generic phy driver
> and don't use the usb-phy infrastructure can still
> signal connect/disconnect events.
>
>
Hi Felipe,
On 2016년 12월 02일 18:03, Felipe Balbi wrote:
>
> Hi,
>
> Chanwoo Choi writes:
>> Hi Felipe,
>>
>> On 2016년 11월 30일 19:36, Felipe Balbi wrote:
>>>
>>> Hi,
>>>
>>> Chanwoo Choi writes:
>>>> This patch uses
This patch replaces the deprecated extcon API as following:
- extcon_set_cable_state_() -> extcon_set_state_sync()
Signed-off-by: Chanwoo Choi
Acked-by: Felipe Balbi
---
drivers/usb/phy/phy-tahvo.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/
This patch uses the resource-managed extcon API for extcon_register_notifier()
and replaces the deprecated extcon API as following:
- extcon_get_cable_state_() -> extcon_get_state()
Signed-off-by: Chanwoo Choi
Acked-by: Felipe Balbi
---
drivers/usb/phy/phy-omap-otg.c |
This patch uses the resource-managed extcon API for extcon_register_notifier()
and replaces the deprecated extcon API as following:
- extcon_get_cable_state_() -> extcon_get_state()
Signed-off-by: Chanwoo Choi
Acked-by: Felipe Balbi
---
drivers/usb/phy/phy-qcom-8x16-usb.c | 13 -
This patch replaces the deprecated extcon API as following:
- extcon_get_cable_state_() -> extcon_get_state()
Cc: Rob Herring
Cc: Geert Uytterhoeven
Signed-off-by: Chanwoo Choi
Acked-by: Felipe Balbi
Acked-by: Yoshihiro Shimoda
---
drivers/usb/renesas_usbhs/common.c | 2 +-
1 file chan
te_() -> extcon_get_state();
Changes from v1:
- Rebase these patches based on v4.10-rc1.
- Add acked-by tag from usb maintainer and reviewer.
- Drop the phy/power-supply/chipidea patches.
Chanwoo Choi (6):
usb: dwc3: omap: Replace the extcon API
usb: phy: msm: Replace the extcon API
usb: phy: om
This patch uses the resource-managed extcon API for extcon_register_notifier()
and replaces the deprecated extcon API as following:
- extcon_get_cable_state_() -> extcon_get_state()
Signed-off-by: Chanwoo Choi
Acked-by: Felipe Balbi
---
drivers/usb/dwc3/dwc3-omap.c | 20 +++-
This patch uses the resource-managed extcon API for extcon_register_notifier()
and replaces the deprecated extcon API as following:
- extcon_get_cable_state_() -> extcon_get_state()
Cc: Peter Chen
Signed-off-by: Chanwoo Choi
---
Changes from v1:
- Rebase these patches based on v4.10-rc1.
- D
This patch uses the resource-managed extcon API for extcon_register_notifier()
and replaces the deprecated extcon API as following:
- extcon_get_cable_state_() -> extcon_get_state()
Signed-off-by: Chanwoo Choi
Acked-by: Felipe Balbi
---
drivers/usb/phy/phy-msm-usb.c |
This patch just uses the resource-managed extcon API when registering
the extcon notifier.
Signed-off-by: Chanwoo Choi
Acked-by: Maxime Ripard
Acked-by: Bin Liu
---
Changes from v1:
- Rebase this patch based on v4.10-rc1.
- Add acked-by tag from Maxime Ripard and Bin Lin.
- Drop the phy/power
Hi Felipe,
On 2016년 12월 30일 11:46, Chanwoo Choi wrote:
> Hi Felipe,
>
> On 2016년 12월 02일 18:03, Felipe Balbi wrote:
>>
>> Hi,
>>
>> Chanwoo Choi writes:
>>> Hi Felipe,
>>>
>>> On 2016년 11월 30일 19:36, Felipe Balbi wrote:
>>>
Hi Peter,
Please ignore this patch. After posting this patch, I got that this patch was
already merged by you. I'm sorry to make the confusion.
Regards,
Chanwoo Choi
On 2016년 12월 30일 13:15, Chanwoo Choi wrote:
> This patch uses the resource-managed extcon API for extcon_register_
Hi Felipe,
These patches have already acked-by tag from you.
Could you please apply them if there is additional comment?
On 2016년 12월 30일 13:08, Chanwoo Choi wrote:
> This patches just replace the deprecated extcon API without any change
> of extcon operation and use the resource-m
Hi Felipe,
This patch got the acked-by from Bin Liu and.
Could you please apply this patch?
On 2016년 12월 30일 13:19, Chanwoo Choi wrote:
> This patch just uses the resource-managed extcon API when registering
> the extcon notifier.
>
> Signed-off-by: Chanwoo Choi
> Acked-by
This patch uses the resource-managed extcon API for extcon_register_notifier()
and replaces the deprecated extcon API as following:
- extcon_get_cable_state_() -> extcon_get_state()
Cc: linux-o...@vger.kernel.org
Signed-off-by: Chanwoo Choi
Acked-by: Felipe Balbi
---
drivers/usb/phy/phy-o
This patch uses the resource-managed extcon API for extcon_register_notifier()
and replaces the deprecated extcon API as following:
- extcon_get_cable_state_() -> extcon_get_state()
Cc: linux-o...@vger.kernel.org
Signed-off-by: Chanwoo Choi
Acked-by: Felipe Balbi
---
drivers/usb/dwc3/d
This patch replaces the deprecated extcon API as following:
- extcon_get_cable_state_() -> extcon_get_state()
Signed-off-by: Chanwoo Choi
Acked-by: Felipe Balbi
Acked-by: Yoshihiro Shimoda
---
drivers/usb/renesas_usbhs/common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --
This patch uses the resource-managed extcon API for extcon_register_notifier()
and replaces the deprecated extcon API as following:
- extcon_get_cable_state_() -> extcon_get_state()
Signed-off-by: Chanwoo Choi
Acked-by: Felipe Balbi
---
drivers/usb/phy/phy-qcom-8x16-usb.c | 13 -
This patch uses the resource-managed extcon API for extcon_register_notifier()
and replaces the deprecated extcon API as following:
- extcon_get_cable_state_() -> extcon_get_state()
Signed-off-by: Chanwoo Choi
Acked-by: Felipe Balbi
---
drivers/usb/phy/phy-msm-usb.c |
This patch replaces the deprecated extcon API as following:
- extcon_set_cable_state_() -> extcon_set_state_sync()
Signed-off-by: Chanwoo Choi
Acked-by: Felipe Balbi
---
drivers/usb/phy/phy-tahvo.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/
/linux/kernel/git/balbi/usb.git/log/?h=testing/next
Chanwoo Choi (6):
usb: dwc3: omap: Replace the extcon API
usb: phy: msm: Replace the extcon API
usb: phy: omap-otg: Replace the extcon API
usb: phy: qcom-8x16-usb: Replace the extcon API
usb: phy: tahvo: Replace the deprecated extcon API
me are preparing the patches
to identify the type of external connector with extcon
This approach is not dependent on any specific SoC.
Maybe, we will send the RFC patches within this month.
--
Best Regards,
Chanwoo Choi
S/W R&D Center
Samsung Electronics
--
To unsubscribe from this list:
LOW -> USB_HOST inactive, USB inactive
>>> VBUS = HIGH -> USB_HOST inactive, USB active
>>>
>>> Signed-off-by: Roger Quadros
>
> Can you please pick this one for v4.9? Thanks.
I already sent the pull request of v4.9. It was finished.
So, this patch might be qu
Only ID GPIO is available:
>>>
>>> ID = LOW -> USB_HOST active, USB inactive
>>> ID = HIGH -> USB_HOST inactive, USB active
>>>
>>> 3) Only VBUS GPIO is available:
>>>
>>> VBUS = LOW -> USB_HOST inactive, USB inactive
se the extcon_set_cable_state().
I think that you should divide it according to role.
Again, the usage case of extcon have to consist of both provider extcon driver
and client extcon driver. If there is no provider extcon driver,
client extcon driver don't receive the any notification of external c
Hi,
On 2015년 12월 07일 21:52, Heikki Krogerus wrote:
> Hi,
>
> On Mon, Dec 07, 2015 at 10:24:22AM +0900, Chanwoo Choi wrote:
>> Hi,
>>
>> On 2015년 12월 04일 17:51, Heikki Krogerus wrote:
>>> Hi,
>>>
>>>> I do never want to add some sp
Hi Sergei,
On 2015년 12월 11일 08:07, Sergei Shtylyov wrote:
> Sometimes there's a real OTG chip behind the USB ID signal mapped to a GPIO
> pin: in my case it's Maxim Integrated MAX3355E which integrates Vbus charge
> pump and comparators and passes thru the ID signal from an OTG connector.
s
7; expression, you used the double space between words.
You should fix it.
Thanks,
Chanwoo Choi
>
> Signed-off-by: Sergei Shtylyov
>
> ---
> The patch is against the 'extcon-next' branch of the 'extcon.git' repo.
>
> Changes in version 2:
> - adde
t_drvdata(pdev, data);
> +
> + /* Perform initial detection */
> + max3355_id_irq(irq, data);
> +
> + return 0;
> +}
> +
> +static int max3355_remove(struct platform_device *pdev)
> +{
> + struct max3355_data *data = platform_get_drvdata(pdev);
> +
> + gpiod_set_value_cansleep(data->shdn_gpiod, 0);
> +
> + return 0;
> +}
> +
> +static const struct of_device_id max3355_match_table[] = {
> + { .compatible = "maxim,max3355", },
> + { }
> +};
> +MODULE_DEVICE_TABLE(of, max3355_match_table);
> +
> +static struct platform_driver max3355_driver = {
> + .probe = max3355_probe,
> + .remove = max3355_remove,
> + .driver = {
> + .name = "extcon-max3355",
> + .of_match_table = max3355_match_table,
> + .owner = THIS_MODULE,
You don't need to add the 'owner'.
> + },
> +};
> +
> +module_platform_driver(max3355_driver);
> +
> +MODULE_AUTHOR("Sergei Shtylyov ");
> +MODULE_DESCRIPTION("Maxim MAX3355 extcon driver");
> +MODULE_LICENSE("GPL v2");
Thanks,
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi,
On 2015년 12월 17일 11:16, Chanwoo Choi wrote:
> Hi Sergei,
>
> On 2015년 12월 17일 03:07, Sergei Shtylyov wrote:
>> Maxim Integrated MAX3355E chip integrates a charge pump and comparators to
>> enable a system with an integrated USB OTG dual-role transceiver to
>> funct
On 2015년 12월 18일 06:20, Sergei Shtylyov wrote:
> Hello.
>
> On 12/17/2015 05:34 AM, Chanwoo Choi wrote:
>
>>> On 2015년 12월 17일 03:07, Sergei Shtylyov wrote:
>>>> Maxim Integrated MAX3355E chip integrates a charge pump and comparators to
>>>> enable
Hi Sergei,
Except for just one comment below, Looks good to me.
Acked-by: Chanwoo Choi
I'll wait for a few days to get the review from DT maintainer
before applying it on extcon-next branch.
On 2015년 12월 18일 07:47, Sergei Shtylyov wrote:
> Maxim Integrated MAX3355E chip integrates
arators to
Thanks,
Chanwoo Choi
On Sat, Dec 19, 2015 at 8:17 AM, Sergei Shtylyov
wrote:
> Maxim Integrated MAX3355E chip integrates a charge pump and comparators to
> enable a system with an integrated USB OTG dual-role transceiver to
> function as an USB OTG dual-role device. In
Hi,
On 2015년 12월 21일 02:15, Sergei Shtylyov wrote:
> Hello.
>
> On 12/20/2015 05:31 PM, Chanwoo Choi wrote:
>
>> This patch depend on GPIOLIB configuration as following:
>> I modified it with following diff and applied it.
>>
>> diff --git a/drivers/ext
ers/extcon/extcon-max3355.c
> @@ -11,14 +11,9 @@
>
> #include
> #include
> -#include
> #include
> -#include
> #include
> -#include
> #include
> -#include
> -#include
>
> struct max3355_data {
> struct extcon_dev *edev;
>
I com
On 2015년 12월 21일 20:01, Sergei Shtylyov wrote:
> Hello.
>
> On 12/21/2015 5:38 AM, Chanwoo Choi wrote:
>
>>>> This patch depend on GPIOLIB configuration as following:
>>>> I modified it with following diff and applied it.
>>>>
>>>>
On 2015년 12월 22일 20:15, Sergei Shtylyov wrote:
> Hello.
>
> On 12/22/2015 4:13 AM, Chanwoo Choi wrote:
>
>>>>>> This patch depend on GPIOLIB configuration as following:
>>>>>> I modified it with following diff and applied it.
>>>>&g
adros
Cc: Charles Keepax
Cc: patc...@opensource.wolfsonmicro.com
Cc: linux-renesas-...@vger.kernel.org
Cc: linux-arm-ker...@lists.infradead.org
Cc: linux-usb@vger.kernel.org
Signed-off-by: Chanwoo Choi
---
drivers/extcon/devres.c | 2 +-
drivers/extcon/extcon-adc-jack.c | 2 +-
dr
p;usb_extcon_pm_ops,
> .of_match_table = usb_extcon_dt_match,
> },
> + .id_table = usb_extcon_platform_ids,
> };
>
> module_platform_driver(usb_extcon_driver);
>
Looks good to me.
Acked-by: Chanwoo Choi
Best Regards,
Chanwoo Choi
--
To unsubscribe fr
return -EINVAL;
>
> info = devm_kzalloc(&pdev->dev, sizeof(*info), GFP_KERNEL);
>
Looks good to me.
Acked-by: Chanwoo Choi
Best Regards,
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Lu,
On 2016년 03월 17일 16:16, Lu Baolu wrote:
> Hi Chanwoo,
>
> On 03/17/2016 02:07 PM, Chanwoo Choi wrote:
>> Hi Lu,
>>
>> To handle extcon (external connector), I implemented the unique id
>> for each external connector on patch[1] instead of using the
opyright (C) 2016 Intel Corporation
> + *
> + * Author: Lu Baolu
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + */
> +
> +#ifndef __LINUX_USB_INTEL_MUX_H
> +#define __LINUX_USB_INTEL_MUX_H
> +
> +#if IS_ENABLED(CONFIG_INTEL_USB_MUX)
> +int intel_usb_mux_bind_cable(struct device *dev, char *extcon_name,
> + char *cable_name,
> + int (*cable_set_cb)(struct device *dev),
> + int (*cable_unset_cb)(struct device *dev));
> +int intel_usb_mux_unbind_cable(struct device *dev);
> +#ifdef CONFIG_PM_SLEEP
> +void intel_usb_mux_complete(struct device *dev);
> +#endif
> +
> +#else
> +static inline int
> +intel_usb_mux_bind_cable(struct device *dev,
> + char *extcon_name,
> + char *cable_name,
> + int (*cable_set_cb)(struct device *dev),
> + int (*cable_unset_cb)(struct device *dev))
> +{
> + return -ENODEV;
> +}
> +
> +static inline int intel_usb_mux_unbind_cable(struct device *dev)
> +{
> + return 0;
> +}
> +#endif /* CONFIG_INTEL_USB_MUX */
> +
> +#endif /* __LINUX_USB_INTEL_MUX_H */
>
Best Regards,
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
"USB-HOST") == true)
> + ci->role = CI_ROLE_HOST;
> + }
> }
> } else {
> ci->role = ci->roles[CI_ROLE_HOST]
> @@ -1021,6 +1025,12 @@ stat
platform
> dependent, could focus on the real operation of mux switch.
>
> Signed-off-by: Lu Baolu
> Reviewed-by: Heikki Krogerus
> Reviewed-by: Felipe Balbi
Looks good to me about extcon usage.
For extcon usage,
Reviewed-by: Chanwoo Choi
Best Regards,
Chanwoo Choi
>
Hi Lu,
On 2016년 04월 25일 17:04, Lu Baolu wrote:
> This is needed to handle the GPIO connected USB ID pin found on
> Intel Baytrail devices.
>
> Signed-off-by: Lu Baolu
> Reviewed-by: Felipe Balbi
> Acked-by: Chanwoo Choi
> ---
> drivers/extcon/extcon-usb-gpio.c | 7 +
Hi Lu,
On 2016년 04월 25일 17:04, Lu Baolu wrote:
> GPIO resource could be retrieved through APCI as well.
>
> Signed-off-by: Lu Baolu
> Reviewed-by: Felipe Balbi
> Acked-by: Chanwoo Choi
> ---
> drivers/extcon/extcon-usb-gpio.c | 3 ++-
> 1 file changed, 2 i
> }
>
> platform_set_drvdata(pdev, info);
> - device_init_wakeup(dev, true);
> + device_set_wakeup_capable(&pdev->dev, true);
>
> /* Perform initial detection */
> usb_extcon_detect_cable(&info->wq_detcable.work);
Applied it
ret = extcon_register_notifier(dwc->edev, EXTCON_USB_HOST,
> + &dwc->edev_nb);
Ditto.
[snip]
--
Best Regards,
Chanwoo Choi
Samsung Electronics
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
w to use the extcon device.
>
>>
>>> +
>>> +if (IS_ERR(dwc->edev))
>>> +return PTR_ERR(dwc->edev);
>>
>> Took me a while to get to this. :)
>>
>> if (IS_ERR(dwc->edev)) {
>>ret = PTR_ERR(dwc->edev);
>>goto err0;
>> }
>>
>> We want to reset the res->start back to its original offset.
>>
>> Testing this series currently. Will get back with my results.
>>
>>
> Thanks :)
>
> --
> cheers,
> -roger
--
Best Regards,
Chanwoo Choi
Samsung Electronics
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
2017-02-25 12:46 GMT+09:00 Chanwoo Choi :
> Hi,
>
> 2017-02-24 21:02 GMT+09:00 Roger Quadros :
>> +Chanwoo
>>
>> Hi Vivek,
>>
>> On 23/02/17 10:34, Vivek Gautam wrote:
>>>
>>>
>>> On 02/16/2017 06:36 PM, Roger Quadros wrote:
>>
This patch uses the resource-managed extcon API for extcon_register_notifier()
and replaces the deprecated extcon API as following:
- extcon_get_cable_state_() -> extcon_get_state()
Cc: Greg Kroah-Hartman
Cc: Chunfeng Yun
Cc: linux-usb@vger.kernel.org
Signed-off-by: Chanwoo Choi
---
driv
Hi Kishon,
Sorry for late reply.
I applied patch1,2 on extcon-linus branch.
-
http://git.kernel.org/cgit/linux/kernel/git/chanwoo/extcon.git/log/?h=extcon-linus
But, I have comment of patch 3 about dt API. I send comment on patch 3 mailing
thread.
Thanks,
Chanwoo Choi
On 06/04/2013 01:13 AM
,
Chanwoo Choi
On 06/04/2013 01:13 AM, Kishon Vijay Abraham I wrote:
> The first three patches deals with cleanup of extcon inorder to get
> through compilation without any issues. It also adds an API to get
> extcon device from dt node which I felt was missing.
>
> The next two pat
har *extcon_name);
>
> /*
> @@ -292,6 +294,12 @@ static inline int extcon_set_cable_state(struct
> extcon_dev *edev,
> return 0;
> }
>
> +static inline struct extcon_dev *of_extcon_get_extcon_dev(struct device *dev,
> + int index)
> +{
> + return NULL;
> +}
> +
> static inline struct extcon_dev *extcon_get_extcon_dev(const char
> *extcon_name)
> {
> return NULL;
Thanks,
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Kishon Vijay Abraham I
Added an API of_extcon_get_extcon_dev() to be used by drivers to get
extcon device in the case of dt boot (this can be used instead of
extcon_get_extcon_dev()).
Signed-off-by: Kishon Vijay Abraham I
Signed-off-by: Chanwoo Choi
Signed-off-by: Myungjoo Ham
On 06/12/2013 03:55 PM, Kishon Vijay Abraham I wrote:
> Hi Chanwoo Choi,
>
> On Wednesday 12 June 2013 07:09 AM, Chanwoo Choi wrote:
>> From: Kishon Vijay Abraham I
>>
>> Added an API of_extcon_get_extcon_dev() to be used by drivers to get
>> extcon device in
From: Kishon Vijay Abraham I
Added an API of_extcon_get_extcon_dev() to be used by drivers to get
extcon device in the case of dt boot (this can be used instead of
extcon_get_extcon_dev()).
Signed-off-by: Kishon Vijay Abraham I
Signed-off-by: Chanwoo Choi
Signed-off-by: Myungjoo Ham
On 06/14/2013 05:36 PM, Kishon Vijay Abraham I wrote:
> Hi,
>
> On Friday 14 June 2013 12:45 PM, Chanwoo Choi wrote:
>> From: Kishon Vijay Abraham I
>>
>> Added an API of_extcon_get_extcon_dev() to be used by drivers to get
>> extcon device in the case of dt
to err2;
> + goto err3;
> }
>
> return 0;
>
> +err3:
> + if (omap->extcon_vbus_dev.edev)
> + extcon_unregister_interest(&omap->extcon_vbus_dev);
> + if (omap->extcon_id_dev.edev)
&
d-by: Felipe Balbi
> Acked-by: Chanwoo Choi
> ---
> This patch should be applied after all of the extcon patchset will be applied
> because this patch has dependency of extcon patch related to DT.
> http://goo.gl/Tu3qW
>
> Changes from v4:
> * checked the return values of e
g to extcon framework.
>>
>> Signed-off-by: Kishon Vijay Abraham I
>> Acked-by: Felipe Balbi
>> Acked-by: Chanwoo Choi
>> ---
>> This patch should be applied after all of the extcon patchset will be applied
>> because this patch has dependency of extcon pa
dev_err(dra7xx_usb->dev, "failed to create thread for %s\n"
> + , dev_name(&pdev->dev));
> + goto err0;
I need correct meaning name as err_thread or etc ...
> + }
> +
> + wake_up_process(dra7xx_usb->thread_task);
> +
> + return 0;
> +
> +err0:
ditto.
> + gpio_free(dra7xx_usb->id_gpio);
> + extcon_dev_unregister(&dra7xx_usb->edev);
> +
> + return status;
> +}
> +
> +static int dra7xx_usb_remove(struct platform_device *pdev)
> +{
> + struct dra7xx_usb *dra7xx_usb = platform_get_drvdata(pdev);
> +
> + if (!dra7xx_usb->irq_gpio)
> + kthread_stop(dra7xx_usb->thread_task);
> +
> + gpio_free(dra7xx_usb->id_gpio);
> + extcon_dev_unregister(&dra7xx_usb->edev);
> +
> + return 0;
> +}
> +
> +static struct of_device_id of_dra7xx_match_tbl[] = {
> + { .compatible = "ti,dra7xx-usb", },
> + { /* end */ }
> +};
> +
> +static struct platform_driver dra7xx_usb_driver = {
> + .probe = dra7xx_usb_probe,
> + .remove = dra7xx_usb_remove,
> + .driver = {
> + .name = "dra7xx-usb",
> + .of_match_table = of_dra7xx_match_tbl,
> + .owner = THIS_MODULE,
> + },
> +};
> +
> +module_platform_driver(dra7xx_usb_driver);
> +
> +MODULE_ALIAS("platform:dra7xx-usb");
> +MODULE_AUTHOR("George Cherian ");
> +MODULE_DESCRIPTION("DRA7x USB Connector driver");
> +MODULE_LICENSE("GPL");
> +MODULE_DEVICE_TABLE(of, of_dra7xx_match_tbl);
>
Thanks,
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
;dev), (void *) dra7xx_usb);
>>> +if (status)
>>> +dev_err(dra7xx_usb->dev, "failed to request irq #%d\n",
>>> +irq_num);
>> If devm_request_threaded_irq() return fail state, why did not you do add
>> e
;>>> Should you use polling method with kthread? I think it isn't proper method.
>>>> You did get the irq number by using DT helper function and register irq
>>>> handler
>>>> with devm_request_threaded_irq(). I prefer interrupt method for detection
pio_usbvid->vbus_gpio);
> + } else {
> + dev_err(&pdev->dev, "failed to get vbus gpio\n");
> + return -ENODEV;
> + }
> + }
> +
> + ret = extcon_dev_register(&gpio_usbvid->edev, gpio_usbvid-
Hi George,
On 08/29/2013 11:21 AM, George Cherian wrote:
> Hi Chanwoo,
>
> Thanks for the review and sorry for all the trivial mistakes.
>
> On 8/29/2013 7:05 AM, Chanwoo Choi wrote:
>> Hi George,
>>
>> You didn't modify this patchset about my comment on v
On 08/29/2013 04:30 PM, George Cherian wrote:
> Hi Chanwoo,
>
> On 8/29/2013 11:53 AM, Chanwoo Choi wrote:
> [snip]
>> You should keep following naming stlye. extcon-gpio-usbvid.c is wrong naming
>> style.
>> - extcon-[device name].c
>> - extcon-gpi
On 08/29/2013 08:48 PM, George Cherian wrote:
> On 8/29/2013 4:07 PM, Chanwoo Choi wrote:
>> On 08/29/2013 04:30 PM, George Cherian wrote:
>>> Hi Chanwoo,
>>>
>>> On 8/29/2013 11:53 AM, Chanwoo Choi wrote:
>>> [snip]
>>>> You should k
Hi George,
On 08/29/2013 10:45 PM, George Cherian wrote:
> Hi Chanwoo,
>
>
> On 8/29/2013 5:42 PM, Chanwoo Choi wrote:
> [big snip ]
>>>> I tested various development board based on Samsung Exynos series SoC.
>>>> Although some gpio of Exynos se
Hi George,
On 08/30/2013 03:15 PM, George Cherian wrote:
> Hi Chanwoo,
>
> On 8/30/2013 5:41 AM, Chanwoo Choi wrote:
>> Hi George,
>>
>> On 08/29/2013 10:45 PM, George Cherian wrote:
>>> Hi Chanwoo,
>>>
>>>
>>> On 8/29/2013 5:42
Hi George,
In addition, I add answer about that device driver control gpio pin directly.
On 08/30/2013 03:15 PM, George Cherian wrote:
> Hi Chanwoo,
>
> On 8/30/2013 5:41 AM, Chanwoo Choi wrote:
>> Hi George,
>>
>> On 08/29/2013 10:45 PM, George Cherian wrote:
>&
con_set_cable_state(&palmas_usb->edev, "USB-HOST", false);
>> dev_info(palmas_usb->dev, "USB-HOST cable is detached\n");
>> +} else if ((palmas_usb->linkstat == PALMAS_USB_STATE_DISCONNECT) &&
>> +(id_src &a
Hi Kishon,
I have some comment about this patch
and upload modified patch to following repository (extcon-for-palmas).
-
http://git.kernel.org/cgit/linux/kernel/git/chanwoo/extcon.git/commit/?h=extcon-for-palmas&id=f2b7cb80699cbe1a5fd6c97ef2c600915f8d7f2c
This patchset include patch related to o
gt; drivers/usb/dwc3/dwc3-omap.c | 80
> +--
> include/linux/usb/dwc3-omap.h | 30
> 2 files changed, 62 insertions(+), 48 deletions(-)
> delete mode 100644 include/linux/usb/dwc3-omap.h
>
>
I check the code about ex
On 05/27/2013 02:54 PM, Kishon Vijay Abraham I wrote:
> Hi,
>
> On Monday 27 May 2013 11:04 AM, Chanwoo Choi wrote:
>> Hi Kishon,
>>
>> I have some comment about this patch
>> and upload modified patch to following repository (extcon-for-palmas).
>> -
>
On 05/27/2013 10:35 PM, Kishon Vijay Abraham I wrote:
> Modified dwc3-omap to receive connect and disconnect notification using
> extcon framework. Also did the necessary cleanups required after
> adapting to extcon framework.
>
> Signed-off-by: Kishon Vijay Abraham I
> Acke
gory
> Signed-off-by: Moiz Sonasath
> Signed-off-by: Ruchika Kharwar
> Signed-off-by: Kishon Vijay Abraham I
> Signed-off-by: George Cherian
> [kis...@ti.com: adapted palmas usb driver to use the extcon framework]
> Signed-off-by: Sebastien Guiriec
> Signed-off-by: C
lmas-usb", "USB",
> + &omap->vbus_nb);
> + omap->id_nb.notifier_call = dwc3_omap_id_notifier;
> + extcon_register_interest(&omap->extcon_id_dev, "palmas-usb", "USB-HOST",
> + &omap->id_nb);
> dev->dma_mask = &dwc3_omap_dma_mask;
>
> +
Thanks,
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Sergei,
I reviewed this patch quickly. This driver has just two gpio without any
registers for IP.
I wonder whether MAX3355E is separate chip to detect external connector or just
use gpio of AP.
Could you send the datasheet of MAX3355E to me?
Thanks,
Chanwoo Choi
On 12/11/2014 08:28 AM
1 - 100 of 211 matches
Mail list logo
