.
- The barrier for dwc2_writel is on the wrong side of the __raw_writel(),
so the MMIO no longer synchronizes with DMA operations.
- On architectures that require specific CPU instructions for MMIO
access, using the __raw_ variant may turn this into a pointer
dereference that does not have
On Friday 29 April 2016 17:52:26 Thierry Reding wrote:
> phy: tegra: Changes for v4.7-rc1
>
> This set of patches adds support for the Tegra XUSB pad controller. The
> controller provides a set of pads (lanes) that are used for I/O by other
> IP blocks within Tegra SoCs (PCIe, SATA and XUSB).
>
>
On Friday 29 April 2016 17:52:27 Thierry Reding wrote:
> PCI: tegra: Changes for v4.7-rc1
>
> These patches update the Tegra PCIe host bridge controller device tree
>
Merged into next/drivers, thanks!
Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the bo
On Friday 29 April 2016 17:52:28 Thierry Reding wrote:
> usb: host: xhci-tegra: Changes for v4.7-rc1
>
> This set of patches introduces a driver for the XUSB controller found on
> NVIDIA Tegra SoCs. When loaded with a firmware (available via the linux-
> firmware repository), it provides an XHCI-c
On Friday 29 April 2016 18:13:30 Thierry Reding wrote:
> ARM: tegra: Enable the XUSB controller
>
> These changes add support for the XUSB controller on Tegra124. It is an
> XHCI compatible controller that replaces the existing EHCI controllers.
> Support is enabled on Venice2, Jetson TK1 and Nyan
On Monday 09 May 2016 13:39:50 Felipe Balbi wrote:
> Arnd Bergmann writes:
> > On Monday 09 May 2016 10:23:22 Benjamin Herrenschmidt wrote:
> >> On Sun, 2016-05-08 at 13:44 +0200, Christian Lamparter wrote:
> >
> > The patch that caused the problem had multiple
On Monday 09 May 2016 21:06:07 Christian Lamparter wrote:
> Uh, Thanks for the participation!
>
> On Monday, May 09, 2016 05:08:48 PM Arnd Bergmann wrote:
> > On Monday 09 May 2016 13:39:50 Felipe Balbi wrote:
> > > Arnd Bergmann writes:
> > > > On
On Monday 09 May 2016 13:22:48 John Youn wrote:
> On 5/9/2016 3:36 AM, Arnd Bergmann wrote:
> > On Monday 09 May 2016 10:23:22 Benjamin Herrenschmidt wrote:
> >> On Sun, 2016-05-08 at 13:44 +0200, Christian Lamparter wrote:
> >>> On Sunday, May 08, 2016 08:40:55 P
On Monday 09 May 2016 14:11:23 John Youn wrote:
> On 5/9/2016 1:39 PM, Arnd Bergmann wrote:
>
> > The systems are not a particular endianess, only the current state
> > of the CPU is, and that may change independent of the way the
> > hardware block got synthesized. W
On Tuesday 10 May 2016 08:37:52 Benjamin Herrenschmidt wrote:
> On Mon, 2016-05-09 at 17:08 +0200, Arnd Bergmann wrote:
> >
> > Unfortunately, I don't see any way this could be done in MIPS specific
> > code: There is typically a byteswap between the internal bus and the
up with a more elaborate change to add runtime
detection of endianess, to make sure it also works on all other
combinations of architectures and implementations of the usb-dwc2
device. That patch however will be fairly large and not appropriate
for backports to stable kernels.
Signed-off-by: Arnd
On Thursday 12 May 2016 14:25:49 Felipe Balbi wrote:
> > {
> > u32 value = __raw_readl(addr);
> >
> > - /* In order to preserve endianness __raw_* operation is used.
> > Therefore
> > - * a barrier is needed to ensure IO access is not re-ordered across
> > + /* in order to pr
On Thursday 12 May 2016 14:43:43 Felipe Balbi wrote:
> >> How many more drivers will we have to 'fix' like this ?
> >
> > Endianess problems will keep coming up, and we have hundreds or thousands
> > of drivers that are written with a particular design in mind that could
> > be wrong as soon as som
On Thursday 12 May 2016 11:58:18 Christian Lamparter wrote:
> > > > Detecting the endianess of the
> > > > device is probably the best future-proof solution, but it's also
> > > > considerably more work to do in the driver, and comes with a
> > > > tiny runtime overhead.
> > >
> > > The runtime ov
On Thursday 12 May 2016 22:39:36 Christian Lamparter wrote:
> On Thursday, May 12, 2016 11:40:28 AM John Youn wrote:
> > On 5/12/2016 6:30 AM, Christian Lamparter wrote:
> > > On Thursday, May 12, 2016 01:55:44 PM Arnd Bergmann wrote:
> > >>
> > >> If I re
-off-by: Arnd Bergmann
Fixes: 95c8bc360944 ("usb: dwc2: Use platform endianness when accessing
registers")
---
v3: reverted the accidental changes that slipped into the patch,
resending as requested by Christian.
drivers/usb/dwc2/core.h | 29 +
1 file c
On Thursday 12 May 2016 23:32:18 John Youn wrote:
>
> Hi Arnd,
>
> The capitalization issue is still there in this patch.
>
> There's also a few checkpatch issues.
Fixed now, thanks. I'll send a v4 in a bit.
> And should the barrier be moved after the write like it says in the
> comment? That
.
Signed-off-by: Arnd Bergmann
Fixes: 95c8bc360944 ("usb: dwc2: Use platform endianness when accessing
registers")
---
drivers/usb/dwc2/core.h | 27 +++
1 file changed, 27 insertions(+)
diff --git a/drivers/usb/dwc2/core.h b/drivers/usb/dwc2/core.h
index 3c
On Saturday 14 May 2016 15:11:34 Christian Lamparter wrote:
>
> +#ifdef CONFIG_MIPS
> +/*
> + * There are some MIPS machines that can run in either big-endian
> + * or little-endian mode and that use the dwc2 register without
> + * a byteswap in both ways.
> + * Unlike other architectures, MIPS ap
On Wednesday 18 May 2016 21:14:55 Christian Lamparter wrote:
> On Tuesday, May 17, 2016 04:50:48 PM John Youn wrote:
> > On 5/14/2016 6:11 AM, Christian Lamparter wrote:
> Hey, that's really nice of you to do that :-D. Please keep me in the
> loop (Cc) for those then.
>
> Yes, this needs definit
The linux/usb/msm_hsusb_hw.h header is now only included
by one file and can be merged into that for simplicity.
Signed-off-by: Arnd Bergmann
---
drivers/usb/phy/phy-msm-usb.c| 56 +-
include/linux/usb/msm_hsusb_hw.h | 74
3.3v regulators in the
MSM usb phy driver. For consistency, the msm_hsusb_init_vddcx()
is also removed, and instead we just set the voltages
directly where needed, reducing the code size further and
making it more obvious what is actually going on here.
Signed-off-by: Arnd Bergmann
---
drivers/usb
-off-by: Arnd Bergmann
---
drivers/soc/qcom/Kconfig | 6 +
drivers/soc/qcom/Makefile| 1 +
drivers/soc/qcom/qcom-tcsr.c | 57
drivers/usb/phy/Kconfig | 1 +
drivers/usb/phy/phy-msm-usb.c| 10 +++
include/linux/soc
It seems odd that this driver explicitly enables the vddcx regulator
on probe along with the other regulators, but doesn't disable it
again when the device is removed.
This changes the remove callback to handle all three regulators the
same way and disable them in the end.
Signed-off-by:
other than
how we now first set the voltage on all regulators and then enable
or disable them, rather than doing it one regulator at a time.
In particular, it looks like a mistake that msm_otg_remove() disables
only two of the three regulators that are enabled in msm_otg_probe(),
but changing th
emoves the duplicate initialization, to avoid the dependency
on the header file and the phy registers.
Signed-off-by: Arnd Bergmann
---
drivers/usb/chipidea/ci_hdrc_msm.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/usb/chipidea/ci_hdrc_msm.c
b/drivers/usb/chipidea/ci_hdrc_m
ee files to go along with it.
Please have a look and test this, provided the patches make sense
conceptually.
Arnd
Arnd Bergmann (8):
usb: phy: move msm_hsusb.h into driver
usb: ehci-msm: call usb_phy_init instead of open-coding it
usb: chipidea: msm: remove open-coded phy init
us
did not test this change, so please review the patch carefully
and wait for a positive test result before applying.
Signed-off-by: Arnd Bergmann
---
drivers/usb/host/ehci-msm.c | 17 ++---
1 file changed, 2 insertions(+), 15 deletions(-)
diff --git a/drivers/usb/host/ehci-msm.c b
As a preparation for another cleanup, this moves the header file
for the phy-msm-usb driver into the driver itself. No other file
includes it any more, and we don't really want it in the global
namespace anyway.
Signed-off-by: Arnd Bergmann
---
drivers/usb/phy/phy-msm-usb.c
riable]
This removes them as well.
Signed-off-by: Arnd Bergmann
Fixes: e00be9e4d0ff ("net: pegasus: remove dead coding")
---
drivers/net/usb/pegasus.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/net/usb/pegasus.c b/drivers/net/usb/pegasus.c
i
On Friday 20 May 2016 12:32:23 Petko Manolov wrote:
> Guys, come on. This code is not dead. This code is executed every time an
> ethernet packet is received. It takes care of various error statistics. More
> importantly, it sends the actual (reported by the adapter) packet length to
> the
>
On Thursday 19 May 2016 14:08:43 Andy Gross wrote:
> > + * - Tim
> > + */
> > +int qcom_tcsr_phy_sel(u32 val)
> > +{
> > + void __iomem *phy_select;
> > + int ret;
> > +
> > + phy_select = ioremap(USB2_PHY_SEL, 4);
> > +
> > + if (!phy_select) {
> > +
On Friday 20 May 2016 13:44:14 Mark Brown wrote:
> On Fri, May 20, 2016 at 02:24:14PM +0200, Arnd Bergmann wrote:
> > On Thursday 19 May 2016 14:08:43 Andy Gross wrote:
>
> > > I'd rather do something like what we did for the GSBI. It needed to
> > > change s
On Wednesday, June 8, 2016 3:04:27 AM CEST kbuild test robot wrote:
> >> drivers/usb/core/of.c:32:21: error: redefinition of 'usb_of_get_child_node'
> struct device_node *usb_of_get_child_node(struct device_node *parent,
> ^
>In file included from
se on by default once all the patches are
merged.
Arnd
Arnd Bergmann (5):
net: qlcnic: don't set unused function argument
net: tlan: don't set unused function argument
mic: remove unused function arg
usb: pxa27x_udc: remove unused function argument
fbmon: remove
error=unused-but-set-parameter]
This remove the argument entirely.
Signed-off-by: Arnd Bergmann
---
drivers/usb/gadget/udc/pxa27x_udc.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/gadget/udc/pxa27x_udc.c
b/drivers/usb/gadget/udc/pxa27x_udc.
dwc2 driver to avoid that
broken configuration.
Signed-off-by: Arnd Bergmann
---
drivers/usb/dwc2/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/dwc2/Kconfig b/drivers/usb/dwc2/Kconfig
index c1f29caa8990..e838701d6dd5 100644
--- a/drivers/usb/dwc2/Kconfig
+++ b/drivers/usb/dw
ts rid of the
warning too.
Signed-off-by: Arnd Bergmann
Fixes: f9c589e142d0 ("xhci: TD-fragment, align the unsplittable case with a
bounce buffer")
---
drivers/usb/host/xhci-ring.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhc
On Tuesday 15 January 2013, Ezequiel Garcia wrote:
> Cc: Lior Amsalem
> Cc: Thomas Petazzoni
> Cc: Gregory CLEMENT
> Signed-off-by: Ezequiel Garcia
The patches look good, but when you have four trivial patches
doing the same thing in different files, and you decide that it's
not worth writing
On Tuesday 15 January 2013, Kishon Vijay Abraham I wrote:
> +OMAP CONTROL USB
> +
> +Required properties:
> + - compatible: Should be "ti,omap-control-usb"
> + - reg : Address and length of the register set for the device. It contains
> + the address of "control_dev_conf" and "otghs_control".
> +
On Tuesday 15 January 2013, Kishon Vijay Abraham I wrote:
> Added a new driver for the usb part of control module. This has an API
> to power on the USB2 phy and an API to write to the mailbox depending on
> whether MUSB has to act in host mode or in device mode.
>
> Writing to control module regi
On Tuesday 15 January 2013, kishon wrote:
> Good point :-). Currently, none of the OMAP platforms have multiple
> control modules and it doesn't seem to be in the future (AFAIK). While
> it might be simpler to support multiple control devices with phandle, it
> might face the same complications
rivers/usb/host/ehci-hcd.c:1255:0: note: this is the location of the previous
definition
In file included from drivers/usb/host/ehci-hcd.c:1254:0:
drivers/usb/host/ehci-mxc.c:280:31: warning: 'ehci_mxc_driver' defined but not
used
Signed-off-by: Arnd Bergmann
Cc: Alan Stern
Cc: Gr
it may be
much too late for that. At least the drivers don't
seem to be too essential, as they are only built
in allyesconfig but not in any of the defconfigs.
Arnd
Arnd Bergmann (15):
ARM: compressed/head.S: work around new binutils warning
ARM: mvebu: build coherency_ll.S for arc
as an better solution.
Without this patch, building allyesconfig results in:
drivers/usb/gadget/fsl_mxc_udc.c:21:27: fatal error: mach/hardware.h: No such
file or directory
Signed-off-by: Arnd Bergmann
Cc: Felipe Balbi
Cc: Shawn Guo
Cc: Greg Kroah-Hartman
Cc: linux-usb@vger.kernel.org
---
driver
On Monday 21 January 2013, Felipe Balbi wrote:
> On Mon, Jan 21, 2013 at 05:16:06PM +0000, Arnd Bergmann wrote:
> > Manjunath Goudar is already working on a patch to convert
> > both the imx and the mvebu glue drivers (along with all
> > the other ARM specific ones) to t
On Monday 21 January 2013, Greg Kroah-Hartman wrote:
> On Mon, Jan 21, 2013 at 08:41:38PM +0200, Felipe Balbi wrote:
>
> > NAK, I prefer to see a real fix for the problem (which in fact is
> > already in my fixes branch).
>
> I'll pull that branch now, sorry for the delay.
>
Ok, great! Thanks a
On Monday 21 January 2013, Alan Stern wrote:
> On Mon, 21 Jan 2013, Felipe Balbi wrote:
>
> > On Mon, Jan 21, 2013 at 05:16:06PM +, Arnd Bergmann wrote:
> > > In linux-3.8-rc1 it became possible to build the imx and
> > > mvebu platforms together in a single kern
On Monday 21 January 2013, Alan Stern wrote:
> Is Manjunath aware of the first patch attached to this email message?
>
> http://marc.info/?l=linux-usb&m=135843902916416&w=2
>
I would not expect so. Manjunath is still learning about the open
source processes, but he has also done a simila
On Tuesday 22 January 2013, Alan Stern wrote:
> In order to prevent this, you have to make sure that each glue driver
> depends on USB_ARCH_HAS_EHCI. A simple way to do this is to surround
> the Kconfig entries for those drivers with "if USB &&
> USB_ARCH_HAS_EHCI" ... "endif".
I was actually th
thing without warning.
Fixes: ea2f35c01d5e ("usb: musb: Fix sleeping function called from invalid
context for hdrc glue")
Signed-off-by: Arnd Bergmann
---
drivers/usb/musb/musb_core.c | 17 +
1 file changed, 5 insertions(+), 12 deletions(-)
diff --git a/driver
On Monday, November 28, 2016 11:51:37 AM CET Geert Uytterhoeven wrote:
> On Tue, Nov 22, 2016 at 3:30 PM, Arnd Bergmann wrote:
> > Building without CONFIG_PM causes a harmless warning:
> >
> > drivers/usb/musb/musb_core.c:2041:12: error: ‘musb_run_resume_work’ defined
>
On Thursday, January 5, 2017 1:53:16 PM CET Raviteja Garimella wrote:
> The UDC is based on Synopsys Designware core USB (2.0) Device controller
> IP.
...
> This is a request for comments from maintainers/others regarding approach
> on whether to have 2 different drivers (one each for AMD and Broad
On Friday, January 6, 2017 12:29:12 PM CET Raviteja Garimella wrote:
> Hi Arnd,
>
> On Fri, Jan 6, 2017 at 3:33 AM, Arnd Bergmann wrote:
> > On Thursday, January 5, 2017 1:53:16 PM CET Raviteja Garimella wrote:
> >> The UDC is based on Synopsys Designware core USB (2.0) D
don't see from where.
Fixes: 635f997a499b ("usb: phy: ab8500: Remove the set_power callback")
Signed-off-by: Arnd Bergmann
---
drivers/usb/phy/phy-ab8500-usb.c | 13 -
1 file changed, 13 deletions(-)
diff --git a/drivers/usb/phy/phy-ab8500-usb.c b/drivers/usb/p
On Thursday, September 8, 2016 2:20:58 PM CEST Felipe Balbi wrote:
> >> It's quite a hack, though. I still think that inheriting DMA (or
> >> manually initializing a child with parent's DMA bits and pieces) is the
> >> best way to go. So we're back to of_dma_configure() and
> >> acpi_dma_configure(
On Thursday, September 8, 2016 3:02:56 PM CEST Grygorii Strashko wrote:
> dwc3: probe()
> if (!&pdev->dev->of_node)
> legacy case - hard-code DMA props
> dwc->sysdev = &pdev->dev;
The PCI case will fall into this too, as we almost never have an
->of_node po
On Thursday, September 8, 2016 2:52:46 PM CEST Felipe Balbi wrote:
> Arnd Bergmann writes:
> >> If we make dwc3.ko a library which glue calls directly then all these
> >> problems are solved but we break all current DTs and fall into the trap
> >> of having another
On Thursday, September 8, 2016 8:28:10 PM CEST Peter Chen wrote:
> On Thu, Sep 08, 2016 at 12:17:21PM +0200, Arnd Bergmann wrote:
> > On Thursday, September 8, 2016 12:43:06 PM CEST Felipe Balbi wrote:
> > > Arnd Bergmann writes:
> > > > On Thursday, September 8
be valid, which tells the compiler that it's
safe and makes it easier to understand to me.
Signed-off-by: Arnd Bergmann
Fixes: 31162af447d7 ("usb: dwc3: gadget: avoid while (1) loop on completion")
---
drivers/usb/dwc3/gadget.c | 14 +-
1 file changed, 9 insertions(
On Monday, September 12, 2016 9:09:16 AM CEST Alan Stern wrote:
> > diff --git a/drivers/usb/core/message.c b/drivers/usb/core/message.c
> > index 0406a59..66364ea 100644
> > --- a/drivers/usb/core/message.c
> > +++ b/drivers/usb/core/message.c
> > @@ -1863,6 +1863,12 @@ free_interfaces:
> >
he USB_F_UVC into 'm'
whenever CONFIG_VIDEO_V4L2=m too, avoiding the link failure.
Signed-off-by: Arnd Bergmann
---
drivers/usb/gadget/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
index 2ea3fc3c41b9..8ad203296079 10064
rs/phy/phy-tusb1210.ko] undefined!
ERROR: "__ulpi_register_driver" [drivers/phy/phy-tusb1210.ko] undefined!
ERROR: "ulpi_write" [drivers/phy/phy-tusb1210.ko] undefined!
This adds a 'select USB_COMMON' for the symbol, similar to what
we have for related optio
On Tuesday, September 13, 2016 9:48:55 AM CEST Peter Chen wrote:
> On Mon, Sep 12, 2016 at 05:36:23PM +0200, Arnd Bergmann wrote:
> > Moving the CONFIG_USB_ULPI_BUS option to the top-level Kconfig file
> > means that we can enable it without any of the other USB support,
> &g
On Tuesday, September 13, 2016 3:19:42 PM CEST Peter Chen wrote:
>
> I just see below Kconfig entry at the same Kconfig
> (drivers/usb/Kconfig), and forget your changes.
>
> config USB_LED_TRIG
> bool "USB LED Triggers"
> depends on LEDS_CLASS && USB_COMMON && LEDS_TRIGGERS
>
On Tuesday, September 13, 2016 4:50:05 PM CEST Peter Chen wrote:
> On Tue, Sep 13, 2016 at 09:36:39AM +0200, Arnd Bergmann wrote:
> > On Tuesday, September 13, 2016 3:19:42 PM CEST Peter Chen wrote:
> > >
> > > I just see below Kconfig entry at the same Kconfig
>
) of 0xF within the scsi layer
> (scsi_calculate_bounce_limit()).
> This will result in bounce buffers being unnecessarily used.
>
> Hint: On 32-bit ARM platforms dma_max_pfn() = dma_mask_pfn + dma_pfn_offset
>
> Signed-off-by: Roger Quadros
Acked-by: Arnd Bergmann
--
To unsubsc
them.
>
> Cc: Arnd Bergmann
> Cc: Felipe Balbi
> Cc: Heikki Krogerus
> Signed-off-by: Peter Chen
>
Acked-by: Arnd Bergmann
I've also put this on top of my randconfig build tree and will let you
know if anything breaks unexpectedly. If you don't hear from me by
ot the
one that already has a correct check for USB_SUPPORT rather than
USB_COMMON.
Signed-off-by: Arnd Bergmann
Fixes: 5ed935458519 ("phy: meson: add USB2 PHY support for Meson8b and GXBB")
---
include/linux/usb/of.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
On Wednesday, September 14, 2016 5:31:36 PM CEST Lorenzo Pieralisi wrote:
> On Wed, Sep 07, 2016 at 01:47:22PM +0300, Felipe Balbi wrote:
> >
> > Hi,
> >
> > Robin Murphy writes:
> > > On 07/09/16 10:55, Peter Chen wrote:
> > > [...]
> > >>> Regarding the DMA configuration that you mention in
>
On Wednesday, September 14, 2016 3:51:01 PM CEST Arnd Bergmann wrote:
> We have had two new PHY drivers call of_usb_get_dr_mode_by_phy()
> recently without having a dependency on CONFIG_USB_COMMON, resulting
> in a link error:
>
> ERROR: "of_usb_get_dr_mode_by_phy" [driv
On Friday, September 16, 2016 1:49:59 PM CEST Kishon Vijay Abraham I wrote:
>
> I think the offset information can come from the devicetree too. The phy can
> be
> modeled something like below.
>
> usb-phys@c000 {
> compatible = "amlogic,meson-gxbb-usb
ed in this
function [-Werror=maybe-uninitialized]
This modifies the function to assign the return code before
checking it, and does uses the same method in the check for
usb_phy_generic_register() as well.
Fixes: 947c49afe41f ("usb: musb: da8xx: Remove mach code")
Signed-off-by: Arnd B
On Monday, September 19, 2016 10:29:27 AM CEST Kishon Vijay Abraham I wrote:
> On Monday 19 September 2016 01:26 AM, Martin Blumenstingl wrote:
> > On Fri, Sep 16, 2016 at 10:19 AM, Kishon Vijay Abraham I
> > wrote:
> >> This way the driver will be probed only once (the reset can be done during
On Wednesday, September 21, 2016 11:06:47 AM CEST Sriram Dash wrote:
>
> Hello Arnd,
>
> We tried this patch on NXP platforms (ls2085 and ls1043) which use dwc3
> controller without any glue layer. On first go, this did not work. But after
> minimal reworks mention snippet below, we are able to
On Wednesday, September 21, 2016 11:43:59 AM CEST Sriram Dash wrote:
> >From: Arnd Bergmann [mailto:a...@arndb.de]
> >On Wednesday, September 21, 2016 11:06:47 AM CEST Sriram Dash wrote:
>
> ===
On Friday, September 23, 2016 5:08:37 PM CEST Greg KH wrote:
> On Fri, Sep 23, 2016 at 09:46:13PM +0800, Baoyou Xie wrote:
> > We get 1 warning when building kernel with W=1:
> > drivers/usb/host/xhci-ring.c:608:6: warning: no previous prototype for
> > 'xhci_unmap_td_bounce_buffer' [-Wmissing-pro
declared here
This warning is harmless, but for consistency, we should make
the check for the return code match what the driver does everywhere
else and just progate it, which then gets rid of the warning.
Signed-off-by: Arnd Bergmann
---
drivers/net/usb/kalmia.c | 2 +-
1 file changed, 1
On Tuesday, October 25, 2016 4:26:28 PM CEST Sriram Dash wrote:
> Do not use dma_coerce_mask_and_coherent for hcd.
>
> Signed-off-by: Arnd Bergmann
The patch is good, but please follow the usual rules for submitting
someone else's patch:
- As the first line, have "From: Arnd
On Tuesday, October 25, 2016 4:26:27 PM CEST Sriram Dash wrote:
> Do not require dma_set_coherent_mask for hcd
>
> Signed-off-by: Arnd Bergmann
Aside from the comments I had for patch 3, you are doing two
different things here:
> diff --git a/drivers/usb/dwc3/dwc3-st.c b/drivers/u
On Thursday, November 10, 2016 1:02:11 PM CET Felipe Balbi wrote:
> > @@ -123,8 +119,8 @@ int dwc3_host_init(struct dwc3 *dwc)
> > void dwc3_host_exit(struct dwc3 *dwc)
> > {
> > phy_remove_lookup(dwc->usb2_generic_phy, "usb2-phy",
> > - dev_name(&dwc->xhci->dev));
> >
ork.kernel.org/patch/9318887/
Signed-off-by: Arnd Bergmann
---
drivers/usb/dwc3/dwc3-pci.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c
index 8c39ec6522fd..771b620b4878 100644
--- a/drivers/usb/dwc3/dwc3
e, so maybe use that instead.
Alternatively, the code could be removed entirely as it does
nothing.
Signed-off-by: Arnd Bergmann
---
This has been present in the driver for a while, but the code
just moved around, so it showed up as a new warning for me.
I hope to eventually address all W=1 warnings
On Wednesday, November 16, 2016 1:17:51 PM CET Felipe Balbi wrote:
> dwc3_pci_dsm() is only needed if (PM || PM_SLEEP),
> we should make sure it's not defined if neither of
> those is defined.
>
> This fixes a randconfig build warning.
>
> Reported-by: Arnd Bergman
On Wednesday, November 16, 2016 1:13:48 PM CET Felipe Balbi wrote:
> Arnd Bergmann writes:
> > A change to the suspend/resume handling in dwc3-pci introduced a
> > harmless warning:
> >
> > drivers/usb/dwc3/dwc3-pci.c:169:12: error: ‘dwc3_pci_dsm’ defined but no
On Thursday, November 17, 2016 1:23:43 PM CET Felipe Balbi wrote:
> Arnd Bergmann writes:
> > Building with W=1, we get a warning about harmless empty statements:
> >
> > drivers/usb/dwc3/ep0.c: In function 'dwc3_ep0_handle_intf':
> > drivers/usb/dwc3/ep0.
On Tuesday 08 December 2015 17:20:46 Peter Chen wrote:
> On Tue, Dec 08, 2015 at 12:30:59AM -0200, Fabio Estevam wrote:
> > On Mon, Dec 7, 2015 at 11:37 PM, Peter Chen
> > wrote:
> > > Add dt-binding documentation for generic onboard USB HUB.
> > >
> > > Signed-off-by: Peter Chen
> > > ---
> > >
On Tuesday 08 December 2015 09:37:48 Peter Chen wrote:
> +struct usb_hub_generic_data {
> + struct clk *clk;
> +};
> +
> +static int usb_hub_generic_probe(struct platform_device *pdev)
> +{
> + struct device *dev = &pdev->dev;
> + struct usb_hub_generic_platform_data *pdata = dev->plat
On Tuesday 08 December 2015 10:50:49 Philipp Zabel wrote:
> Am Dienstag, den 08.12.2015, 09:37 +0800 schrieb Peter Chen:
> > Add dt-binding documentation for generic onboard USB HUB.
> >
> > Signed-off-by: Peter Chen
> > ---
> > .../bindings/usb/generic-onboard-hub.txt | 28
> > ++
On Wednesday 09 December 2015 16:12:24 Peter Chen wrote:
> On Tue, Dec 08, 2015 at 09:24:03PM -0600, Rob Herring wrote:
> > On Tue, Dec 08, 2015 at 10:58:48AM +0100, Arnd Bergmann wrote:
> > > On Tuesday 08 December 2015 10:50:49 Philipp Zabel wrote:
> > > > This som
On Wednesday 09 December 2015 09:57:40 Lucas Stach wrote:
> Am Mittwoch, den 09.12.2015, 16:50 +0800 schrieb Peter Chen:
> > On Tue, Dec 08, 2015 at 08:36:00AM -0700, Mathieu Poirier wrote:
> > > On 7 December 2015 at 18:37, Peter Chen wrote:
> > > > +
> > > > + if (dev->of_node) {
> > > > +
On Monday 14 December 2015 15:26:11 Peter Chen wrote:
> Hi all,
>
> There is a known issue that the USB code can't handle USB HUB's
> external pins well, in that case, it may cause some onboard
> USB HUBs can't work since their PHY's clock or reset pin needs to
> operate.
>
> The user reported th
On Tuesday 15 December 2015 15:54:32 Yoshihiro Shimoda wrote:
> R-Car H3 has USB3.0 peripheral controllers. This controller's has the
> following features:
> - Supports super, high and full speed
> - Contains 30 pipes for bulk or interrupt transfer
> - Contains dedicated DMA controller
>
> This
On Tuesday 15 December 2015 14:45:59 Kishon Vijay Abraham I wrote:
> This series is basically to deprecate using phy-omap-control and use
> syscon APIs to program the control module registers.
>
> Changes from v2:
> No changes.
>
> Changes from v1:
> *) cleanup ti_pipe3_probe in multiple steps
>
On Tuesday 15 December 2015 16:44:41 Kishon Vijay Abraham I wrote:
> Hi Arnd,
>
> On Tuesday 15 December 2015 04:26 PM, Arnd Bergmann wrote:
> > On Tuesday 15 December 2015 14:45:59 Kishon Vijay Abraham I wrote:
> >> This series is basically to deprecate using phy-omap-con
On Wednesday 16 December 2015 02:26:26 Yoshihiro Shimoda wrote:
> Hi Arnd again,
>
> > From: Yoshihiro Shimoda
> > Sent: Wednesday, December 16, 2015 10:43 AM
> < snip >
> > > > +static void usb3_write(struct renesas_usb3 *usb3, u32 data, u32 offs)
> > > > +{
> > > > + iowrite32(data, usb3->
On Wednesday 16 December 2015 16:59:39 Rob Herring wrote:
> On Mon, Dec 14, 2015 at 3:35 AM, Arnd Bergmann wrote:
> > On Monday 14 December 2015 15:26:11 Peter Chen wrote:
>
> I agree on doing it properly, but am not sure that pwrseq binding for
> MMC is proper. The pwrseq
rm-soc/obj-tmp/../include/linux/usb/of.h:23:
first defined here
This patch marks the dummy stub implementation of the function as
'static inline' so we don't get duplicate definitions when the
header gets included multiple times.
Signed-off-by: Arnd Bergmann
Fixes: 98bfb3946695 (&q
intptr_t, not int.
Signed-off-by: Arnd Bergmann
---
I sent this a month ago, here is the same patch again in case it got lost.
diff --git a/drivers/staging/emxx_udc/emxx_udc.c
b/drivers/staging/emxx_udc/emxx_udc.c
index 4e6c16af40fc..c168845cbb91 100644
--- a/drivers/staging/emxx_udc/emxx_udc.c
+++
On Thursday 21 January 2016 11:15:24 Peter Chen wrote:
>
> Just adding from device driver view and change the name from "roohub" to
> "port".
>
> It is the port number (1-9), but not the root hub number.
>
> At the most of embedded platforms, we have only one port per controller.
> For example,
1 - 100 of 637 matches
Mail list logo
