[PATCH] usb: dwc3: of-simple: Fix warning during unbind

2016-09-09 Thread Anurag Kumar Vulisha
(). Signed-off-by: Anurag Kumar Vulisha --- drivers/usb/dwc3/dwc3-of-simple.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/drivers/usb/dwc3/dwc3-of-simple.c index e56d59b..99d8016 100644 --- a/drivers/usb/dwc3/dwc3-of-simple.c +++ b/drivers

[RFC PATCH] xhci: Use Cached ring during endpoint ring allocation

2017-02-22 Thread Anurag Kumar Vulisha
urs due to insufficient memory during ring expansion. Signed-off-by: Anurag Kumar Vulisha --- drivers/usb/host/xhci-mem.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c index 8414ed2..587b6c6 100644 --- a/driver

RE: [PATCH 0/3] usb: gadget: Add support for disabling U1 and U2 entries

2019-05-03 Thread Anurag Kumar Vulisha
Hi Claus, >-Original Message- >From: claus.stovga...@gmail.com [mailto:claus.stovga...@gmail.com] >Sent: Friday, May 03, 2019 3:06 AM >To: Anurag Kumar Vulisha ; Greg Kroah-Hartman >; Rob Herring ; Mark Rutland >; Felipe Balbi >Cc: linux-usb@vger.kernel.org; v.anura

RE: [PATCH v2 3/3] usb: dwc3: gadget: Add support for disabling U1 and U2 entries

2019-05-13 Thread Anurag Kumar Vulisha
Hi Thinh, >-Original Message- >From: Thinh Nguyen [mailto:thinh.ngu...@synopsys.com] >Sent: Saturday, May 11, 2019 7:18 AM >To: Anurag Kumar Vulisha ; Thinh Nguyen >; Greg Kroah-Hartman >; Rob Herring ; Mark Rutland >; Felipe Balbi ; Claus H. Stovgaard > >Cc

[PATCH] usb: dwc3: gadget: Correct the logic for queuing sgs

2018-03-18 Thread Anurag Kumar Vulisha
e correctly fetches the req's which were not queued from the started_list but fails to start from the sg where it previously stopped queuing because of the unavailable TRB's. This patch correct's the code to start queuing from the correct sg in sglist. Signed-off-by: Anurag Kumar Vuli

RE: [PATCH] usb: dwc3: gadget: Correct the logic for queuing sgs

2018-03-19 Thread Anurag Kumar Vulisha
Hi Felipe, Thanks for reviewing the patch , please find my comments inline >-Original Message- >From: Felipe Balbi [mailto:ba...@kernel.org] >Sent: Monday, March 19, 2018 2:21 PM >To: Anurag Kumar Vulisha ; Greg Kroah-Hartman > >Cc: v.anuragku...@gmail.com; Ajay Y

RE: [PATCH] usb: dwc3: gadget: Correct the logic for queuing sgs

2018-03-24 Thread Anurag Kumar Vulisha
Hi Felipe, Thanks for providing your inputs on this patch. Will send v2 with all your suggestions added. Thanks, Anurag Kumar Vulisha >-Original Message- >From: Felipe Balbi [mailto:ba...@kernel.org] >Sent: Friday, March 23, 2018 4:59 PM >To: Anurag Kumar Vulisha ; Greg K

RE: [PATCH v2 1/2] usb: dwc3: gadget: Correct handling of scattergather lists

2018-05-02 Thread Anurag Kumar Vulisha
Hi All, Please let me know if the changes in this patch are okay . If the changes looks fine , can we proceed with this patch. Thanks, Anurag Kumar Vulisha >-Original Message- >From: v.anuragku...@gmail.com [mailto:v.anuragku...@gmail.com] >Sent: Tuesday, March 27, 2018 4:

[LINUX PATCH] usb: xhci: Add toggle cycle bit for the last seg trb when cached ring is used

2017-05-31 Thread Anurag Kumar Vulisha
cached ring last segment. When the controller fetches the last link trb with no toggle bit set, abnormal behaviour is generated. This patch solves that problem by adding the TOGGLE bit for the last trb of the last segment of the cached ring. Signed-off-by: Anurag Kumar Vulisha --- drivers/usb/host

RE: [LINUX PATCH] usb: xhci: Add toggle cycle bit for the last seg trb when cached ring is used

2017-06-01 Thread Anurag Kumar Vulisha
HI Mathias, >-Original Message- >From: Mathias Nyman [mailto:mathias.ny...@linux.intel.com] >Sent: Thursday, June 01, 2017 6:51 PM >To: Anurag Kumar Vulisha ; mathias.ny...@intel.com; >gre...@linuxfoundation.org >Cc: linux-usb@vger.kernel.org; linux-ker...@vger.ke

RE: [PATCH] xhci: remove endpoint ring cache

2017-06-05 Thread Anurag Kumar Vulisha
Hi Mathias, I have tested this patch with my platform and it works fine Thanks, Anurag Kumar Vulisha >-Original Message- >From: Mathias Nyman [mailto:mathias.ny...@linux.intel.com] >Sent: Friday, June 02, 2017 4:51 PM >To: Anurag Kumar Vulisha >Cc: gre...@linuxfoundatio

[PATCH 0/8] fix broken BULK stream support to dwc3 gadget driver

2018-07-25 Thread Anurag Kumar Vulisha
These patch series fixes the broken BULK streaming support in dwc3 gadget driver. Anurag Kumar Vulisha (8): usb: dwc3: Correct the logic for checking TRB full in __dwc3_prepare_one_trb() usb: dwc3: update stream id in depcmd usb: dwc3: make controller clear transfer resources after

[PATCH 2/8] usb: dwc3: update stream id in depcmd

2018-07-25 Thread Anurag Kumar Vulisha
For stream capable endpoints, stream id related information needs to be updated into DEPCMD while issuing START TRANSFER. This patch does the same. Signed-off-by: Anurag Kumar Vulisha --- drivers/usb/dwc3/gadget.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/dwc3/gadget.c

[PATCH 8/8] usb: dwc3: Check MISSED ISOC bit only for ISOC endpoints

2018-07-25 Thread Anurag Kumar Vulisha
When streaming is enabled on BULK endpoints and LST bit is set observed MISSED ISOC bit set in event->status for BULK ep. Since this bit is only valid for isocronous endpoints, changed the code to check for isocrnous endpoints when MISSED ISOC bit is set. Signed-off-by: Anurag Kumar Vuli

[PATCH 6/8] usb: dwc3: check for requests in started list for stream capable endpoints

2018-07-25 Thread Anurag Kumar Vulisha
__dwc3_gadget_kick_transfer() if any. Signed-off-by: Anurag Kumar Vulisha --- drivers/usb/dwc3/gadget.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index af8d470..fe1ea245 100644 --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3

[PATCH 3/8] usb: dwc3: make controller clear transfer resources after complete

2018-07-25 Thread Anurag Kumar Vulisha
the ctrl field of the last TRB. Signed-off-by: Anurag Kumar Vulisha --- drivers/usb/dwc3/gadget.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index efc6e13..b3e9e7f 100644 --- a/drivers/usb/dwc3

[PATCH 4/8] usb: dwc3: implement stream transfer timeout

2018-07-25 Thread Anurag Kumar Vulisha
, device will first stop transfer and restart the transfer again. This patch does the same. Signed-off-by: Anurag Kumar Vulisha --- drivers/usb/dwc3/core.h | 7 +++ drivers/usb/dwc3/gadget.c | 39 +++ 2 files changed, 46 insertions(+) diff --git a/drivers/usb

[PATCH 7/8] usb: dwc3: Check for IOC/LST bit in both event->status and TRB->ctrl fields

2018-07-25 Thread Anurag Kumar Vulisha
t;status is checked for IOC/LST bit and returns on the first TRB. This makes the remaining TRBs left unhandled. To aviod this, changed the code to check for IOC/LST bits in both event->status & TRB->ctrl. This patch does the same. Signed-off-by: Anurag Kumar Vulisha --- drivers/usb/dwc3/ga

[PATCH 1/8] usb: dwc3: Correct the logic for checking TRB full in __dwc3_prepare_one_trb()

2018-07-25 Thread Anurag Kumar Vulisha
() wrongly calculates the present working TRB as free TRB (since HWO bit is not yet set). This patch corrects this issue by setting HWO bit before calling dwc3_calc_trbs_left(). Signed-off-by: Anurag Kumar Vulisha --- drivers/usb/dwc3/gadget.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletion

[PATCH 5/8] usb: dwc3: don't issue no-op trb for stream capable endpoints

2018-07-25 Thread Anurag Kumar Vulisha
The stream capable endpoints require stream id to be given when issuing START TRANSFER. While issuing no-op trb the stream id is not yet known, so don't issue no-op trb's on stream capable endpoints. Signed-off-by: Anurag Kumar Vulisha --- drivers/usb/dwc3/gadget.c | 2 +- 1 file

RE: [PATCH 4/8] usb: dwc3: implement stream transfer timeout

2018-07-25 Thread Anurag Kumar Vulisha
Hi Andy, Thanks for your review comments, please find my comments inline >-Original Message- >From: Andy Shevchenko [mailto:andy.shevche...@gmail.com] >Sent: Wednesday, July 25, 2018 8:36 PM >To: Anurag Kumar Vulisha >Cc: Felipe Balbi ; Greg Kroah-Hartman >; v.anu

RE: [PATCH 4/8] usb: dwc3: implement stream transfer timeout

2018-07-25 Thread Anurag Kumar Vulisha
>-Original Message- >From: Andy Shevchenko [mailto:andy.shevche...@gmail.com] >Sent: Wednesday, July 25, 2018 8:55 PM >To: Anurag Kumar Vulisha >Cc: Felipe Balbi ; Greg Kroah-Hartman >; v.anuragku...@gmail.com; USB u...@vger.kernel.org>; Linux Kernel Mailing List &

RE: [PATCH v2 0/8] usb: dwc3: Fix broken BULK stream support to dwc3 gadget driver

2018-09-04 Thread Anurag Kumar Vulisha
Hi All, Ping! Just thought of giving a friendly remainder for this patch series. Does these patches looks okay, can we proceed with them? Please provide me your valuable suggestions. Thanks, Anurag Kumar Vulisha >-Original Message- >From: Anurag Kumar Vulisha [mailto:anurag.kuma

RE: [PATCH v2 1/8] usb: dwc3: Correct the logic for checking TRB full in __dwc3_prepare_one_trb()

2018-09-05 Thread Anurag Kumar Vulisha
Hi Thinh, Thanks for spending your time in reviewing this code, please find my comments inline >-Original Message- >From: Thinh Nguyen [mailto:thinh.ngu...@synopsys.com] >Sent: Wednesday, September 05, 2018 11:04 AM >To: Anurag Kumar Vulisha ; ba...@kern

RE: [PATCH v2 3/8] usb: dwc3: make controller clear transfer resources after complete

2018-09-05 Thread Anurag Kumar Vulisha
} >> >> switch (event->endpoint_event) { >> +case DWC3_DEPEVT_XFERCOMPLETE: >> +if (!dep->stream_capable) >> +break; >> +dep->flags &= ~DWC3_EP_TRANSFER_STARTED; > Add this: /* Falls Through */ Thanks for c

RE: [PATCH v2 4/8] usb: dwc3: implement stream transfer timeout

2018-09-05 Thread Anurag Kumar Vulisha
timer); >> +break; >> +case DEPEVT_STREAMEVT_NOTFOUND: >> +default: >> +dev_err(dwc->dev, "unable to find suitable stream"); >> + } >Add break after this. Also, it's

RE: [PATCH v2 1/8] usb: dwc3: Correct the logic for checking TRB full in __dwc3_prepare_one_trb()

2018-09-06 Thread Anurag Kumar Vulisha
Hi Thinh, >-Original Message- >From: Thinh Nguyen [mailto:thinh.ngu...@synopsys.com] >Sent: Thursday, September 06, 2018 7:28 AM >To: Anurag Kumar Vulisha ; Thinh Nguyen >; ba...@kernel.org; gre...@linuxfoundation.org >Cc: v.anuragku...@gmail.com; linux-usb@vger.kerne

[PATCH v3 3/8] usb: dwc3: make controller clear transfer resources after complete

2018-09-07 Thread Anurag Kumar Vulisha
the ctrl field of the last TRB. Signed-off-by: Anurag Kumar Vulisha Reviewed-by: Thinh Nguyen --- Changes in v3: 1. Added the changes suggested by "Thinh Nguyen" Changes in v2: 1. None --- drivers/usb/dwc3/gadget.c | 20 +--- 1 file changed, 17 insert

[PATCH v3 2/8] usb: dwc3: update stream id in depcmd

2018-09-07 Thread Anurag Kumar Vulisha
For stream capable endpoints, stream id related information needs to be updated into DEPCMD while issuing START TRANSFER. This patch does the same. Signed-off-by: Anurag Kumar Vulisha Reviewed-by: Thinh Nguyen --- Changes in v3: 1. None Changes in v2: 1. None --- drivers/usb

[PATCH v3 8/8] usb: dwc3: Check MISSED ISOC bit only for ISOC endpoints

2018-09-07 Thread Anurag Kumar Vulisha
When streaming is enabled on BULK endpoints and LST bit is set observed MISSED ISOC bit set in event->status for BULK ep. Since this bit is only valid for isocronous endpoints, changed the code to check for isocrnous endpoints when MISSED ISOC bit is set. Signed-off-by: Anurag Kumar Vuli

[PATCH v3 4/8] usb: dwc3: implement stream transfer timeout

2018-09-07 Thread Anurag Kumar Vulisha
, device will first stop transfer and restart the transfer again. This patch does the same. Signed-off-by: Anurag Kumar Vulisha Reviewed-by: Thinh Nguyen --- Changes in v3: 1. Added the changes suggested by "Thinh Nguyen" Changes in v2: 1. Changed STREAM_TIMEOUT to STREAM_

[PATCH v3 0/8] usb: dwc3: Fix broken BULK stream support to dwc3 gadget driver

2018-09-07 Thread Anurag Kumar Vulisha
These patch series fixes the broken BULK streaming support in dwc3 gadget driver. Changes in v3: 1. Added the changes suggested by "Thinh Nguyen" Changes in v2: 1. Added "usb: dwc3:" in subject heading Anurag Kumar Vulisha (8): usb: dwc3: Correct the lo

[PATCH v3 6/8] usb: dwc3: check for requests in started list for stream capable endpoints

2018-09-07 Thread Anurag Kumar Vulisha
__dwc3_gadget_kick_transfer() if any. Signed-off-by: Anurag Kumar Vulisha Reviewed-by: Thinh Nguyen --- Changes in v3: 1. None Changes in v2: 1. None --- drivers/usb/dwc3/gadget.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3

[PATCH v3 7/8] usb: dwc3: Check for IOC/LST bit in both event->status and TRB->ctrl fields

2018-09-07 Thread Anurag Kumar Vulisha
t;status is checked for IOC/LST bit and returns on the first TRB. This makes the remaining TRBs left unhandled. To aviod this, changed the code to check for IOC/LST bits in both event->status & TRB->ctrl. This patch does the same. Signed-off-by: Anurag Kumar Vulisha Reviewed-by: Thinh Nguye

[PATCH v3 5/8] usb: dwc3: don't issue no-op trb for stream capable endpoints

2018-09-07 Thread Anurag Kumar Vulisha
The stream capable endpoints require stream id to be given when issuing START TRANSFER. While issuing no-op trb the stream id is not yet known, so don't issue no-op trb's on stream capable endpoints. Signed-off-by: Anurag Kumar Vulisha Reviewed-by: Thinh Nguyen --- Changes in v3:

[PATCH v3 1/8] usb: dwc3: Correct the logic for checking TRB full in __dwc3_prepare_one_trb()

2018-09-07 Thread Anurag Kumar Vulisha
B as free(since the HWO bit is not yet set). This could be a problem. This patch correct this issue by setting HWO bit before calling dwc3_calc_trbs_left() Signed-off-by: Anurag Kumar Vulisha Reviewed-by: Thinh Nguyen --- Changes in v3: 1. Corrected the logic for setting HWO bit as sugg

RE: [PATCH v3 4/8] usb: dwc3: implement stream transfer timeout

2018-09-07 Thread Anurag Kumar Vulisha
when there's a deadlock >rather >than to avoid it. You probably need to explain what deadlock it is if you >mentioned it >here, but I think it's ok to simply say timeout timer for streams (unless >Felipe has any >objection). Thanks for correcting again , will fix it in the next version of patch, Thanks, Anurag Kumar Vulisha

RE: [PATCH v3 1/8] usb: dwc3: Correct the logic for checking TRB full in __dwc3_prepare_one_trb()

2018-09-07 Thread Anurag Kumar Vulisha
Hi Thinh, >On 9/7/2018 6:14 AM, Anurag Kumar Vulisha wrote: >> Availability of TRB's are calculated using dwc3_calc_trbs_left(), >> which determines available TRB's based on the HWO bit set in a TRB. >> >> __dwc3_prepare_one_trb() is called with a TRB which

[PATCH v4 6/8] usb: dwc3: check for requests in started list for stream capable endpoints

2018-09-08 Thread Anurag Kumar Vulisha
__dwc3_gadget_kick_transfer() if any. Signed-off-by: Anurag Kumar Vulisha Reviewed-by: Thinh Nguyen --- Changes in v4: 1. None Changes in v3: 1. None Changes in v2: 1. None --- drivers/usb/dwc3/gadget.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb

[PATCH v4 2/8] usb: dwc3: update stream id in depcmd

2018-09-08 Thread Anurag Kumar Vulisha
For stream capable endpoints, stream id related information needs to be updated into DEPCMD while issuing START TRANSFER. This patch does the same. Signed-off-by: Anurag Kumar Vulisha Reviewed-by: Thinh Nguyen --- Changes in v4: 1. None Changes in v3: 1. None Changes in v2

[PATCH v4 5/8] usb: dwc3: don't issue no-op trb for stream capable endpoints

2018-09-08 Thread Anurag Kumar Vulisha
The stream capable endpoints require stream id to be given when issuing START TRANSFER. While issuing no-op trb the stream id is not yet known, so don't issue no-op trb's on stream capable endpoints. Signed-off-by: Anurag Kumar Vulisha Reviewed-by: Thinh Nguyen --- Changes in v4:

[PATCH v4 8/8] usb: dwc3: Check MISSED ISOC bit only for ISOC endpoints

2018-09-08 Thread Anurag Kumar Vulisha
When streaming is enabled on BULK endpoints and LST bit is set observed MISSED ISOC bit set in event->status for BULK ep. Since this bit is only valid for isocronous endpoints, changed the code to check for isocrnous endpoints when MISSED ISOC bit is set. Signed-off-by: Anurag Kumar Vuli

[PATCH v4 7/8] usb: dwc3: Check for IOC/LST bit in both event->status and TRB->ctrl fields

2018-09-08 Thread Anurag Kumar Vulisha
t;status is checked for IOC/LST bit and returns on the first TRB. This makes the remaining TRBs left unhandled. To aviod this, changed the code to check for IOC/LST bits in both event->status & TRB->ctrl. This patch does the same. Signed-off-by: Anurag Kumar Vulisha Reviewed-by: Thinh Nguye

[PATCH v4 1/8] usb: dwc3: Correct the logic for checking TRB full in __dwc3_prepare_one_trb()

2018-09-08 Thread Anurag Kumar Vulisha
t working TRB is also considered as available by dwc3_calc_trbs_left() and non zero value is returned . So, according to the modified logic, when the total available TRBs is equal to 1 that means the total available TRBs in the pool are 0. Signed-off-by: Anurag Kumar Vulisha Reviewed-by: Thinh Nguye

[PATCH v4 3/8] usb: dwc3: make controller clear transfer resources after complete

2018-09-08 Thread Anurag Kumar Vulisha
the ctrl field of the last TRB. Signed-off-by: Anurag Kumar Vulisha Reviewed-by: Thinh Nguyen --- Changes in v4: 1. None Changes in v3: 1. Added the changes suggested by "Thinh Nguyen" Changes in v2: 1. None --- drivers/usb/dwc3/gadget.c | 20 +

[PATCH v4 4/8] usb: dwc3: implement stream transfer timeout

2018-09-08 Thread Anurag Kumar Vulisha
, device will first stop transfer and restart the transfer again. This patch does the same. Signed-off-by: Anurag Kumar Vulisha Reviewed-by: Thinh Nguyen --- Chnages in v4: 1. Added description for stream timeout timer as suggested by "Thinh Nguyen" Changes in v3:

[PATCH v4 0/8] usb: dwc3: Fix broken BULK stream support to dwc3 gadget driver

2018-09-08 Thread Anurag Kumar Vulisha
quot; Changes in v2: 1. Added "usb: dwc3:" in subject heading Anurag Kumar Vulisha (8): usb: dwc3: Correct the logic for checking TRB full in __dwc3_prepare_one_trb() usb: dwc3: update stream id in depcmd usb: dwc3: make controller clear transfer resources after c

RE: [PATCH v4 4/8] usb: dwc3: implement stream transfer timeout

2018-09-15 Thread Anurag Kumar Vulisha
k Felipe will accept adding new dev_dbg() >after removing >all of them and converting them to tracepoints. > I agree with you, thanks for correcting. Will remove the debug prints and resend the patches Thanks, Anurag Kumar Vulisha

[PATCH v5 2/8] usb: dwc3: update stream id in depcmd

2018-09-15 Thread Anurag Kumar Vulisha
For stream capable endpoints, stream id related information needs to be updated into DEPCMD while issuing START TRANSFER. This patch does the same. Signed-off-by: Anurag Kumar Vulisha Reviewed-by: Thinh Nguyen --- Changes in v5: 1. None Changes in v4: 1. None Changes in v3

[PATCH v5 3/8] usb: dwc3: make controller clear transfer resources after complete

2018-09-15 Thread Anurag Kumar Vulisha
the ctrl field of the last TRB. Signed-off-by: Anurag Kumar Vulisha Reviewed-by: Thinh Nguyen --- Changes in v5: 1. None Changes in v4: 1. None Changes in v3: 1. Added the changes suggested by "Thinh Nguyen" Changes in v2: 1. None --- driver

[PATCH v5 0/8] usb: dwc3: Fix broken BULK stream support to dwc3 gadget driver

2018-09-15 Thread Anurag Kumar Vulisha
ot;Thinh Nguyen" Changes in v3: 1. Added the changes suggested by "Thinh Nguyen" Changes in v2: 1. Added "usb: dwc3:" in subject heading Anurag Kumar Vulisha (8): usb: dwc3: Correct the logic for checking TRB full in __dwc3_prepare_one_trb() usb: dwc3

[PATCH v5 1/8] usb: dwc3: Correct the logic for checking TRB full in __dwc3_prepare_one_trb()

2018-09-15 Thread Anurag Kumar Vulisha
t working TRB is also considered as available by dwc3_calc_trbs_left() and non zero value is returned . So, according to the modified logic, when the total available TRBs is equal to 1 that means the total available TRBs in the pool are 0. Signed-off-by: Anurag Kumar Vulisha Reviewed-by: Thinh Nguye

[PATCH v5 6/8] usb: dwc3: check for requests in started list for stream capable endpoints

2018-09-15 Thread Anurag Kumar Vulisha
__dwc3_gadget_kick_transfer() if any. Signed-off-by: Anurag Kumar Vulisha Reviewed-by: Thinh Nguyen --- Changes in v5: 1. None Changes in v4: 1. None Changes in v3: 1. None Changes in v2: 1. None --- drivers/usb/dwc3/gadget.c | 3 +++ 1 file changed, 3

[PATCH v5 8/8] usb: dwc3: Check MISSED ISOC bit only for ISOC endpoints

2018-09-15 Thread Anurag Kumar Vulisha
When streaming is enabled on BULK endpoints and LST bit is set observed MISSED ISOC bit set in event->status for BULK ep. Since this bit is only valid for isocronous endpoints, changed the code to check for isocrnous endpoints when MISSED ISOC bit is set. Signed-off-by: Anurag Kumar Vuli

[PATCH v5 7/8] usb: dwc3: Check for IOC/LST bit in both event->status and TRB->ctrl fields

2018-09-15 Thread Anurag Kumar Vulisha
t;status is checked for IOC/LST bit and returns on the first TRB. This makes the remaining TRBs left unhandled. To aviod this, changed the code to check for IOC/LST bits in both event->status & TRB->ctrl. This patch does the same. Signed-off-by: Anurag Kumar Vulisha Reviewed-by: Thinh Nguye

[PATCH v5 5/8] usb: dwc3: don't issue no-op trb for stream capable endpoints

2018-09-15 Thread Anurag Kumar Vulisha
The stream capable endpoints require stream id to be given when issuing START TRANSFER. While issuing no-op trb the stream id is not yet known, so don't issue no-op trb's on stream capable endpoints. Signed-off-by: Anurag Kumar Vulisha Reviewed-by: Thinh Nguyen --- changes in v5:

[PATCH v5 4/8] usb: dwc3: implement stream transfer timeout

2018-09-15 Thread Anurag Kumar Vulisha
, device will first stop transfer and restart the transfer again. This patch does the same. Signed-off-by: Anurag Kumar Vulisha Reviewed-by: Thinh Nguyen --- Changes in v5: 1. Removed dev_dbg prints as suggested by "Thinh Nguyen" Chnages in v4: 1. Added description for stre

RE: [PATCH v5 0/8] usb: dwc3: Fix broken BULK stream support to dwc3 gadget driver

2018-09-21 Thread Anurag Kumar Vulisha
Hi Tejas, >-Original Message- >From: Tejas Joglekar [mailto:tejas.jogle...@synopsys.com] >Sent: Friday, September 21, 2018 7:01 PM >To: Anurag Kumar Vulisha ; ba...@kernel.org; >gre...@linuxfoundation.org >Cc: v.anuragku...@gmail.com; linux-usb@vger.kerne

[PATCH] usb: host: xhci: Find usb-phy by phandle if of_node not supported

2018-10-03 Thread Anurag Kumar Vulisha
e existing devm_usb_get_phy_by_phandle() doesn't find the "usb-phy" and returns -ENODEV. This patch modifies the code to search for usb phy in of_node if "usb-phy" phandle is not found in sysdev. Signed-off-by: Anurag Kumar Vulisha --- drivers/usb/host/xhci-plat.c | 4 1 file cha

[PATCH] usb: host: xhci: Set the controller as wakeup capable

2018-10-03 Thread Anurag Kumar Vulisha
This patch modifies the xhci_plat_probe() to set the controller as wakeup capable if "wakeup-source" is added into the device node. Signed-off-by: Anurag Kumar Vulisha --- drivers/usb/host/xhci-plat.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/usb/host/xhci-plat.c

RE: [PATCH v5 0/8] usb: dwc3: Fix broken BULK stream support to dwc3 gadget driver

2018-10-08 Thread Anurag Kumar Vulisha
Hi Felipe, Please let us know if you have any suggestions / comments on this patch series. If you feel this patch series are okay, can we proceed with them? Thanks, Anurag Kumar Vulisha >-Original Message- >From: Anurag Kumar Vulisha [mailto:anurag.kumar.vuli...@xilinx.com]

RE: [PATCH v5 0/8] usb: dwc3: Fix broken BULK stream support to dwc3 gadget driver

2018-10-08 Thread Anurag Kumar Vulisha
Hi Felipe, >-Original Message- >From: Felipe Balbi [mailto:ba...@kernel.org] >Sent: Tuesday, October 09, 2018 11:07 AM >To: Anurag Kumar Vulisha ; Anurag Kumar Vulisha >; gre...@linuxfoundation.org >Cc: v.anuragku...@gmail.com; linux-usb@vger.kernel.org; linux- >k

RE: [PATCH v5 0/8] usb: dwc3: Fix broken BULK stream support to dwc3 gadget driver

2018-10-09 Thread Anurag Kumar Vulisha
Hi Felipe, >-Original Message- >From: Felipe Balbi [mailto:ba...@kernel.org] >Sent: Tuesday, October 09, 2018 12:51 PM >To: Anurag Kumar Vulisha ; gre...@linuxfoundation.org >Cc: v.anuragku...@gmail.com; linux-usb@vger.kernel.org; linux- >ker...@vger.ker

[PATCH V6 05/10] usb: dwc3: make controller clear transfer resources after complete

2018-10-13 Thread Anurag Kumar Vulisha
the ctrl field of the last TRB. Signed-off-by: Anurag Kumar Vulisha --- Changes in v6: 1. Used dep->endpoint.stream_capable instead of dep->stream_capable flag Changes in v5: 1. None Changes in v4: 1. None Changes in v3: 1. Added the c

[PATCH V6 02/10] usb: dwc3: gadget: Add stream timeout handler for avoiding deadlock

2018-10-13 Thread Anurag Kumar Vulisha
adlock is avoided. Signed-off-by: Anurag Kumar Vulisha --- Changes in v6: 1. This patch is newly added in this series --- drivers/usb/dwc3/gadget.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index 0

[PATCH V6 10/10] usb: dwc3: Check MISSED ISOC bit only for ISOC endpoints

2018-10-13 Thread Anurag Kumar Vulisha
When streaming is enabled on BULK endpoints and LST bit is set observed MISSED ISOC bit set in event->status for BULK ep. Since this bit is only valid for isocronous endpoints, changed the code to check for isocrnous endpoints when MISSED ISOC bit is set. Signed-off-by: Anurag Kumar Vuli

[PATCH V6 03/10] usb: dwc3: gadget: Remove references to dep->stream_capable

2018-10-13 Thread Anurag Kumar Vulisha
As a part of adding stream timeout timer for stream capable endpoints stream_capable flag is added into struct usb_ep. Replace the usage of dep->stream_capable in with usb_ep->stream_capable. Signed-off-by: Anurag Kumar Vulisha --- Changes in v6: 1. This patch is newly added i

[PATCH V6 07/10] usb: dwc3: check for requests in started list for stream capable endpoints

2018-10-13 Thread Anurag Kumar Vulisha
__dwc3_gadget_kick_transfer() if any. Signed-off-by: Anurag Kumar Vulisha --- Changes in v6: 1. Replaced dep->stream_capable with dep->endpoint.stream_caapable Changes in v5: 1. None Changes in v4: 1. None Changes in v3: 1. None Changes in v2: 1

[PATCH V6 01/10] usb: gadget: udc: Add timer for stream capable endpoints

2018-10-13 Thread Anurag Kumar Vulisha
endpoint ops->stream_timeout API would be called, so that the gadget driver can handle this situation. This kind of behaviour is observed in dwc3 controller and expected to be generic issue with other controllers supporting bulk streams also. Signed-off-by: Anurag Kumar Vulisha --- Changes in

[PATCH V6 09/10] usb: dwc3: Check for IOC/LST bit in both event->status and TRB->ctrl fields

2018-10-13 Thread Anurag Kumar Vulisha
t;status is checked for IOC/LST bit and returns on the first TRB. This makes the remaining TRBs left unhandled. To aviod this, changed the code to check for IOC/LST bits in both event->status & TRB->ctrl. This patch does the same. Signed-off-by: Anurag Kumar Vulisha Reviewed-by: Thinh Ngu

[PATCH V6 04/10] usb: dwc3: update stream id in depcmd

2018-10-13 Thread Anurag Kumar Vulisha
For stream capable endpoints, stream id related information needs to be updated into DEPCMD while issuing START TRANSFER. This patch does the same. Signed-off-by: Anurag Kumar Vulisha --- Changes in v6: 1. Used dep->endpoint.stream_capable instead of dep->stream_capable

[PATCH V6 08/10] usb: dwc3: Correct the logic for checking TRB full in __dwc3_prepare_one_trb()

2018-10-13 Thread Anurag Kumar Vulisha
t working TRB is also considered as available by dwc3_calc_trbs_left() and non zero value is returned . So, according to the modified logic, when the total available TRBs is equal to 1 that means the total available TRBs in the pool are 0. Signed-off-by: Anurag Kumar Vulisha Reviewed-by: Thinh Ngu

[PATCH V6 08/10] usb: dwc3: Correct the logic for checking TRB full in __dwc3_prepare_one_trb()

2018-10-13 Thread Anurag Kumar Vulisha
t working TRB is also considered as available by dwc3_calc_trbs_left() and non zero value is returned . So, according to the modified logic, when the total available TRBs is equal to 1 that means the total available TRBs in the pool are 0. Signed-off-by: Anurag Kumar Vulisha Reviewed-by: Thinh Ngu

[PATCH V6 00/10] usb: dwc3: Fix broken BULK stream support to dwc3 gadget driver

2018-10-13 Thread Anurag Kumar Vulisha
ges suggested by "Thinh Nguyen" Changes in v2: 1. Added "usb: dwc3:" in subject heading Anurag Kumar Vulisha (10): usb: gadget: udc: Add timer for stream capable endpoints usb: dwc3: gadget: Add stream timeout handler for avoiding deadlock usb: dwc3: gadget: Remove ref

[PATCH V6 06/10] usb: dwc3: don't issue no-op trb for stream capable endpoints

2018-10-13 Thread Anurag Kumar Vulisha
The stream capable endpoints require stream id to be given when issuing START TRANSFER. While issuing no-op trb the stream id is not yet known, so don't issue no-op trb's on stream capable endpoints. Signed-off-by: Anurag Kumar Vulisha --- Chnages in v6: 1. Replaced dep->s

RE: [PATCH V6 00/10] usb: dwc3: Fix broken BULK stream support to dwc3 gadget driver

2018-11-11 Thread Anurag Kumar Vulisha
Hi Felipe, Please let me know if you have any comments on this patch series. If you think patches are good, can we proceed with them ? Thanks, Anurag Kumar Vulisha >-Original Message- >From: Anurag Kumar Vulisha [mailto:anurag.kumar.vuli...@xilinx.com] >Sent: Saturday, October

RE: [PATCH V6 01/10] usb: gadget: udc: Add timer for stream capable endpoints

2018-11-28 Thread Anurag Kumar Vulisha
Hi Felipe, Thanks a lot for spending your time in reviewing this patch. Please find my comments inline >-Original Message- >From: Felipe Balbi [mailto:ba...@kernel.org] >Sent: Wednesday, November 14, 2018 7:28 PM >To: Anurag Kumar Vulisha ; Greg Kroah-Hartman >; Ala

RE: [PATCH V6 01/10] usb: gadget: udc: Add timer for stream capable endpoints

2018-11-29 Thread Anurag Kumar Vulisha
Hi Felipe, >-Original Message- >From: Felipe Balbi [mailto:ba...@kernel.org] >Sent: Thursday, November 29, 2018 6:22 PM >To: Anurag Kumar Vulisha ; Greg Kroah-Hartman >; Alan Stern ; Johan >Hovold ; Jaejoong Kim ; Benjamin >Herrenschmidt ; Roger Quadros >Cc: l

[PATCH v7 08/10] usb: dwc3: Correct the logic for checking TRB full in __dwc3_prepare_one_trb()

2018-12-01 Thread Anurag Kumar Vulisha
t working TRB is also considered as available by dwc3_calc_trbs_left() and non zero value is returned . So, according to the modified logic, when the total available TRBs is equal to 1 that means the total available TRBs in the pool are 0. Signed-off-by: Anurag Kumar Vulisha Reviewed-by: Thinh Ngu

[PATCH v7 03/10] usb: dwc3: gadget: handle stream events

2018-12-01 Thread Anurag Kumar Vulisha
delete the pending timer for the request matching the streamid found in the event. Signed-off-by: Anurag Kumar Vulisha --- Changes in v7: 1. This patch is newly added into this series --- drivers/usb/dwc3/gadget.c | 25 + 1 file changed, 25 insertions(+) diff --git a

[PATCH v7 02/10] usb: gadget: function: tcm: Add timeout for stream capable endpoints

2018-12-01 Thread Anurag Kumar Vulisha
expected to be generic issue with other controllers supporting bulk streams. Signed-off-by: Anurag Kumar Vulisha --- Changes in v7: 1. This patch is newly added in this series --- drivers/usb/gadget/function/f_tcm.c | 25 ++--- 1 file changed, 18 insertions(+), 7

[PATCH v7 00/10] usb: dwc3: Fix broken BULK stream support to dwc3 gadget driver

2018-12-01 Thread Anurag Kumar Vulisha
yen" Changes in v3: 1. Added the changes suggested by "Thinh Nguyen" Changes in v2: 1. Added "usb: dwc3:" in subject heading Anurag Kumar Vulisha (10): usb: gadget: udc: Add timer support for usb requests usb: gadget: function: tcm: Add timeout for stre

[PATCH v7 05/10] usb: dwc3: make controller clear transfer resources after complete

2018-12-01 Thread Anurag Kumar Vulisha
the ctrl field of the last TRB. Signed-off-by: Anurag Kumar Vulisha --- Changes in v7: 1. Reverted to dep->stream_capable from dep->endpoint.stream_capable Changes in v6: 1. Used dep->endpoint.stream_capable instead of dep->stream_capable flag C

[PATCH v7 01/10] usb: gadget: udc: Add timer support for usb requests

2018-12-01 Thread Anurag Kumar Vulisha
avoiding deadlocks. This kind of behaviour is observed in dwc3 controller and expected to be generic issue with other controllers supporting bulk streams. Signed-off-by: Anurag Kumar Vulisha --- Changes in v7: 1. Added usb_ep_dequeue() & usb_ep_queue() logic into the timeout han

[PATCH v7 06/10] usb: dwc3: don't issue no-op trb for stream capable endpoints

2018-12-01 Thread Anurag Kumar Vulisha
The stream capable endpoints require stream id to be given when issuing START TRANSFER. While issuing no-op trb the stream id is not yet known, so don't issue no-op trb's on stream capable endpoints. Signed-off-by: Anurag Kumar Vulisha --- Changes in v7: 1. Rever

[PATCH v7 07/10] usb: dwc3: check for requests in started list for stream capable endpoints

2018-12-01 Thread Anurag Kumar Vulisha
__dwc3_gadget_kick_transfer() if any. Signed-off-by: Anurag Kumar Vulisha --- Changes in v7: 1. Reverted to dep->stream_capable from dep->endpoint.stream_caapable Changes in v6: 1. Replaced dep->stream_capable with dep->endpoint.stream_caapable Changes in v5:

[PATCH v7 10/10] usb: dwc3: Check MISSED ISOC bit only for ISOC endpoints

2018-12-01 Thread Anurag Kumar Vulisha
When streaming is enabled on BULK endpoints and LST bit is set observed MISSED ISOC bit set in event->status for BULK ep. Since this bit is only valid for isocronous endpoints, changed the code to check for isocrnous endpoints when MISSED ISOC bit is set. Signed-off-by: Anurag Kumar Vuli

[PATCH v7 04/10] usb: dwc3: update stream id in depcmd

2018-12-01 Thread Anurag Kumar Vulisha
For stream capable endpoints, stream id related information needs to be updated into DEPCMD while issuing START TRANSFER. This patch does the same. Signed-off-by: Anurag Kumar Vulisha --- Changes in v7: 1. Reverted to dep->stream_capable from dep->endpoint.stream_capable Changes

[PATCH v7 09/10] usb: dwc3: Check for IOC/LST bit in both event->status and TRB->ctrl fields

2018-12-01 Thread Anurag Kumar Vulisha
t;status is checked for IOC/LST bit and returns on the first TRB. This makes the remaining TRBs left unhandled. To aviod this, changed the code to check for IOC/LST bits in both event->status & TRB->ctrl. This patch does the same. Signed-off-by: Anurag Kumar Vulisha Reviewed-by: Thinh Ngu

RE: [PATCH v7 01/10] usb: gadget: udc: Add timer support for usb requests

2018-12-03 Thread Anurag Kumar Vulisha
Hi Alan, >-Original Message- >From: Alan Stern [mailto:st...@rowland.harvard.edu] >Sent: Sunday, December 02, 2018 10:06 PM >To: Anurag Kumar Vulisha >Cc: Felipe Balbi ; Greg Kroah-Hartman >; Shuah Khan ; Johan Hovold >; Jaejoong Kim ; Benjamin >Herrenschmid

RE: [PATCH v7 01/10] usb: gadget: udc: Add timer support for usb requests

2018-12-03 Thread Anurag Kumar Vulisha
Hi Alan, >-Original Message- >From: Alan Stern [mailto:st...@rowland.harvard.edu] >Sent: Monday, December 03, 2018 8:21 PM >To: Anurag Kumar Vulisha >Cc: Felipe Balbi ; Greg Kroah-Hartman >; Shuah Khan ; Johan Hovold >; Jaejoong Kim ; Benjamin >Herrenschmid

RE: [PATCH v7 01/10] usb: gadget: udc: Add timer support for usb requests

2018-12-04 Thread Anurag Kumar Vulisha
Hi Alan, >-Original Message- >From: Alan Stern [mailto:st...@rowland.harvard.edu] >Sent: Tuesday, December 04, 2018 4:38 AM >To: Anurag Kumar Vulisha >Cc: Felipe Balbi ; Greg Kroah-Hartman >; Shuah Khan ; Johan Hovold >; Jaejoong Kim ; Benjamin >Herrenschmid

RE: [PATCH v7 01/10] usb: gadget: udc: Add timer support for usb requests

2018-12-04 Thread Anurag Kumar Vulisha
Hi Alan, >-Original Message- >From: Alan Stern [mailto:st...@rowland.harvard.edu] >Sent: Tuesday, December 04, 2018 10:17 PM >To: Anurag Kumar Vulisha >Cc: Felipe Balbi ; Greg Kroah-Hartman >; Shuah Khan ; Johan Hovold >; Jaejoong Kim ; Benjamin >Herrenschmid

RE: [PATCH v7 01/10] usb: gadget: udc: Add timer support for usb requests

2018-12-05 Thread Anurag Kumar Vulisha
Hi Alan, >-Original Message- >From: Alan Stern [mailto:st...@rowland.harvard.edu] >Sent: Wednesday, December 05, 2018 12:59 AM >To: Anurag Kumar Vulisha >Cc: Felipe Balbi ; Greg Kroah-Hartman >; Shuah Khan ; Johan Hovold >; Jaejoong Kim ; Benjamin >Herrenschmid

RE: [PATCH v7 09/10] usb: dwc3: Check for IOC/LST bit in both event->status and TRB->ctrl fields

2018-12-05 Thread Anurag Kumar Vulisha
Hi Felipe, >-Original Message- >From: Felipe Balbi [mailto:ba...@kernel.org] >Sent: Wednesday, December 05, 2018 2:38 PM >To: Anurag Kumar Vulisha ; Greg Kroah-Hartman >; Shuah Khan ; Alan Stern >; Johan Hovold ; Jaejoong Kim >; Benjamin Herrenschmidt ; >Rog

RE: [PATCH v7 05/10] usb: dwc3: make controller clear transfer resources after complete

2018-12-05 Thread Anurag Kumar Vulisha
HI Felipe, >-Original Message- >From: Felipe Balbi [mailto:ba...@kernel.org] >Sent: Wednesday, December 05, 2018 2:32 PM >To: Anurag Kumar Vulisha ; Greg Kroah-Hartman >; Shuah Khan ; Alan Stern >; Johan Hovold ; Jaejoong Kim >; Benjamin Herrenschmidt ; >Rog

RE: [PATCH v7 09/10] usb: dwc3: Check for IOC/LST bit in both event->status and TRB->ctrl fields

2018-12-08 Thread Anurag Kumar Vulisha
HI Felipe, >-Original Message- >From: Felipe Balbi [mailto:ba...@kernel.org] >Sent: Friday, December 07, 2018 11:42 AM >To: Anurag Kumar Vulisha ; Greg Kroah-Hartman >; Shuah Khan ; Alan Stern >; Johan Hovold ; Jaejoong Kim >; Benjamin Herrenschmidt ; >Rog

RE: [PATCH v7 09/10] usb: dwc3: Check for IOC/LST bit in both event->status and TRB->ctrl fields

2018-12-10 Thread Anurag Kumar Vulisha
Hi Felipe, >-Original Message- >From: Felipe Balbi [mailto:ba...@kernel.org] >Sent: Monday, December 10, 2018 12:24 PM >To: Anurag Kumar Vulisha ; Greg Kroah-Hartman >; Shuah Khan ; Alan Stern >; Johan Hovold ; Jaejoong Kim >; Benjamin Herrenschmidt ; >Rog

RE: [PATCH v7 01/10] usb: gadget: udc: Add timer support for usb requests

2018-12-12 Thread Anurag Kumar Vulisha
Hi Felipe, >-Original Message- >From: Alan Stern [mailto:st...@rowland.harvard.edu] >Sent: Friday, December 07, 2018 10:40 PM >To: Felipe Balbi >Cc: Anurag Kumar Vulisha ; Greg Kroah-Hartman >; Shuah Khan ; Johan Hovold >; Jaejoong Kim ; Benjamin >Herrenschmid

RE: [PATCH v7 01/10] usb: gadget: udc: Add timer support for usb requests

2019-01-04 Thread Anurag Kumar Vulisha
Hi Felipe, Resending... Since I am waiting on your suggestion, thought of giving remainder. Thanks, Anurag Kumar Vulisha >-Original Message- >From: Anurag Kumar Vulisha >Sent: Wednesday, December 12, 2018 8:41 PM >To: 'Alan Stern' ; Felipe Balbi >Cc: Greg K

  1   2   >