Introduce option "-P" / "--pid" to request that usbipd save its PID to
a file while running.
Signed-Off-By: Anthony Foiani
---
drivers/staging/usbip/userspace/src/usbipd.c | 38 +++-
1 file changed, 37 insertions(+), 1 deletion(-)
diff --git a/d
A few whitespace changes allows the file to pass checkpatch --strict
(other than ignoring the CamelCase derived from the USB standard.)
Signed-Off-By: Anthony Foiani
---
drivers/staging/usbip/userspace/src/usbipd.c | 31 ++--
1 file changed, 16 insertions(+), 15
log" option was not properly accepted by 'usbip'.
This is based off linux-next commit 985b84a0d18aaad943103c75f82accc94f475a15
Thanks,
Tony
Anthony Foiani (7):
staging: usbip: clean up checkpatch warnings in usbipd.c
staging: usbip: use local variable while setting up socket
Give useful error messages when we can't create server sockets.
Signed-Off-By: Anthony Foiani
---
drivers/staging/usbip/userspace/src/usbipd.c | 28 ++--
1 file changed, 22 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/usbip/userspace/src/usbipd
Add an option "-p" / "--port" to specify the TCP port to listen on.
Signed-Off-By: Anthony Foiani
---
drivers/staging/usbip/userspace/src/usbip.c| 9 +--
.../staging/usbip/userspace/src/usbip_network.c| 30 ++
.../staging/usbip/userspace
This option is checked for, and is in the long options list, but the
optstring didn't include it.
Signed-Off-By: Anthony Foiani
---
drivers/staging/usbip/userspace/src/usbip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/usbip/userspace/src/usbip
Re-align the option lists.
Signed-Off-By: Anthony Foiani
---
drivers/staging/usbip/userspace/src/usbip.c | 6 +++---
drivers/staging/usbip/userspace/src/usbipd.c | 10 +-
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/usbip/userspace/src/usbip.c
b
Using a simple integer makes the code easier to read and removes the
need to blank out array elements in case of errors.
Signed-Off-By: Anthony Foiani
---
drivers/staging/usbip/userspace/src/usbipd.c | 27 ---
1 file changed, 12 insertions(+), 15 deletions(-)
diff --git
Anthony Foiani writes:
> Introduce option "-P" / "--pid" to request that usbipd save its PID to
> a file while running.
I've already spotted one problem with this patch:
> + write_pid_file(pid_file);
>
Anthony Foiani writes:
> Add an option "-p" / "--port" to specify the TCP port to listen on.
This is unfortunate, as "port" is also used to indicate which "usbip
port" is in use by a particular connection.
So I might change this to "-t" / &
This option is in the long options list, and it's handled in the
option processing loop, but the optstring didn't include it.
Signed-off-by: Anthony Foiani
---
drivers/staging/usbip/userspace/src/usbip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/sta
Add an option "-t" / "--tcp-port" to specify the TCP port to listen on.
Signed-off-by: Anthony Foiani
---
drivers/staging/usbip/userspace/src/usbip.c| 9 +--
.../staging/usbip/userspace/src/usbip_network.c| 30 ++
.../staging
Re-align the option lists.
Signed-off-by: Anthony Foiani
---
drivers/staging/usbip/userspace/src/usbip.c | 8
drivers/staging/usbip/userspace/src/usbipd.c | 12 ++--
2 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/usbip/userspace/src/usbip.c
Introduce option "-P" / "--pid" to request that usbipd save its PID to
a file while running.
Signed-off-by: Anthony Foiani
---
drivers/staging/usbip/userspace/src/usbipd.c | 40 +++-
1 file changed, 39 insertions(+), 1 deletion(-)
diff --git a/d
port in use.
* Make sure that 'usbipd' records its PID *after* daemonizing.
* Drop first three patches from v1 (they're already accepted).
Anthony Foiani (4):
staging: usbip: add "-P" / "--pid" option to save usbipd process id
staging: usbip: set usbipd server
Greg KH writes:
> On Sat, Aug 17, 2013 at 03:34:32PM -0600, Anthony Foiani wrote:
> > +int USBIP_PORT = 3240;
> > +char *USBIP_PORT_STRING = "3240";
>
> Variables shouldn't be ALL_CAPS, those are what #defines are for.
> Yes, I know you moved from a define
Greg KH writes:
> On Sat, Aug 17, 2013 at 03:34:31PM -0600, Anthony Foiani wrote:
> > Introduce option "-P" / "--pid" to request that usbipd save its
> > PID to a file while running.
>
> Shouldn't this be the requirement of the tool that starts it up
thread/6re24e7r443kn2nj
http://www.mail-archive.com/linux-usb@xxx/msg23959.html
Changes from v1 -> v2:
* Use "-t" / "--tcp-port" instead of "-p" / "--port"; the 'usbip'
command already has a "-p" option for the usbi
This option is in the long options list, and it's handled in the
option processing loop, but the optstring didn't include it.
Signed-off-by: Anthony Foiani
---
drivers/staging/usbip/userspace/src/usbip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/sta
Add an option "-t" / "--tcp-port" to specify the TCP port to listen
on. Downcase associated variables as they're no longer constants.
Signed-off-by: Anthony Foiani
---
drivers/staging/usbip/userspace/src/usbip.c| 9 +--
drivers/staging/usbip/userspac
Re-align the option lists.
Signed-off-by: Anthony Foiani
---
drivers/staging/usbip/userspace/src/usbip.c | 8
drivers/staging/usbip/userspace/src/usbipd.c | 12 ++--
2 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/usbip/userspace/src/usbip.c
Introduce option "-P" / "--pid" to request that usbipd save its PID to
a file while running.
Signed-off-by: Anthony Foiani
---
drivers/staging/usbip/userspace/src/usbipd.c | 40 +++-
1 file changed, 39 insertions(+), 1 deletion(-)
diff --git a/d
22 matches
Mail list logo
