Re: [PATCH] USB Kconfig: Reorganize USB Kconfig Menu

2007-12-28 Thread Adrian Bunk
On Thu, Dec 27, 2007 at 02:18:58PM -0800, David Brownell wrote: > On Sunday 23 December 2007, Al Boldi wrote: > > > > Reogranize USB Kconfig Menu, and move USB_GADGET out into the Device Driver > > Menu. This helps the USB Kconfig Menu to be more logical/usable. > > > > Cc: David Brownell <[EMAI

Re: [PATCH 2/5] USB Kconfig: Select SCSI for USB Mass Storage support

2008-01-05 Thread Adrian Bunk
On Sat, Jan 05, 2008 at 11:30:24AM -0800, Randy Dunlap wrote: > On Sat, 5 Jan 2008 18:41:39 +0300 Al Boldi wrote: > > > > > Select SCSI for USB Mass Storage support. > > > > > > Cc: David Brownell <[EMAIL PROTECTED]> > > Cc: Greg KH <[EMAIL PROTECTED]> > > Cc: Andrew Morton <[EMAIL PROTECTED]>

Re: [PATCH 2/5] USB Kconfig: Select SCSI for USB Mass Storage support

2008-01-05 Thread Adrian Bunk
On Sat, Jan 05, 2008 at 03:22:14PM -0800, Randy Dunlap wrote: >... > For Aunt Tillie cases, "select" makes sense. For other cases, > I'd argue that it makes sense for config users to know when they > do something that causes an entire subsystem to be added to their > kernel (like SCSI or NET). We

Re: [PATCH 2/5] USB Kconfig: Select SCSI for USB Mass Storage support

2008-01-05 Thread Adrian Bunk
On Sun, Jan 06, 2008 at 01:35:21AM +0100, Stefan Richter wrote: > Adrian Bunk wrote: > > Whether or not an option requires an additional subsystem like e.g. SCSI > > or SSB are hardware and implementation details we shouldn't bother > > kconfig users with. > >

Re: [PATCH 2/5] USB Kconfig: Select SCSI for USB Mass Storage support

2008-01-06 Thread Adrian Bunk
On Sun, Jan 06, 2008 at 12:29:46PM +0100, Stefan Richter wrote: > Adrian Bunk wrote: > > On Sun, Jan 06, 2008 at 01:35:21AM +0100, Stefan Richter wrote: > >> instead work on better UIs if you have got > >> trouble with the complexities of the dependencies graph. The

Re: [PATCH 2/5] USB Kconfig: Select SCSI for USB Mass Storage support

2008-01-06 Thread Adrian Bunk
On Sun, Jan 06, 2008 at 12:54:04PM +0100, Stefan Richter wrote: > Randy Dunlap wrote: > > Sam Ravnborg wrote: > >> On Sat, Jan 05, 2008 at 11:03:30PM +0200, Adrian Bunk wrote: > >>> For kconfig users, "select" is _much_ better than sending them > >

Re: [PATCH 2/5] USB Kconfig: Select SCSI for USB Mass Storage support

2008-01-06 Thread Adrian Bunk
On Sun, Jan 06, 2008 at 01:18:48PM +0100, Stefan Richter wrote: > Adrian Bunk wrote: > > On Sun, Jan 06, 2008 at 01:35:21AM +0100, Stefan Richter wrote: > >> Adrian Bunk wrote: > >>> Whether or not an option requires an additional subsystem like e.g. SCSI

Re: [PATCH 2/5] USB Kconfig: Select SCSI for USB Mass Storage support

2008-01-06 Thread Adrian Bunk
On Sun, Jan 06, 2008 at 01:32:35PM +0100, Stefan Richter wrote: > Adrian Bunk wrote: > > On Sun, Jan 06, 2008 at 12:29:46PM +0100, Stefan Richter wrote: > >> Adrian Bunk wrote: > >>> Duplicating the structure in each UI should be an improvement? > >&g

Re: [PATCH 2/5] USB Kconfig: Select SCSI for USB Mass Storage support

2008-01-06 Thread Adrian Bunk
On Sun, Jan 06, 2008 at 02:13:09PM +0100, Stefan Richter wrote: > Adrian Bunk wrote: > > On Sun, Jan 06, 2008 at 01:18:48PM +0100, Stefan Richter wrote: > >> I'm afraid this can't be put into practice. (User says which hardware > >> and protocols he nee

[2.6 patch] usb/gadget/printer.c: fix an if()

2008-02-02 Thread Adrian Bunk
A bug every C programmer makes at some point in time... Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- diff --git a/drivers/usb/gadget/printer.c b/drivers/usb/gadget/printer.c index 9fdabc8..4f6bfa1 100644 --- a/drivers/usb/gadget/printer.c +++ b/drivers/usb/gadget/printer.c @@ -

Re: [PATCH] USB: mark USB drivers as being GPL only

2008-02-06 Thread Adrian Bunk
On Tue, Feb 05, 2008 at 05:34:23PM -0600, Chris Friesen wrote: > David Newall wrote: >> That being said, a module can be written such that it only dynamically >> links with the kernel. Ndiswrapper is an example of how this can be >> done: None of the drivers that work under ndiswrapper make any

Re: [PATCH] USB: mark USB drivers as being GPL only

2008-02-07 Thread Adrian Bunk
On Thu, Feb 07, 2008 at 09:07:38AM +0100, Diego Zuccato wrote: > Christer Weinigel ha scritto: >... > [...] >> preliminary go ahead from the bosses to provide documentation under an >> NDA to Linux developers that would like to write GPL drivers for it. I > [...] > Urgh... I don't think NDAs and O

usb/serial/io_ti.c: inconsequent NULL checking

2008-02-19 Thread Adrian Bunk
The Coverity checker spotted the following inconsequent NULL checking introduced by commit d5f5bcd425b771c0b7ff5a650b2ce061ac8bbb87: <-- snip --> static int edge_open (struct usb_serial_port *port, struct file * filp) { ... if (port->tty) <

[2.6 patch] usb/serial/io_ti.c: remove unneeded NULL check

2008-02-22 Thread Adrian Bunk
erform magic. It simply notices that it's once checked and once dereferenced unconditionally. > The check can go. Thanks, patch below. > Alan cu Adrian <-- snip --> There's no reason for checking pdev->bus for being NULL here (and we'd anyway Oops below

[2.6.25 patch] fix drivers/usb/host/u132-hcd.c compilation

2008-02-23 Thread Adrian Bunk
error: (Each undeclared identifier is reported only once /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/usb/host/u132-hcd.c:3225: error: for each function it appears in.) make[4]: *** [drivers/usb/host/u132-hcd.o] Error 1 <-- snip --> Signed-off-by: Adrian Bunk <[