Re: [PATCH 8/8] xhci: Fix NULL pointer dereference in xhci_clear_tt_buffer_complete()

2019-10-08 Thread Mathias Nyman
On 7.10.2019 17.02, Johan Hovold wrote: [ +CC: Alan ] On Fri, Oct 04, 2019 at 02:59:33PM +0300, Mathias Nyman wrote: udev stored in ep->hcpriv might be NULL if tt buffer is cleared due to a halted control endpoint during device enumeration xhci_clear_tt_buffer_complete is called by hub_tt_work

[PATCH] USB: core: drop OOM message

2019-10-08 Thread Johan Hovold
Drop redundant OOM message on allocation failures which would already have been logged by the allocator. This also allows us to clean up the error paths somewhat. Signed-off-by: Johan Hovold --- drivers/usb/core/config.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --

[PATCH v3 1/9] usb: typec: Copy everything from struct typec_capability during registration

2019-10-08 Thread Heikki Krogerus
Copying everything from struct typec_capability to struct typec_port during port registration. This will make sure that under no circumstances the driver can change the values in the struct typec_capability that the port uses. Signed-off-by: Heikki Krogerus --- drivers/usb/typec/class.c | 15 +++

[PATCH v3 0/9] usb: typec: Small API improvement

2019-10-08 Thread Heikki Krogerus
Hi, The broken conditions in the *_store() functions should now be fixed. Cover letter from v2: In this version there should be no more semantic changes. The original cover letter: This series moves the callback members from struct typec_capabilities to a new struct typec_operations. That remo

[PATCH v3 2/9] usb: typec: Introduce typec_get_drvdata()

2019-10-08 Thread Heikki Krogerus
Leaving the private driver_data pointer of the port device to the port drivers. Signed-off-by: Heikki Krogerus --- drivers/usb/typec/class.c | 11 +++ include/linux/usb/typec.h | 4 2 files changed, 15 insertions(+) diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.

[PATCH v3 3/9] usb: typec: Separate the operations vector

2019-10-08 Thread Heikki Krogerus
Introducing struct typec_operations which has the same callbacks as struct typec_capability. The old callbacks are kept for now, but after all users have been converted, they will be removed. Signed-off-by: Heikki Krogerus --- drivers/usb/typec/class.c | 39 +-

[PATCH v3 6/9] usb: typec: ucsi: Start using struct typec_operations

2019-10-08 Thread Heikki Krogerus
Supplying the operation callbacks as part of a struct typec_operations instead of as part of struct typec_capability during port registration. Signed-off-by: Heikki Krogerus Reviewed-by: Guenter Roeck --- drivers/usb/typec/ucsi/ucsi.c | 22 +++--- 1 file changed, 11 insertions(+

[PATCH v3 7/9] usb: typec: hd3ss3220: Start using struct typec_operations

2019-10-08 Thread Heikki Krogerus
Supplying the operation callbacks as part of a struct typec_operations instead of as part of struct typec_capability during port registration. After this there is not need to keep the capabilities stored anywhere in the driver. Signed-off-by: Heikki Krogerus --- drivers/usb/typec/hd3ss3220.c | 2

[PATCH v3 9/9] usb: typec: Remove unused members from struct typec_capability

2019-10-08 Thread Heikki Krogerus
The members for the muxes are not used, so dropping them. Signed-off-by: Heikki Krogerus --- include/linux/usb/typec.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/linux/usb/typec.h b/include/linux/usb/typec.h index 894798084319..0f52723a11bd 100644 --- a/include/linux/usb/typec.

[PATCH v3 4/9] usb: typec: tcpm: Start using struct typec_operations

2019-10-08 Thread Heikki Krogerus
Supplying the operation callbacks as part of a struct typec_operations instead of as part of struct typec_capability during port registration. Signed-off-by: Heikki Krogerus Reviewed-by: Guenter Roeck --- drivers/usb/typec/tcpm/tcpm.c | 45 --- 1 file changed, 20

[PATCH v3 8/9] usb: typec: Remove the callback members from struct typec_capability

2019-10-08 Thread Heikki Krogerus
There are no more users for them. Signed-off-by: Heikki Krogerus --- drivers/usb/typec/class.c | 40 +++ include/linux/usb/typec.h | 17 - 2 files changed, 11 insertions(+), 46 deletions(-) diff --git a/drivers/usb/typec/class.c b/drivers/usb/

[PATCH v3 5/9] usb: typec: tps6598x: Start using struct typec_operations

2019-10-08 Thread Heikki Krogerus
Supplying the operation callbacks as part of a struct typec_operations instead of as part of struct typec_capability during port registration. After this there is not need to keep the capabilities stored anywhere in the driver. Signed-off-by: Heikki Krogerus Reviewed-by: Guenter Roeck --- drive

Re: [PATCH v4] usb: hub: Check device descriptor before resusciation

2019-10-08 Thread Greg KH
On Tue, Oct 08, 2019 at 10:09:01AM +0200, David Heinzelmann wrote: > If a device connected to an xHCI host controller disconnects from the USB bus > and then reconnects, e.g. triggered by a firmware update, then the host > controller automatically activates the connection and the port is enabled. T

Re: [PATCH v4] usb: hub: Check device descriptor before resusciation

2019-10-08 Thread David Heinzelmann
On Tue, Oct 08, 2019 at 02:55:46PM +0200, Greg KH wrote: > What happened to Alan's ack? > I'm not sure I'm allowed to add someone else's acked-by tag? If so I will sent v5. David

Re: [PATCH v4] usb: hub: Check device descriptor before resusciation

2019-10-08 Thread Greg KH
On Tue, Oct 08, 2019 at 06:10:22PM +0200, David Heinzelmann wrote: > On Tue, Oct 08, 2019 at 02:55:46PM +0200, Greg KH wrote: > > What happened to Alan's ack? > > > > I'm not sure I'm allowed to add someone else's acked-by tag? If they provide it, and you don't change anything, then yes, you c

Re: CREAD ignored by almost all USB serial drivers

2019-10-08 Thread Greg KH
On Mon, Oct 07, 2019 at 03:18:52PM +0200, Harald Welte wrote: > Hi Greg, > > On Mon, Oct 07, 2019 at 01:06:33PM +0200, Greg KH wrote: > > On Sat, Sep 28, 2019 at 10:49:55PM +0200, Harald Welte wrote: > > > It seems that a lot of Linux kernel USB serial device drivers are > > > ignoring the CREAD s

Re: [PATCH] usb: dwc3: dwc3-meson-g12a.c: use devm_platform_ioremap_resource()

2019-10-08 Thread SAURAV GIREPUNJE
On Tue, Oct 08, 2019 at 07:29:28PM +0200, Martin Blumenstingl wrote: > Hi Saurav, > > On Tue, Oct 8, 2019 at 5:06 PM Kevin Hilman wrote: > > > > Saurav Girepunje writes: > > > > > Use the new helper that wraps the calls to platform_get_resource() > > > and devm_ioremap_resource() together in dwc

[PATCH] usbfs: Suppress uevents for claiminterface/releaseinterface

2019-10-08 Thread Ingo Rohloff
Hello, With recent Ubuntu 18/Linux Mint 19.2 etc, lots of user space programs (in particular systemd/eudev/upowerd) have problems with the "BIND/UNBIND" events produced since kernel 4.13. Some problems are described, when googling for linux "usb" "bind event" Now this might be blamed on these

Re: [PATCH] usbfs: Suppress uevents for claiminterface/releaseinterface

2019-10-08 Thread Greg KH
On Tue, Oct 08, 2019 at 09:32:10PM +0200, Ingo Rohloff wrote: > Hello, > > With recent Ubuntu 18/Linux Mint 19.2 etc, lots of user space programs > (in particular systemd/eudev/upowerd) have problems with the "BIND/UNBIND" > events produced since kernel 4.13. > Some problems are described, when

Unknown symbol errors in usb storage driver

2019-10-08 Thread Heiner Kallweit
Since a while I see the following. I didn't bisect yet, maybe issue is caused by 32bca2df7da2 ("usb-storage: export symbols in USB_STORAGE namespace")? DEPMOD 5.4.0-rc2-next-20191008+ depmod: WARNING: /lib/modules/5.4.0-rc2-next-20191008+/kernel/drivers/usb/storage/ums-re

HERE IS YOUR MONEY GRAM PAYMENT HAS BEEN SENT TO YOU HERE IS THE M.T.C.N:78393135

2019-10-08 Thread MONEY GRAM
HERE IS YOUR MONEY GRAM PAYMENT HAS BEEN SENT TO YOU HERE IS THE M.T.C.N:78393135 Attn: Beneficiary, This is to inform you that the America Embassy office was instructed to transfer your fund $980,000.00 U.S Dollars compensating all the SCAM VICTIMS and your email was found as one of the VICTIMS.

Re: Unknown symbol errors in usb storage driver

2019-10-08 Thread Greg KH
On Tue, Oct 08, 2019 at 09:53:16PM +0200, Heiner Kallweit wrote: > Since a while I see the following. I didn't bisect yet, maybe issue is caused > by > 32bca2df7da2 ("usb-storage: export symbols in USB_STORAGE namespace")? > > DEPMOD 5.4.0-rc2-next-20191008+ >

Re: Unknown symbol errors in usb storage driver

2019-10-08 Thread Heiner Kallweit
ot;)? >> >> DEPMOD 5.4.0-rc2-next-20191008+ >> depmod: WARNING: >> /lib/modules/5.4.0-rc2-next-20191008+/kernel/drivers/usb/storage/ums-realtek.ko >> needs unknown symbol usb_stor_probe1 >> depmod: WARNING: >> /lib/modules/5.4.0-rc2-nex

Re: [PATCH v3 1/9] usb: typec: Copy everything from struct typec_capability during registration

2019-10-08 Thread Guenter Roeck
On Tue, Oct 08, 2019 at 02:13:42PM +0300, Heikki Krogerus wrote: > Copying everything from struct typec_capability to struct > typec_port during port registration. This will make sure > that under no circumstances the driver can change the values > in the struct typec_capability that the port uses.

Re: [PATCH v3 2/9] usb: typec: Introduce typec_get_drvdata()

2019-10-08 Thread Guenter Roeck
On Tue, Oct 08, 2019 at 02:13:43PM +0300, Heikki Krogerus wrote: > Leaving the private driver_data pointer of the port device > to the port drivers. > > Signed-off-by: Heikki Krogerus Reviewed-by: Guenter Roeck > --- > drivers/usb/typec/class.c | 11 +++ > include/linux/usb/typec.h |

Re: [PATCH v3 3/9] usb: typec: Separate the operations vector

2019-10-08 Thread Guenter Roeck
On Tue, Oct 08, 2019 at 02:13:44PM +0300, Heikki Krogerus wrote: > Introducing struct typec_operations which has the same > callbacks as struct typec_capability. The old callbacks are > kept for now, but after all users have been converted, they > will be removed. > > Signed-off-by: Heikki Krogeru

Re: [PATCH v3 7/9] usb: typec: hd3ss3220: Start using struct typec_operations

2019-10-08 Thread Guenter Roeck
On Tue, Oct 08, 2019 at 02:13:48PM +0300, Heikki Krogerus wrote: > Supplying the operation callbacks as part of a struct > typec_operations instead of as part of struct > typec_capability during port registration. After this there > is not need to keep the capabilities stored anywhere in the > driv

Re: [PATCH v3 8/9] usb: typec: Remove the callback members from struct typec_capability

2019-10-08 Thread Guenter Roeck
On Tue, Oct 08, 2019 at 02:13:49PM +0300, Heikki Krogerus wrote: > There are no more users for them. > > Signed-off-by: Heikki Krogerus Reviewed-by: Guenter Roeck > --- > drivers/usb/typec/class.c | 40 +++ > include/linux/usb/typec.h | 17 -

Re: [PATCH v3 9/9] usb: typec: Remove unused members from struct typec_capability

2019-10-08 Thread Guenter Roeck
On Tue, Oct 08, 2019 at 02:13:50PM +0300, Heikki Krogerus wrote: > The members for the muxes are not used, so dropping them. > > Signed-off-by: Heikki Krogerus Reviewed-by: Guenter Roeck > --- > include/linux/usb/typec.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/include/linux

[PATCH] usb: chipidea: imx: check data->usbmisc_data against NULL before access

2019-10-08 Thread jun . li
From: Li Jun As usbmisc_data is optional, so add the check before access its member, this fix below static checker warning: drivers/usb/chipidea/ci_hdrc_imx.c:438 ci_hdrc_imx_probe() warn: 'data->usbmisc_data' can also be NULL which is introduced by Patch 15b80f7c3a7f: "usb: chipidea: imx: enable

[PATCH v5] usb: hub: Check device descriptor before resusciation

2019-10-08 Thread David Heinzelmann
If a device connected to an xHCI host controller disconnects from the USB bus and then reconnects, e.g. triggered by a firmware update, then the host controller automatically activates the connection and the port is enabled. The implementation of hub_port_connect_change() assumes that if the port i