composite_dev_cleanup call from the failure of configfs_composite_bind
frees up the cdev->os_desc_req and cdev->req. If the previous calls of
bind and unbind is successful these will carry stale values.
Consider the below sequence of function calls:
configfs_composite_bind()
composite_dev_
On Mon, Sep 30, 2019 at 09:54:11PM +0200, Sebastian Reichel wrote:
> Hi,
>
> On Mon, Sep 30, 2019 at 08:23:30AM -0700, Tony Lindgren wrote:
> > Actually playing with the cppi41 timeout might be more suitable here,
> > they use the same module clock from what I remember though. So
> > maybe increa
On Tue, Oct 1, 2019 at 10:03 AM Johan Hovold wrote:
>
> On Mon, Sep 30, 2019 at 09:54:11PM +0200, Sebastian Reichel wrote:
> > Hi,
> >
> > On Mon, Sep 30, 2019 at 08:23:30AM -0700, Tony Lindgren wrote:
>
> > > Actually playing with the cppi41 timeout might be more suitable here,
> > > they use the
Supplying the operation callbacks as part of a struct
typec_operations instead of as part of struct
typec_capability during port registration.
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/tcpm/tcpm.c | 47 ---
1 file changed, 21 insertions(+), 26 deletions
There are no more users for them.
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/class.c | 65 +--
include/linux/usb/typec.h | 17 --
2 files changed, 22 insertions(+), 60 deletions(-)
diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/c
Supplying the operation callbacks as part of a struct
typec_operations instead of as part of struct
typec_capability during port registration. After this there
is not need to keep the capabilities stored anywhere in the
driver.
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/tps6598x.c | 49
Supplying the operation callbacks as part of a struct
typec_operations instead of as part of struct
typec_capability during port registration.
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/ucsi/ucsi.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --g
Introducing struct typec_operations which has the same
callbacks as struct typec_capability. The old callbacks are
kept for now, but after all users have been converted, they
will be removed.
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/class.c | 90 +-
Hi guys,
This series moves the callback members from struct typec_capabilities
to a new struct typec_operations. That removes the need for the
drivers to keep a copy of the struct typec_capabilites if they don't
need it, and struct typec_operations can probable always be
constified.
The change is
Copying everything from struct typec_capability to struct
typec_port during port registration.
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/class.c | 55 +--
1 file changed, 35 insertions(+), 20 deletions(-)
diff --git a/drivers/usb/typec/class.c b/dr
Leaving the private driver_data pointer of the port device
to the port drivers.
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/class.c | 11 +++
include/linux/usb/typec.h | 4
2 files changed, 15 insertions(+)
diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.
The "port->typec_caps.data" and "port->typec_caps.type" variables are
enums and in this context GCC will treat them as an unsigned int so they
can never be less than zero.
Fixes: ae8a2ca8a221 ("usb: typec: Group all TCPCI/TCPM code together")
Signed-off-by: Dan Carpenter
---
v2: preserve the erro
On Tue, Oct 01, 2019 at 03:01:17PM +0300, Dan Carpenter wrote:
> The "port->typec_caps.data" and "port->typec_caps.type" variables are
> enums and in this context GCC will treat them as an unsigned int so they
> can never be less than zero.
>
> Fixes: ae8a2ca8a221 ("usb: typec: Group all TCPCI/TCP
On 10/1/19 2:48 AM, Heikki Krogerus wrote:
Copying everything from struct typec_capability to struct
typec_port during port registration.
What is the purpose of this patch ? To reduce the number of indirections at
runtime, or to avoid having to have cap around ?
FWIW, it looks like the code do
On 10/1/19 2:48 AM, Heikki Krogerus wrote:
Introducing struct typec_operations which has the same
callbacks as struct typec_capability. The old callbacks are
kept for now, but after all users have been converted, they
will be removed.
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/class
On 10/1/19 2:48 AM, Heikki Krogerus wrote:
Supplying the operation callbacks as part of a struct
typec_operations instead of as part of struct
typec_capability during port registration.
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/tcpm/tcpm.c | 47 ---
On 10/1/19 2:48 AM, Heikki Krogerus wrote:
Supplying the operation callbacks as part of a struct
typec_operations instead of as part of struct
typec_capability during port registration. After this there
is not need to keep the capabilities stored anywhere in the
driver.
Signed-off-by: Heikki Kro
On 10/1/19 2:48 AM, Heikki Krogerus wrote:
Supplying the operation callbacks as part of a struct
typec_operations instead of as part of struct
typec_capability during port registration.
Signed-off-by: Heikki Krogerus
Reviewed-by: Guenter Roeck
---
drivers/usb/typec/ucsi/ucsi.c | 22 +
On 10/1/19 2:48 AM, Heikki Krogerus wrote:
Supplying the operation callbacks as part of a struct
typec_operations instead of as part of struct
typec_capability during port registration. After this there
is not need to keep the capabilities stored anywhere in the
driver.
Signed-off-by: Heikki Kro
On 10/1/19 2:48 AM, Heikki Krogerus wrote:
There are no more users for them.
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/class.c | 65 +--
include/linux/usb/typec.h | 17 --
2 files changed, 22 insertions(+), 60 deletions(-)
diff --git a
On 10/1/19 5:01 AM, Dan Carpenter wrote:
The "port->typec_caps.data" and "port->typec_caps.type" variables are
enums and in this context GCC will treat them as an unsigned int so they
can never be less than zero.
Fixes: ae8a2ca8a221 ("usb: typec: Group all TCPCI/TCPM code together")
Signed-off-b
On Tue, Oct 01, 2019 at 02:49:54PM +0200, Greg Kroah-Hartman wrote:
> On Tue, Oct 01, 2019 at 02:38:08PM +0300, Mika Westerberg wrote:
> > Hi all,
> >
> > I'm sending this as RFC because the series is still missing important
> > features such as power management so not ready for merging. However,
On Mon, Sep 30, 2019 at 10:45:25PM +0200, Stefan Wahren wrote:
Hi,
during make modules_install for arm/multi_v7_defconfig on current Linux
5.4-rc1, i'm getting the following warnings:
depmod: WARNING:
/media/stefan/rootfs//lib/modules/5.4.0-rc1-6-g4a80125-dirty/kernel/drivers/usb/storage/ua
* Yegor Yefremov [191001 09:20]:
> On Tue, Oct 1, 2019 at 10:03 AM Johan Hovold wrote:
> >
> > On Mon, Sep 30, 2019 at 09:54:11PM +0200, Sebastian Reichel wrote:
> > > Hi,
> > >
> > > On Mon, Sep 30, 2019 at 08:23:30AM -0700, Tony Lindgren wrote:
> >
> > > > Actually playing with the cppi41 timeo
Hi Heikki
> -Original Message-
> From: Heikki Krogerus
> Sent: Thursday, September 26, 2019 3:07 AM
> To: Ajay Gupta
> Cc: linux-usb@vger.kernel.org
> Subject: [PATCH 00/14] usb: typec: UCSI driver overhaul
>
> Hi Ajay,
>
> Here's the pretty much complete rewrite of the I/O handling th
Hi Maxime,
On Tue, 16 Apr 2019 10:28:00 +0200
Maxime Ripard wrote:
> Neither the OHCI or EHCI bindings are using the phy-names property, so we
> can just drop it.
>
> Signed-off-by: Maxime Ripard
> ---
> arch/arm/boot/dts/sun4i-a10.dtsi | 4
> arch/arm/boot/dts/sun5i.dtsi
Hi,
* Tony Lindgren [191001 16:52]:
> * Yegor Yefremov [191001 09:20]:
> > I've tried to increase the autosuspend_delay_ms and to set control to
> > "on" but nothing changes. Below you can see the output of my testing
> > script [1] (Py2 only). As one can see, the first cycle i.e. after the
> >
On Wed, Oct 2, 2019 at 12:03 AM Tony Lindgren wrote:
>
> Hi,
>
> * Tony Lindgren [191001 16:52]:
> > * Yegor Yefremov [191001 09:20]:
> > > I've tried to increase the autosuspend_delay_ms and to set control to
> > > "on" but nothing changes. Below you can see the output of my testing
> > > scrip
28 matches
Mail list logo
