Re: [PATCH] [PATCH v7] USB: serial: pl2303: Add new PID to support PL2303HXN (TYPE_HXN)

2019-09-25 Thread Johan Hovold
On Wed, Sep 25, 2019 at 09:20:07AM +0800, Charles Yeh wrote: > Johan Hovold 於 2019年9月23日 週一 下午9:08寫道: > > > > Yes, the above looks good. > > > > Thank you for your reply > > I have already written a new patch[v8] file, > if you have free time. Please check as soon as possible...thanks! I'll sta

[PATCH 2/2] USB: adutux: fix NULL-derefs on disconnect

2019-09-25 Thread Johan Hovold
The driver was using its struct usb_device pointer as an inverted disconnected flag, but was setting it to NULL before making sure all completion handlers had run. This could lead to a NULL-pointer dereference in a number of dev_dbg statements in the completion handlers which relies on said pointer

[PATCH 1/2] USB: adutux: fix use-after-free on disconnect

2019-09-25 Thread Johan Hovold
The driver was clearing its struct usb_device pointer, which it used as an inverted disconnected flag, before deregistering the character device and without serialising against racing release(). This could lead to a use-after-free if a racing release() callback observes the cleared pointer and fre

Re: [PATCH] [PATCH v7] USB: serial: pl2303: Add new PID to support PL2303HXN (TYPE_HXN)

2019-09-25 Thread Charles Yeh
Johan Hovold 於 2019年9月25日 週三 下午4:06寫道: > Meanwhile you can double check that you've considered all > review-feedback you've gotten so far. > > I don't think you ever replied to my last comment about the reset > register and why I thought using plain write (not read, mask, write) was > the right th

Re: [PATCH] [PATCH v7] USB: serial: pl2303: Add new PID to support PL2303HXN (TYPE_HXN)

2019-09-25 Thread Johan Hovold
On Wed, Sep 25, 2019 at 05:36:23PM +0800, Charles Yeh wrote: > Johan Hovold 於 2019年9月25日 週三 下午4:06寫道: > > Meanwhile you can double check that you've considered all > > review-feedback you've gotten so far. > > > > I don't think you ever replied to my last comment about the reset > > register and w

Re: [PATCH] Check for changed device descriptors when a connection-change occurs before validating the connection.

2019-09-25 Thread Alan Stern
On Tue, 24 Sep 2019, David Heinzelmann wrote: > > I really don't understand this. > > > > Your patch involves the case where there was a connect-change event but > > the port is still enabled. Now maybe I've forgotten about one of the > > pathways, but it seems like that combination should nev

Re: BUG report: usb: dwc3: Link TRB triggered an intterupt without IOC being setted

2019-09-25 Thread Mathias Nyman
On 24.9.2019 17.45, alex zheng wrote: Hi Mathias, I try to ignore the DMA errors, then the transfer continues but it complete with data lost, it seems like these ERROR Transfer event should be right and must not be ignore. test app show: "did not get enough data, received size:14410176/1500

RE: BUG report: usb: dwc3: Link TRB triggered an intterupt without IOC being setted

2019-09-25 Thread David Laight
From: Mathias Nyman > Sent: 25 September 2019 15:48 > > On 24.9.2019 17.45, alex zheng wrote: > > Hi Mathias, ... > Logs show your transfer ring has four segments, but hardware fails to > jump from the last segment back to first) > > Last TRB (LINK TRB) of each segment points to the next segment,

Pheckee23

2019-09-25 Thread cuxgkkzgsu
带开发瓢 +Ⅴ :ⓀⓕⓅ⒎⒎⒍⒏

RE: BUG report: usb: dwc3: Link TRB triggered an intterupt without IOC being setted

2019-09-25 Thread Felipe Balbi
Hi, David Laight writes: > From: Mathias Nyman >> Sent: 25 September 2019 15:48 >> >> On 24.9.2019 17.45, alex zheng wrote: >> > Hi Mathias, > ... >> Logs show your transfer ring has four segments, but hardware fails to >> jump from the last segment back to first) >> >> Last TRB (LINK TRB) of

[PATCH -next] usb: cdns3: Fix sheduling with locks held.

2019-09-25 Thread Pawel Laszczak
Patch fix issue in cdns3_ep0_feature_handle_device function. The function usleep_range can't be used there because this function is called with locks held and IRQs disabled in cdns3_device_thread_irq_handler(). To resolve this issue patch replaces usleep_range with mdelay. Signed-off-by: Pawel L

Re: [PATCH -next] usb: cdns3: Fix sheduling with locks held.

2019-09-25 Thread Greg KH
On Thu, Sep 26, 2019 at 07:19:27AM +0100, Pawel Laszczak wrote: > Patch fix issue in cdns3_ep0_feature_handle_device function. > > The function usleep_range can't be used there because this function is > called with locks held and IRQs disabled in > cdns3_device_thread_irq_handler(). > > To resol