Re: Failed to connect to 4G modem

2019-09-19 Thread Bjørn Mork
Greg KH writes: >> >> [ 44.059958] qmi_wwan 1-1:1.3 wwan0: unregister 'qmi_wwan' >> >> usb-ci_hdrc.1-1, We .. >> That was always my thought until I tried kernel 5.1 under the same >> platform (nothing changed except the kernel version), the kernel 5.1 >> can connect to the 4G modem, I could no

[PATCH 4/4] USB: legousbtower: fix open after failed reset request

2019-09-19 Thread Johan Hovold
The driver would return with a nonzero open count in case the reset control request failed. This would prevent any further attempts to open the char dev until the device was disconnected. Fix this by incrementing the open count only on successful open. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Sig

[PATCH 3/4] USB: legousbtower: fix potential NULL-deref on disconnect

2019-09-19 Thread Johan Hovold
The driver is using its struct usb_device pointer as an inverted disconnected flag, but was setting it to NULL before making sure all completion handlers had run. This could lead to a NULL-pointer dereference in a number of dev_dbg and dev_err statements in the completion handlers which relies on s

[PATCH 1/4] USB: legousbtower: fix slab info leak at probe

2019-09-19 Thread Johan Hovold
Make sure to check for short transfers when retrieving the version information at probe to avoid leaking uninitialised slab data when logging it. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: stable Signed-off-by: Johan Hovold --- drivers/usb/misc/legousbtower.c | 6 -- 1 file changed, 4 ins

[PATCH 0/4] USB: legousbtower: misc fixes

2019-09-19 Thread Johan Hovold
This series fixes a few issues found in the legousbtower driver. The potential deadlock issue was reported by syzbot, and the rest was found through inspection. I have bunch of clean ups for this driver as well that I'll post once these are in Linus's tree. Johan Johan Hovold (4): USB: legous

[PATCH 2/4] USB: legousbtower: fix deadlock on disconnect

2019-09-19 Thread Johan Hovold
Fix a potential deadlock if disconnect races with open. Since commit d4ead16f50f9 ("USB: prevent char device open/deregister race") core holds an rw-semaphore while open is called and when releasing the minor number during deregistration. This can lead to an ABBA deadlock if a driver takes a lock

[PATCH RESEND 1/4] USB: legousbtower: fix slab info leak at probe

2019-09-19 Thread Johan Hovold
Make sure to check for short transfers when retrieving the version information at probe to avoid leaking uninitialised slab data when logging it. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: stable Signed-off-by: Johan Hovold --- drivers/usb/misc/legousbtower.c | 6 -- 1 file changed, 4 ins

[PATCH RESEND 0/4] USB: legousbtower: misc fixes

2019-09-19 Thread Johan Hovold
[ Resend with Juergen on CC ] This series fixes a few issues found in the legousbtower driver. The potential deadlock issue was reported by syzbot, and the rest was found through inspection. I have bunch of clean ups for this driver as well that I'll post once these are in Linus's tree. Johan

[PATCH RESEND 4/4] USB: legousbtower: fix open after failed reset request

2019-09-19 Thread Johan Hovold
The driver would return with a nonzero open count in case the reset control request failed. This would prevent any further attempts to open the char dev until the device was disconnected. Fix this by incrementing the open count only on successful open. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Sig

[PATCH RESEND 3/4] USB: legousbtower: fix potential NULL-deref on disconnect

2019-09-19 Thread Johan Hovold
The driver is using its struct usb_device pointer as an inverted disconnected flag, but was setting it to NULL before making sure all completion handlers had run. This could lead to a NULL-pointer dereference in a number of dev_dbg and dev_err statements in the completion handlers which relies on s

[PATCH RESEND 2/4] USB: legousbtower: fix deadlock on disconnect

2019-09-19 Thread Johan Hovold
Fix a potential deadlock if disconnect races with open. Since commit d4ead16f50f9 ("USB: prevent char device open/deregister race") core holds an rw-semaphore while open is called and when releasing the minor number during deregistration. This can lead to an ABBA deadlock if a driver takes a lock

Re: Event ring is full when do iozone test on UAS storage

2019-09-19 Thread Peter Chen
> On 17.9.2019 12.55, Peter Chen wrote: > >>> > >>> I met "event ring full error" like below, this error is met when > >>> I do iozone test on UAS storage at v4.19.35 kernel, but not meet > >>> this error at linux-next tree (08/24). The same host and test > >>> UAS storage device are used. This iss

Re: Failed to connect to 4G modem

2019-09-19 Thread JH
On 9/19/19, Bjørn Mork wrote: > Greg KH writes: > >>> >> [ 44.059958] qmi_wwan 1-1:1.3 wwan0: unregister 'qmi_wwan' >>> >> usb-ci_hdrc.1-1, We > .. >>> That was always my thought until I tried kernel 5.1 under the same >>> platform (nothing changed except the kernel version), the kernel 5.1 >>>

Re: [PATCH] usb: dwc3: Add shutdown to platform_driver

2019-09-19 Thread Vicente Bergas
Ping? On Saturday, August 17, 2019 7:41:40 PM CEST, Vicente Bergas wrote: Otherwise the device keeps writing to memory after kexec and disturbs the next kernel. Signed-off-by: Vicente Bergas --- drivers/usb/dwc3/dwc3-of-simple.c | 6 ++ 1 file changed, 6 insertions(+) Hi Felipe, Robin, t

Re: [PATCH v5] usb: typec: ucsi: add support for separate DP altmode devices

2019-09-19 Thread Heikki Krogerus
On Tue, Sep 17, 2019 at 09:41:49PM +, Ajay Gupta wrote: > Hi Heikki, > > > -Original Message- > > From: Heikki Krogerus > > Sent: Friday, September 13, 2019 8:20 AM > > To: Ajay Gupta > > Cc: linux-usb@vger.kernel.org; Ajay Gupta > > Subject: Re: [PATCH v5] usb: typec: ucsi: add sup

Re: Event ring is full when do iozone test on UAS storage

2019-09-19 Thread Suwan Kim
On Thu, Sep 19, 2019 at 05:54:25PM +0800, Peter Chen wrote: > > On 17.9.2019 12.55, Peter Chen wrote: > > >>> > > >>> I met "event ring full error" like below, this error is met when > > >>> I do iozone test on UAS storage at v4.19.35 kernel, but not meet > > >>> this error at linux-next tree (08/2

Re: Reminder: 52 active syzbot reports in usb subsystem

2019-09-19 Thread Eric Biggers
On Thu, Sep 19, 2019 at 08:40:58AM +0200, Greg Kroah-Hartman wrote: > On Wed, Sep 18, 2019 at 10:23:42PM -0700, Eric Biggers wrote: > > [This email was generated by a script. Let me know if you have any > > suggestions > > to make it better, or if you want it re-generated with the latest status.]

Re: Reminder: 52 active syzbot reports in usb subsystem

2019-09-19 Thread Greg Kroah-Hartman
On Thu, Sep 19, 2019 at 10:32:49AM -0700, Eric Biggers wrote: > On Thu, Sep 19, 2019 at 08:40:58AM +0200, Greg Kroah-Hartman wrote: > > On Wed, Sep 18, 2019 at 10:23:42PM -0700, Eric Biggers wrote: > > > [This email was generated by a script. Let me know if you have any > > > suggestions > > > to