Re: [PATCH 1/4] dt-bindings: usb: usb251xb: add documentation for voltage supply

2019-09-18 Thread Richard Leitner
On 17/09/2019 16:44, Marco Felsch wrote: Add the optional voltage supply documentation. If not specified the dummy-regulator is used. Signed-off-by: Marco Felsch Hi, please feel free to add: Acked-by: Richard Leitner regards;Richard.L --- Documentation/devicetree/bindings/usb/usb251xb.

Re: [PATCH 3/4] usb: usb251xb: simplify reset helper

2019-09-18 Thread Richard Leitner
On 17/09/2019 16:44, Marco Felsch wrote: Currently the reset handler was always called to deassert the reset line because assert the line was done during probe. Now if we want to support pm by turn of the supply we need to call this routine twice and the i2c_lock_bus is done twice too. To simplif

Re: [PATCH 2/4] usb: usb251xb: add vdd supply support

2019-09-18 Thread Richard Leitner
On 17/09/2019 16:44, Marco Felsch wrote: Currently we don't handle the supply. We need to add the supply support to be able to switch the supply off e.g. during a suspend-to-ram operation. So we can guarantee a correct (re-)initialization. Signed-off-by: Marco Felsch Hi, tested it on a i.MX6

Re: [PATCH 4/4] usb: usb251xb: add pm_ops

2019-09-18 Thread Richard Leitner
On 17/09/2019 16:44, Marco Felsch wrote: Currently the driver don't support pm_ops. These ops are not necessary if the supply isn't switchable (always on). This assumptions seems to be wrong because no one needs a powered hub during suspend-to-ram/disk. So adding simple_dev_pm_ops to be able to

[PATCH] USB: serial: add port statistics

2019-09-18 Thread yegorslists
From: Yegor Yefremov Add additional port statistics like received and transmitted bytes the way /proc/tty/driver/serial does. As usbserial driver already provides USB related information and this line is longer than 100 characters, this patch adds an additional line with the same port number: 0

[PATCH v3] usb: host: xhci: wait CNR when doing xhci resume

2019-09-18 Thread Rick Tseng
NVIDIA 3.1 xHCI card would lose power when moving power state into D3Cold. Thus we need to wait CNR bit to clear when xhci resmue as xhci init. Signed-off-by: Rick Tseng --- drivers/usb/host/xhci.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/usb/host/xhci.c b/drivers

Re: [PATCH] USB: serial: add port statistics

2019-09-18 Thread Greg KH
On Wed, Sep 18, 2019 at 11:14:15AM +0200, yegorsli...@googlemail.com wrote: > From: Yegor Yefremov > > Add additional port statistics like received and transmitted bytes > the way /proc/tty/driver/serial does. > > As usbserial driver already provides USB related information and > this line is lo

Re: [PATCH] USB: serial: add port statistics

2019-09-18 Thread Yegor Yefremov
On Wed, Sep 18, 2019 at 1:08 PM Greg KH wrote: > > On Wed, Sep 18, 2019 at 11:14:15AM +0200, yegorsli...@googlemail.com wrote: > > From: Yegor Yefremov > > > > Add additional port statistics like received and transmitted bytes > > the way /proc/tty/driver/serial does. > > > > As usbserial driver

Re: [PATCH] USB: serial: add port statistics

2019-09-18 Thread Greg KH
On Wed, Sep 18, 2019 at 01:22:42PM +0200, Yegor Yefremov wrote: > On Wed, Sep 18, 2019 at 1:08 PM Greg KH wrote: > > > > On Wed, Sep 18, 2019 at 11:14:15AM +0200, yegorsli...@googlemail.com wrote: > > > From: Yegor Yefremov > > > > > > Add additional port statistics like received and transmitted

Re: [PATCH] USB: serial: add port statistics

2019-09-18 Thread Yegor Yefremov
On Wed, Sep 18, 2019 at 1:45 PM Greg KH wrote: > > On Wed, Sep 18, 2019 at 01:22:42PM +0200, Yegor Yefremov wrote: > > On Wed, Sep 18, 2019 at 1:08 PM Greg KH wrote: > > > > > > On Wed, Sep 18, 2019 at 11:14:15AM +0200, yegorsli...@googlemail.com > > > wrote: > > > > From: Yegor Yefremov > > >

Re: [PATCH] USB: serial: add port statistics

2019-09-18 Thread Greg KH
On Wed, Sep 18, 2019 at 01:51:29PM +0200, Yegor Yefremov wrote: > On Wed, Sep 18, 2019 at 1:45 PM Greg KH wrote: > > > > On Wed, Sep 18, 2019 at 01:22:42PM +0200, Yegor Yefremov wrote: > > > On Wed, Sep 18, 2019 at 1:08 PM Greg KH > > > wrote: > > > > > > > > On Wed, Sep 18, 2019 at 11:14:15AM +

[PATCH net,stable] cdc_ncm: fix divide-by-zero caused by invalid wMaxPacketSize

2019-09-18 Thread Bjørn Mork
Endpoints with zero wMaxPacketSize are not usable for transferring data. Ignore such endpoints when looking for valid in, out and status pipes, to make the driver more robust against invalid and meaningless descriptors. The wMaxPacketSize of the out pipe is used as divisor. So this change fixes a

[PATCH net,stable] usbnet: ignore endpoints with invalid wMaxPacketSize

2019-09-18 Thread Bjørn Mork
Endpoints with zero wMaxPacketSize are not usable for transferring data. Ignore such endpoints when looking for valid in, out and status pipes, to make the drivers more robust against invalid and meaningless descriptors. The wMaxPacketSize of these endpoints are used for memory allocations and as

Re: divide error in cdc_ncm_update_rxtx_max

2019-09-18 Thread syzbot
Hello, syzbot has tested the proposed patch and the reproducer did not trigger crash: Reported-and-tested-by: syzbot+ce366e2b8296e25d8...@syzkaller.appspotmail.com Tested on: commit: f0df5c1b usb-fuzzer: main usb gadget fuzzer driver git tree: https://github.com/google/kasa

Re: [RFT PATCH] xhci: Prevent device initiated U1/U2 link pm if exit latency is too long

2019-09-18 Thread Mathias Nyman
On 17.9.2019 18.56, Jan Schmidt wrote: On 18/9/19 12:53 am, Mathias Nyman wrote: If host/hub initiated link pm is prevented by a driver flag we still must ensure that periodic endpoints have longer service intervals than link pm exit latency before allowing device initiated link pm. Fix this

Re: Event ring is full when do iozone test on UAS storage

2019-09-18 Thread Mathias Nyman
On 17.9.2019 12.55, Peter Chen wrote: I met "event ring full error" like below, this error is met when I do iozone test on UAS storage at v4.19.35 kernel, but not meet this error at linux-next tree (08/24). The same host and test UAS storage device are used. This issue is due to xhci_handle_even

Reminder: 52 active syzbot reports in usb subsystem

2019-09-18 Thread Eric Biggers
[This email was generated by a script. Let me know if you have any suggestions to make it better, or if you want it re-generated with the latest status.] Of the syzbot reports that have (re-)occurred in the last 7 days, I've manually marked 52 of them as possibly being bugs in the usb subsystem.

Re: Reminder: 52 active syzbot reports in usb subsystem

2019-09-18 Thread Greg Kroah-Hartman
On Wed, Sep 18, 2019 at 10:23:42PM -0700, Eric Biggers wrote: > [This email was generated by a script. Let me know if you have any > suggestions > to make it better, or if you want it re-generated with the latest status.] > > Of the syzbot reports that have (re-)occurred in the last 7 days, I've