> -Original Message-
> From: Peter Chen
> Sent: 2019年8月8日 17:31
> To: Jun Li
> Cc: gre...@linuxfoundation.org; Jun Li ; dl-linux-imx
> ; linux-usb@vger.kernel.org
> Subject: RE: [PATCH v2 2/2] usb: chipidea: add role switch class support
>
>
> > USB role is fully controlled by usb role
Hi all having use-after-free issues in USB shutdowns:
I hunted for a similar case in the intel_xhci_usb_sw driver.
What i have found and proposed is (from yesterday):
---
[PATCH] kernel/resource.c: invalidate parent when freed resource has childs
When a resource is freed and has children, the chil
Hi,
Benjamin Herrenschmidt writes:
> On Fri, 2019-08-09 at 08:31 +0300, Felipe Balbi wrote:
>> Hi,
>>
>> Benjamin Herrenschmidt writes:
>>
>> > Some host drivers really do not like keyboards having an OUT
>> > endpoint.
>> >
>> > For example, most UEFI forked from EDK2 before 2006 (or was
On Fri, 2019-08-09 at 11:08 +0300, Felipe Balbi wrote:
>
> that works too. Another option would to introduce two options,
> has_input_report and has_output_report and have them true by default.
>
> Then user can even produce an output-only HID device, like these odd
> USB-controlled relays.
Idea
Hello,
syzbot found the following crash on:
HEAD commit:beaab8a3 fix KASAN build
git tree: kmsan
console output: https://syzkaller.appspot.com/x/log.txt?x=13d7b65c60
kernel config: https://syzkaller.appspot.com/x/.config?x=4db781fe35a84ef5
dashboard link: https://syzkaller.appspot
On Thu, Aug 08, 2019 at 11:22:19PM +0200, Arnd Bergmann wrote:
> The omap usb drivers still rely on mach/*.h headers that
> are explicitly or implicitly included, but all the required
> definitions are now in include/linux/soc/ti/, so use those
> instead and allow compile-testing on other architect
On Fri, Aug 09, 2019 at 07:35:32AM +, Schmid, Carsten wrote:
> Hi all having use-after-free issues in USB shutdowns:
> I hunted for a similar case in the intel_xhci_usb_sw driver.
> What i have found and proposed is (from yesterday):
> ---
> [PATCH] kernel/resource.c: invalidate parent when fre
On Fri, Aug 09, 2019 at 08:27:52AM +0300, Felipe Balbi wrote:
>
> Hi,
>
> kbuild test robot writes:
>
> > tree:
> > https://kernel.googlesource.com/pub/scm/linux/kernel/git/balbi/usb.git
> > testing/next
> > head: d06a2c3f683a591efce9d02b2b60ef346df5ae02
> > commit: 2a714ea6d90d9d1b510ba4
On Thu, Aug 08, 2019 at 04:06:32PM -0700, Kees Cook wrote:
> On Thu, Aug 08, 2019 at 02:46:54PM +0200, Greg KH wrote:
> > On Thu, Aug 08, 2019 at 05:38:06AM -0700, syzbot wrote:
> > > Hello,
> > >
> > > syzbot found the following crash on:
> > >
> > > HEAD commit:e96407b4 usb-fuzzer: main usb
syzbot has found a reproducer for the following crash on:
HEAD commit:e96407b4 usb-fuzzer: main usb gadget fuzzer driver
git tree: https://github.com/google/kasan.git usb-fuzzer
console output: https://syzkaller.appspot.com/x/log.txt?x=15b5018c60
kernel config: https://syzkaller.ap
Hi,
Benjamin Herrenschmidt writes:
> On Fri, 2019-08-09 at 11:08 +0300, Felipe Balbi wrote:
>>
>> that works too. Another option would to introduce two options,
>> has_input_report and has_output_report and have them true by default.
>>
>> Then user can even produce an output-only HID device
> -Ursprüngliche Nachricht-
> Von: Greg KH [mailto:gre...@linuxfoundation.org]
> Gesendet: Freitag, 9. August 2019 09:56
> An: Schmid, Carsten
> Cc: Alan Stern ; Andrey Konovalov
> ; Oliver Neukum ;
> syzkaller-bugs ; syzbot
> ; USB list
> ; Hillf Danton
> Betreff: Re: KASAN: use-after-fr
> > > USB role is fully controlled by usb role switch consumer(e.g.
> > > typec), usb port can be at host mode(USB_ROLE_HOST), device mode
> > > connected to host(USB_ROLE_DEVICE), or not connecting any
> parter(USB_ROLE_NONE).
> > >
> >
> > %s/parter/partner ?
>
> Yes, I will update.
>
> >
> >
Hi,
On 8/9/19 11:34 AM, Schmid, Carsten wrote:
-Ursprüngliche Nachricht-
Von: Greg KH [mailto:gre...@linuxfoundation.org]
Gesendet: Freitag, 9. August 2019 09:56
An: Schmid, Carsten
Cc: Alan Stern ; Andrey Konovalov
; Oliver Neukum ;
syzkaller-bugs ; syzbot
; USB list
; Hillf Danton
Be
Hi,
On 08/08/2019 15:47, Felipe Balbi wrote:
>
> Hi,
>
> Marek Szyprowski writes:
>
>> Commit 08f871a3aca2 ("usb: dwc3: host: convey the PHYs to xhci") added
>> forwarding of the generic PHYs from DWC3 core to the instantiated XHCI-plat
>> device. However XHCI(-plat) driver never gained suppor
Pawel,
On 08/08/2019 07:12, Pawel Laszczak wrote:
> Hi Roger,
>
>>
>>
>> On 23/07/2019 07:32, Pawel Laszczak wrote:
>>
>>> Hi,
>>
>>>
>>
On Mon 2019-07-22 13:56:44, Pavel Machek wrote:
>>
> Hi!
>>
>
>>
> This patch introduce new Cadence USBSS DRD driver to linux kernel.
>>
>>
Hi,
Roger Quadros writes:
>> It allows me for testing some functionality using only single board
>> and even with lacking right cable for proper otg detection.
>>
>> So, removing this can cause that testing some functionality
>> will be limited on my boards.
>>
>> If you rely want to remo
Hi,
On 8/9/19 12:47 PM, Schmid, Carsten wrote:
We are talking memory-mapped io here, so it cannot just be "re-used", it
is wat it is. I guess the PCI BAR could be released and then the physical
address the resource was at could be re-used for another piece of MMIo,
but AFAIK outside of PI=CI ho
>
> We are talking memory-mapped io here, so it cannot just be "re-used", it
> is wat it is. I guess the PCI BAR could be released and then the physical
> address the resource was at could be re-used for another piece of MMIo,
> but AFAIK outside of PI=CI hotplug we never release BARs.
>
> Maybe
Hi,
Nagarjuna Kristam writes:
> This patch adds UDC driver for tegra XUSB 3.0 device mode controller.
> XUSB device mode controller supports SS, HS and FS modes
>
> Based on work by:
> Mark Kuo
> Hui Fu
> Andrew Bresticker
>
> Signed-off-by: Nagarjuna Kristam
> Acked-by: Thierry Redin
Hi,
Michał Mirosław writes:
> Rewrite console support to fix a few shortcomings of the old code
> preventing its use with multiple ports. This removes some duplicated
> code and replaces a custom kthread with simpler workqueue item.
>
> Only port ttyGS0 gets to be a console for now.
>
> Signed-
Hi again,
>>
>> Hey, i did not want to trigger an eartquake in the basement of the kernel ;-)
>> My intention was to prevent some crashes, and help developers to find their
>> bugs.
>> I think my patch exactly does this.
>
> Hehe, actually drivers not being able to block unbind has been bugging
On Fri, Aug 09, 2019 at 12:38:35PM +, Schmid, Carsten wrote:
> Hi again,
>
> >>
> >> Hey, i did not want to trigger an eartquake in the basement of the kernel
> >> ;-)
> >> My intention was to prevent some crashes, and help developers to find
> >> their bugs.
> >> I think my patch exactly do
>>
>> @Greg:
>> I am still confident that my patch in __release_region should be taken in.
>
> Ok, submit it in a "real" way and we can consider it :)
>
> thanks,
>
> greg k-h
Already done, linux-ker...@vger.kernel.org, see
https://www.spinics.net/lists/kernel/msg3218180.html
Thanks, and have a n
Hello,
syzbot found the following crash on:
HEAD commit:e96407b4 usb-fuzzer: main usb gadget fuzzer driver
git tree: https://github.com/google/kasan.git usb-fuzzer
console output: https://syzkaller.appspot.com/x/log.txt?x=15ef3cba60
kernel config: https://syzkaller.appspot.com/x/.
Hello,
syzbot found the following crash on:
HEAD commit:e96407b4 usb-fuzzer: main usb gadget fuzzer driver
git tree: https://github.com/google/kasan.git usb-fuzzer
console output: https://syzkaller.appspot.com/x/log.txt?x=102b8c4a60
kernel config: https://syzkaller.appspot.com/x/.
Hello,
syzbot found the following crash on:
HEAD commit:e96407b4 usb-fuzzer: main usb gadget fuzzer driver
git tree: https://github.com/google/kasan.git usb-fuzzer
console output: https://syzkaller.appspot.com/x/log.txt?x=15a16f2660
kernel config: https://syzkaller.appspot.com/x/.
Hello,
syzbot found the following crash on:
HEAD commit:e96407b4 usb-fuzzer: main usb gadget fuzzer driver
git tree: https://github.com/google/kasan.git usb-fuzzer
console output: https://syzkaller.appspot.com/x/log.txt?x=13b29b2660
kernel config: https://syzkaller.appspot.com/x/.
Hello,
syzbot found the following crash on:
HEAD commit:e96407b4 usb-fuzzer: main usb gadget fuzzer driver
git tree: https://github.com/google/kasan.git usb-fuzzer
console output: https://syzkaller.appspot.com/x/log.txt?x=10fbde8c60
kernel config: https://syzkaller.appspot.com/x/.
On Fri, Aug 09, 2019 at 01:00:25PM +, Schmid, Carsten wrote:
> >>
> >> @Greg:
> >> I am still confident that my patch in __release_region should be taken in.
> >
> > Ok, submit it in a "real" way and we can consider it :)
> >
> > thanks,
> >
> > greg k-h
>
> Already done, linux-ker...@vger.ker
On Mon, Aug 5, 2019 at 10:28 AM Bartosz Golaszewski
wrote:
>
> pt., 2 sie 2019 o 13:20 Arnd Bergmann napisał(a):
> >
> > On Fri, Aug 2, 2019 at 9:10 AM Bartosz Golaszewski
> > wrote:
> > > > -#include
> > > > -#include
> > > > +#define _GPREG(x) (x)
> > >
> > > Wha
On Tue, Aug 6, 2019 at 10:02 PM Sylvain Lemieux wrote:
> >
> > + gpio_reg_base = devm_platform_ioremap_resource(pdev, 0);
> > + if (gpio_reg_base)
> > + return -ENXIO;
>
> The probe function will always return an error.
> Please replace the previous 2 lines with:
> i
Hi Nagarjuna,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[cannot apply to v5.3-rc3 next-20190809]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux
Version 2 contains some minor changes based on earlier feedback
and from the 0day build bot testing on other architectures. The
only patch that changed significantly is the one for the gpio driver.
I would suggest we merge this version into the soc tree directly
if there are no further concerns.
The driver hardcodes a hardware I/O address the way one should
generally not do, and this prevents both compile-testing, and
moving the platform to CONFIG_ARCH_MULTIPLATFORM.
Change the code to be independent of the machine headers
to allow those two. Removing the hardcoded address would
be hard a
The only thing that prevents building this driver on other
platforms is the mach/hardware.h include, which is not actually
used here at all, so remove the line and allow CONFIG_COMPILE_TEST.
Acked-by: Greg Kroah-Hartman
Acked-by: Sylvain Lemieux
Signed-off-by: Arnd Bergmann
---
drivers/usb/gad
On Fri, 9 Aug 2019, Greg KH wrote:
> On Thu, Aug 08, 2019 at 04:06:32PM -0700, Kees Cook wrote:
> > On Thu, Aug 08, 2019 at 02:46:54PM +0200, Greg KH wrote:
> > > On Thu, Aug 08, 2019 at 05:38:06AM -0700, syzbot wrote:
> > > > Hello,
> > > >
> > > > syzbot found the following crash on:
> > > >
>
Greg:
See below...
On Fri, 9 Aug 2019, syzbot wrote:
> Hello,
>
> syzbot found the following crash on:
>
> HEAD commit:e96407b4 usb-fuzzer: main usb gadget fuzzer driver
> git tree: https://github.com/google/kasan.git usb-fuzzer
> console output: https://syzkaller.appspot.com/x/log.t
On Fri, Aug 02, 2019 at 05:33:35PM +0900, Yoshihiro Shimoda wrote:
> When a USB device is connected to the host controller and
> the system enters suspend, the following error happens
> in xhci_suspend():
>
> xhci-hcd ee00.usb: WARN: xHC CMD_RUN timeout
>
> Since the firmware/internal C
On Fri, Aug 9, 2019 at 6:51 PM Alan Stern wrote:
>
> Greg:
>
> See below...
>
> On Fri, 9 Aug 2019, syzbot wrote:
>
> > Hello,
> >
> > syzbot found the following crash on:
> >
> > HEAD commit:e96407b4 usb-fuzzer: main usb gadget fuzzer driver
> > git tree: https://github.com/google/kasan
From: Colin Ian King
The variable sendToTransport is being initialized with a value that is
never read and is being re-assigned a little later on. The assignment
is redundant and hence can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King
---
drivers/usb/storage/is
On Thu, Aug 8, 2019 at 9:37 PM Alan Stern wrote:
>
> On Thu, 8 Aug 2019, Andrey Konovalov wrote:
>
> > On Thu, Jul 25, 2019 at 5:09 PM Alan Stern
> > wrote:
> > >
> > > On Thu, 25 Jul 2019, Oliver Neukum wrote:
> > >
> > > > Am Mittwoch, den 24.07.2019, 17:02 -0400 schrieb Alan Stern:
> > > > >
Hello,
syzbot found the following crash on:
HEAD commit:e96407b4 usb-fuzzer: main usb gadget fuzzer driver
git tree: https://github.com/google/kasan.git usb-fuzzer
console output: https://syzkaller.appspot.com/x/log.txt?x=1799392c60
kernel config: https://syzkaller.appspot.com/x/.
Hello,
syzbot has tested the proposed patch and the reproducer did not trigger
crash:
Reported-and-tested-by:
syzbot+30cf45ebfe0b0c484...@syzkaller.appspotmail.com
Tested on:
commit: e96407b4 usb-fuzzer: main usb gadget fuzzer driver
git tree: https://github.com/google/kasa
Hello,
syzbot has tested the proposed patch and the reproducer did not trigger
crash:
Reported-and-tested-by:
syzbot+ef5de9c4f99c4edb4...@syzkaller.appspotmail.com
Tested on:
commit: 6a3599ce usb-fuzzer: main usb gadget fuzzer driver
git tree: https://github.com/google/kasa
syzbot has found a reproducer for the following crash on:
HEAD commit:e96407b4 usb-fuzzer: main usb gadget fuzzer driver
git tree: https://github.com/google/kasan.git usb-fuzzer
console output: https://syzkaller.appspot.com/x/log.txt?x=15bf780e60
kernel config: https://syzkaller.ap
Hello,
syzbot found the following crash on:
HEAD commit:e96407b4 usb-fuzzer: main usb gadget fuzzer driver
git tree: https://github.com/google/kasan.git usb-fuzzer
console output: https://syzkaller.appspot.com/x/log.txt?x=126120e260
kernel config: https://syzkaller.appspot.com/x/.
(Sorry for the resend, I was in HTML mode earlier :S)
Hi,
I'm trying to get up to speed on USB kernel code. Sounds like
dev->intf should have been set to NULL for the error path in
ld_usb_probe() ?
https://elixir.bootlin.com/linux/latest/source/drivers/usb/misc/ldusb.c#L666
On Fri, Aug 9, 2019
>>> I need tracepoints to see what's going on, please collect tracepoints.
>>
>> See attached. Search for "length 16384/16384" to the USB request using
>> sg list. And the transfer stalls at a request with "length 512/512".
>
> which gadget driver is this btw? Let's look at what happened leading u
On Fri, 9 Aug 2019, Prashant Malani wrote:
> Hi,
>
> I'm trying to get up to speed on USB kernel code. Sounds like
> dev->intf should have been set to NULL for the error path in
> ld_usb_probe() ?
Why should it?
After all, dev gets deallocated at the end of ld_usb_probe(), where
ld_usb_delete(
For DRD controllers, the programming guide recommended that
GUSB3PIPECTL.SUSPENDABLE and GUSB2PHYCFG.SUSPHY to be cleared after
power-on reset and only set after the controller initialization is
completed. This can be done after device soft-reset in dwc3_core_init().
This patch makes sure to clear
On Fri, 9 Aug 2019, syzbot wrote:
> Hello,
>
> syzbot found the following crash on:
>
> HEAD commit:e96407b4 usb-fuzzer: main usb gadget fuzzer driver
> git tree: https://github.com/google/kasan.git usb-fuzzer
> console output: https://syzkaller.appspot.com/x/log.txt?x=1799392c60
>
On Fri, 9 Aug 2019, Colin King wrote:
> From: Colin Ian King
>
> The variable sendToTransport is being initialized with a value that is
> never read and is being re-assigned a little later on. The assignment
> is redundant and hence can be removed.
>
> Addresses-Coverity: ("Unused value")
Of w
On Fri, 9 Aug 2019, syzbot wrote:
> syzbot has found a reproducer for the following crash on:
>
> HEAD commit:e96407b4 usb-fuzzer: main usb gadget fuzzer driver
> git tree: https://github.com/google/kasan.git usb-fuzzer
> console output: https://syzkaller.appspot.com/x/log.txt?x=15bf780
On 09/08/2019 20:29, Alan Stern wrote:
> On Fri, 9 Aug 2019, Colin King wrote:
>
>> From: Colin Ian King
>>
>> The variable sendToTransport is being initialized with a value that is
>> never read and is being re-assigned a little later on. The assignment
>> is redundant and hence can be removed.
Hello,
syzbot has tested the proposed patch and the reproducer did not trigger
crash:
Reported-and-tested-by:
syzbot+22ae4e3b9fcc8a5c1...@syzkaller.appspotmail.com
Tested on:
commit: e96407b4 usb-fuzzer: main usb gadget fuzzer driver
git tree: https://github.com/google/kasa
syzbot has found a reproducer for the following crash on:
HEAD commit:e96407b4 usb-fuzzer: main usb gadget fuzzer driver
git tree: https://github.com/google/kasan.git usb-fuzzer
console output: https://syzkaller.appspot.com/x/log.txt?x=13871a4a60
kernel config: https://syzkaller.ap
The ARM w90x900 platform is getting removed, so this driver is obsolete.
Signed-off-by: Arnd Bergmann
---
drivers/usb/host/Kconfig| 6 --
drivers/usb/host/Makefile | 1 -
drivers/usb/host/ehci-w90x900.c | 130
3 files changed, 137 deletions(-)
Am Donnerstag, den 08.08.2019, 20:54 +0200 schrieb Andrey Konovalov:
> On Thu, Jul 25, 2019 at 5:09 PM Alan Stern wrote:
> >
> > On Thu, 25 Jul 2019, Oliver Neukum wrote:
> >
> > > Am Mittwoch, den 24.07.2019, 17:02 -0400 schrieb Alan Stern:
> > > > On Wed, 24 Jul 2019, Oliver Neukum wrote:
> >
On Fri, 9 Aug 2019, syzbot wrote:
> Hello,
>
> syzbot has tested the proposed patch and the reproducer did not trigger
> crash:
>
> Reported-and-tested-by:
> syzbot+22ae4e3b9fcc8a5c1...@syzkaller.appspotmail.com
>
> Tested on:
>
> commit: e96407b4 usb-fuzzer: main usb gadget fuzzer
For consistency with the naming of (most) other documentation files for DT
bindings for Renesas IP blocks rename the Renesas USB3.0 peripheral
documentation file from renesas,usb3.txt to renesas,usb3-peri.txt
This refines a recent rename from renesas_usb3.txt to renesas-usb3.txt.
The motivation is
Hi Simon,
Thanks for your work.
On 2019-08-09 14:37:10 -0700, Simon Horman wrote:
> For consistency with the naming of (most) other documentation files for DT
> bindings for Renesas IP blocks rename the Renesas USB3.0 peripheral
> documentation file from renesas,usb3.txt to renesas,usb3-peri.txt
Hi Simon,
On Fri, Aug 9, 2019 at 11:37 PM Simon Horman wrote:
> For consistency with the naming of (most) other documentation files for DT
> bindings for Renesas IP blocks rename the Renesas USB3.0 peripheral
> documentation file from renesas,usb3.txt to renesas,usb3-peri.txt
>
> This refines a r
63 matches
Mail list logo
