RE: [PATCH net-next 5/5] r8152: change rx_frag_head_sz and rx_max_agg_num dynamically

2019-08-07 Thread Hayes Wang
Jakub Kicinski [mailto:jakub.kicin...@netronome.com] > Sent: Wednesday, August 07, 2019 6:10 AM [...] > Please don't expose those via sysfs. Ethtool's copybreak and descriptor > count should be applicable here, I think. Excuse me. I find struct ethtool_tunable for ETHTOOL_RX_COPYBREAK. How about t

RE: [PATCH 2/5] usb: chipidea: add role switch class support

2019-08-07 Thread Jun Li
> -Original Message- > From: Peter Chen > Sent: 2019年8月7日 10:41 > To: Jun Li ; Peter Chen > Cc: Greg Kroah-Hartman ; dl-linux-imx > ; USB list > Subject: RE: [PATCH 2/5] usb: chipidea: add role switch class support > > > > > > > > > > > > > > > > > > > You may use connect bit at port

[PATCH v2 1/2] usb: chipidea: replace ci_role with usb_role

2019-08-07 Thread jun . li
From: Li Jun Since there is usb_role which has similar definition like ci_role, switch to use usb_role, then we can directly compare usb role with a common definition, this can benifit on usb role switch class support. Signed-off-by: Li Jun --- v1 -> v2 No change for this patch. drivers/usb/c

[PATCH v2 2/2] usb: chipidea: add role switch class support

2019-08-07 Thread jun . li
From: Li Jun USB role is fully controlled by usb role switch consumer(e.g. typec), usb port can be at host mode(USB_ROLE_HOST), device mode connected to host(USB_ROLE_DEVICE), or not connecting any parter(USB_ROLE_NONE). Signed-off-by: Li Jun --- Change for v2: - Support USB_ROLE_NONE, which f

Re: [PATCH] usbfs: Add ioctls for runtime power management

2019-08-07 Thread Oliver Neukum
Am Dienstag, den 06.08.2019, 15:46 -0400 schrieb Alan Stern: > +static int proc_wait_for_resume(struct usb_dev_state *ps) > +{ > + int ret; > + > + usb_unlock_device(ps->dev); > + ret = wait_event_interruptible(ps->wait_for_resume, > + READ_ONCE(ps->not_yet_r

RE: EHSET USB testing

2019-08-07 Thread Felipe Balbi
Hi, Peter Chen writes: >> (Pinging Mathias regarding xHCI support of the USB 2.0 test modes) >> >> On Mon, Aug 05, 2019 at 02:07:23PM +0800, Peter Chen wrote: >> > On Sun, Aug 4, 2019 at 10:45 AM Evan Gates wrote: >> > > >> > > I'm trying to get my device to pass the EHSET tests. I found the

Re: [PATCH] USB: phy: fsl-usb: convert platform driver to use dev_groups

2019-08-07 Thread Greg Kroah-Hartman
te to > help improve the system] > > url: > https://github.com/0day-ci/linux/commits/Greg-Kroah-Hartman/USB-phy-fsl-usb-convert-platform-driver-to-use-dev_groups/20190807-021855 > base: > https://kernel.googlesource.com/pub/scm/linux/kernel/git/gregkh/usb.git > usb-test

Re: [PATCH] usb: setup authorized_default using usb_bus_notify

2019-08-07 Thread Thiébaud Weksteen
Yes, it does. Thanks Thiebaud On Tue, Aug 6, 2019 at 1:37 PM Greg Kroah-Hartman wrote: > > On Tue, Aug 06, 2019 at 01:00:50PM +0200, Thiébaud Weksteen wrote: > > Currently, the authorized_default and interface_authorized_default > > attributes for HCD are set up after the uevent has been sent to

Re: [PATCH v9 2/6] usb:gadget Separated decoding functions from dwc3 driver.

2019-08-07 Thread Roger Quadros
On 05/07/2019 14:44, Pawel Laszczak wrote: > >> EXTERNAL MAIL >> >> >> >> Hi, >> >> Pawel Laszczak writes: >>> diff --git a/include/linux/usb/ch9.h b/include/linux/usb/ch9.h >>> index da82606be605..d388a3a5ab7e 100644 >>> --- a/include/linux/usb/ch9.h >>> +++ b/include/linux/usb/ch9.h >>> @@ -

Re: [PATCH v9 2/6] usb:gadget Separated decoding functions from dwc3 driver.

2019-08-07 Thread Felipe Balbi
Hi, Roger Quadros writes: +extern const char *usb_decode_ctrl(char *str, size_t size, __u8 bRequestType, + __u8 bRequest, __u16 wValue, __u16 wIndex, + __u16 wLength); + >>> >>> where's the stub when !TRACING? >>

RE: [PATCH v9 5/6] usb:cdns3 Add Cadence USB3 DRD Driver

2019-08-07 Thread Felipe Balbi
Hi, Pawel Laszczak writes: >>> +static int cdns3_gadget_start(struct cdns3 *cdns) >>> +{ >>> + struct cdns3_device *priv_dev; >>> + u32 max_speed; >>> + int ret; >>> + >>> + priv_dev = kzalloc(sizeof(*priv_dev), GFP_KERNEL); >>> + if (!priv_dev) >>> + return -ENOMEM; >>> + >

Re: [PATCH v10 0/6] Introduced new Cadence USBSS DRD Driver.

2019-08-07 Thread Roger Quadros
Pawel, On 23/07/2019 07:32, Pawel Laszczak wrote: > Hi, > >> On Mon 2019-07-22 13:56:44, Pavel Machek wrote: >>> Hi! >>> >>> This patch introduce new Cadence USBSS DRD driver to linux kernel. >>> >>> The Cadence USBSS DRD Controller is a highly configurable IP Core which >>> can

Re: EHSET USB testing

2019-08-07 Thread Mathias Nyman
On 7.8.2019 7.25, Rob Weber wrote: Hi Everyone, (Pinging Mathias regarding xHCI support of the USB 2.0 test modes) On Mon, Aug 05, 2019 at 02:07:23PM +0800, Peter Chen wrote: On Sun, Aug 4, 2019 at 10:45 AM Evan Gates wrote: I'm trying to get my device to pass the EHSET tests. I found the

KMSAN: uninit-value in smsc75xx_wait_eeprom

2019-08-07 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:ae0c578a kmsan: include gfp.h from kmsan.h git tree: kmsan console output: https://syzkaller.appspot.com/x/log.txt?x=10e4f47460 kernel config: https://syzkaller.appspot.com/x/.config?x=27abc558ecb16a3b dashboard link: https:/

Re: [PATCH v10 5/6] usb:cdns3 Add Cadence USB3 DRD Driver

2019-08-07 Thread Roger Quadros
Pawel, On 21/07/2019 21:32, Pawel Laszczak wrote: > This patch introduce new Cadence USBSS DRD driver to Linux kernel. > > The Cadence USBSS DRD Controller is a highly configurable IP Core which > can be instantiated as Dual-Role Device (DRD), Peripheral Only and > Host Only (XHCI)configurations.

Re: [PATCH net-next 5/5] r8152: change rx_frag_head_sz and rx_max_agg_num dynamically

2019-08-07 Thread Maciej Fijalkowski
On Wed, 7 Aug 2019 07:12:32 + Hayes Wang wrote: > Jakub Kicinski [mailto:jakub.kicin...@netronome.com] > > Sent: Wednesday, August 07, 2019 6:10 AM > [...] > > Please don't expose those via sysfs. Ethtool's copybreak and descriptor > > count should be applicable here, I think. > > Excuse

Re: possible deadlock in open_rio

2019-08-07 Thread Oliver Neukum
Am Dienstag, den 06.08.2019, 15:13 -0400 schrieb Alan Stern: > On Thu, 1 Aug 2019, syzbot wrote: > > > Hello, > > > > syzbot found the following crash on: > > > > HEAD commit:7f7867ff usb-fuzzer: main usb gadget fuzzer driver > > git tree: https://github.com/google/kasan.git usb-fuzzer

Re: KASAN: use-after-free Read in device_release_driver_internal

2019-08-07 Thread Oliver Neukum
Am Dienstag, den 06.08.2019, 14:50 +0200 schrieb Andrey Konovalov: > On Tue, Aug 6, 2019 at 2:36 PM Oliver Neukum wrote: > > > > Am Donnerstag, den 01.08.2019, 14:47 -0400 schrieb Alan Stern: > > > > > > I think this must be caused by an unbalanced refcount. That is, > > > something must drop o

Re: KASAN: use-after-free Read in device_release_driver_internal

2019-08-07 Thread Andrey Konovalov
On Wed, Aug 7, 2019 at 3:38 PM Oliver Neukum wrote: > > Am Dienstag, den 06.08.2019, 14:50 +0200 schrieb Andrey Konovalov: > > On Tue, Aug 6, 2019 at 2:36 PM Oliver Neukum wrote: > > > > > > Am Donnerstag, den 01.08.2019, 14:47 -0400 schrieb Alan Stern: > > > > > > > > I think this must be caused

Re: KASAN: use-after-free Read in device_release_driver_internal

2019-08-07 Thread Andrey Konovalov
On Wed, Aug 7, 2019 at 3:44 PM Andrey Konovalov wrote: > > On Wed, Aug 7, 2019 at 3:38 PM Oliver Neukum wrote: > > > > Am Dienstag, den 06.08.2019, 14:50 +0200 schrieb Andrey Konovalov: > > > On Tue, Aug 6, 2019 at 2:36 PM Oliver Neukum wrote: > > > > > > > > Am Donnerstag, den 01.08.2019, 14:47

Re: KASAN: use-after-free Read in device_release_driver_internal

2019-08-07 Thread Andrey Konovalov
On Wed, Aug 7, 2019 at 3:44 PM Andrey Konovalov wrote: > > On Wed, Aug 7, 2019 at 3:44 PM Andrey Konovalov wrote: > > > > On Wed, Aug 7, 2019 at 3:38 PM Oliver Neukum wrote: > > > > > > Am Dienstag, den 06.08.2019, 14:50 +0200 schrieb Andrey Konovalov: > > > > On Tue, Aug 6, 2019 at 2:36 PM Oliv

Re: KASAN: use-after-free Read in device_release_driver_internal

2019-08-07 Thread Andrey Konovalov
On Tue, Aug 6, 2019 at 5:34 PM Oliver Neukum wrote: > > Am Dienstag, den 06.08.2019, 10:19 -0400 schrieb Alan Stern: > > In any case, I don't know if this missing "get" would cause the > > problem, but it might well. > > Hi, > > upon further thought, this should be automated. Checking for > refcou

Re: possible deadlock in open_rio

2019-08-07 Thread Andrey Konovalov
On Tue, Aug 6, 2019 at 9:13 PM Alan Stern wrote: > > On Thu, 1 Aug 2019, syzbot wrote: > > > Hello, > > > > syzbot found the following crash on: > > > > HEAD commit:7f7867ff usb-fuzzer: main usb gadget fuzzer driver > > git tree: https://github.com/google/kasan.git usb-fuzzer > > console

Re: KASAN: use-after-free Read in device_release_driver_internal

2019-08-07 Thread syzbot
Hello, syzbot has tested the proposed patch but the reproducer still triggered crash: KASAN: use-after-free Read in device_release_driver_internal usb 4-1: USB disconnect, device number 2 == BUG: KASAN: use-after-free in __lock_a

Re: possible deadlock in open_rio

2019-08-07 Thread Alan Stern
On Wed, 7 Aug 2019, Andrey Konovalov wrote: > On Tue, Aug 6, 2019 at 9:13 PM Alan Stern wrote: > > > > On Thu, 1 Aug 2019, syzbot wrote: > > > > > Hello, > > > > > > syzbot found the following crash on: > > > > > > HEAD commit:7f7867ff usb-fuzzer: main usb gadget fuzzer driver > > > git tree:

Re: WARNING in rollback_registered_many (2)

2019-08-07 Thread Andrey Konovalov
On Fri, Apr 12, 2019 at 1:32 PM Andrey Konovalov wrote: > > On Fri, Apr 12, 2019 at 1:29 AM syzbot > wrote: > > > > syzbot has found a reproducer for the following crash on: > > > > HEAD commit:9a33b369 usb-fuzzer: main usb gadget fuzzer driver > > git tree: https://github.com/google/ka

Re: WARNING in zd_mac_clear

2019-08-07 Thread Andrey Konovalov
On Fri, Apr 12, 2019 at 1:46 PM syzbot wrote: > > Hello, > > syzbot found the following crash on: > > HEAD commit:9a33b369 usb-fuzzer: main usb gadget fuzzer driver > git tree: https://github.com/google/kasan/tree/usb-fuzzer > console output: https://syzkaller.appspot.com/x/log.txt?x=101

Re: possible deadlock in open_rio

2019-08-07 Thread Alan Stern
On Wed, 7 Aug 2019, Oliver Neukum wrote: > Am Dienstag, den 06.08.2019, 15:13 -0400 schrieb Alan Stern: > > On Thu, 1 Aug 2019, syzbot wrote: > > > > > Hello, > > > > > > syzbot found the following crash on: > > > > > > HEAD commit:7f7867ff usb-fuzzer: main usb gadget fuzzer driver > > > gi

Re: KASAN: use-after-free Read in device_release_driver_internal

2019-08-07 Thread syzbot
Hello, syzbot has tested the proposed patch and the reproducer did not trigger crash: Reported-and-tested-by: syzbot+1b2449b7b5dc240d1...@syzkaller.appspotmail.com Tested on: commit: 6a3599ce usb-fuzzer: main usb gadget fuzzer driver git tree: https://github.com/google/kasa

Re: WARNING in zd_mac_clear

2019-08-07 Thread Oliver Neukum
Am Mittwoch, den 07.08.2019, 16:07 +0200 schrieb Andrey Konovalov: > On Fri, Apr 12, 2019 at 1:46 PM syzbot > wrote: > > > > Hello, > > > > syzbot found the following crash on: > > > > HEAD commit:9a33b369 usb-fuzzer: main usb gadget fuzzer driver > > git tree: https://github.com/goog

Re: WARNING in zd_mac_clear

2019-08-07 Thread Kalle Valo
Oliver Neukum writes: > Am Mittwoch, den 07.08.2019, 16:07 +0200 schrieb Andrey Konovalov: >> On Fri, Apr 12, 2019 at 1:46 PM syzbot >> wrote: >> > >> > Hello, >> > >> > syzbot found the following crash on: >> > >> > HEAD commit:9a33b369 usb-fuzzer: main usb gadget fuzzer driver >> > git

Re: possible deadlock in open_rio

2019-08-07 Thread Andrey Konovalov
On Wed, Aug 7, 2019 at 4:01 PM Alan Stern wrote: > > On Wed, 7 Aug 2019, Andrey Konovalov wrote: > > > On Tue, Aug 6, 2019 at 9:13 PM Alan Stern wrote: > > > > > > On Thu, 1 Aug 2019, syzbot wrote: > > > > > > > Hello, > > > > > > > > syzbot found the following crash on: > > > > > > > > HEAD comm

KASAN: use-after-free Read in wdm_int_callback

2019-08-07 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:e96407b4 usb-fuzzer: main usb gadget fuzzer driver git tree: https://github.com/google/kasan.git usb-fuzzer console output: https://syzkaller.appspot.com/x/log.txt?x=162e635260 kernel config: https://syzkaller.appspot.com/x/.

WARNING in hiddev_ioctl/usb_submit_urb

2019-08-07 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:e96407b4 usb-fuzzer: main usb gadget fuzzer driver git tree: https://github.com/google/kasan.git usb-fuzzer console output: https://syzkaller.appspot.com/x/log.txt?x=14f54e2660 kernel config: https://syzkaller.appspot.com/x/.

[PATCH v2] usbfs: Add ioctls for runtime power management

2019-08-07 Thread Alan Stern
It has been requested that usbfs should implement runtime power management, instead of forcing the device to remain at full power as long as the device file is open. This patch introduces that new feature. It does so by adding three new usbfs ioctls: USBDEVFS_FORBID_SUSPEND: Prevents the

Re: possible deadlock in open_rio

2019-08-07 Thread Andrey Konovalov
On Wed, Aug 7, 2019 at 4:24 PM Andrey Konovalov wrote: > > On Wed, Aug 7, 2019 at 4:01 PM Alan Stern wrote: > > > > On Wed, 7 Aug 2019, Andrey Konovalov wrote: > > > > > On Tue, Aug 6, 2019 at 9:13 PM Alan Stern > > > wrote: > > > > > > > > On Thu, 1 Aug 2019, syzbot wrote: > > > > > > > > > He

Re: possible deadlock in open_rio

2019-08-07 Thread Andrey Konovalov
On Wed, Aug 7, 2019 at 4:34 PM Andrey Konovalov wrote: > > On Wed, Aug 7, 2019 at 4:24 PM Andrey Konovalov wrote: > > > > On Wed, Aug 7, 2019 at 4:01 PM Alan Stern wrote: > > > > > > On Wed, 7 Aug 2019, Andrey Konovalov wrote: > > > > > > > On Tue, Aug 6, 2019 at 9:13 PM Alan Stern > > > > wro

Re: possible deadlock in open_rio

2019-08-07 Thread Alan Stern
On Wed, 7 Aug 2019, Andrey Konovalov wrote: > On Wed, Aug 7, 2019 at 4:01 PM Alan Stern wrote: > > > > On Wed, 7 Aug 2019, Andrey Konovalov wrote: > > > > > On Tue, Aug 6, 2019 at 9:13 PM Alan Stern > > > wrote: > > > > > > > > On Thu, 1 Aug 2019, syzbot wrote: > > > > > > > > > Hello, > > > >

Re: WARNING in zd_mac_clear

2019-08-07 Thread syzbot
Hello, syzbot has tested the proposed patch and the reproducer did not trigger crash: Reported-and-tested-by: syzbot+74c65761783d66a9c...@syzkaller.appspotmail.com Tested on: commit: 9a33b369 usb-fuzzer: main usb gadget fuzzer driver git tree: https://github.com/google/kasa

Re: possible deadlock in open_rio

2019-08-07 Thread Andrey Konovalov
On Wed, Aug 7, 2019 at 4:39 PM Alan Stern wrote: > > On Wed, 7 Aug 2019, Andrey Konovalov wrote: > > > On Wed, Aug 7, 2019 at 4:01 PM Alan Stern wrote: > > > > > > On Wed, 7 Aug 2019, Andrey Konovalov wrote: > > > > > > > On Tue, Aug 6, 2019 at 9:13 PM Alan Stern > > > > wrote: > > > > > > > >

Re: EHSET USB testing

2019-08-07 Thread Rob Weber
Hello, On Wed, Aug 07, 2019 at 02:11:03PM +0300, Mathias Nyman wrote: > On 7.8.2019 7.25, Rob Weber wrote: > > Hi Everyone, > > > > (Pinging Mathias regarding xHCI support of the USB 2.0 test modes) > > > > On Mon, Aug 05, 2019 at 02:07:23PM +0800, Peter Chen wrote: > > > On Sun, Aug 4, 2019 at

Re: EHSET USB testing

2019-08-07 Thread Rob Weber
Hi Felipe and Peter, On Wed, Aug 07, 2019 at 10:47:49AM +0300, Felipe Balbi wrote: > Peter Chen writes: > >> (Pinging Mathias regarding xHCI support of the USB 2.0 test modes) > >> > >> On Mon, Aug 05, 2019 at 02:07:23PM +0800, Peter Chen wrote: > >> > On Sun, Aug 4, 2019 at 10:45 AM Evan Gates

Re: KASAN: use-after-free Read in device_release_driver_internal

2019-08-07 Thread Alan Stern
On Wed, 7 Aug 2019, syzbot wrote: > Hello, > > syzbot has tested the proposed patch but the reproducer still triggered > crash: > KASAN: use-after-free Read in device_release_driver_internal > > usb 4-1: USB disconnect, device number 2 >

Re: KASAN: use-after-free Read in device_release_driver_internal

2019-08-07 Thread syzbot
Hello, syzbot has tested the proposed patch but the reproducer still triggered crash: KASAN: use-after-free Read in device_release_driver_internal == BUG: KASAN: use-after-free in __lock_acquire+0x3a5d/0x5340 kernel/locking/loc

Re: KASAN: use-after-free Read in device_release_driver_internal

2019-08-07 Thread Alan Stern
On Wed, 7 Aug 2019, syzbot wrote: > Hello, > > syzbot has tested the proposed patch but the reproducer still triggered > crash: > KASAN: use-after-free Read in device_release_driver_internal > Tested on: > > commit: 6a3599ce usb-fuzzer: main usb gadget fuzzer driver > git tree:

Re: [PATCH net-next 2/5] r8152: replace array with linking list for rx information

2019-08-07 Thread Jakub Kicinski
On Wed, 7 Aug 2019 04:34:24 +, Hayes Wang wrote: > Jakub Kicinski [mailto:jakub.kicin...@netronome.com] > > > static int rtl_stop_rx(struct r8152 *tp) > > > { > > > - int i; > > > + struct list_head *cursor, *next, tmp_list; > > > + unsigned long flags; > > > + > > > + INIT_LIST_HEAD(&tmp_lis

Re: KASAN: use-after-free Read in device_release_driver_internal

2019-08-07 Thread syzbot
Hello, syzbot has tested the proposed patch and the reproducer did not trigger crash: Reported-and-tested-by: syzbot+1b2449b7b5dc240d1...@syzkaller.appspotmail.com Tested on: commit: 6a3599ce usb-fuzzer: main usb gadget fuzzer driver git tree: https://github.com/google/kasa

Re: [PATCH] USB: musb: convert platform driver to use dev_groups

2019-08-07 Thread Bin Liu
On Mon, Aug 05, 2019 at 09:36:32PM +0200, Greg Kroah-Hartman wrote: > Platform drivers now have the option to have the platform core create > and remove any needed sysfs attribute files. So take advantage of that > and do not register "by hand" any sysfs files. > > Cc: Bin Liu > Signed-off-by: G

Re: KASAN: use-after-free Read in device_release_driver_internal

2019-08-07 Thread Alan Stern
On Wed, 7 Aug 2019, syzbot wrote: > Hello, > > syzbot has tested the proposed patch and the reproducer did not trigger > crash: > > Reported-and-tested-by: > syzbot+1b2449b7b5dc240d1...@syzkaller.appspotmail.com > > Tested on: > > commit: 6a3599ce usb-fuzzer: main usb gadget fuzzer

Re: [PATCH v2 2/2] usb: chipidea: add role switch class support

2019-08-07 Thread kbuild test robot
Hi, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [cannot apply to v5.3-rc3 next-20190807] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/jun-li

Re: [RESEND][PATCH] usb: musb: sunxi: propagate devicetree node to glue pdev

2019-08-07 Thread Bin Liu
On Tue, Aug 06, 2019 at 12:34:58PM +0100, Mans Rullgard wrote: > In order for devicetree nodes to be correctly associated with attached > devices, the controller node needs to be propagated to the glue device. > > Signed-off-by: Mans Rullgard Applied. Thanks. -Bin.

BUG: bad usercopy in hidraw_ioctl

2019-08-07 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:e96407b4 usb-fuzzer: main usb gadget fuzzer driver git tree: https://github.com/google/kasan.git usb-fuzzer console output: https://syzkaller.appspot.com/x/log.txt?x=151b292660 kernel config: https://syzkaller.appspot.com/x/.

Re: [PATCH] usb: musb: Fix external abort on non-linefetch for vbus_store

2019-08-07 Thread Bin Liu
On Thu, Aug 08, 2019 at 12:11:46AM +0530, Saurav Girepunje wrote: > Without pm_runtime_{get,put}_sync calls in place, writing > vbus value via /sys causes the error > > "Unhandled fault external abort on non-linefetch" > > Signed-off-by: Saurav Girepunje Thanks for the patch. Can you please mer

Re: BUG: bad usercopy in hidraw_ioctl

2019-08-07 Thread Matthew Wilcox
On Wed, Aug 07, 2019 at 12:28:06PM -0700, syzbot wrote: > usercopy: Kernel memory exposure attempt detected from wrapped address > (offset 0, size 0)! > [ cut here ] > kernel BUG at mm/usercopy.c:98! This report is confusing because the arguments to usercopy_abort() are wro

Re: [PATCH] usb: musb: musb_core.c: Update the function description

2019-08-07 Thread Bin Liu
On Mon, Aug 05, 2019 at 11:43:21PM +0530, Saurav Girepunje wrote: > Update the function description of musb_stage0_irq in musb_core.c I modified this to: usb: musb: core: Update the function description Update the function description of musb_stage0_irq() to remove unused parameter. and applied

Re: [PATCH] usb: musb: Fix a possible null-pointer dereference in musb_handle_intr_connect()

2019-08-07 Thread Bin Liu
On Mon, Jul 29, 2019 at 05:04:28PM +0800, Jia-Ju Bai wrote: > In musb_handle_intr_connect(), there is an if statement on line 783 to > check whether musb->hcd is NULL: > if (musb->hcd) > > When musb->hcd is NULL, it is used on line 797: > musb_host_poke_root_hub(musb); > if (musb->

RE: [PATCH net-next 5/5] r8152: change rx_frag_head_sz and rx_max_agg_num dynamically

2019-08-07 Thread Hayes Wang
Maciej Fijalkowski [mailto:maciejromanfijalkow...@gmail.com] > Sent: Wednesday, August 07, 2019 8:44 PM [...] > > Excuse me. > > I find struct ethtool_tunable for ETHTOOL_RX_COPYBREAK. > > How about the descriptor count? > > Look how drivers implement ethtool's set_ringparam ops. I would check it

RE: EHSET USB testing

2019-08-07 Thread Peter Chen
> > On Wed, Aug 07, 2019 at 10:47:49AM +0300, Felipe Balbi wrote: > > Peter Chen writes: > > >> (Pinging Mathias regarding xHCI support of the USB 2.0 test modes) > > >> > > >> On Mon, Aug 05, 2019 at 02:07:23PM +0800, Peter Chen wrote: > > >> > On Sun, Aug 4, 2019 at 10:45 AM Evan Gates wrote

Re: BUG: bad usercopy in hidraw_ioctl

2019-08-07 Thread Al Viro
On Wed, Aug 07, 2019 at 12:58:21PM -0700, Matthew Wilcox wrote: > On Wed, Aug 07, 2019 at 12:28:06PM -0700, syzbot wrote: > > usercopy: Kernel memory exposure attempt detected from wrapped address > > (offset 0, size 0)! > > [ cut here ] > > kernel BUG at mm/usercopy.c:98! >

Re: 5.2.x kernel: WD 8TB USB Drives: Unaligned partial completion (resid=78, sector_sz=512)

2019-08-07 Thread Martin K. Petersen
Justin, > Attached 2 x brand new Western Digital 8TB USB 3.0 drives awhile back and > ran some file copy tests and was getting these warnings-- is there any way > to avoid these warnings?  I did confirm with parted that the partition was > aligned but this appears to be something related to the

RE: [PATCH v9 2/6] usb:gadget Separated decoding functions from dwc3 driver.

2019-08-07 Thread Pawel Laszczak
Hi, > >Roger Quadros writes: > +extern const char *usb_decode_ctrl(char *str, size_t size, __u8 > bRequestType, > +__u8 bRequest, __u16 wValue, __u16 wIndex, > +__u16 wLength); > + where's the stub when !TRACIN

RE: [PATCH v10 0/6] Introduced new Cadence USBSS DRD Driver.

2019-08-07 Thread Pawel Laszczak
Hi Roger, > > >On 23/07/2019 07:32, Pawel Laszczak wrote: > >> Hi, > >> > >>> On Mon 2019-07-22 13:56:44, Pavel Machek wrote: > Hi! > > This patch introduce new Cadence USBSS DRD driver to linux kernel. > > The Cadence USBSS DRD Controller is a highly configura

Re: [PATCH v1] usb: dwc3: remove the call trace of USBx_GFLADJ

2019-08-07 Thread Felipe Balbi
Hi, Yinbo Zhu writes: > layerscape board sometimes reported some usb call trace, that is due to > kernel sent LPM tokerns automatically when it has no pending transfers > and think that the link is idle enough to enter L1, which procedure will > ask usb register has a recovery,then kernel will

RE: [PATCH V2] usb: dwc3: gadget: trb_dequeue is not updated properly

2019-08-07 Thread Felipe Balbi
Hi, "Yang, Fei" writes: >> I need tracepoints to see what's going on, please collect tracepoints. > > See attached. Search for "length 16384/16384" to the USB request using > sg list. And the transfer stalls at a request with "length 512/512". which gadget driver is this btw? Let's look at wha

slab corruption in 5.3-rc3 while inserting an usb key

2019-08-07 Thread Pavel Machek
Hi! Machine is thinkpad x220. BFQ related? [ 8224.904413] usb 2-1.1.4: Product: Intenso Twister Line [ 8224.904421] usb 2-1.1.4: Manufacturer: Alcor Tech [ 8224.904428] usb 2-1.1.4: SerialNumber: 12102500210755 [ 8224.905778] usb-storage 2-1.1.4:1.0: USB Mass Storage device detected [ 8

Re: slab corruption in 5.3-rc3 while inserting an usb key

2019-08-07 Thread Paolo Valente
Hi, I hope this has to do with the failure reported by Doug. I'm finalizing my fix. I'd appreciate if you could retry with my fix applied. Thanks, Paolo > Il giorno 7 ago 2019, alle ore 12:10, Pavel Machek ha scritto: > > Hi! > > Machine is thinkpad x220. BFQ related? > > > > [ 8224

Re: slab corruption in 5.3-rc3 while inserting an usb key

2019-08-07 Thread Pavel Machek
Hi! > I hope this has to do with the failure reported by Doug. I'm > finalizing my fix. I'd appreciate if you could retry with my fix > applied. Ok, just cc me with the fix ;-). This happened once so far, but I have other crash (when closing chromium) that happens a bit too often, might be rel