Re: BUG: unable to handle kernel paging request in corrupted (2)

2019-07-23 Thread Dmitry Vyukov
On Fri, Jul 19, 2019 at 1:56 PM syzbot wrote: > > syzbot has bisected this bug to: > > commit 9343ac87f2a4e09bf6e27b5f31e72e9e3a82abff > Author: Dave Stevenson > Date: Mon Jun 25 14:07:15 2018 + > > net: lan78xx: Use s/w csum check on VLANs without tag stripping > > bisection log: htt

Re: [PATCH v5 2/6] usb: gadget: u_serial: reimplement console support

2019-07-23 Thread Ladislav Michl
On Tue, Jul 23, 2019 at 10:18:15AM +0800, Baolin Wang wrote: > Hi Michal, > > On Mon, 22 Jul 2019 at 23:26, Michał Mirosław wrote: > > > > Rewrite console support to fix a few shortcomings of the old code > > preventing its use with multiple ports. This removes some duplicated > > code and replac

Re: [PATCH v5 2/6] usb: gadget: u_serial: reimplement console support

2019-07-23 Thread Michał Mirosław
On Tue, Jul 23, 2019 at 10:18:15AM +0800, Baolin Wang wrote: > Hi Michal, > > On Mon, 22 Jul 2019 at 23:26, Michał Mirosław wrote: > > > > Rewrite console support to fix a few shortcomings of the old code > > preventing its use with multiple ports. This removes some duplicated > > code and replac

High-Impact: xhci_hid - "Not enough bandwidth for new device state"

2019-07-23 Thread Frank Bergmann
Dear Linux-USB, https://bugzilla.redhat.com/show_bug.cgi?id=1411604 - This bug is around since 5 years. - Severity: High - "It's not Fedora specific, it's linux in general" There are 671 results in Google for 'USB "Not enough bandwidth for new device state"'. Why does nobody take this on?

Re: High-Impact: xhci_hid - "Not enough bandwidth for new device state"

2019-07-23 Thread Greg KH
On Tue, Jul 23, 2019 at 02:31:18PM +0200, Frank Bergmann wrote: > Dear Linux-USB, > > > https://bugzilla.redhat.com/show_bug.cgi?id=1411604 > > - This bug is around since 5 years. > > - Severity: High > > - "It's not Fedora specific, it's linux in general" > > > There are 671 results in Goog

KASAN: use-after-free Read in hidraw_ioctl

2019-07-23 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:6a3599ce usb-fuzzer: main usb gadget fuzzer driver git tree: https://github.com/google/kasan.git usb-fuzzer console output: https://syzkaller.appspot.com/x/log.txt?x=107e726460 kernel config: https://syzkaller.appspot.com/x/.

WARNING in usbvision_write_reg/usb_submit_urb

2019-07-23 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:6a3599ce usb-fuzzer: main usb gadget fuzzer driver git tree: https://github.com/google/kasan.git usb-fuzzer console output: https://syzkaller.appspot.com/x/log.txt?x=17daca6460 kernel config: https://syzkaller.appspot.com/x/.

kernel BUG at drivers/usb/wusbcore/wusbhc.c:LINE!

2019-07-23 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:6a3599ce usb-fuzzer: main usb gadget fuzzer driver git tree: https://github.com/google/kasan.git usb-fuzzer console output: https://syzkaller.appspot.com/x/log.txt?x=1417be9460 kernel config: https://syzkaller.appspot.com/x/.

INFO: task hung in hwrng_unregister

2019-07-23 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:6a3599ce usb-fuzzer: main usb gadget fuzzer driver git tree: https://github.com/google/kasan.git usb-fuzzer console output: https://syzkaller.appspot.com/x/log.txt?x=1266ca6460 kernel config: https://syzkaller.appspot.com/x/.

WARNING in ati_remote_sendpacket/usb_submit_urb

2019-07-23 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:6a3599ce usb-fuzzer: main usb gadget fuzzer driver git tree: https://github.com/google/kasan.git usb-fuzzer console output: https://syzkaller.appspot.com/x/log.txt?x=14a3cf4c60 kernel config: https://syzkaller.appspot.com/x/.

WARNING: ODEBUG bug in smsusb_term_device

2019-07-23 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:6a3599ce usb-fuzzer: main usb gadget fuzzer driver git tree: https://github.com/google/kasan.git usb-fuzzer console output: https://syzkaller.appspot.com/x/log.txt?x=14d4a74c60 kernel config: https://syzkaller.appspot.com/x/.

INFO: trying to register non-static key in usbtouch_open

2019-07-23 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:6a3599ce usb-fuzzer: main usb gadget fuzzer driver git tree: https://github.com/google/kasan.git usb-fuzzer console output: https://syzkaller.appspot.com/x/log.txt?x=1633092060 kernel config: https://syzkaller.appspot.com/x/.

KASAN: use-after-free Read in usbhid_power

2019-07-23 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:6a3599ce usb-fuzzer: main usb gadget fuzzer driver git tree: https://github.com/google/kasan.git usb-fuzzer console output: https://syzkaller.appspot.com/x/log.txt?x=11b13e7860 kernel config: https://syzkaller.appspot.com/x/.

Re: High-Impact: xhci_hid - "Not enough bandwidth for new device state"

2019-07-23 Thread Greg KH
On Tue, Jul 23, 2019 at 03:12:53PM +0200, Frank Bergmann wrote: > Hi Greg, > > > Thank you for answering! You are my hero. > > > > not much to be done [...] bandwidth > > [...] we can't do the impossible here > > > It is not the bandwidth! That would be easy... > > > 1. USB 3.0 on my Dell X

Re: [PATCH v2 1/2] usbip: Skip DMA mapping and unmapping for urb at vhci

2019-07-23 Thread Suwan Kim
On Mon, Jul 22, 2019 at 02:26:42PM -0600, shuah wrote: > Hi Suwan, > > On 7/5/19 10:43 AM, Suwan Kim wrote: > > vhci doesn’t do DMA for remote device. Actually, the real DMA > > operation is done by network card driver. vhci just passes virtual > > address of the buffer to the network stack, so vh

Re: [PATCH v2 2/2] usbip: Implement SG support to vhci

2019-07-23 Thread Suwan Kim
On Mon, Jul 22, 2019 at 09:51:30PM -0600, shuah wrote: > On 7/5/19 10:43 AM, Suwan Kim wrote: > > There are bugs on vhci with usb 3.0 storage device. Originally, vhci > > doesn't supported SG, so USB storage driver on vhci breaks SG list > > grammar - Currently vhci doesn't support? Yes, that is

Re: High-Impact: xhci_hid - "Not enough bandwidth for new device state"

2019-07-23 Thread Frank Bergmann
Hi! I just want to make the case that this is quite an important issue. I was very surprised to hear from the CIO of one of our customers that they had the same issue. This kept them from offering Ubuntu and an option for their Dell laptops. Like myself, these guys need to run GoToMeeting/We

KASAN: use-after-free Read in device_release_driver_internal

2019-07-23 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:6a3599ce usb-fuzzer: main usb gadget fuzzer driver git tree: https://github.com/google/kasan.git usb-fuzzer console output: https://syzkaller.appspot.com/x/log.txt?x=13f640cc60 kernel config: https://syzkaller.appspot.com/x/.

usb-fuzzer boot error: general protection fault in dma_direct_max_mapping_size

2019-07-23 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:1154c0b0 wip git tree: https://github.com/google/kasan.git usb-fuzzer console output: https://syzkaller.appspot.com/x/log.txt?x=1197774c60 kernel config: https://syzkaller.appspot.com/x/.config?x=b228fb19779df17d dashboard li

[PATCH] USB: serial: option: Add Motorola modem UARTs

2019-07-23 Thread Tony Lindgren
On Motorola Mapphone devices such as Droid 4 there are five USB ports that do not use the same layout as Gobi 1K/2K/etc devices listed in qcserial.c. So we should use qcaux.c or option.c as noted by Dan Williams . As the Motorola USB serial ports have an interrupt endpoint as shown with lsusb -v,

Re: High-Impact: xhci_hid - "Not enough bandwidth for new device state"

2019-07-23 Thread Alan Stern
On Tue, 23 Jul 2019, Frank Bergmann wrote: > Hi! > > > I just want to make the case that this is quite an important issue. I > was very surprised to hear from the CIO of one of our customers that > they had the same issue. This kept them from offering Ubuntu and an > option for their Dell lap

Re: [PATCH v3] usb-storage: Add a limitation for blk_queue_max_hw_sectors()

2019-07-23 Thread Christoph Hellwig
Looks good: Reviewed-by: Christoph Hellwig

Re: usb-fuzzer boot error: general protection fault in dma_direct_max_mapping_size

2019-07-23 Thread Eric Biggers
On Tue, Jul 23, 2019 at 07:48:05AM -0700, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:1154c0b0 wip > git tree: https://github.com/google/kasan.git usb-fuzzer > console output: https://syzkaller.appspot.com/x/log.txt?x=1197774c60 > kernel config:

Re: usb-fuzzer boot error: general protection fault in dma_direct_max_mapping_size

2019-07-23 Thread Andrey Konovalov
On Tue, Jul 23, 2019 at 6:14 PM Eric Biggers wrote: > > On Tue, Jul 23, 2019 at 07:48:05AM -0700, syzbot wrote: > > Hello, > > > > syzbot found the following crash on: > > > > HEAD commit:1154c0b0 wip > > git tree: https://github.com/google/kasan.git usb-fuzzer > > console output: https:

Re: WARNING in snd_usb_motu_microbookii_communicate/usb_submit_urb

2019-07-23 Thread Andrey Konovalov
On Sat, Jul 20, 2019 at 4:14 PM Hillf Danton wrote: > > > On Fri, 19 Jul 2019 11:41:05 -0700 (PDT) > > syzbot has found a reproducer for the following crash on: > > > > HEAD commit:6a3599ce usb-fuzzer: main usb gadget fuzzer driver > > git tree: https://github.com/google/kasan.git usb-fu

WARNING in kbtab_open/usb_submit_urb

2019-07-23 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:6a3599ce usb-fuzzer: main usb gadget fuzzer driver git tree: https://github.com/google/kasan.git usb-fuzzer console output: https://syzkaller.appspot.com/x/log.txt?x=1033419460 kernel config: https://syzkaller.appspot.com/x/.

Re: [PATCH v3] usb: dwc3: gadget: trb_dequeue is not updated properly

2019-07-23 Thread John Stultz
On Thu, Jul 18, 2019 at 6:12 PM Thinh Nguyen wrote: > fei.y...@intel.com wrote: > > From: Fei Yang > > > > If scatter-gather operation is allowed, a large USB request is split into > > multiple TRBs. These TRBs are chained up by setting DWC3_TRB_CTRL_CHN bit > > except the last one which has DWC3

RE: [PATCH v3] usb: dwc3: gadget: trb_dequeue is not updated properly

2019-07-23 Thread Yang, Fei
>> diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c >> index 173f532..88eed49 100644 >> --- a/drivers/usb/dwc3/gadget.c >> +++ b/drivers/usb/dwc3/gadget.c >> @@ -2394,7 +2394,7 @@ static int dwc3_gadget_ep_reclaim_completed_trb(struct >> dwc3_ep *dep, >> if (event->status &

[PATCH v1] usb: dwc2: Switch to use device_property_count_u32()

2019-07-23 Thread Andy Shevchenko
Use use device_property_count_u32() directly, that makes code neater. Signed-off-by: Andy Shevchenko --- drivers/usb/dwc2/params.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c index 55f841a54015..31e090ac9f1e 100644

[PATCH v1] usb: dwc3: Switch to use device_property_count_u32()

2019-07-23 Thread Andy Shevchenko
Use use device_property_count_u32() directly, that makes code neater. Signed-off-by: Andy Shevchenko --- drivers/usb/dwc3/core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index c9bb93a2c81e..98bce85c29d0 100644 --- a/d

[PATCH v1] usb: typec: tcpm: Switch to use fwnode_property_count_uXX()

2019-07-23 Thread Andy Shevchenko
Use use fwnode_property_count_uXX() directly, that makes code neater. Signed-off-by: Andy Shevchenko --- drivers/usb/typec/tcpm/tcpm.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c index fba32d84e578..ec525

[PATCH v1] usb: typec: mux: Switch to use fwnode_property_count_uXX()

2019-07-23 Thread Andy Shevchenko
Use fwnode_property_count_uXX() directly, that makes code neater. Signed-off-by: Andy Shevchenko --- drivers/usb/typec/mux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/typec/mux.c b/drivers/usb/typec/mux.c index 61b7bc58dd81..57907f26f681 100644 --- a/drivers

Re: [PATCH v1] usb: typec: tcpm: Switch to use fwnode_property_count_uXX()

2019-07-23 Thread Guenter Roeck
On Tue, Jul 23, 2019 at 10:37:50PM +0300, Andy Shevchenko wrote: > Use use fwnode_property_count_uXX() directly, that makes code neater. > > Signed-off-by: Andy Shevchenko Reviewed-by: Guenter Roeck > --- > drivers/usb/typec/tcpm/tcpm.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletio

[PATCH] usb: dwc3: Check for IOC/LST bit in both event->status and TRB->ctrl fields

2019-07-23 Thread John Stultz
From: Anurag Kumar Vulisha The present code in dwc3_gadget_ep_reclaim_completed_trb() will check for IOC/LST bit in the event->status and returns if IOC/LST bit is set. This logic doesn't work if multiple TRBs are queued per request and the IOC/LST bit is set on the last TRB of that request. Cons

[PATCH v3 1/7] drivers: Introduce device lookup variants by name

2019-07-23 Thread Suzuki K Poulose
Add a helper to match the device name for device lookup. Also reuse this generic exported helper for the existing bus_find_device_by_name(). and add similar variants for driver/class. Cc: Alessandro Zummo Cc: Alexander Aring Cc: Alexander Shishkin Cc: Alexandre Belloni Cc: Arnd Bergmann Cc: D

[PATCH v3 4/7] drivers: Introduce device lookup variants by device type

2019-07-23 Thread Suzuki K Poulose
Add a helper to match a device by its type and provide wrappers for {bus/class/driver}_find_device() APIs. Cc: Alexander Shishkin Cc: Arnd Bergmann Cc: Harald Freudenberger Cc: Heiko Carstens Cc: linux-usb@vger.kernel.org Cc: Oliver Neukum Cc: Sebastian Andrzej Siewior Cc: Tomas Winkler Cc:

[PATCH v3 3/7] drivers: Introduce device lookup variants by fwnode

2019-07-23 Thread Suzuki K Poulose
Add a helper to match the firmware node handle of a device and provide wrappers for {bus/class/driver}_find_device() APIs to avoid proliferation of duplicate custom match functions. Cc: "David S. Miller" Cc: Doug Ledford Cc: Greg Kroah-Hartman Cc: Heikki Krogerus Cc: Jason Gunthorpe Cc: linux

Re: 5.1.18 oops: echo source > /sys/class/typec/port0/preferred_role

2019-07-23 Thread Guenter Roeck
Hi Doug, On Tue, Jul 23, 2019 at 07:26:34PM -0400, Douglas Gilbert wrote: > Hi, > Apologies if this is not code you maintain or the wrong medium. > No worries. You should copy the respective mailing lists, but I'll do that for you. > I'm experimenting with a NXP OM 13588 board (USB Type C Arduin

Re: [PATCH v2 2/2] usbip: Implement SG support to vhci

2019-07-23 Thread shuah
Hi Suwan, On 7/5/19 10:43 AM, Suwan Kim wrote: There are bugs on vhci with usb 3.0 storage device. Originally, vhci doesn't supported SG, so USB storage driver on vhci breaks SG list into multiple URBs and it causes error that a transfer got terminated too early because the transfer length for o

Reminder: 67 open syzbot bugs in usb subsystem

2019-07-23 Thread Eric Biggers
[This email was generated by a script. Let me know if you have any suggestions to make it better, or if you want it re-generated with the latest status.] Of the currently open syzbot reports against the upstream kernel, I've manually marked 67 of them as possibly being bugs in the usb subsystem.

[PATCH] usb: wusbcore: fix unbalanced get/put cluster_id

2019-07-23 Thread Phong Tran
syzboot reported that https://syzkaller.appspot.com/bug?extid=fd2bd7df88c606eea4ef There is not consitency parameter in cluste_id_get/put calling. In case of getting the id with result is failure, the wusbhc->cluster_id will not be updated and this can not be used for wusb_cluster_id_put(). Teste

Re: [PATCH] USB: serial: option: Add Motorola modem UARTs

2019-07-23 Thread Lars Melin
On 7/23/2019 21:49, Tony Lindgren wrote: +#define MOTOROLA_VENDOR_ID 0x22b8 +#define MOTOROLA_PRODUCT_MDM6600 0x2a70 +#define MOTOROLA_PRODUCT_MDM9600 0x2e0a +#define MOTOROLA_PRODUCT_MDM_RAM_DL0x4281 +#define MOTOROLA_PRODUCT_MDM_QC_DL

Re: 5.1.18 oops: echo source > /sys/class/typec/port0/preferred_role

2019-07-23 Thread Douglas Gilbert
On 2019-07-23 7:55 p.m., Guenter Roeck wrote: Hi Doug, On Tue, Jul 23, 2019 at 07:26:34PM -0400, Douglas Gilbert wrote: Hi, Apologies if this is not code you maintain or the wrong medium. No worries. You should copy the respective mailing lists, but I'll do that for you. I'm experimenting w

Re: High-Impact: xhci_hid - "Not enough bandwidth for new device state"

2019-07-23 Thread Greg KH
On Tue, Jul 23, 2019 at 04:27:51PM +0200, Frank Bergmann wrote: > > configuration of your devices and root hubs > > > I've got a brand new Dell XPX 15 9370 Laptop. No other USB hubs, devices, no > change to any configuration. I chose the model because it is supposed to be > the same that Linus To