Merge the combo uses of cpu_to_le32s and memcpy.
Use put_unaligned_le32 instead.
This simplifies the code.
Signed-off-by: Chuhong Yuan
---
drivers/net/usb/asix_common.c | 9 -
drivers/net/usb/ax88179_178a.c | 11 ---
drivers/net/usb/lan78xx.c | 11 ---
drivers/net/
Hi Serge,
On 19-07-19 13:13, Serge Semin wrote:
> Hello Lucas
>
> On Fri, Jul 19, 2019 at 10:44:05AM +0200, Lucas Stach wrote:
> > This reverts commit 3342ce35a1, as there is no need for this separate
> > property and it breaks compatibility with existing devicetree files
> > (arch/arm64/boot/dts
Hi Felipe,
at 18:51, Felipe Balbi wrote:
Hi,
Kai Heng Feng writes:
Oliver Neukum writes:
Am Dienstag, den 09.07.2019, 21:10 +0800 schrieb Kai-Heng Feng:
Hi Mika and Mathias,
I’ve filed a bug [1] which renders docking station unusable.
I am not sure it's a bug in PCI, Thunderbolt or xH
Hi,
>
>> This patch introduce new Cadence USBSS DRD driver to linux kernel.
>>
>> The Cadence USBSS DRD Controller is a highly configurable IP Core which
>> can be instantiated as Dual-Role Device (DRD), Peripheral Only and
>> Host Only (XHCI)configurations.
>
>I see you are using debugfs to sele
Hi,
>
>On Sun, 2019-07-21 at 19:32 +0100, Pawel Laszczak wrote:
>> Patch moves some decoding functions from driver/usb/dwc3/debug.h driver
>> to driver/usb/common/debug.c file. These moved functions include:
>[]
>> diff --git a/drivers/usb/common/debug.c b/drivers/usb/common/debug.c
>[]
>> +static
>
>
>On Sun, 2019-07-21 at 19:32 +0100, Pawel Laszczak wrote:
>> Patch adds usb_decode_test_mode and usb_decode_device_feature functions,
>> which allow to make more readable and simplify the
>> usb_decode_set_clear_feature function.
>
> I need to read entire patch series before
>commenting more I
This patch fixes an issue that the following error happens on
swiotlb environment:
xhci-hcd ee00.usb: swiotlb buffer is full (sz: 524288 bytes), total
32768 (slots), used 1338 (slots)
On the kernel v5.1, block settings of a usb-storage with SuperSpeed
were the following so that the b
On Mon, Jul 22, 2019 at 09:58:42AM +, Pawel Laszczak wrote:
> Hi,
>
> >
> >> This patch introduce new Cadence USBSS DRD driver to linux kernel.
> >>
> >> The Cadence USBSS DRD Controller is a highly configurable IP Core which
> >> can be instantiated as Dual-Role Device (DRD), Peripheral Only
On Mon, Jul 22, 2019 at 10:06:38AM +, Pawel Laszczak wrote:
> Hi,
>
> >
> >On Sun, 2019-07-21 at 19:32 +0100, Pawel Laszczak wrote:
> >> Patch moves some decoding functions from driver/usb/dwc3/debug.h driver
> >> to driver/usb/common/debug.c file. These moved functions include:
> >[]
> >> dif
Hi!
> > >> This patch introduce new Cadence USBSS DRD driver to linux kernel.
> > >>
> > >> The Cadence USBSS DRD Controller is a highly configurable IP Core which
> > >> can be instantiated as Dual-Role Device (DRD), Peripheral Only and
> > >> Host Only (XHCI)configurations.
> > >
> > >I see you
On Mon, Jul 22, 2019 at 01:56:45PM +0200, Pavel Machek wrote:
> Hi!
>
> > > >> This patch introduce new Cadence USBSS DRD driver to linux kernel.
> > > >>
> > > >> The Cadence USBSS DRD Controller is a highly configurable IP Core which
> > > >> can be instantiated as Dual-Role Device (DRD), Periph
>
>Hi!
>
>> > >> This patch introduce new Cadence USBSS DRD driver to linux kernel.
>> > >>
>> > >> The Cadence USBSS DRD Controller is a highly configurable IP Core which
>> > >> can be instantiated as Dual-Role Device (DRD), Peripheral Only and
>> > >> Host Only (XHCI)configurations.
>> > >
>> >
Hello,
syzbot found the following crash on:
HEAD commit:6a3599ce usb-fuzzer: main usb gadget fuzzer driver
git tree: https://github.com/google/kasan.git usb-fuzzer
console output: https://syzkaller.appspot.com/x/log.txt?x=138da9d060
kernel config: https://syzkaller.appspot.com/x/.
Hello,
syzbot found the following crash on:
HEAD commit:6a3599ce usb-fuzzer: main usb gadget fuzzer driver
git tree: https://github.com/google/kasan.git usb-fuzzer
console output: https://syzkaller.appspot.com/x/log.txt?x=111a1ed060
kernel config: https://syzkaller.appspot.com/x/.
Hi Mathias,
around 1.5 weeks ago I've sent the dmesg log and xhci_hcd tracing file to you.
Is there anything else that needs to be provided? How should we precede
otherwise?
The problem occurs since kernel version 4.20 and it looks like more and more
people are affected by this, most of them b
gserial_alloc_line() misses locking (for a release barrier) while
resetting port entry on TTY allocation failure. Fix this.
Cc: sta...@vger.kernel.org
Signed-off-by: Michał Mirosław
Reviewed-by: Greg Kroah-Hartman
Tested-by: Ladislav Michl
---
v4: no changes
v3: cc-stable
v2: no changes
Prevent OBEX serial port from ever becoming a console. Console messages
will definitely break the protocol, and since you have to instantiate
the port making it explicitly for OBEX, there is no point in allowing
console to break it by mistake.
Signed-off-by: Michał Mirosław
Reviewed-by: Greg Kroa
This series makes it possible to have more control over console using
USB serial gadget ports. This can be useful when you need more than
one USB console or are configuring multiple serial port function via
configfs.
The patches are against usb-next tree. You can also pull from:
https://rere.qm
Legacy serial USB gadget is still useful as an early console,
before userspace is up. Later it could be replaced with proper
configfs-configured composite gadget - that use case is enabled
by this patch.
Signed-off-by: Michał Mirosław
---
v4: initial revision, new in the patchset
---
drivers
Insert markers in console stream marking places where data
is missing. This makes the hole in the data stand out clearly
instead of glueing together unrelated messages.
Example output as seen from USB host side:
[0.064078] pinctrl core: registered pin 16 (UART3_RTS_N PC0) on
7868.pinmux
Rewrite console support to fix a few shortcomings of the old code
preventing its use with multiple ports. This removes some duplicated
code and replaces a custom kthread with simpler workqueue item.
Only port ttyGS0 gets to be a console for now.
Signed-off-by: Michał Mirosław
Reviewed-by: Greg K
Allow configuring more than one console using USB serial or ACM gadget.
By default, only first (ttyGS0) is a console, but this may be changed
using function's new "console" attribute.
Signed-off-by: Michał Mirosław
---
v4: fixed locking in gserial_set_console()
v3: no changes
v2: no chang
This series makes it possible to have more control over console using
USB serial gadget ports. This can be useful when you need more than
one USB console or are configuring multiple serial port function via
configfs.
The patches are against usb-next tree. You can also pull from:
https://rere.qm
gserial_alloc_line() misses locking (for a release barrier) while
resetting port entry on TTY allocation failure. Fix this.
Cc: sta...@vger.kernel.org
Signed-off-by: Michał Mirosław
Reviewed-by: Greg Kroah-Hartman
Tested-by: Ladislav Michl
---
v5: no changes
v4: no changes
v3: cc-stable
Insert markers in console stream marking places where data
is missing. This makes the hole in the data stand out clearly
instead of glueing together unrelated messages.
Example output as seen from USB host side:
[0.064078] pinctrl core: registered pin 16 (UART3_RTS_N PC0) on
7868.pinmux
Rewrite console support to fix a few shortcomings of the old code
preventing its use with multiple ports. This removes some duplicated
code and replaces a custom kthread with simpler workqueue item.
Only port ttyGS0 gets to be a console for now.
Signed-off-by: Michał Mirosław
Reviewed-by: Greg K
Allow configuring more than one console using USB serial or ACM gadget.
By default, only first (ttyGS0) is a console, but this may be changed
using function's new "console" attribute.
Signed-off-by: Michał Mirosław
---
v5: fixed locking in gserial_get_console()
v4: fixed locking in gserial_
Prevent OBEX serial port from ever becoming a console. Console messages
will definitely break the protocol, and since you have to instantiate
the port making it explicitly for OBEX, there is no point in allowing
console to break it by mistake.
Signed-off-by: Michał Mirosław
Reviewed-by: Greg Kroa
Legacy serial USB gadget is still useful as an early console,
before userspace is up. Later it could be replaced with proper
configfs-configured composite gadget - that use case is enabled
by this patch.
Signed-off-by: Michał Mirosław
---
v5: no changes
v4: initial revision, new in the patch
Hi Kishon,
On 2019-07-19 14:25, Kishon Vijay Abraham I wrote:
> On 19/07/19 5:51 PM, Marek Szyprowski wrote:
>> On 2019-07-19 12:04, Kishon Vijay Abraham I wrote:
>>> On 19/07/19 3:22 PM, Marek Szyprowski wrote:
Commit 36914111e682 ("drivers: phy: add calibrate method") added support
for
Commit 36914111e682 ("drivers: phy: add calibrate method") added support
for generic phy_calibrate() method, but it didn't explain in detail when
such method is supposed to be called. Add some more documentation directly
to the phy.h to make it clean that it is intended to be called after every
hos
Hi Marek,
On Fri, 19 Jul 2019 at 13:43, Marek Szyprowski wrote:
>
> Some PHYs (for example Exynos5 USB3.0 DRD PHY) require calibration to be
> done after every USB HCD reset. Generic PHY framework has been already
> extended with phy_calibrate() function in commit 36914111e682 ("drivers:
> phy: a
Hi Marek,
On Fri, 19 Jul 2019 at 13:43, Marek Szyprowski wrote:
>
> Calls to USB2 generic PHY calibrate() method has been moved to HCD core,
> which now successfully handles generic PHYs and their calibration after
> every HCD reset. This fixes all the timing issues related to PHY
> calibration d
From: Chuhong Yuan
Date: Fri, 19 Jul 2019 15:36:15 +0800
> Merge the combo use of memcpy and lexx_to_cpus.
> Use get_unaligned_lexx instead.
> This simplifies the code.
>
> Signed-off-by: Chuhong Yuan
Applied.
From: Chuhong Yuan
Date: Fri, 19 Jul 2019 16:27:31 +0800
> Merge the combo use of memcpy and le32_to_cpus.
> Use get_unaligned_le32 instead.
> This simplifies the code.
>
> Signed-off-by: Chuhong Yuan
Applied.
From: Chuhong Yuan
Date: Fri, 19 Jul 2019 17:07:15 +0800
> Merge the combo use of memcpy and le32_to_cpus.
> Use get_unaligned_le32 instead.
> This simplifies the code.
>
> Signed-off-by: Chuhong Yuan
Applied.
Hi Suwan,
On 7/5/19 10:43 AM, Suwan Kim wrote:
vhci doesn’t do DMA for remote device. Actually, the real DMA
operation is done by network card driver. vhci just passes virtual
address of the buffer to the network stack, so vhci doesn’t use and
need dma address of the buffer of the URB.
When it
On Mon 2019-07-22 13:56:44, Pavel Machek wrote:
> Hi!
>
> > > >> This patch introduce new Cadence USBSS DRD driver to linux kernel.
> > > >>
> > > >> The Cadence USBSS DRD Controller is a highly configurable IP Core which
> > > >> can be instantiated as Dual-Role Device (DRD), Peripheral Only and
Hi,
I have a USB keyboard that works in UEFI apps (and grub) but if plugged
into a dock stops working when Linux boots. It works when hotplugged
into the dock or plugged into the laptop directly before or after
booting. A mouse plugged into the dock does not share this problem. (I
have no other ke
From: Chuhong Yuan
Date: Mon, 22 Jul 2019 15:41:34 +0800
> Merge the combo uses of cpu_to_le32s and memcpy.
> Use put_unaligned_le32 instead.
> This simplifies the code.
>
> Signed-off-by: Chuhong Yuan
Isn't the skb->data aligned to 4 bytes in these situations?
If so, we should use the aligne
David Miller 于2019年7月23日周二 上午9:22写道：
>
> From: Chuhong Yuan
> Date: Mon, 22 Jul 2019 15:41:34 +0800
>
> > Merge the combo uses of cpu_to_le32s and memcpy.
> > Use put_unaligned_le32 instead.
> > This simplifies the code.
> >
> > Signed-off-by: Chuhong Yuan
>
> Isn't the skb->data aligned to 4 by
Hi Michal,
On Mon, 22 Jul 2019 at 23:26, Michał Mirosław wrote:
>
> Rewrite console support to fix a few shortcomings of the old code
> preventing its use with multiple ports. This removes some duplicated
> code and replaces a custom kthread with simpler workqueue item.
Could you elaborate on wh
Use devm_reset_controller_register to get rid
of manual unregistration.
Signed-off-by: Chuhong Yuan
---
drivers/usb/chipidea/ci_hdrc_msm.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/usb/chipidea/ci_hdrc_msm.c
b/drivers/usb/chipidea/ci_hdrc_msm.c
index bb4645a
i , Greg Kroah-Hartman
, Ladislav Michl
Hi "Micha??,
I love your patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[cannot apply to v5.3-rc1 next-20190722]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
From: Chuhong Yuan
Date: Tue, 23 Jul 2019 10:16:27 +0800
> David Miller 于2019年7月23日周二 上午9:22写道：
>>
>> From: Chuhong Yuan
>> Date: Mon, 22 Jul 2019 15:41:34 +0800
>>
>> > Merge the combo uses of cpu_to_le32s and memcpy.
>> > Use put_unaligned_le32 instead.
>> > This simplifies the code.
>> >
>>
On 7/5/19 10:43 AM, Suwan Kim wrote:
There are bugs on vhci with usb 3.0 storage device. Originally, vhci
doesn't supported SG, so USB storage driver on vhci breaks SG list
grammar - Currently vhci doesn't support?
into multiple URBs and it causes error that a transfer got terminated
too earl
Hi,
>On Mon 2019-07-22 13:56:44, Pavel Machek wrote:
>> Hi!
>>
>> > > >> This patch introduce new Cadence USBSS DRD driver to linux kernel.
>> > > >>
>> > > >> The Cadence USBSS DRD Controller is a highly configurable IP Core
>> > > >> which
>> > > >> can be instantiated as Dual-Role Device (DRD
47 matches
Mail list logo
