Re: Titan Ridge xHCI may stop to working after re-plugging the dock

2019-07-19 Thread Felipe Balbi
Hi, Oliver Neukum writes: > Am Dienstag, den 09.07.2019, 21:10 +0800 schrieb Kai-Heng Feng: >> Hi Mika and Mathias, >> >> I’ve filed a bug [1] which renders docking station unusable. >> >> I am not sure it's a bug in PCI, Thunderbolt or xHCI so raise the issue to >> you both. >> >> [1] http

RE: [PATCH V2] usb: dwc3: gadget: trb_dequeue is not updated properly

2019-07-19 Thread Felipe Balbi
"Yang, Fei" writes: Hi, >> Can only be true for last TRB >> > | if (event->status & DEPEVT_STATUS_IOC) > | return 1; > > This is the problem. The whole USB request gets only one interrupt > when the last TRB completes, so dwc3_gadget_ep_reclaim_trb_sg() gets > called with event->

Re: [PATCH v3] usb: dwc3: gadget: trb_dequeue is not updated properly

2019-07-19 Thread Felipe Balbi
Hi, fei.y...@intel.com writes: > From: Fei Yang > > If scatter-gather operation is allowed, a large USB request is split into > multiple TRBs. These TRBs are chained up by setting DWC3_TRB_CTRL_CHN bit > except the last one which has DWC3_TRB_CTRL_IOC bit set instead. > Since only the last TRB h

KASAN: global-out-of-bounds Read in dvb_pll_attach

2019-07-19 Thread Vandana BN
#syz test: https://github.com/google/kasan.git usb-fuzzer >From 47fdaac830354fdf1775cd6e41a545148557e6e7 Mon Sep 17 00:00:00 2001 From: Vandana BN Date: Wed, 17 Jul 2019 02:48:06 +0530 Subject: [PATCH] media:dvb-frontends:Remove dvb_pll_devcount and id module parameters. Syzbot reported global-

[PATCH] net: lan78xx: Merge memcpy + lexx_to_cpus to get_unaligned_lexx

2019-07-19 Thread Chuhong Yuan
Merge the combo use of memcpy and lexx_to_cpus. Use get_unaligned_lexx instead. This simplifies the code. Signed-off-by: Chuhong Yuan --- drivers/net/usb/lan78xx.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx

Re: KASAN: global-out-of-bounds Read in dvb_pll_attach

2019-07-19 Thread syzbot
Hello, syzbot has tested the proposed patch and the reproducer did not trigger crash: Reported-and-tested-by: syzbot+8a8f48672560c8ca5...@syzkaller.appspotmail.com Tested on: commit: 6a3599ce usb-fuzzer: main usb gadget fuzzer driver git tree: https://github.com/google/kasa

[PATCH v2 0/2] Fix USB3.0 DRD PHY calibration issues (DWC3/XHCI) on Exynos542x SoCs

2019-07-19 Thread Marek Szyprowski
Dear All, Commit d8c80bb3b55b ("phy: exynos5-usbdrd: Calibrate LOS levels for exynos5420/5800") added support for Exynos5 USB3.0 DRD PHY calibration, what enabled proper Super-Speed enumeration of USB3.0 devices connected to various Exynos5 SoCs. After some time it turned out that the mentioned pa

[PATCH v2 1/2] usb: core: phy: add support for PHY calibration

2019-07-19 Thread Marek Szyprowski
Some PHYs (for example Exynos5 USB3.0 DRD PHY) require calibration to be done after every USB HCD reset. Generic PHY framework has been already extended with phy_calibrate() function in commit 36914111e682 ("drivers: phy: add calibrate method"). This patch adds support for it to generic PHY handlin

[PATCH v2 2/2] usb: dwc3: remove generic PHY calibrate() calls

2019-07-19 Thread Marek Szyprowski
Calls to USB2 generic PHY calibrate() method has been moved to HCD core, which now successfully handles generic PHYs and their calibration after every HCD reset. This fixes all the timing issues related to PHY calibration done directly from DWC3 driver: incorrect operation after system suspend/resu

[PATCH] usbnet: smsc75xx: Merge memcpy + le32_to_cpus to get_unaligned_le32

2019-07-19 Thread Chuhong Yuan
Merge the combo use of memcpy and le32_to_cpus. Use get_unaligned_le32 instead. This simplifies the code. Signed-off-by: Chuhong Yuan --- drivers/net/usb/smsc75xx.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/net/usb/smsc75xx.c b/drivers/net/usb/smsc75xx.

[PATCH 2/3] Revert "usb: usb251xb: Add US port lanes inversion property"

2019-07-19 Thread Lucas Stach
This property isn't needed and not yet used anywhere. The swap-dx-lanes property is perfectly fine for doing the swap on the upstream port lanes. CC: sta...@vger.kernel.org #5.2 Signed-off-by: Lucas Stach --- drivers/usb/misc/usb251xb.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/driver

[PATCH 3/3] usb: usb251xb: Reallow swap-dx-lanes to apply to the upstream port

2019-07-19 Thread Lucas Stach
This is a partial revert of 73d31def1aab "usb: usb251xb: Create a ports field collector method", which broke a existing devicetree (arch/arm64/boot/dts/freescale/imx8mq.dtsi). There is no reason why the swap-dx-lanes property should not apply to the upstream port. The reason given in the breaking

[PATCH 1/3] Revert "usb: usb251xb: Add US lanes inversion dts-bindings"

2019-07-19 Thread Lucas Stach
This reverts commit 3342ce35a1, as there is no need for this separate property and it breaks compatibility with existing devicetree files (arch/arm64/boot/dts/freescale/imx8mq.dtsi). CC: sta...@vger.kernel.org #5.2 Signed-off-by: Lucas Stach --- Documentation/devicetree/bindings/usb/usb251xb.txt

[PATCH] ax88179_178a: Merge memcpy + le32_to_cpus to get_unaligned_le32

2019-07-19 Thread Chuhong Yuan
Merge the combo use of memcpy and le32_to_cpus. Use get_unaligned_le32 instead. This simplifies the code. Signed-off-by: Chuhong Yuan --- drivers/net/usb/ax88179_178a.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_

[PATCH] phy: exynos5-usbdrd: Calibrating makes sense only for USB2.0 PHY

2019-07-19 Thread Marek Szyprowski
PHY calibration is needed only for USB2.0 (UTMI) PHY, so skip calling calibration code when phy_calibrate() is called for USB3.0 (PIPE3) PHY. Fixes: d8c80bb3b55b ("phy: exynos5-usbdrd: Calibrate LOS levels for exynos5420/5800") Signed-off-by: Marek Szyprowski --- drivers/phy/samsung/phy-exynos5

[PATCH] usb: dwc3: remove generic PHYs forwarding for XHCI device

2019-07-19 Thread Marek Szyprowski
Commit 08f871a3aca2 ("usb: dwc3: host: convey the PHYs to xhci") added forwarding of the generic PHYs from DWC3 core to the instantiated XHCI-plat device. However XHCI(-plat) driver never gained support for generic PHYs, thus the lookup added by that commit is never used. In meantime the commit d64

[PATCH] phy: core: document calibrate() method

2019-07-19 Thread Marek Szyprowski
Commit 36914111e682 ("drivers: phy: add calibrate method") added support for generic phy_calibrate() method, but it didn't explain in detail when such method is supposed to be called. Add some more documentation directly to the phy.h to make it clean that it is intended to be called after every hos

Re: [PATCH] phy: core: document calibrate() method

2019-07-19 Thread Kishon Vijay Abraham I
Hi Marek, On 19/07/19 3:22 PM, Marek Szyprowski wrote: > Commit 36914111e682 ("drivers: phy: add calibrate method") added support > for generic phy_calibrate() method, but it didn't explain in detail when > such method is supposed to be called. Add some more documentation directly > to the phy.h t

Re: USB Modem support for Droid 4

2019-07-19 Thread Pavel Machek
Hi! > * Pavel Machek [190718 20:17]: > > From: Tony Lindgren > > > > Droid starts to have useful support in linux-next. Modem is tricky to > > play with, but this is enough to get basic support. > > Below is a better patch using option driver adding support for all > the ports. I'll send it ou

Re: [PATCH 1/3] Revert "usb: usb251xb: Add US lanes inversion dts-bindings"

2019-07-19 Thread Serge Semin
Hello Lucas On Fri, Jul 19, 2019 at 10:44:05AM +0200, Lucas Stach wrote: > This reverts commit 3342ce35a1, as there is no need for this separate > property and it breaks compatibility with existing devicetree files > (arch/arm64/boot/dts/freescale/imx8mq.dtsi). > Hmm, didn't know there had been

Re: Titan Ridge xHCI may stop to working after re-plugging the dock

2019-07-19 Thread Kai Heng Feng
Hi Felipe, at 3:23 PM, Felipe Balbi wrote: Hi, Oliver Neukum writes: Am Dienstag, den 09.07.2019, 21:10 +0800 schrieb Kai-Heng Feng: Hi Mika and Mathias, I’ve filed a bug [1] which renders docking station unusable. I am not sure it's a bug in PCI, Thunderbolt or xHCI so raise the issue

Re: Titan Ridge xHCI may stop to working after re-plugging the dock

2019-07-19 Thread Felipe Balbi
Hi, Kai Heng Feng writes: >> Oliver Neukum writes: >>> Am Dienstag, den 09.07.2019, 21:10 +0800 schrieb Kai-Heng Feng: Hi Mika and Mathias, I’ve filed a bug [1] which renders docking station unusable. I am not sure it's a bug in PCI, Thunderbolt or xHCI so raise the iss

Re: BUG: unable to handle kernel paging request in corrupted (2)

2019-07-19 Thread syzbot
syzbot has bisected this bug to: commit 9343ac87f2a4e09bf6e27b5f31e72e9e3a82abff Author: Dave Stevenson Date: Mon Jun 25 14:07:15 2018 + net: lan78xx: Use s/w csum check on VLANs without tag stripping bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=102feb8460 start c

Re: [PATCH] phy: core: document calibrate() method

2019-07-19 Thread Marek Szyprowski
Hi Kishon, On 2019-07-19 12:04, Kishon Vijay Abraham I wrote: > Hi Marek, > > On 19/07/19 3:22 PM, Marek Szyprowski wrote: >> Commit 36914111e682 ("drivers: phy: add calibrate method") added support >> for generic phy_calibrate() method, but it didn't explain in detail when >> such method is suppo

[PATCH] phy: samsung: disable bind/unbind platform driver feature

2019-07-19 Thread Marek Szyprowski
Samsung PHY drivers control the power to the SoC core components needed by their client devices (USB HCDs, SATA, camera ISP bridge, DP encoder) to properly operate. Disabling PHYs in runtime usually causes the client device to crash with external abort exception or similar issue due to lack of API

Re: [PATCH] phy: core: document calibrate() method

2019-07-19 Thread Kishon Vijay Abraham I
Hi Marek, On 19/07/19 5:51 PM, Marek Szyprowski wrote: > Hi Kishon, > > On 2019-07-19 12:04, Kishon Vijay Abraham I wrote: >> Hi Marek, >> >> On 19/07/19 3:22 PM, Marek Szyprowski wrote: >>> Commit 36914111e682 ("drivers: phy: add calibrate method") added support >>> for generic phy_calibrate() m

RE: [PATCH] net: lan78xx: Merge memcpy + lexx_to_cpus to get_unaligned_lexx

2019-07-19 Thread Woojung.Huh
> From: Chuhong Yuan > Sent: Friday, July 19, 2019 3:36 AM > Cc: Woojung Huh - C21699 ; UNGLinuxDriver > ; David S . Miller ; > net...@vger.kernel.org; linux-usb@vger.kernel.org; > linux-ker...@vger.kernel.org; Chuhong Yuan > > Subject: [PATCH] net: lan78xx: Merge memcpy + lexx_to_cpus to > get

Re: USB Modem support for Droid 4

2019-07-19 Thread Greg KH
On Thu, Jul 18, 2019 at 10:17:13PM +0200, Pavel Machek wrote: > From: Tony Lindgren > > Droid starts to have useful support in linux-next. Modem is tricky to > play with, but this is enough to get basic support. > > Signed-off-by: Pavel Machek No signed-off-by from Tony? And no [PATCH] in the

Re: WARNING in snd_usb_motu_microbookii_communicate/usb_submit_urb

2019-07-19 Thread syzbot
syzbot has found a reproducer for the following crash on: HEAD commit:6a3599ce usb-fuzzer: main usb gadget fuzzer driver git tree: https://github.com/google/kasan.git usb-fuzzer console output: https://syzkaller.appspot.com/x/log.txt?x=149006d060 kernel config: https://syzkaller.ap

Re: [PATCH v2 0/2] usbip: Implement SG support

2019-07-19 Thread shuah
On 7/5/19 10:43 AM, Suwan Kim wrote: There are bugs on vhci with usb 3.0 storage device. Originally, vhci doesn't supported SG, so USB storage driver on vhci breaks SG list into multiple URBs and it causes error that a transfer got terminated too early because the transfer length for one of the U