Re: Kernel crash with FTDI FT232R on AMD boards.

2019-05-20 Thread starost...@gmail.com
Dne 16.5.2019 v 15:56 Johan Hovold napsal(a): On Thu, May 16, 2019 at 03:35:42PM +0200, starost...@gmail.com wrote: You should mention that you're using libusb and the vendor's ftdi library. Specifically, the kernels ftdi_sio driver is not involved. Sorry, you are right, I use libftd2xx drivers v

Re: [PATCH v2 6/8] ARM: dts: imx7ulp: add imx7ulp USBOTG1 support

2019-05-20 Thread Shawn Guo
On Tue, May 14, 2019 at 07:38:21AM +, Peter Chen wrote: > Add imx7ulp USBOTG1 support. > > Signed-off-by: Peter Chen > --- > arch/arm/boot/dts/imx7ulp.dtsi | 31 +++ > 1 file changed, 31 insertions(+) > > diff --git a/arch/arm/boot/dts/imx7ulp.dtsi b/arch/arm/boo

Re: Kernel crash with FTDI FT232R on AMD boards.

2019-05-20 Thread starost...@gmail.com
Dne 16.5.2019 v 16:34 Mathias Nyman napsal(a): To get xhci traces and logs please do: mount -t debugfs none /sys/kernel/debug I get message: mount: /sys/kernel/debug: none already mounted or mount point busy. echo 'module xhci_hcd =p' >/sys/kernel/debug/dynamic_debug/control echo 'module usbc

RE: [PATCH 1/4] i2c: nvidia-gpu: add runtime pm support

2019-05-20 Thread Ajay Gupta
Hi Wolfram, > -Original Message- > From: Wolfram Sang > Sent: Sunday, May 19, 2019 7:47 AM > To: Ajay Gupta > Cc: heikki.kroge...@linux.intel.com; linux-usb@vger.kernel.org; linux- > i...@vger.kernel.org; Ajay Gupta > Subject: Re: [PATCH 1/4] i2c: nvidia-gpu: add runtime pm support > >

RE: [PATCH 3/4] i2c: nvidia-gpu: resume ccgx i2c client

2019-05-20 Thread Ajay Gupta
Hi Wolfram, > -Original Message- > From: Wolfram Sang > Sent: Sunday, May 19, 2019 7:49 AM > To: Ajay Gupta > Cc: heikki.kroge...@linux.intel.com; linux-usb@vger.kernel.org; linux- > i...@vger.kernel.org; Ajay Gupta > Subject: Re: [PATCH 3/4] i2c: nvidia-gpu: resume ccgx i2c client > >

Re: [PATCH 1/4] i2c: nvidia-gpu: add runtime pm support

2019-05-20 Thread Wolfram Sang
> > I am not nacking this, yet the use of goto here seems too much for my > > taste. If > > you could try refactoring the whole code (dunno, maybe using a flag when to > > use stop?), I'd appreciate this. > Ok, I will add a local variable to make it more readable. I was brainstorming here, I am

[PATCH v2 4/5] i2c: nvidia-gpu: resume ccgx i2c client

2019-05-20 Thread Ajay Gupta
From: Ajay Gupta Cypress USB Type-C CCGx controller firmware version 3.1.10 (which is being used in many NVIDIA GPU cards) has known issue of not triggering interrupt when a USB device is hot plugged to runtime resume the controller. If any GPU card gets latest kernel with runtime pm support but

[PATCH v2 2/5] i2c: nvidia-gpu: add runtime pm support

2019-05-20 Thread Ajay Gupta
From: Ajay Gupta Enable runtime pm support with autosuspend delay of three second. This is to make sure I2C client device Cypress CCGx has completed all transaction. Signed-off-by: Ajay Gupta --- Changes from v1->v2: None drivers/i2c/busses/i2c-nvidia-gpu.c | 19 ++- 1 file ch

[PATCH v2 0/5] usb: typec: ucsi: ccg: add runtime pm support

2019-05-20 Thread Ajay Gupta
Hi Heikki and Wolfram These patches add support for runtime power management for UCSI CCGx driver. I have tested them with NVIDIA GPU card which has i2c interface to talk to CCG controller. I have added runtime pm support for the i2c bus driver as well. First patch refactors master_xfer() of i2c

[PATCH v2 5/5] usb: typec: ucsi: ccg: add runtime pm workaround

2019-05-20 Thread Ajay Gupta
From: Ajay Gupta Cypress USB Type-C CCGx controller firmware version 3.1.10 (which is being used in many NVIDIA GPU cards) has known issue of not triggering interrupt when a USB device is hot plugged to runtime resume the controller. If any GPU card gets latest kernel with runtime pm support but

[PATCH v2 1/5] i2c: nvidia-gpu: refactor master_xfer

2019-05-20 Thread Ajay Gupta
From: Ajay Gupta Added a local variable "send_stop" to simplify "goto" statements. The "send_stop" handles below two case 1) When first i2c start fails and so i2c stop is not sent before exiting 2) When i2c stop failed after all transfers and we do not need to send another stop before exiting.

[PATCH v2 3/5] usb: typec: ucsi: ccg: enable runtime pm support

2019-05-20 Thread Ajay Gupta
From: Ajay Gupta The change enables runtime pm support to UCSI CCG driver. ucsi_send_command() is used in resume path and so exported ucsi_send_command() symbol in ucsi.c for modular build. Signed-off-by: Ajay Gupta --- Changes from v1->v2 : None drivers/usb/typec/ucsi/ucsi.c | 1 + driv

TODO advice for octeon-usb?

2019-05-20 Thread Aaro Koskinen
Hi, I'm looking for input what should be done next to get drivers/staging/octeon-usb out of staging. Thousands of checkpatch errors/warnings have been fixed (starting point was ), also the size of the driver has shrunken considerably.

Re: [PATCH v2] usbnet: fix kernel crash after disconnect

2019-05-20 Thread David Miller
From: Kloetzke Jan Date: Thu, 16 May 2019 07:10:30 + > Am Montag, den 06.05.2019, 10:17 +0200 schrieb Oliver Neukum: >> On So, 2019-05-05 at 00:45 -0700, David Miller wrote: >> > From: Kloetzke Jan >> > Date: Tue, 30 Apr 2019 14:15:07 + >> > >> > > @@ -1431,6 +1432,11 @@ netdev_tx_t usb

Re: [Patch V3 1/8] phy: tegra: xusb: t210: add XUSB dual mode support

2019-05-20 Thread jckuo
Reviewed-by: JC Kuo On 5/16/19 2:39 PM, Nagarjuna Kristam wrote: Configure the port capabilities based on usb_dr_mode settings. Based on work by JC Kuo . Signed-off-by: Nagarjuna Kristam --- drivers/phy/tegra/xusb-tegra210.c | 22 +++--- 1 file changed, 19 insertions(+),

Re: [Patch V3 2/8] phy: tegra: xusb: t210: add usb3 port fake support

2019-05-20 Thread jckuo
Hi Nagarjuna, Please check tegra_xusb_update_usb3_fake_port(). Thanks, JC On 5/16/19 2:39 PM, Nagarjuna Kristam wrote: On Tegra210, usb2 only otg/peripheral ports dont work in device mode. They need an assosciated usb3 port to work in device mode. Identify an unused usb3 port and assign it as

Re: [Patch V3 3/8] phy: tegra: xusb: t210: add vbus override support

2019-05-20 Thread jckuo
Hi Nagarjuna, Please check tegra_phy_xusb_utmi_port_reset(). Thanks, JC On 5/16/19 2:39 PM, Nagarjuna Kristam wrote: Tegra XUSB device control driver needs to control vbus override during its operations, add API for the support. Signed-off-by: Nagarjuna Kristam --- drivers/phy/tegra/xusb-

Re: [Patch V3 4/8] dt-bindings: usb: Add NVIDIA Tegra XUSB device mode controller binding

2019-05-20 Thread JC Kuo
Reviewed-by: JC Kuo Thanks, JC On 5/16/19 2:39 PM, Nagarjuna Kristam wrote: Add device-tree binding documentation for the XUSB device mode controller present on Tegra210 SoC. This controller supports the USB 3.0 specification. Signed-off-by: Nagarjuna Kristam --- .../devicetree/bindings/u

Re: [Patch V3 5/8] arm64: tegra: Add xudc node for Tegra210

2019-05-20 Thread JC Kuo
Reviewed-by: JC Kuo Thanks, JC On 5/16/19 2:39 PM, Nagarjuna Kristam wrote: Tegra210 has one XUSB device mode controller, which can be operated HS and SS modes. Add DT support for XUSB device mode controller. Signed-off-by: Nagarjuna Kristam --- arch/arm64/boot/dts/nvidia/tegra210.dtsi |

Re: [Patch V3 6/8] arm64: tegra: Enable xudc on Jetson TX1

2019-05-20 Thread JC Kuo
Reviewed-by: JC Kuo Thanks, JC On 5/16/19 2:39 PM, Nagarjuna Kristam wrote: Enable XUSB device mode driver for USB0 slot on Jetson TX1. Signed-off-by: Nagarjuna Kristam --- arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi | 14 ++ 1 file changed, 14 insertions(+) diff --git a/

Re: TODO advice for octeon-usb?

2019-05-20 Thread Felipe Balbi
Hi, Aaro Koskinen writes: > I'm looking for input what should be done next to get > drivers/staging/octeon-usb out of staging. > > Thousands of checkpatch errors/warnings have been fixed (starting point > was ), > also the size of th