Re: [PATCH 01/14] usb: dwc2: Fix dwc2_restore_device_registers() function.

2019-04-30 Thread Artur Petrosyan
On 4/29/2019 21:34, Doug Anderson wrote: > Hi, > > On Mon, Apr 29, 2019 at 3:51 AM Artur Petrosyan > wrote: >> >> On 4/27/2019 00:43, Doug Anderson wrote: >>> Hi, >>> >>> On Fri, Apr 12, 2019 at 6:38 AM Artur Petrosyan >>> wrote: - Added backup of DCFG register. - Added Set the Po

Re: [PATCH v1 04/14] usb: dwc2: Fix suspend state in host mode for partial power down.

2019-04-30 Thread Artur Petrosyan
Hi, On 4/29/2019 21:35, Doug Anderson wrote: > Hi, > > On Mon, Apr 29, 2019 at 4:03 AM Artur Petrosyan > wrote: >> >> Hi, >> >> On 4/27/2019 00:45, Doug Anderson wrote: >>> Hi, >>> >>> On Fri, Apr 19, 2019 at 1:05 PM Artur Petrosyan >>> wrote: - In dwc2_port_suspend() function added w

RE: [PATCH] UAS: fix alignment of scatter/gather segments

2019-04-30 Thread David Laight
From: Alan Stern > Sent: 29 April 2019 18:55 > On Mon, 29 Apr 2019, Oliver Neukum wrote: > > > On Mo, 2019-04-29 at 12:08 -0400, Alan Stern wrote: > > > On Mon, 29 Apr 2019, Oliver Neukum wrote: > > > > > > > On Mo, 2019-04-29 at 15:06 +, David Laight wrote: > > > > > > > But the statement the

[PATCHv2] UAS: fix alignment of scatter/gather segments

2019-04-30 Thread Oliver Neukum
This is the UAS version of 747668dbc061b3e62bc1982767a3a1f9815fcf0e usb-storage: Set virt_boundary_mask to avoid SG overflows We are not as likely to be vulnerable as storage, as it is unlikelier that UAS is run over a controller without native support for SG, but the issue exists. The issue has

Re: [PATCHv2] UAS: fix alignment of scatter/gather segments

2019-04-30 Thread Greg KH
On Tue, Apr 30, 2019 at 12:21:45PM +0200, Oliver Neukum wrote: > This is the UAS version of > > 747668dbc061b3e62bc1982767a3a1f9815fcf0e > usb-storage: Set virt_boundary_mask to avoid SG overflows > > We are not as likely to be vulnerable as storage, as it is unlikelier > that UAS is run over a c

Re: [PATCH v1 08/14] usb: dwc2: Add default param to control power optimization.

2019-04-30 Thread Artur Petrosyan
Hi, On 4/29/2019 21:41, Doug Anderson wrote: > Hi, > > On Mon, Apr 29, 2019 at 4:30 AM Artur Petrosyan > wrote: >> >> Hi, >> >> On 4/27/2019 00:46, Doug Anderson wrote: >>> Hi, >>> >>> On Fri, Apr 19, 2019 at 11:53 AM Artur Petrosyan >>> wrote: - Added a default param "power_saving" t

Re: [PATCH v1 14/14] usb: dwc2: Add enter/exit hibernation from system issued suspend/resume

2019-04-30 Thread Artur Petrosyan
On 4/29/2019 21:43, Doug Anderson wrote: > Hi, > > On Mon, Apr 29, 2019 at 5:01 AM Artur Petrosyan > wrote: >> >> Hi, >> >> On 4/27/2019 01:01, Doug Anderson wrote: >>> Hi, >>> >>> On Fri, Apr 19, 2019 at 1:05 PM Artur Petrosyan >>> wrote: Added a new flow of entering and exiting hiber

[PATCHv3] UAS: fix alignment of scatter/gather segments

2019-04-30 Thread Oliver Neukum
This is the UAS version of 747668dbc061b3e62bc1982767a3a1f9815fcf0e usb-storage: Set virt_boundary_mask to avoid SG overflows We are not as likely to be vulnerable as storage, as it is unlikelier that UAS is run over a controller without native support for SG, but the issue exists. The issue has

[PATCH 1/3] rio500: refuse more than one device at a time

2019-04-30 Thread Oliver Neukum
This driver is using a global variable. It cannot handle more than one device at a time. The issue has been exisying since the dawn of the driver. Signed-off-by: Oliver Neukum Reported-by: syzbot+35f04d136fc975a70...@syzkaller.appspotmail.com --- drivers/usb/misc/rio500.c | 7 ++- 1 file cha

[PATCH 3/3] rio500: simplify locking

2019-04-30 Thread Oliver Neukum
Admitting that there can be only one device allows us to drop any pretense about locking one device or a table of devices. Signed-off-by: Oliver Neukum --- drivers/usb/misc/rio500.c | 43 --- 1 file changed, 16 insertions(+), 27 deletions(-) diff --git a/

[PATCH 2/3] rio500: fix memeory leak in close after disconnect

2019-04-30 Thread Oliver Neukum
If a disconnected device is closed, rio_close() must free the buffers. Signed-off-by: Oliver Neukum --- drivers/usb/misc/rio500.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/drivers/usb/misc/rio500.c b/drivers/usb/misc/rio500.c index a4b6fbea975f..20c3e

RE: [PATCH] UAS: fix alignment of scatter/gather segments

2019-04-30 Thread Alan Stern
On Tue, 30 Apr 2019, David Laight wrote: > From: Alan Stern > > Sent: 29 April 2019 18:55 > > On Mon, 29 Apr 2019, Oliver Neukum wrote: > > > > > On Mo, 2019-04-29 at 12:08 -0400, Alan Stern wrote: > > > > On Mon, 29 Apr 2019, Oliver Neukum wrote: > > > > > > > > > On Mo, 2019-04-29 at 15:06 +000

Re: [PATCH 1/3] rio500: refuse more than one device at a time

2019-04-30 Thread Alan Stern
On Tue, 30 Apr 2019, Oliver Neukum wrote: > This driver is using a global variable. It cannot handle more than > one device at a time. The issue has been exisying since the dawn s/exisying/existing/ > of the driver. > > Signed-off-by: Oliver Neukum > Reported-by: syzbot+35f04d136fc975a70...@sy

Re: [PATCHv2] UAS: fix alignment of scatter/gather segments

2019-04-30 Thread Alan Stern
On Tue, 30 Apr 2019, Oliver Neukum wrote: > This is the UAS version of > > 747668dbc061b3e62bc1982767a3a1f9815fcf0e > usb-storage: Set virt_boundary_mask to avoid SG overflows > > We are not as likely to be vulnerable as storage, as it is unlikelier s/unlikelier/less likely/ A matter of Englis

[PATCH 2/7] usb: musb: omap2430: Add support for idling phy when musb is idle

2019-04-30 Thread Bin Liu
From: Tony Lindgren I noticed that musb is blocking core retention for omap4 unlike for omap3. This is because for omap3 we have phy-twl4030-usb implement it's own PM runtime to handle errata "VUSB3V1 VBUS overvoltage debouncer not working when the PHY is powered down". That is done in order to k

[PATCH 5/7] usb: musb: jz4740: Let the platform probe the PHY

2019-04-30 Thread Bin Liu
From: Paul Cercueil By registering a generic USB PHY from within the driver, we may shadow the USB PHY registered by the platform, which might be different. Signed-off-by: Paul Cercueil Signed-off-by: Bin Liu --- drivers/usb/musb/jz4740.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/d

[PATCH 3/7] soc: sunxi: Fix missing dependency on REGMAP_MMIO

2019-04-30 Thread Bin Liu
From: Samuel Holland When enabling ARCH_SUNXI from allnoconfig, SUNXI_SRAM is enabled, but not REGMAP_MMIO, so the kernel fails to link with an undefined reference to __devm_regmap_init_mmio_clk. Select REGMAP_MMIO, as suggested in drivers/base/regmap/Kconfig. This creates the following dependen

[PATCH 4/7] dt-bindings: usb: Add usb-phy property to the jz4740-musb node

2019-04-30 Thread Bin Liu
From: Paul Cercueil Add a required 'usb-phy' property, to obtain a phandle to the USB PHY from devicetree. Signed-off-by: Paul Cercueil Reviewed-by: Rob Herring Signed-off-by: Bin Liu --- .../devicetree/bindings/usb/ingenic,jz4740-musb.txt | 8 1 file changed, 8 insertions(+)

[PATCH 0/7] musb patches for v5.2-rc1

2019-04-30 Thread Bin Liu
Hi Greg, Here are the musb patches for v5.2 rc1. There are all small fixes or improvements. Please let me know if any change is needed. There is one of the patches marked for stable. I will send it to stable tree later after they get into v5.2 rc. Thanks, -Bin. --- Kefeng Wang (1): usb: musb:

[PATCH 1/7] usb: musb: Silence error about blacklisting hubs if !CONFIG_USB

2019-04-30 Thread Bin Liu
From: Paul Cercueil Some drivers, like jz4740-musb, don't depend on CONFIG_USB. Signed-off-by: Paul Cercueil Signed-off-by: Bin Liu --- drivers/usb/musb/musb_core.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/mus

[PATCH 0/6] musb patches for v5.2-rc1

2019-04-30 Thread Bin Liu
Hi Greg, Here are the musb patches for v5.2 rc1. There are all small fixes or improvements. Please let me know if any change is needed. There is one of the patches marked for stable. I will send it to stable tree later after they get into v5.2 rc. Thanks, -Bin. --- Kefeng Wang (1): usb: musb:

[PATCH 6/7] usb: musb: jz4740: obtain USB PHY from devicetree

2019-04-30 Thread Bin Liu
From: Paul Cercueil Fall back to devm_usb_get_phy() if devicetree is not available. Signed-off-by: Paul Cercueil Signed-off-by: Bin Liu --- drivers/usb/musb/jz4740.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/drivers/usb/musb/jz4740.c b/drivers/usb/

[PATCH 7/7] usb: musb: dsps: Use dev_get_drvdata()

2019-04-30 Thread Bin Liu
From: Kefeng Wang Using dev_get_drvdata directly. Cc: Bin Liu Cc: Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org Signed-off-by: Kefeng Wang Signed-off-by: Bin Liu --- drivers/usb/musb/musb_dsps.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/usb/musb/mu

Re: [PATCH 0/6] musb patches for v5.2-rc1

2019-04-30 Thread Bin Liu
Please ignore this specific email. Sorry for the noise. -Bin. On Tue, Apr 30, 2019 at 09:59:42AM -0500, Bin Liu wrote: > Hi Greg, > > Here are the musb patches for v5.2 rc1. There are all small fixes or > improvements. Please let me know if any change is needed. > > There is one of the patches

Re: [PATCH v1 08/14] usb: dwc2: Add default param to control power optimization.

2019-04-30 Thread Doug Anderson
Hi, On Tue, Apr 30, 2019 at 5:45 AM Artur Petrosyan wrote: > > > If setting "power_down = 0" is wrong then please update your patch to > > remove all the mainline code that sets power_down to 0. Presumably > > this means you'd want to convert that code over to using "power_saving > > = False".

Re: [PATCH 01/14] usb: dwc2: Fix dwc2_restore_device_registers() function.

2019-04-30 Thread Doug Anderson
Hi, On Mon, Apr 29, 2019 at 11:59 PM Artur Petrosyan wrote: > > On 4/29/2019 21:34, Doug Anderson wrote: > > Hi, > > > > On Mon, Apr 29, 2019 at 3:51 AM Artur Petrosyan > > wrote: > >> > >> On 4/27/2019 00:43, Doug Anderson wrote: > >>> Hi, > >>> > >>> On Fri, Apr 12, 2019 at 6:38 AM Artur Petro

Re: usb: dwc2: Usb wifi dongle fails to initialize with Frame Overrun errors

2019-04-30 Thread Hal Emmerich
Hi Minas, On 4/23/19 2:54 AM, Minas Harutyunyan wrote: Hi Hal, On 4/19/2019 11:41 PM, Hal Emmerich wrote: Hello all, I have a ar9271 wireless dongle which is known to not work well with dwc2. When inserted, it may initialize properly if the system was just rebooted but after that will er

Re: [PATCH v1 04/14] usb: dwc2: Fix suspend state in host mode for partial power down.

2019-04-30 Thread Doug Anderson
Hi, On Tue, Apr 30, 2019 at 12:11 AM Artur Petrosyan wrote: > > Hi, > > On 4/29/2019 21:35, Doug Anderson wrote: > > Hi, > > > > On Mon, Apr 29, 2019 at 4:03 AM Artur Petrosyan > > wrote: > >> > >> Hi, > >> > >> On 4/27/2019 00:45, Doug Anderson wrote: > >>> Hi, > >>> > >>> On Fri, Apr 19, 2019