[PATCH] usbip: stub_rx: tidy the indenting in is_clear_halt_cmd()

2019-04-24 Thread Dan Carpenter
There is an extra space character before the return statement. Signed-off-by: Dan Carpenter diff --git a/drivers/usb/usbip/stub_rx.c b/drivers/usb/usbip/stub_rx.c index 97b09a42a10c..f3230bed18af 100644 --- a/drivers/usb/usbip/stub_rx.c +++ b/drivers/usb/usbip/stub_rx.c @@ -17,9 +17,9 @@ static

Re: [PATCH] usb: dwc3: Allow building USB_DWC3_QCOM without EXTCON

2019-04-24 Thread Marc Gonzalez
On 19/04/2019 11:59, Marc Gonzalez wrote: > Keep EXTCON support optional, since some platforms do not need it. > > Fixes: 3def4031b3e3 ("usb: dwc3: add EXTCON dependency for qcom") > Signed-off-by: Marc Gonzalez > --- > drivers/usb/dwc3/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 dele

Re: Bug#918800: PROBLEM: USB 3.0 NIC operates only at USB 2.0 speed on Odroid HC1

2019-04-24 Thread Steinar H. Gunderson
On Sat, Feb 02, 2019 at 01:39:06PM +0100, Benjamin Drung wrote: > The Odroid HC1 ARM board contains a JMicron JMS578 USB 3.0 to SATA > Bridge and a Realtek Gbps Ethernet device connected to an USB 3.0 host. > The SATA bridge works correctly at USB 3.0 speed, but the Ethernet > controller operates o

Re: [PATCH] usb: dwc3: Allow building USB_DWC3_QCOM without EXTCON

2019-04-24 Thread Arnd Bergmann
On Fri, Apr 19, 2019 at 11:59 AM Marc Gonzalez wrote: > > Keep EXTCON support optional, since some platforms do not need it. > > Fixes: 3def4031b3e3 ("usb: dwc3: add EXTCON dependency for qcom") > Signed-off-by: Marc Gonzalez The patch looks good, but please keep this in sync with the TI driver

[PATCH v2] usb: dwc3: Allow building USB_DWC3_QCOM without EXTCON

2019-04-24 Thread Marc Gonzalez
Keep EXTCON support optional, as some platforms do not need it. Do the same for USB_DWC3_OMAP while we're at it. Fixes: 3def4031b3e3f ("usb: dwc3: add EXTCON dependency for qcom") Signed-off-by: Marc Gonzalez --- Changes from v1: Do the same change for USB_DWC3_OMAP, as suggested by Arnd --- dr

Re: USB fuzzing with syzbot

2019-04-24 Thread Andrey Konovalov
On Fri, Apr 19, 2019 at 10:35 AM Greg Kroah-Hartman wrote: > > On Wed, Apr 17, 2019 at 06:33:39PM +0200, Andrey Konovalov wrote: > > Hi, > > > > As you might have noticed, syzbot has started reporting bugs in the > > USB subsystem that can be triggered externally by a malicious USB > > device. Rig

Re: USB fuzzing with syzbot

2019-04-24 Thread Andrey Konovalov
On Fri, Apr 19, 2019 at 4:39 PM Alan Stern wrote: > > On Fri, 19 Apr 2019, Greg Kroah-Hartman wrote: > > > > 3. Regarding that GadgetFS-like interface. > > > > > > Initially I was using GadgetFS (together with the Dummy HCD/UDC > > > module) to perform emulation of USB devices for fuzzing, but lat

Use device tree to disable U1/U2 in gadget devices based on DWC3

2019-04-24 Thread Claus H. Stovgaard
Hi Balbi and other USB developers. I am developing camera devices based on Xilinx ZynqMP, using the gadget framework and the build-in dwc3 core of the ZynqMP as USB3 controller and the build-in Cirrus SERDES as phy. Testing with a number of hosts and Windows 7, has shown sporadic reconnects whe

Re: Use device tree to disable U1/U2 in gadget devices based on DWC3

2019-04-24 Thread Alan Stern
On Wed, 24 Apr 2019, Claus H. Stovgaard wrote: > Hi Balbi and other USB developers. > > I am developing camera devices based on Xilinx ZynqMP, using the > gadget framework and the build-in dwc3 core of the ZynqMP as USB3 > controller and the build-in Cirrus SERDES as phy. > Testing with a number