Re: [PATCH 6/6] arm64: dts: allwinner: Remove useless phy-names from EHCI and OHCI

2019-04-17 Thread Maxime Ripard
On Tue, Apr 16, 2019 at 04:43:48PM +0800, Chen-Yu Tsai wrote: > On Tue, Apr 16, 2019 at 4:28 PM Maxime Ripard > wrote: > > > > Neither the OHCI or EHCI bindings are using the phy-names property, so we > > can just drop it. > > > > Signed-off-by: Maxime Ripard > > Acked-by: Chen-Yu Tsai > > for

RE: [PATCH v2 1/3] usb: typec: tcpm: Notify the tcpc to start connection-detection for SRPs

2019-04-17 Thread Adam Thomson
On 16 April 2019 21:08, Hans de Goede wrote: > Some tcpc device-drivers need to explicitly be told to watch for connection > events, otherwise the tcpc will not generate any TCPM_CC_EVENTs and devices > being plugged into the Type-C port will not be noticed. > > For dual-role ports tcpm_start_drp

RE: [PATCH v2 2/3] usb: typec: fusb302: Implement start_toggling for all port-types

2019-04-17 Thread Adam Thomson
On 16 April 2019 21:08, Hans de Goede wrote: > When in single-role port mode, we must start single-role toggling to > get an interrupt when a device / cable gets plugged into the port. > > This commit modifies the fusb302 start_toggling implementation to > start toggling for all port-types, so th

Re: [PATCH] USB:serial:pl2303:Add new PID to support PL2303HXN (TYPE_HXN)

2019-04-17 Thread Charles Yeh
Hello Sir, Please download the PL2303_Linux_0419.zip from https://app.box.com/s/uh9kldrdldjnmjffku8gkdvvaq5496tk > > After the actual test (I have tested the old PL2303H chip on Linux), > > when I plug in the PL2303H (TYPE_01), the Linux code will execute the code: > > if (spriv->quirks & PL2303_

RE: [PATCH v2 3/3] usb: typec: fusb302: Revert "Resolve fixed power role contract setup"

2019-04-17 Thread Adam Thomson
On 16 April 2019 21:08, Hans de Goede wrote: > Some tcpc device-drivers need to explicitly be told to watch for connection > events, otherwise the tcpc will not generate any TCPM_CC_EVENTs and devices > being plugged into the Type-C port will not be noticed. > > For dual-role ports tcpm_start_drp

Re: [PATCH] USB:serial:pl2303:Add new PID to support PL2303HXN (TYPE_HXN)

2019-04-17 Thread Johan Hovold
On Wed, Apr 17, 2019 at 06:50:55PM +0800, Charles Yeh wrote: > Hello Sir, > > Please download the PL2303_Linux_0419.zip from > https://app.box.com/s/uh9kldrdldjnmjffku8gkdvvaq5496tk > > > > After the actual test (I have tested the old PL2303H chip on Linux), > > > when I plug in the PL2303H (TYPE

[PATCH v3 6/7] usb: typec: displayport: Export probe and remove functions

2019-04-17 Thread Heikki Krogerus
From: Ajay Gupta VirtualLink standard extends the DisplayPort Alt Mode by utilizing also the USB 2 pins on the USB Type-C connector. It uses the same messages as DisplayPort, but not the DP SVID. At the time of writing, USB IF has not assigned a Standard ID (SID) for VirtualLink, so the manufactu

[PATCH v3 7/7] usb: typec: Add driver for NVIDIA Alt Modes

2019-04-17 Thread Heikki Krogerus
From: Ajay Gupta Latest NVIDIA GPUs support VirtualLink device. Since USBIF has not assigned a Standard ID (SID) for VirtualLink so using NVIDA VID 0x955 as SVID. Signed-off-by: Ajay Gupta Signed-off-by: Heikki Krogerus --- drivers/usb/typec/altmodes/Kconfig | 10 +++ drivers/usb/typec/a

[PATCH v3 5/7] usb: typec: ucsi: Support for DisplayPort alt mode

2019-04-17 Thread Heikki Krogerus
This makes it possible to bind a driver to a DisplayPort alt mode adapter devices. The driver attempts to cope with the limitations of UCSI by "emulating" behaviour and attempting to guess things when ever possible in order to satisfy the requirements the standard DisplayPort alt mode driver has.

[PATCH v3 1/7] usb: typec: ucsi: ccg: add get_fw_info function

2019-04-17 Thread Heikki Krogerus
From: Ajay Gupta Function is to get the details of ccg firmware and device version. It will be useful in debugging and also during firmware update. Signed-off-by: Ajay Gupta Signed-off-by: Heikki Krogerus --- drivers/usb/typec/ucsi/ucsi_ccg.c | 66 ++- 1 file chang

[PATCH v3 3/7] usb: typec: ucsi: ccg: add firmware flashing support

2019-04-17 Thread Heikki Krogerus
From: Ajay Gupta CCGx has two copies of the firmware in addition to the bootloader. If the device is running FW1, FW2 can be updated with the new version. Dual firmware mode allows the CCG device to stay in a PD contract and support USB PD and Type-C functionality while a firmware update is in pr

[PATCH v3 0/7] usb: typec: ucsi: Remaining changes for v5.2

2019-04-17 Thread Heikki Krogerus
Hi Greg, This is the third version of this collection of UCSI driver related changes. I fixed the header problem I caused in Ajay's patch adding the NVIDIA alt mode support (patch 7/7), and I also took the liberty of writing the missing ABI documentation for the extra sysfs file that's created in

[PATCH v3 4/7] usb: typec: ucsi: Preliminary support for alternate modes

2019-04-17 Thread Heikki Krogerus
With UCSI the alternate modes, just like everything else related to USB Type-C connectors, are handled in firmware. The operating system can see the status and is allowed to request certain things, for example entering and exiting the modes, but the support for alternate modes is very limited in UC

[PATCH v3 2/7] i2c: nvidia-gpu: Supply CCGx driver the fw build info

2019-04-17 Thread Heikki Krogerus
From: Ajay Gupta Adding device property "ccgx,firmware-build" for the CCGx device, so the CCGx driver knows which firmware binary to use for a specific vendor. Suggested-by: Heikki Krogerus Signed-off-by: Ajay Gupta Signed-off-by: Heikki Krogerus --- drivers/i2c/busses/i2c-nvidia-gpu.c | 7 +

Re: [PATCH] USB:serial:pl2303:Add new PID to support PL2303HXN (TYPE_HXN)

2019-04-17 Thread Charles Yeh
Johan Hovold 於 2019年4月17日 週三 下午7:13寫道: > > The code I see in the pl2303_set_termios function > > is still pl2303_vendor_write(serial,0x0,0x41), > > Not pl2303_update_reg(serial,0,PL2303_FLOWCTRL_MASK,0x40); > > Yes, you need to base it on my usb-next branch (or linux-next): > > git://git.

Re: [PATCH v3 0/7] usb: typec: ucsi: Remaining changes for v5.2

2019-04-17 Thread Heikki Krogerus
On Wed, Apr 17, 2019 at 02:47:43PM +0300, Heikki Krogerus wrote: > Hi Greg, > > This is the third version of this collection of UCSI driver related > changes. I fixed the header problem I caused in Ajay's patch adding the > NVIDIA alt mode support (patch 7/7), and I also took the liberty of > writ

USB fuzzing with syzbot

2019-04-17 Thread Andrey Konovalov
Hi, As you might have noticed, syzbot has started reporting bugs in the USB subsystem that can be triggered externally by a malicious USB device. Right now the fuzzing is done via a GadgetFS-like interface to emulate USB devices through the USB Gadget subsystem and the Dummy HCD/UDC module to "loo

Re: WARNING in usb_submit_urb (4)

2019-04-17 Thread Alan Stern
On Tue, 16 Apr 2019, syzbot wrote: > Hello, > > syzbot has tested the proposed patch but the reproducer still triggered > crash: > WARNING in usb_submit_urb > > hub 3-0:1.0: 90da6a2e hub_activate type 4 discon 0 > hub 3-0:1.0: 90da6a2e Submitting status URB > hub 3-0:1.0: 0

Re: WARNING in usb_submit_urb (4)

2019-04-17 Thread syzbot
Hello, syzbot has tested the proposed patch but the reproducer still triggered crash: WARNING in usb_submit_urb hub 3-0:1.0: e9b0f156 hub_resume hub 3-0:1.0: e9b0f156 hub_activate type 4 discon 0 hub 3-0:1.0: e9b0f156 hub_activate type 1 discon 0 [ cut here