Re: USB OTG removal in musb

2019-03-22 Thread Bin Liu
+ linux-usb list Hi, On Tue, Mar 12, 2019 at 04:11:15AM +0100, Daniele Orlandi wrote: > > Hello, > > I'm writing you in reference to the discussion archived here: > > https://www.spinics.net/lists/linux-usb/msg167003.html > > Did I correctly understand that OTG support has been removed from m

[PATCH 3/3] xhci: Don't let USB3 ports stuck in polling state prevent suspend

2019-03-22 Thread Mathias Nyman
Commit 2f31a67f01a8 ("usb: xhci: Prevent bus suspend if a port connect change or polling state is detected") was intended to prevent ports that were still link training from being forced to U3 suspend state mid enumeration. This solved enumeration issues for devices with slow link training. Turns

[PATCH 0/3] xhci fixes for usb-linus

2019-03-22 Thread Mathias Nyman
Hi Greg A few patches for usb-linus fixing mostly suspend and resume related issues. Solving one regression that prevented second suspend on some MacBooks, and a resume issue seen with devices that quickly enter link power management states after system resume. -Mathias Mathias Nyman (3): xhci

[PATCH 2/3] usb: xhci: dbc: Don't free all memory with spinlock held

2019-03-22 Thread Mathias Nyman
The xhci debug capability (DbC) feature did its memory cleanup with spinlock held. dma_free_coherent() warns if called with interrupts disabled move the memory cleanup outside the spinlock Cc: stable Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci-dbgcap.c | 5 +++-- 1 file changed, 3 i

[PATCH 1/3] xhci: Fix port resume done detection for SS ports with LPM enabled

2019-03-22 Thread Mathias Nyman
A suspended SS port in U3 link state will go to U0 when resumed, but can almost immediately after that enter U1 or U2 link power save states before host controller driver reads the port status. Host controller driver only checks for U0 state, and might miss the finished resume, leaving flags uncle

Re: [PATCH v3 0/5] usb: gadget: u_serial: console for multiple ports

2019-03-22 Thread Michał Mirosław
On Wed, Feb 27, 2019 at 11:46:56AM +0100, Michał Mirosław wrote: > This series makes it possible to have more control over console using > USB serial gadget ports. This can be useful when you need more than > one USB console or are configuring multiple serial port function via > configfs. > > The

[PATCH] usb: host: ohci-platform: Implement ohci_platform_shutdown

2019-03-22 Thread Tony Lindgren
If OHCI is runtime suspended, we can currently get an "imprecise external abort" on reboot with ohci-platform loaded when PM runtime is implemented for the SoC. Let's fix this by implementing ohci_platform_shutdown with PM runtime calls clocking the hardware before calling hcd->driver->shutdown.

Re: [PATCH] usb: host: ohci-platform: Implement ohci_platform_shutdown

2019-03-22 Thread Alan Stern
On Fri, 22 Mar 2019, Tony Lindgren wrote: > If OHCI is runtime suspended, we can currently get an "imprecise > external abort" on reboot with ohci-platform loaded when PM runtime > is implemented for the SoC. > > Let's fix this by implementing ohci_platform_shutdown with PM runtime > calls clocki

Re: [PATCH] usb: host: ohci-platform: Implement ohci_platform_shutdown

2019-03-22 Thread Tony Lindgren
* Alan Stern [190322 18:37]: > How about putting these runtime PM additions into > usb_hcd_platform_shutdown instead, so they will apply to all platform > controller drivers? OK let's do that then. > Also, are you certain you want the pm_runtime_put_sync at the end? If > the system is shutting

Re: [PATCH] usb: host: ohci-platform: Implement ohci_platform_shutdown

2019-03-22 Thread Alan Stern
On Fri, 22 Mar 2019, Tony Lindgren wrote: > * Alan Stern [190322 18:37]: > > How about putting these runtime PM additions into > > usb_hcd_platform_shutdown instead, so they will apply to all platform > > controller drivers? > > OK let's do that then. > > > Also, are you certain you want the pm

Re: [PATCH] usb: host: ohci-platform: Implement ohci_platform_shutdown

2019-03-22 Thread Tony Lindgren
* Alan Stern [190322 20:03]: > On Fri, 22 Mar 2019, Tony Lindgren wrote: > > > * Alan Stern [190322 18:37]: > > > How about putting these runtime PM additions into > > > usb_hcd_platform_shutdown instead, so they will apply to all platform > > > controller drivers? > > > > OK let's do that then

Re: [PATCH] usb: host: ohci-platform: Implement ohci_platform_shutdown

2019-03-22 Thread Alan Stern
On Fri, 22 Mar 2019, Tony Lindgren wrote: > * Alan Stern [190322 20:03]: > > On Fri, 22 Mar 2019, Tony Lindgren wrote: > > > > > * Alan Stern [190322 18:37]: > > > > How about putting these runtime PM additions into > > > > usb_hcd_platform_shutdown instead, so they will apply to all platform >

[PATCH] usb: core: Add PM runtime calls to usb_hcd_platform_shutdown

2019-03-22 Thread Tony Lindgren
If ohci-platform is runtime suspended, we can currently get an "imprecise external abort" on reboot with ohci-platform loaded when PM runtime is implemented for the SoC. Let's fix this by adding PM runtime support to usb_hcd_platform_shutdown. Signed-off-by: Tony Lindgren --- drivers/usb/core/h