RE: [PATCH 1/2] usb: chipiea: add flags for id and vbus from external block

2019-03-05 Thread Peter Chen
> > > > > > > > > > > > > > > drivers/usb/chipidea/core.c | 2 ++ > > > > > include/linux/usb/chipidea.h > > > > > | > > > > > 4 > > > > > 2 files changed, 6 insertions(+) > > > > > > > > > > diff --git a/drivers/usb/chipidea/core.c > > > > > b/drivers/usb/chipidea/core.c index > > > > > 7bf

[PATCH] USB: gadget: f_hid: fix deadlock in f_hidg_write()

2019-03-05 Thread Radoslav Gerganov
In f_hidg_write() the write_spinlock is acquired before calling usb_ep_queue() which causes a deadlock when dummy_hcd is being used. This is because dummy_queue() callbacks into f_hidg_req_complete() which tries to acquire the same spinlock. This is (part of) the backtrace when the deadlock occurs:

[PATCH] usb: dwc2: Fix channel disable flow

2019-03-05 Thread Minas Harutyunyan
Channel disabling/halting should performed for enabled only channels to avoid warnings "Unable to clear enable on channel N" which seen if host works in Slave mode. Signed-off-by: Minas Harutyunyan --- drivers/usb/dwc2/hcd.c | 34 -- 1 file changed, 20 insertions(

Re: MUSB interrupt storm on device removal

2019-03-05 Thread Måns Rullgård
Bin Liu writes: > On Wed, Jan 23, 2019 at 03:55:47PM +0100, Johan Hovold wrote: >> On Wed, Jan 23, 2019 at 08:09:47AM -0600, Bin Liu wrote: >> > On Wed, Jan 23, 2019 at 09:55:49AM +0100, Johan Hovold wrote: >> > > On Wed, Jan 23, 2019 at 07:52:12AM +0100, Greg Kroah-Hartman wrote: >> >> > > > Th

Re: [PATCH v3 09/12] usb: dwc3: Registering a role switch in the DRD code.

2019-03-05 Thread kbuild test robot
Hi Yu, I love your patch! Perhaps something to improve: [auto build test WARNING on balbi-usb/next] [also build test WARNING on v5.0 next-20190305] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

[PATCH] usbip: Remove unnecessary null check

2019-03-05 Thread Suwan Kim
"vdev" points to vhci_hcd->vdev[] array and vhci_hcd->vdev[] array is not a pointer array but a structure array and it is already used in vhci_urb_enqueue() and then passed to vhci_tx_urb() as an argument. vhci_tx_urb() is not called except vhci_urb_enqueue(). So, "vdev" can not be null pointer. Th

Re: [PATCH] wusb: use correct format characters

2019-03-05 Thread Test
Hallo Am 28.02.19 um 12:52 schrieb Louis Taylor: > When compiling with -Wformat, clang warns: > > ./include/linux/usb/wusb.h:245:5: warning: format specifies type > 'unsigned short' but the argument has type 'u8' (aka 'unsigned char') > [-Wformat] > ckhdid->data[0], ckhdid->data[1], > ^~~

Re: [PATCH] wusb: use correct format characters

2019-03-05 Thread Test
Test Am 28.02.19 um 12:52 schrieb Louis Taylor: > When compiling with -Wformat, clang warns: > > ./include/linux/usb/wusb.h:245:5: warning: format specifies type > 'unsigned short' but the argument has type 'u8' (aka 'unsigned char') > [-Wformat] > ckhdid->data[0], ckhdid->data[1], > ^~~~

Re: [PATCH v2 2/8] dt-bindings: phy: Add Amlogic G12A USB3+PCIE Combo PHY Bindings

2019-03-05 Thread Martin Blumenstingl
Hi Neil, On Mon, Mar 4, 2019 at 11:38 AM Neil Armstrong wrote: > > Add the Amlogic G12A Family USB3 + PCIE Combo PHY Bindings. > > This PHY can provide exclusively USB3 or PCIE support on shared I/Os. > > Signed-off-by: Neil Armstrong > Reviewed-by: Martin Blumenstingl > --- > .../bindings/phy

[PATCH] USB: serial: ftdi_sio: add additional NovaTech products

2019-03-05 Thread George McCollister
Add PIDs for the NovaTech OrionLX+ and Orion I/O so they can be automatically detected. Signed-off-by: George McCollister --- drivers/usb/serial/ftdi_sio.c | 2 ++ drivers/usb/serial/ftdi_sio_ids.h | 4 +++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/usb/serial/ftd

Re: [PATCH -next] usb: gadget: Remove dead branch code

2019-03-05 Thread Laurent Pinchart
Hello YueHaibing, Thank you for the patch. On Wed, Jan 23, 2019 at 10:31:36PM +0800, YueHaibing wrote: > 'num' is a u8 variable, it never greater than 255, > So the if branch is dead code and can be removed. > > Signed-off-by: YueHaibing Reviewed-by: Laurent Pinchart > --- > drivers/usb/gad

Re: [PATCH] [v2]USB:serial:pl2303:add new Pull-Up mode to support PL2303HXD (TYPE_HX)

2019-03-05 Thread Charles Yeh
Hi Johan / Greg, Do you have time to review the patch? If there is no time.. Who else can review this patch? Because my boss has been asking me to update the Linux patch... Charles. Charles Yeh 於 2019年3月5日 週二 上午9:16寫道: > > Hi Johan, > Do you have time to review the two patch? > > Johan Ho

Re: [PATCH] [v2]USB:serial:pl2303:add new Pull-Up mode to support PL2303HXD (TYPE_HX)

2019-03-05 Thread Greg KH
On Wed, Mar 06, 2019 at 12:42:29PM +0800, Charles Yeh wrote: > Hi Johan / Greg, > > Do you have time to review the patch? > If there is no time.. Who else can review this patch? > Because my boss has been asking me to update the Linux patch... It is the middle of the merge window and we can not a