[xhci-hcd][linux 4.20.13] autosuspend on causes a single cpu core to stay in kernel mode using 100% of said cpu core.

2019-03-03 Thread Farelka kek
usbcore.autosuspend higher than -1, causes 1 cpu core to never step down from kernel mode. It happens on a core i5-7200U laptop, an acer f5-573g-50ec Disabling usb autosuspend causes the cpu not to idle at, minimum of 25% cpu usage.

Re: [xhci-hcd][linux 4.20.13] autosuspend on causes a single cpu core to stay in kernel mode using 100% of said cpu core.

2019-03-03 Thread Greg KH
On Sun, Mar 03, 2019 at 03:15:27PM +0100, Farelka kek wrote: > usbcore.autosuspend higher than -1, causes 1 cpu core to never step > down from kernel mode. Some hardware does not aupport autosuspend, so leaving it at -1 is good. > It happens on a core i5-7200U laptop, an acer f5-573g-50ec > Disab

Re: [PATCH v3 10/12] hikey960: Support usb functionality of Hikey960

2019-03-03 Thread John Stultz
On Sat, Mar 2, 2019 at 4:05 AM Yu Chen wrote: > +static int hisi_hikey_usb_probe(struct platform_device *pdev) > +{ > + struct device *dev = &pdev->dev; > + struct device_node *root = dev->of_node; Minor nit: root is unused and generates build warnings. thanks -john

Re: [BUG] mt76x0u: Probing issues on Raspberry Pi 3 B+

2019-03-03 Thread Stefan Wahren
Hi, > Stanislaw Gruszka hat am 20. Februar 2019 um 17:32 > geschrieben: > > > On Wed, Feb 20, 2019 at 05:22:18PM +0100, Lorenzo Bianconi wrote: > > > On Wed, Feb 20, 2019 at 02:22:08PM +0100, Lorenzo Bianconi wrote: > > > > > On Tue, Feb 19, 2019 at 01:19:26PM +0100, Felix Fietkau wrote: > > >

Re: [PATCH] usb: typec: pi3usb30532: Keep orientation when setting mux to safe mode

2019-03-03 Thread Guenter Roeck
On 2/22/19 11:22 AM, Hans de Goede wrote: Keep the orientation value when setting the mux to safe mode, this fixes the orientation getting reset when switching alt-modes. Signed-off-by: Hans de Goede Reviewed-by: Guenter Roeck --- drivers/usb/typec/mux/pi3usb30532.c | 3 ++- 1 file chan

Re: [PATCH] USB:serial:pl2303:Add new PID to support PL2303HXN (TYPE_HXN)

2019-03-03 Thread Charles Yeh
Hi Johan, Is it free to check out the patch file provided before? If you can, please see first 1. [PATCH] USB:serial:pl2303:Add new PID to support PL2303HXN (TYPE_HXN) 2. [PATCH] [v2]USB:serial:pl2303:add new Pull-Up mode to support PL2303HXD (TYPE_HX) 1 & 2 are independent.. Charles Yeh 於 2019

Re: [PATCH v3 10/12] hikey960: Support usb functionality of Hikey960

2019-03-03 Thread Chen Yu
On 2019/3/4 4:17, John Stultz wrote: > On Sat, Mar 2, 2019 at 4:05 AM Yu Chen wrote: >> +static int hisi_hikey_usb_probe(struct platform_device *pdev) >> +{ >> + struct device *dev = &pdev->dev; >> + struct device_node *root = dev->of_node; > > Minor nit: root is unused and generat

Re: [PATCH v3 10/12] hikey960: Support usb functionality of Hikey960

2019-03-03 Thread Chunfeng Yun
hi, On Sat, 2019-03-02 at 17:05 +0800, Yu Chen wrote: > This driver handles usb hub power on and typeC port event of HiKey960 board: > 1)DP&DM switching between usb hub and typeC port base on typeC port > state > 2)Control power of usb hub on Hikey960 > 3)Control vbus of typeC port > > Cc: Chunfen

Re: [PATCH v3 10/12] hikey960: Support usb functionality of Hikey960

2019-03-03 Thread Chen Yu
Hi Chunfeng Yun, On 2019/3/4 9:47, Chunfeng Yun wrote: >> + >> +hisi_hikey_usb->role_sw = usb_role_switch_get(dev); >> +if (!hisi_hikey_usb->role_sw) >> +return -EPROBE_DEFER; > Here return EPROBE_DEFFER means the related device_connection is > registered after this probe is c

Re: [PATCH v3 10/12] hikey960: Support usb functionality of Hikey960

2019-03-03 Thread Chen Yu
Hi Andy, On 2019/3/3 0:01, Andy Shevchenko wrote: > On Sat, Mar 2, 2019 at 11:05 AM Yu Chen wrote: >> >> This driver handles usb hub power on and typeC port event of HiKey960 board: >> 1)DP&DM switching between usb hub and typeC port base on typeC port >> state >> 2)Control power of usb hub on Hi

Re: [PATCH v3 07/12] phy: Add usb phy support for hi3660 Soc of Hisilicon

2019-03-03 Thread Chen Yu
Hi Andy, On 2019/3/2 23:56, Andy Shevchenko wrote: > On Sat, Mar 2, 2019 at 11:06 AM Yu Chen wrote: >> >> This driver handles usb phy power on and shutdown for hi3660 Soc of >> Hisilicon. > > Few comments below. After fixing them, FWIW > Reviewed-by: Andy Shevchenko > >> +#define HI3660_USB_DE

//Re: [PATCH v3 06/12] usb: dwc3: Increase timeout for CmdAct cleared by device controller

2019-03-03 Thread Chen Yu
Hi Zhang Fei, On 2019/3/2 23:47, Andy Shevchenko wrote: > On Sat, Mar 2, 2019 at 11:06 AM Yu Chen wrote: >> >> It needs more time for the device controller to clear the CmdAct of >> DEPCMD on Hisilicon Kirin Soc. >> > > 5x times more? Can you provide more specific details on that? > Can you exp

Re: [PATCH] usb: uas: fix usb subsystem hang after power off hub port

2019-03-03 Thread Greg KH
On Mon, Mar 04, 2019 at 02:08:54AM +, jacky@sony.com wrote: > > > This email is confidential and intended only for the use of the individual or > entity named above and may contain information that is privileged. If you are > not the intended recipient, y

Re: [PATCH v3 10/12] hikey960: Support usb functionality of Hikey960

2019-03-03 Thread Andy Shevchenko
On Mon, Mar 4, 2019 at 3:47 AM Chunfeng Yun wrote: > On Sat, 2019-03-02 at 17:05 +0800, Yu Chen wrote: > > + hisi_hikey_usb->role_sw = usb_role_switch_get(dev); > > + if (!hisi_hikey_usb->role_sw) > > + return -EPROBE_DEFER; > Here return EPROBE_DEFFER means the related device

Re: [PATCH v3 10/12] hikey960: Support usb functionality of Hikey960

2019-03-03 Thread Andy Shevchenko
On Mon, Mar 4, 2019 at 4:35 AM Chen Yu wrote: > On 2019/3/3 0:01, Andy Shevchenko wrote: > > On Sat, Mar 2, 2019 at 11:05 AM Yu Chen wrote: > >> +config HISI_HIKEY_USB > >> + tristate "USB functionality of HiSilicon Hikey Platform" > >> + depends on OF && GPIOLIB > >> + help >

Re: [PATCH v3 10/12] hikey960: Support usb functionality of Hikey960

2019-03-03 Thread Chunfeng Yun
hi, On Mon, 2019-03-04 at 08:50 +0200, Andy Shevchenko wrote: > On Mon, Mar 4, 2019 at 3:47 AM Chunfeng Yun wrote: > > On Sat, 2019-03-02 at 17:05 +0800, Yu Chen wrote: > > > > + hisi_hikey_usb->role_sw = usb_role_switch_get(dev); > > > + if (!hisi_hikey_usb->role_sw) > > > +

RE: [PATCH] usb: uas: fix usb subsystem hang after power off hub port

2019-03-03 Thread Jacky.Cao
Dear Greg-san: I confirmed our company email related counter person that below footer is added automatically after we send email to who doesn't work in our company. I am very sorry that I didn't notice this issue and make you confuse. Now I am confirming with our counter person whether there is s

Re: [PATCH v3 10/12] hikey960: Support usb functionality of Hikey960

2019-03-03 Thread Chen Yu
Hi, On 2019/3/4 14:55, Andy Shevchenko wrote: > On Mon, Mar 4, 2019 at 4:35 AM Chen Yu wrote: >> On 2019/3/3 0:01, Andy Shevchenko wrote: >>> On Sat, Mar 2, 2019 at 11:05 AM Yu Chen wrote: > +config HISI_HIKEY_USB + tristate "USB functionality of HiSilicon Hikey Platform" +