[PATCH net-next] drivers: net: Remove unnecessary semicolon

2019-03-01 Thread Yue Haibing
From: YueHaibing drivers/net/dsa/mt7530.c:649:3-4: Unneeded semicolon drivers/net/ethernet/cisco/enic/enic_clsf.c:35:2-3: Unneeded semicolon drivers/net/ethernet/faraday/ftgmac100.c:1640:2-3: Unneeded semicolon drivers/net/ethernet/mediatek/mtk_eth_soc.c:229:2-3: Unneeded semicolon drivers/net/us

Re: [PATCH] usb: xhci: Support running urb giveback in tasklet context

2019-03-01 Thread Suwan Kim
Hi Mathias, On Thu, Feb 28, 2019 at 11:18:58AM +0200, Mathias Nyman wrote: > Hi > > On 19.2.2019 17.41, Suwan Kim wrote: > > Patch "USB: HCD: support giveback of URB in tasklet context" > > introduced giveback of urb in tasklet context. [1] This patch was > > applied to ehci but not xhci. [2] It

Re: [PATCH] usb: xhci: Support running urb giveback in tasklet context

2019-03-01 Thread Suwan Kim
I forgot to add links... sorry! [1], https://marc.info/?l=linux-usb&m=139523715802919&w=2 [2], https://marc.info/?l=linux-usb&m=137109031822092&w=2

RE: Bus noise periodically causes ci_hdrc IRQ lockup

2019-03-01 Thread Peter Chen
> On 2/28/19 1:57 AM, Peter Chen wrote: > > > >>> Let me summary your observation: > >>> - bind/unbind ci_hdrc device can recover connection > >>> - Reset HUB can't recover, and will go the previous error state > >>> after reset > >>> > >>> From the register, we do see something abnormal, and t

Re: [PATCH] usb: xhci: Support running urb giveback in tasklet context

2019-03-01 Thread Suwan Kim
There is typo.. sorry again in [USB-mass storge TEST] - xhci with tasklet - device1 - 130.2MB/s (not 103.2MS/s!) - device2 - 103.692MB/s

Re: [PATCH 4/8] dt-bindings: usb: dwc3: Add Amlogic G12A DWC3 Glue Bindings

2019-03-01 Thread Neil Armstrong
On 28/02/2019 17:29, Rob Herring wrote: > On Tue, Feb 12, 2019 at 04:14:09PM +0100, Neil Armstrong wrote: >> Adds the bindings for the Amlogic G12A USB Glue HW. >> >> The Amlogic G12A SoC Family embeds 2 USB Controllers : >> - a DWC3 IP configured as Host for USB2 and USB3 >> - a DWC2 IP configured

[PATCH 0/4] Add USB-HOST support to cat874

2019-03-01 Thread Fabrizio Castro
While trying to add USB-HOST support to the cat874 board, it came up that of_usb_get_dr_mode_by_phy was selecting the wrong DT node to use for dr_mode. Also, drivers/phy/renesas/phy-rcar-gen3-usb2.c was registering IRQs, no matter the dr_mode. This series adds all that is required to add USB-HOST

[PATCH 1/4] usb: common: Consider only available nodes for dr_mode

2019-03-01 Thread Fabrizio Castro
There are cases where multiple device tree nodes point to the same phy node by means of the "phys" property, but we should only consider those nodes that are marked as available rather than just any node. Fixes: 98bfb3946695 ("usb: of: add an api to get dr_mode by the phy node") Cc: sta...@vger.ke

Re: [PATCH] wusb: Remove unnecessary static function ckhdid_printf

2019-03-01 Thread Louis Taylor
On Thu, Feb 28, 2019 at 08:38:16PM -0800, Joe Perches wrote: > This static inline is unnecessary and can be removed > by using the vsprintf %ph extension. > > This reduces overall object size by more than 2K. > > Signed-off-by: Joe Perches > --- > drivers/usb/wusbcore/cbaf.c | 15

RE: [PATCH] dt-bindings: usb-xhci: Add r8a774c0 support

2019-03-01 Thread Fabrizio Castro
Hello Greg, I am sorry to bother you. Do you think you take this patch? Thanks, Fab > From: Fabrizio Castro > Sent: 13 December 2018 20:21 > Subject: [PATCH] dt-bindings: usb-xhci: Add r8a774c0 support > > Document RZ/G2E (R8A774C0) SoC bindings. > > Signed-off-by: Fabrizio Castro > --- > D

[PATCH] usb: core: make default autosuspend delay configurable

2019-03-01 Thread Mans Rullgard
Make the default autosuspend delay configurable at build time. This is useful for systems that require a non-standard value as it avoids relying on the command line being properly set. Signed-off-by: Mans Rullgard --- drivers/usb/core/Kconfig | 8 drivers/usb/core/usb.c | 4 ++-- 2 fi

Re: [PATCH] soc: sunxi: Fix missing dependency on REGMAP_MMIO

2019-03-01 Thread Maxime Ripard
On Thu, Feb 28, 2019 at 08:20:44PM -0600, Samuel Holland wrote: > When enabling ARCH_SUNXI from allnoconfig, SUNXI_SRAM is enabled, but > not REGMAP_MMIO, so the kernel fails to link with an undefined reference > to __devm_regmap_init_mmio_clk. Select REGMAP_MMIO, as suggested in > drivers/base/reg

Re: [PATCH] dt-bindings: usb-xhci: Add r8a774c0 support

2019-03-01 Thread Greg Kroah-Hartman
On Fri, Mar 01, 2019 at 11:25:33AM +, Fabrizio Castro wrote: > Hello Greg, > > I am sorry to bother you. > Do you think you take this patch? device tree bindings need an ack from the DT maintainers before I can take them. Also, this is for xhci, the xhci maintainer is responsible for those,

Re: [PATCH] usb: introduce usb_ep_type_string() function

2019-03-01 Thread Greg Kroah-Hartman
On Fri, Mar 01, 2019 at 02:58:23PM +0800, Chunfeng Yun wrote: > In some places, the code prints a human-readable USB endpoint > transfer type (e.g. "bulk"). This involves a switch statement > sometimes wrapped around in ({ ... }) block leading to code > repetition. > To make this scenario easier, h

Re: [PATCH] usb: core: make default autosuspend delay configurable

2019-03-01 Thread Greg Kroah-Hartman
On Fri, Mar 01, 2019 at 02:26:46PM +, Mans Rullgard wrote: > Make the default autosuspend delay configurable at build time. > This is useful for systems that require a non-standard value as > it avoids relying on the command line being properly set. > > Signed-off-by: Mans Rullgard > --- > d

RE: [PATCH] dt-bindings: usb-xhci: Add r8a774c0 support

2019-03-01 Thread Fabrizio Castro
Hello Greg, Thank you for your reply! > From: Greg Kroah-Hartman > Sent: 01 March 2019 16:16 > To: Fabrizio Castro > Cc: linux-usb@vger.kernel.org; devicet...@vger.kernel.org; > linux-ker...@vger.kernel.org; Simon Horman ; > Geert Uytterhoeven ; Chris Paterson > ; Biju Das > ; linux-renesas-.

[PATCH v2] usb: core: make default autosuspend delay configurable

2019-03-01 Thread Mans Rullgard
Make the default autosuspend delay configurable at build time. This is useful for systems that require a non-standard value as it avoids relying on the command line being properly set. Signed-off-by: Mans Rullgard --- Changes in v2: - add explanatory text to Kconfig help --- drivers/usb/core/Kco

Re: [PATCH v2] usb: core: make default autosuspend delay configurable

2019-03-01 Thread Greg Kroah-Hartman
On Fri, Mar 01, 2019 at 04:43:20PM +, Mans Rullgard wrote: > Make the default autosuspend delay configurable at build time. > This is useful for systems that require a non-standard value as > it avoids relying on the command line being properly set. > > Signed-off-by: Mans Rullgard > --- > Ch

[PATCH] USB: usb.h: tweak struct urb to remove wasted space

2019-03-01 Thread Greg Kroah-Hartman
By moving one field around in 'struct urb' we reduce the size of the structure by 8 bytes. Before the patch on x86_64 the overall size of the structure as reported by pahole was: /* size: 192, cachelines: 3, members: 30 */ /* sum members: 184, holes: 2, sum holes: 8 */ After the pa

Re: [PATCH] wusb: Remove unnecessary static function ckhdid_printf

2019-03-01 Thread Nick Desaulniers
On Thu, Feb 28, 2019 at 8:38 PM Joe Perches wrote: > > This static inline is unnecessary and can be removed > by using the vsprintf %ph extension. > > This reduces overall object size by more than 2K. > > Signed-off-by: Joe Perches Deserves a reported by tag from (https://lkml.org/lkml/2019/2/28

Re: [PATCH net-next] drivers: net: Remove unnecessary semicolon

2019-03-01 Thread Sean Wang
On Fri, 2019-03-01 at 16:09 +0800, Yue Haibing wrote: > From: YueHaibing > > drivers/net/dsa/mt7530.c:649:3-4: Unneeded semicolon > drivers/net/ethernet/cisco/enic/enic_clsf.c:35:2-3: Unneeded semicolon > drivers/net/ethernet/faraday/ftgmac100.c:1640:2-3: Unneeded semicolon > drivers/net/ethernet

Re: [PATCH] usb: dwc2: suppress confusing warnings on BCM2835

2019-03-01 Thread Stefan Wahren
Hi Minas, sorry for the delay, i was too busy with other issues. > Minas Harutyunyan hat am 21. Februar 2019 um > 08:34 geschrieben: > > > Hi Stefan, > > On 2/19/2019 10:23 PM, Stefan Wahren wrote: > > According to the BCM2835 datasheet the used Synopsys IP isn't a LPM-capable > > core. So d

Re: [PATCH] USB: usb.h: tweak struct urb to remove wasted space

2019-03-01 Thread Oliver Neukum
On Fr, 2019-03-01 at 18:22 +0100, Greg Kroah-Hartman wrote: > By moving one field around in 'struct urb' we reduce the size of the > structure by 8 bytes. If you are going for this I have to ask why unlink and status are full size ints anyway. Regards Oliver

Re: [PATCH] wusb: Remove unnecessary static function ckhdid_printf

2019-03-01 Thread Greg KH
On Fri, Mar 01, 2019 at 10:18:32AM -0800, Nick Desaulniers wrote: > On Thu, Feb 28, 2019 at 8:38 PM Joe Perches wrote: > > > > This static inline is unnecessary and can be removed > > by using the vsprintf %ph extension. > > > > This reduces overall object size by more than 2K. > > > > Signed-off-

Re: [PATCH v2 08/10] hikey960: Support usb functionality of Hikey960

2019-03-01 Thread Chen Yu
Hi Chunfeng Yun, On 2019/2/22 15:32, Chunfeng Yun wrote: > On Tue, 2019-02-19 at 11:20 +0800, Chen Yu wrote: >> Hi, >> >> On 2019/2/19 10:50, Chunfeng Yun wrote: + if (ret) + hisi_hikey_usb->typec_vbus_enable_val = 1; + + hisi_hikey_usb->typec_vbus = devm_gpiod_get(d

[BUG] ASIX AX88179 USB 3.0 Ethernet NICs not sending/receiving frames

2019-03-01 Thread Bradley Chapman
All, I am trying to get an ASIX AX88179 USB 3.0 dual Ethernet NIC dongle to work on an SFF system running Linux 4.20.13. The NICs are properly detected and named eth3 and eth4 by udev and I can configure and administer them like any other NIC, but neither interface is able to fully establish