Re: [PATCH 6/8] dt-bindings: usb: Add NVIDIA Tegra XUSB device mode controller binding

2019-02-25 Thread Thierry Reding
On Thu, Feb 14, 2019 at 08:26:52PM +0530, Nagarjuna Kristam wrote: > >> + reg = <0x0 0x700d 0x0 0x8000>, > >> + <0x0 0x700d8000 0x0 0x1000>, > >> + <0x0 0x700d9000 0x0 0x1000>; > >> + interrupts = <0 44 0x4>; > >> + clocks = <&tegra_c

Re: [PATCH 7/8] usb: gadget: Add UDC driver for tegra XUSB device mode controller

2019-02-25 Thread Thierry Reding
On Thu, Feb 14, 2019 at 08:22:34PM +0530, Nagarjuna Kristam wrote: > > > On 04-02-2019 19:26, Thierry Reding wrote: > > On Thu, Jan 03, 2019 at 03:34:58PM +0530, Nagarjuna Kristam wrote: > >> This patch adds UDC driver for tegra XUSB 3.0 device mode controller. > >> XUSB device mode controller su

Re: [PATCH 1/8] phy: tegra: xusb: t210: add XUSB device mode support

2019-02-25 Thread Thierry Reding
On Fri, Feb 15, 2019 at 11:48:37AM +0530, Nagarjuna Kristam wrote: > > > On 13-02-2019 12:34, Nagarjuna Kristam wrote: > >>> EXPORT_SYMBOL_GPL(tegra_xusb_padctl_usb3_set_lfps_detect); > >>> > >>> +int tegra_xusb_padctl_set_vbus_override(struct tegra_xusb_padctl *padctl) > >>> +{ > >>> + if (pa

[PATCH] usb: typec: altmodes/displayport: Fall back to multi-func pins

2019-02-25 Thread Hans de Goede
If our port-partner supports both DP-only operation (pin-assignment C) and multi-func operation (pin-assignment D) and we only support pin-assignment D and the port-partner prefers DP-only mode, then before this commit we would and up masking out pin-assignment D from the available pin-assignments

[PATCH 0/3] Propagate DP-over-Type-C hotplug events from Type-C subsys to drm-drivers

2019-02-25 Thread Hans de Goede
Hi All, On some Cherry Trail devices, DisplayPort over Type-C is supported through a USB-PD microcontroller (e.g. a fusb302) + a mux to switch the superspeed datalines between USB-3 and DP (e.g. a pi3usb30532). The kernel in this case does the PD/alt-mode negotiation itself, rather then everything

[PATCH 2/3] i915: Add support for out-of-bound hotplug events

2019-02-25 Thread Hans de Goede
On some Cherry Trail devices, DisplayPort over Type-C is supported through a USB-PD microcontroller (e.g. a fusb302) + a mux to switch the superspeed datalines between USB-3 and DP (e.g. a pi3usb30532). The kernel in this case does the PD/alt-mode negotiation itself, rather then everything being ha

[PATCH 1/3] drm: Add support for out-of-band hotplug notification

2019-02-25 Thread Hans de Goede
On some hardware a hotplug event notification may come from outside the display driver / device. One example of this is laptops with hybrid graphics where one or more outputs are connected to the discrete GPU only. In this case if the discrete GPU is fully powered down to save power, a hotplug to

[PATCH 3/3] usb: typec: altmodes/displayport: Notify drm subsys of hotplug events

2019-02-25 Thread Hans de Goede
Use the new drm_kms_call_oob_hotplug_notifier_chain() function to load drm/kms drivers know about DisplayPort over Type-C hotplug events. Signed-off-by: Hans de Goede --- drivers/usb/typec/altmodes/displayport.c | 34 1 file changed, 23 insertions(+), 11 deletions(-) di

Re: [RFC PATCH 0/2] Fix for the internal card reader and suspend on MacBooks

2019-02-25 Thread Ivan Mironov
On Thu, 2019-02-14 at 22:32 +0500, Ivan Mironov wrote: > On Thu, 2019-02-14 at 06:40 +0500, Ivan Mironov wrote: > > Unfortunately, everything broke again after yet another suspend/resume. > > Currently I'm suspecting that my patch maybe only helps to survive the > > short suspend, but not the long

Re: [PATCH 3/3] usb: typec: altmodes/displayport: Notify drm subsys of hotplug events

2019-02-25 Thread Greg Kroah-Hartman
On Mon, Feb 25, 2019 at 02:20:37PM +0100, Hans de Goede wrote: > Use the new drm_kms_call_oob_hotplug_notifier_chain() function to load > drm/kms drivers know about DisplayPort over Type-C hotplug events. > > Signed-off-by: Hans de Goede > --- > drivers/usb/typec/altmodes/displayport.c | 34

Re: [PATCH] usb: typec: altmodes/displayport: Fall back to multi-func pins

2019-02-25 Thread Heikki Krogerus
On Mon, Feb 25, 2019 at 01:56:37PM +0100, Hans de Goede wrote: > If our port-partner supports both DP-only operation (pin-assignment C) > and multi-func operation (pin-assignment D) and we only support > pin-assignment D and the port-partner prefers DP-only mode, then > before this commit we would

Re: [PATCH] usb: typec: pi3usb30532: Keep orientation when setting mux to safe mode

2019-02-25 Thread Heikki Krogerus
On Fri, Feb 22, 2019 at 08:22:39PM +0100, Hans de Goede wrote: > Keep the orientation value when setting the mux to safe mode, this > fixes the orientation getting reset when switching alt-modes. > > Signed-off-by: Hans de Goede Should this be also a fix? > --- > drivers/usb/typec/mux/pi3usb30

[PATCH] usb: ehci: Cleanup itd/sidt_complete()

2019-02-25 Thread Suwan Kim
This patch makes itd/sitd_complete() use *bus instead of referening ehci_to_hcd(ehci)->self. And remove unnecessary "urb = NULL" lines. Signed-off-by: Suwan Kim --- drivers/usb/host/ehci-sched.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/drivers/usb/h

Re: [PATCH 3/3] usb: typec: altmodes/displayport: Notify drm subsys of hotplug events

2019-02-25 Thread Hans de Goede
Hi, On 25-02-19 15:06, Greg Kroah-Hartman wrote: On Mon, Feb 25, 2019 at 02:20:37PM +0100, Hans de Goede wrote: Use the new drm_kms_call_oob_hotplug_notifier_chain() function to load s/load/let/ fixed in my tree. drm/kms drivers know about DisplayPort over Type-C hotplug events. Signed-off

Re: [PATCH] usb: ehci: Cleanup itd/sidt_complete()

2019-02-25 Thread Greg KH
On Tue, Feb 26, 2019 at 12:51:44AM +0900, Suwan Kim wrote: > This patch makes itd/sitd_complete() use *bus instead of referening > ehci_to_hcd(ehci)->self. And remove unnecessary "urb = NULL" lines. That is two different things to do in the same patch, please break this up into different patches.

Re: [PATCH] usb: typec: altmodes/displayport: Fall back to multi-func pins

2019-02-25 Thread Hans de Goede
Hi Heikki, On 25-02-19 16:49, Heikki Krogerus wrote: On Mon, Feb 25, 2019 at 01:56:37PM +0100, Hans de Goede wrote: If our port-partner supports both DP-only operation (pin-assignment C) and multi-func operation (pin-assignment D) and we only support pin-assignment D and the port-partner prefer

Re: [PATCH] usb: typec: pi3usb30532: Keep orientation when setting mux to safe mode

2019-02-25 Thread Hans de Goede
Hi, On 25-02-19 16:50, Heikki Krogerus wrote: On Fri, Feb 22, 2019 at 08:22:39PM +0100, Hans de Goede wrote: Keep the orientation value when setting the mux to safe mode, this fixes the orientation getting reset when switching alt-modes. Signed-off-by: Hans de Goede Should this be also a fi

Re: Bus noise periodically causes ci_hdrc IRQ lockup

2019-02-25 Thread Chandler Griscom
On 2/24/19 9:58 PM, Peter Chen wrote: I suspect the controller is stuck at high speed. Chandler, would you please supply below information: - If there is SOFs on the bus (you need to measure by probe) when the issue occurs? - If the SOF can't be observed at bus, it means the disconnection can't

Re: [PATCH v2 2/2] usb: dwc3: Add workaround for host mode VBUS glitch when boot

2019-02-25 Thread Yang Li
On Tue, Feb 19, 2019 at 1:24 AM Ran Wang wrote: > > When DWC3 is set to host mode by programming register DWC3_GCTL, VBUS > (or its control signal) will be turned on immediately on related Root Hub > ports. Then, the VBUS is turned off for a little while(15us) when do xhci > reset (conducted by xh

Re: [PATCH 1/2] dt-bindings: usb-xhci: Add usb-phy-port-reset property

2019-02-25 Thread Rob Herring
On Tue, Feb 05, 2019 at 11:48:53AM +0530, Srinath Mannam wrote: > Add usb-phy-port-reset optional property to set quirk in xhci platform > driver which forces USB port PHY reset on port disconnect event. > > Signed-off-by: Srinath Mannam > Reviewed-by: Ray Jui > --- > Documentation/devicetree/b

Re: [PATCH 1/2] USB: gadget: pxa25x: Add DT bindings

2019-02-25 Thread Rob Herring
On Sun, Feb 03, 2019 at 12:59:07AM +0100, Linus Walleij wrote: > This adds device tree bindings for the PXA25x USB Device > Controller as found in the PXA25x and the IXP4xx. > > Cc: Robert Jarzmik > Cc: devicet...@vger.kernel.org > Signed-off-by: Linus Walleij > --- > .../devicetree/bindings/us

Re: [regression] USB power management failure to suspend / high CPU usage

2019-02-25 Thread Ivan Mironov
On Wed, 2019-02-20 at 19:28 +0200, Mathias Nyman wrote: > On 14.2.2019 20.04, Eric Blau wrote: > > On Thu, Feb 14, 2019 at 9:56 AM Mathias Nyman > > wrote: > > > > Thanks for looking into this, Mathias. Now that you point this out, on > > > > older kernels where suspend and resume works, I noticed

Re: [PATCH] usb: ehci: Cleanup itd/sidt_complete()

2019-02-25 Thread Suwan Kim
On Mon, Feb 25, 2019 at 05:41:45PM +0100, Greg KH wrote: > On Tue, Feb 26, 2019 at 12:51:44AM +0900, Suwan Kim wrote: > > This patch makes itd/sitd_complete() use *bus instead of referening > > ehci_to_hcd(ehci)->self. And remove unnecessary "urb = NULL" lines. > > That is two different things to

RE: Bus noise periodically causes ci_hdrc IRQ lockup

2019-02-25 Thread Peter Chen
> > I suspect the controller is stuck at high speed. Chandler, would you please > > supply > below information: > > - If there is SOFs on the bus (you need to measure by probe) when the issue > occurs? > > - If the SOF can't be observed at bus, it means the disconnection > > can't be observed eith

Re: [PATCH 1/2] dt-bindings: usb-xhci: Add usb-phy-port-reset property

2019-02-25 Thread Srinath Mannam
Hi Rob, Thanks for the review, Please see my comments below in line. Regards, Srinath. On Tue, Feb 26, 2019 at 3:08 AM Rob Herring wrote: > > On Tue, Feb 05, 2019 at 11:48:53AM +0530, Srinath Mannam wrote: > > Add usb-phy-port-reset optional property to set quirk in xhci platform > > driver which

RE: [PATCH v2 2/2] usb: dwc3: Add workaround for host mode VBUS glitch when boot

2019-02-25 Thread Ran Wang
Hi Leo, > -Original Message- > From: Yang Li > Sent: Tuesday, February 26, 2019 05:29 > To: Ran Wang > Cc: Greg Kroah-Hartman ; Rob Herring > ; Mark Rutland ; Felipe Balbi > ; linux-usb@vger.kernel.org; devicet...@vger.kernel.org; > linux-ker...@vger.kernel.org > Subject: Re: [PATCH v2 2

RE: [PATCH 1/2] usb: chipiea: add flags for id and vbus from external block

2019-02-25 Thread Peter Chen
> drivers/usb/chipidea/core.c | 2 ++ > include/linux/usb/chipidea.h | 4 > 2 files changed, 6 insertions(+) > > diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c index > 7bfcbb2..0bfa850 100644 > --- a/drivers/usb/chipidea/core.c > +++ b/drivers/usb/chipidea/core.c >

[PATCH v3 1/2] usb: dwc3: Add avoiding vbus glitch happen during xhci reset

2019-02-25 Thread Ran Wang
When DWC3 is set to host mode by programming register DWC3_GCTL, VBUS (or its control signal) will turn on immediately on related Root Hub ports. Then the VBUS will be de-asserted for a little while during xhci reset (conducted by xhci driver) for a little while and back to normal. This VBUS glitc

[PATCH v3 2/2] usb: dwc3: Add workaround for host mode VBUS glitch when boot

2019-02-25 Thread Ran Wang
When DWC3 is set to host mode by programming register DWC3_GCTL, VBUS (or its control signal) will be turned on immediately on related Root Hub ports. Then, the VBUS is turned off for a little while(15us) when do xhci reset (conducted by xhci driver) and back to normal finally, we can observe a neg

Re: [PATCH 7/8] usb: gadget: Add UDC driver for tegra XUSB device mode controller

2019-02-25 Thread Nagarjuna Kristam
On 25-02-2019 17:45, Thierry Reding wrote: > On Thu, Feb 14, 2019 at 08:22:34PM +0530, Nagarjuna Kristam wrote: >> >> # +static void tegra_xudc_device_mode_on(struct tegra_xudc *xudc) +{ + unsigned long flags; + int err; + + spin_lock_irqsave(&xudc->lock, f

Re: [PATCH 2/2] usb: typec: add typec switch via GPIO control

2019-02-25 Thread Andy Shevchenko
On Mon, Feb 25, 2019 at 9:27 AM Jun Li wrote: > > This patch adds a simple typec switch driver which only needs > a GPIO to switch the super speed active channel according to > typec orientation. > +#include > +#include > +#include > +#include > +#include > +#include I don't see how these

Re: [PATCH 3/3] usb: typec: altmodes/displayport: Notify drm subsys of hotplug events

2019-02-25 Thread kbuild test robot
Hi Hans, I love your patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on next-20190225] [cannot apply to v5.0-rc8] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https