[PATCH 1/1] USB: serial: option: add Telit ME910 ECM composition

2019-02-20 Thread Daniele Palmas
This patch adds Telit ME910 family ECM composition 0x1102. Signed-off-by: Daniele Palmas --- lsusb verbose output: Bus 003 Device 005: ID 1bc7:1102 Telit Wireless Solutions Device Descriptor: bLength18 bDescriptorType 1 bcdUSB 2.00 bDeviceClass

Re: [PATCH v2] USB: serial: cp210x: Fix GPIO in autosuspend

2019-02-20 Thread Johan Hovold
On Sun, Feb 17, 2019 at 06:59:01PM +0100, Karoly Pados wrote: > Current GPIO code in cp210x fails to take USB autosuspend into account, > making it practically impossible to use GPIOs with autosuspend enabled > without user configuration. Fix this like for ftdi_sio in a previous patch. > Tested on

Re: 4.20.7: pl2303 not working (post-4.19 regression) (limited info so far, not yet bisected)

2019-02-20 Thread Johan Hovold
On Mon, Feb 18, 2019 at 10:32:57AM +, Nix wrote: > On 18 Feb 2019, Johan Hovold stated: > > > On Sun, Feb 17, 2019 at 07:13:52PM +, Nix wrote: > >> I'm still fairly sure this is a regression -- my machines are often up > >> for a lot longer than that and I've never seen this before I upgra

Re: [PATCH] usb: xhci: add Immediate Data Transfer support

2019-02-20 Thread Felipe Balbi
Nicolas Saenz Julienne writes: > Immediate data transfers (IDT) allow the HCD to copy small chunks of > data (up to 8bytes) directly into its output transfer TRBs. This avoids > the somewhat expensive DMA mappings that are performed by default on > most URBs submissions. > > In the case an URB wa

Re: [PATCH 1/1] USB: serial: option: add Telit ME910 ECM composition

2019-02-20 Thread Johan Hovold
On Wed, Feb 20, 2019 at 10:13:09AM +0100, Daniele Palmas wrote: > This patch adds Telit ME910 family ECM composition 0x1102. > > Signed-off-by: Daniele Palmas > --- > lsusb verbose output: > > Bus 003 Device 005: ID 1bc7:1102 Telit Wireless Solutions > Device Descriptor: > bLength

Re: [PATCH 1/1] USB: serial: option: add Telit ME910 ECM composition

2019-02-20 Thread Daniele Palmas
Hi Johan, Il giorno mer 20 feb 2019 alle ore 10:39 Johan Hovold ha scritto: > > On Wed, Feb 20, 2019 at 10:13:09AM +0100, Daniele Palmas wrote: > > This patch adds Telit ME910 family ECM composition 0x1102. > > > > Signed-off-by: Daniele Palmas > > --- > > lsusb verbose output: > > > > Bus 003 D

Re: [PATCH 1/1] USB: serial: option: add Telit ME910 ECM composition

2019-02-20 Thread Johan Hovold
On Wed, Feb 20, 2019 at 10:47:59AM +0100, Daniele Palmas wrote: > Hi Johan, > > Il giorno mer 20 feb 2019 alle ore 10:39 Johan Hovold > ha scritto: > > > > On Wed, Feb 20, 2019 at 10:13:09AM +0100, Daniele Palmas wrote: > > > This patch adds Telit ME910 family ECM composition 0x1102. > > > diff

Re: [BUG] mt76x0u: Probing issues on Raspberry Pi 3 B+

2019-02-20 Thread Stanislaw Gruszka
On Tue, Feb 19, 2019 at 10:40:47AM -0500, Alan Stern wrote: > On Tue, 19 Feb 2019, Stanislaw Gruszka wrote: > > > It would be interesting why urb->num_sgs = 0 & urb->sg cause > > the troubles. This is how usb_sg_init() submit urbs for sg_tablesize = 0 > > controllers. So either are there are some

Re: [PATCH v4 6/6] usb:cdns3 Fix for stuck packets in on-chip OUT buffer.

2019-02-20 Thread Roger Quadros
Pawel, On 14/02/2019 21:45, Pawel Laszczak wrote: > Controller for OUT endpoints has shared on-chip buffers for all incoming > packets, including ep0out. It's FIFO buffer, so packets must be handle > by DMA in correct order. If the first packet in the buffer will not be > handled, then the followi

[PATCH v2 1/1] USB: serial: option: add Telit ME910 ECM composition

2019-02-20 Thread Daniele Palmas
This patch adds Telit ME910 family ECM composition 0x1102. Signed-off-by: Daniele Palmas --- v2: add matching on interface class to remove blacklisting lsusb verbose output: Bus 003 Device 005: ID 1bc7:1102 Telit Wireless Solutions Device Descriptor: bLength18 bDescriptorTyp

Re: usb: over-current condition

2019-02-20 Thread Subhashini Rao Beerisetty
On Tue, Feb 19, 2019 at 8:30 PM Roger Quadros wrote: > > Please keep linux-usb in cc. > > On 19/02/2019 16:50, Subhashini Rao Beerisetty wrote: > > On Tue, Feb 19, 2019 at 8:06 PM Roger Quadros wrote: > >> > >> Hi Subhashini, > >> > >> On 19/02/2019 16:30, Subhashini Rao Beerisetty wrote: > >>> H

Re: [PATCH v2 1/1] USB: serial: option: add Telit ME910 ECM composition

2019-02-20 Thread Johan Hovold
On Wed, Feb 20, 2019 at 11:43:17AM +0100, Daniele Palmas wrote: > This patch adds Telit ME910 family ECM composition 0x1102. > > Signed-off-by: Daniele Palmas > --- > v2: add matching on interface class to remove blacklisting > > lsusb verbose output: > --- > drivers/usb/serial/option.c | 2 ++

[PATCH] usb: typec: tps6598x: handle block writes separately with plain-I2C adapters

2019-02-20 Thread Nikolaus Voss
Commit 1a2f474d328f handles block _reads_ separately with plain-I2C adapters, but the problem described with regmap-i2c not handling SMBus block transfers (i.e. read and writes) correctly also exists with writes. As workaround, this patch adds a block write function the same way 1a2f474d328f adds

RE: [PATCH v4 6/6] usb:cdns3 Fix for stuck packets in on-chip OUT buffer.

2019-02-20 Thread Pawel Laszczak
Hi Roger. > >On 14/02/2019 21:45, Pawel Laszczak wrote: >> Controller for OUT endpoints has shared on-chip buffers for all incoming >> packets, including ep0out. It's FIFO buffer, so packets must be handle >> by DMA in correct order. If the first packet in the buffer will not be >> handled, then th

Re: [PATCH] usb: typec: tps6598x: handle block writes separately with plain-I2C adapters

2019-02-20 Thread Heikki Krogerus
Hi, On Mon, Sep 10, 2018 at 07:05:01AM +0200, Nikolaus Voss wrote: > Commit 1a2f474d328f handles block _reads_ separately with plain-I2C > adapters, but the problem described with regmap-i2c not handling > SMBus block transfers (i.e. read and writes) correctly also exists > with writes. > > As wo

[PATCH 2/3] usb: gadget: atmel: support USB suspend

2019-02-20 Thread Jonas Bonn
This patch adds support for USB suspend to the Atmel UDC. When suspended, the UDC clock can be stopped, resulting in some power savings. The "wake up" interrupt will fire irregardless of whether the clock is running or not, allowing the UDC clock to be restarted when the USB master wants to wake

[PATCH 3/3] usb: gadget: atmel: tie wake lock to running clock

2019-02-20 Thread Jonas Bonn
If the USB device is connected to a host, the CPU cannot be suspended or else the USB device appears to be disconnected from the host's point of view. Only after a "USB suspend" state has been entered (as set by the host) or the host is disconnected can the system safely be suspended: in both thes

[PATCH 1/3] usb: gadget: atmel_usba_udc: simplify setting of interrupt-enabled mask

2019-02-20 Thread Jonas Bonn
This patch adds set and clear functions for enabling/disabling interrupts. This simplifies the implementation a bit as the masking of previously set bits doesn't need to be so explicit. Signed-off-by: Jonas Bonn CC: Cristian Birsan CC: Felipe Balbi CC: Greg Kroah-Hartman CC: Nicolas Ferre CC

[PATCH 0/3] usb: gadget: atmel: support USB suspend/resume

2019-02-20 Thread Jonas Bonn
This patch series hooks up proper support for USB suspend and resume to the Atmel UDC. Jonas Bonn (3): usb: gadget: atmel_usba_udc: simplify setting of interrupt-enabled mask usb: gadget: atmel: support USB suspend usb: gadget: atmel: tie wake lock to running clock drivers/usb/gadget/u

[PATCHv2] usb: typec: tps6598x: handle block writes separately with plain-I2C adapters

2019-02-20 Thread Nikolaus Voss
Commit 1a2f474d328f handles block _reads_ separately with plain-I2C adapters, but the problem described with regmap-i2c not handling SMBus block transfers (i.e. read and writes) correctly also exists with writes. As workaround, this patch adds a block write function the same way 1a2f474d328f adds

Re: [PATCH] usb: typec: tps6598x: handle block writes separately with plain-I2C adapters

2019-02-20 Thread Nikolaus Voss
Hi, On Wed, 20 Feb 2019, Heikki Krogerus wrote: Hi, On Mon, Sep 10, 2018 at 07:05:01AM +0200, Nikolaus Voss wrote: Commit 1a2f474d328f handles block _reads_ separately with plain-I2C adapters, but the problem described with regmap-i2c not handling SMBus block transfers (i.e. read and writes) c

Re: [BUG] mt76x0u: Probing issues on Raspberry Pi 3 B+

2019-02-20 Thread Stanislaw Gruszka
On Tue, Feb 19, 2019 at 01:19:26PM +0100, Felix Fietkau wrote: > >> >> The way I see it, we have two choices. > >> >> 1. Fix dwc2 to do its alignment quirk for the urb->sg != NULL case > >> >> 2. Rely on urb->transfer_buffer and keep urb->sg NULL > >> > > >> > I agree, if this is only needed for d

Re: [PATCH v4 5/6] usb:cdns3 Add Cadence USB3 DRD Driver

2019-02-20 Thread Roger Quadros
Pawel, On 14/02/2019 21:45, Pawel Laszczak wrote: > This patch introduce new Cadence USBSS DRD driver to linux kernel. > > The Cadence USBSS DRD Driver is a highly configurable IP Core whichi > can be instantiated as Dual-Role Device (DRD), Peripheral Only and > Host Only (XHCI)configurations. >

Re: usb: over-current condition

2019-02-20 Thread Roger Quadros
On 20/02/2019 13:00, Subhashini Rao Beerisetty wrote: > On Tue, Feb 19, 2019 at 8:30 PM Roger Quadros wrote: >> >> Please keep linux-usb in cc. >> >> On 19/02/2019 16:50, Subhashini Rao Beerisetty wrote: >>> On Tue, Feb 19, 2019 at 8:06 PM Roger Quadros wrote: Hi Subhashini, O

Re: [PATCH v4 6/6] usb:cdns3 Fix for stuck packets in on-chip OUT buffer.

2019-02-20 Thread Roger Quadros
Pawel, On 20/02/2019 13:18, Pawel Laszczak wrote: > Hi Roger. >> >> On 14/02/2019 21:45, Pawel Laszczak wrote: >>> Controller for OUT endpoints has shared on-chip buffers for all incoming >>> packets, including ep0out. It's FIFO buffer, so packets must be handle >>> by DMA in correct order. If the

Re: [BUG] mt76x0u: Probing issues on Raspberry Pi 3 B+

2019-02-20 Thread Lorenzo Bianconi
> On Tue, Feb 19, 2019 at 01:19:26PM +0100, Felix Fietkau wrote: > > >> >> The way I see it, we have two choices. > > >> >> 1. Fix dwc2 to do its alignment quirk for the urb->sg != NULL case > > >> >> 2. Rely on urb->transfer_buffer and keep urb->sg NULL > > >> > > > >> > I agree, if this is only

Re: [PATCHv2] usb: typec: tps6598x: handle block writes separately with plain-I2C adapters

2019-02-20 Thread Heikki Krogerus
On Wed, Feb 20, 2019 at 01:57:30PM +0100, Nikolaus Voss wrote: > Commit 1a2f474d328f handles block _reads_ separately with plain-I2C > adapters, but the problem described with regmap-i2c not handling > SMBus block transfers (i.e. read and writes) correctly also exists > with writes. > > As workaro

Re: [PATCHv2] usb: typec: tps6598x: handle block writes separately with plain-I2C adapters

2019-02-20 Thread Nikolaus Voss
On Wed, 20 Feb 2019, Heikki Krogerus wrote: On Wed, Feb 20, 2019 at 01:57:30PM +0100, Nikolaus Voss wrote: Commit 1a2f474d328f handles block _reads_ separately with plain-I2C adapters, but the problem described with regmap-i2c not handling SMBus block transfers (i.e. read and writes) correctly a

[PATCH] xhci: tegra: Prevent error pointer dereference

2019-02-20 Thread Thierry Reding
From: Thierry Reding During initialization, the host and super-speed power domains will contain an ERR_PTR() encoded error code rather than being NULL. To avoid a crash, use a !IS_ERR_OR_NULL() condition during cleanup. Signed-off-by: Thierry Reding --- drivers/usb/host/xhci-tegra.c | 4 ++--

Re: [PATCHv2] usb: typec: tps6598x: handle block writes separately with plain-I2C adapters

2019-02-20 Thread Heikki Krogerus
On Wed, Feb 20, 2019 at 02:38:47PM +0100, Nikolaus Voss wrote: > On Wed, 20 Feb 2019, Heikki Krogerus wrote: > > On Wed, Feb 20, 2019 at 01:57:30PM +0100, Nikolaus Voss wrote: > > > Commit 1a2f474d328f handles block _reads_ separately with plain-I2C > > > adapters, but the problem described with re

Re: [PATCHv2] usb: typec: tps6598x: handle block writes separately with plain-I2C adapters

2019-02-20 Thread Heikki Krogerus
On Wed, Feb 20, 2019 at 04:14:23PM +0200, Heikki Krogerus wrote: > On Wed, Feb 20, 2019 at 02:38:47PM +0100, Nikolaus Voss wrote: > > On Wed, 20 Feb 2019, Heikki Krogerus wrote: > > > On Wed, Feb 20, 2019 at 01:57:30PM +0100, Nikolaus Voss wrote: > > > > Commit 1a2f474d328f handles block _reads_ se

Re: [PATCH] xhci: tegra: Prevent error pointer dereference

2019-02-20 Thread Jon Hunter
On 20/02/2019 13:48, Thierry Reding wrote: > From: Thierry Reding > > During initialization, the host and super-speed power domains will > contain an ERR_PTR() encoded error code rather than being NULL. To > avoid a crash, use a !IS_ERR_OR_NULL() condition during cleanup. > > Signed-off-by: Th

Re: [PATCHv2] usb: typec: tps6598x: handle block writes separately with plain-I2C adapters

2019-02-20 Thread Guenter Roeck
On 2/20/19 4:57 AM, Nikolaus Voss wrote: Commit 1a2f474d328f handles block _reads_ separately with plain-I2C adapters, but the problem described with regmap-i2c not handling SMBus block transfers (i.e. read and writes) correctly also exists with writes. As workaround, this patch adds a block wri

Re: [PATCHv2] usb: typec: tps6598x: handle block writes separately with plain-I2C adapters

2019-02-20 Thread Greg Kroah-Hartman
On Wed, Feb 20, 2019 at 01:57:30PM +0100, Nikolaus Voss wrote: > Commit 1a2f474d328f handles block _reads_ separately with plain-I2C > adapters, but the problem described with regmap-i2c not handling > SMBus block transfers (i.e. read and writes) correctly also exists > with writes. > > As workaro

Re: [PATCHv2] usb: typec: tps6598x: handle block writes separately with plain-I2C adapters

2019-02-20 Thread Nikolaus Voss
On Wed, 20 Feb 2019, Heikki Krogerus wrote: On Wed, Feb 20, 2019 at 04:14:23PM +0200, Heikki Krogerus wrote: On Wed, Feb 20, 2019 at 02:38:47PM +0100, Nikolaus Voss wrote: On Wed, 20 Feb 2019, Heikki Krogerus wrote: On Wed, Feb 20, 2019 at 01:57:30PM +0100, Nikolaus Voss wrote: Commit 1a2f474

[PATCHv3] usb: typec: tps6598x: handle block writes separately with plain-I2C adapters

2019-02-20 Thread Nikolaus Voss
From: Nikolaus Voss Commit 1a2f474d328f handles block _reads_ separately with plain-I2C adapters, but the problem described with regmap-i2c not handling SMBus block transfers (i.e. read and writes) correctly also exists with writes. As workaround, this patch adds a block write function the same

Re: [PATCHv2] usb: typec: tps6598x: handle block writes separately with plain-I2C adapters

2019-02-20 Thread Nikolaus Voss
On Wed, 20 Feb 2019, Guenter Roeck wrote: On 2/20/19 4:57 AM, Nikolaus Voss wrote: Commit 1a2f474d328f handles block _reads_ separately with plain-I2C adapters, but the problem described with regmap-i2c not handling SMBus block transfers (i.e. read and writes) correctly also exists with writes.

Re: [PATCHv2] usb: typec: tps6598x: handle block writes separately with plain-I2C adapters

2019-02-20 Thread Nikolaus Voss
On Wed, 20 Feb 2019, Greg Kroah-Hartman wrote: On Wed, Feb 20, 2019 at 01:57:30PM +0100, Nikolaus Voss wrote: Commit 1a2f474d328f handles block _reads_ separately with plain-I2C adapters, but the problem described with regmap-i2c not handling SMBus block transfers (i.e. read and writes) correctl

Re: [BUG] mt76x0u: Probing issues on Raspberry Pi 3 B+

2019-02-20 Thread Alan Stern
On Wed, 20 Feb 2019, Stanislaw Gruszka wrote: > On Tue, Feb 19, 2019 at 10:40:47AM -0500, Alan Stern wrote: > > On Tue, 19 Feb 2019, Stanislaw Gruszka wrote: > > > > > It would be interesting why urb->num_sgs = 0 & urb->sg cause > > > the troubles. This is how usb_sg_init() submit urbs for sg_tab

Re: [PATCHv3] usb: typec: tps6598x: handle block writes separately with plain-I2C adapters

2019-02-20 Thread Guenter Roeck
On 2/20/19 7:11 AM, Nikolaus Voss wrote: From: Nikolaus Voss Commit 1a2f474d328f handles block _reads_ separately with plain-I2C adapters, but the problem described with regmap-i2c not handling SMBus block transfers (i.e. read and writes) correctly also exists with writes. As workaround, this

Re: [PATCHv3] usb: typec: tps6598x: handle block writes separately with plain-I2C adapters

2019-02-20 Thread Guenter Roeck
On 2/20/19 7:35 AM, Guenter Roeck wrote: On 2/20/19 7:11 AM, Nikolaus Voss wrote: From: Nikolaus Voss Commit 1a2f474d328f handles block _reads_ separately with plain-I2C adapters, but the problem described with regmap-i2c not handling SMBus block transfers (i.e. read and writes) correctly also

RE: [PATCH v4 6/6] usb:cdns3 Fix for stuck packets in on-chip OUT buffer.

2019-02-20 Thread Pawel Laszczak
> >On 20/02/2019 13:18, Pawel Laszczak wrote: >> Hi Roger. >>> >>> On 14/02/2019 21:45, Pawel Laszczak wrote: Controller for OUT endpoints has shared on-chip buffers for all incoming packets, including ep0out. It's FIFO buffer, so packets must be handle by DMA in correct order. If th

Re: [BUG] mt76x0u: Probing issues on Raspberry Pi 3 B+

2019-02-20 Thread Stanislaw Gruszka
On Wed, Feb 20, 2019 at 02:22:08PM +0100, Lorenzo Bianconi wrote: > > On Tue, Feb 19, 2019 at 01:19:26PM +0100, Felix Fietkau wrote: > > > >> >> The way I see it, we have two choices. > > > >> >> 1. Fix dwc2 to do its alignment quirk for the urb->sg != NULL case > > > >> >> 2. Rely on urb->transfer

Re: [PATCH] xhci: tegra: Prevent error pointer dereference

2019-02-20 Thread Greg Kroah-Hartman
On Wed, Feb 20, 2019 at 02:48:41PM +0100, Thierry Reding wrote: > From: Thierry Reding > > During initialization, the host and super-speed power domains will > contain an ERR_PTR() encoded error code rather than being NULL. To > avoid a crash, use a !IS_ERR_OR_NULL() condition during cleanup. >

Re: [BUG] mt76x0u: Probing issues on Raspberry Pi 3 B+

2019-02-20 Thread Lorenzo Bianconi
> On Wed, Feb 20, 2019 at 02:22:08PM +0100, Lorenzo Bianconi wrote: > > > On Tue, Feb 19, 2019 at 01:19:26PM +0100, Felix Fietkau wrote: > > > > >> >> The way I see it, we have two choices. > > > > >> >> 1. Fix dwc2 to do its alignment quirk for the urb->sg != NULL case > > > > >> >> 2. Rely on urb

Re: [PATCHv2] usb: typec: tps6598x: handle block writes separately with plain-I2C adapters

2019-02-20 Thread Greg Kroah-Hartman
On Wed, Feb 20, 2019 at 04:22:00PM +0100, Nikolaus Voss wrote: > > > v2: fix tps6598x_exec_cmd also > > > --- > > > drivers/usb/typec/tps6598x.c | 26 -- > > > 1 file changed, 20 insertions(+), 6 deletions(-) > > > > > > diff --git a/drivers/usb/typec/tps6598x.c b/drivers/

Re: [PATCH] xhci: tegra: Prevent error pointer dereference

2019-02-20 Thread Thierry Reding
On Wed, Feb 20, 2019 at 05:16:12PM +0100, Greg Kroah-Hartman wrote: > On Wed, Feb 20, 2019 at 02:48:41PM +0100, Thierry Reding wrote: > > From: Thierry Reding > > > > During initialization, the host and super-speed power domains will > > contain an ERR_PTR() encoded error code rather than being N

Re: [PATCH] xhci: tegra: Prevent error pointer dereference

2019-02-20 Thread Greg Kroah-Hartman
On Wed, Feb 20, 2019 at 05:27:02PM +0100, Thierry Reding wrote: > On Wed, Feb 20, 2019 at 05:16:12PM +0100, Greg Kroah-Hartman wrote: > > On Wed, Feb 20, 2019 at 02:48:41PM +0100, Thierry Reding wrote: > > > From: Thierry Reding > > > > > > During initialization, the host and super-speed power do

Re: [BUG] mt76x0u: Probing issues on Raspberry Pi 3 B+

2019-02-20 Thread Stanislaw Gruszka
On Wed, Feb 20, 2019 at 05:22:18PM +0100, Lorenzo Bianconi wrote: > > On Wed, Feb 20, 2019 at 02:22:08PM +0100, Lorenzo Bianconi wrote: > > > > On Tue, Feb 19, 2019 at 01:19:26PM +0100, Felix Fietkau wrote: > > > > > >> >> The way I see it, we have two choices. > > > > > >> >> 1. Fix dwc2 to do its

Re: [PATCH] xhci: tegra: Prevent error pointer dereference

2019-02-20 Thread Mathias Nyman
On 20.2.2019 18.31, Greg Kroah-Hartman wrote: On Wed, Feb 20, 2019 at 05:27:02PM +0100, Thierry Reding wrote: On Wed, Feb 20, 2019 at 05:16:12PM +0100, Greg Kroah-Hartman wrote: On Wed, Feb 20, 2019 at 02:48:41PM +0100, Thierry Reding wrote: From: Thierry Reding During initialization, the ho

Re: [BUG] mt76x0u: Probing issues on Raspberry Pi 3 B+

2019-02-20 Thread Lorenzo Bianconi
> On Wed, Feb 20, 2019 at 05:22:18PM +0100, Lorenzo Bianconi wrote: > > > On Wed, Feb 20, 2019 at 02:22:08PM +0100, Lorenzo Bianconi wrote: > > > > > On Tue, Feb 19, 2019 at 01:19:26PM +0100, Felix Fietkau wrote: > > > > > > >> >> The way I see it, we have two choices. > > > > > > >> >> 1. Fix dwc2

Re: [regression] USB power management failure to suspend / high CPU usage

2019-02-20 Thread Mathias Nyman
On 14.2.2019 20.04, Eric Blau wrote: On Thu, Feb 14, 2019 at 9:56 AM Mathias Nyman wrote: Thanks for looking into this, Mathias. Now that you point this out, on older kernels where suspend and resume works, I noticed the following log messages emitted when resuming from suspend: Feb 06 18:58

[PATCH 1/4] usb: xhci: fix build warning - missing prototype

2019-02-20 Thread Mathias Nyman
From: Jean-Philippe Menil Fix build warning when building drivers/usb/host/xhci-mem.o due to missing prototype for xhci_free_virt_devices_depth_first. This function is only used in xhci-mem.c so just make it static. Signed-off-by: Jean-Philippe Menil --- drivers/usb/host/xhci-mem.c | 2 +- 1

[PATCH 0/4] xhci features for usb-next

2019-02-20 Thread Mathias Nyman
Hi Greg A few minor xhci features for usb-next. A bit late in the cycle, there is nothing urgent with these but nice if they make 5.1 -Mathias Balaji Manoharan (1): usb: xhci: Fix for Enabling USB ROLE SWITCH QUIRK on INTEL_SUNRISEPOINT_LP_XHCI Chunfeng Yun (1): usb: xhci: remove unused

[PATCH 3/4] usb: xhci: remove unused member 'parent' in xhci_regset struct

2019-02-20 Thread Mathias Nyman
From: Chunfeng Yun The member @parent of xhci_regset struct is not used in fact, so remove it Signed-off-by: Chunfeng Yun Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci-debugfs.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/host/xhci-debugfs.h b/drivers/usb/host/xhci

[PATCH 2/4] usb: xhci: Fix for Enabling USB ROLE SWITCH QUIRK on INTEL_SUNRISEPOINT_LP_XHCI

2019-02-20 Thread Mathias Nyman
From: Balaji Manoharan This fix enables USB role feature on intel commercial nuc platform which is based on Kabylake chipset. Signed-off-by: Balaji Manoharan Reviewed-by: Hans de Goede Reviewed-by: Heikki Krogerus Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci-pci.c | 1 + 1 file ch

[PATCH 4/4] usb: xhci: dbc: Fixing typo error.

2019-02-20 Thread Mathias Nyman
From: Prabhat Chand Pandey Replaced "xhci_dbc_flush_reqests" with xhci_dbc_flush_requests". Signed-off-by: Prabhat Chand Pandey Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci-dbgcap.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/host/xhci-dbgca

Re: [PATCH 1/4] usb: xhci: fix build warning - missing prototype

2019-02-20 Thread Mathias Nyman
On 20.2.2019 19.50, Mathias Nyman wrote: From: Jean-Philippe Menil Fix build warning when building drivers/usb/host/xhci-mem.o due to missing prototype for xhci_free_virt_devices_depth_first. This function is only used in xhci-mem.c so just make it static. Signed-off-by: Jean-Philippe Menil

Re: [PATCH 1/4] usb: xhci: fix build warning - missing prototype

2019-02-20 Thread Greg KH
On Wed, Feb 20, 2019 at 08:01:08PM +0200, Mathias Nyman wrote: > On 20.2.2019 19.50, Mathias Nyman wrote: > > From: Jean-Philippe Menil > > > > Fix build warning when building drivers/usb/host/xhci-mem.o due to missing > > prototype for xhci_free_virt_devices_depth_first. > > > > This function i

Re: [PATCH 2/4] usb: xhci: Fix for Enabling USB ROLE SWITCH QUIRK on INTEL_SUNRISEPOINT_LP_XHCI

2019-02-20 Thread Greg KH
On Wed, Feb 20, 2019 at 07:50:53PM +0200, Mathias Nyman wrote: > From: Balaji Manoharan > > This fix enables USB role feature on intel commercial nuc > platform which is based on Kabylake chipset. > > Signed-off-by: Balaji Manoharan > Reviewed-by: Hans de Goede > Reviewed-by: Heikki Krogerus

Re: [PATCH 1/4] usb: xhci: fix build warning - missing prototype

2019-02-20 Thread Greg KH
On Wed, Feb 20, 2019 at 07:50:52PM +0200, Mathias Nyman wrote: > From: Jean-Philippe Menil > > Fix build warning when building drivers/usb/host/xhci-mem.o due to missing > prototype for xhci_free_virt_devices_depth_first. There is no normal "build warning", this is a sparse fixup, right?

Re: [PATCH 1/4] usb: xhci: fix build warning - missing prototype

2019-02-20 Thread Jean-Philippe Menil
On Wed, 20 Feb 2019, Greg KH wrote: > On Wed, Feb 20, 2019 at 07:50:52PM +0200, Mathias Nyman wrote: > > From: Jean-Philippe Menil > > > > Fix build warning when building drivers/usb/host/xhci-mem.o due to missing > > prototype for xhci_free_virt_devices_depth_first. > > There is no normal "bui

USB mouse doesn't work after laptop entered in suspending mode

2019-02-20 Thread Jorge Augusto
Dear developers, I have an ACER Aspire E1-522 but with this motherboard EG50-KB MB 12253-3M and the USB mouse stops working after resume and I need to unbind and bin OCHI-PCI to mouse starts working again This is the error: dmesg --level=err [ 836.062810] ohci-pci :00:12.0: frame counter not

RE: [PATCH v3] usb: chipidea: Grab the (legacy) USB PHY by phandle first

2019-02-20 Thread Peter Chen
> > On Mon, 2019-02-18 at 03:04 +, Peter Chen wrote: > > > According to the chipidea driver bindings, the USB PHY is specified via > > > the > "phys" > > > phandle node. However, this only takes effect for USB PHYs that use > > > the common PHY framework. For legacy USB PHYs, a simple looku

RE: [PATCH v4 6/6] usb:cdns3 Fix for stuck packets in on-chip OUT buffer.

2019-02-20 Thread Felipe Balbi
Hi, (please break your emails at 80-columns) Pawel Laszczak writes: >>> One more thing. Workaround has implemented algorithm that decide for which >>> endpoint it should be enabled. e.g for composite device MSC+NCM+ACM it >>> should work only for ACM OUT endpoint. >>> >> >>If ACM driver didn't

Re: [PATCH] usb: dwc2: suppress confusing warnings on BCM2835

2019-02-20 Thread Minas Harutyunyan
Hi Stefan, On 2/19/2019 10:23 PM, Stefan Wahren wrote: > According to the BCM2835 datasheet the used Synopsys IP isn't a LPM-capable > core. So disable these features and suppress these confusing warnings: > > dwc2 3f98.usb: dwc2_check_params: Invalid parameter lpm=1 > dwc2 3f98.usb: dwc2