Re: [PATCH v2 02/10] dt-bindings: misc: Add bindings for HiSilicon usb hub and data role switch functionality on HiKey960

2019-02-19 Thread Sergei Shtylyov
Hello! On 18.02.2019 14:23, Yu Chen wrote: This patch adds binding documentation to support usb hub and usb data role switch of Hisilicon HiKey960 Board. Cc: Sergei Shtylyov Cc: Rob Herring Cc: Mark Rutland Cc: John Stultz Cc: Binghui Wang Signed-off-by: Yu Chen --- v1: * Fix some format

Re: [PATCH] [v2]USB:serial:pl2303:add new Pull-Up mode to support PL2303HXD (TYPE_HX)

2019-02-19 Thread Johan Hovold
On Tue, Feb 19, 2019 at 02:41:28PM +0800, Charles Yeh wrote: > Hi Johan & Greg, > > > Do you have received a new patch"[PATCH] [v2]USB:serial:pl2303:add new > Pull-Up mode to support PL2303HXD (TYPE_HX)"? > > If you have received a new patch, has the content been confirmed? > > Or tell me where

Re: [BUG] mt76x0u: Probing issues on Raspberry Pi 3 B+

2019-02-19 Thread Stanislaw Gruszka
On Mon, Feb 18, 2019 at 07:52:27PM +0100, Felix Fietkau wrote: > On 2019-02-18 16:03, Stanislaw Gruszka wrote: > > On Mon, Feb 18, 2019 at 03:43:26PM +0100, Felix Fietkau wrote: > >> On 2019-02-18 14:52, Stanislaw Gruszka wrote: > >> > On Sat, Feb 16, 2019 at 08:17:07PM +0100, Stefan Wahren wrote:

Re: [BUG] mt76x0u: Probing issues on Raspberry Pi 3 B+

2019-02-19 Thread Stanislaw Gruszka
On Mon, Feb 18, 2019 at 11:19:40PM +0100, Stefan Wahren wrote: > Hi, > > > Stanislaw Gruszka hat am 18. Februar 2019 um 14:52 > > geschrieben: > > > > > > On Sat, Feb 16, 2019 at 08:17:07PM +0100, Stefan Wahren wrote: > > > this is a misunderstanding. The warning is about memory alignment to 3

Re: [PATCH v2 00/10] Add support for usb on Hikey960

2019-02-19 Thread Valentin Schneider
On 19/02/2019 01:34, Chen Yu wrote: [...] > This patch set based on Heikki Krogerus's patches. > Have you applied https://do-db2.lkml.org/lkml/2019/2/13/106 first? > And these configs should be set to y: > CONFIG_TYPEC > CONFIG_TYPEC_TCPM > CONFIG_TYPEC_TCPCI > CONFIG_TYPEC_

overdue payment

2019-02-19 Thread First Commercial Bank London

Re: [BUG] mt76x0u: Probing issues on Raspberry Pi 3 B+

2019-02-19 Thread Felix Fietkau
On 2019-02-19 11:59, Stanislaw Gruszka wrote: > On Mon, Feb 18, 2019 at 11:19:40PM +0100, Stefan Wahren wrote: >> Hi, >> >> > Stanislaw Gruszka hat am 18. Februar 2019 um 14:52 >> > geschrieben: >> > >> > >> > On Sat, Feb 16, 2019 at 08:17:07PM +0100, Stefan Wahren wrote: >> > > this is a misu

Re: [BUG] mt76x0u: Probing issues on Raspberry Pi 3 B+

2019-02-19 Thread Felix Fietkau
On 2019-02-19 11:42, Stanislaw Gruszka wrote: > On Mon, Feb 18, 2019 at 07:52:27PM +0100, Felix Fietkau wrote: >> On 2019-02-18 16:03, Stanislaw Gruszka wrote: >> > On Mon, Feb 18, 2019 at 03:43:26PM +0100, Felix Fietkau wrote: >> >> On 2019-02-18 14:52, Stanislaw Gruszka wrote: >> >> > On Sat, Feb

Re: USB 3.0 device next to USB 2.0 receiver result in dysfunctional mouse

2019-02-19 Thread Greg KH
On Mon, Feb 18, 2019 at 10:59:43AM +0100, usbu...@mailbox.org wrote: > Hello, > > I build a new pc with the B450-I motherboard from Asus. My issue is the > following: When I plug-in a USB 3.0 device next to the unifying receiver from > logitech the mouse stops working. Meaning no movement, click

Re: [PATCH] usb: core: skip interfaces disabled in devicetree

2019-02-19 Thread Greg Kroah-Hartman
On Sat, Feb 16, 2019 at 05:04:52PM +, Mans Rullgard wrote: > If an interface has an associated devicetree node with status disabled, > do not register the device. This is useful for boards with a built-in > multifunction USB device where some functions are broken or otherwise > undesired. > >

Re: [PATCH v4 2/6] usb:common Separated decoding functions from dwc3 driver.

2019-02-19 Thread Greg KH
On Thu, Feb 14, 2019 at 07:45:10PM +, Pawel Laszczak wrote: > Patch moves some decoding functions from driver/usb/dwc3/debug.h driver > to driver/usb/common/debug.c file. These moved functions include: > dwc3_decode_get_status > dwc3_decode_set_clear_feature > dwc3_decode_set_addres

Re: [PATCH v4 5/6] usb:cdns3 Add Cadence USB3 DRD Driver

2019-02-19 Thread Greg KH
On Thu, Feb 14, 2019 at 07:45:13PM +, Pawel Laszczak wrote: > This patch introduce new Cadence USBSS DRD driver to linux kernel. Nit, "Linux" :) > The Cadence USBSS DRD Driver is a highly configurable IP Core whichi "whichi"? > can be instantiated as Dual-Role Device (DRD), Peripheral Only

Re: [PATCH v1] usb: dwc3: drd: Defer probe if extcon device is not found

2019-02-19 Thread Greg Kroah-Hartman
On Mon, Feb 18, 2019 at 03:26:31PM +0200, Andy Shevchenko wrote: > In case the "linux,extcon-name" property is defined but device itself > is not ready, defer the probe. > > Cc: Felipe Balbi > Signed-off-by: Andy Shevchenko > --- > > This is a missed part of the v2 [1] of the commit 268784ba14a

Re: [PATCH] usb: core: skip interfaces disabled in devicetree

2019-02-19 Thread Måns Rullgård
Greg Kroah-Hartman writes: > On Sat, Feb 16, 2019 at 05:04:52PM +, Mans Rullgard wrote: >> If an interface has an associated devicetree node with status disabled, >> do not register the device. This is useful for boards with a built-in >> multifunction USB device where some functions are bro

Re: [PATCH] usb: core: skip interfaces disabled in devicetree

2019-02-19 Thread Greg Kroah-Hartman
On Tue, Feb 19, 2019 at 01:24:51PM +, Måns Rullgård wrote: > Greg Kroah-Hartman writes: > > > On Sat, Feb 16, 2019 at 05:04:52PM +, Mans Rullgard wrote: > >> If an interface has an associated devicetree node with status disabled, > >> do not register the device. This is useful for boards

[PATCH][next] usb: typec: mux: remove redundant check on variable match

2019-02-19 Thread Colin King
From: Colin Ian King All the code paths that lead to the return statement are where match is always true, hence the check to see if it is true is redundant and can be removed. Detected by CoverityScan, CID#14769672 ("Logically dead code") Signed-off-by: Colin Ian King --- drivers/usb/typec/mu

Re: [PATCH v1] usb: dwc3: drd: Defer probe if extcon device is not found

2019-02-19 Thread Felipe Balbi
Greg Kroah-Hartman writes: > On Mon, Feb 18, 2019 at 03:26:31PM +0200, Andy Shevchenko wrote: >> In case the "linux,extcon-name" property is defined but device itself >> is not ready, defer the probe. >> >> Cc: Felipe Balbi >> Signed-off-by: Andy Shevchenko >> --- >> >> This is a missed part

Re: [PATCH v2 01/10] dt-bindings: phy: Add support for HiSilicon's hi3660 USB PHY

2019-02-19 Thread Rob Herring
On Mon, Feb 18, 2019 at 9:03 PM Chunfeng Yun wrote: > > Hi, > On Tue, 2019-02-19 at 09:50 +0800, Chen Yu wrote: > > Hi, > > > > On 2019/2/19 4:18, Rob Herring wrote: > > > On Mon, Feb 18, 2019 at 07:23:01PM +0800, Yu Chen wrote: > > >> This patch adds binding documentation for supporting the hi366

usb: over-current condition

2019-02-19 Thread Subhashini Rao Beerisetty
Hi All, [ Please keep me in CC as I'm not subscribed to the list] I’m using an Ubuntu 16.04.4 LTS PC and when I connect an USB device to my Ubuntu PC, I see the below mentioned messages in dmesg. [ 9012.287432] usb usb3-port1: over-current condition [ 9012.287739] usb usb2-port1: over-curren

Re: usb: over-current condition

2019-02-19 Thread Roger Quadros
Hi Subhashini, On 19/02/2019 16:30, Subhashini Rao Beerisetty wrote: > Hi All, > > [ Please keep me in CC as I'm not subscribed to the list] > > > I’m using an Ubuntu 16.04.4 LTS PC and when I connect an USB device to > my Ubuntu PC, I see the below mentioned messages in dmesg. > > > > [ 901

Re: usb: over-current condition

2019-02-19 Thread Greg KH
On Tue, Feb 19, 2019 at 08:00:11PM +0530, Subhashini Rao Beerisetty wrote: > Hi All, > > [ Please keep me in CC as I'm not subscribed to the list] > > > I’m using an Ubuntu 16.04.4 LTS PC and when I connect an USB device to > my Ubuntu PC, I see the below mentioned messages in dmesg. That's a v

Re: [PATCH][next] usb: typec: mux: remove redundant check on variable match

2019-02-19 Thread Heikki Krogerus
On Tue, Feb 19, 2019 at 01:43:33PM +, Colin King wrote: > From: Colin Ian King > > All the code paths that lead to the return statement are where > match is always true, hence the check to see if it is true is > redundant and can be removed. > > Detected by CoverityScan, CID#14769672 ("Logic

usb: gadget: net2280: Fix function net2280_dequeue()

2019-02-19 Thread guido
Hi Alan, My last proposal "udc: net2280: Fix overrun of OUT messages" is still under investigation. During the random stress tests I found a new rare problem: When a request must be dequeued with net2280_dequeue() e.g. due to a device clear action and the same request is finished by the functio

[PATCH v2] usb: core: skip interfaces disabled in devicetree

2019-02-19 Thread Mans Rullgard
If an interface has an associated devicetree node with status disabled, do not register the device. This is useful for boards with a built-in multifunction USB device where some functions are broken or otherwise undesired. Signed-off-by: Mans Rullgard --- Changed in v2: - print message about ski

Re: usb: over-current condition

2019-02-19 Thread Roger Quadros
Please keep linux-usb in cc. On 19/02/2019 16:50, Subhashini Rao Beerisetty wrote: > On Tue, Feb 19, 2019 at 8:06 PM Roger Quadros wrote: >> >> Hi Subhashini, >> >> On 19/02/2019 16:30, Subhashini Rao Beerisetty wrote: >>> Hi All, >>> >>> [ Please keep me in CC as I'm not subscribed to the list]

[PATCH][next] usb: typec: mux: fix an unsigned less than zero check

2019-02-19 Thread Colin King
From: Colin Ian King The checks of a negative nval indicating an error an never be true as nval is currently a size_t which is of course unsigned and hence never less than zero. Fix this by making nval an int. Detected by CoverityScan, CID#1476863 ("Unsigned compared against 0) and CID#1476948

Re: [BUG] mt76x0u: Probing issues on Raspberry Pi 3 B+

2019-02-19 Thread Alan Stern
On Tue, 19 Feb 2019, Stanislaw Gruszka wrote: > It would be interesting why urb->num_sgs = 0 & urb->sg cause > the troubles. This is how usb_sg_init() submit urbs for sg_tablesize = 0 > controllers. So either are there are some requirement on urb->sg > mapped via dma_map_page() (which mt76usb does

[PATCH] usb: xhci: Support running urb giveback in tasklet context

2019-02-19 Thread Suwan Kim
Patch "USB: HCD: support giveback of URB in tasklet context" introduced giveback of urb in tasklet context. [1] This patch was applied to ehci but not xhci. [2] It significantly reduces the hard irq time of xhci. Especially for the uvc driver, the hard irq including the uvc complete function runs q

[PATCH] usb: xhci: add Immediate Data Transfer support

2019-02-19 Thread Nicolas Saenz Julienne
Immediate data transfers (IDT) allow the HCD to copy small chunks of data (up to 8bytes) directly into its output transfer TRBs. This avoids the somewhat expensive DMA mappings that are performed by default on most URBs submissions. In the case an URB was suitable for IDT. The data is directly cop

Re: [BUG] mt76x0u: Probing issues on Raspberry Pi 3 B+

2019-02-19 Thread Stefan Wahren
Am 19.02.19 um 11:59 schrieb Stanislaw Gruszka: > On Mon, Feb 18, 2019 at 11:19:40PM +0100, Stefan Wahren wrote: >> Hi, >> >>> Stanislaw Gruszka hat am 18. Februar 2019 um 14:52 >>> geschrieben: >>> >>> >>> On Sat, Feb 16, 2019 at 08:17:07PM +0100, Stefan Wahren wrote: >>> >>> Sorry for being inp

[PATCH] usb: dwc2: suppress confusing warnings on BCM2835

2019-02-19 Thread Stefan Wahren
According to the BCM2835 datasheet the used Synopsys IP isn't a LPM-capable core. So disable these features and suppress these confusing warnings: dwc2 3f98.usb: dwc2_check_params: Invalid parameter lpm=1 dwc2 3f98.usb: dwc2_check_params: Invalid parameter lpm_clock_gating=1 dwc2 3f98.

Re: XHCI ISSUE: xhci_hcd: disabling already-disabled device

2019-02-19 Thread Todd Brandt
On Wed, 2019-02-13 at 08:38 +0100, Greg KH wrote: > On Fri, Jan 25, 2019 at 02:45:05PM -0800, Todd Brandt wrote: > > Hi Greg, we run weekly 48-hour S3/S2idle stress tests on each > > release > > candidate, and I found a single instance (out of 2794 runs) of this > > warning on the Lenovo Yoga 920 w

Re: [PATCH v2] scsi: sd: block: Fix regressions in read-only block device handling

2019-02-19 Thread Martin K. Petersen
Hi Ming, > From the Bugzilla, looks it is only reported on the "Kingston DT > Ultimate G3" USB flash drive. There are several bug reports as a result of the change. It's not at all uncommon for a device to switch at runtime. Before Jeremy's change we just didn't see it because the device settin

[PATCH] usb: core: Replace hardcoded check with inline function from usb.h

2019-02-19 Thread Keyur Patel
From: Keyur Patel Expression (urb->transfer_flags & URB_DIR_MASK) == URB_DIR_IN can be replaced by usb_urb_dir_in(struct urb *urb) from usb.h for better readability. Signed-off-by: Keyur Patel --- drivers/usb/core/devio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/driv

Re: [PATCH v2 02/10] dt-bindings: misc: Add bindings for HiSilicon usb hub and data role switch functionality on HiKey960

2019-02-19 Thread Chen Yu
Hi, On 2019/2/19 16:25, Sergei Shtylyov wrote: > Hello! > > On 18.02.2019 14:23, Yu Chen wrote: > >> This patch adds binding documentation to support usb hub and usb >> data role switch of Hisilicon HiKey960 Board. >> >> Cc: Sergei Shtylyov >> Cc: Rob Herring >> Cc: Mark Rutland >> Cc: John S

[PATCH] r8152: Fix an error on RTL8153-BD MAC Address Passthrough support

2019-02-19 Thread David Chen
From: David Chen RTL8153-BD is used in Dell DA300 type-C dongle. Added RTL8153-BD support to activate MAC address pass through on DA300. Apply correction on previously submitted patch in net.git tree. Signed-off-by: David Chen --- drivers/net/usb/r8152.c | 2 +- 1 file changed, 1 insertion(+),

RE: [PATCH v4 2/6] usb:common Separated decoding functions from dwc3 driver.

2019-02-19 Thread Pawel Laszczak
Hi, >On Thu, Feb 14, 2019 at 07:45:10PM +, Pawel Laszczak wrote: >> Patch moves some decoding functions from driver/usb/dwc3/debug.h driver >> to driver/usb/common/debug.c file. These moved functions include: >> dwc3_decode_get_status >> dwc3_decode_set_clear_feature >> dwc3_decode

Re: [PATCH][next] usb: typec: mux: fix an unsigned less than zero check

2019-02-19 Thread Heikki Krogerus
On Tue, Feb 19, 2019 at 03:19:18PM +, Colin King wrote: > From: Colin Ian King > > The checks of a negative nval indicating an error an never be true > as nval is currently a size_t which is of course unsigned and hence > never less than zero. Fix this by making nval an int. > > Detected by