Re: [PATCH v3 0/9] device connection: Add support for device graphs

2019-02-18 Thread Greg Kroah-Hartman
On Fri, Feb 15, 2019 at 02:47:15PM +0200, Heikki Krogerus wrote: > Hi Greg, > > On Thu, Feb 14, 2019 at 11:10:44AM +0100, Greg Kroah-Hartman wrote: > > On Wed, Feb 13, 2019 at 10:45:48AM +0300, Heikki Krogerus wrote: > > > Hi, > > > > > > This is the third version of my proposal to add device gra

Re: [PATCH 2/2] RTL8153-BD is used in Dell DA300 type-C dongle. It should be added to the whitelist of devices to activate MAC address pass through.

2019-02-18 Thread Oliver Neukum
On Mo, 2019-02-18 at 11:48 +0800, David Chen wrote: > From: David Chen > > Per confirming with Realtek all devices containing RTL8153-BD should > activate MAC pass through and there won't use pass through bit on efuse > like in RTL8153-AD. > > Signed-off-by: David Chen > --- > drivers/net/usb/

Re: [PATCH 2/2] RTL8153-BD is used in Dell DA300 type-C dongle. It should be added to the whitelist of devices to activate MAC address pass through.

2019-02-18 Thread David Chen
Hi Oliver, Thanks for reviewing. I have made some mistake, will correct it and resend. Thanks and Regards, -David > Oliver Neukum 於 2019年2月18日 下午4:04 寫道: > >> On Mo, 2019-02-18 at 11:48 +0800, David Chen wrote: >> From: David Chen >> >> Per confirming with Realtek all devices containing RTL

Re: [PATCH v3] usb: chipidea: Grab the (legacy) USB PHY by phandle first

2019-02-18 Thread Paul Kocialkowski
Hi, On Mon, 2019-02-18 at 03:04 +, Peter Chen wrote: > > According to the chipidea driver bindings, the USB PHY is specified via the > > "phys" > > phandle node. However, this only takes effect for USB PHYs that use the > > common > > PHY framework. For legacy USB PHYs, a simple lookup based

Re: [PATCH v3 0/9] device connection: Add support for device graphs

2019-02-18 Thread Heikki Krogerus
On Mon, Feb 18, 2019 at 09:07:27AM +0100, Greg Kroah-Hartman wrote: > On Fri, Feb 15, 2019 at 02:47:15PM +0200, Heikki Krogerus wrote: > > Hi Greg, > > > > On Thu, Feb 14, 2019 at 11:10:44AM +0100, Greg Kroah-Hartman wrote: > > > On Wed, Feb 13, 2019 at 10:45:48AM +0300, Heikki Krogerus wrote: > >

Re: [PATCH v2] USB: serial: cp210x: Fix GPIO in autosuspend

2019-02-18 Thread Oliver Neukum
On So, 2019-02-17 at 18:59 +0100, Karoly Pados wrote: > Current GPIO code in cp210x fails to take USB autosuspend into account, > making it practically impossible to use GPIOs with autosuspend enabled > without user configuration. Fix this like for ftdi_sio in a previous patch. > Tested on a CP2102

USB 3.0 device next to USB 2.0 receiver result in dysfunctional mouse

2019-02-18 Thread usbuser
Hello, I build a new pc with the B450-I motherboard from Asus. My issue is the following: When I plug-in a USB 3.0 device next to the unifying receiver from logitech the mouse stops working. Meaning no movement, clicking or scrolling is registered. USB 2.0 devices do not result in a dysfunction

Re: 4.20.7: pl2303 not working (post-4.19 regression) (limited info so far, not yet bisected)

2019-02-18 Thread Nix
On 18 Feb 2019, Johan Hovold stated: > On Sun, Feb 17, 2019 at 07:13:52PM +, Nix wrote: >> I'm still fairly sure this is a regression -- my machines are often up >> for a lot longer than that and I've never seen this before I upgraded to >> 4.20.x -- but I don't think I'm going to identify it

Re: [PATCH 2/8] dt-bindings: phy: Add Amlogic G12A USB3+PCIE Combo PHY Bindings

2019-02-18 Thread Neil Armstrong
On 17/02/2019 23:03, Martin Blumenstingl wrote: > On Tue, Feb 12, 2019 at 4:15 PM Neil Armstrong > wrote: >> >> Add the Amlogic G12A Family USB3 + PCIE Combo PHY Bindings. >> >> This PHY can provide exclusively USB3 or PCIE support on shared I/Os. >> >> Signed-off-by: Neil Armstrong > one nit-pi

[PATCH] usb: host: xhci-rcar: Add XHCI_TRUST_TX_LENGTH quirk

2019-02-18 Thread Spyridon Papageorgiou
From: Yasushi Asano When plugging BUFFALO LUA4-U3-AGT USB3.0 to Gigabit Ethernet LAN Adapter, warning messages filled up dmesg. [ 101.098287] xhci-hcd ee00.usb: WARN Successful completion on short TX for slot 1 ep 4: needs XHCI_TRUST_TX_LENGTH quirk? [ 101.117463] xhci-hcd ee00.usb: W

Re: [PATCH 5/8] phy: amlogic: add Amlogic G12A USB2 PHY Driver

2019-02-18 Thread Neil Armstrong
Hi Martin, On 17/02/2019 23:24, Martin Blumenstingl wrote: > Hi Neil, > > On Tue, Feb 12, 2019 at 4:15 PM Neil Armstrong > wrote: >> >> This adds support for the USB2 PHY found in the Amlogic G12A SoC Family. >> >> It supports Host and/or Peripheral mode, depending on it's position. >> The firs

[PATCH v2 00/10] Add support for usb on Hikey960

2019-02-18 Thread Yu Chen
The patchset adds support for usb functionality of Hikey960, includes: - dwc3 driver for Hisilicon Kirin Soc hi3660 - usb driver for HiKey960 board - some adjustment in dwc3, usb gadget and typec driver - dts for support usb of HiKey960 --- v2: * This patchset based on patchset https://lkml.org/lk

[PATCH v2 03/10] usb: dwc3: dwc3-of-simple: Add support for dwc3 of Hisilicon Soc Platform

2019-02-18 Thread Yu Chen
This patch adds support for the poweron and shutdown of dwc3 core on Hisilicon Soc Platform. --- drivers/usb/dwc3/dwc3-of-simple.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/drivers/usb/dwc3/dwc3-of-simple.c index 4c2771c5e727..0ed09

[PATCH v2 07/10] usb: dwc3: Registering a role switch in the DRD code.

2019-02-18 Thread Yu Chen
The Type-C drivers use USB role switch API to inform the system about the negotiated data role, so registering a role switch in the DRD code in order to support platforms with USB Type-C connectors. Cc: John Stultz Cc: Felipe Balbi Cc: Greg Kroah-Hartman Cc: Heikki Krogerus Suggested-by: Heikk

[PATCH v2 05/10] phy: Add usb phy support for hi3660 Soc of Hisilicon

2019-02-18 Thread Yu Chen
This driver handles usb phy power on and shutdown for hi3660 Soc of Hisilicon. Cc: Andy Shevchenko Cc: Kishon Vijay Abraham I Cc: "David S. Miller" Cc: Greg Kroah-Hartman Cc: Mauro Carvalho Chehab Cc: Andrew Morton Cc: Arnd Bergmann Cc: Shawn Guo Cc: Pengcheng Li Cc: Jianguo Sun Cc: Masa

[PATCH v2 10/10] dts: hi3660: Add support for usb on Hikey960

2019-02-18 Thread Yu Chen
This patch adds support for usb on Hikey960. Cc: Wei Xu Cc: Rob Herring Cc: Mark Rutland Cc: linux-arm-ker...@lists.infradead.org Cc: John Stultz Cc: Binghui Wang Signed-off-by: Yu Chen --- v2: * Remove device_type property. * Add property "usb-role-switch". --- --- arch/arm64/boot/dts/hisi

[PATCH v2 09/10] usb: gadget: Add configfs attribuite for controling match_existing_only

2019-02-18 Thread Yu Chen
Currently the "match_existing_only" of usb_gadget_driver in configfs is set to one which is not flexible. Dwc3 udc will be removed when usb core switch to host mode. This causes failure of writing name of dwc3 udc to configfs's UDC attribuite. To fix this we need to add a way to change the config o

[PATCH v2 06/10] usb: roles: Add usb role switch notifier.

2019-02-18 Thread Yu Chen
This patch adds notifier for drivers want to be informed of the usb role switch. Cc: Greg Kroah-Hartman Cc: Heikki Krogerus Cc: Hans de Goede Cc: Andy Shevchenko Cc: John Stultz Suggested-by: Heikki Krogerus Signed-off-by: Yu Chen --- drivers/usb/roles/class.c | 20 +++- in

[PATCH v2 04/10] usb: dwc3: Add two quirks for Hisilicon Kirin Soc Platform

2019-02-18 Thread Yu Chen
There are tow quirks for DesignWare USB3 DRD Core of Hisilicon Kirin Soc. 1)SPLIT_BOUNDARY_DISABLE should be set for Host mode 2)A GCTL soft reset should be executed when switch mode Cc: Andy Shevchenko Cc: Felipe Balbi Cc: Greg Kroah-Hartman Cc: John Stultz Cc: Binghui Wang Signed-off-by: Yu

[PATCH v2 01/10] dt-bindings: phy: Add support for HiSilicon's hi3660 USB PHY

2019-02-18 Thread Yu Chen
This patch adds binding documentation for supporting the hi3660 usb phy on boards like the HiKey960. Cc: Rob Herring Cc: Mark Rutland Cc: John Stultz Cc: Binghui Wang Signed-off-by: Yu Chen --- v1: * Fix some format error as suggested by Rob. v2: * Change hi3660 usb PHY to hi3660 USB PHY ---

[PATCH v2 08/10] hikey960: Support usb functionality of Hikey960

2019-02-18 Thread Yu Chen
This driver handles usb hub power on and typeC port event of HiKey960 board: 1)DP&DM switching between usb hub and typeC port base on typeC port state 2)Control power of usb hub on Hikey960 3)Control vbus of typeC port Cc: Andy Shevchenko Cc: Arnd Bergmann Cc: Greg Kroah-Hartman Cc: John Stultz

[PATCH v2 02/10] dt-bindings: misc: Add bindings for HiSilicon usb hub and data role switch functionality on HiKey960

2019-02-18 Thread Yu Chen
This patch adds binding documentation to support usb hub and usb data role switch of Hisilicon HiKey960 Board. Cc: Sergei Shtylyov Cc: Rob Herring Cc: Mark Rutland Cc: John Stultz Cc: Binghui Wang Signed-off-by: Yu Chen --- v1: * Fix some format errors as suggested by Sergei. * Modify gpio d

Re: [PATCH v2 04/10] usb: dwc3: Add two quirks for Hisilicon Kirin Soc Platform

2019-02-18 Thread Andy Shevchenko
On Mon, Feb 18, 2019 at 1:23 PM Yu Chen wrote: > > There are tow quirks for DesignWare USB3 DRD Core of Hisilicon Kirin Soc. > 1)SPLIT_BOUNDARY_DISABLE should be set for Host mode > 2)A GCTL soft reset should be executed when switch mode Thus, it must be two patches, no? > +static void dwc3_gctl

Re: [RESEND PATCH] dt-bindings: arm: atmel: add new sam9x60 SFR binding

2019-02-18 Thread Nicolas.Ferre
On 06/02/2019 at 19:04, Nicolas Ferre wrote: > Add this SFR compatible definition for the sam9x60 SoC. Will be needed > in OHCI driver: ohci-at91.c. > > Signed-off-by: Nicolas Ferre > --- > Hi Rob, > It seems that this patch was lost in my series "[PATCH 0/8] ARM: at91/dt: > update to existing dr

Re: [PATCH v2 04/10] usb: dwc3: Add two quirks for Hisilicon Kirin Soc Platform

2019-02-18 Thread Chen Yu
Hi, On 2019/2/18 20:21, Andy Shevchenko wrote: > On Mon, Feb 18, 2019 at 1:23 PM Yu Chen wrote: >> >> There are tow quirks for DesignWare USB3 DRD Core of Hisilicon Kirin Soc. >> 1)SPLIT_BOUNDARY_DISABLE should be set for Host mode >> 2)A GCTL soft reset should be executed when switch mode > > T

[PATCH v1] usb: dwc3: drd: Defer probe if extcon device is not found

2019-02-18 Thread Andy Shevchenko
In case the "linux,extcon-name" property is defined but device itself is not ready, defer the probe. Cc: Felipe Balbi Signed-off-by: Andy Shevchenko --- This is a missed part of the v2 [1] of the commit 268784ba14a7 ("usb: dwc3: drd: Add support for DR detection through extcon") which see

Re: [BUG] mt76x0u: Probing issues on Raspberry Pi 3 B+

2019-02-18 Thread Stanislaw Gruszka
On Sat, Feb 16, 2019 at 08:17:07PM +0100, Stefan Wahren wrote: > this is a misunderstanding. The warning is about memory alignment to 32 bit > addresses, not about page alignment. This is a typical ARM restriction. Maybe > we need to make sure in mt76 that the DMA buffer needs to be aligned. But

Re: [PATCH 4/5] usb: typec: ucsi: Preliminary support for alternate modes

2019-02-18 Thread Heikki Krogerus
Hi, On Sat, Feb 16, 2019 at 01:36:05AM +, Michael Hsu wrote: > > I think for clarity's sake I better fix the mode index issue now and send > > second > > version of these patches so we can concentrate on the bigger problem, the > > two > > connector DP alt modes. > > > > Agreed. Please up

[PATCH] [V2]r8152: Add support for MAC address pass through on RTL8153-BD

2019-02-18 Thread David Chen
From: David Chen RTL8153-BD is used in Dell DA300 type-C dongle. It should be added to the whitelist of devices to activate MAC address pass through. Per confirming with Realtek all devices containing RTL8153-BD should activate MAC pass through and there won't use pass through bit on efuse like

Re: [PATCH] [V2]r8152: Add support for MAC address pass through on RTL8153-BD

2019-02-18 Thread Jiri Slaby
On 18. 02. 19, 15:00, David Chen wrote: > From: David Chen > > RTL8153-BD is used in Dell DA300 type-C dongle. > It should be added to the whitelist of devices to activate MAC address > pass through. > > Per confirming with Realtek all devices containing RTL8153-BD should > activate MAC pass thr

Re: [BUG] mt76x0u: Probing issues on Raspberry Pi 3 B+

2019-02-18 Thread Lorenzo Bianconi
> commit 0d9813319b40399a0d8fd761d2fcfedee5701487 > Author: Lorenzo Bianconi > Date: Fri Sep 7 23:13:12 2018 +0200 [...] > diff --git a/drivers/net/wireless/mediatek/mt76/mt76x02_util.c > b/drivers/net/wireless/mediatek/mt76/mt76x02_util.c > index 062614ad0d51..08425b1d2c30 100644 > --- a/dri

[PATCH -next] cdc-wdm: pass return value of recover_from_urb_loss

2019-02-18 Thread YueHaibing
'rv' is the correct return value, pass it upstream instead of 0 Fixes: 17d80d562fd7 ("USB: autosuspend for cdc-wdm") Signed-off-by: YueHaibing --- drivers/usb/class/cdc-wdm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/class/cdc-wdm.c b/drivers/usb/class/cdc-w

Re: [usb:usb-testing 63/64] drivers/usb/typec/mux.c:167 typec_mux_match() warn: unsigned 'nval' is never less than zero.

2019-02-18 Thread Heikki Krogerus
On Fri, Feb 15, 2019 at 07:51:56PM +0200, Andy Shevchenko wrote: > On Fri, Feb 15, 2019 at 4:40 PM Heikki Krogerus > wrote: > > > > On Fri, Feb 15, 2019 at 11:19:47AM +0200, Andy Shevchenko wrote: > > > On Fri, Feb 15, 2019 at 11:01 AM Heikki Krogerus > > > wrote: > > > > > > > > On Fri, Feb 15,

Re: [BUG] mt76x0u: Probing issues on Raspberry Pi 3 B+

2019-02-18 Thread Felix Fietkau
On 2019-02-18 14:52, Stanislaw Gruszka wrote: > On Sat, Feb 16, 2019 at 08:17:07PM +0100, Stefan Wahren wrote: >> this is a misunderstanding. The warning is about memory alignment to 32 bit >> addresses, not about page alignment. This is a typical ARM restriction. >> Maybe we need to make sure in

Re: [BUG] mt76x0u: Probing issues on Raspberry Pi 3 B+

2019-02-18 Thread Stanislaw Gruszka
On Mon, Feb 18, 2019 at 03:25:28PM +0100, Lorenzo Bianconi wrote: > > commit 0d9813319b40399a0d8fd761d2fcfedee5701487 > > Author: Lorenzo Bianconi > > Date: Fri Sep 7 23:13:12 2018 +0200 > > [...] > > > diff --git a/drivers/net/wireless/mediatek/mt76/mt76x02_util.c > > b/drivers/net/wireless/

Re: [BUG] mt76x0u: Probing issues on Raspberry Pi 3 B+

2019-02-18 Thread Stanislaw Gruszka
On Mon, Feb 18, 2019 at 03:43:26PM +0100, Felix Fietkau wrote: > On 2019-02-18 14:52, Stanislaw Gruszka wrote: > > On Sat, Feb 16, 2019 at 08:17:07PM +0100, Stefan Wahren wrote: > >> this is a misunderstanding. The warning is about memory alignment to 32 > >> bit addresses, not about page alignmen

Re: [PATCH v4 1/6] dt-bindings: add binding for USBSS-DRD controller.

2019-02-18 Thread Rob Herring
On Thu, 14 Feb 2019 19:45:09 +, Pawel Laszczak wrote: > This patch aim at documenting USB related dt-bindings for the > Cadence USBSS-DRD controller. > > Signed-off-by: Pawel Laszczak > --- > .../devicetree/bindings/usb/cdns-usb3.txt | 30 +++ > 1 file changed, 30 inserti

[PATCH v2] usb: musb: Fix urb->hcpriv value

2019-02-18 Thread Matwey V. Kornilov
urb->hcpriv != NULL is used to indicate that the URB is queued [1]. Also see __usb_hcd_giveback_urb() and usb_hcd_submit_urb() for the reference. In this code path, the URB is actually queued and valid qh is hep->hcpriv. [1] https://lkml.org/lkml/2019/1/25/750 Fixes: 714bc5ef3eda ("musb: potenti

Re: [PATCH v2 00/10] Add support for usb on Hikey960

2019-02-18 Thread Valentin Schneider
Hi, On 18/02/2019 11:23, Yu Chen wrote: > The patchset adds support for usb functionality of Hikey960, includes: > - dwc3 driver for Hisilicon Kirin Soc hi3660 > - usb driver for HiKey960 board > - some adjustment in dwc3, usb gadget and typec driver > - dts for support usb of HiKey960 > I want

Re: [PATCH v2 07/10] usb: dwc3: Registering a role switch in the DRD code.

2019-02-18 Thread Valentin Schneider
Hi, On 18/02/2019 11:23, Yu Chen wrote: [...] > @@ -522,6 +556,15 @@ int dwc3_drd_init(struct dwc3 *dwc) > dwc3_set_mode(dwc, DWC3_GCTL_PRTCAP_OTG); > } > > + dwc3_role_switch.fwnode = dev_fwnode(dwc->dev); > + dwc3_role_switch.set = dwc3_usb_role_switch_set; > +

Re: [RFC PATCH 0/2] Fix for the internal card reader and suspend on MacBooks

2019-02-18 Thread Eric Blau
On Wed, Feb 13, 2019 at 1:14 PM Ivan Mironov wrote: > > First patch adds code for this new quirk, and second patch enables this > quirk for card reader device which is used in my macbook. Hi Ivan, Thanks for sending these patches along. I've applied them against 4.20.8 and they fix the suspend/r

Re: [BUG] mt76x0u: Probing issues on Raspberry Pi 3 B+

2019-02-18 Thread Felix Fietkau
On 2019-02-18 16:03, Stanislaw Gruszka wrote: > On Mon, Feb 18, 2019 at 03:43:26PM +0100, Felix Fietkau wrote: >> On 2019-02-18 14:52, Stanislaw Gruszka wrote: >> > On Sat, Feb 16, 2019 at 08:17:07PM +0100, Stefan Wahren wrote: >> >> this is a misunderstanding. The warning is about memory alignment

[PATCH] usb: dwc2: use struct_size() in kzalloc()

2019-02-18 Thread Gustavo A. R. Silva
One of the more common cases of allocation size calculations is finding the size of a structure that has a zero-sized array at the end, along with memory for some number of elements for that array. For example: struct foo { int stuff; struct boo entry[]; }; size = sizeof(struct foo) + cou

[PATCH 09/14] media: usb: fix several typos

2019-02-18 Thread Mauro Carvalho Chehab
Use codespell to fix lots of typos over frontends. Manually verified to avoid false-positives. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/usb/au0828/au0828-core.c| 2 +- drivers/media/usb/au0828/au0828.h | 2 +- drivers/media/usb/cx231xx/cx231xx-avcore.

[PATCH] usb: core: config: Use struct_size() in kzalloc()

2019-02-18 Thread Gustavo A. R. Silva
One of the more common cases of allocation size calculations is finding the size of a structure that has a zero-sized array at the end, along with memory for some number of elements for that array. For example: struct foo { int stuff; struct boo entry[]; }; size = sizeof(struct foo) + cou

Re: [PATCH 2/2] RTL8153-BD is used in Dell DA300 type-C dongle. It should be added to the whitelist of devices to activate MAC address pass through.

2019-02-18 Thread David Miller
Where is patch #1?

Re: [PATCH v2 01/10] dt-bindings: phy: Add support for HiSilicon's hi3660 USB PHY

2019-02-18 Thread Rob Herring
On Mon, Feb 18, 2019 at 07:23:01PM +0800, Yu Chen wrote: > This patch adds binding documentation for supporting the hi3660 usb > phy on boards like the HiKey960. > > Cc: Rob Herring > Cc: Mark Rutland > Cc: John Stultz > Cc: Binghui Wang > Signed-off-by: Yu Chen > --- > v1: > * Fix some forma

[PATCH] usb: wusbcore: wa-xfer: use struct_size() helper

2019-02-18 Thread Gustavo A. R. Silva
Make use of the struct_size() helper instead of an open-coded version in order to avoid any potential type mistakes, in particular in the context in which this code is being used. So, change the following form: sizeof(*packet_desc) + (sizeof(packet_desc->PacketLength[0]) * seg->isoc_frame_count)

Re: [BUG] mt76x0u: Probing issues on Raspberry Pi 3 B+

2019-02-18 Thread Stefan Wahren
Hi, > Stanislaw Gruszka hat am 18. Februar 2019 um 14:52 > geschrieben: > > > On Sat, Feb 16, 2019 at 08:17:07PM +0100, Stefan Wahren wrote: > > this is a misunderstanding. The warning is about memory alignment to 32 bit > > addresses, not about page alignment. This is a typical ARM restricti

Re: [PATCH] r8152: Add support for MAC address pass through on RTL8153-BD

2019-02-18 Thread David Miller
From: David Chen Date: Sat, 16 Feb 2019 17:16:42 +0800 > From: David Chen > > RTL8153-BD is used in Dell DA300 type-C dongle. > It should be added to the whitelist of devices to activate MAC address > pass through. > > Per confirming with Realtek all devices containing RTL8153-BD should > acti

Re: [PATCH v2 00/10] Add support for usb on Hikey960

2019-02-18 Thread Chen Yu
Hi, On 2019/2/19 1:30, Valentin Schneider wrote: > Hi, > > On 18/02/2019 11:23, Yu Chen wrote: >> The patchset adds support for usb functionality of Hikey960, includes: >> - dwc3 driver for Hisilicon Kirin Soc hi3660 >> - usb driver for HiKey960 board >> - some adjustment in dwc3, usb gadget and

Re: [PATCH v2] scsi: sd: block: Fix regressions in read-only block device handling

2019-02-18 Thread Ming Lei
On Wed, Feb 13, 2019 at 5:01 PM Martin K. Petersen wrote: > > Some devices come online in write protected state and switch to > read-write once they are ready to process I/O requests. These devices > broke with commit 20bd1d026aac ("scsi: sd: Keep disk read-only when > re-reading partition") becau

Re: [PATCH v2 07/10] usb: dwc3: Registering a role switch in the DRD code.

2019-02-18 Thread Chen Yu
Hi, On 2019/2/19 1:30, Valentin Schneider wrote: > Hi, > > On 18/02/2019 11:23, Yu Chen wrote: > [...] >> @@ -522,6 +556,15 @@ int dwc3_drd_init(struct dwc3 *dwc) >> dwc3_set_mode(dwc, DWC3_GCTL_PRTCAP_OTG); >> } >> >> +dwc3_role_switch.fwnode = dev_fwnode(dwc->dev); >> +

Re: [PATCH v2 01/10] dt-bindings: phy: Add support for HiSilicon's hi3660 USB PHY

2019-02-18 Thread Chen Yu
Hi, On 2019/2/19 4:18, Rob Herring wrote: > On Mon, Feb 18, 2019 at 07:23:01PM +0800, Yu Chen wrote: >> This patch adds binding documentation for supporting the hi3660 usb >> phy on boards like the HiKey960. >> >> Cc: Rob Herring >> Cc: Mark Rutland >> Cc: John Stultz >> Cc: Binghui Wang >> Si

Re: [PATCH v2 08/10] hikey960: Support usb functionality of Hikey960

2019-02-18 Thread Chunfeng Yun
Hi, On Mon, 2019-02-18 at 19:23 +0800, Yu Chen wrote: > This driver handles usb hub power on and typeC port event of HiKey960 board: > 1)DP&DM switching between usb hub and typeC port base on typeC port > state > 2)Control power of usb hub on Hikey960 > 3)Control vbus of typeC port > > Cc: Andy Sh

Re: [PATCH v2 07/10] usb: dwc3: Registering a role switch in the DRD code.

2019-02-18 Thread Jun Li
Hi Yu Chen 于2019年2月18日周一 下午7:34写道: > > The Type-C drivers use USB role switch API to inform the > system about the negotiated data role, so registering a role > switch in the DRD code in order to support platforms with > USB Type-C connectors. > > Cc: John Stultz > Cc: Felipe Balbi > Cc: Greg Kr

Re: [PATCH v2 01/10] dt-bindings: phy: Add support for HiSilicon's hi3660 USB PHY

2019-02-18 Thread Chunfeng Yun
Hi, On Tue, 2019-02-19 at 09:50 +0800, Chen Yu wrote: > Hi, > > On 2019/2/19 4:18, Rob Herring wrote: > > On Mon, Feb 18, 2019 at 07:23:01PM +0800, Yu Chen wrote: > >> This patch adds binding documentation for supporting the hi3660 usb > >> phy on boards like the HiKey960. > >> > >> Cc: Rob Herrin

Re: [PATCH v2 08/10] hikey960: Support usb functionality of Hikey960

2019-02-18 Thread Chen Yu
Hi, On 2019/2/19 10:50, Chunfeng Yun wrote: >> +if (ret) >> +hisi_hikey_usb->typec_vbus_enable_val = 1; >> + >> +hisi_hikey_usb->typec_vbus = devm_gpiod_get(dev, "typec-vbus", >> +hisi_hikey_usb->typec_vbus_enable_val ? >> +GPIOD_OUT_LOW

Re: [PATCH v2 07/10] usb: dwc3: Registering a role switch in the DRD code.

2019-02-18 Thread Chen Yu
Hi, On 2019/2/19 10:57, Jun Li wrote: >> >> +static int dwc3_usb_role_switch_set(struct device *dev, enum usb_role role) >> +{ >> + u32 mode; >> + >> + switch (role) { >> + case USB_ROLE_HOST: >> + mode = DWC3_GCTL_PRTCAP_HOST; >> + break; >> + c

Re: [PATCH v2 01/10] dt-bindings: phy: Add support for HiSilicon's hi3660 USB PHY

2019-02-18 Thread Chen Yu
Hi, On 2019/2/19 11:03, Chunfeng Yun wrote: + +Example: + usb-phy { + compatible = "hisilicon,hi3660-usb-phy"; + #phy-cells = <0>; + hisilicon,pericrg-syscon = <&crg_ctrl>; + hisilicon,pctrl-syscon = <&pctrl>; +

Re: [PATCH] [v2]USB:serial:pl2303:add new Pull-Up mode to support PL2303HXD (TYPE_HX)

2019-02-18 Thread Charles Yeh
Hi Johan & Greg, Do you have received a new patch"[PATCH] [v2]USB:serial:pl2303:add new Pull-Up mode to support PL2303HXD (TYPE_HX)"? If you have received a new patch, has the content been confirmed? Or tell me where needs to be modified. Charles Yeh 於 2019年2月12日 週二 下午8:51寫道: > > Pull-Up mode

Re: [PATCH] USB:serial:pl2303:Add new PID to support PL2303HXN (TYPE_HXN)

2019-02-18 Thread Charles Yeh
Hi Johan & Greg, Do you have received a new patch"[PATCH] USB:serial:pl2303:Add new PID to support PL2303HXN (TYPE_HXN)"? If you have received a new patch, has the content been confirmed? Or tell me where needs to be modified. Thanks! Charles. Charles Yeh 於 2019年2月13日 週三 下午8:30寫道: > > Pr

[PATCH -next] usb: typec: mux: Fix unsigned comparison with less than zero

2019-02-18 Thread YueHaibing
The return from the call to fwnode_property_read_u16_array is int, it can be a negative error code however this is being assigned to an size_t variable 'nval', hence the check is always false. Fix this by making 'nval' an int. Detected by Coccinelle ("Unsigned expression compared with zero: nval

[PATCH v2 2/2] usb: dwc3: Add workaround for host mode VBUS glitch when boot

2019-02-18 Thread Ran Wang
When DWC3 is set to host mode by programming register DWC3_GCTL, VBUS (or its control signal) will be turned on immediately on related Root Hub ports. Then, the VBUS is turned off for a little while(15us) when do xhci reset (conducted by xhci driver) and back to normal finally, we can observe a neg

[PATCH v2 1/2] usb: dwc3: Add avoiding vbus glitch happen during xhci reset

2019-02-18 Thread Ran Wang
When DWC3 is set to host mode by programming register DWC3_GCTL, VBUS (or its control signal) will turn on immediately on related Root Hub ports. Then the VBUS will be de-asserted for a little while during xhci reset (conducted by xhci driver) for a little while and back to normal. This VBUS glitc

[PATCH v5 1/6] dt-bindings: usb: musb: Add support for MediaTek musb controller

2019-02-18 Thread min.guo
From: Min Guo This adds support for MediaTek musb controller in host, peripheral and otg mode. Signed-off-by: Min Guo --- changes in v5: suggested by Rob: 1. Modify compatible as - compatible : should be one of: "mediatek,mt-2701" ... followed by "m

[PATCH v5 0/6] Add MediaTek MUSB Controller Driver

2019-02-18 Thread min.guo
From: Min Guo These patches introduce the MediaTek MUSB controller driver. The driver can be configured as Dual-Role Device (DRD), Peripheral Only and Host Only modes. This has beed tested on MT2701 with a variety of devices in host mode and with the f_mass gadget driver in peripheral mode, plu

[PATCH v5 2/6] arm: dts: mt2701: Add usb2 device nodes

2019-02-18 Thread min.guo
From: Min Guo Add musb nodes and usb2 phy nodes for MT2701 Signed-off-by: Min Guo --- changes in v5: 1. Add usb connector child node changes in v4: 1. no changes changes in v3: 1. no changes changes in v2: 1. Remove phy-names --- arch/arm/boot/dts/mt2701-evb.dts | 26 +++

[PATCH v5 5/6] usb: musb: Add musb_clearb/w() interface

2019-02-18 Thread min.guo
From: Min Guo Delete the const attribute of addr parameter in readb/w/l hooks, these changes are for implementing clearing W1C registers. Replace musb_readb/w with musb_clearb/w to clear the interrupt status. Signed-off-by: Min Guo --- changes in v5: 1. Replace musb_readb() with musb_clearb() t

[PATCH v5 4/6] usb: musb: Add noirq type of dma create interface

2019-02-18 Thread min.guo
From: Min Guo Add noirq type of dma create interface for platform which do not have dedicated DMA interrupt line, move musbhsdma macro definition to musb_dma.h Signed-off-by: Min Guo --- changes in v5: 1. no changes new patch based on v4: --- drivers/usb/musb/musb_dma.h | 9 driver

[PATCH v5 6/6] usb: musb: Add support for MediaTek musb controller

2019-02-18 Thread min.guo
From: Min Guo This adds support for MediaTek musb controller in host, peripheral and otg mode. There are some quirk of MediaTek musb controller, such as: -W1C interrupt status registers -Private data toggle registers -No dedicated DMA interrupt line Signed-off-by: Min Guo Signed-off-by: Yong

[PATCH v5 3/6] usb: musb: Add get/set toggle hooks

2019-02-18 Thread min.guo
From: Min Guo Add get/set toggle hooks in struct musb_io and struct musb_platform_ops for special platform; remove function musb_save_toggle, use the set/get callback to handle toggle. Signed-off-by: Min Guo --- changes in v5: 1. no changes new patch based on v4: --- drivers/usb/musb/musb_cor

Re: [PATCH -next] usb: typec: mux: Fix unsigned comparison with less than zero

2019-02-18 Thread Heikki Krogerus
On Tue, Feb 19, 2019 at 02:57:50PM +0800, YueHaibing wrote: > The return from the call to fwnode_property_read_u16_array is int, > it can be a negative error code however this is being assigned to > an size_t variable 'nval', hence the check is always false. > Fix this by making 'nval' an int. >