Re: [PATCH 4/5] usb: typec: ucsi: Preliminary support for alternate modes

2019-02-06 Thread Heikki Krogerus
Hi Ajay, On Tue, Feb 05, 2019 at 12:59:27AM +, Ajay Gupta wrote: > > +static int ucsi_register_altmode(struct ucsi_connector *con, > > +struct typec_altmode_desc *desc, > > +u8 recipient) > > +{ > > + struct typec_altmode *alt; > > +

Re: [PATCH 5/5] usb: typec: ucsi: Support for DisplayPort alt mode

2019-02-06 Thread Heikki Krogerus
Hi, On Tue, Feb 05, 2019 at 01:03:58AM +, Ajay Gupta wrote: > > @@ -412,6 +424,12 @@ static void ucsi_unregister_altmodes(struct > > ucsi_connector *con, u8 recipient) > > } > > > > while (adev[i]) { > > + if (recipient == UCSI_RECIPIENT_SOP && > > + adev[i]->s

Re: [PATCH] usb: dwc3: Enable GBit Ethernet on Odroid XU4

2019-02-06 Thread Roger Quadros
Hi, On 21/01/19 16:02, Jochen Sprickerhof wrote: > Note that it only works with USB_XHCI_PLATFORM=y. Also it needs a hard > reset when coming from an unpatched kernel. > > This was included in the original patch in > https://patchwork.kernel.org/patch/9992809/ but got dropped when > accepted in d

Re: [PATCH 5/5] usb: typec: ucsi: Support for DisplayPort alt mode

2019-02-06 Thread Heikki Krogerus
Hi Ajay, On Tue, Feb 05, 2019 at 07:24:49PM +, Ajay Gupta wrote: > > +static int ucsi_displayport_configure(struct ucsi_dp *dp) { > > + u32 pins = DP_CONF_GET_PIN_ASSIGN(dp->data.conf); > > + struct ucsi_control ctrl; > > + > > + if (!dp->override) > > + return 0; > > + > > +

Re: [PATCH] USB: dwc3: add missing of_node_put()

2019-02-06 Thread Patrice CHOTARD
Hi Wen On 2/3/19 4:52 AM, wen yang wrote: > The call to of_find_node_by_name returns a node pointer with refcount > incremented thus it must be explicitly decremented here after the last > usage. > The of_find_device_by_node() takes a reference to the underlying device > structure, we also should

[PATCH v2] USB: serial: cp210x: add minimun baud rate for CP2105 SCI

2019-02-06 Thread Johanna Abrahamsson
From: Johanna Abrahamsson This patch adds minimum baud rate to the cp210x driver. According to the datasheet for CP2105, the SCI supports 2400 as the lowest baud rate. As this is not heeded in the current code, an error message 'failed set req 0x1e size 4 status: -32' when trying to set a lower

Re: [PATCH 4/5] usb: typec: ucsi: Preliminary support for alternate modes

2019-02-06 Thread Heikki Krogerus
Hi Michael, On Fri, Feb 01, 2019 at 10:02:19PM +, Michael Hsu wrote: > Hi Heikki, the use of "con->port_altmode[cur]->mode" (which is a 1-based > index, not a 32-bit mode VDO) can cause incorrect matches if the > GET_ALTERNATE_MODES returns different ordering for recipient=connector and > reci

Re: [PATCH v3 2/6] usb: typec: ucsi: add ccg command framework

2019-02-06 Thread Heikki Krogerus
Hi Ajay, Sorry for the late response, but I hit a compiler warning after doing bisect test. On Fri, Feb 01, 2019 at 05:05:06PM -0800, Ajay Gupta wrote: > +/* CCGx response codes */ > +enum ccg_resp_code { > + CMD_NO_RESP = 0x00, > + CMD_SUCCESS = 0x02, > + FLAS

Re: [PATCH v3 4/6] usb: typec: ucsi: add cmd used for fw flashing

2019-02-06 Thread Heikki Krogerus
On Fri, Feb 01, 2019 at 05:05:08PM -0800, Ajay Gupta wrote: > From: Ajay Gupta > > Adding support for below commands which will be used > during firmware flashing. > - ENTER_FLASHING > - RESET > - PDPORT_ENABLE > - JUMP_TO_BOOT > - FLASH_ROW_RW > - VALIDATE_FW

Re: [RFC v2] usb: xhci: add Immediate Data Transfer support

2019-02-06 Thread Nicolas Saenz Julienne
Hi Felipe, thanks for the review! On Wed, 2019-02-06 at 08:35 +0200, Felipe Balbi wrote: > Hi, > > Nicolas Saenz Julienne writes: > > diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c > > index 40fa25c4d041..a4efbe62a1a3 100644 > > --- a/drivers/usb/host/xhci-ring.c > > ++

Re: [PATCH] usb: dwc3: Enable GBit Ethernet on Odroid XU4

2019-02-06 Thread Roger Quadros
+Marek As Vivek's and Andrzej's Samsung IDs bounced back. On 06/02/19 11:38, Jochen Sprickerhof wrote: > * Roger Quadros [2019-02-06 10:41]: >> Hi, >> >> On 21/01/19 16:02, Jochen Sprickerhof wrote: > [..] >>> I'm not sure why this it only works with the driver compiled into the >>> kernel nor w

Re: [RFC v2] usb: xhci: add Immediate Data Transfer support

2019-02-06 Thread Felipe Balbi
Hi, Nicolas Saenz Julienne writes: >> > diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c >> > index 005e65922608..dec62f7f5dc8 100644 >> > --- a/drivers/usb/host/xhci.c >> > +++ b/drivers/usb/host/xhci.c >> > @@ -1238,6 +1238,21 @@ EXPORT_SYMBOL_GPL(xhci_resume); >> > >> > >> >

Re: [PATCH] usb: dwc3: Enable GBit Ethernet on Odroid XU4

2019-02-06 Thread Jochen Sprickerhof
* Roger Quadros [2019-02-06 10:41]: Hi, On 21/01/19 16:02, Jochen Sprickerhof wrote: [..] I'm not sure why this it only works with the driver compiled into the kernel nor why it needs a hard reset or why it was the line was dropped when the patch was accepted. Would be great to get some feedb

Re: [PATCH] USB: Fix configuration selection issues introduced in v4.20.0

2019-02-06 Thread Nikolay Yakimov
Hey there. Sorry to nag, but it seems we came to the conclusion that there's indeed a problem with the current code, and then collectively decided that we're done. Can I do something to expedite this? Are there any issues with my proposed patch? If there are, what can I do to fix those? Alternativ

Re: [PATCH v3 0/6] Add support for firmware update on Cypres CCGx

2019-02-06 Thread Heikki Krogerus
Hi Ajay, On Fri, Feb 01, 2019 at 05:05:04PM -0800, Ajay Gupta wrote: > Hi Heikki > > These changes adds support for updating firmware on Cypress CCGx > controller. New version (v3) fixes comments form you and Greg. > > I have tested them on NVIDIA GPU card. > > I will be posting firmware binary

Re: [PATCH] usb: dwc2: Reset device address on EnumDone

2019-02-06 Thread Minas Harutyunyan
Hi Felipe, On 2/6/2019 10:44 AM, Felipe Balbi wrote: > > Hi, > > Minas Harutyunyan writes: >> Hi Felipe, >> >> On 1/21/2019 11:13 AM, Minas Harutyunyan wrote: >>> Hi Felipe, >>> >>> On 12/12/2018 3:43 PM, Minas Harutyunyan wrote: Initially resetting device address was done in USB RESET int

Re: [PATCH 2/3] udc: net2280: Fix overrun of OUT messages

2019-02-06 Thread guido
Zitat von Alan Stern : On Tue, 5 Feb 2019 gu...@kiener-muenchen.de wrote: Zitat von Alan Stern : > On Mon, 4 Feb 2019, Guido Kiener wrote: > >> From: Guido Kiener >> >> The OUT endpoint normally blocks (NAK) subsequent packets when a >> short packet is received and returns an incomplete q

Re: [PATCH v2 1/2] dt-bindings: Add Qualcomm USB Super-Speed PHY bindings

2019-02-06 Thread Jorge Ramirez
On 2/5/19 12:02, Jorge Ramirez wrote: > On 1/30/19 21:02, Rob Herring wrote: >> On Tue, Jan 29, 2019 at 12:35:14PM +0100, Jorge Ramirez-Ortiz wrote: >>> Binding description for Qualcomm's Synopsys 1.0.0 super-speed PHY >>> controller embedded in QCS404. >>> >>> Based on Sriharsha Allenki's origina

[PATCH] USB: serial: cp210x: Add ID for Ingenico 3070

2019-02-06 Thread Ivan Mironov
Here is how this device appears in kernel log: usb 3-1: new full-speed USB device number 18 using xhci_hcd usb 3-1: New USB device found, idVendor=0b00, idProduct=3070 usb 3-1: New USB device strings: Mfr=1, Product=2, SerialNumber=3 usb 3-1: Product: Ingenico 3070

Re: [PATCH 2/3] udc: net2280: Fix overrun of OUT messages

2019-02-06 Thread Alan Stern
On Wed, 6 Feb 2019 gu...@kiener-muenchen.de wrote: > Alan, > > I have inserted a bug detection and can now explain the race: > > Ween receiving a long transfer the gadget driver queues a new request with > net2280_queue() and calls start_dma(). In the meantime the OUT FIFO is still > receiving d

RE: [PATCH v3 0/6] Add support for firmware update on Cypres CCGx

2019-02-06 Thread Ajay Gupta
Hi Heikki, > -Original Message- > From: Heikki Krogerus > Sent: Wednesday, February 6, 2019 4:12 AM > To: Ajay Gupta > Cc: linux-usb@vger.kernel.org; Ajay Gupta > Subject: Re: [PATCH v3 0/6] Add support for firmware update on Cypres CCGx > > Hi Ajay, > > On Fri, Feb 01, 2019 at 05:05:

Re: [PATCH 0/8] ARM: at91/dt: update to existing drivers for the sam9x60 SoC

2019-02-06 Thread Nicolas.Ferre
All, On 16/01/2019 at 10:57, Nicolas Ferre wrote: > Hi, > > This series collects some little modifications to DT bindings and associated > drivers changes for supporting the upcoming SAM9X60 SoC. > > I took the advantage of this series for fixing some of the leftovers in DT > bindings for reset

[RESEND PATCH] dt-bindings: arm: atmel: add new sam9x60 SFR binding

2019-02-06 Thread Nicolas Ferre
Add this SFR compatible definition for the sam9x60 SoC. Will be needed in OHCI driver: ohci-at91.c. Signed-off-by: Nicolas Ferre --- Hi Rob, It seems that this patch was lost in my series "[PATCH 0/8] ARM: at91/dt: update to existing drivers for the sam9x60 SoC". I split it and resend it only for

[PATCH] usb: dwc3: haps: Workaround matching VID PID

2019-02-06 Thread Thinh Nguyen
i.MX6QP and i.MX7D platform use a PCIe controller with the same VID and PID as this USB controller. The system may incorrectly match this driver to that PCIe controller. To workaround this, specifically use class type USB with PCI device ID to prevent incorrect driver matching. Signed-off-by: Thin

Re: [PATCH] usb: dwc2: gadget: Consider VBUS discharge time in disconnect flow

2019-02-06 Thread John Keeping
On Tue, 5 Feb 2019 12:08:48 +0400 Minas Harutyunyan wrote: > If VBUS discharge time > 3ms then on device cable disconnect, core > asserted Early Suspend then Suspend interrupts which no need to > handle. > > VBUS discharge time depend on PHY schematic implementation. > Can be up to 1 sec. > > T

[RFC net-next] net: fixed_phy: Move the DT based link GPIO parsing to of_mdio.c

2019-02-06 Thread Moritz Fischer
Move the DT based link GPIO parsing to of_mdio and let the places that register a fixed_phy pass in a GPIO descriptor or NULL. This allows fixed_phy on non-DT platforms to have link GPIOs, too. Signed-off-by: Moritz Fischer --- drivers/net/dsa/dsa_loop.c | 2 +- drivers/net/e

Re: [PATCH 2/2] USB: gadget: pxa25x: Add DT probing

2019-02-06 Thread Robert Jarzmik
Linus Walleij writes: > This makes it possible to instantiate the PXA25x UDC > driver from the device tree. > > Cc: Robert Jarzmik > Signed-off-by: Linus Walleij > --- > drivers/usb/gadget/udc/pxa25x_udc.c | 11 +++ > 1 file changed, 11 insertions(+) Mmmh it's a good start, but I don'

[GIT,PULL] add Cypress CCGx type-C controller firmware

2019-02-06 Thread Ajay Gupta
Hi Josh, This pull request is for Cypress CCGx controller firmware which is required for Type-C interface on Turing (tu10x) NVIDIA GPUs. They driver changes which is required to flash these firmwares are currently being reviewed at [1]. Thanks Ajay [ nvpublic ] [1] https://marc.info/?l=linux-us

[PATCH v4 1/2] usb: typec: ucsi: add get_fw_info function

2019-02-06 Thread Ajay Gupta
From: Ajay Gupta Function is to get the details of ccg firmware and device version. It will be useful in debugging and also during firmware update. Signed-off-by: Ajay Gupta --- Changes from v3 to v4 - None drivers/usb/typec/ucsi/ucsi_ccg.c | 66 ++- 1 file

[PATCH v4 2/2] usb: typec: ucsi: add firmware flashing support

2019-02-06 Thread Ajay Gupta
From: Ajay Gupta CCGx has two copies of the firmware in addition to the bootloader. If the device is running FW1, FW2 can be updated with the new version. Dual firmware mode allows the CCG device to stay in a PD contract and support USB PD and Type-C functionality while a firmware update is in pr

[PATCH v4 0/2] Add support for firmware update on Cypres CCGx

2019-02-06 Thread Ajay Gupta
Hi Heikki These changes adds support for updating firmware on Cypress CCGx controller. New version (v4) has two patches where second one is merge of patch 2,3,4,5 and 6 of previous version (v3) to fix git bisect compile warning. I have tested them on NVIDIA GPU card. Firmware binary pull-request

Re: [PATCH] USB: serial: cp210x: Fix GPIO in autosuspend

2019-02-06 Thread Karoly Pados
Uhm, yes, sorry, it kind of went out of my head. I am doing a lot of travelling lately (in the past 48 hours I've been on 3 airplanes), and I had travels on earlier weeks too, mixed with some project releases and family celebrations. So my head is just somewhere else. Realistically, I'll submit

Re: [RFC net-next] net: fixed_phy: Move the DT based link GPIO parsing to of_mdio.c

2019-02-06 Thread Andrew Lunn
On Wed, Feb 06, 2019 at 12:51:06PM -0800, Moritz Fischer wrote: > Move the DT based link GPIO parsing to of_mdio and let the places > that register a fixed_phy pass in a GPIO descriptor or NULL. > > This allows fixed_phy on non-DT platforms to have link GPIOs, too. > > Signed-off-by: Moritz Fisch

Re: Fwd: composite device fails to reset "suspended" flag

2019-02-06 Thread Frank Mori Hess
Hi Minas, On Tue, Feb 5, 2019 at 5:22 AM Minas Harutyunyan wrote: > Could you please try patch submitted by me today:"[PATCH] usb: dwc2: > gadget: Consider VBUS discharge time in disconnect flow" I should be able to try it tonight or tomorrow to see if it makes the driver recognize a cable disco

RE: [PATCH 4/5] usb: typec: ucsi: Preliminary support for alternate modes

2019-02-06 Thread Michael Hsu
Hi Heikki, > -Original Message- > From: Heikki Krogerus > Sent: Tuesday, February 5, 2019 7:24 AM > To: Michael Hsu > Cc: Greg Kroah-Hartman ; Ajay Gupta > ; linux-usb@vger.kernel.org > Subject: Re: [PATCH 4/5] usb: typec: ucsi: Preliminary support for alternate > modes > > Hi Michael,

Re: [RFC net-next] net: fixed_phy: Move the DT based link GPIO parsing to of_mdio.c

2019-02-06 Thread Moritz Fischer
Hi Andrew, thanks for your feedback. On Wed, Feb 06, 2019 at 10:53:22PM +0100, Andrew Lunn wrote: > On Wed, Feb 06, 2019 at 12:51:06PM -0800, Moritz Fischer wrote: > > Move the DT based link GPIO parsing to of_mdio and let the places > > that register a fixed_phy pass in a GPIO descriptor or NULL

Re: [RFC net-next] net: fixed_phy: Move the DT based link GPIO parsing to of_mdio.c

2019-02-06 Thread Florian Fainelli
On 2/6/19 2:38 PM, Moritz Fischer wrote: > Hi Andrew, > > thanks for your feedback. > > On Wed, Feb 06, 2019 at 10:53:22PM +0100, Andrew Lunn wrote: >> On Wed, Feb 06, 2019 at 12:51:06PM -0800, Moritz Fischer wrote: >>> Move the DT based link GPIO parsing to of_mdio and let the places >>> that re

[PATCH] xhci: Drop superfluous initialization in xhci_queue_ctrl_tx()

2019-02-06 Thread Andrey Smirnov
Simplify filed's initialization by directly assigning its final value instead of initializing the variable to sero and then bitwise or-ing it. Signed-off-by: Andrey Smirnov Cc: Mathias Nyman Cc: Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org Cc: linux-ker...@vger.kernel.org --- drivers/usb/h

[PATCH] xhci: Convert xhci_handshake() to use readl_poll_timeout()

2019-02-06 Thread Andrey Smirnov
Xhci_handshake() implements the algorithm already captured by readl_poll_timeout(). Convert the former to use the latter to avoid repetition. Signed-off-by: Andrey Smirnov Cc: Mathias Nyman Cc: Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org Cc: linux-ker...@vger.kernel.org --- drivers/usb/ho

[PATCH] xhci: Use ffs() to find page size in xhci_mem_init()

2019-02-06 Thread Andrey Smirnov
Get page size order using ffs() instead of open coding it with a loop. Signed-off-by: Andrey Smirnov Cc: Mathias Nyman Cc: Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org Cc: linux-ker...@vger.kernel.org --- drivers/usb/host/xhci-mem.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-