On Mon, Jan 21, 2019 at 10:25:10AM +, Yinbo Zhu wrote:
> From: yinbo.zhu
This line is still wrong :(
On Mon, Jan 21, 2019 at 10:25:00AM +, Yinbo Zhu wrote:
> From: Nikhil Badola
>
> Set USB_EN bit to select ULPI phy for USB controller version 2.5
>
> Signed-off-by: Nikhil Badola
> Signed-off-by: Yinbo Zhu
> ---
> Change in v2:
> replace Yinbo.Zhu with Yinbo Zhu
>
> driver
Hi Alexey,
On 2019-01-21 22:23, Alexey Khoroshilov wrote:
> If clk_prepare_enable() fails in dwc3_exynos_probe() or in
> dwc3_exynos_resume(), exynos->clks[0] is left undisabled
> because of usage preincrement in while condition.
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
Remove debugfs if tcpm register port fails.
Signed-off-by: Li Jun
---
drivers/usb/typec/tcpm/tcpm.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
index 4f1f421..4cdc53d 100644
--- a/drivers/usb/typec/tcpm
Hi Rob,
On 22/01/2019 at 02:07, Rob Herring wrote:
> On Wed, Jan 16, 2019 at 10:57:38AM +0100, Nicolas Ferre wrote:
>> Update the Reset Controller's binding to add new SoC compatibility string.
>>
>> Signed-off-by: Nicolas Ferre
>> ---
>> Documentation/devicetree/bindings/arm/atmel-sysregs.txt
Hi Rob,
On 22/01/2019 at 02:10, Rob Herring wrote:
> On Wed, Jan 16, 2019 at 10:57:40AM +0100, Nicolas Ferre wrote:
>> This removes a line left while adding the correct compatibility string for
>> sama5d3 10/100 interface. Now use the "atmel,sama5d3-macb" string.
>>
>> Signed-off-by: Nicolas Ferre
Hi Bin,
Sorry to bother you again, I encounter a problem about the extcon
property.
I don't find a common driver describing the usb-connector. Is
there any driver that I can refer to, specially the way to switch MUSB
controller between host and device mode?
If it needs to implement by myself, is
Fix link errors when CONFIG_FSL_USB2_OTG is enabled and USB_OTG_FSM is
set to module then the following link error occurs.
aarch64-linux-gnu-ld: drivers/usb/phy/phy-fsl-usb.o: in function
`fsl_otg_ioctl':
drivers/usb/phy/phy-fsl-usb.c:1083: undefined reference to `otg_statemachine'
aarch64-linux-
Set the right power down clock scale if the property
"snps,power-down-scale" is specified.
Signed-off-by: Li Jun
---
drivers/usb/dwc3/core.c | 15 +++
drivers/usb/dwc3/core.h | 1 +
2 files changed, 16 insertions(+)
diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
ind
The USB3 suspend_clk input replaces pipe3_rx_pclk as a clock
source to a small part of the USB3 core that operates when the
SS PHY is in its lowest power(P3) state, and therefore does
not provide a clock. The power down scale specifies how many
suspend_clk periods fit into a 16 KHz clock period, de
On Tue, Jan 22, 2019 at 01:40:02PM +0800, Jun Li wrote:
> Hi Heikki,
> Heikki Krogerus 于2018年10月24日周三 下午11:06写道:
> >
> > When the connections are defined in firmware, struct
> > device_connection will have the fwnode member pointing to
> > the device node (struct fwnode_handle) of the requested
>
On Tue, Jan 22, 2019 at 09:00:24AM +, Jun Li wrote:
> Remove debugfs if tcpm register port fails.
>
> Signed-off-by: Li Jun
Reviewed-by: Heikki Krogerus
> ---
> drivers/usb/typec/tcpm/tcpm.c | 8 +---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/type
On Tue, Jan 22, 2019 at 3:00 AM wrote:
>
> Hi Rob,
>
> On 22/01/2019 at 02:07, Rob Herring wrote:
> > On Wed, Jan 16, 2019 at 10:57:38AM +0100, Nicolas Ferre wrote:
> >> Update the Reset Controller's binding to add new SoC compatibility string.
> >>
> >> Signed-off-by: Nicolas Ferre
> >> ---
> >>
On Tue, Jan 22, 2019 at 3:09 AM wrote:
>
> Hi Rob,
>
> On 22/01/2019 at 02:10, Rob Herring wrote:
> > On Wed, Jan 16, 2019 at 10:57:40AM +0100, Nicolas Ferre wrote:
> >> This removes a line left while adding the correct compatibility string for
> >> sama5d3 10/100 interface. Now use the "atmel,sam
On Mon, Jan 21, 2019 at 8:38 PM Ran Wang wrote:
>
> Hi Rob,
>
> On January 22, 2019 09:03, Rob Herring wrote:
> >
> > On Wed, Jan 16, 2019 at 06:48:06AM +, Ran Wang wrote:
> > > When DWC3 is set to host mode by programming register DWC3_GCTL,
> > VUBS
> >
> > s/VUBS/VBUS/
>
> Yes, will fix it
s last enabled at (11251): []
_raw_spin_unlock_irqrestore+0x6c/0x74
hardirqs last disabled at (11252): []
_raw_spin_lock_irqsave+0x1c/0x5c
softirqs last enabled at (9744): [] __do_softirq+0x3a4/0x66c
softirqs last disabled at (9737): [] irq_exit+0x140/0x168
Preemption disabled at:
[<000
On Mon, Jan 21, 2019 at 03:35:34PM +0100, Greg KH wrote:
> On Mon, Jan 21, 2019 at 11:30:55PM +0900, Suwan Kim wrote:
> > usb_create_ep_devs() returns error code if an error occurs. But
> > usb_new_device() and create_intf_ep_devs() which use usb_create_ep_devs()
> > to create endpoint devices igno
Hi linux-usb list,
I have had issues with USB power management since upgrading from
4.19.4 to 4.19.8. The issue still persists even with 4.20.3. I had
reported the issue on the linux-stable list and Greg K-H asked me to
report the issue here. Here is the original report which still holds
for 4.20.
From: Colin Ian King
There are a bunch of various indentation issues, clean these up.
Signed-off-by: Colin Ian King
---
drivers/usb/gadget/function/f_uac1.c | 8 ++---
drivers/usb/gadget/legacy/inode.c| 40
drivers/usb/gadget/udc/aspeed-vhub/hub.c | 2 +-
Hi Min,
On Tue, Jan 22, 2019 at 05:36:13PM +0800, Min Guo wrote:
> Hi Bin,
>
> Sorry to bother you again, I encounter a problem about the extcon
> property.
>
> I don't find a common driver describing the usb-connector. Is
> there any driver that I can refer to, specially the way to switch MUSB
On Mon, Jan 21, 2019 at 09:20:52PM +, Måns Rullgård wrote:
> Bin Liu writes:
>
> > On Fri, Jan 18, 2019 at 08:15:02PM +, Måns Rullgård wrote:
> >> Bin Liu writes:
> >>
> >> > On Mon, Dec 17, 2018 at 09:36:17PM +, Måns Rullgård wrote:
> >> >> Bin Liu writes:
> >> >>
> >> >> > On Mo
After the previous patch we see, that whole files are ifdeffed depending
on CONFIG options. So do not build the files at all if the CONFIG is not
enabled. (I.e. move the check from .c to Makefile.)
Signed-off-by: Jiri Slaby
---
drivers/usb/misc/sisusbvga/Makefile | 3 ++-
drivers/usb/misc/s
Remove macros which are only wrappers around standard operations. When
we expand them into code, we see that sisusbcon_memsetw can simply use
memset16 and sisusbcon_putcs can just call memcpy. So make the code
compact.
Signed-off-by: Jiri Slaby
---
drivers/usb/misc/sisusbvga/sisusb_con.c | 48 ++
Convert SISUSB_VADDR and SISUSB_HADDR to inline functions. Now, there
are no more hidden accesses to local variables (vc_data and
sisusb_usb_data).
sisusb_haddr returns unsigned long from now on, not u16 *, as ulong is
what every caller expects -- we can remove some casts.
Call sites were aligned
There are two macros defined:
1) ifdef CONFIG_COMPAT => define SISUSB_NEW_CONFIG_COMPAT
2) ifdef CONFIG_USB_SISUSBVGA_CON => define INCL_SISUSB_CON
Remove the latter and make use only of the former. This removes one
layer of obfuscation.
Signed-off-by: Jiri Slaby
---
drivers/usb/misc/sisusbvga/
On Tue, Jan 22, 2019 at 04:11:59PM +0100, Jiri Slaby wrote:
> Convert SISUSB_VADDR and SISUSB_HADDR to inline functions. Now, there
> are no more hidden accesses to local variables (vc_data and
> sisusb_usb_data).
>
> sisusb_haddr returns unsigned long from now on, not u16 *, as ulong is
> what ev
On 22. 01. 19, 16:23, Greg KH wrote:
> On Tue, Jan 22, 2019 at 04:11:59PM +0100, Jiri Slaby wrote:
>> Convert SISUSB_VADDR and SISUSB_HADDR to inline functions. Now, there
>> are no more hidden accesses to local variables (vc_data and
>> sisusb_usb_data).
>>
>> sisusb_haddr returns unsigned long fr
On Tue, Jan 22, 2019 at 09:00:24AM +, Jun Li wrote:
> Remove debugfs if tcpm register port fails.
>
> Signed-off-by: Li Jun
Reviewed-by: Guenter Roeck
> ---
> drivers/usb/typec/tcpm/tcpm.c | 8 +---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/typec/
On Tue, 2019-01-22 at 16:12 +0100, Jiri Slaby wrote:
> Remove macros which are only wrappers around standard operations. When
> we expand them into code, we see that sisusbcon_memsetw can simply use
> memset16 and sisusbcon_putcs can just call memcpy. So make the code
> compact.
[]
> diff --git a/d
On Mon, Jan 21, 2019 at 9:49 AM Gregory CLEMENT
wrote:
>
> Hi Rob,
>
> On lun., janv. 21 2019, Rob Herring wrote:
>
> > On Mon, 21 Jan 2019 12:23:32 +0100, Miquel Raynal wrote:
> >> Add bindings for Marvell Armada 3700 USB2 UTMI+ PHY.
> >>
> >> Signed-off-by: Miquel Raynal
> >> ---
> >> .../bi
Hello,
Rob Herring wrote on Tue, 22 Jan 2019 10:08:41 -0600:
> On Mon, Jan 21, 2019 at 9:49 AM Gregory CLEMENT
> wrote:
> >
> > Hi Rob,
> >
> > On lun., janv. 21 2019, Rob Herring wrote:
> >
> > > On Mon, 21 Jan 2019 12:23:32 +0100, Miquel Raynal wrote:
> > >> Add bindings for Marvell Arm
Bin Liu writes:
> On Mon, Jan 21, 2019 at 09:20:52PM +, Måns Rullgård wrote:
>> Bin Liu writes:
>>
>> > On Fri, Jan 18, 2019 at 08:15:02PM +, Måns Rullgård wrote:
>> >> Bin Liu writes:
>> >>
>> >> > On Mon, Dec 17, 2018 at 09:36:17PM +, Måns Rullgård wrote:
>> >> >> Bin Liu write
Hello,
On Mon, 21 Jan 2019 12:23:32 +0100, Miquel Raynal wrote:
> +- compatible: Should be one of:
> + * "marvell,a3700-utmi-host-phy" for the PHY connected to
> + the USB2 host-only controller.
> + * "marvell,a3700-utmi-otg-phy" for the PHY connected to
> +
Hi Minas,
I have one more issue on the dwc2 gadget driver that I can't figure out the
root cause. Hopefully, you have an idea on this problem.
Our system is using an Altera Cyclone V SoC FPGA on our board with linux kernel
4.14.44 and enabling the USB gadget for HID (keyboard and mouse) and mas
Hi Thomas,
Thomas Petazzoni wrote on Tue, 22 Jan
2019 18:38:33 +0100:
> Hello,
>
> On Mon, 21 Jan 2019 12:23:32 +0100, Miquel Raynal wrote:
>
> > +- compatible: Should be one of:
> > + * "marvell,a3700-utmi-host-phy" for the PHY connected to
> > + the USB2 host-only controlle
On Tue, 22 Jan 2019, Eric Blau wrote:
> Hi linux-usb list,
>
> I have had issues with USB power management since upgrading from
> 4.19.4 to 4.19.8. The issue still persists even with 4.20.3. I had
> reported the issue on the linux-stable list and Greg K-H asked me to
> report the issue here. Here
On Tue, Jan 22, 2019 at 05:19:39PM +, Måns Rullgård wrote:
> Bin Liu writes:
>
> > On Mon, Jan 21, 2019 at 09:20:52PM +, Måns Rullgård wrote:
> >> Bin Liu writes:
> >>
> >> > On Fri, Jan 18, 2019 at 08:15:02PM +, Måns Rullgård wrote:
> >> >> Bin Liu writes:
> >> >>
> >> >> > On Mo
Hi Johan,
On Tue, Jan 22, 2019 at 02:16:30PM -0600, Bin Liu wrote:
> On Tue, Jan 22, 2019 at 05:19:39PM +, Måns Rullgård wrote:
> > Bin Liu writes:
> >
> > > On Mon, Jan 21, 2019 at 09:20:52PM +, Måns Rullgård wrote:
> > >> Bin Liu writes:
> > >>
> > >> > On Fri, Jan 18, 2019 at 08:15:
On Mon, Jan 21, 2019 at 02:33:08PM -0700, Jeffrey Hugo wrote:
> Add a MSM8998 specific DT compatible so that we can properly bind to the
> device and enable the USB controller.
>
> Signed-off-by: Jeffrey Hugo
> Reviewed-by: Bjorn Andersson
> ---
> drivers/usb/dwc3/dwc3-qcom.c | 1 +
> 1 file ch
(!x & y) strikes again.
Fix bitwise and boolean operations by enclosing the expression:
intcsr & (1 << NET2272_PCI_IRQ)
in parentheses, before applying the boolean operator '!'.
Notice that this code has been there since 2011. So, it would
be helpful if someone can double-check this.
T
Hi Marcel,
On Sat, Jan 19, 2019 at 11:51 AM Marcel Holtmann wrote:
>
> Hi Rajat,
>
> > In preparation for handling embedded USB devices let's split
> > usb_acpi_find_companion() into usb_acpi_find_companion_for_device() and
> > usb_acpi_find_companion_for_port().
> >
> > Signed-off-by: Dmitry Tor
On Sat, Jan 19, 2019 at 11:51 AM Marcel Holtmann wrote:
>
> Hi Rajat,
>
> > USB devices permanently connected to USB ports may be described in ACPI
> > tables and share ACPI devices with ports they are connected to. See [1]
> > for details.
> >
> > This will allow us to describe sideband resources
On Sat, Jan 19, 2019 at 11:51 AM Marcel Holtmann wrote:
>
> Hi Rajat,
>
> > The BTUSB_INTEL and BTUSB_INTEL_NEW have common functions & quirks are
> > assigned to hdev structure. Lets collect them together instead of
> > repeating them in different code branches.
> >
> > Signed-off-by: Rajat Jain
On Sat, Jan 19, 2019 at 11:51 AM Marcel Holtmann wrote:
>
> Hi Rajat,
>
> > Add a quirk and a hook to allow the HCI core to reset the BT chip
> > if needed (after a number of timed out commands). Use that new hook to
> > initiate BT chip reset if the controller fails to respond to certain
> > numb
On Sat, Jan 19, 2019 at 11:51 AM Marcel Holtmann wrote:
>
> Hi Rajat,
>
> > If the platform provides it, use the reset gpio to reset the BT
> > chip (requested by the HCI core if needed). This has been found helpful
> > on some of Intel bluetooth controllers where the firmware gets stuck and
> > t
On Tue, Jan 22, 2019 at 2:29 PM Rajat Jain wrote:
>
> Hi Marcel,
>
> On Sat, Jan 19, 2019 at 11:51 AM Marcel Holtmann wrote:
> >
> > Hi Rajat,
> >
> > > In preparation for handling embedded USB devices let's split
> > > usb_acpi_find_companion() into usb_acpi_find_companion_for_device() and
> > >
On 1/19/19 1:17 AM, Greg KH wrote:
On Fri, Jan 18, 2019 at 02:29:30PM -0700, Shuah Khan wrote:
From: Shuah Khan
Fix vep_free_request() to return when usb_ep and usb_request are null
instead of calling WARN_ON.
Signed-off-by: Shuah Khan
---
drivers/usb/usbip/vudc_dev.c | 2 +-
1 file chang
Those 2 headers files are not required now.
Signed-off-by: Li Jun
---
drivers/usb/chipidea/ci_hdrc_imx.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c
b/drivers/usb/chipidea/ci_hdrc_imx.c
index 9b45aa4..076d8c0 100644
--- a/drivers/usb/chipidea/ci_hdrc_
On Tue, Jan 22, 2019 at 02:42:26PM -0800, Dmitry Torokhov wrote:
> On Tue, Jan 22, 2019 at 2:29 PM Rajat Jain wrote:
> >
> > Hi Marcel,
> >
> > On Sat, Jan 19, 2019 at 11:51 AM Marcel Holtmann
> > wrote:
> > >
> > > Hi Rajat,
> > >
> > > > In preparation for handling embedded USB devices let's s
Hi Maynard,
On 1/22/2019 11:00 PM, Maynard CABIENTE wrote:
> Hi Minas,
>
> I have one more issue on the dwc2 gadget driver that I can't figure out the
> root cause. Hopefully, you have an idea on this problem.
>
> Our system is using an Altera Cyclone V SoC FPGA on our board with linux
> kerne
On Tue, Jan 22, 2019 at 02:52:44PM -0600, Bin Liu wrote:
> Hi Johan,
>
> On Tue, Jan 22, 2019 at 02:16:30PM -0600, Bin Liu wrote:
> > On Tue, Jan 22, 2019 at 05:19:39PM +, Måns Rullgård wrote:
> > > Bin Liu writes:
> > >
> > > > On Mon, Jan 21, 2019 at 09:20:52PM +, Måns Rullgård wrote:
Hi Minas,
On Wednesday, January 23, 2019 1:42 AM, Minas Harutyunyan wrote:
>
> Can you provide USB trace for above fragment.
>
Is it ok to have a 14MB attachment on this e-mail list? My USB trace was taken
using the Ellisys USB Analyzer. It requires that you download their Windows
software from
From: Yinbo Zhu
This patch is to add member has_fsl_erratum_a006918 in platform data
Signed-off-by: Yinbo Zhu
---
include/linux/fsl_devices.h |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/include/linux/fsl_devices.h b/include/linux/fsl_devices.h
index 5da56a6..4c613d
From: Nikhil Badola
Remove USB errata checking code from driver. Applicability of erratum
is retrieved by reading corresponding property in device tree.
This property is written during device tree fixup.
Signed-off-by: Ramneek Mehresh
Signed-off-by: Nikhil Badola
Signed-off-by: Yinbo Zhu
---
From: Nikhil Badola
Set USB_EN bit to select ULPI phy for USB controller version 2.5
Signed-off-by: Nikhil Badola
Signed-off-by: Yinbo Zhu
---
Change in v3:
Code base already has patch[5/6], so remove it.
drivers/usb/host/ehci-fsl.c |6 ++
1 files changed, 6 inserti
From: Suresh Gupta
PHY_CLK_VALID bit for UTMI PHY in USBDR does not set even
if PHY is providing valid clock. Workaround for this
involves resetting of PHY and check PHY_CLK_VALID bit
multiple times. If PHY_CLK_VALID bit is still not set even
after 5 retries, it would be safe to deaclare that PHY
From: Ramneek Mehresh
USB erratum-A006918 workaround tries to start internal PHY inside
uboot (when PLL fails to lock). However, if the workaround also
fails, then USB initialization is also stopped inside Linux.
Erratum-A006918 workaround failure creates "fsl,erratum_a006918"
node in device-tree
On Wed, Jan 23, 2019 at 06:52:00AM +, Maynard CABIENTE wrote:
> This e-mail, and any document attached hereby, may contain confidential
> and/or privileged information. If you are not the intended recipient (or have
> received this e-mail in error) please notify the sender immediately and
>
58 matches
Mail list logo