Re: [PATCH] usbip: Fix vep_free_request() null pointer checks on input args

On Fri, Jan 18, 2019 at 02:29:30PM -0700, Shuah Khan wrote: > From: Shuah Khan > > Fix vep_free_request() to return when usb_ep and usb_request are null > instead of calling WARN_ON. > > Signed-off-by: Shuah Khan > --- > drivers/usb/usbip/vudc_dev.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH] usbip: Fix vhci_urb_enqueue() URB null transfer buffer error path

On Fri, Jan 18, 2019 at 02:29:31PM -0700, Shuah Khan wrote: > From: Shuah Khan > > Fix vhci_urb_enqueue() to print error and return error instead of > failing with WARN_ON. > > Signed-off-by: Shuah Khan > --- > drivers/usb/usbip/vhci_hcd.c | 6 -- > 1 file changed, 4 insertions(+), 2 delet

Re: [PATCH] usbip: Fix vhci_urb_enqueue() URB null transfer buffer error path

Hello! On 01/19/2019 12:29 AM, Shuah Khan wrote: > From: Shuah Khan > > Fix vhci_urb_enqueue() to print error and return error instead of > failing with WARN_ON. It's BUG_ON(). > Signed-off-by: Shuah Khan > --- > drivers/usb/usbip/vhci_hcd.c | 6 -- > 1 file changed, 4 insertions(+),

Re: [PATCH net-next] net: usb: rtl8150: remove set but not used variable 'rx_stat'

From: YueHaibing Date: Fri, 18 Jan 2019 02:06:49 + > From: Yue Haibing > > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/usb/rtl8150.c: In function 'read_bulk_callback': > drivers/net/usb/rtl8150.c:391:6: warning: > variable 'rx_stat' set but not used [-Wunused-but-set-va

Re: [PATCH v4 5/5] Bluetooth: btusb: Use the hw_reset method to allow resetting the BT chip

Hi Rajat, > If the platform provides it, use the reset gpio to reset the BT > chip (requested by the HCI core if needed). This has been found helpful > on some of Intel bluetooth controllers where the firmware gets stuck and > the only way out is a hard reset pin provided by the platform. > > Sig

Re: [PATCH v4 3/5] Bluetooth: Reset Bluetooth chip after multiple command timeouts

Hi Rajat, > Add a quirk and a hook to allow the HCI core to reset the BT chip > if needed (after a number of timed out commands). Use that new hook to > initiate BT chip reset if the controller fails to respond to certain > number of commands (currently 5) including the HCI reset commands. > This

Re: [PATCH v4 2/5] usb: assign ACPI companions for embedded USB devices

Hi Rajat, > USB devices permanently connected to USB ports may be described in ACPI > tables and share ACPI devices with ports they are connected to. See [1] > for details. > > This will allow us to describe sideband resources for devices, such as, > for example, hard reset line for BT USB contro

Re: [PATCH v4 1/5] usb: split code locating ACPI companion into port and device

Hi Rajat, > In preparation for handling embedded USB devices let's split > usb_acpi_find_companion() into usb_acpi_find_companion_for_device() and > usb_acpi_find_companion_for_port(). > > Signed-off-by: Dmitry Torokhov > Signed-off-by: Rajat Jain > Acked-by: Greg Kroah-Hartman > Tested-by: Su

Re: [PATCH v4 4/5] Bluetooth: btusb: Collect the common Intel assignments together

Hi Rajat, > The BTUSB_INTEL and BTUSB_INTEL_NEW have common functions & quirks are > assigned to hdev structure. Lets collect them together instead of > repeating them in different code branches. > > Signed-off-by: Rajat Jain > --- > v4: same as v1 > v3: same as v1 > v2: same as v1 > > drivers/