RE: [PATCH 2/3] usb: ehci: fsl: Update register accessing for arm/arm64 platforms

2019-01-17 Thread Ran Wang
Hi Greg, On 08, 2019 23:45, Greg Kroah-Hartman wrote: > > On Tue, Jan 08, 2019 at 06:04:26AM +, Ran Wang wrote: > > arm/arm64's io.h doesn't define clrbits32() and clrsetbits_be32(), > > which causing compile failure on some Layerscape Platforms (such as > > LS1021A and LS2012A which also int

[PATCH] USB: remove README file

2019-01-17 Thread Greg Kroah-Hartman
This file is really really old, and doesn't make any sense to keep around anymore, so just drop it. Signed-off-by: Greg Kroah-Hartman --- drivers/usb/README | 54 -- 1 file changed, 54 deletions(-) delete mode 100644 drivers/usb/README diff --git a/d

[PATCH] USB: add missing SPDX lines to Kconfig and Makefiles

2019-01-17 Thread Greg Kroah-Hartman
There are a few remaining drivers/usb/ files that do not have SPDX identifiers in them, all of these are either Kconfig or Makefiles. Add the correct GPL-2.0 identifier to them to make scanning tools happy. Signed-off-by: Greg Kroah-Hartman --- drivers/usb/Kconfig | 1 + drivers

[PATCH] USB: host: whci: rename Kbuild file

2019-01-17 Thread Greg Kroah-Hartman
We have been using Makefile for well over a decade now, use that name instead of Kbuild. Also, while moving the file, add the proper SPDX identifier at the top of it. Signed-off-by: Greg Kroah-Hartman --- drivers/usb/host/whci/{Kbuild => Makefile} | 2 ++ 1 file changed, 2 insertions(+) rename

[PATCH] USB: serial: keyspan_usa: add proper SPDX lines for .h files

2019-01-17 Thread Greg Kroah-Hartman
The keyspan_usa??msg.h files are under a BSD-3 style license, so properly label them as such with a SPDX line at the top of the file. Cc: Johan Hovold Signed-off-by: Greg Kroah-Hartman --- drivers/usb/serial/keyspan_usa26msg.h | 1 + drivers/usb/serial/keyspan_usa28msg.h | 1 + drivers/usb/seri

[PATCH] USB: usbip: delete README file

2019-01-17 Thread Greg Kroah-Hartman
The README file ni the drivers/usb/usbip/ directory is not needed anymore, so just delete it. Cc: Valentina Manea Cc: Shuah Khan Signed-off-by: Greg Kroah-Hartman --- drivers/usb/usbip/README | 7 --- 1 file changed, 7 deletions(-) delete mode 100644 drivers/usb/usbip/README diff --git a

[PATCH v2 2/3] usb: kconfig: remove dependency FSL_SOC for ehci fsl driver

2019-01-17 Thread Ran Wang
CONFIG_USB_EHCI_FSL is not dependent on FSL_SOC, it can be built on non-PPC platforms. Signed-off-by: Rajesh Bhagat Signed-off-by: Ran Wang --- Changes in v2: - remove 'depends on USB_EHCI_HCD' - Move this patch to be second one to avoid breaking the build on ARM. drivers/usb/host/Kconfig

[PATCH v2 3/3] drivers: usb :fsl: Remove USB Errata checking code

2019-01-17 Thread Ran Wang
Remove USB errata checking code from driver. Applicability of erratum is retrieved by reading corresponding property in device tree. This property is written during device tree fixup. Besides, replace spaces with tabs to make code aligned. Signed-off-by: Ramneek Mehresh Signed-off-by: Nikhil Bad

[PATCH v2 1/3] usb: ehci: fsl: Update register accessing for arm/arm64 platforms

2019-01-17 Thread Ran Wang
arm/arm64's io.h doesn't define clrbits32() and clrsetbits_be32(), which causing compile failure on some Layerscape Platforms (such as LS1021A and LS2012A which also integrates FSL EHCI controller). So use ioread32be()/iowrite32be() instead to make it workable on both powerpc and arm. Signed-off-b

[PATCH 0/1] usb: chipidea: fix for usb-linus

2019-01-17 Thread Peter Chen
Peter Chen (1): usb: chipidea: fix static checker warning for NULL pointer drivers/usb/chipidea/ci_hdrc_imx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.14.1

[PATCH 1/1] usb: chipidea: fix static checker warning for NULL pointer

2019-01-17 Thread Peter Chen
During the static checker, "data->usbmisc_data" may be NULL. Fix it by adding this pointer judgement before using. Reported-by: Dan Carpenter Signed-off-by: Peter Chen --- drivers/usb/chipidea/ci_hdrc_imx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/chipid

Re: [PATCH 21/21] memblock: drop memblock_alloc_*_nopanic() variants

2019-01-17 Thread Petr Mladek
On Wed 2019-01-16 15:44:21, Mike Rapoport wrote: > As all the memblock allocation functions return NULL in case of error > rather than panic(), the duplicates with _nopanic suffix can be removed. [...] > diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c > index c4f0a41..ae65221 100644

Re: [PATCH] usb: renesas_usbhs: replace udelay() with usleep_range()

2019-01-17 Thread Simon Horman
On Thu, Jan 17, 2019 at 04:24:15PM +0900, Yoshihiro Shimoda wrote: > According to Documentation/timers/timers-howto.txt, a driver should > use usleep_range() instead of udelay() on NON-ATOMIC CONTEXT if > "SLEEPING FOR ~USECS OR SMALL MSECS ( 10us - 20ms)". > > Since the .hardware_init() and .powe

Re: [PATCH v2 3/6] phy: qcom-qusb2: Add QUSB2 PHY support for msm8998

2019-01-17 Thread Kishon Vijay Abraham I
Hi, On 16/01/19 8:58 PM, Jeffrey Hugo wrote: > On 1/16/2019 1:58 AM, Kishon Vijay Abraham I wrote: >> Hi, >> >> On 16/01/19 2:20 PM, Kishon Vijay Abraham I wrote: >>> >>> >>> On 15/01/19 11:41 PM, Bjorn Andersson wrote: On Mon 14 Jan 08:36 PST 2019, Jeffrey Hugo wrote: > MSM8998 cont

Re: [PATCH 1/1] usb: chipidea: fix static checker warning for NULL pointer

2019-01-17 Thread gre...@linuxfoundation.org
On Thu, Jan 17, 2019 at 09:24:20AM +, Peter Chen wrote: > During the static checker, "data->usbmisc_data" may be NULL. I can not quite parse this sentance. Do you mean that a static checker found this issue? > Fix it by adding this pointer judgement before using. > > Reported-by: Dan Carpen

Re: [PATCH v3 1/4] dt-bindings: usb: musb: Add support for MediaTek musb controller

2019-01-17 Thread Sergei Shtylyov
Hello! On 01/17/2019 10:15 AM, min@mediatek.com wrote: > From: Min Guo > > This adds support for MediaTek musb controller in > host, peripheral and otg mode. > > Signed-off-by: Min Guo > --- > .../devicetree/bindings/usb/mediatek,musb.txt | 43 > ++ > 1 file cha

Re: [PATCH V3] usb:xhci: Fix for Enabling USB ROLE SWITCH QUIRK on INTEL_SUNRISEPOINT_LP_XHCI

2019-01-17 Thread Mathias Nyman
On 08.01.2019 22:43, m.bal...@intel.com wrote: From: Balaji Manoharan This fix enables USB role feature on intel commercial nuc platform which is based on Kabylake chipset. Signed-off-by: Balaji Manoharan --- Thanks, Adding to queue -Mathias

Re: [PATCH v3 1/4] dt-bindings: usb: musb: Add support for MediaTek musb controller

2019-01-17 Thread Min Guo
Hello! On Thu, 2019-01-17 at 14:06 +0300, Sergei Shtylyov wrote: > Hello! > > On 01/17/2019 10:15 AM, min@mediatek.com wrote: > > > From: Min Guo > > > > This adds support for MediaTek musb controller in > > host, peripheral and otg mode. > > > > Signed-off-by: Min Guo > > --- > > .../d

Re: [PATCH] USB: usbip: delete README file

2019-01-17 Thread shuah
On 1/17/19 1:23 AM, Greg Kroah-Hartman wrote: The README file ni the drivers/usb/usbip/ directory is not needed anymore, so just delete it. Cc: Valentina Manea Cc: Shuah Khan Signed-off-by: Greg Kroah-Hartman --- drivers/usb/usbip/README | 7 --- 1 file changed, 7 deletions(-) delete

Re: [PATCH v3 4/4] usb: musb: Add support for MediaTek musb controller

2019-01-17 Thread Tony Lindgren
Hi, * min@mediatek.com [190117 07:16]: > There are some quirk of MediaTek musb controller, such as: > -W1C interrupt status registers > -Private data toggle registers > -No dedicated DMA interrupt line Can you please separate the musb generic changes listed above into separate individual

Re: [PATCH v3 0/4] Add MediaTek MUSB Controller Driver

2019-01-17 Thread Bin Liu
On Thu, Jan 17, 2019 at 03:15:44PM +0800, min@mediatek.com wrote: > From: Min Guo > > These patches introduce the MediaTek MUSB controller driver. > > The driver can be configured as Dual-Role Device (DRD), > Peripheral Only and Host Only modes. This has beed tested on > MT2701 with a variet

Re: [PATCH v2 1/3] usb: ehci: fsl: Update register accessing for arm/arm64 platforms

2019-01-17 Thread Alan Stern
On Thu, 17 Jan 2019, Ran Wang wrote: > arm/arm64's io.h doesn't define clrbits32() and clrsetbits_be32(), which > causing compile failure on some Layerscape Platforms (such as LS1021A and > LS2012A which also integrates FSL EHCI controller). So use > ioread32be()/iowrite32be() instead to make it w

Re: [PATCH] USB:Serial:pl2303:Add new PID to support PL2303TB(TYPE_HX)

2019-01-17 Thread Johan Hovold
On Thu, Jan 17, 2019 at 02:18:45AM +, Yeh.Charles [葉榮鑫] wrote: > Hi Johan, > > Please add a space after each colon in the commit summary (subject) and > > no need to capitalise "serial". > > Charles_Ans: OK... I'll fix this one up, but please keep it in mind for future submissions. > > Is

Re: usb: gadget: ffs: Fix BUG when userland exits with submitted AIO transfers

2019-01-17 Thread Evan Green
On Wed, Jan 16, 2019 at 7:37 PM He, Bo wrote: > > Hi, Green: > if you check the latest kernel, you can see the below 3 patches > introduce the cancelled_list feature can fix the issue: > > commit fec9095bdef4e7c988adb603d0d4f92ee735d4a1 > Author: Felipe Balbi > Date: Wed Aug 1 13:56:50

Re: [PATCH] usb: chipidea: Grab the (legacy) USB PHY by phandle first

2019-01-17 Thread Paul Kocialkowski
Hi, On Thu, 2019-01-17 at 06:44 +, Peter Chen wrote: > > > On Wed, 2019-01-16 at 14:44 +0100, Thomas Petazzoni wrote: > > > Well prior to your code, there was already a possibility for both > > > ci->phy and ci->usb_phy to be valid. I don't think it's really useful > > > to avoid the fallbac

Re: [PATCH] USB:Serial:pl2303:Add new Pull-UP Mode to support PL2303HXD(TYPE_HX)

2019-01-17 Thread Johan Hovold
On Thu, Jan 17, 2019 at 06:19:56AM +, Yeh.Charles [葉榮鑫] wrote: > Hi Johan, > Please refer to > https://electronics.stackexchange.com/questions/28091/push-pull-open-drain-pull-up-pull-down Thanks, I know that bit. I still need a proper commit message describing why the change is needed. You

Re: [PATCH v2 3/6] phy: qcom-qusb2: Add QUSB2 PHY support for msm8998

2019-01-17 Thread Jeffrey Hugo
On 1/17/2019 3:52 AM, Kishon Vijay Abraham I wrote: Hi, On 16/01/19 8:58 PM, Jeffrey Hugo wrote: On 1/16/2019 1:58 AM, Kishon Vijay Abraham I wrote: Hi, On 16/01/19 2:20 PM, Kishon Vijay Abraham I wrote: On 15/01/19 11:41 PM, Bjorn Andersson wrote: On Mon 14 Jan 08:36 PST 2019, Jeffrey Hu

Did You Get My Message This Time?

2019-01-17 Thread Friedrich Mayrhofer
-- This is the second time i am sending you this mail.I, Friedrich Mayrhofer Donate $ 1,000,000.00 to You, Email Me personally for more details. Regards. Friedrich Mayrhofer

Re: [PATCH v2 3/4] usb: musb: Kconfig: Drop dependency on MACH_JZ4740 for jz4740

2019-01-17 Thread Paul Cercueil
Hi, On Tue, Jan 15, 2019 at 1:26 PM, Bin Liu wrote: Hi Paul, On Thu, Jan 10, 2019 at 10:36:59AM -0300, Paul Cercueil wrote: Depending on MACH_INGENIC prevent us from creating a generic kernel that Again, did you mean MACH_JZ4740 instead? Dammit. I'm sorry. Will send a v3 right now. wor

[PATCH v3 4/4] usb: musb: Kconfig: Drop dependency on CONFIG_USB for jz4740

2019-01-17 Thread Paul Cercueil
The Kconfig entry previously depended on USB_OTG_BLACKLIST_HUB unconditionally, which is an option that is only available when CONFIG_USB is enabled. However, the USB IP in the JZ4740 SoC does not support host mode, only gadget mode, so it makes sense to allow it to build when CONFIG_USB is not set

[PATCH v3 2/4] usb: musb: jz4740: Add support for devicetree

2019-01-17 Thread Paul Cercueil
Add support for probing the driver from devicetree. Signed-off-by: Paul Cercueil --- v2: Add MODULE_DEVICE_TABLE and wrap inside CONFIG_OF v3: No change drivers/usb/musb/jz4740.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/usb/musb/jz4740.c b/drivers/usb/musb/jz474

[PATCH v3 3/4] usb: musb: Kconfig: Drop dependency on MACH_JZ4740 for jz4740

2019-01-17 Thread Paul Cercueil
Depending on MACH_JZ4740 prevent us from creating a generic kernel that works on more than one MIPS board. Instead, we just depend on MIPS being set. Signed-off-by: Paul Cercueil --- v2: Remove info about adding COMPILE_TEST in commit message, as it was there before v3: Change MACH_INGENIC

[PATCH v3 1/4] Documentation: dt: Add binding info for jz4740-musb driver

2019-01-17 Thread Paul Cercueil
This commit adds documentation for the device-tree bindings of the jz4740-musb driver, which provides support for the USB gadget mode of the JZ4740 and similar SoCs from Ingenic. Signed-off-by: Paul Cercueil Reviewed-by: Rob Herring --- v2: No change v3: No change .../bindings/usb/ingenic,jz

[PATCH 2/7] usb: typec: ucsi: add ccg command framework

2019-01-17 Thread Ajay Gupta
Used to send command to ccg controller Signed-off-by: Ajay Gupta --- drivers/usb/typec/ucsi/ucsi_ccg.c | 252 -- 1 file changed, 243 insertions(+), 9 deletions(-) diff --git a/drivers/usb/typec/ucsi/ucsi_ccg.c b/drivers/usb/typec/ucsi/ucsi_ccg.c index 4d35279ab853..

[PATCH 4/7] usb: typec: ucsi: add cmd used for fw flashing

2019-01-17 Thread Ajay Gupta
Adding support for commands which will be used for firmware flashing. Signed-off-by: Ajay Gupta --- drivers/usb/typec/ucsi/ucsi_ccg.c | 216 ++ 1 file changed, 216 insertions(+) diff --git a/drivers/usb/typec/ucsi/ucsi_ccg.c b/drivers/usb/typec/ucsi/ucsi_ccg.c index

[PATCH 3/7] usb: typec: ucsi: add port num info

2019-01-17 Thread Ajay Gupta
Read PD port number information and save. Signed-off-by: Ajay Gupta --- drivers/usb/typec/ucsi/ucsi_ccg.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/usb/typec/ucsi/ucsi_ccg.c b/drivers/usb/typec/ucsi/ucsi_ccg.c index dce9126b6a37..b30ca51120a3 100644 --- a/drivers/usb/typ

[PATCH 0/7] Add support for firmware update on Cypres CCGx

2019-01-17 Thread Ajay Gupta
Hi Heikki This patch set adds support for updating firmware on Cypress CCGx controller. I have tested them on NVIDIA GPU card. I will be posting firmware binary patch to linux-firmware.git repo soon. Please help review this set. Thanks Ajay Ajay Gupta (7): usb: typec: ucsi: add get_fw_info f

[PATCH 1/7] usb: typec: ucsi: add get_fw_info function

2019-01-17 Thread Ajay Gupta
Function is to get the details of ccg firmware and device version. Signed-off-by: Ajay Gupta --- drivers/usb/typec/ucsi/ucsi_ccg.c | 76 ++- 1 file changed, 74 insertions(+), 2 deletions(-) diff --git a/drivers/usb/typec/ucsi/ucsi_ccg.c b/drivers/usb/typec/ucsi/ucsi

[PATCH 5/7] usb: typec: ucsi: add fw update needed check

2019-01-17 Thread Ajay Gupta
This will be needed to check if latest fw is already flashed. Signed-off-by: Ajay Gupta --- drivers/usb/typec/ucsi/ucsi_ccg.c | 139 ++ 1 file changed, 139 insertions(+) diff --git a/drivers/usb/typec/ucsi/ucsi_ccg.c b/drivers/usb/typec/ucsi/ucsi_ccg.c index 5f34193

[PATCH 6/7] usb: typec: ucsi: add check for supported vendor

2019-01-17 Thread Ajay Gupta
Added check to see the currently flashed or new firmware being flashed is from a supported vendor. Signed-off-by: Ajay Gupta --- drivers/usb/typec/ucsi/ucsi_ccg.c | 28 1 file changed, 28 insertions(+) diff --git a/drivers/usb/typec/ucsi/ucsi_ccg.c b/drivers/usb/ty

[PATCH 7/7] usb: typec: ucsi: add firmware flashing support

2019-01-17 Thread Ajay Gupta
CCGx has two copies of the firmware in addition to the bootloader. If the device is running FW1, FW2 can be updated with the new version. Dual firmware mode allows the CCG device to stay in a PD contract and support USB PD and Type-C functionality while a firmware update is in progress. Signed-off

Re: [PATCH v3 0/4] Add MediaTek MUSB Controller Driver

2019-01-17 Thread Min Guo
Hi Bin, On Thu, 2019-01-17 at 09:00 -0600, Bin Liu wrote: > On Thu, Jan 17, 2019 at 03:15:44PM +0800, min@mediatek.com wrote: > > From: Min Guo > > > > These patches introduce the MediaTek MUSB controller driver. > > > > The driver can be configured as Dual-Role Device (DRD), > > Peripheral

RE: [PATCH 1/1] usb: chipidea: fix static checker warning for NULL pointer

2019-01-17 Thread Peter Chen
> > On Thu, Jan 17, 2019 at 09:24:20AM +, Peter Chen wrote: > > During the static checker, "data->usbmisc_data" may be NULL. > > I can not quite parse this sentance. Do you mean that a static checker found > this > issue? I think "yes", Dan Carpenter reported it. https://www.spinics.net

[PATCH net-next] net: usb: rtl8150: remove set but not used variable 'rx_stat'

2019-01-17 Thread YueHaibing
From: Yue Haibing Fixes gcc '-Wunused-but-set-variable' warning: drivers/net/usb/rtl8150.c: In function 'read_bulk_callback': drivers/net/usb/rtl8150.c:391:6: warning: variable 'rx_stat' set but not used [-Wunused-but-set-variable] Signed-off-by: Yue Haibing --- drivers/net/usb/rtl8150.c | 2

RE: [PATCH] usb: chipidea: Grab the (legacy) USB PHY by phandle first

2019-01-17 Thread Peter Chen
> On Thu, 2019-01-17 at 06:44 +, Peter Chen wrote: > > > > > On Wed, 2019-01-16 at 14:44 +0100, Thomas Petazzoni wrote: > > > > Well prior to your code, there was already a possibility for both > > > > ci->phy and ci->usb_phy to be valid. I don't think it's really > > > > ci->useful > > > > t

RE: [PATCH v2 1/3] usb: ehci: fsl: Update register accessing for arm/arm64 platforms

2019-01-17 Thread Ran Wang
Hi Alan, On January 18, 2019 00:08, Alan Stern wrote: > > On Thu, 17 Jan 2019, Ran Wang wrote: > > > arm/arm64's io.h doesn't define clrbits32() and clrsetbits_be32(), > > which causing compile failure on some Layerscape Platforms (such as > > LS1021A and LS2012A which also integrates FSL EHCI c

Re: [PATCH v3 4/4] usb: musb: Add support for MediaTek musb controller

2019-01-17 Thread Min Guo
On Thu, 2019-01-17 at 06:33 -0800, Tony Lindgren wrote: > Hi, > > * min@mediatek.com [190117 07:16]: > > There are some quirk of MediaTek musb controller, such as: > > -W1C interrupt status registers > > -Private data toggle registers > > -No dedicated DMA interrupt line > > Can you pleas

[GIT PULL] USB fixes for v5.0-rc2

2019-01-17 Thread Felipe Balbi
Hi Greg, here's my first pull request for this -rc cycle. Not much this time around, things are surprisingly calm. Let me know if you want anything to be changed. cheers The following changes since commit 1c7fc5cbc33980acd13d668f1c8f0313d6ae9fd8: Linux 5.0-rc2 (2019-01-14 10:41:12 +1200) a

Re: [PATCH 10/14] usb: dwc3: gadget: remove wait_end_transfer

2019-01-17 Thread Felipe Balbi
Hi, Thinh Nguyen writes: > @@ -1409,15 +1407,11 @@ static int dwc3_gadget_ep_dequeue(struct usb_ep *ep, > if (r == req) { > /* wait until it is processed */ > dwc3_stop_active_transfer(dep, true); > > I ran into a regression with th

Re: [PATCH 5/7] usb: typec: ucsi: add fw update needed check

2019-01-17 Thread Greg KH
On Thu, Jan 17, 2019 at 05:12:38PM -0800, Ajay Gupta wrote: > This will be needed to check if latest fw is already flashed. Very odd changelog text, please make this more detailed. And your email threading broke here, did your email client change? thanks, greg k-h

Re: [PATCH 2/7] usb: typec: ucsi: add ccg command framework

2019-01-17 Thread Greg KH
On Thu, Jan 17, 2019 at 05:09:04PM -0800, Ajay Gupta wrote: > Used to send command to ccg controller Writing changelog comments is hard, but please do more than just tiny snippets like this. Explain _why_ this change is needed in detail please. Same for all of these patches, you are adding new f

Re: [PATCH 1/7] usb: typec: ucsi: add get_fw_info function

2019-01-17 Thread Greg KH
On Thu, Jan 17, 2019 at 05:09:03PM -0800, Ajay Gupta wrote: > Function is to get the details of ccg firmware and device version. > > Signed-off-by: Ajay Gupta > --- > drivers/usb/typec/ucsi/ucsi_ccg.c | 76 ++- > 1 file changed, 74 insertions(+), 2 deletions(-) > > d

Re: [PATCH 5/7] usb: typec: ucsi: add fw update needed check

2019-01-17 Thread Greg KH
On Thu, Jan 17, 2019 at 05:12:38PM -0800, Ajay Gupta wrote: > This will be needed to check if latest fw is already flashed. > > Signed-off-by: Ajay Gupta > --- > drivers/usb/typec/ucsi/ucsi_ccg.c | 139 ++ > 1 file changed, 139 insertions(+) > > diff --git a/drivers/