Re: [PATCH 2/2] usb: dwc3: Add workaround for host mode VBUS glitch when boot

Hi, Ran Wang writes: > +static void dwc3_power_off_all_roothub_ports(struct dwc3 *dwc) > +{ > + int i, port_num; > + u32 reg, op_regs_base, offset; > + void __iomem*xhci_regs; > + > + /* xhci regs is not mapped yet, do it temperary here */ > + if (dwc->xhci_resour

Re: [PATCH v2 3/6] phy: qcom-qusb2: Add QUSB2 PHY support for msm8998

On 15/01/19 11:41 PM, Bjorn Andersson wrote: > On Mon 14 Jan 08:36 PST 2019, Jeffrey Hugo wrote: > >> MSM8998 contains one QUSB2 PHY which is very similar to the existing >> sdm845 support. >> > I don't seem to have the dt-binding patch in my inbox. Can you send them as well? Thanks Kishon >

Re: [PATCH v2 1/6] dt-bindings: phy-qcom: Add support for msm8998 usb

On 15/01/19 11:38 PM, Bjorn Andersson wrote: > On Mon 14 Jan 08:36 PST 2019, Jeffrey Hugo wrote: > >> USB on msm8998 utilizes the QUSB2 and QMP phys, similar to sdm845. >> >> Signed-off-by: Jeffrey Hugo >> --- >> Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt | 5 + >> Documenta

Re: [PATCH v2 3/6] phy: qcom-qusb2: Add QUSB2 PHY support for msm8998

Hi, On 16/01/19 2:20 PM, Kishon Vijay Abraham I wrote: > > > On 15/01/19 11:41 PM, Bjorn Andersson wrote: >> On Mon 14 Jan 08:36 PST 2019, Jeffrey Hugo wrote: >> >>> MSM8998 contains one QUSB2 PHY which is very similar to the existing >>> sdm845 support. >>> >> > I don't seem to have the dt-bind

Re: [PATCH v2 05/10] phy: add A3700 UTMI PHY driver

Hi, On 15/01/19 8:10 AM, Chunfeng Yun wrote: > Hi, > On Fri, 2019-01-11 at 14:31 +0100, Miquel Raynal wrote: >> Marvell Armada 3700 SoC has two USB controllers, each of them being >> wired to an internal UTMI PHY. Add a driver to control them. >> >> Igal Liberman worked on supporting the PHY, I to

Re: [PATCH v2 4/4] usb: musb: Add support for MediaTek musb controller

Hi Bin, On Tue, 2019-01-15 at 14:38 -0600, Bin Liu wrote: > Hi Min, > > very close, thanks. > Below I tried to explain a further cleanup in musb_clearb/w() and > musb_get/set_toggle() implementation. Please let me know if it is not > clear. > > Basically, we don't need musb_default_clearb/w(), j

[PATCH 8/8] net: macb: add sam9x60-macb compatibility string

Add a new compatibility string for this product. It's using at91sam9260-macb layout but has a newer hardware revision: it's safer to use its own string. Signed-off-by: Nicolas Ferre --- drivers/net/ethernet/cadence/macb_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ether

[PATCH 6/8] power: reset: at91-reset: add support for sam9x60 SoC

Add support for additional reset causes and the proper compatibility string for sam9x60 SoC. The restart function is the same as the samx7. Signed-off-by: Nicolas Ferre --- drivers/power/reset/at91-reset.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/power/reset/at9

[PATCH 4/8] net/macb: bindings doc/trivial: fix documentation for sama5d3 10/100 interface

This removes a line left while adding the correct compatibility string for sama5d3 10/100 interface. Now use the "atmel,sama5d3-macb" string. Signed-off-by: Nicolas Ferre --- Documentation/devicetree/bindings/net/macb.txt | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Docu

[PATCH 5/8] net/macb: bindings doc: add sam9x60 binding

Add the compatibility sting documentation for sam9x60 10/100 interface. Signed-off-by: Nicolas Ferre --- Documentation/devicetree/bindings/net/macb.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree/bindings/net/macb

[PATCH 7/8] USB: host: ohci-at91: add sam9x60-sfr definition for ohci

Add this SFR compatible definition for the sam9x60 SoC and manage its use in ohci-at91.c driver. Signed-off-by: Nicolas Ferre --- drivers/usb/host/ohci-at91.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/ohci-at91.c b/drivers/usb/host/ohci-at91.c in

[PATCH 2/8] dt-bindings: arm: atmel: add new sam9x60 reset controller binding

Update the Reset Controller's binding to add new SoC compatibility string. Signed-off-by: Nicolas Ferre --- Documentation/devicetree/bindings/arm/atmel-sysregs.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/arm/atmel-sysregs.txt b/Documentation/devicet

[PATCH 1/8] dt-bindings: arm: atmel: add missing samx7 to reset controller

Add this missing compatibility string to the Reset Controller compatible string chip list. Signed-off-by: Nicolas Ferre --- Documentation/devicetree/bindings/arm/atmel-sysregs.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/arm/atmel-sysr

[PATCH 3/8] dt-bindings: arm: atmel: add new sam9x60 SFR binding

Add this SFR compatible definition for the sam9x60 SoC. Will be needed in OHCI driver: ohci-at91.c. Signed-off-by: Nicolas Ferre --- Documentation/devicetree/bindings/arm/atmel-sysregs.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/arm/atmel-sysregs.txt

[PATCH 0/8] ARM: at91/dt: update to existing drivers for the sam9x60 SoC

Hi, This serries collects some little modifications to DT bindings and associated drivers changes for supporting the upcoming SAM9X60 SoC. I took the advantage of this series for fixing some of the leftovers in DT bindings for reset controller and Ethernet macb. These changes touch several sub-s

[PATCH] usb: chipidea: Grab the (legacy) USB PHY by phandle first

According to the chipidea driver bindings, the USB PHY is specified via the "phys" phandle node. However, this only takes effect for USB PHYs that use the common PHY framework. For legacy USB PHYs, a simple lookup based on the USB PHY type is done instead. This does not play out well when more tha

Re: question on xhci_handle_stopped_cmd_ring()

Hi, back from a long sick leave On 10.01.2019 11:39, Oliver Neukum wrote: Hi, looking at this code: /* ring command ring doorbell to restart the command ring */ if ((xhci->cmd_ring->dequeue != xhci->cmd_ring->enqueue) && !(xhci->xhc_state & XHCI_STATE_DYING)) {

[PATCH v2,1/2] dt-bindings: usb: ci-hdrc-usb2: add property power-active-high

Signed-off-by: Philipp Puschmann --- V2: unchanged ... --- Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt index adae82385

[PATCH v2,2/2] usb: chipidea: imx: set power polarity

This patch adds support to set the power line polarity for i.MX6q/dl. To let the USB controller control the power it may be necessary to configure the polarity of the power line. So far the polarity was configured by Bootloader or alternatively the power line was muxed as gpio and driven by a regu

Re: [PATCH] usb: chipidea: Grab the (legacy) USB PHY by phandle first

Hello, Thanks for the patch! On Wed, 16 Jan 2019 11:10:51 +0100, Paul Kocialkowski wrote: > According to the chipidea driver bindings, the USB PHY is specified via > the "phys" phandle node. However, this only takes effect for USB PHYs > that use the common PHY framework. For legacy USB PHYs, a s

[PATCH v3 1/2] dt-bindings: usb: ci-hdrc-usb2: add property power-active-high

The i.MX6q/dl USB controller may drive the usb power line directly, but the polarity depends on the board. Reset state of the polarity is low-active so add this property to allow it to be high-active. Signed-off-by: Philipp Puschmann --- Changes in v3: add description --- Documentation/devicetre

[PATCH v3 2/2] usb: chipidea: imx: set power polarity

This patch adds support to set the power line polarity for i.MX6q/dl. To let the USB controller control the power it may be necessary to configure the polarity of the power line. So far the polarity was configured by Bootloader or alternatively the power line was muxed as gpio and driven by a regu

Re: [PATCH] USB:Serial:pl2303:Add new Pull-UP Mode to support PL2303HXD(TYPE_HX)

On Tue, Jan 15, 2019 at 11:15:36PM +0800, Charles Yeh wrote: > The Pull-UP mode only support PL2303HXD,it needs to use addition > schematic design. I need a better explain of why this is needed here. Your are also enabling this for all current devices, which seems to just fine without this. > Si

Re: [PATCH] USB:Serial:pl2303:Add new PID to support PL2303TB(TYPE_HX)

Please add a space after each colon in the commit summary (subject) and no need to capitalise "serial". On Tue, Jan 15, 2019 at 11:13:56PM +0800, Charles Yeh wrote: > Add new PID to support PL2303TB (TYPE_HX) Is this one independent of the second "pull-up" patch? > Signed-off-by: Charles Yeh T

Re: [PATCH 2/2] usb: dwc3: Add workaround for host mode VBUS glitch when boot

Hi Ran, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on usb/usb-testing] [also build test WARNING on v5.0-rc2 next-20190116] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci

Re: [PATCH v2 06/10] dt-bindings: phy: mvebu-utmi: add UTMI PHY bindings

Hi Rob, Rob Herring wrote on Tue, 15 Jan 2019 15:44:29 -0600: > On Fri, Jan 11, 2019 at 02:31:29PM +0100, Miquel Raynal wrote: > > Add bindings for Marvell Armada 3700 USB2 UTMI+ PHY. > > > > Signed-off-by: Miquel Raynal > > --- > > .../bindings/phy/phy-mvebu-utmi.txt | 37 +

Re: [PATCH] usb: chipidea: Grab the (legacy) USB PHY by phandle first

Hi, On Wed, 2019-01-16 at 11:53 +0100, Thomas Petazzoni wrote: > Hello, > > Thanks for the patch! And thanks for the review! > On Wed, 16 Jan 2019 11:10:51 +0100, Paul Kocialkowski wrote: > > According to the chipidea driver bindings, the USB PHY is specified via > > the "phys" phandle node. Ho

[PATCH 01/21] openrisc: prefer memblock APIs returning virtual address

The allocation of the page tables memory in openrics uses memblock_phys_alloc() and then converts the returned physical address to virtual one. Use memblock_alloc_raw() and add a panic() if the allocation fails. Signed-off-by: Mike Rapoport --- arch/openrisc/mm/init.c | 5 - 1 file changed,

[PATCH 04/21] memblock: drop memblock_alloc_base_nid()

The memblock_alloc_base_nid() is a oneliner wrapper for memblock_alloc_range_nid() without any side effect. Replace it's usage by the direct calls to memblock_alloc_range_nid(). Signed-off-by: Mike Rapoport --- include/linux/memblock.h | 3 --- mm/memblock.c| 15 --- 2 f

[PATCH 06/21] memblock: memblock_phys_alloc_try_nid(): don't panic

The memblock_phys_alloc_try_nid() function tries to allocate memory from the requested node and then falls back to allocation from any node in the system. The memblock_alloc_base() fallback used by this function panics if the allocation fails. Replace the memblock_alloc_base() fallback with the di

[PATCH 09/21] memblock: drop memblock_alloc_base()

The memblock_alloc_base() function tries to allocate a memory up to the limit specified by its max_addr parameter and panics if the allocation fails. Replace its usage with memblock_phys_alloc_range() and make the callers check the return value and panic in case of error. Signed-off-by: Mike Rapop

[PATCH 11/21] memblock: make memblock_find_in_range_node() and choose_memblock_flags() static

These functions are not used outside memblock. Make them static. Signed-off-by: Mike Rapoport --- include/linux/memblock.h | 4 mm/memblock.c| 4 ++-- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/include/linux/memblock.h b/include/linux/memblock.h index cf4cd9c

[PATCH 15/21] sparc: add checks for the return value of memblock_alloc*()

Add panic() calls if memblock_alloc*() returns NULL. Most of the changes are simply addition of if(!ptr) panic(); statements after the calls to memblock_alloc*() variants. Exceptions are pcpu_populate_pte() and kernel_map_range() that were slightly refactored to accommod

[PATCH 14/21] ia64: add checks for the return value of memblock_alloc*()

Add panic() calls if memblock_alloc*() returns NULL. Most of the changes are simply addition of if(!ptr) panic(); statements after the calls to memblock_alloc*() variants. Exceptions are create_mem_map_page_table() and ia64_log_init() that were slightly refactored to acc

[PATCH 16/21] mm/percpu: add checks for the return value of memblock_alloc*()

Add panic() calls if memblock_alloc() returns NULL. The panic() format duplicates the one used by memblock itself and in order to avoid explosion with long parameters list replace open coded allocation size calculations with a local variable. Signed-off-by: Mike Rapoport --- mm/percpu.c | 73 ++

[PATCH 21/21] memblock: drop memblock_alloc_*_nopanic() variants

As all the memblock allocation functions return NULL in case of error rather than panic(), the duplicates with _nopanic suffix can be removed. Signed-off-by: Mike Rapoport --- arch/arc/kernel/unwind.c | 3 +-- arch/sh/mm/init.c | 2 +- arch/x86/kernel/setup_percpu.c | 10 +++

[PATCH 20/21] memblock: memblock_alloc_try_nid: don't panic

As all the memblock_alloc*() users are now checking the return value and panic() in case of error, the panic() call can be removed from the core memblock allocator, namely memblock_alloc_try_nid(). Signed-off-by: Mike Rapoport --- mm/memblock.c | 15 +-- 1 file changed, 5 insertions(

[PATCH 17/21] init/main: add checks for the return value of memblock_alloc*()

Add panic() calls if memblock_alloc() returns NULL. The panic() format duplicates the one used by memblock itself and in order to avoid explosion with long parameters list replace open coded allocation size calculations with a local variable. Signed-off-by: Mike Rapoport --- init/main.c | 26 ++

[PATCH 19/21] treewide: add checks for the return value of memblock_alloc*()

Add check for the return value of memblock_alloc*() functions and call panic() in case of error. The panic message repeats the one used by panicing memblock allocators with adjustment of parameters to include only relevant ones. The replacement was mostly automated with semantic patches like the o

[PATCH 13/21] arch: don't memset(0) memory returned by memblock_alloc()

memblock_alloc() already clears the allocated memory, no point in doing it twice. Signed-off-by: Mike Rapoport --- arch/c6x/mm/init.c | 1 - arch/h8300/mm/init.c| 1 - arch/ia64/kernel/mca.c | 2 -- arch/m68k/mm/mcfmmu.c | 1 - arch/microblaze/mm/init.c | 6 ++

[PATCH 18/21] swiotlb: add checks for the return value of memblock_alloc*()

Add panic() calls if memblock_alloc() returns NULL. The panic() format duplicates the one used by memblock itself and in order to avoid explosion with long parameters list replace open coded allocation size calculations with a local variable. Signed-off-by: Mike Rapoport --- kernel/dma/swiotlb.

[PATCH 10/21] memblock: refactor internal allocation functions

Currently, memblock has several internal functions with overlapping functionality. They all call memblock_find_in_range_node() to find free memory and then reserve the allocated range and mark it with kmemleak. However, there is difference in the allocation constraints and in fallback strategies.

[PATCH 08/21] memblock: drop __memblock_alloc_base()

The __memblock_alloc_base() function tries to allocate a memory up to the limit specified by its max_addr parameter. Depending on the value of this parameter, the __memblock_alloc_base() can is replaced with the appropriate memblock_phys_alloc*() variant. Signed-off-by: Mike Rapoport --- arch/sh

[PATCH 12/21] arch: use memblock_alloc() instead of memblock_alloc_from(size, align, 0)

The last parameter of memblock_alloc_from() is the lower limit for the memory allocation. When it is 0, the call is equivalent to memblock_alloc(). Signed-off-by: Mike Rapoport --- arch/alpha/kernel/core_cia.c | 2 +- arch/alpha/kernel/pci_iommu.c | 4 ++-- arch/alpha/kernel/setup.c | 2

[PATCH 05/21] memblock: emphasize that memblock_alloc_range() returns a physical address

Rename memblock_alloc_range() to memblock_phys_alloc_range() to emphasize that it returns a physical address. While on it, remove the 'enum memblock_flags' parameter from this function as its only user anyway sets it to MEMBLOCK_NONE, which is the default for the most of memblock allocations. Sign

[PATCH 07/21] memblock: memblock_phys_alloc(): don't panic

Make the memblock_phys_alloc() function an inline wrapper for memblock_phys_alloc_range() and update the memblock_phys_alloc() callers to check the returned value and panic in case of error. Signed-off-by: Mike Rapoport --- arch/arm/mm/init.c | 4 arch/arm64/mm/mmu.c

Re: [PATCH] usb: chipidea: Grab the (legacy) USB PHY by phandle first

Hello, On Wed, 16 Jan 2019 14:30:28 +0100, Paul Kocialkowski wrote: > > Why is this conditional on the generic PHY lookup failing? > > > > Don't we simply want: > > > > ci->phy = devm_phy_get(dev->parent, "usb-phy"); > > ci->usb_phy = devm_usb_get_phy_by_phandle(dev->parent, "phys", 0);

[PATCH 02/21] powerpc: use memblock functions returning virtual address

From: Christophe Leroy Since only the virtual address of allocated blocks is used, lets use functions returning directly virtual address. Those functions have the advantage of also zeroing the block. [ MR: - updated error message in alloc_stack() to be more verbose - convereted several additi

[PATCH 00/21] Refine memblock API

Hi, Current memblock API is quite extensive and, which is more annoying, duplicated. Except the low-level functions that allow searching for a free memory region and marking it as reserved, memblock provides three (well, two and a half) sets of functions to allocate memory. There are several overl

[PATCH 03/21] memblock: replace memblock_alloc_base(ANYWHERE) with memblock_phys_alloc

The calls to memblock_alloc_base(size, align, MEMBLOCK_ALLOC_ANYWHERE) and memblock_phys_alloc(size, align) are equivalent as both try to allocate 'size' bytes with 'align' alignment anywhere in the memory and panic if hte allocation fails. The conversion is done using the following semantic patch

Re: [PATCH v2 1/2] dt-bindings: usb: usb251xb: add documentation for data lane swapping

On 15/01/2019 12:50, Marco Felsch wrote: Add optional binding to allow USB differential-pair (D+/D-) data lane swapping. The swapping can be specified for each port separately, default is no swapping. Signed-off-by: Marco Felsch --- Changes: v2: - rename property s/sw-dx-lanes-ports/swap-dx-l

Re: [PATCH v2 2/2] usb: usb251xb: add usb data lane port swap feature

Hi, On 15/01/2019 13:04, Marco Felsch wrote: Hi, On 19-01-15 12:50, Marco Felsch wrote: The HW can swap the USB differential-pair (D+/D-) for each port separately. So the USB signals can be re-aligned with a misplaced USB connector on the PCB. Signed-off-by: Marco Felsch --- Changes: v2: -

Re: [PATCH v2 4/4] usb: musb: Add support for MediaTek musb controller

On Wed, Jan 16, 2019 at 05:39:02PM +0800, Min Guo wrote: > Hi Bin, > > On Tue, 2019-01-15 at 14:38 -0600, Bin Liu wrote: > > Hi Min, > > > > very close, thanks. > > Below I tried to explain a further cleanup in musb_clearb/w() and > > musb_get/set_toggle() implementation. Please let me know if it

[PATCH v3 1/2] dt-bindings: usb: usb251xb: add documentation for data lane swapping

Add optional binding to allow USB differential-pair (D+/D-) data lane swapping. The swapping can be specified for each port separately, default is no swapping. Signed-off-by: Marco Felsch Reviewed-by: Richard Leitner --- Changes: v3: - no changes v2: - rename property s/sw-dx-lanes-ports/swap-

[PATCH v3 2/2] usb: usb251xb: add usb data lane port swap feature

The HW can swap the USB differential-pair (D+/D-) for each port separately. So the USB signals can be re-aligned with a misplaced USB connector on the PCB. Signed-off-by: Marco Felsch Reviewed-by: Richard Leitner --- Changes: v3: - fix comment v2: - rename property s/sw-dx-lanes-ports/swap-dx-

Re: [PATCH] usb: chipidea: Grab the (legacy) USB PHY by phandle first

Hi, On Wed, 2019-01-16 at 14:44 +0100, Thomas Petazzoni wrote: > Well prior to your code, there was already a possibility for both > ci->phy and ci->usb_phy to be valid. I don't think it's really useful > to avoid the fallback when a generic PHY has already been found, it's > confusing. If really

Re: [Xen-devel] [PATCH 19/21] treewide: add checks for the return value of memblock_alloc*()

On 16/01/2019 14:44, Mike Rapoport wrote: > Add check for the return value of memblock_alloc*() functions and call > panic() in case of error. > The panic message repeats the one used by panicing memblock allocators with > adjustment of parameters to include only relevant ones. > > The replacement

Re: [PATCH v5 4/6] usb: gadget: add mechanism to specify an explicit status stage

On Wed, 16 Jan 2019, Paul Elder wrote: > On Mon, Jan 14, 2019 at 10:24:44AM -0500, Alan Stern wrote: > > On Mon, 14 Jan 2019, Paul Elder wrote: > > > > > > > > Can you check your uvc > > > > > > changes using dummy_hcd with the patch below? > > > > > > > > > > I'm not sure what to make of the te

Re: [PATCH v2 3/6] phy: qcom-qusb2: Add QUSB2 PHY support for msm8998

On 1/16/2019 1:58 AM, Kishon Vijay Abraham I wrote: Hi, On 16/01/19 2:20 PM, Kishon Vijay Abraham I wrote: On 15/01/19 11:41 PM, Bjorn Andersson wrote: On Mon 14 Jan 08:36 PST 2019, Jeffrey Hugo wrote: MSM8998 contains one QUSB2 PHY which is very similar to the existing sdm845 support.

Re: [PATCH v3] usb: gadget: musb: fix short isoc packets with inventra dma

On Tue, Jan 15, 2019 at 07:01:45PM -0500, Paul Elder wrote: > Handling short packets (length < max packet size) in the Inventra DMA > engine in the MUSB driver causes the MUSB DMA controller to hang. An > example of a problem that is caused by this problem is when streaming > video out of a UVC gad

Re: DWC3 DEPEVT_STATUS_SHORT

Hi, (break your lines at 80-columns) david preetham writes: > In DWC3 USB device controller, on which basis event->status & > DEPEVT_STATUS_SHORT is set who will set? I understand if we receive > less bytes we are going to set short packet. > > Suppose gadget driver requested 1MB req length, D

[PATCH] usb: warm-reset ports on hub resume, if requested

On plug-in of my USB-C device, its USB_SS_PORT_LS_SS_INACTIVE link state bit is set. Greping all the kernel for this bit shows that the port status requests a warm-reset this way. This just happens, if its the only device on that hub and the hub resumes, so we don't call port_event, which would ot

[PATCH v2] usb: warm-reset ports on hub resume, if requested

On plug-in of my USB-C device, its USB_SS_PORT_LS_SS_INACTIVE link state bit is set. Greping all the kernel for this bit shows that the port status requests a warm-reset this way. This just happens, if its the only device on that hub and the hub resumes, so we don't call port_event, which would ot

Re: [PATCH v2,2/2] usb: chipidea: imx: set power polarity

Hello! On 01/16/2019 01:51 PM, Philipp Puschmann wrote: > This patch adds support to set the power line polarity for i.MX6q/dl. > > To let the USB controller control the power it may be necessary to configure > the polarity of the power line. So far the polarity was configured > by Bootloader or

Re: [PATCH v2] usb: warm-reset ports on hub resume, if requested

On Wed, Jan 16, 2019 at 05:06:33PM +0100, Jan-Marek Glogowski wrote: > On plug-in of my USB-C device, its USB_SS_PORT_LS_SS_INACTIVE > link state bit is set. Greping all the kernel for this bit shows > that the port status requests a warm-reset this way. > > This just happens, if its the only devi

cannot get freq errors for Jabra evolve link headset

When I plug in a Jabra evolve link headset (kernel v4.20.0), I see the following errors in dmesg. However, the headset does seem to work so they may be benign? [14498.436108] usb 1-2: 1:1: cannot get freq at ep 0x83 [14498.438203] usb 1-2: 2:1: cannot get freq at ep 0x4 Overall dmesg output from

[PATCH v3] usb: warm-reset ports on hub resume, if requested

On plug-in of my USB-C device, its USB_SS_PORT_LS_SS_INACTIVE link state bit is set. Greping all the kernel for this bit shows that the port status requests a warm-reset this way. This just happens, if its the only device on that hub and the hub resumes, so we don't call port_event, which would ot

Re: [PATCH 15/21] sparc: add checks for the return value of memblock_alloc*()

From: Mike Rapoport Date: Wed, 16 Jan 2019 15:44:15 +0200 > Add panic() calls if memblock_alloc*() returns NULL. > > Most of the changes are simply addition of > > if(!ptr) > panic(); > > statements after the calls to memblock_alloc*() variants. > > Exceptions are pcpu

[PATCH] usb: phy: am335x: fix race condition in _probe

power off the phy should be done before populate the phy. Otherwise, am335x_init() could be called by the phy owner to power on the phy first, then am335x_phy_probe() turns off the phy again without the caller knowing it. Fixes: 2fc711d76352 ("usb: phy: am335x: Enable USB remote wakeup using PHY

Re: [PATCH] USB: Fix configuration selection issues introduced in v4.20.0

On Wed, 16 Jan 2019 at 07:24, Gopal, Saranya wrote: > > Hi Yakimov, > > As per UAC3 configuration, the first configuration will always be > backward-compatible. > So, there cannot be any UAC3-compatible device which has first configuration > as UAC3. Thanks for the clarification. I would argue

Re: [PATCH v3 1/2] dt-bindings: usb: ci-hdrc-usb2: add property power-active-high

On Wed, 16 Jan 2019 12:11:32 +0100, Philipp Puschmann wrote: > The i.MX6q/dl USB controller may drive the usb power line directly, but the > polarity depends on the board. Reset state of the polarity is low-active so > add this property to allow it to be high-active. > > Signed-off-by: Philipp Pus

Re: [PATCH v3 1/2] dt-bindings: usb: usb251xb: add documentation for data lane swapping

On Wed, 16 Jan 2019 15:20:36 +0100, Marco Felsch wrote: > Add optional binding to allow USB differential-pair (D+/D-) data lane > swapping. The swapping can be specified for each port separately, > default is no swapping. > > Signed-off-by: Marco Felsch > Reviewed-by: Richard Leitner > --- > Cha

Re: [PATCH v2 06/10] dt-bindings: phy: mvebu-utmi: add UTMI PHY bindings

On Wed, Jan 16, 2019 at 02:20:21PM +0100, Miquel Raynal wrote: > Hi Rob, > > Rob Herring wrote on Tue, 15 Jan 2019 15:44:29 -0600: > > > On Fri, Jan 11, 2019 at 02:31:29PM +0100, Miquel Raynal wrote: > > > Add bindings for Marvell Armada 3700 USB2 UTMI+ PHY. > > > > > > Signed-off-by: Miquel Ra

Re: [PATCH v2 2/6] dt-bindings: usb: Add support for msm8998

On Mon, 14 Jan 2019 09:36:27 -0700, Jeffrey Hugo wrote: > msm8998 USB has a dwc3 controller just like the existing sdm845 support > > Signed-off-by: Jeffrey Hugo > --- > Documentation/devicetree/bindings/usb/qcom,dwc3.txt | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Rob Herring

Re: usb: gadget: ffs: Fix BUG when userland exits with submitted AIO transfers

On Wed, Jan 16, 2019 at 3:20 PM Vincent Pelletier wrote: > > This bug happens only when the UDC needs to sleep during usb_ep_dequeue, > as is the case for (at least) dwc3. > > [ 382.200896] BUG: scheduling while atomic: screen/1808/0x0100 > [ 382.207124] 4 locks held by screen/1808: > [ 382

RE: [PATCH] USB:Serial:pl2303:Add new PID to support PL2303TB(TYPE_HX)

Hi Johan, Please add a space after each colon in the commit summary (subject) and no need to capitalise "serial". Charles_Ans: OK... Is this one independent of the second "pull-up" patch? Charles_Ans: Yes, it is independent of the second "pull-up" patch. Charles Yeh(葉榮鑫) TeL: +886-2-26546363

Re: [PATCH v2 4/4] usb: musb: Add support for MediaTek musb controller

On Wed, 2019-01-16 at 07:59 -0600, Bin Liu wrote: > On Wed, Jan 16, 2019 at 05:39:02PM +0800, Min Guo wrote: > > Hi Bin, > > > > On Tue, 2019-01-15 at 14:38 -0600, Bin Liu wrote: > > > Hi Min, > > > > > > very close, thanks. > > > Below I tried to explain a further cleanup in musb_clearb/w() and

RE: [PATCH] USB: Fix configuration selection issues introduced in v4.20.0

> The result is this: > Before f13912d3f014a, if an RNDIS device has non-vendor-specific > configurations after the first one, that one would be selected. > After ff2a8c532c14, the first configuration would always be selected > for RNDIS devices. Besides, there are several redundant checks in this

RE: [PATCH] USB:Serial:pl2303:Add new Pull-UP Mode to support PL2303HXD(TYPE_HX)

Hi Johan, Please refer to https://electronics.stackexchange.com/questions/28091/push-pull-open-drain-pull-up-pull-down " Your are also enabling this for all current devices " <<--No, it needs to use addition schematic design. It needs special PCB and special PL2303HXD, and then enable P

RE: [PATCH] usb: chipidea: Grab the (legacy) USB PHY by phandle first

> > On Wed, 2019-01-16 at 14:44 +0100, Thomas Petazzoni wrote: > > Well prior to your code, there was already a possibility for both > > ci->phy and ci->usb_phy to be valid. I don't think it's really useful > > to avoid the fallback when a generic PHY has already been found, it's > > confusing.

RE: [PATCH v3 1/2] dt-bindings: usb: ci-hdrc-usb2: add property power-active-high

> > The i.MX6q/dl USB controller may drive the usb power line directly, but the > polarity > depends on the board. Reset state of the polarity is low-active so add this > property > to allow it to be high-active. > As far as I know, most of i.mx USB controllers (except imx28/23, but they don

Re: [PATCH 19/21] treewide: add checks for the return value of memblock_alloc*()

On Wed, Jan 16, 2019 at 03:44:19PM +0200, Mike Rapoport wrote: > arch/csky/mm/highmem.c| 5 + ... > diff --git a/arch/csky/mm/highmem.c b/arch/csky/mm/highmem.c > index 53b1bfa..3317b774 100644 > --- a/arch/csky/mm/highmem.c > +++ b/arch/csky/mm/highmem.c > @@ -141,6 +141,1

[PATCH v3 4/4] usb: musb: Add support for MediaTek musb controller

From: Min Guo This adds support for MediaTek musb controller in host, peripheral and otg mode. There are some quirk of MediaTek musb controller, such as: -W1C interrupt status registers -Private data toggle registers -No dedicated DMA interrupt line Signed-off-by: Min Guo Signed-off-by: Yong

[PATCH v3 1/4] dt-bindings: usb: musb: Add support for MediaTek musb controller

From: Min Guo This adds support for MediaTek musb controller in host, peripheral and otg mode. Signed-off-by: Min Guo --- .../devicetree/bindings/usb/mediatek,musb.txt | 43 ++ 1 file changed, 43 insertions(+) create mode 100644 Documentation/devicetree/bindings/usb/m

[PATCH v3 2/4] arm: dts: mt2701: Add usb2 device nodes

From: Min Guo Add musb nodes and usb2 phy nodes for MT2701 Signed-off-by: Min Guo --- arch/arm/boot/dts/mt2701-evb.dts | 21 + arch/arm/boot/dts/mt2701.dtsi| 33 + 2 files changed, 54 insertions(+) diff --git a/arch/arm/boot/dts/mt2701-e

[PATCH v3 3/4] usb: musb: Delete the const attribute of addr parameter in readb/w/l hooks

From: Min Guo These changes are for implementing clearing W1C registers. Signed-off-by: Min Guo --- drivers/usb/musb/musb_core.c | 10 +- drivers/usb/musb/musb_core.h | 4 ++-- drivers/usb/musb/musb_io.h | 6 +++--- drivers/usb/musb/sunxi.c | 4 ++-- drivers/usb/musb/tusb6010.

[PATCH v3 0/4] Add MediaTek MUSB Controller Driver

From: Min Guo These patches introduce the MediaTek MUSB controller driver. The driver can be configured as Dual-Role Device (DRD), Peripheral Only and Host Only modes. This has beed tested on MT2701 with a variety of devices in host mode and with the f_mass gadget driver in peripheral mode, plu

[PATCH] usb: renesas_usbhs: replace udelay() with usleep_range()

According to Documentation/timers/timers-howto.txt, a driver should use usleep_range() instead of udelay() on NON-ATOMIC CONTEXT if "SLEEPING FOR ~USECS OR SMALL MSECS ( 10us - 20ms)". Since the .hardware_init() and .power_ctrl() will run on NON-ATOMIC CONTEXT, this patch replaces udelay() with us