Re: [PATCH] roles: Fix for Enabling USB ROLE SWITCH QUIRK on INTEL_SUNRISEPOINT_LP_XHCI

2019-01-07 Thread Hans de Goede
Hi, On 08-01-19 07:25, m.bal...@intel.com wrote: From: M, Balaji This fix enables USB role feature on intel commercial nuc platform which is based on Kabylake chipset. Signed-off-by: M, Balaji Patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans --- drivers/usb/host/x

[PATCH V2] roles: Fix for Enabling USB ROLE SWITCH QUIRK on INTEL_SUNRISEPOINT_LP_XHCI

2019-01-07 Thread m . balaji
From: M, Balaji This fix enables USB role feature on intel commercial nuc platform which is based on Kabylake chipset. Signed-off-by: M, Balaji Reviewed-by: Hans de Goede --- Changes from v1: Added Reviewed-by drivers/usb/host/xhci-pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dr

Re: [PATCH V2] roles: Fix for Enabling USB ROLE SWITCH QUIRK on INTEL_SUNRISEPOINT_LP_XHCI

2019-01-07 Thread Hans de Goede
Hi, On 08-01-19 11:04, m.bal...@intel.com wrote: From: M, Balaji This fix enables USB role feature on intel commercial nuc platform which is based on Kabylake chipset. Signed-off-by: M, Balaji Reviewed-by: Hans de Goede --- Changes from v1: Added Reviewed-by There is no need to send out

Re: [PATCH 02/19] usbnet: smsc95xx: Stop propagation of in_pm

2019-01-07 Thread Oliver Neukum
On Do, 2019-01-03 at 02:10 +0100, Marek Vasut wrote: > The information whether the SMSC95xx is in_pm or not can be derived from > the usbdev->suspend_count. First thing called in smsc95xx_suspend() is > usbnet_suspend(), which increments the usbdev->suspend_count and since > then the driver only ca

Re: [PATCH 07/19] usbnet: smsc95xx: Split the reset function

2019-01-07 Thread Oliver Neukum
On Do, 2019-01-03 at 02:10 +0100, Marek Vasut wrote: > The smsc95xx_reset() is called either during bind or later during > the driver operation. However, the MII structure can be populated > only once, when the smsc95xx_reset() is called from the drivers > bind function. > > Split the reset functi

Re: [PATCH V2] roles: Fix for Enabling USB ROLE SWITCH QUIRK on INTEL_SUNRISEPOINT_LP_XHCI

2019-01-07 Thread Heikki Krogerus
On Tue, Jan 08, 2019 at 05:04:20AM -0500, m.bal...@intel.com wrote: > From: M, Balaji > > This fix enables USB role feature on intel commercial nuc > platform which is based on Kabylake chipset. > > Signed-off-by: M, Balaji > Reviewed-by: Hans de Goede OK by me: Reviewed-by: Heikki Krogerus

Re: [PATCH 02/19] usbnet: smsc95xx: Stop propagation of in_pm

2019-01-07 Thread Marek Vasut
On 1/7/19 12:02 PM, Oliver Neukum wrote: > On Do, 2019-01-03 at 02:10 +0100, Marek Vasut wrote: >> The information whether the SMSC95xx is in_pm or not can be derived from >> the usbdev->suspend_count. First thing called in smsc95xx_suspend() is >> usbnet_suspend(), which increments the usbdev->sus

Re: [PATCH lora-next 3/5] net: lora: sx130x: Add PicoCell serdev driver

2019-01-07 Thread Oliver Neukum
On Fr, 2019-01-04 at 12:21 +0100, Andreas Färber wrote: > > +struct picogw_device { > + struct serdev_device *serdev; > + > + u8 rx_buf[1024]; No, you cannot do that. AFAICT this buffer can be used for DMA. Thus putting it into another data structure violates the rules of DMA coherency.

Re: [PATCH RFC 4/5] usb: cdc-acm: Enable serdev support

2019-01-07 Thread Oliver Neukum
On Fr, 2019-01-04 at 12:21 +0100, Andreas Färber wrote: > Switch from tty_port_register_device() to tty_port_register_device_serdev() > and from tty_unregister_device() to tty_port_unregister_device(). > > On removal of a serdev driver sometimes count mismatch warnings were seen: > > ttyACM tt

[PATCH] usb: core: Simplify return value of usb_get_configuration()

2019-01-07 Thread Suwan Kim
It is better to initialize the return value "result" to -ENOMEM than to 0. And because "result" takes the return value of usb_parse_configuration() which returns 0 for success, setting "result" to 0 at before and after of the for loop is unnecessary. Signed-off-by: Suwan Kim --- drivers/usb/core

RE: [PATCH V2] roles: Fix for Enabling USB ROLE SWITCH QUIRK on INTEL_SUNRISEPOINT_LP_XHCI

2019-01-07 Thread Balaji, M
> -Original Message- > From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb- > ow...@vger.kernel.org] On Behalf Of Hans de Goede > Sent: Monday, January 7, 2019 4:20 PM > To: Balaji, M ; linux-usb@vger.kernel.org > Cc: mathias.ny...@linux.intel.com; heikki.kroge...@linux.intel.com > Su

Re: [PATCH RFC 4/5] usb: cdc-acm: Enable serdev support

2019-01-07 Thread Johan Hovold
On Mon, Jan 07, 2019 at 02:48:26PM +0100, Oliver Neukum wrote: > On Fr, 2019-01-04 at 12:21 +0100, Andreas Färber wrote: > > Switch from tty_port_register_device() to tty_port_register_device_serdev() > > and from tty_unregister_device() to tty_port_unregister_device(). > > > > On removal of a se

Re: [PATCH v4] USB: Don't enable LPM if it's already enabled

2019-01-07 Thread Alan Stern
On Mon, 7 Jan 2019, Kai Heng Feng wrote: > Hi, > > > On Dec 3, 2018, at 18:26, Kai-Heng Feng wrote: > > > > USB Bluetooth controller QCA ROME (0cf3:e007) sometimes stops working > > after S3: > > [ 165.110742] Bluetooth: hci0: using NVM file: qca/nvm_usb_0302.bin > > [ 168.432065] Bluetooth

Re: [PATCH] usb: core: Simplify return value of usb_get_configuration()

2019-01-07 Thread Alan Stern
On Mon, 7 Jan 2019, Suwan Kim wrote: > It is better to initialize the return value "result" to -ENOMEM > than to 0. And because "result" takes the return value of > usb_parse_configuration() which returns 0 for success, setting > "result" to 0 at before and after of the for loop is unnecessary. >

Re: [RFC lora-next 5/5] HACK: net: lora: sx130x: Add PicoCell gateway shim for cdc-acm

2019-01-07 Thread Johan Hovold
On Sat, Jan 05, 2019 at 12:43:48AM +0100, Andreas Färber wrote: > Hi Rob, > > Am 04.01.19 um 18:07 schrieb Rob Herring: > > On Fri, Jan 4, 2019 at 5:21 AM Andreas Färber wrote: > >> > >> Ignore our device in cdc-acm probing and add a new driver for it, > >> dispatching to cdc-acm for the actual i

Re: [PATCH] USB: serial: simple: add Motorola Tetra driver for TPG2200

2019-01-07 Thread Johan Hovold
On Mon, Jan 07, 2019 at 08:31:49AM +0100, Max Schulze wrote: > Add new Motorola Tetra (simple) driver for Motorola Solutions TETRA PEI > device I rephrased the summary and comment above since you're adding a new device id to an existing driver (rather than a new driver). > T: Bus=02 Lev=01 Prnt=

RE: r8152: data corruption in various scenarios

2019-01-07 Thread Mario.Limonciello
> -Original Message- > From: Hayes Wang > Sent: Sunday, January 6, 2019 9:54 PM > To: Mark Lord; Kai Heng Feng > Cc: Ansis Atteka; David Miller; g...@kroah.com; rom...@fr.zoreil.com; > net...@vger.kernel.org; nic_swsd; linux-ker...@vger.kernel.org; linux- > u...@vger.kernel.org; Limonciell

Re: [PATCH v4] USB: Don't enable LPM if it's already enabled

2019-01-07 Thread Greg KH
On Mon, Dec 03, 2018 at 06:26:43PM +0800, Kai-Heng Feng wrote: > USB Bluetooth controller QCA ROME (0cf3:e007) sometimes stops working > after S3: > [ 165.110742] Bluetooth: hci0: using NVM file: qca/nvm_usb_0302.bin > [ 168.432065] Bluetooth: hci0: Failed to send body at 4 of 1953 (-110) > >

Re: [PATCH] USB: host: ehci: allow tine of highspeed nak-count

2019-01-07 Thread Greg KH
On Wed, Nov 14, 2018 at 05:13:15PM +, Ben Dooks wrote: > From: Ben Dooks > > At least some systems benefit with less scheduling if the NAK count > value is set higher than the default 4. For instance a Tegra3 with > an SMSC9512 showed less interrupt load when this was changed to 14. > > To a

Re: [PATCH V2] roles: Fix for Enabling USB ROLE SWITCH QUIRK on INTEL_SUNRISEPOINT_LP_XHCI

2019-01-07 Thread Greg KH
On Tue, Jan 08, 2019 at 05:04:20AM -0500, m.bal...@intel.com wrote: > From: M, Balaji > > This fix enables USB role feature on intel commercial nuc > platform which is based on Kabylake chipset. Your subject prefix is a bit odd "roles" is not a global thing, it should look something like:

Re: [PATCH v3] usb: hub: add retry routine after intr URB submit error

2019-01-07 Thread Greg KH
On Tue, Nov 20, 2018 at 03:34:38PM +0100, Nicolas Saenz Julienne wrote: > The hub sends hot-plug events to the host trough it's interrupt URB. The > driver takes care of completing the URB and re-submitting it. Completion > errors are handled in the hub_event() work, yet submission errors are > ign

Re: [PATCH] cdc_ether: trivial whitespace readability fix

2019-01-07 Thread David Miller
From: Bjørn Mork Date: Sat, 5 Jan 2019 14:32:39 +0100 > This function is unreadable enough without indenting mismatches > and unnecessary line breaks. > > Signed-off-by: Bjørn Mork Applied, thanks.

[PATCH V2] usb:xhci: Fix for Enabling USB ROLE SWITCH QUIRK on INTEL_SUNRISEPOINT_LP_XHCI

2019-01-07 Thread m . balaji
From: M, Balaji This fix enables USB role feature on intel commercial nuc platform which is based on Kabylake chipset. Signed-off-by: M, Balaji --- Changes from v1: changed patch subject from roles: to usb:xhci drivers/usb/host/xhci-pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dr

Re: [PATCH V2] usb:xhci: Fix for Enabling USB ROLE SWITCH QUIRK on INTEL_SUNRISEPOINT_LP_XHCI

2019-01-07 Thread Greg KH
On Tue, Jan 08, 2019 at 11:31:53AM -0500, m.bal...@intel.com wrote: > From: M, Balaji We need a "full" name, "M," is probably not your first name :) thanks, greg k-h

Re: r8152: data corruption in various scenarios

2019-01-07 Thread Mark Lord
On 2019-01-07 11:01 a.m., mario.limoncie...@dell.com wrote: > > TB16 contains ASMedia host controller. It's a Thunderbolt dock and all USB > devices > are connected to ASMedia host controller in the dock. > > WD15 does not contain an ASMedia host controller, it connected to system's > USB host c

Re: [PATCH v1 3/6] phy: qcom-qusb2: Add QUSB2 PHY support for msm8998

2019-01-07 Thread Jack Pham
Hi Jeff, Spotted a typo below: On Fri, Jan 04, 2019 at 09:50:29AM -0700, Jeffrey Hugo wrote: > MSM8998 contains one QUSB2 PHY which is very similar to the existing > sdm845 support. > > Signed-off-by: Jeffrey Hugo > --- > .../devicetree/bindings/phy/qcom-qusb2-phy.txt | 1 + > drivers/phy

RE: r8152: data corruption in various scenarios

2019-01-07 Thread Mario.Limonciello
> -Original Message- > From: Mark Lord > Sent: Monday, January 7, 2019 12:06 PM > To: Limonciello, Mario; hayesw...@realtek.com; kai.heng.f...@canonical.com > Cc: aatt...@nicira.com; da...@davemloft.net; g...@kroah.com; > rom...@fr.zoreil.com; net...@vger.kernel.org; nic_s...@realtek.com;

Re: [PATCH v1 3/6] phy: qcom-qusb2: Add QUSB2 PHY support for msm8998

2019-01-07 Thread Jeffrey Hugo
On 1/7/2019 11:18 AM, Jack Pham wrote: Hi Jeff, Spotted a typo below: On Fri, Jan 04, 2019 at 09:50:29AM -0700, Jeffrey Hugo wrote: MSM8998 contains one QUSB2 PHY which is very similar to the existing sdm845 support. Signed-off-by: Jeffrey Hugo --- .../devicetree/bindings/phy/qcom-qusb2-ph

Re: [PATCH v3] usb: hub: add retry routine after intr URB submit error

2019-01-07 Thread Alan Stern
On Mon, 7 Jan 2019, Greg KH wrote: > On Tue, Nov 20, 2018 at 03:34:38PM +0100, Nicolas Saenz Julienne wrote: > > The hub sends hot-plug events to the host trough it's interrupt URB. The > > driver takes care of completing the URB and re-submitting it. Completion > > errors are handled in the hub_e

Re: [PATCH] usb: gadget: musb: fix short isoc packets with inventra dma for pandaboard es

2019-01-07 Thread Bin Liu
Hi Paul, Sorry for the delay on reviewing it. For the subject, can you please use usb: musb: gadget: fix short isoc packets with inventra dma On Tue, Oct 09, 2018 at 02:32:20AM -0400, Paul Elder wrote: > Handling short packets (length < max packet size) in the Inventra DMA > engine in th

[PATCH] usb: storage: Remove outdated URL from MAINTAINERS

2019-01-07 Thread David Brown
This website hasn't worked for quite some time. Signed-off-by: David Brown Cc: Matt Dharm --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 82ad0eabce4f..0dbba14128e4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -14142,7 +14142,6 @@ M: Alan

Re: r8152: data corruption in various scenarios

2019-01-07 Thread Mark Lord
On 2019-01-07 1:27 p.m., mario.limoncie...@dell.com wrote: .. > The xHCI overrun workaround should only be applied on TB16/TB16, correct. > > Can you double check the verbose information from lsusb for the r8153 device > on your WD15? Sure, see below for the full output. > If it's the same infor

Re: [PATCH 2/4] usb: musb: jz4740: Add support for devicetree

2019-01-07 Thread Bin Liu
Hi, On Thu, Dec 13, 2018 at 03:45:53PM +0100, Paul Cercueil wrote: > Add support for probing the driver from devicetree. > > Signed-off-by: Paul Cercueil > --- > drivers/usb/musb/jz4740.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/usb/musb/jz4740.c b/drivers/usb/mu

Re: [PATCH 3/4] usb: musb: jz4740: Drop dependency on MACH_JZ4740, use COMPILE_TEST

2019-01-07 Thread Bin Liu
Hi, Please use the following subject instead. usb: musb: Kconfig: Drop dependency on MACH_JZ4740 and use COMPILE_TEST for jz4740 On Thu, Dec 13, 2018 at 03:45:54PM +0100, Paul Cercueil wrote: > Depending on MACH_INGENIC prevent us from creating a generic kernel that did you mea

Re: [PATCH 4/4] usb: musb: jz4740: Drop dependency on USB_OTG_BLACKLIST_HUB

2019-01-07 Thread Bin Liu
Hi, Please use the following subject instead. usb: musb: Kconfig: Drop dependency on USB_OTG_BLACKLIST_HUB for jz4740 Regards, -Bin. On Thu, Dec 13, 2018 at 03:45:55PM +0100, Paul Cercueil wrote: > The USB IP in the JZ4740 SoC does not support host mode, only gadget > mode. > > Signed-

Re: [PATCH] USB: musb: fix indentation issue on a return statement

2019-01-07 Thread Bin Liu
Hi, On Fri, Jan 04, 2019 at 05:59:41PM +, Colin King wrote: > From: Colin Ian King > > A return statement is indented one level too far, fix this by removing > a tab. > > Signed-off-by: Colin Ian King > --- > drivers/usb/musb/musb_host.c | 2 +- > 1 file changed, 1 insertion(+), 1 deleti

Re: [PATCH 1/2] dt-bindings: Add Qualcomm USB Super-Speed PHY bindings

2019-01-07 Thread Jack Pham
Hi Jorge, Sorry for the late reply as I was out during the holiday break. On Fri, Dec 28, 2018 at 01:38:59PM +0100, Jorge Ramirez wrote: > On 12/20/18 18:37, Jack Pham wrote: > >Hi Rob, Jorge, > > > >On Thu, Dec 20, 2018 at 11:05:31AM -0600, Rob Herring wrote: > >>On Fri, Dec 07, 2018 at 10:55:57

Re: [PATCH 1/2] dt-bindings: Add Qualcomm USB Super-Speed PHY bindings

2019-01-07 Thread Andy Gross
On Mon, 7 Jan 2019 at 14:26, Jack Pham wrote: > > Hi Jorge, > > Sorry for the late reply as I was out during the holiday break. > > On Fri, Dec 28, 2018 at 01:38:59PM +0100, Jorge Ramirez wrote: > > On 12/20/18 18:37, Jack Pham wrote: > > >Hi Rob, Jorge, > > > > > >On Thu, Dec 20, 2018 at 11:05:31

Re: [PATCH 1/4] dt-bindings: usb: musb: Add support for MediaTek musb controller

2019-01-07 Thread Bin Liu
Hi, On Thu, Dec 27, 2018 at 03:34:23PM +0800, min@mediatek.com wrote: > From: Min Guo > > This adds support for MediaTek musb controller in > host, peripheral and otg mode > > Signed-off-by: Min Guo > --- > .../devicetree/bindings/usb/mediatek,musb.txt | 49 > ++

[PATCH V3] usb:xhci: Fix for Enabling USB ROLE SWITCH QUIRK on INTEL_SUNRISEPOINT_LP_XHCI

2019-01-07 Thread m . balaji
From: Balaji Manoharan This fix enables USB role feature on intel commercial nuc platform which is based on Kabylake chipset. Signed-off-by: Balaji Manoharan --- Changes from v2: changed initals to full name Changes from v1: changed patch subject from roles: to usb:xhci drivers/usb/host/xhci

Re: [PATCH v3] usb: hub: add retry routine after intr URB submit error

2019-01-07 Thread Oliver Neukum
On Mo, 2019-01-07 at 13:59 -0500, Alan Stern wrote: > On Mon, 7 Jan 2019, Greg KH wrote: > > > > What ever happened to this patch? Is it still needed? Oliver and Alan, > > any objections about it anymore? > > I have just one very minor nit to pick (see below). Mostly I've been > waiting to he

Re: [PATCH 1/4] dt-bindings: usb: musb: Add support for MediaTek musb controller

2019-01-07 Thread Min Guo
On Mon, 2019-01-07 at 14:40 -0600, Bin Liu wrote: > Hi, > > On Thu, Dec 27, 2018 at 03:34:23PM +0800, min@mediatek.com wrote: > > From: Min Guo > > > > This adds support for MediaTek musb controller in > > host, peripheral and otg mode > > > > Signed-off-by: Min Guo > > --- > > .../device

Re: [PATCH] usb: gadget: musb: fix short isoc packets with inventra dma for pandaboard es

2019-01-07 Thread Paul Elder
Hi Bin, On Mon, Jan 07, 2019 at 01:11:57PM -0600, Bin Liu wrote: > Hi Paul, > > Sorry for the delay on reviewing it. Thanks for the review. > For the subject, can you please use > > usb: musb: gadget: fix short isoc packets with inventra dma ack > On Tue, Oct 09, 2018 at 02:32:20AM -04

Re: [PATCH v4 5/6] usb: musb: gadget: implement optional explicit status stage

2019-01-07 Thread Paul Elder
On Sun, Jan 06, 2019 at 03:03:09PM -0500, Alan Stern wrote: > On Sun, 6 Jan 2019, Paul Elder wrote: > > > Implement the mechanism for optional explicit status stage for the MUSB > > driver. This allows a function driver to specify what to reply for the > > status stage. The functionality for an im

[PATCH 1/3] usb: kconfig: remove dependency FSL_SOC for ehci fsl driver

2019-01-07 Thread Ran Wang
From: Rajesh Bhagat CONFIG_USB_EHCI_FSL is not dependent on FSL_SOC, it can be built on non-PPC platforms. Signed-off-by: Rajesh Bhagat Signed-off-by: Ran Wang --- drivers/usb/host/Kconfig |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/Kconfig b/d

[PATCH 2/3] usb: ehci: fsl: Update register accessing for arm/arm64 platforms

2019-01-07 Thread Ran Wang
arm/arm64's io.h doesn't define clrbits32() and clrsetbits_be32(), which causing compile failure on some Layerscape Platforms (such as LS1021A and LS2012A which also integrates FSL EHCI controller). So use ioread32be()/iowrite32be() instead to make it workable on both powerpc and arm. Signed-off-b

[PATCH 3/3] drivers: usb :fsl: Remove USB Errata checking code

2019-01-07 Thread Ran Wang
From: yinbo.zhu Remove USB errata checking code from driver. Applicability of erratum is retrieved by reading corresponding property in device tree. This property is written during device tree fixup. Signed-off-by: Ramneek Mehresh Signed-off-by: Nikhil Badola Signed-off-by: yinbo.zhu Signed-o

Re: [PATCH v4] USB: Don't enable LPM if it's already enabled

2019-01-07 Thread Kai Heng Feng
> On Jan 8, 2019, at 00:16, Greg KH wrote: > > On Mon, Dec 03, 2018 at 06:26:43PM +0800, Kai-Heng Feng wrote: >> USB Bluetooth controller QCA ROME (0cf3:e007) sometimes stops working >> after S3: >> [ 165.110742] Bluetooth: hci0: using NVM file: qca/nvm_usb_0302.bin >> [ 168.432065] Blueto