Re: kernel: xhci_hcd 0000:00:14.0: ERROR unknown event type 37 - Kernel 4.19.13

2019-01-02 Thread Nathan Royce
...But then again, maybe it wasn't the cable. It's acting up again. On Tue, Jan 1, 2019 at 3:14 PM Nathan Royce wrote: > > Looks like this particular issue may have been due to a touchy/finicky > connection. > > I removed my tuner from my hub and removed the hub from my > motherboard's USB and pu

Re: [PATCH] xhci-pci: don't enable runtime PM for Alpine Ridge on Maximus VIII Impact

2019-01-02 Thread Mathias Nyman
On 30.12.2018 18:34, Philip Langdale wrote: This fixes a regression since: 2815ef7fe4d43072b9eda448d04fbc184f2aa513 This motherboard is a strange beast, with an Alpine Ridge thunderbolt controller configured to only do USB with no actual thunderbolt capabilities (Apparently due to the wiring not

Re: kernel: xhci_hcd 0000:00:14.0: ERROR unknown event type 37 - Kernel 4.19.13

2019-01-02 Thread Mathias Nyman
On 01.01.2019 20:57, Nathan Royce wrote: Kernel 4.19.13 00:14.0 USB controller: Intel Corporation 9 Series Chipset Family USB xHCI Controller Around 400 "unknown event type 37" messages logged in a 2 second span. * Jan 01 02:08:07 computername tvheadend[2370]: linuxdvb: Auvitek AU8522 QAM/8

[PATCH] Add USB_QUIRK_DELAY_CTRL_MSG quirk for Corsair K70 RGB

2019-01-02 Thread Jack Stocker
To match the Corsair Strafe RGB, the Corsair K70 RGB also requires USB_QUIRK_DELAY_CTRL_MSG to completely resolve boot connection issues discussed here: https://github.com/ckb-next/ckb-next/issues/42. Otherwise roughly 1 in 10 boots the keyboard will fail to be detected. Signed-off-by: Jack Stocke

Re: [PATCH] Add USB_QUIRK_DELAY_CTRL_MSG quirk for Corsair K70 RGB

2019-01-02 Thread Danilo Krummrich
You're referring to this patch cb88a0588717 ("usb: quirks: add control message delay for 1b1c:1b20") I guess. Maybe you want to name it explicitly for better reference. Acked-by: Danilo Krummrich On 2019-01-02 19:37, Jack Stocker wrote: To match the Corsair Strafe RGB, the Corsair K70 RGB als

[PATCH 02/19] usbnet: smsc95xx: Stop propagation of in_pm

2019-01-02 Thread Marek Vasut
The information whether the SMSC95xx is in_pm or not can be derived from the usbdev->suspend_count. First thing called in smsc95xx_suspend() is usbnet_suspend(), which increments the usbdev->suspend_count and since then the driver only calls _nopm() functions and functions with in_pm set to 1. The

[PATCH 08/19] usbnet: smsc95xx: Register MII bus

2019-01-02 Thread Marek Vasut
Register MII bus so that a phydev can attach to it. This works in parallel with the existing MII bus accessors within the driver, however the existing accessors will be removed in subsequent patch. Signed-off-by: Marek Vasut Cc: David S. Miller Cc: Nisar Sayed Cc: Woojung Huh Cc: Andrew Lunn

[PATCH 19/19] usbnet: smsc95xx: Use phy bit operations

2019-01-02 Thread Marek Vasut
Use bit operations provided by bit.h instead of reimplementing them. No functional change. Signed-off-by: Marek Vasut Cc: David S. Miller Cc: Nisar Sayed Cc: Woojung Huh Cc: Andrew Lunn Cc: Florian Fainelli Cc: linux-usb@vger.kernel.org To: net...@vger.kernel.org --- drivers/net/usb/smsc95x

[PATCH 13/19] usbnet: smsc95xx: Replace smsc95xx_link_ok_nopm()

2019-01-02 Thread Marek Vasut
Replace the function with genphy_update_link(), since that's really all that it is. Signed-off-by: Marek Vasut Cc: David S. Miller Cc: Nisar Sayed Cc: Woojung Huh Cc: Andrew Lunn Cc: Florian Fainelli Cc: linux-usb@vger.kernel.org To: net...@vger.kernel.org --- drivers/net/usb/smsc95xx.c | 1

[PATCH 17/19] usbnet: smsc95xx: Replace generic_mii_ioctl()

2019-01-02 Thread Marek Vasut
Replace generic_mii_ioctl() with phydev compatible phy_mii_ioctl(). Signed-off-by: Marek Vasut Cc: David S. Miller Cc: Nisar Sayed Cc: Woojung Huh Cc: Andrew Lunn Cc: Florian Fainelli Cc: linux-usb@vger.kernel.org To: net...@vger.kernel.org --- drivers/net/usb/smsc95xx.c | 3 ++- 1 file cha

[PATCH 16/19] usbnet: smsc95xx: Replace mii_check_media()

2019-01-02 Thread Marek Vasut
The mii_check_media() is called to read out the PHY status registers and update the internal status reported by mii_ethtool_gset(), just replace it with phydev compatible phy_read_status(). Signed-off-by: Marek Vasut Cc: David S. Miller Cc: Nisar Sayed Cc: Woojung Huh Cc: Andrew Lunn Cc: Flor

[PATCH 11/19] usbnet: smsc95xx: Replace smsc95xx_mdio_write() with phy_write()

2019-01-02 Thread Marek Vasut
Just replace smsc95xx_mdio_write() with generic phy_write() to reduce usage of the ad-hoc accessors. Signed-off-by: Marek Vasut Cc: David S. Miller Cc: Nisar Sayed Cc: Woojung Huh Cc: Andrew Lunn Cc: Florian Fainelli Cc: linux-usb@vger.kernel.org To: net...@vger.kernel.org --- drivers/net/u

[PATCH 14/19] usbnet: smsc95xx: Replace mii_nway_restart()

2019-01-02 Thread Marek Vasut
This is in fact genphy_restart_aneg(), just use the generic phydev function. Signed-off-by: Marek Vasut Cc: David S. Miller Cc: Nisar Sayed Cc: Woojung Huh Cc: Andrew Lunn Cc: Florian Fainelli Cc: linux-usb@vger.kernel.org To: net...@vger.kernel.org --- drivers/net/usb/smsc95xx.c | 5 -

[PATCH 10/19] usbnet: smsc95xx: Replace smsc95xx_mdio_read() with phy_read()

2019-01-02 Thread Marek Vasut
Just replace smsc95xx_mdio_read() with generic phy_read() to reduce usage of the ad-hoc accessors. Signed-off-by: Marek Vasut Cc: David S. Miller Cc: Nisar Sayed Cc: Woojung Huh Cc: Andrew Lunn Cc: Florian Fainelli Cc: linux-usb@vger.kernel.org To: net...@vger.kernel.org --- drivers/net/usb

[PATCH 07/19] usbnet: smsc95xx: Split the reset function

2019-01-02 Thread Marek Vasut
The smsc95xx_reset() is called either during bind or later during the driver operation. However, the MII structure can be populated only once, when the smsc95xx_reset() is called from the drivers bind function. Split the reset function to allow filling the MII structure only once. This is done in

[PATCH 03/19] usbnet: smsc95xx: Remove smsc95xx_{read,write}_reg_nopm()

2019-01-02 Thread Marek Vasut
These functions are now equal to smsc95xx_{read,write}_reg(), deduplicate them. Signed-off-by: Marek Vasut Cc: David S. Miller Cc: Nisar Sayed Cc: Woojung Huh Cc: Andrew Lunn Cc: Florian Fainelli Cc: linux-usb@vger.kernel.org To: net...@vger.kernel.org --- drivers/net/usb/smsc95xx.c | 78 ++

[PATCH 05/19] usbnet: smsc95xx: Remove smsc95xx_{read,write}_nopm()

2019-01-02 Thread Marek Vasut
These functions are now equal to smsc95xx_mdio_{read,write}(), deduplicate them. Signed-off-by: Marek Vasut Cc: David S. Miller Cc: Nisar Sayed Cc: Woojung Huh Cc: Andrew Lunn Cc: Florian Fainelli Cc: linux-usb@vger.kernel.org To: net...@vger.kernel.org --- drivers/net/usb/smsc95xx.c | 30 +

[PATCH 04/19] usbnet: smsc95xx: Remove __smsc95xx_{read,write}_reg()

2019-01-02 Thread Marek Vasut
Inline those functions into smsc95xx_{read,write}_reg() to get rid of the wrapper. Signed-off-by: Marek Vasut Cc: David S. Miller Cc: Nisar Sayed Cc: Woojung Huh Cc: Andrew Lunn Cc: Florian Fainelli Cc: linux-usb@vger.kernel.org To: net...@vger.kernel.org --- drivers/net/usb/smsc95xx.c | 32

[PATCH 06/19] usbnet: smsc95xx: Remove __smsc95xx_mdio_{read,write}()

2019-01-02 Thread Marek Vasut
Inline those functions into smsc95xx_mdio_{read,write}() to get rid of the wrapper. Signed-off-by: Marek Vasut Cc: David S. Miller Cc: Nisar Sayed Cc: Woojung Huh Cc: Andrew Lunn Cc: Florian Fainelli Cc: linux-usb@vger.kernel.org To: net...@vger.kernel.org --- drivers/net/usb/smsc95xx.c | 1

[PATCH 01/19] usbnet: smsc95xx: Fix memory leak in smsc95xx_bind

2019-01-02 Thread Marek Vasut
In case reading of PHY register fails in smsc95xx_bind(), the private data allocated earlier are not free()d. Free them before bailing out. Signed-off-by: Marek Vasut Cc: David S. Miller Cc: Nisar Sayed Cc: Woojung Huh Cc: Andrew Lunn Cc: Florian Fainelli Cc: linux-usb@vger.kernel.org To: ne

[PATCH 00/19] usbnet: smsc95xx: Convert to phydev

2019-01-02 Thread Marek Vasut
This series first cleans up the in_pm variable and _nopm() functions, in preparations for conversion to phy_device instead of ad-hoc PHY configuration. This is followed by a registration of an MDIO bus, attaching a PHY device to it and conversion and cleanup of assorted functions to use the new PH

[PATCH 18/19] usbnet: smsc95xx: Remove all of the carrier checking code

2019-01-02 Thread Marek Vasut
The carrier checking code is completely handled by the internal phydev state machine, remove it. Signed-off-by: Marek Vasut Cc: David S. Miller Cc: Nisar Sayed Cc: Woojung Huh Cc: Andrew Lunn Cc: Florian Fainelli Cc: linux-usb@vger.kernel.org To: net...@vger.kernel.org --- drivers/net/usb/s

[PATCH 12/19] usbnet: smsc95xx: Replace ad-hoc PHY functions with generic ones

2019-01-02 Thread Marek Vasut
Replace the ad-hoc reimplementation of genphy_soft_reset() and genphy_config_aneg() with the generic functions. Signed-off-by: Marek Vasut Cc: David S. Miller Cc: Nisar Sayed Cc: Woojung Huh Cc: Andrew Lunn Cc: Florian Fainelli Cc: linux-usb@vger.kernel.org To: net...@vger.kernel.org --- dr

[PATCH 09/19] usbnet: smsc95xx: Connect to phydev

2019-01-02 Thread Marek Vasut
Add code to detect and connect to PHY. The internal PHY of the SMSC95xx is a regular SMSC LAN8700 and the driver only supports the internal PHY, so just use the SMSC PHY driver to configure the PHY. Note that the driver does a lot of extra configuration of the PHY, which is left in to avoid breakag

[PATCH 15/19] usbnet: smsc95xx: Replace mii_ethtool_gset()

2019-01-02 Thread Marek Vasut
Replace mii_ethtool_gset() with a phydev compatible function and update the code to match. Signed-off-by: Marek Vasut Cc: David S. Miller Cc: Nisar Sayed Cc: Woojung Huh Cc: Andrew Lunn Cc: Florian Fainelli Cc: linux-usb@vger.kernel.org To: net...@vger.kernel.org --- drivers/net/usb/smsc95x

[PATCH v2 0/2] USB Storage quirk for SMI SM3350

2019-01-02 Thread Icenowy Zheng
SMI SM3350 UFS-USB bridge controller cannot handle REQUEST SENSE command with long sense (96-bytes) well, and will even trap the controller into a state that refuses to do read/write command. Currently Linux uncondintionally set US_FL_SANE_SENSE for devices claiming SPC3+, which makes simply add U

[PATCH v2 2/2] USB: storage: add quirk for SMI SM3350

2019-01-02 Thread Icenowy Zheng
The SMI SM3350 USB-UFS bridge controller cannot handle long sense request correctly and will make the chip refuse to do read/write when requested long sense. Add a bad sense quirk for it. Signed-off-by: Icenowy Zheng --- drivers/usb/storage/unusual_devs.h | 12 1 file changed, 12 i

[PATCH v2 1/2] USB: storage: don't insert sane sense for SPC3+ when bad sense specified

2019-01-02 Thread Icenowy Zheng
Currently the code will set US_FL_SANE_SENSE flag unconditionally if device claims SPC3+, however we should allow US_FL_BAD_SENSE flag to prevent this behavior, because SMI SM3350 UFS-USB bridge controller, which claims SPC4, will show strange behavior with 96-byte sense (put the chip into a wrong

Re: [PATCH] xhci-pci: don't enable runtime PM for Alpine Ridge on Maximus VIII Impact

2019-01-02 Thread Philip Langdale
On Wed, 2 Jan 2019 13:23:51 +0200 Mathias Nyman wrote: > On 30.12.2018 18:34, Philip Langdale wrote: > > This fixes a regression since: > > 2815ef7fe4d43072b9eda448d04fbc184f2aa513 > > > > This motherboard is a strange beast, with an Alpine Ridge > > thunderbolt controller configured to only do