RE: [PATCH v2 5/5] usb:cdns3 Add Cadence USB3 DRD Driver

2018-12-27 Thread Pawel Laszczak
Hi, >> > + >> > + if (ret) >> > + return ret; >> > + >> > + state = readl(&cdns->otg_regs->sts); >> > + if (OTGSTS_OTG_NRDY(state) != 0) { >> > + dev_err(cdns->dev, "Cadence USB3 OTG device not ready\n"); >> > + return -ENODEV; >> > +

Re: SHANWAN pad rumbling not working on USB

2018-12-27 Thread Greg KH
Adding linux-input which is the best list for this... On Thu, Dec 27, 2018 at 09:17:22AM +0800, liquid wrote: > Rumbling function on SHANWAN DS3 clone joystick doesn't work. > Meanwhile it can work fine on Windows ScpToolkit v1.7.277.16103-BETA. > (Tested with PCSX2 lilypad Win32 build). > > SDL2

Fwd: SHANWAN pad rumbling not working on USB

2018-12-27 Thread liquid
It's a PS3 "clone" joystick. Everything works fine EXCEPT rumbling. I think it's related to commit 492ca83c3d19fba1622164f07cd7b775596a7db2 (HID: sony: Fix SHANWAN pad rumbling on USB ) . If I revert this commit, the controller starts to rumble as soon as plugged in, indicated this joystick is, in

Re: SHANWAN pad rumbling not working on USB

2018-12-27 Thread liquid
It's a PS3 "clone" joystick. Everything works fine EXCEPT rumbling. I think it's related to commit 492ca83c3d19fba1622164f07cd7b775596a7db2 (HID: sony: Fix SHANWAN pad rumbling on USB ) . If I revert this commit, the controller starts to rumble as soon as plugged in, indicated this joystick is, in

Re: SHANWAN pad rumbling not working on USB

2018-12-27 Thread Greg KH
On Thu, Dec 27, 2018 at 07:34:25PM +0800, liquid wrote: > It's a PS3 "clone" joystick. Everything works fine EXCEPT rumbling. > > I think it's related to commit > 492ca83c3d19fba1622164f07cd7b775596a7db2 (HID: sony: Fix SHANWAN pad > rumbling on USB ) . If I revert this commit, the controller star

Re: SHANWAN pad rumbling not working on USB

2018-12-27 Thread liquid
I think the problem could be this controller ignoring HID Output Reports. According to drivers/hid/hid-sony.c:1850 line comment, "The Sixaxis on USB will override any LED settings sent to it and keep flashing all of the LEDs until the PS button is pressed", which is exactly my controller behaving o

RE: [PATCH v2 5/5] usb:cdns3 Add Cadence USB3 DRD Driver

2018-12-27 Thread Pawel Laszczak
HI, >> >> The host side of USBSS-DRD controller is compliance >> with XHCI specification, so it works with >> standard XHCI linux driver. >> > >After adding my glue layer change (with my phy part) and make one >change for this code, >the xHCI can work at my platform. I list the comments from today

usb_f_fs is making false assumptions when parsing descriptors

2018-12-27 Thread Harald Welte
Dear Linux USB hackers, I am currently trying to implement a CCID (chip card reader) using usb-configf + usb-functionfs. As per the USB CCID class specification, there's a class-specific functional descriptor that follows the interface descriptor. When trying to send this descriptor from userspa

[PATCH 2/2] USB: storage: add quirk for SMI SM3350

2018-12-27 Thread Icenowy Zheng
The SMI SM3350 USB-UFS bridge controller cannot handle long sense request correctly and will make the chip refuse to do read/write when requested long sense. Add a bad sense quirk for it. Signed-off-by: Icenowy Zheng --- drivers/usb/storage/unusual_devs.h | 12 1 file changed, 12 i

[PATCH 0/2] USB Storage quirk for SMI SM3350

2018-12-27 Thread Icenowy Zheng
SMI SM3350 UFS-USB bridge controller cannot handle REQUEST SENSE command with long sense (96-bytes) well, and will even trap the controller into a state that refuses to do read/write command. Currently Linux uncondintionally set US_FL_SANE_SENSE for devices claiming SPC3+, which makes simply add U

[PATCH 1/2] USB: storage: don't insert sane sense for SPC3+ when bad sense specified

2018-12-27 Thread Icenowy Zheng
Currently the code will set US_FL_SANE_SENSE flag unconditionally if device claims SPC3+, however we should allow US_FL_BAD_SENSE flag to prevent this behavior, because SMI SM3350 UFS-USB bridge controller, which claims SPC4, will show strange behavior with 96-byte sense (put the chip into a wrong

Re: [PATCH 1/2] USB: storage: don't insert sane sense for SPC3+ when bad sense specified

2018-12-27 Thread Icenowy Zheng
在 2018-12-27四的 22:34 +0800,Icenowy Zheng写道: > Currently the code will set US_FL_SANE_SENSE flag unconditionally if > device claims SPC3+, however we should allow US_FL_BAD_SENSE flag to > prevent this behavior, because SMI SM3350 UFS-USB bridge controller, > which claims SPC4, will show strange beh

Re: [PATCH 2/2] USB: storage: add quirk for SMI SM3350

2018-12-27 Thread Icenowy Zheng
在 2018-12-27四的 22:34 +0800,Icenowy Zheng写道: > The SMI SM3350 USB-UFS bridge controller cannot handle long sense > request > correctly and will make the chip refuse to do read/write when > requested > long sense. > > Add a bad sense quirk for it. > > Signed-off-by: Icenowy Zheng > --- I forgot t

Re: [PATCH v1 1/2] dt-bindings: add binding for USBSS-DRD controller.

2018-12-27 Thread Rob Herring
On Sat, Dec 22, 2018 at 4:24 PM Pawel Laszczak wrote: > > Hi Rob, > > >On Mon, Dec 10, 2018 at 12:39:14PM +, Pawel Laszczak wrote: > >> This patch aim at documenting USB related dt-bindings for the > >> Cadence USBSS-DRD controller. > >> > >> Signed-off-by: Pawel Laszczak [...] > >> + - phy

Re: SHANWAN pad rumbling not working on USB

2018-12-27 Thread Roderick Colenbrander
On Thu, Dec 27, 2018 at 10:20 AM Greg KH wrote: > > Adding linux-input which is the best list for this... > > On Thu, Dec 27, 2018 at 09:17:22AM +0800, liquid wrote: > > Rumbling function on SHANWAN DS3 clone joystick doesn't work. > > Meanwhile it can work fine on Windows ScpToolkit v1.7.277.1610

RE: [PATCH v2 5/5] usb:cdns3 Add Cadence USB3 DRD Driver

2018-12-27 Thread Peter Chen
> > > >@@ -299,6 +306,7 @@ int cdns3_drd_init(struct cdns3 *cdns) > >cdns->version = CDNS3_CONTROLLER_V0; > >cdns->otg_v1_regs = NULL; > >cdns->otg_regs = regs; > >+ writel(0x1, &cdns->otg_v0_regs->simulate); > >dev_in

Re: SHANWAN pad rumbling not working on USB

2018-12-27 Thread liquid
I am able to fix this issue by using hid_hw_output_report instead of hid_hw_raw_request in sixaxis_send_output_report(). Now working on a patch...

[PATCH] HID: sony: Fix SHANWAN PS3 GamePad rumbling on USB again

2018-12-27 Thread liquid
>From 6323ffb83e23eab9a08208063f9dba27c6a0d228 Mon Sep 17 00:00:00 2001 From: Hongye Yuan Date: Thu, 27 Dec 2018 09:41:23 +0800 Subject: [PATCH] HID: sony: Fix SHANWAN PS3 GamePad rumbling on USB again - The SHANWAN DS3 clone joystick requires HID Output Reports via Interrupt EP. - Added a quirk

[PATCH] HID: sony: Fix SHANWAN PS3 GamePad rumbling on USB again

2018-12-27 Thread liquid
>From 6323ffb83e23eab9a08208063f9dba27c6a0d228 Mon Sep 17 00:00:00 2001 From: Hongye Yuan Date: Thu, 27 Dec 2018 09:41:23 +0800 Subject: [PATCH] HID: sony: Fix SHANWAN PS3 GamePad rumbling on USB again - The SHANWAN DS3 clone joystick requires HID Output Reports via Interrupt EP. - Added a quirk