Re: [PATCH v3 4/6] usb: gadget: add mechanism to specify an explicit status stage

2018-12-21 Thread Paul Elder
On Wed, Dec 19, 2018 at 11:01:52AM -0500, Alan Stern wrote: > On Wed, 19 Dec 2018, Paul Elder wrote: > > > A usb gadget function driver may or may not want to delay the status > > stage of a control OUT request. An instance it might want to is to > -^ >

Re: Fwd: composite device fails to reset "suspended" flag

2018-12-21 Thread Minas Harutyunyan
Hi, On 12/21/2018 11:17 AM, Felipe Balbi wrote: > > Hi, > > Alan Stern writes: You're using a really old kernel. Please try with v4.19.11 or v4.20-rc7 >>> >>> I have to use an altera patched kernel linux-socfpga to boot my board, >>> and it always lags behind mainline kernel. If I re

USB: serial: option: add Fibocom NL678 series

2018-12-21 Thread Jörgen Storvist
Added USB serial option driver support for Fibocom NL678 series cellular module: VID 2cb7 and PIDs 0x0104 and 0x0105. Reserved network and ADB interfaces. T: Bus=01 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 2 Spd=480 MxCh= 0 D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1 P: Vendor=2cb7

Re: Fwd: composite device fails to reset "suspended" flag

2018-12-21 Thread Frank Mori Hess
On Fri, Dec 21, 2018 at 6:01 AM Minas Harutyunyan wrote: > > According data book Disconnect Interrupt asserted only in Host mode. > Programming guide says for device initialization unmask follow device > specific interrupts: USB reset, Enum Done, Early suspend, Suspend and SOF. > And on device di

Re: USB: serial: option: add Fibocom NL678 series

2018-12-21 Thread Greg KH
On Fri, Dec 21, 2018 at 02:40:44PM +0100, Jörgen Storvist wrote: > Added USB serial option driver support for Fibocom NL678 series cellular > module: VID 2cb7 and PIDs 0x0104 and 0x0105. > Reserved network and ADB interfaces. > > T: Bus=01 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 2 Spd=480 MxCh= 0 >

Re: USB: serial: option: add Fibocom NL678 series

2018-12-21 Thread Johan Hovold
On Fri, Dec 21, 2018 at 02:56:16PM +0100, Greg Kroah-Hartman wrote: > On Fri, Dec 21, 2018 at 02:40:44PM +0100, Jörgen Storvist wrote: > > Added USB serial option driver support for Fibocom NL678 series cellular > > module: VID 2cb7 and PIDs 0x0104 and 0x0105. > > Reserved network and ADB interface

Re: Fwd: composite device fails to reset "suspended" flag

2018-12-21 Thread Frank Mori Hess
> > According data book Disconnect Interrupt asserted only in Host mode. > Programming guide says for device initialization unmask follow device > specific interrupts: USB reset, Enum Done, Early suspend, Suspend and SOF. > And on device disconnect asserted interrupts: > - In OTG_MODE=0,1,3: GOTGIN

Re: XHCI DbC (debug port) problems

2018-12-21 Thread Tj
On 11/12/2018 14:00, Mathias Nyman wrote: >> Any advice or experience as to what we might be missing? > > What does sudo lsusb -v on the host say about the target device? > What's the dbc status on the target? you did enable it right? > (on target,  cat /sys/bus/pci/devices/:00:14.0/dbc) Is t

Re: [PATCH] usb: dwc2: gadget: fix ISOC frame overflow handling

2018-12-21 Thread John Keeping
Hi Minas, On Wed, 19 Dec 2018 14:09:01 + Minas Harutyunyan wrote: > On 12/18/2018 6:35 PM, John Keeping wrote: > > Hi Minas, > > > > On Fri, 14 Dec 2018 09:00:08 + > > Minas Harutyunyan wrote: > >> First of all, sorry for delayed answer. > >> Looks like similar issue seen by Andrzej

Re: USB: serial: option: add Fibocom NL678 series

2018-12-21 Thread Greg KH
On Fri, Dec 21, 2018 at 03:11:43PM +0100, Johan Hovold wrote: > On Fri, Dec 21, 2018 at 02:56:16PM +0100, Greg Kroah-Hartman wrote: > > On Fri, Dec 21, 2018 at 02:40:44PM +0100, Jörgen Storvist wrote: > > > Added USB serial option driver support for Fibocom NL678 series cellular > > > module: VID 2

Re: XHCI DbC (debug port) problems

2018-12-21 Thread Mathias Nyman
On 21.12.2018 17:53, Tj wrote: On 11/12/2018 14:00, Mathias Nyman wrote: Any advice or experience as to what we might be missing? What does sudo lsusb -v on the host say about the target device? What's the dbc status on the target? you did enable it right? (on target,  cat /sys/bus/pci/devices

Re: [PATCH v2 1/4] usb: dwc3: Add property snps,refclk-period-ns

2018-12-21 Thread Rob Herring
On Thu, Dec 20, 2018 at 6:22 PM Thinh Nguyen wrote: > > Hi, > > On 12/19/2018 10:48 PM, Felipe Balbi wrote: > > Hi, > > > > Thinh Nguyen writes: > On 12/18/2018 8:39 AM, Rob Herring wrote: > > On Fri, Dec 07, 2018 at 06:27:30PM -0800, Thinh Nguyen wrote: > >> This patch introduces pr

Re: [PATCH v2 1/4] usb: dwc3: Add property snps,refclk-period-ns

2018-12-21 Thread Thinh Nguyen
Hi, On 12/21/2018 9:12 AM, Rob Herring wrote: > On Thu, Dec 20, 2018 at 6:22 PM Thinh Nguyen > wrote: >> Hi, >> >> On 12/19/2018 10:48 PM, Felipe Balbi wrote: >>> Hi, >>> >>> Thinh Nguyen writes: >> On 12/18/2018 8:39 AM, Rob Herring wrote: >>> On Fri, Dec 07, 2018 at 06:27:30PM -0800,

Re: XHCI DbC (debug port) problems

2018-12-21 Thread Tj
On 21/12/2018 16:37, Mathias Nyman wrote: > On 21.12.2018 17:53, Tj wrote: >> On 11/12/2018 14:00, Mathias Nyman wrote: Any advice or experience as to what we might be missing? >>> >>> What does sudo lsusb -v on the host say about the target device? >>> What's the dbc status on the target? you

[PATCH] usb: gadget: Potential NULL dereference on allocation error

2018-12-21 Thread Dan Carpenter
The source_sink_alloc_func() function is supposed to return error pointers on error. The function is called from usb_get_function() which doesn't check for NULL returns so it would result in an Oops. Of course, in the current kernel, small allocations always succeed so this doesn't affect runtime

[PATCH] usb: dwc3: gadget: Clear req->needs_extra_trb flag on cleanup

2018-12-21 Thread Jack Pham
OUT endpoint requests may somtimes have this flag set when preparing to be submitted to HW indicating that there is an additional TRB chained to the request for alignment purposes. If that request is removed before the controller can execute the transfer (e.g. ep_dequeue/ep_disable), the request wi