Re: [PATCH drivers\usb\serial\pl2303.c & pl2303.h] Prolific's PL2303G: new USB to UART chip

2018-12-06 Thread Greg KH
On Thu, Dec 06, 2018 at 03:47:46PM +0800, Charles Yeh wrote: > Hi Greg, > The patch file: diffpl2303.patch is attached.. > Please you kindly check... Please fix up the patch to look like all other patches on this mailing list. You do not need the huge comment in the file, that should be in the

[balbi-usb:testing/next 50/50] drivers/usb/dwc3/./trace.h:216:449: warning: 's' may be used uninitialized in this function

2018-12-06 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git testing/next head: ad7b607f82731eec3ed17d9d22764eb6f09609f9 commit: ad7b607f82731eec3ed17d9d22764eb6f09609f9 [50/50] usb: dwc3: trace: add missing break statement to make compiler happy config: i386-allyesconfig (attached as

Re: [PATCH] dma: cppi41: delete channel from pending list when stop channel

2018-12-06 Thread Bin Liu
Peter, On Wed, Nov 28, 2018 at 01:16:32PM +0200, Peter Ujfalusi wrote: > Hi, > > On 28/11/2018 13.15, Peter Ujfalusi wrote: > > forgot to fix up Vinod's email address. > > > > > > > On 12/11/2018 17.40, Bin Liu wrote: > > > > Can you fix up the subject line to: > > dmaengine: ti: cppi4: dele

Re: [PATCH] USB: qcaux: Add Motorola modem UARTs

2018-12-06 Thread Tony Lindgren
Hi, * Johan Hovold [181206 06:00]: > On Wed, Dec 05, 2018 at 05:54:07PM -0800, Tony Lindgren wrote: ... > > idVendor 0x22b8 > > idProduct 0x4281 > > This PID is not included in your patch however. Oops sorry did a cat on wrong two trimmed lsusb -v output files.. > And

Re: [PATCH] USB: qcaux: Add Motorola modem UARTs

2018-12-06 Thread Tony Lindgren
* Tony Lindgren [181206 07:48]: > * Johan Hovold [181206 06:00]: > > How do switch modes by the way? > > The flash mode gets enabled with the control GPIOs. I just > did a quick test patch for phy-mapphone-mdm6600 using module > param for that. Then additionally the modem USB can be > multiplexe

[GIT PULL] USB-serial fix for v4.20-rc6

2018-12-06 Thread Johan Hovold
The following changes since commit 2595646791c319cadfdbf271563aac97d0843dc7: Linux 4.20-rc5 (2018-12-02 15:07:55 -0800) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git tags/usb-serial-4.20-rc6 for you to fetch changes up to f51cc

Re: [GIT PULL] USB-serial fix for v4.20-rc6

2018-12-06 Thread Greg Kroah-Hartman
On Thu, Dec 06, 2018 at 05:33:46PM +0100, Johan Hovold wrote: > The following changes since commit 2595646791c319cadfdbf271563aac97d0843dc7: > > Linux 4.20-rc5 (2018-12-02 15:07:55 -0800) > > are available in the Git repository at: > > https://git.kernel.org/pub/scm/linux/kernel/git/johan/us

[PATCH] Revert "usb: dwc3: pci: Use devm functions to get the phy GPIOs"

2018-12-06 Thread Stephan Gerhold
Commit 211f658b7b40 ("usb: dwc3: pci: Use devm functions to get the phy GPIOs") changed the code to claim the PHY GPIOs permanently for Intel Baytrail devices. This causes issues when the actual PHY driver attempts to claim the same GPIO descriptors. For example, tusb1210 now fails to probe with:

[PATCH -next] usb: mtu3: fix dbginfo in qmu_tx_zlp_error_handler

2018-12-06 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/usb/mtu3/mtu3_qmu.c: In function 'qmu_tx_zlp_error_handler': drivers/usb/mtu3/mtu3_qmu.c:385:22: warning: variable 'req' set but not used [-Wunused-but-set-variable] It seems dbginfo original intention is print 'req' other than 'mreq' Signe

Re: [PATCH -next] usb: mtu3: fix dbginfo in qmu_tx_zlp_error_handler

2018-12-06 Thread Chunfeng Yun
Hi Haibing, On Fri, 2018-12-07 at 03:52 +, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/usb/mtu3/mtu3_qmu.c: In function 'qmu_tx_zlp_error_handler': > drivers/usb/mtu3/mtu3_qmu.c:385:22: warning: > variable 'req' set but not used [-Wunused-but-set-variable]

Re: [balbi-usb:testing/next 50/50] drivers/usb/dwc3/./trace.h:216:449: warning: 's' may be used uninitialized in this function

2018-12-06 Thread Felipe Balbi
Hi, kbuild test robot writes: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git > testing/next > head: ad7b607f82731eec3ed17d9d22764eb6f09609f9 > commit: ad7b607f82731eec3ed17d9d22764eb6f09609f9 [50/50] usb: dwc3: trace: > add missing break statement to make compiler

Re: [PATCH v3 2/2] usb: dwc3: gadget: Report isoc transfer frame number

2018-12-06 Thread Felipe Balbi
Hi, Thinh Nguyen writes: >>> diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c >>> index 679c12e14522..2de563124fc1 100644 >>> --- a/drivers/usb/dwc3/gadget.c >>> +++ b/drivers/usb/dwc3/gadget.c >>> @@ -2254,6 +2254,19 @@ static int >>> dwc3_gadget_ep_reclaim_completed_trb(struc

Re: [PATCH 0/5 v7] Keep rtsx_usb suspended when there's no card

2018-12-06 Thread Ulf Hansson
On Fri, 23 Nov 2018 at 13:21, Ulf Hansson wrote: > > On Fri, 23 Nov 2018 at 07:06, Kai Heng Feng > wrote: > > > > Hi Ulf, > > > > > On Nov 8, 2018, at 8:17 PM, Oleksandr Natalenko > > > wrote: > > > > > >> This is based on Ulf's work [1] [2]. > > >> This patch series can keep rtsx_usb suspende

RE: [RFC PATCH v2 04/15] usb:cdns3: Driver initialization code.

2018-12-06 Thread Pawel Laszczak
Hi, >On 04/12/18 10:50, Peter Chen wrote: + * Cadence USBSS DRD Driver. + * + * Copyright (C) 2018 Cadence. + * + * Author: Peter Chen + * Pawel Laszczak + */ + +#include +#include +#include +#include +#include +#

RE: [RFC PATCH v2 04/15] usb:cdns3: Driver initialization code.

2018-12-06 Thread Pawel Laszczak
Hi, >>> > + >>> > +static inline void cdns3_role_stop(struct cdns3 *cdns) >>> > +{ >>> > + enum cdns3_roles role = cdns->role; >>> > + >>> > + if (role == CDNS3_ROLE_END) >>> >>> WARN_ON(role >= CNDS3_ROLE_END) ? >>> >>> > + return; >>> > + >>> > + mutex_lock(&cdns->mutex);

RE: [RFC PATCH v2 03/15] dt-bindings: add binding for USBSS-DRD controller.

2018-12-06 Thread Pawel Laszczak
Hi, >On Sun, Nov 18, 2018 at 10:08:59AM +, Pawel Laszczak wrote: >> Thsi patch aim at documenting USB related dt-bindings for the > >typo > >> Cadence USBSS-DRD controller. >> >> Signed-off-by: Pawel Laszczak >> --- >> .../devicetree/bindings/usb/cdns3-usb.txt | 17 + >>

Re: [PATCH 2/3] dt-bindings: usb: keystone-usb: Add ti,am654-dwc3 support

2018-12-06 Thread Vignesh R
Hi Roger, On 05/12/18 8:49 PM, Roger Quadros wrote: > The AM654 SoC from TI contains a DWC3 controller. Add > support for it. > > Signed-off-by: Roger Quadros > --- > Documentation/devicetree/bindings/usb/keystone-usb.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --g

Re: [PATCH] usb: dwc2: Disable power down feature on Samsung SoCs

2018-12-06 Thread Marek Szyprowski
Hi Artur, On 2018-12-04 15:28, Artur Petrosyan wrote: > On 11/20/2018 19:38, Marek Szyprowski wrote: >> Power down feature of DWC2 module integrated in Samsung SoCs doesn't work >> properly or needs some additional handling in PHY or SoC glue layer, so >> disable it for now. Without disabling powe

Re: [PATCH] usb: dwc2: Revert "usb: dwc2: Disable all EP's on disconnect"

2018-12-06 Thread Dan Carpenter
Hi Marek, I'm surprised you don't get deadlocks when you apply this patch. On Wed, Nov 21, 2018 at 04:45:04PM +0100, Marek Szyprowski wrote: > @@ -4020,9 +4008,7 @@ static int dwc2_hsotg_ep_disable(struct usb_ep *ep) > > epctrl_reg = dir_in ? DIEPCTL(index) : DOEPCTL(index); > > -

Re: [PATCH] usb: dwc2: Revert "usb: dwc2: Disable all EP's on disconnect"

2018-12-06 Thread Marek Szyprowski
Dear Minas, On 2018-12-04 13:34, Minas Harutyunyan wrote: > On 11/23/2018 6:43 PM, Dan Carpenter wrote: >> Ugh... We also had a long thread about the v2 patch but it turns out >> the list was not CC'd. I should have checked for that. >> >> You have to pass a flag to say if the caller holds the l

Re: [PATCH] usb: dwc2: Revert "usb: dwc2: Disable all EP's on disconnect"

2018-12-06 Thread Marek Szyprowski
Hi Dan, On 2018-12-06 15:52, Dan Carpenter wrote: > Hi Marek, > > I'm surprised you don't get deadlocks when you apply this patch. Why should I get it? It is just a revert to the state before applying the mentioned incorrect patch. > On Wed, Nov 21, 2018 at 04:45:04PM +0100, Marek Szyprowski wro

Re: [PATCH] usb: typec: tcpm: Extend the matching rules on PPS APDO selection

2018-12-06 Thread Guenter Roeck
On Thu, Dec 06, 2018 at 11:02:27AM +0800, Kyle Tso wrote: > Current matching rules ensure that the voltage range of selected Source > Capability is entirely within the range defined in one of the Sink > Capabilities. This is reasonable but not practical because Sink may not > support wide range of

RE: [PATCH] usb: dwc2: Revert "usb: dwc2: Disable all EP's on disconnect"

2018-12-06 Thread Maynard CABIENTE
Hi Minas, I tried your new patch on top of the other 2 patches for a couple of days now and I do not see the issue that Marek encountered. Of course, I did not see it also on the original two patches you created. I also do not see the original FIFO map warning issue that I have with all 3 patch

[PATCH -next] USB: serial: mos7840: remove set but not used variables 'number, serial'

2018-12-06 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/usb/serial/mos7840.c: In function 'mos7840_send_cmd_write_baud_rate': drivers/usb/serial/mos7840.c:1584:16: warning: variable 'number' set but not used [-Wunused-but-set-variable] drivers/usb/serial/mos7840.c: In function 'mos7840_change_por

RE: [PATCH v7 01/10] usb: gadget: udc: Add timer support for usb requests

2018-12-06 Thread Felipe Balbi
hi, Anurag Kumar Vulisha writes: >>Does the data book suggest a value for the timeout? >> > > No, the databook doesn't mention about the timeout value > >>> >At this point, it seems that the generic approach will be messier than >>> >having every >>> >controller driver implement its own fix.

RE: [PATCH v7 09/10] usb: dwc3: Check for IOC/LST bit in both event->status and TRB->ctrl fields

2018-12-06 Thread Felipe Balbi
Hi, Anurag Kumar Vulisha writes: >>> @@ -2286,7 +2286,12 @@ static int >>dwc3_gadget_ep_reclaim_completed_trb(struct dwc3_ep *dep, >>> if (event->status & DEPEVT_STATUS_SHORT && !chain) >>> return 1; >>> >>> - if (event->status & (DEPEVT_STATUS_IOC | DEPEVT_STATUS_LST)) >>> +