Re: [PATCH v3 4/4] doc: usb: ci-hdrc-usb2: Add pinctrl properties for HSIC pin groups

2018-12-05 Thread Schrempf Frieder
On 05.12.18 08:45, Schrempf Frieder wrote: > Hi Fabio, > > On 04.12.18 21:01, Fabio Estevam wrote: >> Hi Frieder, >> >> On Tue, Dec 4, 2018 at 12:31 PM Schrempf Frieder >> wrote: >> >>> There are many other optional properties for this driver and a lot of >>> them are not in the given example. Ma

Re: [PATCH] dma: cppi41: delete channel from pending list when stop channel

2018-12-05 Thread Vinod Koul
On 28-11-18, 13:15, Peter Ujfalusi wrote: > > > On 12/11/2018 17.40, Bin Liu wrote: > > Can you fix up the subject line to: > dmaengine: ti: cppi4: delete channel from pending list when stop channel > > > The driver defines three states for a cppi channel. > > - idle: .chan_busy == 0 && not in

Re: [PATCH v1] usb: dwc3: trace: Refactor nested switch to make compiler happy

2018-12-05 Thread Felipe Balbi
Andy Shevchenko writes: > The missed break statement in the outer switch makes the code fall through > always and thus always same value will be printed. > > Besides that, compiler warns about missed fall through marker: > > drivers/usb/dwc3/./trace.h: In function ‘trace_raw_output_dwc3_log_trb’:

Re: [PATCH v3 2/2] usb: dwc3: gadget: Report isoc transfer frame number

2018-12-05 Thread Felipe Balbi
Hi, Thinh Nguyen writes: > Implement the new frame_number API to report the isochronous interval > frame number. This patch checks and reports the interval in which the > isoc transfer was transmitted or received via the Isoc-First TRB SOF > number field. > > Signed-off-by: Thinh Nguyen > --- >

Re: [PATCH v1] usb: dwc3: trace: Refactor nested switch to make compiler happy

2018-12-05 Thread Andy Shevchenko
On Wed, Dec 05, 2018 at 11:10:46AM +0200, Felipe Balbi wrote: > Andy Shevchenko writes: > > > The missed break statement in the outer switch makes the code fall through > > always and thus always same value will be printed. > > > > Besides that, compiler warns about missed fall through marker: >

Re: [PATCH v2 1/3] staging: typec: fusb302: Rename fcs,extcon-name to linux,extcon-name

2018-12-05 Thread Greg Kroah-Hartman
On Mon, Dec 03, 2018 at 09:23:44PM +0200, Andy Shevchenko wrote: > On Thu, Nov 15, 2018 at 04:53:03PM +0200, Heikki Krogerus wrote: > > On Thu, Nov 15, 2018 at 03:16:19PM +0200, Andy Shevchenko wrote: > > > Since we are going to use the same in Designware USB 3 driver, > > > rename the property to

Re: [PATCH] USB: quirks: add NO_LPM quirk for Logitech Flare

2018-12-05 Thread Greg KH
On Wed, Nov 28, 2018 at 06:19:31PM -0500, Kyle Williams wrote: > Description: Some USB device / host controller combinations seem to have > problems with Link Power management. In particular it is described that > the combination of a Logitech Flare and other powered devices such as > the Atrus dev

Re: [PATCH v1] usb: dwc3: trace: Refactor nested switch to make compiler happy

2018-12-05 Thread Andy Shevchenko
On Wed, Dec 05, 2018 at 11:18:45AM +0200, Andy Shevchenko wrote: > On Wed, Dec 05, 2018 at 11:10:46AM +0200, Felipe Balbi wrote: > > Andy Shevchenko writes: > > > > > The missed break statement in the outer switch makes the code fall through > > > always and thus always same value will be printed

Re: [PATCH 0/3] Small improvements to the appledisplay driver

2018-12-05 Thread Greg Kroah-Hartman
On Tue, Dec 04, 2018 at 11:43:34PM +0100, alex.theis...@me.com wrote: > With the exception of the first patch I am not entirely sure if my changes are > correct and justified. This is my first contribution and I am equally > satisfied > if someone could point out why my changes are not correct. >

Re: USB driver resets

2018-12-05 Thread Mika Westerberg
Hi, On Tue, Dec 04, 2018 at 04:02:56PM +, Richard van der Hoff wrote: > Mathias, Mika, thanks very much for your help. > > On 04/12/2018 15:09, Mika Westerberg wrote: > > On Tue, Dec 04, 2018 at 04:45:33PM +0200, Mathias Nyman wrote: > > > > On 19/11/2018 15:27, Richard van der Hoff wrote: >

Re: [PATCH v2 1/3] staging: typec: fusb302: Rename fcs,extcon-name to linux,extcon-name

2018-12-05 Thread Andy Shevchenko
On Wed, Dec 05, 2018 at 10:25:36AM +0100, Greg Kroah-Hartman wrote: > On Mon, Dec 03, 2018 at 09:23:44PM +0200, Andy Shevchenko wrote: > > On Thu, Nov 15, 2018 at 04:53:03PM +0200, Heikki Krogerus wrote: > > > FWIW, the series: > > > Reviewed-by: Heikki Krogerus > > > > Greg, can you pick up thi

Re: USB driver resets

2018-12-05 Thread Richard van der Hoff
On 05/12/2018 09:44, Mika Westerberg wrote: On Tue, Dec 04, 2018 at 04:02:56PM +, Richard van der Hoff wrote: Sorry. The system is a Dell XPS13 9350, with an Intel DSL6340 Thunderbolt 3 bridge. The dock is a Plugable UD-CA1 [2]. Also if you have dual boot or similar, do you experience si

Re: [PATCH v1] usb: dwc3: trace: Refactor nested switch to make compiler happy

2018-12-05 Thread Felipe Balbi
Andy Shevchenko writes: > On Wed, Dec 05, 2018 at 11:18:45AM +0200, Andy Shevchenko wrote: >> On Wed, Dec 05, 2018 at 11:10:46AM +0200, Felipe Balbi wrote: >> > Andy Shevchenko writes: >> > >> > > The missed break statement in the outer switch makes the code fall >> > > through >> > > always a

Re: [PATCH v3 4/4] doc: usb: ci-hdrc-usb2: Add pinctrl properties for HSIC pin groups

2018-12-05 Thread Fabio Estevam
On Wed, Dec 5, 2018 at 5:57 AM PETER CHEN wrote: > So, there are two examples at binding-doc, one for normal, one for HSIC? > Fabio, do you > mean that? If DT maintainer agrees it too, I will add it. Yes, I think it will makes things clearer. Thanks

XHCI DbC (debug port) problems

2018-12-05 Thread Tj
I'm assisting in debugging what appears to be a race condition in I2C code [0] on Intel ComputeStick STK1A32SC [1] devices. As part of that effort we were originally using an external USB<>RS232 adapter and "console=ttyUSB0,115200n8" but that can be extremely slow (connected to a real UART port) an

[balbi-usb:testing/next 50/50] drivers/usb/gadget/function/f_fs.c:2198:9: error: too few arguments to function 'ffs_do_single_desc'

2018-12-05 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git testing/next head: 3591a2f3900e0f93dbd246d979ddd939251cac3e commit: 3591a2f3900e0f93dbd246d979ddd939251cac3e [50/50] usb: gadget: f_fs: add the support for alternate interface setting config: arm-omap2plus_defconfig (attached

[PATCH 2/2] xhci: Prevent U1/U2 link pm states if exit latency is too long

2018-12-05 Thread Mathias Nyman
Don't allow USB3 U1 or U2 if the latency to wake up from the U-state reaches the service interval for a periodic endpoint. This is according to xhci 1.1 specification section 4.23.5.2 extra note: "Software shall ensure that a device is prevented from entering a U-state where its worst case exit

[PATCH 1/2] xhci: workaround CSS timeout on AMD SNPS 3.0 xHC

2018-12-05 Thread Mathias Nyman
From: Sandeep Singh Occasionally AMD SNPS 3.0 xHC does not respond to CSS when set, also it does not flag anything on SRE and HCE to point the internal xHC errors on USBSTS register. This stalls the entire system wide suspend and there is no point in stalling just because of xHC CSS is not respon

[PATCH 0/2] xhci fixes for usb-linus

2018-12-05 Thread Mathias Nyman
Hi Greg A couple patches for 4.20. Finally found a reason why devices attached after a high bandwidth USB3 isoc device may fail to enumerate with bandwidth error. Second patch is a quirk for AMD SNPS host specific suspend issue. -Mathias Mathias Nyman (1): xhci: Prevent U1/U2 link pm states

[balbi-usb:testing/next 50/50] drivers/usb/dwc3/./trace.h:239:2: note: in expansion of macro 'TP_printk'

2018-12-05 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git testing/next head: ad7b607f82731eec3ed17d9d22764eb6f09609f9 commit: ad7b607f82731eec3ed17d9d22764eb6f09609f9 [50/50] usb: dwc3: trace: add missing break statement to make compiler happy config: i386-randconfig-x006-12051027 (

Re: [PATCH] USB: qcaux: Add Motorola modem UARTs

2018-12-05 Thread Tony Lindgren
Hi, * Johan Hovold [181205 06:17]: > On Sun, Dec 02, 2018 at 05:34:24PM -0800, Tony Lindgren wrote: > > On Motorola Mapphone devices such as Droid 4 there are five USB ports > > that do not use the same layout as Gobi 1K/2K/etc devices listed in > > qcserial.c. So we should use qcaux.c or option.

Re: [PATCH v3 2/2] usb: dwc3: gadget: Report isoc transfer frame number

2018-12-05 Thread Thinh Nguyen
Hi Felipe, On 12/5/2018 1:15 AM, Felipe Balbi wrote: > Hi, > > Thinh Nguyen writes: >> Implement the new frame_number API to report the isochronous interval >> frame number. This patch checks and reports the interval in which the >> isoc transfer was transmitted or received via the Isoc-First TRB

Re: [PATCH] USB: qcaux: Add Motorola modem UARTs

2018-12-05 Thread Johan Hovold
On Wed, Dec 05, 2018 at 05:54:07PM -0800, Tony Lindgren wrote: > Hi, > > * Johan Hovold [181205 06:17]: > > On Sun, Dec 02, 2018 at 05:34:24PM -0800, Tony Lindgren wrote: > > > On Motorola Mapphone devices such as Droid 4 there are five USB ports > > > that do not use the same layout as Gobi 1K/2

Re: [PATCH drivers\usb\serial\pl2303.c & pl2303.h] Prolific's PL2303G: new USB to UART chip

2018-12-05 Thread Charles Yeh
Hi Greg, The patch file: diffpl2303.patch is attached.. Please you kindly check... Thanks! Charles Charles Yeh 於 2018年11月20日 週二 下午5:35寫道: > > Hi Greg, >Try again...no problem... > > make one patch for all of the files modified, <<---OK. > > proper changelog text and a signed-off-by line

Re: [RFC PATCH v2 06/15] usb:cdns3: Adds Host support

2018-12-05 Thread Peter Chen
> > --- a/drivers/usb/cdns3/Makefile > > +++ b/drivers/usb/cdns3/Makefile > > @@ -2,4 +2,5 @@ obj-$(CONFIG_USB_CDNS3) += cdns3.o > > obj-$(CONFIG_USB_CDNS3_PCI_WRAP) += cdns3-pci.o > > > > cdns3-y := core.o drd.o > > +cdns3-$(CONFIG_U

Re: [PATCH v1 10/12] hikey960: Support usb functionality of Hikey960

2018-12-05 Thread Andy Shevchenko
On Wed, Dec 5, 2018 at 3:57 AM Chen Yu wrote: > On 2018/12/5 1:47, Andy Shevchenko wrote: > > On Tue, Dec 4, 2018 at 3:40 AM Chen Yu wrote: > >> On 2018/12/3 17:23, Andy Shevchenko wrote: > >>> On Mon, Dec 3, 2018 at 5:47 AM Yu Chen wrote: > > > + .of_match_table = of_match_pt

RE: [RFC PATCH v2 04/15] usb:cdns3: Driver initialization code.

2018-12-05 Thread Alan Douglas
Hi Peter, On 05 December 2018 07:20, Pawel Laszczak wrote: > Hi, > > >> >> > >> >> Patch adds core.c and core.h file that implements initialization > >> >> of platform driver and adds function responsible for selecting, > >> >> switching and running appropriate Device/Host mode. > >> >> > >> >> S

Re: [RFC PATCH v2 04/15] usb:cdns3: Driver initialization code.

2018-12-05 Thread Peter Chen
> > > > On 04/12/18 10:50, Peter Chen wrote: > >>> + * Cadence USBSS DRD Driver. > >>> + * > >>> + * Copyright (C) 2018 Cadence. > >>> + * > >>> + * Author: Peter Chen > >>> + * Pawel Laszczak > >>> + */ > >>> + > >>> +#include > >>> +#include > >>> +#include > >>> +#include > >>> +#i

Re: [PATCH v7 05/10] usb: dwc3: make controller clear transfer resources after complete

2018-12-05 Thread Felipe Balbi
Hi, Anurag Kumar Vulisha writes: > @@ -2487,6 +2497,11 @@ static void dwc3_endpoint_interrupt(struct dwc3 *dwc, > } > > switch (event->endpoint_event) { > + case DWC3_DEPEVT_XFERCOMPLETE: > + if (!dep->stream_capable) > + break; > + d

Re: [RFC PATCH v2 04/15] usb:cdns3: Driver initialization code.

2018-12-05 Thread Peter Chen
On Wed, Dec 5, 2018 at 4:55 PM Alan Douglas wrote: > > Hi Peter, > > On 05 December 2018 07:20, Pawel Laszczak wrote: > > Hi, > > > > >> >> > > >> >> Patch adds core.c and core.h file that implements initialization > > >> >> of platform driver and adds function responsible for selecting, > > >> >>

Re: [PATCH v7 09/10] usb: dwc3: Check for IOC/LST bit in both event->status and TRB->ctrl fields

2018-12-05 Thread Felipe Balbi
Hi, Anurag Kumar Vulisha writes: > The present code in dwc3_gadget_ep_reclaim_completed_trb() will check > for IOC/LST bit in the event->status and returns if IOC/LST bit is > set. This logic doesn't work if multiple TRBs are queued per > request and the IOC/LST bit is set on the last TRB of tha

Re: [PATCH v2] usb: dwc2: host: use hrtimer for NAK retries

2018-12-05 Thread Felipe Balbi
Hi, Doug Anderson writes: > >> Signed-off-by: Terin Stock >> >> --- >> >> drivers/usb/dwc2/hcd.h |2 +- >> >> drivers/usb/dwc2/hcd_queue.c | 19 --- >> >> 2 files changed, 13 insertions(+), 8 deletions(-) >> > >> > Reviewed-by: Douglas Anderson >> > Cc: sta...@vg

Re: [PATCH v3 2/5] usb: assign ACPI companions for embedded USB devices

2018-12-05 Thread Greg Kroah-Hartman
On Wed, Nov 21, 2018 at 03:50:17PM -0800, Rajat Jain wrote: > From: Dmitry Torokhov > > USB devices permanently connected to USB ports may be described in ACPI > tables and share ACPI devices with ports they are connected to. See [1] > for details. > > This will allow us to describe sideband res

Re: [PATCH v3 1/5] usb: split code locating ACPI companion into port and device

2018-12-05 Thread Greg Kroah-Hartman
On Wed, Nov 21, 2018 at 03:50:16PM -0800, Rajat Jain wrote: > From: Dmitry Torokhov > > In preparation for handling embedded USB devices let's split > usb_acpi_find_companion() into usb_acpi_find_companion_for_device() and > usb_acpi_find_companion_for_port(). > > Signed-off-by: Dmitry Torokhov

Re: [PATCH] USB: quirks: add NO_LPM quirk for Logitech Rally Camera

2018-12-05 Thread Greg Kroah-Hartman
On Thu, Nov 29, 2018 at 07:59:09AM -0500, Kyle Williams wrote: > Description: Some USB device / host controller combinations seem to have > problems with Link Power management. In particular it is described that > the combination of a Logitech Rally and Atrus device causes > 'not enough bandwidth f

[PATCH AUTOSEL 4.19 088/123] usb: gadget: u_ether: fix unsafe list iteration

2018-12-05 Thread Sasha Levin
From: Marek Szyprowski [ Upstream commit c9287fa657b3328b4549c0ab39ea7f197a3d6a50 ] list_for_each_entry_safe() is not safe for deleting entries from the list if the spin lock, which protects it, is released and reacquired during the list iteration. Fix this issue by replacing this construction w

Re: [PATCH] USB: serial: console: fix reported terminal settings

2018-12-05 Thread Johan Hovold
On Wed, Dec 05, 2018 at 11:36:52AM +0200, Jarkko Nikula wrote: > On 12/4/18 6:31 PM, Johan Hovold wrote: > > On Tue, Dec 04, 2018 at 05:15:18PM +0100, Greg Kroah-Hartman wrote: > >> On Tue, Dec 04, 2018 at 05:00:36PM +0100, Johan Hovold wrote: > >>> The USB-serial console implementation has never r

[PATCH AUTOSEL 3.18 14/26] USB: omap_udc: fix USB gadget functionality on Palm Tungsten E

2018-12-05 Thread Sasha Levin
From: Aaro Koskinen [ Upstream commit 2c2322fbcab8102b8cadc09d66714700a2da42c2 ] On Palm TE nothing happens when you try to use gadget drivers and plug the USB cable. Fix by adding the board to the vbus sense quirk list. Signed-off-by: Aaro Koskinen Signed-off-by: Felipe Balbi Signed-off-by:

[PATCH AUTOSEL 3.18 12/26] USB: omap_udc: fix crashes on probe error and module removal

2018-12-05 Thread Sasha Levin
From: Aaro Koskinen [ Upstream commit 99f700366fcea1aa2fa3c49c99f371670c3c62f8 ] We currently crash if usb_add_gadget_udc_release() fails, since the udc->done is not initialized until in the remove function. Furthermore, on module removal the udc data is accessed although the release function is

[PATCH AUTOSEL 3.18 13/26] USB: omap_udc: fix omap_udc_start() on 15xx machines

2018-12-05 Thread Sasha Levin
From: Aaro Koskinen [ Upstream commit 6ca6695f576b8453fe68865e84d25946d63b10ad ] On OMAP 15xx machines there are no transceivers, and omap_udc_start() always fails as it forgot to adjust the default return value. Signed-off-by: Aaro Koskinen Signed-off-by: Felipe Balbi Signed-off-by: Sasha Le

[PATCH AUTOSEL 3.18 11/26] USB: omap_udc: use devm_request_irq()

2018-12-05 Thread Sasha Levin
From: Aaro Koskinen [ Upstream commit 286afdde1640d8ea8916a0f05e811441fbbf4b9d ] The current code fails to release the third irq on the error path (observed by reading the code), and we get also multiple WARNs with failing gadget drivers due to duplicate IRQ releases. Fix by using devm_request_i

[PATCH AUTOSEL 4.4 15/33] USB: omap_udc: fix crashes on probe error and module removal

2018-12-05 Thread Sasha Levin
From: Aaro Koskinen [ Upstream commit 99f700366fcea1aa2fa3c49c99f371670c3c62f8 ] We currently crash if usb_add_gadget_udc_release() fails, since the udc->done is not initialized until in the remove function. Furthermore, on module removal the udc data is accessed although the release function is

[PATCH AUTOSEL 4.4 14/33] USB: omap_udc: use devm_request_irq()

2018-12-05 Thread Sasha Levin
From: Aaro Koskinen [ Upstream commit 286afdde1640d8ea8916a0f05e811441fbbf4b9d ] The current code fails to release the third irq on the error path (observed by reading the code), and we get also multiple WARNs with failing gadget drivers due to duplicate IRQ releases. Fix by using devm_request_i

[PATCH AUTOSEL 4.4 16/33] USB: omap_udc: fix omap_udc_start() on 15xx machines

2018-12-05 Thread Sasha Levin
From: Aaro Koskinen [ Upstream commit 6ca6695f576b8453fe68865e84d25946d63b10ad ] On OMAP 15xx machines there are no transceivers, and omap_udc_start() always fails as it forgot to adjust the default return value. Signed-off-by: Aaro Koskinen Signed-off-by: Felipe Balbi Signed-off-by: Sasha Le

[PATCH AUTOSEL 4.4 17/33] USB: omap_udc: fix USB gadget functionality on Palm Tungsten E

2018-12-05 Thread Sasha Levin
From: Aaro Koskinen [ Upstream commit 2c2322fbcab8102b8cadc09d66714700a2da42c2 ] On Palm TE nothing happens when you try to use gadget drivers and plug the USB cable. Fix by adding the board to the vbus sense quirk list. Signed-off-by: Aaro Koskinen Signed-off-by: Felipe Balbi Signed-off-by:

[PATCH AUTOSEL 4.9 24/45] USB: omap_udc: fix omap_udc_start() on 15xx machines

2018-12-05 Thread Sasha Levin
From: Aaro Koskinen [ Upstream commit 6ca6695f576b8453fe68865e84d25946d63b10ad ] On OMAP 15xx machines there are no transceivers, and omap_udc_start() always fails as it forgot to adjust the default return value. Signed-off-by: Aaro Koskinen Signed-off-by: Felipe Balbi Signed-off-by: Sasha Le

Re: [PATCH v3 3/3] fpga: Add fpga manager driver for ARRI Altera FPP

2018-12-05 Thread Anatolij Gustschin
Hi Alan, On Tue, 27 Nov 2018 18:54:38 +0100 Anatolij Gustschin ag...@denx.de wrote: >Add FPGA manager driver for loading ARRI Altera FPGAs via fast >passive parallel (FPP) interface using FTDI FT232H chip. Ping. Is this patch okay? I suppose that it will go via usb tree as part of the whole seri

[PATCH AUTOSEL 4.9 25/45] USB: omap_udc: fix USB gadget functionality on Palm Tungsten E

2018-12-05 Thread Sasha Levin
From: Aaro Koskinen [ Upstream commit 2c2322fbcab8102b8cadc09d66714700a2da42c2 ] On Palm TE nothing happens when you try to use gadget drivers and plug the USB cable. Fix by adding the board to the vbus sense quirk list. Signed-off-by: Aaro Koskinen Signed-off-by: Felipe Balbi Signed-off-by:

[PATCH AUTOSEL 4.9 22/45] USB: omap_udc: use devm_request_irq()

2018-12-05 Thread Sasha Levin
From: Aaro Koskinen [ Upstream commit 286afdde1640d8ea8916a0f05e811441fbbf4b9d ] The current code fails to release the third irq on the error path (observed by reading the code), and we get also multiple WARNs with failing gadget drivers due to duplicate IRQ releases. Fix by using devm_request_i

[PATCH AUTOSEL 4.9 23/45] USB: omap_udc: fix crashes on probe error and module removal

2018-12-05 Thread Sasha Levin
From: Aaro Koskinen [ Upstream commit 99f700366fcea1aa2fa3c49c99f371670c3c62f8 ] We currently crash if usb_add_gadget_udc_release() fails, since the udc->done is not initialized until in the remove function. Furthermore, on module removal the udc data is accessed although the release function is

[PATCH AUTOSEL 4.14 45/69] usb: gadget: u_ether: fix unsafe list iteration

2018-12-05 Thread Sasha Levin
From: Marek Szyprowski [ Upstream commit c9287fa657b3328b4549c0ab39ea7f197a3d6a50 ] list_for_each_entry_safe() is not safe for deleting entries from the list if the spin lock, which protects it, is released and reacquired during the list iteration. Fix this issue by replacing this construction w

[PATCH AUTOSEL 4.14 38/69] USB: omap_udc: fix rejection of out transfers when DMA is used

2018-12-05 Thread Sasha Levin
From: Aaro Koskinen [ Upstream commit 069caf5950dfa75d0526cd89c439ff9d9d3136d8 ] Commit 387f869d2579 ("usb: gadget: u_ether: conditionally align transfer size") started aligning transfer size only if requested, breaking omap_udc DMA mode. Set quirk_ep_out_aligned_size to restore the old behaviou

[PATCH AUTOSEL 4.14 37/69] USB: omap_udc: fix USB gadget functionality on Palm Tungsten E

2018-12-05 Thread Sasha Levin
From: Aaro Koskinen [ Upstream commit 2c2322fbcab8102b8cadc09d66714700a2da42c2 ] On Palm TE nothing happens when you try to use gadget drivers and plug the USB cable. Fix by adding the board to the vbus sense quirk list. Signed-off-by: Aaro Koskinen Signed-off-by: Felipe Balbi Signed-off-by:

[PATCH AUTOSEL 4.14 36/69] USB: omap_udc: fix omap_udc_start() on 15xx machines

2018-12-05 Thread Sasha Levin
From: Aaro Koskinen [ Upstream commit 6ca6695f576b8453fe68865e84d25946d63b10ad ] On OMAP 15xx machines there are no transceivers, and omap_udc_start() always fails as it forgot to adjust the default return value. Signed-off-by: Aaro Koskinen Signed-off-by: Felipe Balbi Signed-off-by: Sasha Le

[PATCH AUTOSEL 4.14 35/69] USB: omap_udc: fix crashes on probe error and module removal

2018-12-05 Thread Sasha Levin
From: Aaro Koskinen [ Upstream commit 99f700366fcea1aa2fa3c49c99f371670c3c62f8 ] We currently crash if usb_add_gadget_udc_release() fails, since the udc->done is not initialized until in the remove function. Furthermore, on module removal the udc data is accessed although the release function is

[PATCH AUTOSEL 4.14 34/69] USB: omap_udc: use devm_request_irq()

2018-12-05 Thread Sasha Levin
From: Aaro Koskinen [ Upstream commit 286afdde1640d8ea8916a0f05e811441fbbf4b9d ] The current code fails to release the third irq on the error path (observed by reading the code), and we get also multiple WARNs with failing gadget drivers due to duplicate IRQ releases. Fix by using devm_request_i

Re: [PATCH] USB: serial: console: fix reported terminal settings

2018-12-05 Thread Greg Kroah-Hartman
On Wed, Dec 05, 2018 at 10:50:49AM +0100, Johan Hovold wrote: > On Wed, Dec 05, 2018 at 11:36:52AM +0200, Jarkko Nikula wrote: > > On 12/4/18 6:31 PM, Johan Hovold wrote: > > > On Tue, Dec 04, 2018 at 05:15:18PM +0100, Greg Kroah-Hartman wrote: > > >> On Tue, Dec 04, 2018 at 05:00:36PM +0100, Johan

[PATCH AUTOSEL 4.19 083/123] usbnet: ipheth: fix potential recvmsg bug and recvmsg bug 2

2018-12-05 Thread Sasha Levin
From: Bernd Eckstein <3erndeckst...@gmail.com> [ Upstream commit 45611c61dd503454b2edae00aabe1e429ec49ebe ] The bug is not easily reproducable, as it may occur very infrequently (we had machines with 20minutes heavy downloading before it occurred) However, on a virual machine (VMWare on Windows 1

[PATCH AUTOSEL 4.19 072/123] USB: omap_udc: fix rejection of out transfers when DMA is used

2018-12-05 Thread Sasha Levin
From: Aaro Koskinen [ Upstream commit 069caf5950dfa75d0526cd89c439ff9d9d3136d8 ] Commit 387f869d2579 ("usb: gadget: u_ether: conditionally align transfer size") started aligning transfer size only if requested, breaking omap_udc DMA mode. Set quirk_ep_out_aligned_size to restore the old behaviou

[PATCH AUTOSEL 4.19 071/123] USB: omap_udc: fix USB gadget functionality on Palm Tungsten E

2018-12-05 Thread Sasha Levin
From: Aaro Koskinen [ Upstream commit 2c2322fbcab8102b8cadc09d66714700a2da42c2 ] On Palm TE nothing happens when you try to use gadget drivers and plug the USB cable. Fix by adding the board to the vbus sense quirk list. Signed-off-by: Aaro Koskinen Signed-off-by: Felipe Balbi Signed-off-by:

[PATCH AUTOSEL 4.19 069/123] USB: omap_udc: fix crashes on probe error and module removal

2018-12-05 Thread Sasha Levin
From: Aaro Koskinen [ Upstream commit 99f700366fcea1aa2fa3c49c99f371670c3c62f8 ] We currently crash if usb_add_gadget_udc_release() fails, since the udc->done is not initialized until in the remove function. Furthermore, on module removal the udc data is accessed although the release function is

[PATCH AUTOSEL 4.19 070/123] USB: omap_udc: fix omap_udc_start() on 15xx machines

2018-12-05 Thread Sasha Levin
From: Aaro Koskinen [ Upstream commit 6ca6695f576b8453fe68865e84d25946d63b10ad ] On OMAP 15xx machines there are no transceivers, and omap_udc_start() always fails as it forgot to adjust the default return value. Signed-off-by: Aaro Koskinen Signed-off-by: Felipe Balbi Signed-off-by: Sasha Le

[PATCH AUTOSEL 4.19 068/123] USB: omap_udc: use devm_request_irq()

2018-12-05 Thread Sasha Levin
From: Aaro Koskinen [ Upstream commit 286afdde1640d8ea8916a0f05e811441fbbf4b9d ] The current code fails to release the third irq on the error path (observed by reading the code), and we get also multiple WARNs with failing gadget drivers due to duplicate IRQ releases. Fix by using devm_request_i

Re: [PATCH] USB: quirks: add NO_LPM quirk for Logitech Flare|Meetup|Brio|Rally

2018-12-05 Thread Greg Kroah-Hartman
On Tue, Dec 04, 2018 at 03:38:25PM -0500, Kyle Williams wrote: > Description: Some USB device / host controller combinations seem to have > problems with Link Power management. In particular it is described that > the combination of certain Logitech devices and other powered media > devices such as

Re: [PATCH] USB: serial: console: fix reported terminal settings

2018-12-05 Thread Johan Hovold
On Wed, Dec 05, 2018 at 11:05:45AM +0100, Greg Kroah-Hartman wrote: > On Wed, Dec 05, 2018 at 10:50:49AM +0100, Johan Hovold wrote: > > Note that the changes to tty are trivial; I'm just renaming and > > exporting an existing helper. > > Yeah, I have no objections to them. We can take them in my

Re: [PATCH] USB: serial: console: fix reported terminal settings

2018-12-05 Thread Jarkko Nikula
On 12/4/18 6:31 PM, Johan Hovold wrote: On Tue, Dec 04, 2018 at 05:15:18PM +0100, Greg Kroah-Hartman wrote: On Tue, Dec 04, 2018 at 05:00:36PM +0100, Johan Hovold wrote: The USB-serial console implementation has never reported the actual terminal settings used. Despite storing the corresponding

Re: [PATCH] USB: serial: console: fix reported terminal settings

2018-12-05 Thread Greg Kroah-Hartman
On Wed, Dec 05, 2018 at 11:10:20AM +0100, Johan Hovold wrote: > On Wed, Dec 05, 2018 at 11:05:45AM +0100, Greg Kroah-Hartman wrote: > > On Wed, Dec 05, 2018 at 10:50:49AM +0100, Johan Hovold wrote: > > > > Note that the changes to tty are trivial; I'm just renaming and > > > exporting an existing

Re: [PATCH v3 2/3] spi: add FTDI MPSSE SPI controller driver

2018-12-05 Thread Anatolij Gustschin
Hi Mark, On Tue, 27 Nov 2018 18:54:37 +0100 Anatolij Gustschin ag...@denx.de wrote: >Add SPI bus controller driver for FTDI MPSSE mode. This driver >is supposed to be used together with the FT232H interface driver >for FPGA configuration in drivers/usb/misc/ft232h-intf.c which >adds an mpsse spi

Re: [PATCH] USB: serial: console: fix reported terminal settings

2018-12-05 Thread Johan Hovold
On Wed, Dec 05, 2018 at 11:18:50AM +0100, Greg Kroah-Hartman wrote: > On Wed, Dec 05, 2018 at 11:10:20AM +0100, Johan Hovold wrote: > > On Wed, Dec 05, 2018 at 11:05:45AM +0100, Greg Kroah-Hartman wrote: > > > On Wed, Dec 05, 2018 at 10:50:49AM +0100, Johan Hovold wrote: > > > > > > Note that the

Re: [PATCH] usb: dwc2: Revert "usb: dwc2: Disable all EP's on disconnect"

2018-12-05 Thread Minas Harutyunyan
Hi, On 12/4/2018 5:29 PM, Dan Carpenter wrote: > On Tue, Dec 04, 2018 at 12:34:08PM +, Minas Harutyunyan wrote: >> @@ -3185,12 +3183,13 @@ void dwc2_hsotg_disconnect(struct dwc2_hsotg *hsotg) >> hsotg->connected = 0; >> hsotg->test_mode = 0; >> >> - /* all endpoints s

usb: thoughts of adding more support for FT232H

2018-12-05 Thread Song Qiang
Hi Johan, I've been developing some iio device drivers and found that some people would like to test their devices with a qemu system which requires an i2c or spi port on our development hosts. Usually this is achieved with a DLN-2 adapter, while this is a bit difficult for me because it costs ~

[PATCH 3/3] usb: dwc3: keystone: Add support for ti,am654-dwc3

2018-12-05 Thread Roger Quadros
The AM654 SoC contains a DWC3 controller with TI specific wrapper. Add support for that. Unlike the Keystone 2 case, for AM654 We don't need to process any IRQs for basic USB operation. Signed-off-by: Roger Quadros --- drivers/usb/dwc3/Kconfig | 6 +++--- drivers/usb/dwc3/dwc3-keystone

[PATCH 1/3] usb: dwc3: gadget: Fix OTG events when gadget driver isn't loaded

2018-12-05 Thread Roger Quadros
On v3.10a in dual-role mode, if port is in device mode and gadget driver isn't loaded, the OTG event interrupts don't come through. It seems that if the core is configured to be OTG2.0 only, then we can't leave the DCFG.DEVSPD at Super-speed (default) if we expect OTG to work properly. It must be

[PATCH 2/3] dt-bindings: usb: keystone-usb: Add ti,am654-dwc3 support

2018-12-05 Thread Roger Quadros
The AM654 SoC from TI contains a DWC3 controller. Add support for it. Signed-off-by: Roger Quadros --- Documentation/devicetree/bindings/usb/keystone-usb.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/usb/keystone-usb.txt b/Document

[PATCH 0/3] usb: dwc3: Add support for AM654 USB

2018-12-05 Thread Roger Quadros
Hi Felipe, TI's AM654 USB SoC has 2 instances of the DWC3 controller. This series adds AM654 USB wrapper support to the keystone-usb driver. cheers, -roger Roger Quadros (3): usb: dwc3: gadget: Fix OTG events when gadget driver isn't loaded dt-bindings: usb: keystone-usb: Add ti,am654-dwc3 s

[PATCH 0/3] usb: dwc3: Add support for AM654 USB

2018-12-05 Thread Roger Quadros
Hi Felipe, TI's AM654 USB SoC has 2 instances of the DWC3 controller. This series adds AM654 USB wrapper support to the keystone-usb driver. cheers, -roger Roger Quadros (3): usb: dwc3: gadget: Fix OTG events when gadget driver isn't loaded dt-bindings: usb: keystone-usb: Add ti,am654-dwc3 s

[PATCH 2/3] dt-bindings: usb: keystone-usb: Add ti,am654-dwc3 support

2018-12-05 Thread Roger Quadros
The AM654 SoC from TI contains a DWC3 controller. Add support for it. Signed-off-by: Roger Quadros --- Documentation/devicetree/bindings/usb/keystone-usb.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/usb/keystone-usb.txt b/Document

Re: usb: thoughts of adding more support for FT232H

2018-12-05 Thread Anatolij Gustschin
Hi, On Wed, 5 Dec 2018 22:10:40 +0800 Song Qiang songqiang1304...@gmail.com wrote: ... >I've been developing some iio device drivers and found that some people >would like to test their devices with a qemu system which requires an >i2c or spi port on our development hosts. Usually this is achieved

Re: [PATCH 0/3] usb: dwc3: Add support for AM654 USB

2018-12-05 Thread Roger Quadros
Misspelled Felipe's ID. Will resend this series. On 05/12/18 17:14, Roger Quadros wrote: > Hi Felipe, > > TI's AM654 USB SoC has 2 instances of the DWC3 controller. > This series adds AM654 USB wrapper support to the keystone-usb driver. > > cheers, > -roger > > Roger Quadros (3): > usb: dwc3

[PATCH 3/3] usb: dwc3: keystone: Add support for ti,am654-dwc3

2018-12-05 Thread Roger Quadros
The AM654 SoC contains a DWC3 controller with TI specific wrapper. Add support for that. Unlike the Keystone 2 case, for AM654 We don't need to process any IRQs for basic USB operation. Signed-off-by: Roger Quadros --- drivers/usb/dwc3/Kconfig | 6 +++--- drivers/usb/dwc3/dwc3-keystone

[PATCH 1/3] usb: dwc3: gadget: Fix OTG events when gadget driver isn't loaded

2018-12-05 Thread Roger Quadros
On v3.10a in dual-role mode, if port is in device mode and gadget driver isn't loaded, the OTG event interrupts don't come through. It seems that if the core is configured to be OTG2.0 only, then we can't leave the DCFG.DEVSPD at Super-speed (default) if we expect OTG to work properly. It must be

Re: usb: thoughts of adding more support for FT232H

2018-12-05 Thread Johan Hovold
On Wed, Dec 05, 2018 at 04:17:18PM +0100, Anatolij Gustschin wrote: > Hi, > > On Wed, 5 Dec 2018 22:10:40 +0800 > Song Qiang songqiang1304...@gmail.com wrote: > ... > >I've been developing some iio device drivers and found that some people > >would like to test their devices with a qemu system whi

RE: [PATCH v7 01/10] usb: gadget: udc: Add timer support for usb requests

2018-12-05 Thread Anurag Kumar Vulisha
Hi Alan, >-Original Message- >From: Alan Stern [mailto:st...@rowland.harvard.edu] >Sent: Wednesday, December 05, 2018 12:59 AM >To: Anurag Kumar Vulisha >Cc: Felipe Balbi ; Greg Kroah-Hartman >; Shuah Khan ; Johan Hovold >; Jaejoong Kim ; Benjamin >Herrenschmidt ; Roger Quadros ; Manu >Ga

[PATCH] USB: gadget: udc: s3c2410_udc: convert to DEFINE_SHOW_ATTRIBUTE

2018-12-05 Thread Yangtao Li
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Yangtao Li --- drivers/usb/gadget/udc/s3c2410_udc.c | 17 ++--- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/drivers/usb/gadget/udc/s3c2410_udc.c b/drivers/usb/gadget/udc/s3c2410_udc.c index 8bf5a

[PATCH] usb: host: isp1362-hcd: convert to DEFINE_SHOW_ATTRIBUTE

2018-12-05 Thread Yangtao Li
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Yangtao Li --- drivers/usb/host/isp1362-hcd.c | 16 +++- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/drivers/usb/host/isp1362-hcd.c b/drivers/usb/host/isp1362-hcd.c index b21c386e6a46..28bf8bfb091

RE: [PATCH v3 2/5] usb: assign ACPI companions for embedded USB devices

2018-12-05 Thread Ghorai, Sukumar
>On Wed, Nov 21, 2018 at 03:50:17PM -0800, Rajat Jain wrote: >> From: Dmitry Torokhov >> >> USB devices permanently connected to USB ports may be described in >> ACPI tables and share ACPI devices with ports they are connected to. >> See [1] for details. >> >> This will allow us to describe sideba

RE: [PATCH v3 1/5] usb: split code locating ACPI companion into port and device

2018-12-05 Thread Ghorai, Sukumar
>On Wed, Nov 21, 2018 at 03:50:16PM -0800, Rajat Jain wrote: >> From: Dmitry Torokhov >> >> In preparation for handling embedded USB devices let's split >> usb_acpi_find_companion() into usb_acpi_find_companion_for_device() >> and usb_acpi_find_companion_for_port(). >> >> Signed-off-by: Dmitry Tor

RE: [PATCH v7 09/10] usb: dwc3: Check for IOC/LST bit in both event->status and TRB->ctrl fields

2018-12-05 Thread Anurag Kumar Vulisha
Hi Felipe, >-Original Message- >From: Felipe Balbi [mailto:ba...@kernel.org] >Sent: Wednesday, December 05, 2018 2:38 PM >To: Anurag Kumar Vulisha ; Greg Kroah-Hartman >; Shuah Khan ; Alan Stern >; Johan Hovold ; Jaejoong Kim >; Benjamin Herrenschmidt ; >Roger Quadros ; Manu Gautam ; >mar

RE: [PATCH v7 05/10] usb: dwc3: make controller clear transfer resources after complete

2018-12-05 Thread Anurag Kumar Vulisha
HI Felipe, >-Original Message- >From: Felipe Balbi [mailto:ba...@kernel.org] >Sent: Wednesday, December 05, 2018 2:32 PM >To: Anurag Kumar Vulisha ; Greg Kroah-Hartman >; Shuah Khan ; Alan Stern >; Johan Hovold ; Jaejoong Kim >; Benjamin Herrenschmidt ; >Roger Quadros ; Manu Gautam ; >mar

RE: [RFC PATCH v2 04/15] usb:cdns3: Driver initialization code.

2018-12-05 Thread Pawel Laszczak
Hi + Tomek >> > + * Cadence USBSS DRD Driver. >> > + * >> > + * Copyright (C) 2018 Cadence. >> > + * >> > + * Author: Peter Chen >> > + * Pawel Laszczak >> > + */ >> > + >> > +#include >> > +#include >> > +#include >> > +#include >> > +#include >> > +#include >> > + >> > +#include

RE: [RFC PATCH v2 04/15] usb:cdns3: Driver initialization code.

2018-12-05 Thread Pawel Laszczak
+ Tomek Klimek >> > + >> > +static inline void cdns3_role_stop(struct cdns3 *cdns) >> > +{ >> > + enum cdns3_roles role = cdns->role; >> > + >> > + if (role == CDNS3_ROLE_END) >> >> WARN_ON(role >= CNDS3_ROLE_END) ? >> >> > + return; >> > + >> > + mutex_lock(&cdns->mutex);

[PATCH] usb: typec: tcpm: Extend the matching rules on PPS APDO selection

2018-12-05 Thread Kyle Tso
Current matching rules ensure that the voltage range of selected Source Capability is entirely within the range defined in one of the Sink Capabilities. This is reasonable but not practical because Sink may not support wide range of voltage when sinking power while Source could advertise its capabi

Re: usb: thoughts of adding more support for FT232H

2018-12-05 Thread Song Qiang
On 12/5/18 11:17 PM, Anatolij Gustschin wrote: Hi, On Wed, 5 Dec 2018 22:10:40 +0800 Song Qiang songqiang1304...@gmail.com wrote: ... I've been developing some iio device drivers and found that some people would like to test their devices with a qemu system which requires an i2c or spi port o

RE: [RFC PATCH v2 04/15] usb:cdns3: Driver initialization code.

2018-12-05 Thread Pawel Laszczak
> >> Hi Roger >> >> >On 18/11/18 12:09, Pawel Laszczak wrote: >> >> Patch adds core.c and core.h file that implements initialization >> >> of platform driver and adds function responsible for selecting, >> >> switching and running appropriate Device/Host mode. >> >> >> >> Signed-off-by: Pawel Laszc

RE: [RFC PATCH v2 05/15] usb:cdns3: Added DRD support

2018-12-05 Thread Pawel Laszczak
>> Patch adds supports for detecting Host/Device mode. >> Controller has additional OTG register that allow >> implement even whole OTG functionality. >> At this moment patch adds support only for detecting >> the appropriate mode based on strap pins and ID pin. >> >> Signed-off-by: Pawel Laszczak