Re: [PATCH 1/3] usb: dwc3: Add reference clock properties

2018-11-09 Thread Felipe Balbi
Hi, Thinh Nguyen writes: >> Thinh Nguyen writes: Thinh Nguyen writes: > diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt > b/Documentation/devicetree/bindings/usb/dwc3.txt > index 636630fb92d7..712b344c3a31 100644 > --- a/Documentation/devicetre

Re: [PATCH 4/4] usb: dwc3: gadget: check if dep->frame_number is still valid

2018-11-09 Thread Felipe Balbi
Hi again, Felipe Balbi writes: > In the case of interval of 1ms, it will start on the next interval. >> frame_number + max(4, interval) will start at least 4 uframes in the future. >> >> In any case, what about immediately retry the START_TRANSFER command >> with a new frame_number + (interval*r

Re: [PATCH 4/4] usb: dwc3: gadget: check if dep->frame_number is still valid

2018-11-09 Thread Felipe Balbi
Hi, Thinh Nguyen writes: diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index d8c7ad0c22e8..00fe01a01977 100644 --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadget.c @@ -1268,12 +1268,22 @@ static int __dwc3_gadget_get_frame(struct dwc3 >>>

Re: [PATCH 3/3] usb: dwc3: Support option to disable USB2 LPM

2018-11-09 Thread Roger Quadros
Hi, On 08/11/18 04:10, Thinh Nguyen wrote: > Support the option to disable USB2 LPM. Set xhci "usb2-lpm-disable" > property via "snps,usb2-lpm-disable" property. > > Signed-off-by: Thinh Nguyen > --- > drivers/usb/dwc3/core.c | 2 ++ > drivers/usb/dwc3/core.h | 2 ++ > drivers/usb/dwc3/host.c |

Re: Query on usb/core/devio.c

2018-11-09 Thread Mayuresh Kulkarni
On Thu, 2018-11-08 at 10:26 -0500, Alan Stern wrote: > On Thu, 8 Nov 2018, Mayuresh Kulkarni wrote: > > > > > On Wed, 24 Oct 2018 10:10:32 -0400 > > Alan Stern wrote: > > > > > > > > On Wed, 24 Oct 2018, Mayuresh Kulkarni wrote: > > > > > > > > > > > On Mon, 22 Oct 2018 10:24:46 -0400 > > >

Re: [PATCH] usb: gadget: f_fs: Allow scatter-gather buffers

2018-11-09 Thread kbuild test robot
Hi Andrzej, I love your patch! Yet something to improve: [auto build test ERROR on balbi-usb/next] [also build test ERROR on v4.20-rc1 next-20181109] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

[PATCHv2] usb: gadget: f_fs: Allow scatter-gather buffers

2018-11-09 Thread Andrzej Pietrasiewicz
Some protocols implemented in userspace with FunctionFS might require large buffers, e.g. 64kB or more. Currently the said memory is allocated with kmalloc, which might fail should system memory be highly fragmented. On the other hand, some UDC hardware allows scatter-gather operation and this pat

Re: [PATCH v2 2/3] spi: add FTDI MPSSE SPI controller driver

2018-11-09 Thread Mark Brown
On Fri, Nov 09, 2018 at 08:53:56AM +0100, Anatolij Gustschin wrote: > Add SPI bus controller driver for FTDI MPSSE mode. This driver > is supposed to be used together with the FT232H interface driver > for FPGA configuration in drivers/usb/misc/ft232h-intf.c which > adds an mpsse spi platform devic

Re: Query on usb/core/devio.c

2018-11-09 Thread Alan Stern
On Fri, 9 Nov 2018, Mayuresh Kulkarni wrote: > > The driver has no way to tell whether the resume was caused by the  > > host or by the device.  (In fact, it's possible for a resume to be  > > caused by _both_ the host and the device, if they request it at the  > > same time.)  In the end, it does

Re: [PATCH v15 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-11-09 Thread Wolfram Sang
On Fri, Oct 26, 2018 at 09:36:58AM -0700, Ajay Gupta wrote: > Latest NVIDIA GPU card has USB Type-C interface. There is a > Type-C controller which can be accessed over I2C. > > This driver adds I2C bus driver to communicate with Type-C controller. > I2C client driver will be part of USB Type-C UC

Re: [PATCH v15 0/2] Add support for USB Type-C interface on latest NVIDIA GPU

2018-11-09 Thread Wolfram Sang
On Mon, Oct 29, 2018 at 02:42:37PM +0200, Andy Shevchenko wrote: > On Fri, Oct 26, 2018 at 09:36:57AM -0700, Ajay Gupta wrote: > > Hi Heikki and Wolfram, > > > > These two changes add support for USB Type-C interface on latest NVIDIA GPU > > card. > > The Type-C controller used is Cypress CCGx an

Re: [PATCH v15 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-11-09 Thread Wolfram Sang
> @@ -140,5 +140,6 @@ obj-$(CONFIG_I2C_SIBYTE) += i2c-sibyte.o > obj-$(CONFIG_I2C_XGENE_SLIMPRO) += i2c-xgene-slimpro.o > obj-$(CONFIG_SCx200_ACB) += scx200_acb.o > obj-$(CONFIG_I2C_FSI)+= i2c-fsi.o > +obj-$(CONFIG_I2C_NVIDIA_GPU) += i2c-nvidia-gpu.o Oh, I fixed this up an

Re: [PATCH v15 0/2] Add support for USB Type-C interface on latest NVIDIA GPU

2018-11-09 Thread Andy Shevchenko
On Fri, Nov 09, 2018 at 05:45:16PM +0100, Wolfram Sang wrote: > On Mon, Oct 29, 2018 at 02:42:37PM +0200, Andy Shevchenko wrote: > > On Fri, Oct 26, 2018 at 09:36:57AM -0700, Ajay Gupta wrote: > > > Hi Heikki and Wolfram, > > > > > > These two changes add support for USB Type-C interface on latest

Re: [PATCH v15 0/2] Add support for USB Type-C interface on latest NVIDIA GPU

2018-11-09 Thread Wolfram Sang
> Hmm... It would be a bit difficult (requires to download patches again as > mbox). > I would rather give you a hint how I resolve such problem when apply a tag to > a > pile of patches. I don't mean now, for future patch series, that is... With this one, all is fine... > git filter-branch --

RE: [PATCH v15 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-11-09 Thread Ajay Gupta
Hi Wolfram, > > Latest NVIDIA GPU card has USB Type-C interface. There is a Type-C > > controller which can be accessed over I2C. > > > > This driver adds I2C bus driver to communicate with Type-C controller. > > I2C client driver will be part of USB Type-C UCSI driver. > > > > Signed-off-by: Ajay

Re: [PATCH v15 2/2] usb: typec: ucsi: add support for Cypress CCGx

2018-11-09 Thread Wolfram Sang
On Fri, Oct 26, 2018 at 09:36:59AM -0700, Ajay Gupta wrote: > Latest NVIDIA GPU cards have a Cypress CCGx Type-C controller > over I2C interface. > > This UCSI I2C driver uses I2C bus driver interface for communicating > with Type-C controller. > > Signed-off-by: Ajay Gupta Applied to for-curre

Re: [PATCH v15 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-11-09 Thread Wolfram Sang
> It will be good if both of them can go together either through I2C or > USB subsystem. Since USB part is reviewed and has Acked-by Heikki so please > take that also. Hmmm, technicallly, there is no need to let them go together. There is no strict dependency. Yet, since Heikki gave his ack, I a

RE: [PATCH v15 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-11-09 Thread Ajay Gupta
Hi Wolfram, > > It will be good if both of them can go together either through I2C or > > USB subsystem. Since USB part is reviewed and has Acked-by Heikki so > > please take that also. > > Hmmm, technicallly, there is no need to let them go together. There is no > strict dependency. Agree. > Yet

RE: [PATCH v15 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-11-09 Thread Ajay Gupta
Hi Wolfram, > > @@ -140,5 +140,6 @@ obj-$(CONFIG_I2C_SIBYTE)+= i2c-sibyte.o > > obj-$(CONFIG_I2C_XGENE_SLIMPRO) += i2c-xgene-slimpro.o > > obj-$(CONFIG_SCx200_ACB) += scx200_acb.o > > obj-$(CONFIG_I2C_FSI) += i2c-fsi.o > > +obj-$(CONFIG_I2C_NVIDIA_GPU) += i2c-nvidia

Re: [PATCH v15 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-11-09 Thread Wolfram Sang
> > I can't send an incremental patch for this, I need to ask: did you try > > SMBUS_QUICK with it? > Tried it today using i2cdetect and it looks good to me. Yup, looks good. Thanks for checking! signature.asc Description: PGP signature

Re: [PATCH V2 2/6] usb: core: Add ability to skip phy exit on suspend and init on resume

2018-11-09 Thread Chunfeng Yun
On Thu, 2018-11-08 at 17:50 -0500, Alan Cooper wrote: > On Wed, Nov 7, 2018 at 8:43 PM Chunfeng Yun wrote: > > > > hi, > > On Tue, 2018-10-30 at 18:30 -0400, Alan Cooper wrote: > > > On 10/17/18 9:46 PM, Chunfeng Yun wrote:> hi, > > > > > > > > On Wed, 2018-10-17 at 18:29 -0400, Al Cooper wrote: >

Re: [PATCH] usb: dwc2: gadget: fix ISOC frame overflow handling

2018-11-09 Thread Minas Harutyunyan
Hi John, On 11/8/2018 9:37 PM, John Keeping wrote: > Hi Minas, > > On Mon, 5 Nov 2018 08:28:07 + > Minas Harutyunyan wrote: > >> On 10/23/2018 5:43 PM, John Keeping wrote: >>> By clearing the overrun flag as soon as the target frame is next >>> incremented, we can end up incrementing the ta

Re: [PATCH] [stable, netdev 4.4+] lan78xx: make sure RX_ADDRL & RX_ADDRH regs are always up to date

2018-11-09 Thread Paolo Pisati
On Thu, Nov 08, 2018 at 10:49:04AM -0500, Sasha Levin wrote: > > Can you confirm it actually works on 4.4? Yes, built and tested on 4.4.y: Tested-by: Paolo Pisati -- bye, p.

[PATCH] usb: gadget: udc: renesas_usb3: add a safety connection way for forced_b_device

2018-11-09 Thread Yoshihiro Shimoda
This patch adds a safety connection way for "forced_b_device" with "workaround_for_vbus" like below: < Example for R-Car E3 Ebisu > # modprobe # echo 1 > /sys/kernel/debug/ee02.usb/b_device (connect a usb cable to host side.) # echo 2 > /sys/kernel/debug/ee02.usb/b_device Previous co

Re: [PATCH V2 2/6] usb: core: Add ability to skip phy exit on suspend and init on resume

2018-11-09 Thread Alan Cooper
On Fri, Nov 9, 2018 at 3:08 AM Chunfeng Yun wrote: > > On Thu, 2018-11-08 at 17:50 -0500, Alan Cooper wrote: > > On Wed, Nov 7, 2018 at 8:43 PM Chunfeng Yun > > wrote: > > > > > > hi, > > > On Tue, 2018-10-30 at 18:30 -0400, Alan Cooper wrote: > > > > On 10/17/18 9:46 PM, Chunfeng Yun wrote:> hi

Re: USB-C device hotplug issue

2018-11-09 Thread Mathias Nyman
On 07.11.2018 11:08, Dennis Wassenberg wrote: On 05.11.18 16:35, Mathias Nyman wrote: On 26.10.2018 17:07, Alan Stern wrote: On Fri, 26 Oct 2018, Dennis Wassenberg wrote: --- a/drivers/usb/core/hub.c +++ b/drivers/usb/core/hub.c @@ -2815,7 +2815,9 @@ static int hub_port_reset(struct usb_hub

[PATCH V4 2/5] usb: core: Add ability to skip phy exit on suspend and init on resume

2018-11-09 Thread Al Cooper
Add the ability to skip calling the PHY's exit routine on suspend and the PHY's init routine on resume. This is to handle a USB PHY that should have it's power_off function called on suspend but cannot have it's exit function called because on exit it will disable the PHY to the point where all USB

[PATCH V4 4/5] usb: ehci: Add new EHCI driver for Broadcom STB SoC's

2018-11-09 Thread Al Cooper
Add a new EHCI driver for Broadcom STB SoC's. A new EHCI driver was created instead of adding support to the existing ehci platform driver because of the code required to workaround bugs in the EHCI controller. Signed-off-by: Al Cooper --- drivers/usb/host/ehci-brcm.c | 286 +

[PATCH V4 5/5] usb: host: Add ability to build new Broadcom STB USB drivers

2018-11-09 Thread Al Cooper
Add the build system changes needed to get the Broadcom STB XHCI, EHCI and OHCI functionality working. The link order for XHCI was changed in the Makefile because of the way STB XHCI, EHCI and OHCI controllers share a port which requires that the XHCI driver be initialized first. Also update MAINTA

[PATCH V4 1/5] dt-bindings: Add Broadcom STB USB support

2018-11-09 Thread Al Cooper
Add DT bindings for Broadcom STB USB EHCI and XHCI drivers. Add "phy-supplies-usb-clock" property description to usb-hcd.txt NOTE: The OHCI driver is not included because it uses the generic platform driver. Signed-off-by: Al Cooper --- .../devicetree/bindings/usb/brcm,bcm7445-ehci.txt |

[PATCH V4 0/5] Add XHCI, EHCI and OHCI support for Broadcom STB SoS's

2018-11-09 Thread Al Cooper
V4 - Rename hcd phy flag "suspend_without_phy_exit" to "phy_supplies_usb_clock" to more closely reflect the actaual hardware. Add the device tree property "suspend-without-phy-exit" to set the flag. Remove the code that sets the flag in the OHCI, EHCI and XHCI drivers which

[PATCH V4 3/5] usb: xhci: xhci-plat: Add support for Broadcom STB SoC's

2018-11-09 Thread Al Cooper
Add support for Broadcom STB SoC's to the xhci platform driver Signed-off-by: Al Cooper --- drivers/usb/host/xhci-brcm.c | 16 drivers/usb/host/xhci-brcm.h | 16 drivers/usb/host/xhci-plat.c | 8 3 files changed, 40 insertions(+) create mode 100644 dr

Re: [PATCH] usb: dwc2: gadget: fix ISOC frame overflow handling

2018-11-09 Thread Minas Harutyunyan
Hi John, On 11/9/2018 12:43 PM, Minas Harutyunyan wrote: > Hi John, > > On 11/8/2018 9:37 PM, John Keeping wrote: >> Hi Minas, >> >> On Mon, 5 Nov 2018 08:28:07 + >> Minas Harutyunyan wrote: >> >>> On 10/23/2018 5:43 PM, John Keeping wrote: By clearing the overrun flag as soon as the ta

[PATCH] USB: remove the unused struct hcd_timeout definition

2018-11-09 Thread Christoph Hellwig
No users of this type anywhere in the tree. Signed-off-by: Christoph Hellwig --- include/linux/usb/hcd.h | 5 - 1 file changed, 5 deletions(-) diff --git a/include/linux/usb/hcd.h b/include/linux/usb/hcd.h index 97e2ddec18b1..7dc3a411bece 100644 --- a/include/linux/usb/hcd.h +++ b/include/l

Re: [PATCH] usb: dwc2: gadget: fix ISOC frame overflow handling

2018-11-09 Thread John Keeping
Hi Minas, On Fri, 9 Nov 2018 14:36:36 + Minas Harutyunyan wrote: > On 11/9/2018 12:43 PM, Minas Harutyunyan wrote: > > Hi John, > > > > On 11/8/2018 9:37 PM, John Keeping wrote: > >> Hi Minas, > >> > >> On Mon, 5 Nov 2018 08:28:07 + > >> Minas Harutyunyan wrote: > >> > >>> On 10/23/201

Re: [PATCH] USB: remove the unused struct hcd_timeout definition

2018-11-09 Thread Greg KH
On Fri, Nov 09, 2018 at 07:39:03PM +0100, Christoph Hellwig wrote: > No users of this type anywhere in the tree. > > Signed-off-by: Christoph Hellwig > --- > include/linux/usb/hcd.h | 5 - > 1 file changed, 5 deletions(-) > > diff --git a/include/linux/usb/hcd.h b/include/linux/usb/hcd.h >

[PATCH] usb: host: fix platform_no_drv_owner.cocci warnings

2018-11-09 Thread kbuild test robot
From: kbuild test robot drivers/usb/host/ehci-brcm.c:258:3-8: No need to set .owner here. The core will do it. Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci Fixes: 51b4c79a49f1 ("usb: host: Add ability to bui

Re: [PATCH V4 5/5] usb: host: Add ability to build new Broadcom STB USB drivers

2018-11-09 Thread kbuild test robot
Hi Al, I love your patch! Perhaps something to improve: [auto build test WARNING on usb/usb-testing] [also build test WARNING on v4.20-rc1 next-20181109] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux