URGENT RESPONSE NEEDED

Hello my dear. Did you receive my email message to you? Please, get back to me ASAP as the matter is becoming late. Expecting your urgent response. Sean.

RE: [PATCH v13 0/2] Add support for USB Type-C interface on latest NVIDIA GPU

Hi Heikki and Wolfram Do you have any comments on these changes? Regards, Ajay --nvpublic > Hi Heikki and Wolfram, > > These two changes add support for USB Type-C interface on latest NVIDIA GPU > card. > The Type-C controller used is Cypress CCGx and is over I2C interface. > > I2C host control

[PATCH 4/8] usbnet: smsc95xx: check for csum being in last four bytes

The manual states that the checksum cannot lie in the last DWORD of the transmission, so add a basic check for this and fall back to software checksumming the packet. This only seems to trigger for ACK packets with no options or data to return to the other end, and the use of the tx-alignment opti

[PATCH 1/8] usbnet: smsc95xx: fix rx packet alignment

The smsc95xx driver already takes into account the NET_IP_ALIGN parameter when setting up the receive packet data, which means we do not need to worry about aligning the packets in the usbnet driver. Adding the EVENT_NO_IP_ALIGN means that the IPv4 header is now passed to the ip_rcv() routine with

[PATCH 7/8] usbnet: smsc95xx: add usbnet -> priv function

There are a number of places in the smsc95xx driver where it gets the private-data from the usbnet passed in. It would be sensible to have one inline function to convert it and change all points in the driver to use that. Signed-off-by: Ben Dooks --- drivers/net/usb/smsc95xx.c | 47 +

[PATCH 2/8] usbnet: smsc95xx: add kconfig for turbo mode

Add a configuration option for the default state of turbo mode on the smsc95xx networking driver. Some systems it is better to default this to off as it causes significant increases in soft-irq load. Signed-off-by: Ben Dooks --- drivers/net/usb/Kconfig| 13 + drivers/net/usb/smsc

[PATCH 5/8] usbnet: smsc95xx: align tx-buffer to word

The tegra EHCI driver requires alignment of the buffer, so try and make this better by pushing the buffer start back to an word aligned address. At the worst this makes memcpy() easier as it is word aligned, at best it makes sure the usb can directly map the buffer. Signed-off-by: Ben Dooks --- C

[PATCH 6/8] usbnet: smsc95xx: fix memcpy for accessing rx-data

Change the RX code to use get_unaligned_le32() instead of the combo of memcpy and cpu_to_le32s(&var). Signed-off-by: Ben Dooks --- drivers/net/usb/smsc95xx.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c index 8

[PATCH 8/8] usbnet: smsc95xx: add rx_turbo attribute

Add attribute for the rx_turbo mode to allow run-time configuration of this feature. Note, this requires a restart of the device to take effect. Signed-off-by: Ben Dooks --- drivers/net/usb/smsc95xx.c | 41 +- 1 file changed, 40 insertions(+), 1 deletion(-)

SMSC95XX updates for packet alignment and turbo mode (V2)

This is the new seris of SMSC95XX patches to deal with the issues we found when working on this driver for a client. The new series has been tested on an Raspberry Pi3 B. Changes since v1: - Change memcpy to use {get,put}_unaligned_le32() calls - Merge tx fixups - Added rx_turbo attribute

[PATCH 3/8] usbnet: smsc95xx: simplify tx_fixup code

The smsc95xx_tx_fixup is doing multiple calls to skb_push() to put an 8-byte command header onto the packet. It would be easier to do one skb_push() and then copy the data in once the push is done. We also make the code smaller by using proper unaligned puts for the header. This merges in the CPU

Re: [PATCH 6/8] usbnet: smsc95xx: fix memcpy for accessing rx-data

Hello! On 12.10.2018 11:34, Ben Dooks wrote: Change the RX code to use get_unaligned_le32() instead of the combo of memcpy and cpu_to_le32s(&var). le32_to_cpus(), actually. Signed-off-by: Ben Dooks --- drivers/net/usb/smsc95xx.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions

[PATCH 5/7] net: cdc_ether: add usbnet -> priv function

There are a number of places in the cdc drivers where it gets the private-data from the usbnet passed in. It would be sensible to have one inline function to convert it and change all points in the driver to use that. Signed-off-by: Ben Dooks --- drivers/net/usb/cdc_ether.c | 8 ++--- drivers/

usbnet private-data accessor functions

I have been looking at the usbnet drivers and the possibility of some code cleanups. One of the things I've found is that changing the way the drivers use the private data with the usbnet structure is often hand-coded each time is needed. An easy cleanp (and making it easier in the future to chang

[PATCH 3/7] net: usb: asix88179_178a: add usbnet -> priv function

There are a number of places in the asix88179_178a driver where it gets the private-data from the usbnet passed in. It would be sensible to have one inline function to convert it and change all points in the driver to use that. Signed-off-by: Ben Dooks --- drivers/net/usb/ax88179_178a.c | 19 +++

[PATCH 4/7] net: qmi_wwan: add usbnet -> priv function

There are a number of places in the qmi_wwan driver where it gets the private-data from the usbnet passed in. It would be sensible to have one inline function to convert it and change all points in the driver to use that. Signed-off-by: Ben Dooks --- drivers/net/usb/qmi_wwan.c | 31 +

[PATCH 2/7] net: asix: add usbnet -> priv function

There are a number of places in the asix driver where it gets the private-data from the usbnet passed in. It would be sensible to have one inline function to convert it and change all points in the driver to use that. Signed-off-by: Ben Dooks --- drivers/net/usb/asix.h | 5 + driver

[PATCH 6/7] net: huawei_cdc_ncm: add usbnet -> priv function

There are a number of places in the huawei driver where it gets the private-data from the usbnet passed in. It would be sensible to have one inline function to convert it and change all points in the driver to use that. Signed-off-by: Ben Dooks --- --- drivers/net/usb/huawei_cdc_ncm.c | 15 +

[PATCH 1/7] net: smsc75xx: add usbnet -> priv function

There are a number of places in the smsc75xx driver where it gets the private-data from the usbnet passed in. It would be sensible to have one inline function to convert it and change all points in the driver to use that. Signed-off-by: Ben Dooks --- drivers/net/usb/smsc75xx.c | 31 +

[PATCH 7/7] net: usb: sr9800: add usbnet -> priv function

There are a number of places in the sr8900 driver where it gets the private-data from the usbnet passed in. It would be sensible to have one inline function to convert it and change all points in the driver to use that. Signed-off-by: Ben Dooks --- drivers/net/usb/sr9800.c | 15 ++-

Re: [PATCH 2/7] net: asix: add usbnet -> priv function

On Fri, Oct 12, 2018 at 10:16:37AM +0100, Ben Dooks wrote: > There are a number of places in the asix driver where it gets the > private-data from the usbnet passed in. It would be sensible to have > one inline function to convert it and change all points in the driver > to use that. > > Signed-of

Re: [PATCH 6/7] net: huawei_cdc_ncm: add usbnet -> priv function

On Fri, Oct 12, 2018 at 10:16:41AM +0100, Ben Dooks wrote: > There are a number of places in the huawei driver where it gets the > private-data from the usbnet passed in. It would be sensible to have > one inline function to convert it and change all points in the driver > to use that. > > Signed-

Re: [PATCH 5/7] net: cdc_ether: add usbnet -> priv function

On Fri, Oct 12, 2018 at 10:16:40AM +0100, Ben Dooks wrote: > There are a number of places in the cdc drivers where it gets the > private-data from the usbnet passed in. It would be sensible to have > one inline function to convert it and change all points in the driver > to use that. > > Signed-of

Re: [PATCH 3/7] net: usb: asix88179_178a: add usbnet -> priv function

On Fri, Oct 12, 2018 at 10:16:38AM +0100, Ben Dooks wrote: > There are a number of places in the asix88179_178a driver where it gets the > private-data from the usbnet passed in. It would be sensible to have > one inline function to convert it and change all points in the driver > to use that. > >

Re: [PATCH 7/7] net: usb: sr9800: add usbnet -> priv function

On Fri, Oct 12, 2018 at 10:16:42AM +0100, Ben Dooks wrote: > There are a number of places in the sr8900 driver where it gets the > private-data from the usbnet passed in. It would be sensible to have > one inline function to convert it and change all points in the driver > to use that. > > Signed-

Re: [PATCH 1/7] net: smsc75xx: add usbnet -> priv function

On Fri, Oct 12, 2018 at 10:16:36AM +0100, Ben Dooks wrote: > There are a number of places in the smsc75xx driver where it gets the > private-data from the usbnet passed in. It would be sensible to have > one inline function to convert it and change all points in the driver > to use that. > > Signe

Re: [PATCH 4/7] net: qmi_wwan: add usbnet -> priv function

On Fri, Oct 12, 2018 at 10:16:39AM +0100, Ben Dooks wrote: > There are a number of places in the qmi_wwan driver where it gets the > private-data from the usbnet passed in. It would be sensible to have > one inline function to convert it and change all points in the driver > to use that. > > Signe

Re: [PATCH 4/7] net: qmi_wwan: add usbnet -> priv function

Ben Dooks writes: > +static inline struct qmi_wwan_state *usbnet_to_qmi(struct usbnet *usb) > +{ > + return (void *) &usb->data; > +} checkpatch doesn't like this, and it is also inconsistent with the coding style elsewhere in the driver. CHECK: No space is necessary after a cast #30: FILE

Re: [PATCH 4/7] net: qmi_wwan: add usbnet -> priv function

On 12/10/18 11:44, Bjørn Mork wrote: Ben Dooks writes: +static inline struct qmi_wwan_state *usbnet_to_qmi(struct usbnet *usb) +{ + return (void *) &usb->data; +} checkpatch doesn't like this, and it is also inconsistent with the coding style elsewhere in the driver. Thank you for p

Re: [PATCH v3 3/3] usb: typec: tcpm: charge current handling for sink during hard reset

On Mon, 1 Oct 2018 12:45:01 -0700, Badhri Jagan Sridharan wrote: > During the initial connect to a non-pd port, sink would hard reset > twice before deeming that the port partner is non-pd. TCPM sets the > the charge path to false during the hard reset. This causes unnecessary > connects/disconnec

Re: usbnet private-data accessor functions

On Fr, 2018-10-12 at 10:16 +0100, Ben Dooks wrote: > I have been looking at the usbnet drivers and the possibility of some > code cleanups. One of the things I've found is that changing the way > the drivers use the private data with the usbnet structure is often > hand-coded each time is needed.

Re: [PATCH net-next] net: cdc_ncm: remove set but not used variable 'ctx'

From: YueHaibing Date: Fri, 12 Oct 2018 01:49:13 + > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/usb/cdc_ncm.c: In function 'cdc_ncm_status': > drivers/net/usb/cdc_ncm.c:1603:22: warning: > variable 'ctx' set but not used [-Wunused-but-set-variable] > struct cdc_ncm_ctx

WARNING in usb_submit_urb (3)

Hello, syzbot found the following crash on: HEAD commit:9dcd936c5312 Merge tag 'for-4.19/dm-fixes-4' of git://git... git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=123b8da140 kernel config: https://syzkaller.appspot.com/x/.config?x=88e9a8a39dc0be2d da