[PATCH -next] USB: serial: quatech2: remove set but not used variable 'port_priv'

2018-10-11 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/usb/serial/quatech2.c: In function 'qt2_process_read_urb': drivers/usb/serial/quatech2.c:503:27: warning: variable 'port_priv' set but not used [-Wunused-but-set-variable] It not used any more after commit 2be818a116b2 ("Revert "USB: quatech

Re: KASAN: slab-out-of-bounds Read in vhci_hub_control

2018-10-11 Thread Dmitry Vyukov
On Wed, Oct 10, 2018 at 10:26 PM, Shuah Khan wrote: > On 10/10/2018 01:42 PM, Dmitry Vyukov wrote: >> On Tue, Oct 2, 2018 at 6:04 PM, Shuah Khan wrote: >>> On 09/04/2018 12:52 PM, syzbot wrote: Hello, syzbot found the following crash on: HEAD commit:420f51f4ab6b Merge

P/Contact

2018-10-11 Thread Allen Yun
Dear Sir Please contact for detailed information of funds transfer based on your surname, Your prompt response will be highly appreciated. Kind Regards, Allen Yun B.Group manager contact id..

[PATCH] net: cdc_ncm: use tasklet_init() for tasklet_struct init

2018-10-11 Thread Ben Dooks
The tasklet initialisation would be better done by tasklet_init() instead of assuming all the fields are in an ok state by default. This does not fix any actual know bug. Signed-off-by: Ben Dooks --- drivers/net/usb/cdc_ncm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a

Re: [PATCH] usbip: vhci_hcd: Check rhport everywhere in vhci_hub_control()

2018-10-11 Thread Shuah Khan
Hi Ben, Thanks for the patch. On 10/10/2018 11:30 PM, Ben Hutchings wrote: > Commit 5b22f676118f "usbip: vhci_hcd: check rhport before using in > vhci_hub_control()" added some validation of rhport, but left > several problems: > > - If VHCI_HC_PORTS < 256, we can get rhport >= VHCI_HC_PORTS whi

Re: Query on usb/core/devio.c

2018-10-11 Thread Mayuresh Kulkarni
On Tue, 9 Oct 2018 13:27:02 +0200 Greg KH wrote: > On Tue, Oct 09, 2018 at 10:51:53AM +0100, Mayuresh Kulkarni wrote: > > With all due respect, one of the possible reason for this could be, > > power saving on mobile/tablet platforms (running Android). These > > platforms usually have a single US

Re: Query on usb/core/devio.c

2018-10-11 Thread Alan Stern
On Thu, 11 Oct 2018, Mayuresh Kulkarni wrote: > On Tue, 9 Oct 2018 13:27:02 +0200 > Greg KH wrote: > > > On Tue, Oct 09, 2018 at 10:51:53AM +0100, Mayuresh Kulkarni wrote: > > > With all due respect, one of the possible reason for this could be, > > > power saving on mobile/tablet platforms (run

Re: usbfs zerocopy broken on ARM/ARM64

2018-10-11 Thread Alan Stern
On Sun, 7 Oct 2018, Steve Markgraf wrote: > Hi, > > I'm the author of a userspace library that makes use of the usbfs > zerocopy-feature via libusb-1.0, and recently received a bug report that > garbage data is received with bulk transfers on ARM-based systems. > > When I debugged the issue, I f

[PATCH v2] usb: host: add DT bindings for faraday fotg2

2018-10-11 Thread Linus Walleij
From: Hans Ulli Kroll This adds device tree bindings for the Faraday FOTG2 dual-mode host controller. Cc: devicet...@vger.kernel.org Signed-off-by: Hans Ulli Kroll Acked-by: Rob Herring Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Changed "OTH" to "OTG" - Collected Rob's ACK. - I don'

Re: [PATCH 5/6] usb: musb: gadget: implement send_response

2018-10-11 Thread Bin Liu
Hi, On Tue, Oct 09, 2018 at 10:49:02PM -0400, Paul Elder wrote: > This patch implements a mechanism to signal the MUSB driver to reply to > a control OUT request with STALL or ACK. > > Signed-off-by: Paul Elder > Reviewed-by: Laurent Pinchart The patch looks good to me, here is my Acked-by: A

Re: [PATCH 4/6] usb: gadget: add functions to signal udc driver to delay status stage

2018-10-11 Thread Bin Liu
Hi, On Tue, Oct 09, 2018 at 10:49:01PM -0400, Paul Elder wrote: > A usb gadget function driver may or may not want to delay the status > stage of a control OUT request. An instance it might want to is to > asynchronously validate the data of a class-specific request. > > Add a function usb_ep_del

Re: [PATCH] net: cdc_ncm: use tasklet_init() for tasklet_struct init

2018-10-11 Thread David Miller
From: Ben Dooks Date: Thu, 11 Oct 2018 14:03:32 +0100 > The tasklet initialisation would be better done by tasklet_init() > instead of assuming all the fields are in an ok state by default. > > This does not fix any actual know bug. > > Signed-off-by: Ben Dooks Applied to net-next.

Re: [PATCH 0/6] usb: gadget: add mechanism to asynchronously validate data stage of ctrl out request

2018-10-11 Thread Bin Liu
Hi, On Tue, Oct 09, 2018 at 10:48:57PM -0400, Paul Elder wrote: > This patch series adds a mechanism to allow asynchronously validating > the data stage of a control out request, and for stalling or suceeding > the request accordingly. This mechanism is implemented for MUSB, and is > used by UVC.

RE: [RFC] usb: chipidea: Add minimal support for HSIC interface on i.MX6QDL

2018-10-11 Thread Peter Chen
> > Thanks, I should do it earlier, I could not find a suitable board with HSIC > > support > at mainline kernel. > > It is very kind that you could help on it and test function at real > > board. My suggestion is follow all flows in Link [2] since we need to cover > suspend/resume and remote wa

[PATCH net-next] net: cdc_ncm: remove set but not used variable 'ctx'

2018-10-11 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/net/usb/cdc_ncm.c: In function 'cdc_ncm_status': drivers/net/usb/cdc_ncm.c:1603:22: warning: variable 'ctx' set but not used [-Wunused-but-set-variable] struct cdc_ncm_ctx *ctx; It not used any more after commit fa83dbeee558 ("net: cdc_ncm