[GIT PULL] USB for v4.20 merge window

Hi Greg, Here's my pull request for v4.20 merge window. Most of the changes are on the UVC gadget driver. Seems like we'll have a calm merge window for USB folks this time around. Let me know if you want anything to be changed. The following changes since commit 17b57b1883c1285f3d0dc2266e8f7928

Re: [PATCH v2 -next] USB: cypress_m8: remove set but not used variables 'iflag'

On Thu, Oct 04, 2018 at 07:09:53AM +, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/usb/serial/cypress_m8.c: In function 'cypress_set_termios': > drivers/usb/serial/cypress_m8.c:866:18: warning: > variable 'iflag' set but not used [-Wunused-but-set-variable] >

Re: [GIT PULL] USB for v4.20 merge window

On Fri, Oct 05, 2018 at 11:07:31AM +0300, Felipe Balbi wrote: > > Hi Greg, > > Here's my pull request for v4.20 merge window. Most of the changes are > on the UVC gadget driver. Seems like we'll have a calm merge window for > USB folks this time around. Now pulled and pushed out, thanks. greg k

USB mass storage device inaccessible, freezes lsusb

Dear Linux USB experts, I noticed that a device (Garmin Foretrex 601, firmware version 2.80) that is supposed to present itself as USB mass storage, does not work on Linux. After being connected, the device does show up in the output of lsusb (ID 091e:0003): $ lsusb Bus 002 Device 002: ID 8087:0

[PATCH -next] usb/early: remove set but not used variable 'remain_length'

Fixes gcc '-Wunused-but-set-variable' warning: drivers/usb/early/xhci-dbc.c: In function 'xdbc_handle_tx_event': drivers/usb/early/xhci-dbc.c:720:9: warning: variable 'remain_length' set but not used [-Wunused-but-set-variable] It never be used since introduction in commit aeb9dd1de98c ("usb/ea

[PATCH net-next 02/19] net: usb: aqc111: Add bind and empty unbind callbacks

From: Dmitry Bezrukov Initialize net_device_ops structure Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/drivers/net/usb/aqc111.c b/drivers/net/usb/aqc111.c index

[PATCH net-next 01/19] net: usb: aqc111: Driver skeleton for Aquantia AQtion USB to 5GbE

From: Dmitry Bezrukov Initialize usb_driver structure skeleton Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/Kconfig | 12 +++ drivers/net/usb/Makefile | 1 + drivers/net/usb/aqc111.c | 52 3 files ch

[PATCH net-next 00/19] Add support for Aquantia AQtion USB to 5/2.5GbE devices

This patchset introduces support for new multigig ethernet to USB dongle, developed jointly by Aquantia (Phy) and ASIX (USB MAC). The driver has similar structure with other ASIX MAC drivers (AX88179), but with a number of important differences: - Driver supports both direct Phy and custom firmwar

[PATCH net-next 08/19] net: usb: aqc111: Implement TX data path

From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 73 drivers/net/usb/aqc111.h | 22 +++ 2 files changed, 95 insertions(+) diff --git a/drivers/net/usb/aqc111.c b/driver

[PATCH net-next 17/19] net: usb: aqc111: Initialize ethtool_ops structure

From: Dmitry Bezrukov Implement get_drvinfo, set/get_msglevel, get_link callbacks Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/drivers/net/usb/aqc111.c b/drivers/net

[PATCH net-next 03/19] net: usb: aqc111: Add implementation of read and write commands

From: Dmitry Bezrukov Read/write command register defines and functions Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 124 +++ drivers/net/usb/aqc111.h | 19 2 files changed, 143 insertions(+)

[PATCH net-next 07/19] net: usb: aqc111: Add support for getting and setting of MAC address

From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 51 drivers/net/usb/aqc111.h | 1 + 2 files changed, 52 insertions(+) diff --git a/drivers/net/usb/aqc111.c b/drivers/net/usb/aqc1

[PATCH net-next 13/19] net: usb: aqc111: Add support for TSO

From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 3 +++ drivers/net/usb/aqc111.h | 6 -- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/net/usb/aqc111.c b/drivers/net/usb/aqc111.c index 6efd9a9ad44e..f6

[PATCH net-next 16/19] net: usb: aqc111: Add RX VLAN filtering support

From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 90 drivers/net/usb/aqc111.h | 2 +- 2 files changed, 91 insertions(+), 1 deletion(-) diff --git a/drivers/net/usb/aqc111.c b/driv

[PATCH net-next 06/19] net: usb: aqc111: Introduce link management

From: Dmitry Bezrukov Add full hardware initialization sequence and link configuration logic Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 330 +++ drivers/net/usb/aqc111.h | 51 2 files changed

[PATCH net-next 18/19] net: usb: aqc111: Implement get/set_link_ksettings callbacks

From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 133 +++ 1 file changed, 133 insertions(+) diff --git a/drivers/net/usb/aqc111.c b/drivers/net/usb/aqc111.c index ade2b60b4811..20d4347e

[PATCH net-next 19/19] net: usb: aqc111: Add support for wake on LAN by MAGIC packet

From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 203 +++ drivers/net/usb/aqc111.h | 11 +++ 2 files changed, 214 insertions(+) diff --git a/drivers/net/usb/aqc111.c b/drivers/net/usb/

[PATCH net-next 05/19] net: usb: aqc111: Introduce PHY access

From: Dmitry Bezrukov Implement PHY power up/down sequences. AQC111, depending on FW used, may has PHY being controlled either directly (dpa = 1) or via vendor command interface (dpa = 0). Drivers supports both themes. We determine this from firmware versioning agreement. Signed-off-by: Dmitry B

[PATCH net-next 15/19] net: usb: aqc111: Add support for VLAN_CTAG_TX/RX offload

From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 14 ++ drivers/net/usb/aqc111.h | 7 ++- 2 files changed, 20 insertions(+), 1 deletion(-) diff --git a/drivers/net/usb/aqc111.c b/drivers/net/usb/aqc111.c index cc

[PATCH net-next 12/19] net: usb: aqc111: Add support for enable/disable checksum offload

From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 45 - drivers/net/usb/aqc111.h | 1 + 2 files changed, 45 insertions(+), 1 deletion(-) diff --git a/drivers/net/usb/aqc111.c b/drivers/

[PATCH net-next 09/19] net: usb: aqc111: Implement RX data path

From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 100 +++ drivers/net/usb/aqc111.h | 39 ++ 2 files changed, 139 insertions(+) diff --git a/drivers/net/usb/aqc111.c b/d

[PATCH net-next 14/19] net: usb: aqc111: Implement set_rx_mode callback

From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 72 drivers/net/usb/aqc111.h | 4 +++ 2 files changed, 71 insertions(+), 5 deletions(-) diff --git a/drivers/net/usb/aqc111.c b/dr

[PATCH net-next 10/19] net: usb: aqc111: Add checksum offload support

From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 38 ++ drivers/net/usb/aqc111.h | 23 +-- 2 files changed, 59 insertions(+), 2 deletions(-) diff --git a/drivers/net/usb/aqc

[PATCH net-next 11/19] net: usb: aqc111: Add support for changing MTU

From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 63 +++- 1 file changed, 62 insertions(+), 1 deletion(-) diff --git a/drivers/net/usb/aqc111.c b/drivers/net/usb/aqc111.c index 5967f7ad

[PATCH net-next 04/19] net: usb: aqc111: Various callbacks implementation

From: Dmitry Bezrukov Reset, stop callbacks, driver unbind callback. More register defines required for these callbacks. Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 48 ++ drivers/net/usb/aqc111.h | 101 ++

Re: [PATCH 0/2] USB: serial: gpio line-name fix and FT232R CBUS gpio support

On Mon, Oct 01, 2018 at 11:43:55AM +0200, Linus Walleij wrote: > On Sun, Sep 30, 2018 at 2:29 PM Johan Hovold wrote: > > Linus, we finally got around to adding gpio support for FTDI devices; > > see commit > > > > ba93cc7da896 ("USB: serial: ftdi_sio: implement GPIO support for > > FT-X

Re: [PATCH net-next 06/19] net: usb: aqc111: Introduce link management

On Fri, Oct 05, 2018 at 10:24:55AM +, Igor Russkikh wrote: > From: Dmitry Bezrukov > > Add full hardware initialization sequence and link configuration logic Hi Igor, Dmitry Please could you explain why you decided to not use drivers/net/phy? The previous patch introduced basically what you

Re: [PATCH net-next 02/19] net: usb: aqc111: Add bind and empty unbind callbacks

From: Igor Russkikh Date: Fri, 5 Oct 2018 10:24:42 + > +static int aqc111_bind(struct usbnet *dev, struct usb_interface *intf) > +{ > + int ret; > + struct usb_device *udev = interface_to_usbdev(intf); Please always order local variable declarations from longest to shortest line (rev

Re: [PATCH net-next 03/19] net: usb: aqc111: Add implementation of read and write commands

From: Igor Russkikh Date: Fri, 5 Oct 2018 10:24:44 + > +static int __aqc111_read_cmd(struct usbnet *dev, u8 cmd, u16 value, > + u16 index, u16 size, void *data, int nopm) > +{ > + int ret; > + int (*fn)(struct usbnet *dev, u8 cmd, u8 reqtype, u16 value, > +

Re: [PATCH net-next 06/19] net: usb: aqc111: Introduce link management

From: Igor Russkikh Date: Fri, 5 Oct 2018 10:24:55 + > + switch (aqc111_data->link_speed) { > + case AQ_INT_SPEED_5G: > + { > + link_speed = 5000; > + reg8 = 0x05; > + reg16 = 0x001F; > + break; > + } Please do not put curly bra

Re: [PATCH] usbnet: smsc95xx: simplify tx_fixup code

From: Ben Dooks Date: Tue, 2 Oct 2018 17:56:02 +0100 > - memcpy(skb->data, &tx_cmd_a, 4); > + ptr = skb_push(skb, 8); > + tx_cmd_a = cpu_to_le32(tx_cmd_a); > + tx_cmd_b = cpu_to_le32(tx_cmd_b); > + memcpy(ptr, &tx_cmd_a, 4); > + memcpy(ptr+4, &tx_cmd_b, 4); Even a memcpy

Re: [PATCH net-next 05/19] net: usb: aqc111: Introduce PHY access

On Fri, Oct 05, 2018 at 10:24:53AM +, Igor Russkikh wrote: > From: Dmitry Bezrukov > > Implement PHY power up/down sequences. > AQC111, depending on FW used, may has PHY being controlled either > directly (dpa = 1) or via vendor command interface (dpa = 0). Hi Igor dpa is not a very descrip

[PATCH] selftests: usbip: add wait after attach and before checking port status

Add sleep between attach and "usbip port" check to make sure status is updated. Running attach and query back shows incorrect status. Signed-off-by: Shuah Khan (Samsung OSG) --- tools/testing/selftests/drivers/usb/usbip/usbip_test.sh | 4 1 file changed, 4 insertions(+) diff --git a/tools/

[PATCH] usb: usbip: Fix BUG: KASAN: slab-out-of-bounds in vhci_hub_control()

vhci_hub_control() accesses port_status array with out of bounds port value. Fix it to reference port_status[] only with a valid rhport value when invalid_rhport flag is true. The invalid_rhport flag is set early on after detecting in port value is within the bounds or not. The following is used

Re: [PATCH net-next 07/19] net: usb: aqc111: Add support for getting and setting of MAC address

On Fri, Oct 05, 2018 at 10:24:58AM +, Igor Russkikh wrote: > From: Dmitry Bezrukov > > Signed-off-by: Dmitry Bezrukov > Signed-off-by: Igor Russkikh > --- > drivers/net/usb/aqc111.c | 51 > > drivers/net/usb/aqc111.h | 1 + > 2 files chang

Re: [PATCH net-next 08/19] net: usb: aqc111: Implement TX data path

> +static struct sk_buff *aqc111_tx_fixup(struct usbnet *dev, struct sk_buff > *skb, > +gfp_t flags) > +{ > + struct aq_tx_packet_desc tx_hdr; > + int frame_size = dev->maxpacket; > + int headroom = 0; > + int tailroom = 0; > + int padding_si

Re: [PATCH net-next 09/19] net: usb: aqc111: Implement RX data path

> +static int aqc111_rx_fixup(struct usbnet *dev, struct sk_buff *skb) > +{ > + struct sk_buff *new_skb = NULL; > + u32 skb_len = 0; > + u32 desc_offset = 0; /*RX Header Offset*/ > + u32 start_of_descs = 0; > + u16 pkt_count = 0; > + u32 pkt_total_offset = 0; > + struct