Re: [Bug 200917] 4.18 regression: I/O error on external icybox disk enclosures

2018-10-03 Thread Klaus Kusche
Hello, On 09/09/2018 21:28, Alan Stern wrote: On Sun, 9 Sep 2018, Klaus Kusche wrote: Hello, On 01/09/2018 17:38, Alan Stern wrote: However, the USB layer does set certain quirk bits which can cause those other parts to avoid sending certain commands. Perhaps your controller needs the BRO

Re: [Bug 200917] 4.18 regression: I/O error on external icybox disk enclosures

2018-10-03 Thread Alan Stern
On Wed, 3 Oct 2018, Klaus Kusche wrote: > Hello, > > On 09/09/2018 21:28, Alan Stern wrote: > > On Sun, 9 Sep 2018, Klaus Kusche wrote: > > > >> Hello, > >> > >> On 01/09/2018 17:38, Alan Stern wrote: > >>> However, the USB layer does set certain quirk bits which can cause > >>> those other part

Re: USB hotplug on HP 255 G6 laptop

2018-10-03 Thread Mathias Nyman
On 02.10.2018 17:53, Jan Kara wrote: On Tue 02-10-18 17:01:54, Mathias Nyman wrote: On 02.10.2018 16:06, Jan Kara wrote: Hello, my wife has HP 255 G6 laptop. When it is attached to AC, everything works as expected however when it is running on battery, USB hotplug stops working - newly plugged

Re: USB hotplug on HP 255 G6 laptop

2018-10-03 Thread Jan Kara
On Wed 03-10-18 17:19:33, Mathias Nyman wrote: > On 02.10.2018 17:53, Jan Kara wrote: > > On Tue 02-10-18 17:01:54, Mathias Nyman wrote: > > > On 02.10.2018 16:06, Jan Kara wrote: > > > > Hello, > > > > > > > > my wife has HP 255 G6 laptop. When it is attached to AC, everything > > > > works > >

[PATCH v13 0/2] Add support for USB Type-C interface on latest NVIDIA GPU

2018-10-03 Thread Ajay Gupta
Hi Heikki and Wolfram, These two changes add support for USB Type-C interface on latest NVIDIA GPU card. The Type-C controller used is Cypress CCGx and is over I2C interface. I2C host controller has known limitation of sending STOP after every read. Since each read can be of 4 byte maximum lengt

[PATCH v13 2/2] usb: typec: ucsi: add support for Cypress CCGx

2018-10-03 Thread Ajay Gupta
Latest NVIDIA GPU cards have a Cypress CCGx Type-C controller over I2C interface. This UCSI I2C driver uses I2C bus driver interface for communicating with Type-C controller. Signed-off-by: Ajay Gupta Reviewed-by: Andy Shevchenko Acked-by: Heikki Krogerus --- Changes from v1 -> v2 Fixe

[PATCH v13 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-10-03 Thread Ajay Gupta
Latest NVIDIA GPU card has USB Type-C interface. There is a Type-C controller which can be accessed over I2C. This driver adds I2C bus driver to communicate with Type-C controller. I2C client driver will be part of USB Type-C UCSI driver. Signed-off-by: Ajay Gupta Reviewed-by: Andy Shevchenko R

Re: [PATCH -next] USB: cypress_m8: remove set but not used variables 'actual_size, iflag'

2018-10-03 Thread YueHaibing
On 2018/10/1 15:19, Dan Carpenter wrote: > On Sun, Sep 30, 2018 at 06:02:24PM +0200, Johan Hovold wrote: >> On Sat, Sep 29, 2018 at 09:54:03AM +, YueHaibing wrote: >>> Fixes gcc '-Wunused-but-set-variable' warning: >>> >>> drivers/usb/serial/cypress_m8.c: In function 'cypress_send': >>> drivers

[PATCH v2 -next] USB: core: remove set but not used variable 'udev'

2018-10-03 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/usb/core/driver.c: In function 'usb_driver_claim_interface': drivers/usb/core/driver.c:513:21: warning: variable 'udev' set but not used [-Wunused-but-set-variable] Since commit c183813fcee44a24 ("USB: remove LPM management from usb_driver_

[PATCH v2 -next] USB: cypress_m8: remove set but not used variables 'iflag'

2018-10-03 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/usb/serial/cypress_m8.c: In function 'cypress_set_termios': drivers/usb/serial/cypress_m8.c:866:18: warning: variable 'iflag' set but not used [-Wunused-but-set-variable] Signed-off-by: YueHaibing --- v2: only fix 'iflag' warning --- drive

[PATCH][usb-next] usb: core: fix memory leak on port_dev_path allocation

2018-10-03 Thread Colin King
From: Colin Ian King Currently the allocation of port_dev_path from the call to kobject_get_path is not being kfree'd, causing a memory leak. Fix this by kfree'ing this at the end of the function. Add an extra error exit path to fix one of the early leaks when envp[0] fails to be allocated. Dete

[PATCH] usb: host: xhci: Find usb-phy by phandle if of_node not supported

2018-10-03 Thread Anurag Kumar Vulisha
There are use cases where the usb phy is created at runtime and added into sysdev (for example phy-generic.c creates the usb phy during probe and adds the phy to phy list using usb_add_phy_dev). In this case, the sysdev may not have the "usb-phy" phandle added. So, the existing devm_usb_get_phy_by_

RE: [PATCH] usbnet: smsc95xx: simplify tx_fixup code

2018-10-03 Thread David Laight
From: Ben Dooks > Sent: 02 October 2018 17:56 > > The smsc95xx_tx_fixup is doing multiple calls to skb_push() to > put an 8-byte command header onto the packet. It would be easier > to do one skb_push() and then copy the data in once the push is > done. > > Signed-off-by: Ben Dooks > --- > driv

Re: [PATCH] usb: core: Check portchange C_PORT_RESET after resetting

2018-10-03 Thread Alan Stern
On Wed, 3 Oct 2018, Kai-Heng Feng wrote: > Based on USB2.0 Spec Section 11.24.2.7.2.5: > > "This bit is set when the port transitions from the Resetting state (or, > if present, the Speed_eval state) to the Enabled state." > > Also Section 11.24.2.13: > > "Setting the reset feature PORT_R

RE: [PATCH] usbnet: smsc95xx: simplify tx_fixup code

2018-10-03 Thread Ben Dooks
On 2018-10-03 14:36, David Laight wrote: From: Ben Dooks Sent: 02 October 2018 17:56 The smsc95xx_tx_fixup is doing multiple calls to skb_push() to put an 8-byte command header onto the packet. It would be easier to do one skb_push() and then copy the data in once the push is done. Signed-off-

[PATCH] usb: host: xhci: Set the controller as wakeup capable

2018-10-03 Thread Anurag Kumar Vulisha
This patch modifies the xhci_plat_probe() to set the controller as wakeup capable if "wakeup-source" is added into the device node. Signed-off-by: Anurag Kumar Vulisha --- drivers/usb/host/xhci-plat.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/usb/host/xhci-plat.c b/drivers/