Re: UVC gadget changes for v4.20

2018-10-02 Thread Felipe Balbi
Hi, Laurent Pinchart writes: > Hi Felipe, > > (CC'ing Greg, in case you're on vacation) > > Ping ? I'd really like to get this merged in v4.20. Do you think that would > be > possible ? applying patches today. Are you merging this elsewhere or can I take it as patches? -- balbi signatur

Re: [PATCH v12 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-10-02 Thread Wolfram Sang
Hi, > > > We got confirmation from HW team about 4 byte read limitation. There > > > has to be a STOP after every single read cycle. One read cycle > > > supports maximum of > > > 4 byte burst. I will update the patches with a comment on this. > > > > Could it be that this is more an SMBus contro

Re: [PATCH] usb: dwc2: disable power_down on rockchip devices

2018-10-02 Thread Felipe Balbi
Hi, Hal Emmerich writes: > From 04fbf78e4e569bf872f1ffcb0a6f9b89569dc913 Mon Sep 17 00:00:00 2001 > From: Hal Emmerich > Date: Thu, 19 Jul 2018 21:48:08 -0500 > Subject: [PATCH] usb: dwc2: disable power_down on rockchip devices > >  The bug would let the usb controller enter partial power down

Re: [PATCH 0/2] USB: gadget core: Call ->disconnect() from usb_gadget_disconnect()

2018-10-02 Thread Felipe Balbi
Hi, Alan Stern writes: > Felipe: > > The following patches concern ->disconnect() callbacks made when a > gadget's D+ pullup is turned off. Currently we don't have a fixed rule > for such callbacks. > > The first patch makes usb_gadget_disconnect() issue the callback > automatically, so that

Re: UVC gadget changes for v4.20

2018-10-02 Thread Laurent Pinchart
Hi Felipe, On Tuesday, 2 October 2018 10:26:25 EEST Felipe Balbi wrote: > Laurent Pinchart writes: > > Hi Felipe, > > > > (CC'ing Greg, in case you're on vacation) > > > > Ping ? I'd really like to get this merged in v4.20. Do you think that > > would be possible ? > > applying patches today.

Re: UVC gadget changes for v4.20

2018-10-02 Thread Felipe Balbi
Hi, Laurent Pinchart writes: > On Tuesday, 2 October 2018 10:26:25 EEST Felipe Balbi wrote: >> Laurent Pinchart writes: >> > Hi Felipe, >> > >> > (CC'ing Greg, in case you're on vacation) >> > >> > Ping ? I'd really like to get this merged in v4.20. Do you think that >> > would be possible ?

HID gadget driver supports get/set features ?

2018-10-02 Thread Ranran
Hello, >From my reading about HID gadget driver (hidg), it seems that it support input reports, but not get/set features. This is my understanding from the documentation: https://www.kernel.org/doc/Documentation/usb/gadget_hid.txt Is that correct ? Thank you, ranran

Re: HID gadget driver supports get/set features ?

2018-10-02 Thread Felipe Balbi
Ranran writes: > Hello, > > From my reading about HID gadget driver (hidg), it seems that it > support input reports, but not get/set features. > This is my understanding from the documentation: > https://www.kernel.org/doc/Documentation/usb/gadget_hid.txt > > Is that correct ? you might wanna r

USB hotplug on HP 255 G6 laptop

2018-10-02 Thread Jan Kara
Hello, my wife has HP 255 G6 laptop. When it is attached to AC, everything works as expected however when it is running on battery, USB hotplug stops working - newly plugged devices do not appear to be visible to the kernel. Only when the AC is plugged back in, the kernel suddently wakes up and de

Re: USB hotplug on HP 255 G6 laptop

2018-10-02 Thread Mathias Nyman
On 02.10.2018 16:06, Jan Kara wrote: Hello, my wife has HP 255 G6 laptop. When it is attached to AC, everything works as expected however when it is running on battery, USB hotplug stops working - newly plugged devices do not appear to be visible to the kernel. Only when the AC is plugged back i

Re: [PATCH 0/2] USB: gadget core: Call ->disconnect() from usb_gadget_disconnect()

2018-10-02 Thread Alan Stern
On Tue, 2 Oct 2018, Felipe Balbi wrote: > Hi, > > Alan Stern writes: > > Felipe: > > > > The following patches concern ->disconnect() callbacks made when a > > gadget's D+ pullup is turned off. Currently we don't have a fixed rule > > for such callbacks. > > > > The first patch makes usb_gadg

[PATCH 1/2] USB: gadget core: Issue ->disconnect() callback from usb_gadget_disconnect()

2018-10-02 Thread Alan Stern
The gadget documentation doesn't state clearly whether a gadget driver's ->disconnect() callback should be invoked when the D+ pullup is turned off. Some UDC drivers do this and some don't. This patch settles the issue by making the core function usb_gadget_disconnect() issue the callback, so tha

[PATCH 2/2] USB: net2280: Remove ->disconnect() callback from net2280_pullup()

2018-10-02 Thread Alan Stern
The net2280 UDC driver invokes the gadget driver's ->disconnect() callback routine when the net2280_pullup() routine turns off the D+ pullup. This is now unnecessary, because the gadget core performs the callback on our behalf. This patch removes the unneeded callback. Signed-off-by: Alan Stern

Re: USB hotplug on HP 255 G6 laptop

2018-10-02 Thread Jan Kara
On Tue 02-10-18 17:01:54, Mathias Nyman wrote: > On 02.10.2018 16:06, Jan Kara wrote: > > Hello, > > > > my wife has HP 255 G6 laptop. When it is attached to AC, everything works > > as expected however when it is running on battery, USB hotplug stops > > working - newly plugged devices do not app

RE: [PATCH v12 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-10-02 Thread Ajay Gupta
Hi Wolfram, > > > > We got confirmation from HW team about 4 byte read limitation. > > > > There has to be a STOP after every single read cycle. One read > > > > cycle supports maximum of > > > > 4 byte burst. I will update the patches with a comment on this. > > > > > > Could it be that this is m

Re: ioctl for HID Power devices (UPS) always returning 0

2018-10-02 Thread Greg KH
On Sun, Sep 30, 2018 at 08:15:16PM +0200, Laurent Bigonville wrote: > Le 30/09/18 à 13:59, Laurent Bigonville a écrit : > > Hello, > > > > For quite some time, upower is not properly displaying the information > > from my Eaton UPS, looking at this it seems that the kernel is not > > returning the

Re: UVC gadget changes for v4.20

2018-10-02 Thread Greg KH
On Tue, Oct 02, 2018 at 01:03:34PM +0300, Felipe Balbi wrote: > > Hi, > > Laurent Pinchart writes: > > On Tuesday, 2 October 2018 10:26:25 EEST Felipe Balbi wrote: > >> Laurent Pinchart writes: > >> > Hi Felipe, > >> > > >> > (CC'ing Greg, in case you're on vacation) > >> > > >> > Ping ? I'd

Re: Inaccessible dual-role port on CherryTrail

2018-10-02 Thread Rob Weber
On Wed, Sep 19, 2018 at 02:36:17PM +0300, Heikki Krogerus wrote: > > I noticed that bits [21:20] are set as 0b11. The datasheet describes > > these bits as software configuration of the OTG_ID signal functionality. > > With these bits set, does that mean that the OS is expected to be > > configurin

[PATCH] usb: dwc2: disable power_down on rockchip devices

2018-10-02 Thread SolidHal
The bug would let the usb controller enter partial power down, which was formally known as hibernate, upon boot if nothing was plugged in to the port. Partial power down couldn't be exited properly, so any usb devices plugged in after boot would not be usable. Before the name change, params.h

Re: [PATCH v6 3/4] arm64: dts: dwc3: description of incr burst type

2018-10-02 Thread Felipe Balbi
Hi, linux-usb-ow...@vger.kernel.org writes: > On Tue, Jul 24, 2018 at 6:23 PM Rob Herring wrote: >> >> On Mon, Jul 23, 2018 at 06:32:38PM +0800, Pengbo Mu wrote: >> > Add description of 'snps,incr-burst-type-adjustment' to binding >> > so that configuring devicetree. >> > >> > Signed-off-by: Ra

[PATCH 4/4] usbnet: smsc95xx: fix rx packet alignment

2018-10-02 Thread Ben Dooks
The smsc95xx driver already takes into account the NET_IP_ALIGN parameter when setting up the receive packet data, which means we do not need to worry about aligning the packets in the usbnet driver. Adding the EVENT_NO_IP_ALIGN means that the IPv4 header is now passed to the ip_rcv() routine with

[PATCH 3/4] usbnet: smsc95xx: check for csum being in last four bytes

2018-10-02 Thread Ben Dooks
The manual states that the checksum cannot lie in the last DWORD of the transmission, so add a basic check for this and fall back to software checksumming the packet. This only seems to trigger for ACK packets with no options or data to return to the other end, and the use of the tx-alignment opti

[PATCH 1/4] usbnet: smsc95xx: add kconfig for turbo mode

2018-10-02 Thread Ben Dooks
Add a configuration option for the default state of turbo mode on the smsc95xx networking driver. Some systems it is better to default this to off as it causes significant increases in soft-irq load. Signed-off-by: Ben Dooks --- drivers/net/usb/Kconfig| 9 + drivers/net/usb/smsc95xx.

[PATCH 2/4] usbnet: smsc95xx: align tx-buffer to word

2018-10-02 Thread Ben Dooks
The tegra driver requires alignment of the buffer, so try and make this better by pushing the buffer start back to an word aligned address. At the worst this makes memcpy() easier as it is word aligned, at best it makes sure the usb can directly map the buffer. Signed-off-by: Ben Dooks [todo - ma

SMSC95XX driver updates

2018-10-02 Thread Ben Dooks
I have been doing some work with tegra3 systems which have a smsc9512 USB network device on them. A couple of issues we found with alignment of the data (both receive and transmit) and an issue where the automatic transmit checksum failed.

Re: [PATCH 3/4] usbnet: smsc95xx: check for csum being in last four bytes

2018-10-02 Thread Sergei Shtylyov
Hello! On 10/2/2018 12:26 PM, Ben Dooks wrote: The manual states that the checksum cannot lie in the last DWORD of the transmission, so add a basic check for this and fall back to software checksumming the packet. This only seems to trigger for ACK packets with no options or data to return to

[PATCH] usb: gadget: udc: renesas_usb3: Fix b-device mode for "workaround"

2018-10-02 Thread Yoshihiro Shimoda
If the "workaround_for_vbus" is true, the driver will not call usb_disconnect(). So, since the controller keeps some registers' value, the driver doesn't re-enumarate suitable speed after the b-device mode is disabled. To fix the issue, this patch adds usb_disconnect() calling in renesas_usb3_b_dev

[PATCH 2/2] usb: gadget: udc: renesas_usb3: add support for r8a77990

2018-10-02 Thread Yoshihiro Shimoda
Since r8a77990 (R-Car E3) doesn't have VBUS detect pin and number of ramif is 4, this patch adds a new renesas_usb3_priv variable for the SoC. Signed-off-by: Yoshihiro Shimoda --- drivers/usb/gadget/udc/renesas_usb3.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/usb/g

[PATCH 1/2] dt-bindings: usb: renesas_usb3: add bindings for r8a77990

2018-10-02 Thread Yoshihiro Shimoda
This patch adds bindings for r8a77990 (R-Car E3). Signed-off-by: Yoshihiro Shimoda --- Documentation/devicetree/bindings/usb/renesas_usb3.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/usb/renesas_usb3.txt b/Documentation/devicetree/bindings/usb/renesa

[PATCH 0/2] usb: gadget: udc: renesas_usb3: add support for r8a77990

2018-10-02 Thread Yoshihiro Shimoda
This patch set is based on the latest Greg's usb.git / usb-testing branch. Yoshihiro Shimoda (2): dt-bindings: usb: renesas_usb3: add bindings for r8a77990 usb: gadget: udc: renesas_usb3: add support for r8a77990 Documentation/devicetree/bindings/usb/renesas_usb3.txt | 1 + drivers/usb/gadg

Re: [PATCH 1/2] dt-bindings: usb: renesas_usb3: add bindings for r8a77990

2018-10-02 Thread Felipe Balbi
Yoshihiro Shimoda writes: > This patch adds bindings for r8a77990 (R-Car E3). > > Signed-off-by: Yoshihiro Shimoda > --- > Documentation/devicetree/bindings/usb/renesas_usb3.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/usb/renesas_usb3.txt > b/

RE: [PATCH 1/2] dt-bindings: usb: renesas_usb3: add bindings for r8a77990

2018-10-02 Thread Yoshihiro Shimoda
Hi Felipe-san, > From: Felipe Balbi, Sent: Tuesday, October 2, 2018 9:18 PM > > Yoshihiro Shimoda writes: > > > This patch adds bindings for r8a77990 (R-Car E3). > > > > Signed-off-by: Yoshihiro Shimoda > > --- > > Documentation/devicetree/bindings/usb/renesas_usb3.txt | 1 + > > 1 file chang

Re: [PATCH 1/4] usbnet: smsc95xx: add kconfig for turbo mode

2018-10-02 Thread Andrew Lunn
On Tue, Oct 02, 2018 at 10:26:42AM +0100, Ben Dooks wrote: > Add a configuration option for the default state of turbo mode > on the smsc95xx networking driver. Some systems it is better > to default this to off as it causes significant increases in > soft-irq load. > > Signed-off-by: Ben Dooks >

RE: [PATCH 1/2] dt-bindings: usb: renesas_usb3: add bindings for r8a77990

2018-10-02 Thread Felipe Balbi
Hi, Yoshihiro Shimoda writes: > Hi Felipe-san, > >> From: Felipe Balbi, Sent: Tuesday, October 2, 2018 9:18 PM >> >> Yoshihiro Shimoda writes: >> >> > This patch adds bindings for r8a77990 (R-Car E3). >> > >> > Signed-off-by: Yoshihiro Shimoda >> > --- >> > Documentation/devicetree/bindings

RE: [PATCH 2/4] usbnet: smsc95xx: align tx-buffer to word

2018-10-02 Thread David Laight
From: Ben Dooks > Sent: 02 October 2018 10:27 > > The tegra driver requires alignment of the buffer, so try and > make this better by pushing the buffer start back to an word > aligned address. At the worst this makes memcpy() easier as > it is word aligned, at best it makes sure the usb can direc

Re: [PATCH 2/4] usbnet: smsc95xx: align tx-buffer to word

2018-10-02 Thread Ben Dooks
On 02/10/18 14:19, David Laight wrote: From: Ben Dooks Sent: 02 October 2018 10:27 The tegra driver requires alignment of the buffer, so try and make this better by pushing the buffer start back to an word aligned address. At the worst this makes memcpy() easier as it is word aligned, at best i

Re: KASAN: slab-out-of-bounds Read in vhci_hub_control

2018-10-02 Thread Shuah Khan
On 09/04/2018 12:52 PM, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:    420f51f4ab6b Merge tag 'arm64-fixes' of git://git.kernel.o.. > git tree:   upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=126a6f0e40 > kernel config:  https://

Re: KASAN: slab-out-of-bounds Read in vhci_hub_control

2018-10-02 Thread Dmitry Vyukov
On Tue, Oct 2, 2018 at 6:04 PM, Shuah Khan wrote: > On 09/04/2018 12:52 PM, syzbot wrote: >> Hello, >> >> syzbot found the following crash on: >> >> HEAD commit:420f51f4ab6b Merge tag 'arm64-fixes' of git://git.kernel.o.. >> git tree: upstream >> console output: https://syzkaller.appspot

[PATCH] usbnet: smsc95xx: simplify tx_fixup code

2018-10-02 Thread Ben Dooks
The smsc95xx_tx_fixup is doing multiple calls to skb_push() to put an 8-byte command header onto the packet. It would be easier to do one skb_push() and then copy the data in once the push is done. Signed-off-by: Ben Dooks --- drivers/net/usb/smsc95xx.c | 25 + 1 file cha

Re: [PATCH 2/2] cdc-acm: correct counting of UART states in serial state notification

2018-10-02 Thread Greg KH
On Sat, Sep 22, 2018 at 10:11:11PM +0200, Tobias Herzog wrote: > The usb standard ("Universal Serial Bus Class Definitions for Communication > Devices") distiguishes between "consistent signals" (DSR, DCD), and > "irregular signals" (break, ring, parity error, framing error, overrun). > The bits of

Re: [PATCH 1/2] dt-bindings: usb: renesas_usb3: add bindings for r8a77990

2018-10-02 Thread gre...@linuxfoundation.org
On Tue, Oct 02, 2018 at 03:52:38PM +0300, Felipe Balbi wrote: > > Hi, > > Yoshihiro Shimoda writes: > > Hi Felipe-san, > > > >> From: Felipe Balbi, Sent: Tuesday, October 2, 2018 9:18 PM > >> > >> Yoshihiro Shimoda writes: > >> > >> > This patch adds bindings for r8a77990 (R-Car E3). > >> > >

Re: KASAN: slab-out-of-bounds Read in vhci_hub_control

2018-10-02 Thread Shuah Khan
On 10/02/2018 10:42 AM, Dmitry Vyukov wrote: > On Tue, Oct 2, 2018 at 6:04 PM, Shuah Khan wrote: >> On 09/04/2018 12:52 PM, syzbot wrote: >>> Hello, >>> >>> syzbot found the following crash on: >>> >>> HEAD commit:420f51f4ab6b Merge tag 'arm64-fixes' of git://git.kernel.o.. >>> git tree:

[PATCH] usb: core: Check portchange C_PORT_RESET after resetting

2018-10-02 Thread Kai-Heng Feng
Based on USB2.0 Spec Section 11.24.2.7.2.5: "This bit is set when the port transitions from the Resetting state (or, if present, the Speed_eval state) to the Enabled state." Also Section 11.24.2.13: "Setting the reset feature PORT_RESET causes the hub to signal reset on that port. When t

Re: [PATCH] net: usbnet: make driver_info const

2018-10-02 Thread David Miller
From: Ben Dooks Date: Mon, 1 Oct 2018 17:02:43 +0100 > From: Ben Dooks > > The driver_info field that is used for describing each of the usb-net > drivers using the usbnet.c core all declare their information as const > and the usbnet.c itself does not try and modify the struct. > > It is the