Re: [PATCH 1/3] usb: host: xhci: fix oops when removing hcd

2018-09-26 Thread Mathias Nyman
Hi Jack, Peter On 24.09.2018 19:37, Jack Pham wrote: Hi Peter, On Fri, Sep 21, 2018 at 09:48:43AM +0800, Peter Chen wrote: Type-C-to-A cable, and the USB3 HCD has already been NULL at that time. The oops log like below: [681.782288] xhci-hcd xhci-hcd.1.auto: remove, state 1 [681.787490] usb u

Re: [PATCH 1/3] usb: host: xhci: fix oops when removing hcd

2018-09-26 Thread Jack Pham
Hi Mathias, On Wed, Sep 26, 2018 at 02:51:40PM +0300, Mathias Nyman wrote: > Hi Jack, Peter > > On 24.09.2018 19:37, Jack Pham wrote: > >Hi Peter, > > > >On Fri, Sep 21, 2018 at 09:48:43AM +0800, Peter Chen wrote: > >>Type-C-to-A cable, and the USB3 HCD has already been NULL at that time. > >>The

Re: [PATCH 1/3] usb: host: xhci: fix oops when removing hcd

2018-09-26 Thread Jack Pham
On Wed, Sep 26, 2018 at 06:34:30PM -0700, Jack Pham wrote: > Hi Mathias, > > On Wed, Sep 26, 2018 at 02:51:40PM +0300, Mathias Nyman wrote: > > Hi Jack, Peter > > > > On 24.09.2018 19:37, Jack Pham wrote: > > >Hi Peter, > > > > > >On Fri, Sep 21, 2018 at 09:48:43AM +0800, Peter Chen wrote: > > >>

RE: usb: gadget: ffs: Fix BUG when userland exits with submitted AIO transfers

2018-09-26 Thread He, Bo
Hi, Vincent: We tried my patch doesn't fix the issue totally, we still see the kernel panic. currently solution in our test is: Rvert "usb: gadget: ffs: Fix BUG when userland exits with submitted AIO transfers" and only add the below patch to use the in_interrupt() to avoi

Re: [PATCH] usb: usbfs: fix crash in check_ctrlrecip()->usb_find_alt_setting()

2018-09-26 Thread Vladis Dronov
Hello, Alan, > Now consider the case at hand: the call to usb_find_alt_setting() from > check_ctrlrecip(). In this case ps->dev->actconfig being NULL doesn't > indicate an error or a bug; it merely indicates that the user is trying > to send a control request to a device which happens to be uncon

[PATCH net-next] usbnet: ipheth: fix return type of ndo_start_xmit function

2018-09-26 Thread YueHaibing
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, so make sure the implementation in this driver has returns 'netdev_tx_t' value, and change the function return type to netdev_tx_t. Found by coccinelle. Signed-off-by: YueHaibing --- drive

Re: [PATCH v7] USB: serial: ftdi_sio: implement GPIO support for FT-X devices

2018-09-26 Thread Johan Hovold
On Tue, Sep 25, 2018 at 03:59:11PM +0200, Karoly Pados wrote: > This patch allows using the CBUS pins of FT-X devices as GPIO in CBUS > bitbanging mode. There is no conflict between the GPIO and VCP > functionality in this mode. Tested on FT230X and FT231X. > > As there is no way to request the cu

[PATCH 2/2] usb: typec: fusb302: Resolve fixed power role contract setup

2018-09-26 Thread Adam Thomson
When the controller is configured for a fixed power role (Source only or Sink only), attach does not proceed within the TCPM state machine as there is no CC event generated by this driver to update the CC line status. To rectify this, when CC is configured as Source or Sink we now make use of the

[PATCH 1/2] usb: typec: fusb302: Correct spelling mistake for toggling state

2018-09-26 Thread Adam Thomson
There's a typo in the enum name of the 'OFF' state for toggling (TOGGLINE instead of TOGGLING). This commit resolves that trivial spelling inconsistency. Signed-off-by: Adam Thomson --- drivers/usb/typec/tcpm/fusb302.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --gi

[PATCH 0/2] usb: typec: fusb302: Resolve fixed role power configuration

2018-09-26 Thread Adam Thomson
This small patch set updates the fusb302 driver to correctly report CC line status during attach, when the device is configured as source only or sink only (non-DRP), so that TCPM state machine correctly proceeds with contract establishment. In addition, a trivial typo with regards to the OFF toggl

Re: [PATCH 1/2] usb: typec: fusb302: Correct spelling mistake for toggling state

2018-09-26 Thread Guenter Roeck
On Wed, Sep 26, 2018 at 04:23:51PM +0100, Adam Thomson wrote: > There's a typo in the enum name of the 'OFF' state for toggling > (TOGGLINE instead of TOGGLING). This commit resolves that trivial > spelling inconsistency. > > Signed-off-by: Adam Thomson Reviewed-by: Guenter Roeck > --- > driv

Re: [PATCH 2/2] usb: typec: fusb302: Resolve fixed power role contract setup

2018-09-26 Thread Guenter Roeck
On Wed, Sep 26, 2018 at 04:23:52PM +0100, Adam Thomson wrote: > When the controller is configured for a fixed power role (Source > only or Sink only), attach does not proceed within the TCPM state > machine as there is no CC event generated by this driver to update > the CC line status. > > To rec

[PATCH 2/5] usb: host: Add OHCI driver for Broadcom STB SoCs

2018-09-26 Thread Al Cooper
This driver enables USB OHCI on Broadcom ARM and MIPS STB SoCs. The drivers depend on a matching "brcm,brcmstb-usb-phy" Broadcom STB USB Phy driver. The standard platform driver can't be used because of differences in PHY and Clock handling. The standard PHY handling in hcd.c will do a phy_exit/ph

[PATCH 4/5] usb: host: Add XHCI driver for Broadcom STB SoCs

2018-09-26 Thread Al Cooper
This driver enables USB XHCI on Broadcom ARM STB SoCs. The drivers depend on a matching "brcm,brcmstb-usb-phy" Broadcom STB USB Phy driver. The standard platform driver can't be used because of differences in PHY and Clock handling. The standard PHY handling in hcd.c will do a phy_exit/phy_init on

[PATCH 5/5] usb: host: Enable building of new Broadcom STB USB drivers

2018-09-26 Thread Al Cooper
Changes to Makefile and Kconfig to enable building of the new Broadcom STB OHCI, EHCI and XHCI drivers. Also update MAINTAINERS. Signed-off-by: Al Cooper --- MAINTAINERS | 9 + drivers/usb/host/Kconfig | 27 +++ drivers/usb/host/Makefile | 7 +

[PATCH 1/5] dt-bindings: Add Broadcom STB OHCI, EHCI and XHCI binding document

2018-09-26 Thread Al Cooper
Add DT bindings document for Broadcom STB USB OHCI, EHCI and XHCI drivers. Signed-off-by: Al Cooper --- .../devicetree/bindings/usb/brcm,ehci-brcm.txt | 22 + .../devicetree/bindings/usb/brcm,ohci-brcm.txt | 22 + .../devicetree/bindings/usb/brcm,x

[PATCH 3/5] usb: host: Add EHCI driver for Broadcom STB SoCs

2018-09-26 Thread Al Cooper
This driver enables USB EHCI on Broadcom ARM and MIPS STB SoCs. The drivers depend on a matching "brcm,brcmstb-usb-phy" Broadcom STB USB Phy driver. The standard platform driver can't be used because of differences in PHY and Clock handling. The standard PHY handling in hcd.c will do a phy_exit/ph

[PATCH 0/5] Add XHCI, EHCI and OHCI drivers for Broadcom STB SoCs

2018-09-26 Thread Al Cooper
Add XHCI, EHCI and OHCI drivers for Broadcom STB SoCs. These drivers depend on getting access to the new Broadcom STB USB PHY driver through a device-tree phandle and will fail if the driver is not available. Al Cooper (5): dt-bindings: Add Broadcom STB OHCI, EHCI and XHCI binding document usb

Re: [PATCH net 0/7] net: usb: Check for Wake-on-LAN modes

2018-09-26 Thread David Miller
From: Florian Fainelli Date: Mon, 24 Sep 2018 13:54:13 -0700 > Most of our USB Ethernet drivers don't seem to be checking properly > whether the user is supplying a correct Wake-on-LAN mode to enter, so > the experience as an user could be confusing, since it would generally > lead to either no w

Re: [PATCH net 0/7] net: usb: Check for Wake-on-LAN modes

2018-09-26 Thread Florian Fainelli
On 09/26/2018 05:12 PM, David Miller wrote: > From: Florian Fainelli > Date: Mon, 24 Sep 2018 13:54:13 -0700 > >> Most of our USB Ethernet drivers don't seem to be checking properly >> whether the user is supplying a correct Wake-on-LAN mode to enter, so >> the experience as an user could be conf

Re: [PATCH] usb: core: disable USB2 LPM when suspending

2018-09-26 Thread AceLan Kao
Alan Stern 於 2018年9月20日 週四 下午10:43寫道: > > On Thu, 20 Sep 2018, AceLan Kao wrote: > > > We found a S5 current leakage issue on Dell DW1820 WiFi/BT combo card > > which uses Qualcomm QCA6174 SoC. It also comes with WiFi and BT failure > > when encountered current leakage issue. > >1. Power on, b

Re: [PATCH 4/5] usb: host: Add XHCI driver for Broadcom STB SoCs

2018-09-26 Thread Chunfeng Yun
Hi, On Wed, 2018-09-26 at 18:20 -0400, Al Cooper wrote: > This driver enables USB XHCI on Broadcom ARM STB SoCs. > The drivers depend on a matching "brcm,brcmstb-usb-phy" > Broadcom STB USB Phy driver. > > The standard platform driver can't be used because of differences > in PHY and Clock handli

Re: [PATCH 4/5] usb: host: Add XHCI driver for Broadcom STB SoCs

2018-09-26 Thread Felipe Balbi
Hi, Al Cooper writes: > This driver enables USB XHCI on Broadcom ARM STB SoCs. > The drivers depend on a matching "brcm,brcmstb-usb-phy" > Broadcom STB USB Phy driver. > > The standard platform driver can't be used because of differences > in PHY and Clock handling. The standard PHY handling i