Intel Apollo Lake has the same internal USB role mux as
Intel Cherry Trail.
Signed-off-by: Heikki Krogerus
---
drivers/usb/host/xhci-pci.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
index 6372edf339d9..aef66
On Mon, Sep 10, 2018 at 03:12:22PM -0700, Jon Flatley wrote:
> On Mon, Sep 10, 2018 at 11:14 AM Greg KH wrote:
> >
> > On Fri, Aug 31, 2018 at 10:14:19AM -0700, Jon Flatley wrote:
> > > After commit 1cbd53c8cd85 ("usb: core: introduce per-port over-current
> > > counters") usb ports expose a sysfs
[I seem to have lost my local copy of the mail I'm responding to, so I
copied bits of it from an archive and broke threading in the process,
sorry about that]
On 2018-09-11 00:22, Ajay Gupta wrote:
>> Hmm, that goto stop is however not perfect. Ideally,
>> you shouldn't issue stop if i == 0 and g
Introducing helpers for adding and removing multiple device
connection descriptions at once.
Signed-off-by: Heikki Krogerus
---
include/linux/device.h | 24
1 file changed, 24 insertions(+)
diff --git a/include/linux/device.h b/include/linux/device.h
index 8f882549edee.
The connections create clear dependency on the muxes.
fusb302 fails to probe unless we have the mux drivers
available.
Signed-off-by: Heikki Krogerus
Acked-by: Andy Shevchenko
---
drivers/platform/x86/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/platform/x86/Kconfig b/d
We can register all device connection descriptors with a
single call to device_connections_add().
Signed-off-by: Heikki Krogerus
Acked-by: Andy Shevchenko
---
drivers/platform/x86/intel_cht_int33fe.c | 14 --
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/drivers/pla
Functions typec_mux_get() and typec_switch_get() already
make sure that the mux device reference count is
incremented, but the same must be done to the driver module
as well to prevent the drivers from being unloaded in the
middle of operation.
This fixes a potential "BUG: unable to handle kernel
This fixes potential "BUG: unable to handle kernel paging
request at ..." from happening.
Fixes: fde0aa6c175a ("usb: common: Small class for USB role switches")
Cc:
Signed-off-by: Heikki Krogerus
---
drivers/usb/common/roles.c | 15 ---
1 file changed, 12 insertions(+), 3 deletions(
Hi,
This is fourth version of this series. There was one bug in patch 2/10
that Hans noticed. It should be fixed now.
The commit message from v3:
These patches will introduce a few improvements to the USB Type-C
support on Intel CHT platform. In this series I'm preparing Intel CHT
mux handling f
USB Type-C class driver now expects the muxes to be always
assigned to the ports and not controllers, so the
connections for the mux and fusb302 can be removed.
Signed-off-by: Heikki Krogerus
Acked-by: Andy Shevchenko
---
drivers/platform/x86/intel_cht_int33fe.c | 18 --
1 file
It is not possible to use the parent of the port device when
requesting mux handles as the parent may be a multiport USB
Type-C or PD controller. The muxes must be assigned to the
ports, not the controllers.
This will also move the requesting of the muxes after the
port device is initialized.
Sig
The debugfs needs to be initialized as the last step in
probe in this case. The struct dentry *rootdir can't be
pointing to anything unless driver probe really finishes
successfully.
It is also not necessary to clear the i2c clientdata if the
probe fails, so removing the extra label used for that.
Adding a connection for the DisplayPort alternate mode.
PI3USB30532 is used for muxing the port to DisplayPort on
CHT platforms. The connection allows the alternate mode
device to get handle to the mux, and therefore make it
possible to use the USB Type-C connector as DisplayPort.
Signed-off-by: H
Assigning the mux to the USB Type-C port on top of fusb302.
That will prepare this driver for the change in the USB
Type-C class code, where the class driver will assume the
muxes to be always assigned to the ports and not the
controllers.
Once the USB Type-C class driver has been updated, the
con
The SMSC95xx chip can use either the internal PHY or an external one.
Currently, the driver hard-codes support for the internal PHY only.
This patch reads out the HW_CFG register to determine whether external
PHY is attached or not. If an external PHY is not attached, the driver
falls back to inte
The company atmes.de manufactures a SMSC95xx device with default USB
ID 0424:9e00 , but with external NXP TJA1100 PHY at address 0x4. This
PHY is not 802.3 c22 compliant, but rather c96 compliant. The register
set is slightly different and does not provide link state information
in c22-compliant ma
Hi Peter
> On Sep 10, 2018, at 11:29 PM, Peter Rosin wrote:
>
>> On 2018-09-11 06:30, Ajay Gupta wrote:
>> Hi Peter,
>>
>>> +static int ucsi_ccg_send_data(struct ucsi_ccg *uc) {
>>> +unsigned char buf1[USBC_MSG_OUT_SIZE];
>>> +unsigned char buf2[USBC_CONTROL_SIZE
On Mon, Sep 10, 2018 at 06:21:04AM -0700, Guenter Roeck wrote:
> On 09/10/2018 04:58 AM, Heikki Krogerus wrote:
> > Moving all the drivers that depend on the Port Controller
> > Manager under a new directory drivers/usb/typec/tcpm/ and
> > making Guenter Roeck the designated reviewer of that code.
Hello,
This series fixes a v4.19-rc1 regression that results in OMAP EHCI failing to
probe (patch 1/3) and then moves on to cleaning up related code (patches 2/3
and 3/3).
The first patch is a regression fix and should thus be merged before v4.19.
The other two patches can wait until v4.20.
Tony
The omap-usb-host driver uses platform_driver_probe() in the fs initcall
level to ensure that the devices get probed before the EHCI and OHCI
drivers arer probed.
The EHCI and OHCI devices are created and registered by the omap-usb-host
driver, and if no driver is present yet to handle them they w
Several legacy USB-related functions, structures and macros are not used
anymore after conversion to DT. Remove them.
Signed-off-by: Laurent Pinchart
---
arch/arm/mach-omap2/common.h| 2 -
arch/arm/mach-omap2/omap_phy_internal.c | 96 +
arch/arm/mach-
Now that all platforms using OMAP USB host devices have been converted
to DT, drop support for legacy non-DT probe from the driver.
Signed-off-by: Laurent Pinchart
---
drivers/mfd/omap-usb-host.c| 153 +++--
include/linux/platform_data/usb-omap.h | 4 -
* Laurent Pinchart [180911 15:10]:
> Hello,
>
> This series fixes a v4.19-rc1 regression that results in OMAP EHCI failing to
> probe (patch 1/3) and then moves on to cleaning up related code (patches 2/3
> and 3/3).
>
> The first patch is a regression fix and should thus be merged before v4.19.
* Laurent Pinchart [180911 15:10]:
> --- a/drivers/mfd/omap-usb-host.c
> +++ b/drivers/mfd/omap-usb-host.c
> @@ -855,31 +856,14 @@ static struct platform_driver usbhs_omap_driver = {
> .pm = &usbhsomap_dev_pm_ops,
> .of_match_table = usbhs_omap_dt_ids,
>
* Tony Lindgren [180911 15:21]:
> * Laurent Pinchart [180911 15:10]:
> > Tony, as patch 1/3 fixes a problem introduced by one of your DT changes,
> > could
> > you please review it ? Out of curiosity, is ethernet on the Pandaboard not
> > part of your regression tests ?
>
> Sorry not any longer
On Tue, Sep 11, 2018 at 06:06:08PM +0300, Laurent Pinchart wrote:
> The omap-usb-host driver uses platform_driver_probe() in the fs initcall
> level to ensure that the devices get probed before the EHCI and OHCI
> drivers arer probed.
>
> The EHCI and OHCI devices are created and registered by the
Hi Tony,
On Tuesday, 11 September 2018 18:16:41 EEST Tony Lindgren wrote:
> * Laurent Pinchart [180911 15:10]:
> > Hello,
> >
> > This series fixes a v4.19-rc1 regression that results in OMAP EHCI failing
> > to probe (patch 1/3) and then moves on to cleaning up related code
> > (patches 2/3 and
On Tuesday, 11 September 2018 18:53:19 EEST Ladislav Michl wrote:
> On Tue, Sep 11, 2018 at 06:06:08PM +0300, Laurent Pinchart wrote:
> > The omap-usb-host driver uses platform_driver_probe() in the fs initcall
> > level to ensure that the devices get probed before the EHCI and OHCI
> > drivers are
* Laurent Pinchart [180911 16:12]:
> On Tuesday, 11 September 2018 18:16:41 EEST Tony Lindgren wrote:
> > * Laurent Pinchart [180911 15:10]:
> > > Hello,
> > >
> > > This series fixes a v4.19-rc1 regression that results in OMAP EHCI failing
> > > to probe (patch 1/3) and then moves on to cleanin
Hi Peter,
> -Original Message-
> From: linux-i2c-ow...@vger.kernel.org
> On Behalf Of Peter Rosin
> Sent: Tuesday, September 11, 2018 1:55 AM
> To: Ajay Gupta ; w...@the-dreams.de;
> heikki.kroge...@linux.intel.com
> Cc: linux-usb@vger.kernel.org; linux-...@vger.kernel.org
> Subject: Re:
Hi,
On 11-09-18 12:10, Heikki Krogerus wrote:
Hi,
This is fourth version of this series. There was one bug in patch 2/10
that Hans noticed. It should be fixed now.
The commit message from v3:
These patches will introduce a few improvements to the USB Type-C
support on Intel CHT platform. In t
After commit 1cbd53c8cd85 ("usb: core: introduce per-port over-current
counters") usb ports expose a sysfs value 'over_current_count'
to user space. This value on its own is not very useful as it requires
manual polling.
As a solution, fire a udev event from the usb hub device that specifies
the v
Latest NVIDIA GPU card has USB Type-C interface. There is a
Type-C controller which can be accessed over I2C.
This driver adds I2C bus driver to communicate with Type-C controller.
I2C client driver will be part of USB Type-C UCSI driver.
Signed-off-by: Ajay Gupta
Reviewed-by: Andy Shevchenko
R
Latest NVIDIA GPU cards have a Cypress CCGx Type-C controller
over I2C interface.
This UCSI I2C driver uses I2C bus driver interface for communicating
with Type-C controller.
Signed-off-by: Ajay Gupta
Reviewed-by: Andy Shevchenko
Acked-by: Heikki Krogerus
---
Changes from v1 -> v2
Fixe
From: Saranya Gopal
USB audio class 3.0 specification introduced many significant
changes like
- new power domains, support for LPM/L1
- new cluster descriptor
- new high capability and class-specific string descriptors
- BADD profiles
- ... and many other things (check spec from link below:
From: Saranya Gopal
USB audio class 3.0 specification introduced many significant
changes like
- new power domains, support for LPM/L1
- new cluster descriptor
- new high capability and class-specific string descriptors
- BADD profiles
- ... and many other things (check spec from link below:
When operating in USB 2.0 speeds (HS/FS), if GUSB2PHYCFG.ENBLSLPM or
GUSB2PHYCFG.SUSPHY is set, it must be cleared before issuing an endpoint
command.
Current implementation only save and restore GUSB2PHYCFG.SUSPHY
configuration. We must save and clear both GUSB2PHYCFG.ENBLSLPM and
GUSB2PHYCFG.SUS
On Wed, Sep 12, 2018 at 01:03:57AM +0530, saranya.go...@intel.com wrote:
> From: Saranya Gopal
Any reason you forgot to cc: the usb maintainer? :)
>
> USB audio class 3.0 specification introduced many significant
> changes like
> - new power domains, support for LPM/L1
> - new cluster descri
On 2018-09-11 19:45, Ajay Gupta wrote:
> Latest NVIDIA GPU card has USB Type-C interface. There is a
> Type-C controller which can be accessed over I2C.
>
> This driver adds I2C bus driver to communicate with Type-C controller.
> I2C client driver will be part of USB Type-C UCSI driver.
>
> Signe
Hi Peter,
> > Latest NVIDIA GPU card has USB Type-C interface. There is a Type-C
> > controller which can be accessed over I2C.
> >
> > This driver adds I2C bus driver to communicate with Type-C controller.
> > I2C client driver will be part of USB Type-C UCSI driver.
> >
> > Signed-off-by: Ajay G
From: Saranya Gopal
USB audio class 3.0 specification introduced many significant
changes like
- new power domains, support for LPM/L1
- new cluster descriptor
- new high capability and class-specific string descriptors
- BADD profiles
- ... and many other things (check spec from link below:
On 2018-09-01 16:12:10 [+0800], Jia-Ju Bai wrote:
> wdm_in_callback() is a completion handler function for the USB driver.
> So it should not sleep. But it calls service_outstanding_interrupt(),
> which calls usb_submit_urb() with GFP_KERNEL.
At which point does wdm_in_callback() invoke
service_
This reverts commit 6e22e3af7bb3a7b9dc53cb4687659f6e63fca427.
The bug the patch describes to, has been already fixed in commit
2df6948428542 ("USB: cdc-wdm: don't enable interrupts in USB-giveback")
so need to this, revert it.
Signed-off-by: Sebastian Andrzej Siewior
---
drivers/usb/class/cdc-w
On Tue, Sep 11, 2018 at 02:54:13AM -0500, Gustavo A. R. Silva wrote:
> Fix the following compile warning:
>
> warning: unused variable ‘flags’ [-Wunused-variable]
> unsigned long flags;
>
> Fixes: ed194d136769 ("usb: core: remove local_irq_save() around ->complete()
> handler")
> Signed-off-by
On Tue, Sep 11, 2018 at 08:48:43AM +0300, Felipe Balbi wrote:
>
> Hi,
>
> Greg Kroah-Hartman writes:
> > On Thu, Jul 19, 2018 at 06:57:35PM +0100, Pawel Laszczak wrote:
> >> This patch add additional functions that converts some fields to string.
> >>
> >> For example function usbssp_trb_comp_c
Fix the following compile warning:
warning: unused variable ‘flags’ [-Wunused-variable]
unsigned long flags;
Fixes: ed194d136769 ("usb: core: remove local_irq_save() around ->complete()
handler")
Signed-off-by: Gustavo A. R. Silva
---
drivers/usb/core/hcd.c | 1 -
1 file changed, 1 deletion(
On 2018/9/11 15:49, Sebastian Andrzej Siewior wrote:
On 2018-09-01 16:12:10 [+0800], Jia-Ju Bai wrote:
wdm_in_callback() is a completion handler function for the USB driver.
So it should not sleep. But it calls service_outstanding_interrupt(),
which calls usb_submit_urb() with GFP_KERNEL.
At
This patch set is based on Felipe's usb.git / testing/next branch
(the commit id is 5b394b2ddf0347bef56e50c69a58773c94343ff3) with
the following patch:
https://patchwork.kernel.org/patch/10574875/
Changes from v4:
- Revise the dt-bindings to add how many clocks are required and expect
for "r
R-Car Gen3 needs to enable clocks of both host and peripheral.
Otherwise, other side device cannot work correctly. So, this patch
adds a property of clock-names for R-Car Gen3 as an optional.
Signed-off-by: Yoshihiro Shimoda
---
Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 6 +-
R-Car Gen3 needs to deassert resets of both host and peripheral.
Since [eo]hci-platform is possible to assert the reset(s) when
the probing failed, renesas_usbhs driver doesn't work correctly
regardless of finished probing. To fix this issue, this patch adds
reset_control on this renesas_usbhs driv
R-Car Gen3 needs to enable clocks of both host and peripheral.
Since [eo]hci-platform disables the reset(s) when the drivers are
removed, renesas_usbhs driver doesn't work correctly. To fix this
issue, this patch adds multiple clocks management on this
renesas_usbhs driver.
Signed-off-by: Yoshihir
HI, All
Please stop review of this series. It's a pity of your time.
Probably the design of USBSSP device controller will be significantly changed
and simplified, so
I will have to create new driver.
The planed change include:
- simplification and change registers map
- removing com
On Mon, Sep 10, 2018 at 08:15:47PM +0900, Yoshihiro Shimoda wrote:
> This patch adds detailed information of an optional property "clocks"
> description for R-Car Gen3.
>
> Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Simon Horman
On Mon, Sep 10, 2018 at 08:15:48PM +0900, Yoshihiro Shimoda wrote:
> This patch adds detailed information of an optional property "clocks"
> description for R-Car Gen3.
>
> Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Simon Horman
On 9/10/2018 18:39, Kristian Evensen wrote:
Hi,
On Mon, Sep 10, 2018 at 12:30 PM Johan Hovold wrote:
Please provide the output of usb-devices (or lsusb -v) for both
"configurations". How do you update the configuration by the way?
The configuration is updated using a proprietary AT-command
(
On Tue, Sep 11, 2018 at 4:00 PM Lars Melin wrote:
> This also becomes a mess for the qmi-wwan driver which has the rmnet/qmi
> interface hardcoded to 4 so that driver will also need a workaround.
> Quectel seems to have completely missed the reason why usb id's should
> be unique and not reused f
Hi Adam,
On Mon, Sep 10, 2018 at 01:24:26PM +0100, Adam Thomson wrote:
> Add support for PPS APDOs to connector bindings so a port controller
> can specify support for PPS, as per existing FIXED/BATT/VAR PDOs.
>
> Signed-off-by: Adam Thomson
> Reviewed-by: Rob Herring
I've applied this patch t
Hi Adam,
On Mon, Sep 10, 2018 at 01:24:27PM +0100, Adam Thomson wrote:
> There are now generic usb-connector bindings which can be used
> to define a port controllers configuration for USB-PD, so device
> specific bindings are no longer necessary.
>
> This update deprecates 'fcs,operating-sink-mi
Hi Adam,
On Mon, Sep 10, 2018 at 01:24:28PM +0100, Adam Thomson wrote:
> This update populates the tcpc handle's fwnode pointer with the
> child usb-connector node, if it exists, so that TCPM can perform
> generic property handling to define the ports capabilities.
>
> Signed-off-by: Adam Thomson
On 11 September 2018 15:35, Heikki Krogerus wrote:
> Hi Adam,
>
> On Mon, Sep 10, 2018 at 01:24:26PM +0100, Adam Thomson wrote:
> > Add support for PPS APDOs to connector bindings so a port controller
> > can specify support for PPS, as per existing FIXED/BATT/VAR PDOs.
> >
> > Signed-off-by: Ada
If the board is being powered by USB disabling the source and sink
can remove power from the board. Allow the source and sink to be
initallized based on devicetree values.
Changed since V2:
Change the devicetree documentation.
Change the devicetree property names.
Changed since V1:
use devicetr
I cant put my finger on it but this seems wrong. As i said both src and sink
should never be true at the same time. I also din’t understand why turning off
src should power off your board. Ultimately my concern is that we may be just
painting over the real problem, and that would be really bad t
From: Colin Ian King
The removal of the use of 'flags' in commit ed194d136769
("usb: core: remove local_irq_save() around ->complete() handler")
didn't remove the unused variable. Remove it.
Cleans up warning:
warning: unused variable ‘flags’ [-Wunused-variable]
Signed-off-by: Colin Ian King
-
On 2018-09-05 04:18, Greg KH wrote:
On Wed, Sep 05, 2018 at 03:01:26PM +0530, Manu Gautam wrote:
Hi,
On 9/5/2018 3:04 AM, Prakruthi Deepak Heragu wrote:
> Add support for control peripheral of EUD (Embedded USB Debugger) to
> listen to events such as USB attach/detach, charger enable/disable,
On Tue, Sep 11, 2018 at 01:40:19PM -0700, pher...@codeaurora.org wrote:
> On 2018-09-05 04:18, Greg KH wrote:
> > On Wed, Sep 05, 2018 at 03:01:26PM +0530, Manu Gautam wrote:
> > > Hi,
> > >
> > >
> > > On 9/5/2018 3:04 AM, Prakruthi Deepak Heragu wrote:
> > > > Add support for control peripheral
65 matches
Mail list logo
