Re: [PATCH] usb: typec: Group all TCPCI/TCPM code together

2018-09-10 Thread Heikki Krogerus
On Sat, Sep 08, 2018 at 06:37:12AM -0700, Guenter Roeck wrote: > On 09/08/2018 04:12 AM, Hans de Goede wrote: > > HI, > > > > On 07-09-18 18:19, Guenter Roeck wrote: > > > On Fri, Sep 07, 2018 at 05:06:12PM +0300, Heikki Krogerus wrote: > > > > On Fri, Sep 07, 2018 at 06:35:12AM -0700, Guenter Roe

Re: Possible race condition in f_mass_storage gadget during deinitialization. Kernel warning issued

2018-09-10 Thread Adrian Ambrożewicz
Thanks for the patch. I was happy to blindly apply it on my sources and check the result. Unfortunately it ended up with even worse crash than before. I've noticed that uninitialized stack variable "flags" is passed to spin_unlock_irqrestore . I've tried to tweak the patch and pass "flags" from ev

Re: [PATCH V6] roles: Fix USB 3.0 OTG issue on Intel platform

2018-09-10 Thread Heikki Krogerus
On Sun, Sep 09, 2018 at 01:18:45PM +0200, Hans de Goede wrote: > Hi Saranya, Heikki, > > On 07-09-18 10:18, Heikki Krogerus wrote: > > +Hans > > > > On Fri, Sep 07, 2018 at 12:32:01PM +0530, saranya.go...@intel.com wrote: > > > From: Saranya Gopal > > > > > > This patch adds static DRD mode for

Re: [PATCH V6] roles: Fix USB 3.0 OTG issue on Intel platform

2018-09-10 Thread Hans de Goede
Hi, On 10-09-18 12:13, Heikki Krogerus wrote: On Sun, Sep 09, 2018 at 01:18:45PM +0200, Hans de Goede wrote: Hi Saranya, Heikki, On 07-09-18 10:18, Heikki Krogerus wrote: +Hans On Fri, Sep 07, 2018 at 12:32:01PM +0530, saranya.go...@intel.com wrote: From: Saranya Gopal This patch adds sta

Re: [PATCH V6] roles: Fix USB 3.0 OTG issue on Intel platform

2018-09-10 Thread Heikki Krogerus
On Mon, Sep 10, 2018 at 12:17:56PM +0200, Hans de Goede wrote: > Hi, > > On 10-09-18 12:13, Heikki Krogerus wrote: > > On Sun, Sep 09, 2018 at 01:18:45PM +0200, Hans de Goede wrote: > > > Hi Saranya, Heikki, > > > > > > On 07-09-18 10:18, Heikki Krogerus wrote: > > > > +Hans > > > > > > > > On F

[PATCHv2] usb: typec: Group all TCPCI/TCPM code together

2018-09-10 Thread Heikki Krogerus
Moving all the drivers that depend on the Port Controller Manager under a new directory drivers/usb/typec/tcpm/ and making Guenter Roeck the designated reviewer of that code. Signed-off-by: Heikki Krogerus --- Changes since v1: - Naming the directory tcpm instead of tcpci - Port controller driver

Re: [PATCH 1/3] dt-bindings: usb: dwc2: add description for px30

2018-09-10 Thread Heiko Stuebner
Hi Greg, Felipe, Am Donnerstag, 2. August 2018, 15:01:31 CEST schrieb Heiko Stuebner: > From: Liang Chen > > This patch adds the compatible of dwc2 for PX30 SoCs. > > Signed-off-by: Liang Chen > Acked-by: Rob Herring > Signed-off-by: Heiko Stuebner Do you want to pick that patch through one

Re: [PATCHv2] usb: typec: Group all TCPCI/TCPM code together

2018-09-10 Thread Guenter Roeck
On 09/10/2018 04:58 AM, Heikki Krogerus wrote: Moving all the drivers that depend on the Port Controller Manager under a new directory drivers/usb/typec/tcpm/ and making Guenter Roeck the designated reviewer of that code. Signed-off-by: Heikki Krogerus Acked-by: Guenter Roeck --- Changes s

Re: [PATCH v10 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-09-10 Thread Peter Rosin
On 2018-09-08 21:17, Peter Rosin wrote: >> + >> +if (msgs[i].flags & I2C_M_RD) { >> +/* gpu_i2c_read has implicit start and stop */ >> +status = gpu_i2c_read(i2cd, msgs[i].buf, msgs[i].len); >> +if (status < 0) >> +

RE: [PATCH v10 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-09-10 Thread Ajay Gupta
Hi Peter, > >> + > >> + if (msgs[i].flags & I2C_M_RD) { > >> + /* gpu_i2c_read has implicit start and stop */ > >> + status = gpu_i2c_read(i2cd, msgs[i].buf, msgs[i].len); > >> + if (status < 0) > >> + return stat

Re: [PATCH v10 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-09-10 Thread Peter Rosin
On 2018-09-10 18:08, Ajay Gupta wrote: > Hi Peter, > + + if (msgs[i].flags & I2C_M_RD) { + /* gpu_i2c_read has implicit start and stop */ + status = gpu_i2c_read(i2cd, msgs[i].buf, msgs[i].len); + if (status < 0)

Re: [PATCH v10 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-09-10 Thread Peter Rosin
On 2018-09-10 19:28, Peter Rosin wrote: > On 2018-09-10 18:08, Ajay Gupta wrote: >> Hi Peter, >> > + > + if (msgs[i].flags & I2C_M_RD) { > + /* gpu_i2c_read has implicit start and stop */ > + status = gpu_i2c_read(i2cd, msgs[i].buf, msgs[i].le

RE: [PATCH v10 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-09-10 Thread Ajay Gupta
Hi Peter, > > + > > + if (msgs[i].flags & I2C_M_RD) { > > + /* gpu_i2c_read has implicit start and stop */ > > + status = gpu_i2c_read(i2cd, msgs[i].buf, > > msgs[i].len); > > + if (status < 0)

RE: [PATCH v10 2/2] usb: typec: ucsi: add support for Cypress CCGx

2018-09-10 Thread Ajay Gupta
Hi Peter, > > Latest NVIDIA GPU cards have a Cypress CCGx Type-C controller over I2C > > interface. > > > > This UCSI I2C driver uses I2C bus driver interface for communicating > > with Type-C controller. > > > > Signed-off-by: Ajay Gupta > > Reviewed-by: Andy Shevchenko > > Acked-by: Heikki Kro

[PATCH 1/2] USB: remove LPM management from usb_driver_claim_interface()

2018-09-10 Thread Alan Stern
usb_driver_claim_interface() disables and re-enables Link Power Management, but it shouldn't do either one, for the reasons listed below. This patch removes the two LPM-related function calls from the routine. The reason for disabling LPM in the analogous function usb_probe_interface() is so that

[PATCH 2/2] USB: fix error handling in usb_driver_claim_interface()

2018-09-10 Thread Alan Stern
The syzbot fuzzing project found a use-after-free bug in the USB core. The bug was caused by usbfs not unbinding from an interface when the USB device file was closed, which led another process to attempt the unbind later on, after the private data structure had been deallocated. The reason usbfs

[PATCH] USB: handle NULL config in usb_find_alt_setting()

2018-09-10 Thread Alan Stern
usb_find_alt_setting() takes a pointer to a struct usb_host_config as an argument; it searches for an interface with specified interface and alternate setting numbers in that config. However, it crashes if the usb_host_config pointer argument is NULL. Since this is a general-purpose routine, avai

Re: [PATCH] usb: core: added uevent for over-current

2018-09-10 Thread Greg KH
On Fri, Aug 31, 2018 at 10:14:19AM -0700, Jon Flatley wrote: > After commit 1cbd53c8cd85 ("usb: core: introduce per-port over-current > counters") usb ports expose a sysfs value 'over_current_count' > to user space. This value on its own is not very useful as it requires > manual polling. > > As a

Re: [PATCH V4] roles: Fix USB 3.0 OTG issue on Intel platform

2018-09-10 Thread Greg KH
On Fri, Sep 07, 2018 at 09:59:40AM +0530, saranya.go...@intel.com wrote: > From: Saranya Gopal > > This patch adds static DRD mode for host/device > mode switch. This fixes the issue where device > mode was not working after DUT switches to host > mode with 3.0 OTG connector. > > Change-Id: Ib6d

Re: [PATCH v10 2/2] usb: typec: ucsi: add support for Cypress CCGx

2018-09-10 Thread Peter Rosin
On 2018-09-10 19:32, Ajay Gupta wrote: >>> +static int ccg_read(struct ucsi_ccg *uc, u16 rab, u8 *data, u32 len) >>> +{ >>> + struct i2c_client *client = uc->client; >>> + unsigned char buf[2]; >>> + struct i2c_msg msgs[] = { >>> + { >>> + .addr = client->addr, >

RE: [PATCH v10 2/2] usb: typec: ucsi: add support for Cypress CCGx

2018-09-10 Thread Ajay Gupta
Hi Peter, > >>> +static int ccg_read(struct ucsi_ccg *uc, u16 rab, u8 *data, u32 > >>> +len) { > >>> + struct i2c_client *client = uc->client; > >>> + unsigned char buf[2]; > >>> + struct i2c_msg msgs[] = { > >>> + { > >>> + .addr = client->addr, > >>> + .

Re: [PATCH v10 2/2] usb: typec: ucsi: add support for Cypress CCGx

2018-09-10 Thread Peter Rosin
On 2018-09-10 20:51, Ajay Gupta wrote: > +static int ucsi_ccg_send_data(struct ucsi_ccg *uc) { > + unsigned char buf1[USBC_MSG_OUT_SIZE]; > + unsigned char buf2[USBC_CONTROL_SIZE]; > + int status; > + u16 rab; > + > + memcpy(buf1, (u8 *)(uc->ppm.data) + USBC_MSG_OUT_OFFS

Re: [PATCH v10 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-09-10 Thread Peter Rosin
On 2018-09-10 19:43, Ajay Gupta wrote: > Hi Peter, > >>> + >>> + if (msgs[i].flags & I2C_M_RD) { >>> + /* gpu_i2c_read has implicit start and stop */ >>> + status = gpu_i2c_read(i2cd, msgs[i].buf, >>> msgs[i].len);

RE: [PATCH v10 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-09-10 Thread Ajay Gupta
Hi Peter, > >>> + if (msgs[i].flags & I2C_M_RD) { > >>> + /* gpu_i2c_read has implicit start and stop */ > >>> + status = gpu_i2c_read(i2cd, msgs[i].buf, > msgs[i].len); > >>> + if (status < 0) > >>> +

Re: [PATCH v10 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-09-10 Thread Peter Rosin
On 2018-09-10 22:04, Ajay Gupta wrote: > Hi Peter, > > + if (msgs[i].flags & I2C_M_RD) { > + /* gpu_i2c_read has implicit start and stop */ > + status = gpu_i2c_read(i2cd, msgs[i].buf, >> msgs[i].len); > +

RE: [PATCH v10 2/2] usb: typec: ucsi: add support for Cypress CCGx

2018-09-10 Thread Ajay Gupta
Hi Peter > > +static int ucsi_ccg_send_data(struct ucsi_ccg *uc) { > > + unsigned char buf1[USBC_MSG_OUT_SIZE]; > > + unsigned char buf2[USBC_CONTROL_SIZE]; > > + int status; > > + u16 rab; > > + > > + memcpy(buf1, (u8 *)(uc->ppm.data) + US

RE: [PATCH v10 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-09-10 Thread Ajay Gupta
Hi Peter > > + if (msgs[i].flags & I2C_M_RD) { > > + /* gpu_i2c_read has implicit start and stop */ > > + status = gpu_i2c_read(i2cd, msgs[i].buf, > >> msgs[i].len); > > + if (status < 0) > > +

Re: [PATCH v10 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-09-10 Thread Peter Rosin
On 2018-09-10 23:38, Ajay Gupta wrote: >> My guess is that with the above, you can actually program the I2C_MST_ADDR >> register inside the "if (Read)" branch and then remove the I2C_AQ_COMB | >> I2C_AQ_COMB_WRITE_FIRST | I2C_AQ_COMB_SAME_ADDR quirks. > > We need I2C_MST_ADDR to be programmed even

RE: [PATCH v10 2/2] usb: typec: ucsi: add support for Cypress CCGx

2018-09-10 Thread Ajay Gupta
Hi Peter > > > +static int ucsi_ccg_send_data(struct ucsi_ccg *uc) { > > > + unsigned char buf1[USBC_MSG_OUT_SIZE]; > > > + unsigned char buf2[USBC_CONTROL_SIZE]; > > > + int status; > > > + u16 rab; > > > + > > > + memcpy(buf1, (u8 *)(uc->ppm.data)

Re: [PATCH] usb: core: added uevent for over-current

2018-09-10 Thread Jon Flatley
On Mon, Sep 10, 2018 at 11:14 AM Greg KH wrote: > > On Fri, Aug 31, 2018 at 10:14:19AM -0700, Jon Flatley wrote: > > After commit 1cbd53c8cd85 ("usb: core: introduce per-port over-current > > counters") usb ports expose a sysfs value 'over_current_count' > > to user space. This value on its own is

[PATCH v11 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-09-10 Thread Ajay Gupta
Latest NVIDIA GPU card has USB Type-C interface. There is a Type-C controller which can be accessed over I2C. This driver adds I2C bus driver to communicate with Type-C controller. I2C client driver will be part of USB Type-C UCSI driver. Signed-off-by: Ajay Gupta Reviewed-by: Andy Shevchenko R

[PATCH v11 2/2] usb: typec: ucsi: add support for Cypress CCGx

2018-09-10 Thread Ajay Gupta
Latest NVIDIA GPU cards have a Cypress CCGx Type-C controller over I2C interface. This UCSI I2C driver uses I2C bus driver interface for communicating with Type-C controller. Signed-off-by: Ajay Gupta Reviewed-by: Andy Shevchenko Acked-by: Heikki Krogerus --- Changes from v1 -> v2 Fixe

Re: [PATCH v10 2/2] usb: typec: ucsi: add support for Cypress CCGx

2018-09-10 Thread Peter Rosin
On 2018-09-10 23:53, Ajay Gupta wrote: > Hi Peter > +static int ucsi_ccg_send_data(struct ucsi_ccg *uc) { + unsigned char buf1[USBC_MSG_OUT_SIZE]; + unsigned char buf2[USBC_CONTROL_SIZE]; + int status; + u16 rab; +

Re: [PATCH v11 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-09-10 Thread Peter Rosin
On 2018-09-11 00:22, Ajay Gupta wrote: > Latest NVIDIA GPU card has USB Type-C interface. There is a > Type-C controller which can be accessed over I2C. > > This driver adds I2C bus driver to communicate with Type-C controller. > I2C client driver will be part of USB Type-C UCSI driver. > > Signe

RE: [PATCH v11 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-09-10 Thread Ajay Gupta
Hi Peter, > > Latest NVIDIA GPU card has USB Type-C interface. There is a Type-C > > controller which can be accessed over I2C. > > > > This driver adds I2C bus driver to communicate with Type-C controller. > > I2C client driver will be part of USB Type-C UCSI driver. > > > > Signed-off-by: Ajay G

RE: [PATCH v10 2/2] usb: typec: ucsi: add support for Cypress CCGx

2018-09-10 Thread Ajay Gupta
Hi Peter, > +static int ucsi_ccg_send_data(struct ucsi_ccg *uc) { > +unsigned char buf1[USBC_MSG_OUT_SIZE]; > +unsigned char buf2[USBC_CONTROL_SIZE]; > +int status; > +u16 rab; > + > +memcpy(buf1, (u8 *)(uc->ppm.dat

Re: [PATCH v10 2/2] usb: typec: ucsi: add support for Cypress CCGx

2018-09-10 Thread Peter Rosin
On 2018-09-11 06:30, Ajay Gupta wrote: > Hi Peter, > >> +static int ucsi_ccg_send_data(struct ucsi_ccg *uc) { >> +unsigned char buf1[USBC_MSG_OUT_SIZE]; >> +unsigned char buf2[USBC_CONTROL_SIZE]; >> +int status; >> +u16 rab; >> +

Re: [PATCH v2] usb: typec: get the vbus source and charge values from the devicetree

2018-09-10 Thread Heikki Krogerus
On Sun, Sep 09, 2018 at 12:05:31PM -0600, Angus Ainslie (Purism) wrote: > If the board is being powered by USB disabling the source and sink > can remove power from the board. Allow the source and sink to be > initallized based on devicetree values. > > Changed since V1: > > use devicetree values

[PATCH 2/3] media: tm6000: use irqsave() in USB's complete callback

2018-09-10 Thread Sebastian Andrzej Siewior
The USB completion callback does not disable interrupts while acquiring the lock. We want to remove the local_irq_disable() invocation from __usb_hcd_giveback_urb() and therefore it is required for the callback handler to disable the interrupts while acquiring the lock. The callback may be invoked

[PATCH 0/3] media: use irqsave() in USB's complete callback + remove local_irq_save

2018-09-10 Thread Sebastian Andrzej Siewior
I've been looking at my queue and compared to v4.19-rc3. As it turns out, everything was merged except for media: em28xx-audio: use irqsave() in USB's complete media: tm6000: use irqsave() in USB's complete callback I haven't seen any reply to those two patches (like asking for ch

[PATCH 1/3] media: em28xx-audio: use irqsave() in USB's complete callback

2018-09-10 Thread Sebastian Andrzej Siewior
The USB completion callback does not disable interrupts while acquiring the lock. We want to remove the local_irq_disable() invocation from __usb_hcd_giveback_urb() and therefore it is required for the callback handler to disable the interrupts while acquiring the lock. The callback may be invoked

[PATCH 3/3] usb: core: remove local_irq_save() around ->complete() handler

2018-09-10 Thread Sebastian Andrzej Siewior
The core disabled interrupts before invocation the ->complete handler because the handler might have expected that interrupts are disabled. All handlers were audited and use proper locking now. With it, the core code no longer needs to disable interrupts before invoking the ->complete handler. Rem

Re: [PATCH 0/3] media: use irqsave() in USB's complete callback + remove local_irq_save

2018-09-10 Thread Mauro Carvalho Chehab
Em Mon, 10 Sep 2018 11:19:57 +0200 Sebastian Andrzej Siewior escreveu: > I've been looking at my queue and compared to v4.19-rc3. As it turns > out, everything was merged except for > > media: em28xx-audio: use irqsave() in USB's complete > media: tm6000: use irqsave() in USB's compl

Re: [PATCH 0/3] media: use irqsave() in USB's complete callback + remove local_irq_save

2018-09-10 Thread Sebastian Andrzej Siewior
On 2018-09-10 06:25:57 [-0300], Mauro Carvalho Chehab wrote: > Em Mon, 10 Sep 2018 11:19:57 +0200 > Sebastian Andrzej Siewior escreveu: > > > I've been looking at my queue and compared to v4.19-rc3. As it turns > > out, everything was merged except for > > > > media: em28xx-audio: use irqsav

[PATCH v4 0/3] usb: renesas_usbhs: add reset_control and multiple clocks management

2018-09-10 Thread Yoshihiro Shimoda
This patch set is based on Felipe's usb.git / testing/next branch (the commit id is 5b394b2ddf0347bef56e50c69a58773c94343ff3) with the following patch: https://patchwork.kernel.org/patch/10574875/ Changes from v3: - Change the dt-bindings not to use clock-names in patch 2. - To achieve backwar

[PATCH v4 3/3] usb: renesas_usbhs: Add multiple clocks management

2018-09-10 Thread Yoshihiro Shimoda
R-Car Gen3 needs to enable clocks of both host and peripheral. Since [eo]hci-platform disables the reset(s) when the drivers are removed, renesas_usbhs driver doesn't work correctly. To fix this issue, this patch adds multiple clocks management on this renesas_usbhs driver. Signed-off-by: Yoshihir

[PATCH v4 1/3] usb: renesas_usbhs: Add reset_control

2018-09-10 Thread Yoshihiro Shimoda
R-Car Gen3 needs to deassert resets of both host and peripheral. Since [eo]hci-platform is possible to assert the reset(s) when the probing failed, renesas_usbhs driver doesn't work correctly regardless of finished probing. To fix this issue, this patch adds reset_control on this renesas_usbhs driv

[PATCH v4 2/3] dt-bindings: usb: renesas_usbhs: add clock-names property

2018-09-10 Thread Yoshihiro Shimoda
R-Car Gen3 needs to enable clocks of both host and peripheral. Otherwise, other side device cannot work correctly. So, this patch adds a property of clock-names for R-Car Gen3 as an optional. Signed-off-by: Yoshihiro Shimoda --- Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 4 +++- 1

Re: [PATCH 0/4] usb: dwc2: fix host mode external vbus supply management

2018-09-10 Thread Artur Petrosyan
Hi, On 9/5/2018 15:41, Amelie Delaunay wrote: > This patchset fixes and improves host mode external vbus supply management, > mainly around suspend/resume use cases. It also avoid 'vbus regulator" > to be requested lots of times upon each call to dwc2_vbus_supply_init(), > especially when pm runti

Re: [PATCH] option: Improve Quectel EP06 detection

2018-09-10 Thread Johan Hovold
On Sat, Sep 08, 2018 at 02:57:54PM +0200, Kristian Evensen wrote: > The Quectel EP06 (and EM06/EG06) LTE modem supports updating the USB > configuration, without the VID/PID or configuration number changing. > When the configuration is updated and interfaces are added/removed, the > interface numbe

[PATCH 2/2] dt-bindings: usb: ohci: Add clocks description for R-Car Gen3

2018-09-10 Thread Yoshihiro Shimoda
This patch adds detailed information of an optional property "clocks" description for R-Car Gen3. Signed-off-by: Yoshihiro Shimoda --- Documentation/devicetree/bindings/usb/usb-ohci.txt | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/usb

[PATCH 1/2] dt-bindings: usb: ehci: Add clocks description for R-Car Gen3

2018-09-10 Thread Yoshihiro Shimoda
This patch adds detailed information of an optional property "clocks" description for R-Car Gen3. Signed-off-by: Yoshihiro Shimoda --- Documentation/devicetree/bindings/usb/usb-ehci.txt | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/usb

[PATCH 0/2] dt-bindings: usb: [eo]hci: Add clocks description for R-Car Gen3

2018-09-10 Thread Yoshihiro Shimoda
This patch is based on the latest Greg's usb.git / usb-next branch (the commit id = 57361846b52bc686112da6ca5368d11210796804). Since the current dt-bindings document is unclear about usb-[eo]hci.txt for R-Car Gen3 SoCs clocks descriptions, this patch adds detailed information for the SoCs. Yoshih

Re: [PATCH] option: Improve Quectel EP06 detection

2018-09-10 Thread Kristian Evensen
Hi, On Mon, Sep 10, 2018 at 12:30 PM Johan Hovold wrote: > Please provide the output of usb-devices (or lsusb -v) for both > "configurations". How do you update the configuration by the way? The configuration is updated using a proprietary AT-command (AT+QCFG="usbcfg"). The format of the command

[PATCH 1/3] dt-bindings: connector: Add support for USB-PD PPS APDOs to bindings

2018-09-10 Thread Adam Thomson
Add support for PPS APDOs to connector bindings so a port controller can specify support for PPS, as per existing FIXED/BATT/VAR PDOs. Signed-off-by: Adam Thomson Reviewed-by: Rob Herring --- .../bindings/connector/usb-connector.txt | 8 +++ include/dt-bindings/usb/pd.h

[PATCH 3/3] usb: typec: fusb302: Populate tcpc fwnode for TCPM property handling

2018-09-10 Thread Adam Thomson
This update populates the tcpc handle's fwnode pointer with the child usb-connector node, if it exists, so that TCPM can perform generic property handling to define the ports capabilities. Signed-off-by: Adam Thomson Reviewed-by: Heikki Krogerus Reviewed-by: Guenter Roeck --- drivers/usb/typec

[PATCH 2/3] dt-bindings: usb: fusb302: Use usb-connector bindings for configuration

2018-09-10 Thread Adam Thomson
There are now generic usb-connector bindings which can be used to define a port controllers configuration for USB-PD, so device specific bindings are no longer necessary. This update deprecates 'fcs,operating-sink-microwatt', and references the 'usb-connector' bindings instead to achieve the requi

[PATCH 0/3] *** SUBJECT HERE ***

2018-09-10 Thread Adam Thomson
This patch set adds DT bindings support for PPS APDOs, and updates the FUSB302 to use the generic connector bindings allowing for PPS support in this Type-C port controller. Existing FUSB302 device specific bindings still work, but are now deprecated in favour of the generic connector approach. Ch

RE: [PATCH 0/3] *** SUBJECT HERE ***

2018-09-10 Thread Adam Thomson
On 10 September 2018 13:19, Adam Thomson wrote: > This patch set adds DT bindings support for PPS APDOs, and updates the FUSB302 > to use the generic connector bindings allowing for PPS support in this Type-C > port controller. Existing FUSB302 device specific bindings still work, but > are now de

Re: [PATCH v2] usb: typec: get the vbus source and charge values from the devicetree

2018-09-10 Thread Angus Ainslie
Hi Heikki On 2018-09-10 01:35, Heikki Krogerus wrote: On Sun, Sep 09, 2018 at 12:05:31PM -0600, Angus Ainslie (Purism) wrote: If the board is being powered by USB disabling the source and sink can remove power from the board. Allow the source and sink to be initallized based on devicetree value

Re: [PATCH 0/3] media: use irqsave() in USB's complete callback + remove local_irq_save

2018-09-10 Thread Greg Kroah-Hartman
On Mon, Sep 10, 2018 at 11:30:30AM +0200, Sebastian Andrzej Siewior wrote: > On 2018-09-10 06:25:57 [-0300], Mauro Carvalho Chehab wrote: > > Em Mon, 10 Sep 2018 11:19:57 +0200 > > Sebastian Andrzej Siewior escreveu: > > > > > I've been looking at my queue and compared to v4.19-rc3. As it turns >

Re: [PATCH v2] usb: typec: get the vbus source and charge values from the devicetree

2018-09-10 Thread Guenter Roeck
On 09/10/2018 06:11 AM, Angus Ainslie wrote: Hi Heikki On 2018-09-10 01:35, Heikki Krogerus wrote: On Sun, Sep 09, 2018 at 12:05:31PM -0600, Angus Ainslie (Purism) wrote: If the board is being powered by USB disabling the source and sink can remove power from the board. Allow the source and si

Re: [PATCH v2] usb: typec: get the vbus source and charge values from the devicetree

2018-09-10 Thread Heikki Krogerus
Hi Angus, On Mon, Sep 10, 2018 at 07:11:43AM -0600, Angus Ainslie wrote: > They are tcpm specific but need to go into the connector sub-node to get > parsed correctly. Would something like below be better ? > > diff --git a/Documentation/devicetree/bindings/usb/typec-tcpci.txt > b/Documentation/d

Re: [PATCH 3/3] usb: core: remove local_irq_save() around ->complete() handler

2018-09-10 Thread Alan Stern
On Mon, 10 Sep 2018, Sebastian Andrzej Siewior wrote: > The core disabled interrupts before invocation the ->complete handler > because the handler might have expected that interrupts are disabled. > > All handlers were audited and use proper locking now. With it, the core > code no longer needs

Re: [PATCH v2] usb: typec: get the vbus source and charge values from the devicetree

2018-09-10 Thread Angus Ainslie
On 2018-09-10 07:43, Guenter Roeck wrote: On 09/10/2018 06:11 AM, Angus Ainslie wrote: Hi Heikki On 2018-09-10 01:35, Heikki Krogerus wrote: On Sun, Sep 09, 2018 at 12:05:31PM -0600, Angus Ainslie (Purism) wrote: If the board is being powered by USB disabling the source and sink can remove po

Re: [PATCH] option: Improve Quectel EP06 detection

2018-09-10 Thread Dan Williams
On Sat, 2018-09-08 at 14:57 +0200, Kristian Evensen wrote: > The Quectel EP06 (and EM06/EG06) LTE modem supports updating the USB > configuration, without the VID/PID or configuration number changing. > When the configuration is updated and interfaces are added/removed, > the > interface numbers ar

Re: [PATCH 0/3] media: use irqsave() in USB's complete callback + remove local_irq_save

2018-09-10 Thread Mauro Carvalho Chehab
Em Mon, 10 Sep 2018 15:37:58 +0200 Greg Kroah-Hartman escreveu: > On Mon, Sep 10, 2018 at 11:30:30AM +0200, Sebastian Andrzej Siewior wrote: > > On 2018-09-10 06:25:57 [-0300], Mauro Carvalho Chehab wrote: > > > Em Mon, 10 Sep 2018 11:19:57 +0200 > > > Sebastian Andrzej Siewior escreveu: > > >

[PATCH v3] USB: serial: ftdi_sio: implement GPIO support for FT-X devices

2018-09-10 Thread Karoly Pados
This patch allows using the CBUS pins of FT-X devices as GPIO in CBUS bitbanging mode. There is no conflict between the GPIO and VCP functionality in this mode. Tested on FT230X and FT231X. As there is no way to request the current CBUS register configuration from the device, all CBUS pins are set

Re: [PATCH 00/31] Introduced new Cadence USBSSP DRD Driver

2018-09-10 Thread Greg Kroah-Hartman
On Thu, Jul 19, 2018 at 06:57:33PM +0100, Pawel Laszczak wrote: > This patch set introduce new Cadence USBSSP DRD driver > to linux kernel. Is this the v2 submission? If so, please always say so and properly document somewhere what changed from v1 to this one. thanks, greg k-h

Re: [PATCH 02/31] usb: usbssp: Added some decoding functions.

2018-09-10 Thread Greg Kroah-Hartman
On Thu, Jul 19, 2018 at 06:57:35PM +0100, Pawel Laszczak wrote: > This patch add additional functions that converts some fields to string. > > For example function usbssp_trb_comp_code_string take completion > code value and return string describing completion code. > > Signed-off-by: Pawel Laszc

Re: [PATCH 00/31] Introduced new Cadence USBSSP DRD Driver

2018-09-10 Thread Greg Kroah-Hartman
On Tue, Aug 21, 2018 at 02:50:19PM +, Pawel Laszczak wrote: > Hi, > > USBSSP it's the project name and it was the reason for such prefix. > > I agree with you that the shorter prefix could be better and we could get rid > of some warnings reported by checkpatch. Currently we have more import

Re: [PATCH 00/31] Introduced new Cadence USBSSP DRD Driver

2018-09-10 Thread Greg Kroah-Hartman
On Thu, Aug 02, 2018 at 04:26:45AM +, Pawel Laszczak wrote: > > > This patch set introduce new Cadence USBSSP DRD driver to linux > > > kernel. > > > > > > The Cadence USBSSP DRD Driver s a highly configurable IP Core which > > > can be instantiated as Dual-Role Device (DRD), Peripheral Only an

Re: [PATCH v4 2/3] dt-bindings: usb: renesas_usbhs: add clock-names property

2018-09-10 Thread Rob Herring
On Mon, Sep 10, 2018 at 06:52:19PM +0900, Yoshihiro Shimoda wrote: > R-Car Gen3 needs to enable clocks of both host and peripheral. > Otherwise, other side device cannot work correctly. So, this patch > adds a property of clock-names for R-Car Gen3 as an optional. > > Signed-off-by: Yoshihiro Shim

[PATCH] usb: gadget: udc: atmel: handle at91sam9rl PMC

2018-09-10 Thread Alexandre Belloni
The at91sam9rl PMC is not quite the same as the at91sam9g45 one and now has its own compatible string. Add support for that. Fixes: 217bace8e548 ("ARM: dts: fix PMC compatible") Signed-off-by: Alexandre Belloni --- drivers/usb/gadget/udc/atmel_usba_udc.c | 2 ++ 1 file changed, 2 insertions(+)

Re: [PATCH v4 6/8] usb: dwc3: check for requests in started list for stream capable endpoints

2018-09-10 Thread Thinh Nguyen
Hi Anurag, On 9/8/2018 8:03 AM, Anurag Kumar Vulisha wrote: > For stream capable endpoints, uas layer can queue mulpile requests on > single ep with different stream ids. So, there can be multiple pending > requests waiting to be transferred. This patch changes the code to check > for any pending

Re: [PATCH v4 6/8] usb: dwc3: check for requests in started list for stream capable endpoints

2018-09-10 Thread Thinh Nguyen
Hi, On 9/10/2018 1:13 PM, Thinh Nguyen wrote: > Hi Anurag, > > On 9/8/2018 8:03 AM, Anurag Kumar Vulisha wrote: >> For stream capable endpoints, uas layer can queue mulpile requests on >> single ep with different stream ids. So, there can be multiple pending >> requests waiting to be transferred.

RE: [PATCH v4 2/3] dt-bindings: usb: renesas_usbhs: add clock-names property

2018-09-10 Thread Yoshihiro Shimoda
Hi Rob, > From: Rob Herring, Sent: Tuesday, September 11, 2018 3:27 AM > > On Mon, Sep 10, 2018 at 06:52:19PM +0900, Yoshihiro Shimoda wrote: > > R-Car Gen3 needs to enable clocks of both host and peripheral. > > Otherwise, other side device cannot work correctly. So, this patch > > adds a proper

Re: [PATCH 02/31] usb: usbssp: Added some decoding functions.

2018-09-10 Thread Felipe Balbi
Hi, Greg Kroah-Hartman writes: > On Thu, Jul 19, 2018 at 06:57:35PM +0100, Pawel Laszczak wrote: >> This patch add additional functions that converts some fields to string. >> >> For example function usbssp_trb_comp_code_string take completion >> code value and return string describing complet