On Mon, Sep 03, 2018 at 09:01:47AM +0300, Andy Shevchenko wrote:
> On Fri, Aug 31, 2018 at 5:21 PM Heikki Krogerus
> wrote:
> >
> > Only create thre Intel role mux device if the platform has
> > USB peripheral controller PCI device.
> >
> > While here, enable the role mux on Apollo Lake platforms.
On Mon, Sep 03, 2018 at 09:17:13AM +0300, Andy Shevchenko wrote:
> On Fri, Aug 31, 2018 at 5:21 PM Heikki Krogerus
> wrote:
> >
> > Hi,
> >
> > The second last patch in this series will make it possible to use
> > multiport USB Type-C and PD controllers with the muxes. The CHT
> > connections are
Hi,
On 31-08-18 16:20, Heikki Krogerus wrote:
Only create thre Intel role mux device if the platform has
USB peripheral controller PCI device.
While here, enable the role mux on Apollo Lake platforms.
Signed-off-by: Heikki Krogerus
Cc: Mathias Nyman
---
drivers/usb/host/xhci-pci.c | 20 +++
Hi,
On 31-08-18 16:20, Heikki Krogerus wrote:
Hi,
The second last patch in this series will make it possible to use
multiport USB Type-C and PD controllers with the muxes. The CHT
connections are simply adapted to that. The rest of the series will
mainly allow us to use the USB Type-C on CHT bo
On 8/29/2018 8:58 PM, Grigor Tovmasyan wrote:
> This patch set adds Service Interval support for device mode.
>
> When this mode is enabled core is able to send data any u(f) in current
> service interval.
>
> Also in this mode core is able to accept L1 tokens for ISOC IN endpoints.
>
> Referen
On Mon, Sep 03, 2018 at 10:01:01AM +0200, Hans de Goede wrote:
> This patch and "[PATCH 3/8] plarform: x86: intel_cht_int33fe: Use the USB
> role switch conditionally"
> both assume that the mux will be in host mode when Linux boots, so we do not
> need to
> touch it. I'm not sure that is a valid
Hi,
On Mon, Sep 03, 2018 at 10:01:52AM +0200, Hans de Goede wrote:
> Besides my comments on patches 3 and 4, one small nitpick,
> platform is spelled wrong (as plarform) in the subject of
> a number of the patches.
Thanks Hans. I'll fix them.
Cheers,
--
heikki
On Mon, Sep 3, 2018 at 10:19 AM Heikki Krogerus
wrote:
>
> On Mon, Sep 03, 2018 at 09:17:13AM +0300, Andy Shevchenko wrote:
> > On Fri, Aug 31, 2018 at 5:21 PM Heikki Krogerus
> > wrote:
> > >
> > > Hi,
> > >
> > > The second last patch in this series will make it possible to use
> > > multiport
On 31.08.2018 17:39, Alan Stern wrote:
On Fri, 31 Aug 2018, Mathias Nyman wrote:
The steps taken by usb core to set a new interface is very different from
what is done on the xHC host side.
xHC hardware will do everything in one go. One command is used to set up
new endpoints, free old endpoin
On Mon, Sep 03, 2018 at 09:39:14AM +0300, Ranran wrote:
> Hello,
>
> I try to add gadget configfs as described in:
> https://www.kernel.org/doc/Documentation/usb/gadget_configfs.txt
> Yet, I find nothing in /sys/class/udc:
>
> user@user-VirtualBox:~/tegra$ ls /sys/class/udc/ -al
> total 0
> drwxr
The steps taken by usb core to set a new interface is very different from
what is done on the xHC host side.
xHC hardware will do everything in one go. One command is used to set up
new endpoints, free old endpoints, check bandwidth, and run the new
endpoints.
All this is done by xHC when usb cor
On Mon, Sep 03, 2018 at 03:08:46PM +0300, Andy Shevchenko wrote:
> On Mon, Sep 3, 2018 at 10:19 AM Heikki Krogerus
> wrote:
> >
> > On Mon, Sep 03, 2018 at 09:17:13AM +0300, Andy Shevchenko wrote:
> > > On Fri, Aug 31, 2018 at 5:21 PM Heikki Krogerus
> > > wrote:
> > > >
> > > > Hi,
> > > >
> > >
On Mon, Sep 3, 2018 at 3:40 PM Greg KH wrote:
>
> On Mon, Sep 03, 2018 at 09:39:14AM +0300, Ranran wrote:
> > Hello,
> >
> > I try to add gadget configfs as described in:
> > https://www.kernel.org/doc/Documentation/usb/gadget_configfs.txt
> > Yet, I find nothing in /sys/class/udc:
> >
> > user@us
PI3USB30532 is used for muxing the port to DisplayPort on
CHT platforms, so changing the connection ID so that the
mux will get assigned to the alternate mode device and not
the port device. Connection ID "typec-mux" is now reserved
for Accessory Modes.
Signed-off-by: Heikki Krogerus
---
drivers
The debugfs needs to be initialized as the last step in
probe in this case. The struct dentry *rootdir can't be
pointing to anything unless driver probe really finishes
successfully.
It is also not necessary to clear the i2c clientdata if the
probe fails, so removing the extra label used for that.
Assigning the mux to the USB Type-C port on top of fusb302.
That will prepare this driver for the change in the USB
Type-C class code, where the class driver will assume the
muxes to be always assigned to the ports and not the
controllers.
Once the USB Type-C class driver has been updated, the
con
It is not possible to use the parent of the port device when
requesting mux handles as the parent may be a multiport USB
Type-C or PD controller. The muxes must be assigned to the
ports, not the controllers.
This will also move the requesting of the muxes after the
port device is initialized.
Sig
Functions typec_mux_get() and typec_switch_get() already
make sure that the mux device reference count is
incremented, but the same must be done to the driver module
as well to prevent the drivers from being unloaded in the
middle of operation.
This fixes a potential "BUG: unable to handle kernel
Hi,
I've now removed the conditional creation of the mux device, and the
connection for it that was checked in intel_cht_int33fe.c. I'm instead
making the intel_cht_int33fe driver depend on the mux drivers. I also
added a trivial cleanup patch (patch 10/10) for the fusb302.c to this
series, and al
Introducing helpers for adding and removing multiple device
connection descriptions at once.
Signed-off-by: Heikki Krogerus
---
include/linux/device.h | 24
1 file changed, 24 insertions(+)
diff --git a/include/linux/device.h b/include/linux/device.h
index 8f882549edee.
This fixes potential "BUG: unable to handle kernel paging
request at ..." from happening.
Fixes: fde0aa6c175a ("usb: common: Small class for USB role switches")
Cc:
Signed-off-by: Heikki Krogerus
---
drivers/usb/common/roles.c | 15 ---
1 file changed, 12 insertions(+), 3 deletions(
The connections create clear dependency on the muxes.
fusb302 fails to probe unless we have the mux drivers
available.
Signed-off-by: Heikki Krogerus
---
drivers/platform/x86/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
USB Type-C class driver now expects the muxes to be always
assigned to the ports and not controllers, so the
connections for the mux and fusb302 can be removed.
Signed-off-by: Heikki Krogerus
---
drivers/platform/x86/intel_cht_int33fe.c | 11 ++-
1 file changed, 2 insertions(+), 9 deleti
We can register all device connection descriptors with a
single call to device_connections_add().
Signed-off-by: Heikki Krogerus
---
drivers/platform/x86/intel_cht_int33fe.c | 14 --
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/drivers/platform/x86/intel_cht_int33fe
On Mon, Sep 3, 2018 at 4:22 PM Ranran wrote:
>
> On Mon, Sep 3, 2018 at 3:40 PM Greg KH wrote:
> >
> > On Mon, Sep 03, 2018 at 09:39:14AM +0300, Ranran wrote:
> > > Hello,
> > >
> > > I try to add gadget configfs as described in:
> > > https://www.kernel.org/doc/Documentation/usb/gadget_configfs.
On Mon, Sep 3, 2018 at 4:37 PM Heikki Krogerus
wrote:
>
> Hi,
>
> I've now removed the conditional creation of the mux device, and the
> connection for it that was checked in intel_cht_int33fe.c. I'm instead
> making the intel_cht_int33fe driver depend on the mux drivers. I also
> added a trivial
On Mon, Sep 3, 2018 at 4:50 PM Ranran wrote:
>
> On Mon, Sep 3, 2018 at 4:22 PM Ranran wrote:
> >
> > On Mon, Sep 3, 2018 at 3:40 PM Greg KH wrote:
> > >
> > > On Mon, Sep 03, 2018 at 09:39:14AM +0300, Ranran wrote:
> > > > Hello,
> > > >
> > > > I try to add gadget configfs as described in:
> >
Hi,
On 03-09-18 15:36, Heikki Krogerus wrote:
PI3USB30532 is used for muxing the port to DisplayPort on
CHT platforms, so changing the connection ID so that the
mux will get assigned to the alternate mode device and not
the port device. Connection ID "typec-mux" is now reserved
for Accessory Mod
Hi,
i have problems with usb-keyboard on bananapi-r2 since 4.17. same keyboard
works till 4.16.
In 4.19-rc1 same issue occours. Keyboard is recognized and on keypress it is
disconnected
and connected again without anything written to console.
dmesg (printk-debuglevel=8) looks like this:
Hi Jaejoong.
> Change return type for tty functions. Patch No.01
> tty: Change return type to void
Adding this patch first will generate a lot of warnings
until all users are updated.
It is usual practice to prepare all users
and then apply the infrastructure changes as the
last patch.
Then peop
On Tue, Sep 04, 2018 at 06:39:20AM +0200, Frank Wunderlich wrote:
>
>
>
> Hi,
>
> i have problems with usb-keyboard on bananapi-r2 since 4.17. same keyboard
> works till 4.16.
> In 4.19-rc1 same issue occours. Keyboard is recognized and on keypress it is
> disconnected
> and connected again
On Sun, Sep 02, 2018 at 07:30:48PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap
>
> Fix kernel-doc warning (13 times):
>
> ../drivers/usb/typec/class.c:1497: warning: Excess function parameter
> 'drvdata' description in 'typec_port_register_altmode'
>
> Signed-off-by: Randy Dunlap
Acked-b
On 8/28/2018 1:37 AM, Bruno Meirelles Herrera wrote:
> Some SoC/IP as STM32F469, the snpsid can only be read after clock is
> enabled, otherwise it will read as 0, and the dwc2_check_core_endianness
> will assume the core and AHB have opposite endianness, leading to the
> following error:
>
> [
Hello,
syzbot found the following crash on:
HEAD commit:420f51f4ab6b Merge tag 'arm64-fixes' of git://git.kernel.o..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=160cf55a40
kernel config: https://syzkaller.appspot.com/x/.config?x=531a917630d2a492
da
From: Thierry Reding
The XUSB firmware header is in little endian byte order, so make the
fields __le32 and __le16 instead of u32 and u16 to avoid warnings from
sparse when the fields are used with the endian-aware __le32_to_cpu()
and __le16_to_cpu() accessors, respectively.
Signed-off-by: Thier
On Mon, Sep 03, 2018 at 04:14:41AM +, Peter Chen wrote:
>
> >
> > The SPDX-License-Identifier is set to GPL-2.0+, which correspond to
> > MODULE_LICENSE "GPL".
> >
> > Signed-off-by: Marcus Folkesson
> > ---
> > drivers/usb/chipidea/ci_hdrc_imx.c | 2 +-
> > drivers/usb/chipidea/usbmisc_
On 03.09.2018 13:18, Thierry Reding wrote:
From: Thierry Reding
The XUSB firmware header is in little endian byte order, so make the
fields __le32 and __le16 instead of u32 and u16 to avoid warnings from
sparse when the fields are used with the endian-aware __le32_to_cpu()
and __le16_to_cpu() a
Hi,
On Mon, Sep 03, 2018 at 02:36:11PM +0200, Greg Kroah-Hartman wrote:
> On Mon, Sep 03, 2018 at 04:14:41AM +, Peter Chen wrote:
> >
> > >
> > > The SPDX-License-Identifier is set to GPL-2.0+, which correspond to
> > > MODULE_LICENSE "GPL".
> > >
> > > Signed-off-by: Marcus Folkesson
> >
3.18-stable review patch. If anyone has any objections, please let me know.
--
From: Randy Dunlap
[ Upstream commit a39ba90a1cc7010edb0a7132e1b67f3d80b994e9 ]
Fix build errors when built for PPC64:
These variables are only used on PPC32 so they don't need to be
initialized for
4.4-stable review patch. If anyone has any objections, please let me know.
--
From: Randy Dunlap
[ Upstream commit a39ba90a1cc7010edb0a7132e1b67f3d80b994e9 ]
Fix build errors when built for PPC64:
These variables are only used on PPC32 so they don't need to be
initialized for
4.9-stable review patch. If anyone has any objections, please let me know.
--
From: Randy Dunlap
[ Upstream commit a39ba90a1cc7010edb0a7132e1b67f3d80b994e9 ]
Fix build errors when built for PPC64:
These variables are only used on PPC32 so they don't need to be
initialized for
This patch makes some declaration more consistent.
Signed-off-by: Stefan Wahren
---
drivers/net/usb/lan78xx.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c
index a6e88a4..143091a 100644
--- a/drivers/net/u
There is no need for this strcpy because alloc_etherdev() already
does this job.
Signed-off-by: Stefan Wahren
---
drivers/net/usb/lan78xx.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c
index 3f70b94..3d505c2 100644
--- a/drivers/net/usb
Adopt the SPDX license identifier headers to ease license compliance
management.
Signed-off-by: Stefan Wahren
---
drivers/net/usb/lan78xx.c | 18 ++
drivers/net/usb/lan78xx.h | 18 ++
2 files changed, 4 insertions(+), 32 deletions(-)
diff --git a/drivers/net/usb/
We need to bail out if lan78xx_get_endpoints() fails, otherwise the
result is overwritten.
Fixes: 55d7de9de6c3 ("Microchip's LAN7800 family USB 2/3 to 10/100/1000
Ethernet")
Signed-off-by: Stefan Wahren
---
drivers/net/usb/lan78xx.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drive
This patch series contains some minor improvements for the lan78xx
driver.
Stefan Wahren (4):
net: lan78xx: Bail out if lan78xx_get_endpoints fails
net: lan78xx: Drop unnecessary strcpy in lan78xx_probe
net: lan78xx: Switch to SPDX identifier
net: lan78xx: Make declaration style consistent
4.14-stable review patch. If anyone has any objections, please let me know.
--
From: Randy Dunlap
[ Upstream commit a39ba90a1cc7010edb0a7132e1b67f3d80b994e9 ]
Fix build errors when built for PPC64:
These variables are only used on PPC32 so they don't need to be
initialized for
Hello,
syzbot found the following crash on:
HEAD commit:58c3f14f86c9 Merge tag 'riscv-for-linus-4.19-rc2' of git:/..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=1046f0ea40
kernel config: https://syzkaller.appspot.com/x/.config?x=531a917630d2a492
da
Hello,
syzbot found the following crash on:
HEAD commit:3d18c2437944 Add linux-next specific files for 20180830
git tree: linux-next
console output: https://syzkaller.appspot.com/x/log.txt?x=156078ea40
kernel config: https://syzkaller.appspot.com/x/.config?x=a059d319ef7d83f6
dashb
Hello,
syzbot found the following crash on:
HEAD commit:58c3f14f86c9 Merge tag 'riscv-for-linus-4.19-rc2' of git:/..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=175be2b640
kernel config: https://syzkaller.appspot.com/x/.config?x=531a917630d2a492
da
On Fri, Aug 31, 2018 at 12:02 PM Chunfeng Yun wrote:
>
> Use IS_ERR() instead of IS_ERR_OR_NULL() because devm_of_phy_get_by_index()
> never return NULL value;
> But still need ignore the error of -ENODEV, for more information, please
> refer to:
> [0] https://lkml.org/lkml/2018/4/19/88
> [1] http
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Addresses-Coverity-ID: 1077614 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva
---
drivers/net/usb/usbnet.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/
From: Randy Dunlap
Fix kernel-doc warning for missing struct member description:
../include/linux/mod_devicetable.h:763: warning: Function parameter or member
'driver_data' not described in 'typec_device_id'
Fixes: 8a37d87d72f0c ("usb: typec: Bus type for alternate modes")
Signed-off-by: Rand
From: Randy Dunlap
Fix kernel-doc warning for missing function parameter 'mode' description:
../drivers/usb/typec/bus.c:268: warning: Function parameter or member 'mode'
not described in 'typec_match_altmode'
Also fix typos for same function documentation.
Fixes: 8a37d87d72f0 ("usb: typec: Bu
Hello,
syzbot found the following crash on:
HEAD commit:58c3f14f86c9 Merge tag 'riscv-for-linus-4.19-rc2' of git:/..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=12fc6f0e40
kernel config: https://syzkaller.appspot.com/x/.config?x=531a917630d2a492
da
Many drivers with tty use the tty_stand_install(). But, there is no
need to handle the error, since it always returns 0. So, change the
return type of tty_standard_install() and tty_port_install() to void
type and remove unnecessary exception handling where we use these
functions.
Signed-off-by: J
Since tty_port_install() always returns 0, the return type has changed
to void. Now apply this and remove the obsolete error check.
Signed-off-by: Jaejoong Kim
---
drivers/isdn/i4l/isdn_tty.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/isdn/i4l/isdn_tty.c b/driv
Since tty_port_install() always returns 0, the return type has changed
to void. Now apply this and remove the obsolete error check.
Signed-off-by: Jaejoong Kim
---
drivers/tty/hvc/hvcs.c | 10 ++
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/tty/hvc/hvcs.c b/drive
Since tty_standard_install() always returns 0, the return type has changed
to void. Now apply this and remove the obsolete error check.
Signed-off-by: Jaejoong Kim
---
drivers/isdn/capi/capi.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/isdn/capi/capi.c
Since tty_standard_install() always returns 0, the return type has changed
to void. Now apply this and remove the obsolete error check.
Signed-off-by: Jaejoong Kim
---
arch/um/drivers/line.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/arch/um/drivers/line.c b/arch/u
Since tty_port_install() always returns 0, the return type has changed
to void. Now apply this and remove the obsolete error check.
Signed-off-by: Jaejoong Kim
---
drivers/tty/synclink.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/tty/synclink.c b/drivers/tty/sy
Since tty_standard_install() always returns 0, the return type has changed
to void. Now apply this and remove the obsolete error check.
Signed-off-by: Jaejoong Kim
---
drivers/usb/serial/usb-serial.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/usb/serial/usb-
Since tty_standard_install() always returns 0, the return type has changed
to void. Now apply this and remove the obsolete error check.
Signed-off-by: Jaejoong Kim
---
drivers/usb/class/cdc-acm.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/usb/class/cdc-
Since tty_standard_install() always returns 0, the return type has changed
to void. Now apply this and remove the obsolete error check.
Signed-off-by: Jaejoong Kim
---
drivers/tty/vcc.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/tty/vcc.c b/drivers/tty/vcc.c
Since tty_standard_install() always returns 0, the return type has changed
to void. Now apply this and remove the obsolete error check.
Signed-off-by: Jaejoong Kim
---
drivers/staging/greybus/uart.c | 10 ++
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/gr
Since tty_standard_install() always returns 0, the return type has changed
to void. Now apply this and remove the obsolete error check.
Signed-off-by: Jaejoong Kim
---
drivers/misc/pti.c | 28 +---
1 file changed, 13 insertions(+), 15 deletions(-)
diff --git a/drivers/mi
Since tty_standard_install() always returns 0, the return type has changed
to void. Now apply this and remove the obsolete error check.
Signed-off-by: Jaejoong Kim
---
drivers/mmc/core/sdio_uart.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/mmc/core/sd
Since tty_standard_install() always returns 0, the return type has changed
to void. Now apply this and remove the obsolete error check.
Signed-off-by: Jaejoong Kim
---
drivers/tty/nozomi.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/tty/nozomi.c b/drivers/
Since tty_standard_install() always returns 0, the return type has changed
to void. Now apply this and remove the obsolete error check.
Signed-off-by: Jaejoong Kim
---
drivers/staging/fwserial/fwserial.c | 22 --
1 file changed, 8 insertions(+), 14 deletions(-)
diff --git a/
Since tty_standard_install() always returns 0, the return type has changed
to void. Now apply this and remove the obsolete error check.
Signed-off-by: Jaejoong Kim
---
drivers/staging/gdm724x/gdm_tty.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/stagin
Since tty_port_install() always returns 0, the return type has changed
to void. Now apply this and remove the obsolete error check.
Signed-off-by: Jaejoong Kim
---
drivers/usb/host/xhci-dbgtty.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/host/xhci-dbgtty.c
Since tty_port_install() always returns 0, the return type has changed
to void. Now apply this and remove the obsolete error check.
Signed-off-by: Jaejoong Kim
---
drivers/tty/vt/vt.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.
Since tty_port_install() always returns 0, the return type has changed
to void. Now apply this and remove the obsolete error check.
Signed-off-by: Jaejoong Kim
---
net/bluetooth/rfcomm/tty.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/net/bluetooth/rfcomm/tty.c b/ne
Since tty_port_install() always returns 0, the return type has changed
to void. Now apply this and remove the obsolete error check.
Signed-off-by: Jaejoong Kim
---
drivers/tty/serial/kgdb_nmi.c | 11 +--
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/tty/serial/kgd
Since tty_port_install() always returns 0, the return type has changed
to void. Now apply this and remove the obsolete error check.
Signed-off-by: Jaejoong Kim
---
drivers/tty/n_gsm.c | 9 +
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_
Since tty_port_install() always returns 0, the return type has changed
to void. Now apply this and remove the obsolete error check.
Signed-off-by: Jaejoong Kim
---
drivers/s390/char/tty3270.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/s390/char/tty3270.c b/
Since tty_port_install() always returns 0, the return type has changed
to void. Now apply this and remove the obsolete error check.
Signed-off-by: Jaejoong Kim
---
drivers/tty/synclinkmp.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/tty/synclinkmp.c b/drivers/tt
Since tty_port_install() always returns 0, the return type has changed
to void. Now apply this and remove the obsolete error check.
Signed-off-by: Jaejoong Kim
---
drivers/tty/mips_ejtag_fdc.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/tty/mips_ejtag_fdc.c b/d
Since tty_port_install() always returns 0, the return type has changed
to void. Now apply this and remove the obsolete error check.
Signed-off-by: Jaejoong Kim
---
drivers/s390/char/con3215.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/s390/char/con3215.c b/driv
Since tty_port_install() always returns 0, the return type has changed
to void. Now apply this and remove the obsolete error check.
Signed-off-by: Jaejoong Kim
---
drivers/tty/hvc/hvc_console.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/tty/hvc/hvc_console
Many drivers with tty use the tty_stand_install(). But, there is no
need to handle the error, since it always returns 0. So, change the
return type of tty_standard_install() and tty_port_install() to void
type and remove unnecessary exception handling where we use these
functions.
Change return ty
> We need to bail out if lan78xx_get_endpoints() fails, otherwise the result is
> overwritten.
>
> Fixes: 55d7de9de6c3 ("Microchip's LAN7800 family USB 2/3 to 10/100/1000
> Ethernet")
> Signed-off-by: Stefan Wahren
Reviewed-by: Raghuram Chary Jallipalli
Thanks,
-Raghu
> There is no need for this strcpy because alloc_etherdev() already does this
> job.
>
> Signed-off-by: Stefan Wahren
Reviewed-by: Raghuram Chary Jallipalli
Thanks,
-Raghu
> This patch makes some declaration more consistent.
>
> Signed-off-by: Stefan Wahren
Reviewed-by: Raghuram Chary Jallipalli
Thanks,
-Raghu
> +// SPDX-License-Identifier: GPL-2.0+
> +/* Copyright (C) 2015 Microchip Technology */
Can we merge both in single comment line?
> +/* SPDX-License-Identifier: GPL-2.0+ */
> +/* Copyright (C) 2015 Microchip Technology */
Here too.
Thanks,
-Raghu
85 matches
Mail list logo
